Backport crash fix by Huzaifa Sidhpurwala <huzaifas@redhat.com>
authorHuzaifa Sidhpurwala <huzaifas@redhat.com>
Mon, 31 Jan 2011 08:00:30 +0000 (13:30 +0530)
committerHuzaifa Sidhpurwala <huzaifas@redhat.com>
Mon, 31 Jan 2011 08:00:30 +0000 (13:30 +0530)
commit4d701fcc540c9393171a051087a3556b242a7d93
tree080014219b3f8a69fa770ddafb153b439695cad5
parenta6631ebc0dc40a62609c698250db3a4bc3c27123
Backport crash fix by Huzaifa Sidhpurwala <huzaifas@redhat.com>
Omit mac specific test cases from the commit

    2011-01-01  Abhishek Arya  <inferno@chromium.org>

            Reviewed by Darin Adler.

            Fixes before child calculation when adding anonymous childs to table parts.
            https://bugs.webkit.org/show_bug.cgi?id=50932

            Fix in r74364 was incomplete. When before child is equal to the table part(to
            which the new child is getting added), it confuses the table part to add it
            incorrectly as an after child. The patch fixes by passing the before child as
            the table part's first child.

            Tests: fast/css-generated-content/table-before-after-child-add.html
                   fast/css-generated-content/table-cell-before-after-child-add.html
                   fast/css-generated-content/table-row-before-after-child-add.html
                   fast/css-generated-content/table-row-before-after-child-add.html

            * rendering/RenderTable.cpp:
            (WebCore::RenderTable::addChild):
            * rendering/RenderTableRow.cpp:
            (WebCore::RenderTableRow::addChild):
            * rendering/RenderTableSection.cpp:
            (WebCore::RenderTableSection::addChild):
    2010-12-20  Abhishek Arya  <inferno@chromium.org>

            Reviewed by Darin Adler.

            Tests that "before" and "after" childs are added to table correctly.
            https://bugs.webkit.org/show_bug.cgi?id=50932

            * fast/css-generated-content/table-before-after-child-add.html: Added.
            * fast/css-generated-content/table-before-child-add.html: Removed.
            * fast/css-generated-content/table-cell-before-after-child-add.html: Added.
            * fast/css-generated-content/table-row-before-after-child-add.html: Added.

    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/fast/css-generated-content/table-before-after-child-add.html [new file with mode: 0644]
LayoutTests/fast/css-generated-content/table-cell-before-after-child-add.html [new file with mode: 0644]
LayoutTests/fast/css-generated-content/table-row-before-after-child-add.html [new file with mode: 0644]
WebCore/rendering/RenderTable.cpp
WebCore/rendering/RenderTableRow.cpp
WebCore/rendering/RenderTableSection.cpp