webkit:webkit.git
4 years ago[Qt] Unreviewed gardening. Added platform specific expected files after r148987. master
kadam [Thu, 25 Apr 2013 08:01:53 +0000 (08:01 +0000)]
[Qt] Unreviewed gardening. Added platform specific expected files after r148987.

* platform/qt/editing/deleting/delete-by-word-002-expected.txt: Added.
* platform/qt/editing/deleting/delete-cell-contents-expected.txt: Added.
* platform/qt/editing/execCommand/button-expected.txt: Added.
* platform/qt/editing/execCommand/createLink-expected.txt: Added.
* platform/qt/editing/execCommand/indent-pre-expected.txt: Added.
* platform/qt/editing/execCommand/unlink-expected.txt: Added.
* platform/qt/editing/input/emacs-ctrl-o-expected.png:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/inserting/insert-before-link-1-expected.txt: Added.
* platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Added.
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png:
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-2-expected.txt: Added.
* platform/qt/editing/pasteboard/merge-end-table-2-expected.txt: Added.
* platform/qt/editing/pasteboard/page-zoom-expected.txt: Added.
* platform/qt/editing/selection/extend-selection-word-expected.txt: Added.
* platform/qt/editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt: Added.
* platform/qt/editing/style/apply-through-end-of-document-expected.txt: Added.
* platform/qt/editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
* platform/qt/editing/style/remove-underline-across-paragraph-expected.txt: Added.
* platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
* platform/qt/editing/style/remove-underline-expected.txt: Added.
* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
* platform/qt/editing/style/remove-underline-in-bold-expected.txt: Added.
* platform/qt/editing/style/unbold-in-bold-expected.png:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r149032.
Ryosuke Niwa [Thu, 25 Apr 2013 07:50:58 +0000 (07:50 +0000)]
Unreviewed, rolling out r149032.
http://trac.webkit.org/changeset/149032
https://bugs.webkit.org/show_bug.cgi?id=115151

EFL WK1 API test has been broken after r149032 (Requested by
gyuyoung on #webkit).

* tests/test_ewk_setting.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBack references don't work in pattern attribute
Kent Tamura [Thu, 25 Apr 2013 06:42:03 +0000 (06:42 +0000)]
Back references don't work in pattern attribute
https://bugs.webkit.org/show_bug.cgi?id=105875

Reviewed by Geoffrey Garen.

Source/WebCore:

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

* html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch):
Don't use capturing parentheses. They affected back references in
pattern attribute values.

LayoutTests:

* fast/forms/ValidityState-patternMismatch-expected.txt:
* fast/forms/ValidityState-patternMismatch.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove checking chromium from run-webkit-tests
commit-queue [Thu, 25 Apr 2013 05:41:07 +0000 (05:41 +0000)]
Remove checking chromium from run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=115139

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPDFPlugin: Cursor should become an i-beam when over selectable text
Tim Horton [Thu, 25 Apr 2013 05:30:36 +0000 (05:30 +0000)]
PDFPlugin: Cursor should become an i-beam when over selectable text
https://bugs.webkit.org/show_bug.cgi?id=115018
<rdar://problem/12645012>

Reviewed by Alexey Proskuryakov.

* WebProcess/Plugins/PDF/PDFPlugin.h:
Add updateCursor(), the UpdateCursorMode and HitTestResult enums, and
storage for the last PDF hit test result.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::updateCursor):
Hit test the PDF. If there is a word under the cursor, use the I-beam cursor,
otherwise, use the default pointer cursor. This approximates PDFKit's behavior,
though does not match it precisely in the case of annotations.
Only send the cursor update to the UIProcess if it is a change, or if
we're explicitly asked to update.
(WebKit::PDFPlugin::handleMouseEvent):
If we're processing a mouse moved event, update the cursor if needed.
(WebKit::PDFPlugin::handleMouseEnterEvent):
If the cursor just moved over the PDFPlugin, force-update the cursor,
even if it matches the previously-set cursor (because something else
likely updated the cursor while it was not over the PDFPlugin).

* WebCore.exp.in: Export the I-beam and arrow cursors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRoll out AppleWin re-baselines from r149088.
roger_fong [Thu, 25 Apr 2013 04:56:09 +0000 (04:56 +0000)]
Roll out AppleWin re-baselines from r149088.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd watchdog timer polling for the DFG.
mark.lam [Thu, 25 Apr 2013 02:59:51 +0000 (02:59 +0000)]
Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.

Reviewed by Geoffrey Garen.

The strategy is to add a speculation check to the DFG generated code to
test if the watchdog timer has fired or not. If the watchdog timer has
fired, the generated code will do an OSR exit to the baseline JIT, and
let it handle servicing the watchdog timer.

If the watchdog is not enabled, this speculation check will not be
emitted.

* API/tests/testapi.c:
(currentCPUTime_callAsFunction):
(extendTerminateCallback):
(main):
- removed try/catch statements so that we can test the watchdog on the DFG.
- added JS bindings to a native currentCPUTime() function so that the timeout
  tests can be more accurate.
- also shortened the time values so that the tests can complete sooner.

* bytecode/ExitKind.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Watchdog.cpp:
(JSC::Watchdog::setTimeLimit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed optimize-baselines for mac and win.
roger_fong [Thu, 25 Apr 2013 02:44:19 +0000 (02:44 +0000)]
Unreviewed optimize-baselines for mac and win.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPixel tests in SVG are all broken in WK2
Simon Fraser [Thu, 25 Apr 2013 02:09:22 +0000 (02:09 +0000)]
Pixel tests in SVG are all broken in WK2
https://bugs.webkit.org/show_bug.cgi?id=114218

Reviewed by Darin Adler.

Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.

Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.

Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::setShouldPaintBrokenImage):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webInspectorShowWindow):
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
* DumpRenderTree/win/DumpRenderTree.cpp:
(sizeWebViewForCurrentTest):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPage Overlays shouldn't waste time flushing layers if we're not going to use it
Tim Horton [Thu, 25 Apr 2013 01:32:47 +0000 (01:32 +0000)]
Page Overlays shouldn't waste time flushing layers if we're not going to use it
https://bugs.webkit.org/show_bug.cgi?id=115145

Reviewed by Simon Fraser.

Don't flush the page overlay layer when it's installed - it starts out
with paintContents=false, so we don't really need a CALayer yet. We'll
flush later if need be.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGarbage at the top of http://www.technologyreview.com after scrolling
Simon Fraser [Thu, 25 Apr 2013 01:27:20 +0000 (01:27 +0000)]
Garbage at the top of technologyreview.com after scrolling
https://bugs.webkit.org/show_bug.cgi?id=114825

Source/WebCore:

Reviewed by Tim Horton.

Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
but then not painting anything into it. On this page, the element is
toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
failed to consider that as something that can cause backgrounds not to be opaque.

For the bug to happen, some subtle interactions with r142012 come into play
for the layer to remain visible, hence the slightly complex testcase.

Test: compositing/contents-opaque/visibility-hidden.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

Test that sets visibility:hidden on an element with some complex
configuration of layer children, and dumps the layer tree to check
that the contents are not marked as opaque.

* compositing/contents-opaque/visibility-hidden-expected.txt: Added.
* compositing/contents-opaque/visibility-hidden.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDump layer opaqueness in the Compositing log output
Simon Fraser [Thu, 25 Apr 2013 01:27:13 +0000 (01:27 +0000)]
Dump layer opaqueness in the Compositing log output
https://bugs.webkit.org/show_bug.cgi?id=115132

Reviewed by Tim Horton.

It's useful to see whether we consider layers to be opaque in the Compositing
log channel output, so dump it.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSpecial thunks for math functions should work on ARMv7
Filip Pizlo [Thu, 25 Apr 2013 01:26:35 +0000 (01:26 +0000)]
Special thunks for math functions should work on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=115144

Reviewed by Gavin Barraclough and Oliver Hunt.

The only hard bit here was ensuring that we implemented the very special
"cheap C call" convention on ARMv7.

* assembler/AbstractMacroAssembler.h:
(JSC::isARMv7s):
(JSC):
(JSC::isX86):
* dfg/DFGCommon.h:
* jit/SpecializedThunkJIT.h:
(SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):
* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd efl to JSInspectorFrontendHost::port()
commit-queue [Thu, 25 Apr 2013 00:51:29 +0000 (00:51 +0000)]
Add efl to JSInspectorFrontendHost::port()
https://bugs.webkit.org/show_bug.cgi?id=115137

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Timothy Hatcher.

No new tests, because there is no change in behavior.

* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::port):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFunction parameter quotePair can be passed by reference
kangil.han [Thu, 25 Apr 2013 00:44:13 +0000 (00:44 +0000)]
Function parameter quotePair can be passed by reference
https://bugs.webkit.org/show_bug.cgi?id=115089

Reviewed by Alexey Proskuryakov.

Minor performance patch.

* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::addPair):
* rendering/style/QuotesData.h:
(QuotesData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplementors of CachedResource subclasses should be forced to decide if encoded data...
Brady Eidson [Thu, 25 Apr 2013 00:17:16 +0000 (00:17 +0000)]
Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
https://bugs.webkit.org/show_bug.cgi?id=115140

Reviewed by Beth Dakin.

No new tests (No behavior change).

This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
in all CachedResource subclasses besides CachedFont (which already has an implementation).

* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.h:
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedScript.h:
* loader/cache/CachedShader.h:
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMisc bugfix and cleaning in sh4 base JIT.
commit-queue [Thu, 25 Apr 2013 00:10:15 +0000 (00:10 +0000)]
Misc bugfix and cleaning in sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115022.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-24
Reviewed by Oliver Hunt.

Remove unused add32() and sub32() with scratchreg parameter to avoid
confusion as this function prototype means another behaviour.
Remove unused "void push(Address)" function which seems quite buggy.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::and32): Cosmetic change.
(JSC::MacroAssemblerSH4::lshift32): Cosmetic change.
(JSC::MacroAssemblerSH4::or32): Cosmetic change.
(JSC::MacroAssemblerSH4::xor32): Cosmetic change.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load32): Cosmetic change.
(JSC::MacroAssemblerSH4::load8Signed): Fix invalid offset upper limit
when using r0 register and cosmetic changes.
(JSC::MacroAssemblerSH4::load8): Reuse load8Signed to avoid duplication.
(JSC::MacroAssemblerSH4::load16): Fix invalid offset upper limit when
using r0 register, fix missing offset shift and cosmetic changes.
(JSC::MacroAssemblerSH4::store32): Cosmetic change.
(JSC::MacroAssemblerSH4::branchAdd32): Store result value before branch.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFurther unreviewed build fix; CFNetwork.framework is the one which Lion
Jer Noble [Wed, 24 Apr 2013 23:46:06 +0000 (23:46 +0000)]
Further unreviewed build fix; CFNetwork.framework is the one which Lion
refuses to link against.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix; link against CoreServices.framework instead of against
Jer Noble [Wed, 24 Apr 2013 23:32:32 +0000 (23:32 +0000)]
Unreviewed build fix; link against CoreServices.framework instead of against
CoreFoundation.framework directly, to make the linker happy on Lion.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix invalid test names in jsc-test-list
David Kilzer [Wed, 24 Apr 2013 23:31:55 +0000 (23:31 +0000)]
Fix invalid test names in jsc-test-list
<http://webkit.org/b/115136>

Reviewed by Geoffrey Garen.

This shell script finds all the invalid tests listed in
LayoutTests/fast/js/jsc-test-list:

    $ for F in `cat LayoutTests/fast/js/jsc-test-list`; do if [ ! -f LayoutTests/$F.html ]; then echo $F; fi; done
    fast/js/dfg-double-addition-simplify-to-int.html
    fast/js/dfg-mul-big-integers-with-small-integer-and-bitor
    fast/js/dfg-mul-big-integers-with-small-integer-and-detect-overflow
    fast/js/dfg-mul-big-integers-with-small-integer
    fast/js/dfg-value-to-int32-with-side-effects

* fast/js/jsc-test-list: Fix invalid test names by removing
*.html suffix or stray "s" characters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWWDC session videos don’t play at developer.apple.com
Jer Noble [Wed, 24 Apr 2013 23:20:44 +0000 (23:20 +0000)]
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858

Reviewed by Eric Carlson. Rubber stamped by Brady Eidson.

AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.

Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
* Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
* Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
    the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.

Add a helper singleton class which will talk to the shim through the
registered callbacks:
* Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
* Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
    over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.

Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):

As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
* Shared/mac/DyldInterpose.h: Added.
* PluginProcess/mac/PluginProcessShim.mm:
* WebProcess/mac/SecItemShimLibrary.mm:

Add new files to the project:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Fix build error after r148963.
bw80.lee [Wed, 24 Apr 2013 22:50:14 +0000 (22:50 +0000)]
[EFL] Fix build error after r148963.
https://bugs.webkit.org/show_bug.cgi?id=115126

Reviewed by Laszlo Gombos.

Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h

Source/WebKit2:

* PlatformEfl.cmake:

Tools:

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WIN] Remove pthread from Visual Studio files in JavaScriptCore
Patrick Gansterer [Wed, 24 Apr 2013 22:42:54 +0000 (22:42 +0000)]
[WIN] Remove pthread from Visual Studio files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114864

Reviewed by Brent Fulgham.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
* JavaScriptCore.vcxproj/jsc/jscCommon.props:
* JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
* JavaScriptCore.vcxproj/testapi/testapiCommon.props:
* JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFG should keep the operand to create_this alive if it's emitting code for create_this
Filip Pizlo [Wed, 24 Apr 2013 22:39:33 +0000 (22:39 +0000)]
DFG should keep the operand to create_this alive if it's emitting code for create_this
https://bugs.webkit.org/show_bug.cgi?id=115133

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The DFG must model bytecode liveness, or else OSR exit is going to have a really bad time.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test crashes prior to my change.

* fast/js/dfg-allocation-profile-watch-point-exit-expected.txt: Added.
* fast/js/dfg-allocation-profile-watch-point-exit.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js: Added.
(Foo):
(foo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoOnce a custom font is cached to disk, it starts failing to render until the page...
Brady Eidson [Wed, 24 Apr 2013 22:35:47 +0000 (22:35 +0000)]
Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
<rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131

Reviewed by Alexey Proskuryakov.

No new tests (Not a tested config, nor are disk cache issues currently testable).

* loader/cache/CachedResource.h:
(WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.

* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.
* loader/cache/CachedFont.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago fast/js/global-constructors.html was deleted in r149001, removing it from
Alexey Proskuryakov [Wed, 24 Apr 2013 22:05:13 +0000 (22:05 +0000)]
    fast/js/global-constructors.html was deleted in r149001, removing it from
        TextExpectations too.

        * platform/mac/TestExpectations:
        * platform/qt-arm/TestExpectations:
        * platform/win/TestExpectations:
        * platform/wincairo/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHave VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.
roger_fong [Wed, 24 Apr 2013 21:43:53 +0000 (21:43 +0000)]
Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
* JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd:
* JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd:
* JavaScriptCore.vcxproj/jsc/jscPreLink.cmd:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
* JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd:
* JavaScriptCore.vcxproj/testRegExp/testRegExpPreLink.cmd:
* JavaScriptCore.vcxproj/testapi/testapiPreLink.cmd:
* WTF.vcxproj/build-generated-files.sh:
* win/tools/vsprops/common.props:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoVertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
Beth Dakin [Wed, 24 Apr 2013 21:37:34 +0000 (21:37 +0000)]
Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
a circle
https://bugs.webkit.org/show_bug.cgi?id=115124
-and corresponding-
<rdar://problem/13168957>

Reviewed by Anders Carlsson.

With http://trac.webkit.org/changeset/119834 we started calling
ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection
API on a zero-delay timer instead of calling it right away. This prevented some
crashes that we saw whenever this was called during a layout. However, that delay,
combined with the particulars of contentAreaScrolledInDirection cause this bug
where sometimes the scrollbars in an iframe will fade out very noticeably when
scrolling in a circle.

This change makes it so we will only use the zero-delay timer if the
ScrollableArea is not currently handling a wheel event. If it IS handling a wheel
event, then we will send the notifications to AppKit right away. I confirmed that
this change did not reintroduce the old crashes.

Keep track of whether we are currently handling a wheel event with the new member
variable m_isHandlingWheelEvent.
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):
* page/EventHandler.h:
(WebCore::EventHandler::isHandlingWheelEvent):
(EventHandler):

To prevent layering violations, the ScrollableArea sub-classes will have to access
this information from the EventHandler.
* page/FrameView.cpp:
(WebCore::FrameView::isHandlingWheelEvent):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::isHandlingWheelEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isHandlingWheelEvent):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isHandlingWheelEvent):
* rendering/RenderListBox.h:

sendContentAreaScrolledSoon() can be private. Also add new function
sendContentAreaScrolled().
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):

If the ScrollableArea is handling a wheel event, call
sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):

Re-factored to use sendContentAreaScrolled()
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix a merge error in r149007 (was missing a null check added in r148777).
Ryosuke Niwa [Wed, 24 Apr 2013 21:35:41 +0000 (21:35 +0000)]
Fix a merge error in r149007 (was missing a null check added in r148777).

* rendering/LogicalSelectionOffsetCaches.h:
(WebCore::containingBlockForAbsolutePosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash when trying to determine the length of an invalid message
Anders Carlsson [Wed, 24 Apr 2013 21:33:43 +0000 (21:33 +0000)]
Crash when trying to determine the length of an invalid message
https://bugs.webkit.org/show_bug.cgi?id=115127
<rdar://problem/13700736>

Reviewed by Beth Dakin.

Use message instead of incomingMessage since incomingMessage will always be null.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBattery API won't return updated battery status until client calls didChangeBatteryStatus
commit-queue [Wed, 24 Apr 2013 20:38:38 +0000 (20:38 +0000)]
Battery API won't return updated battery status until client calls didChangeBatteryStatus
https://bugs.webkit.org/show_bug.cgi?id=114891

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-24
Reviewed by Rob Buis.

The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
or other get functions will always return the default values until the next battery status
change object gets passed to the controller.

We need to update the manager when we attach it to the controller, and update all
existing managers when the controller receives it's first battery status object.

* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::updateBatteryStatus):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryManager.h:
(BatteryManager):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoClean up unused code in ViewportArguments.h
zhajiang [Wed, 24 Apr 2013 20:11:03 +0000 (20:11 +0000)]
Clean up unused code in ViewportArguments.h
https://bugs.webkit.org/show_bug.cgi?id=115121

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-24.
Reviewed by Benjamin Poulain.

The target-densityDPI emulation implementation has been removed by
r147893, so clean up the remaining code as well.

* dom/ViewportArguments.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoElementData should use 'unsigned' attribute indices.
akling [Wed, 24 Apr 2013 20:03:12 +0000 (20:03 +0000)]
ElementData should use 'unsigned' attribute indices.
<http://webkit.org/b/115103>

Reviewed by Antti Koivisto.

Switch to using 'unsigned' for attribute indices. This gives consistent behavior
on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.

Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.

* dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::getAttributeItemIndexSlowCase):
* dom/Element.h:
(ElementData):
(UniqueElementData):
(Element):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::attributeCount):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::length):
* dom/NamedNodeMap.h:
(NamedNodeMap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoElementData::attributeItem() should bounds-check the index.
akling [Wed, 24 Apr 2013 20:00:44 +0000 (20:00 +0000)]
ElementData::attributeItem() should bounds-check the index.
<http://webkit.org/b/115076>

Reviewed by Antti Koivisto.

Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.

* dom/Element.h:
(WebCore::ElementData::attributeItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSetting an inline style property to "" shouldn't cause style recalc unless the proper...
akling [Wed, 24 Apr 2013 19:59:18 +0000 (19:59 +0000)]
Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
<http://webkit.org/b/115122>

Reviewed by Antti Koivisto.

StylePropertySet::setProperty() handles empty strings by removing the property entirely.
If there was no property to remove, it shouldn't claim that it changed something, as that
will cause the CSSOM wrapper to mark the element for style recalc.

A common idiom that triggers this is excessive use of { element.style.display = ''; }

* css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMoving word boundaries backwards fails when there is a text node starting with an...
Ryosuke Niwa [Wed, 24 Apr 2013 19:50:50 +0000 (19:50 +0000)]
Moving word boundaries backwards fails when there is a text node starting with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=115070

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
"I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".

Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
languages like Hebrew and some of European languages, there could be many accents and combining characters
between split into multiple text nodes as one variant is seen in the newly added test case.

Test: editing/selection/previous-word-boundary-across-text-nodes.html

* editing/VisibleUnits.cpp:
(WebCore::previousBoundary):

LayoutTests:

Added a test case for moving bacwkards with a word granurality across multiple text nodes.
Some test cases still fail since this patch only implements a work around.

* editing/selection/previous-word-boundary-across-text-nodes-expected.txt: Added.
* editing/selection/previous-word-boundary-across-text-nodes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDo not use static string in DiagnosticLoggingKeys
Benjamin Poulain [Wed, 24 Apr 2013 19:46:44 +0000 (19:46 +0000)]
Do not use static string in DiagnosticLoggingKeys
https://bugs.webkit.org/show_bug.cgi?id=115093

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-24
Reviewed by Andreas Kling.

The code is not hot enough to justify keeping the memory around.
This removes 3kb from the binary on x86_64.

* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
* page/DiagnosticLoggingKeys.h:
(DiagnosticLoggingKeys):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove wxWebKit #ifdefs from WebCore/platform/graphics
Benjamin Poulain [Wed, 24 Apr 2013 19:38:08 +0000 (19:38 +0000)]
Remove wxWebKit #ifdefs from WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=115081

Reviewed by Geoffrey Garen.

* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/Color.h:
(Color):
* platform/graphics/FloatRect.h:
(FloatRect):
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/FontPlatformData.h:
* platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/ImageBufferData.h:
* platform/graphics/IntPoint.h:
(IntPoint):
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
(IntSize):
* platform/graphics/NativeImagePtr.h:
(WebCore):
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/transforms/AffineTransform.h:
(AffineTransform):
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove wxWebKit #ifdefs from WebCore/plugins
Benjamin Poulain [Wed, 24 Apr 2013 19:36:17 +0000 (19:36 +0000)]
Remove wxWebKit #ifdefs from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=115080

Reviewed by Geoffrey Garen.

* plugins/PluginView.h:
(PluginView):
* plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::platformStart):
* plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove wxWebKit #ifdefs from WebCore/page
Benjamin Poulain [Wed, 24 Apr 2013 19:35:31 +0000 (19:35 +0000)]
Remove wxWebKit #ifdefs from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=115079

Reviewed by Geoffrey Garen.

* page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
* page/Settings.cpp:
(WebCore):
* page/Settings.h:
(Settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse post-branch store for RefCountedBase::derefBase
Benjamin Poulain [Wed, 24 Apr 2013 19:34:50 +0000 (19:34 +0000)]
Use post-branch store for RefCountedBase::derefBase
https://bugs.webkit.org/show_bug.cgi?id=115078

Reviewed by Andreas Kling.

* wtf/RefCounted.h:
(WTF::RefCountedBase::derefBase): This makes the assembly easier to follow.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Use stamp files for generate-forwarding-headers makefile rules
Carlos Garcia Campos [Wed, 24 Apr 2013 18:34:04 +0000 (18:34 +0000)]
[GTK] Use stamp files for generate-forwarding-headers makefile rules
https://bugs.webkit.org/show_bug.cgi?id=115118

Reviewed by Martin Robinson.

Source/WebKit2:

Use a stamp file for the WebKit2 forwarding generator rule. Also
fix the rule dependencies that pointed to a non existent variable.

* GNUmakefile.am:

Tools:

Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.

* TestWebKitAPI/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: WAI-ARIA landmarks no longer speak type of landmark on iOS
Chris Fleizach [Wed, 24 Apr 2013 18:33:12 +0000 (18:33 +0000)]
AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
https://bugs.webkit.org/show_bug.cgi?id=114547

Reviewed by David Kilzer.

Source/WebCore:

We want iOS to speak the landmark type.
I've moved the landmark role description to the base Mac class and exposed
these localized strings to iOS (the ones used to return landmark descriptions).

I've also updated the accessibilityLabel to account for landmark type, but also
handle multiple label sources more gracefully by appending commas, which changed a few
tests in minor ways.

Test: platform/iphone-simulator/accessibility/landmark-type.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
* platform/LocalizedStrings.h:
(WebCore):

LayoutTests:

* platform/iphone-simulator/accessibility/landmark-type-expected.txt: Added.
* platform/iphone-simulator/accessibility/landmark-type.html: Added.
* platform/iphone-simulator/accessibility/link-with-images-text-expected.txt:
* platform/iphone-simulator/accessibility/link-with-images-text.html:
     Minor change to accomodate trimming of white space.
* platform/iphone-simulator/accessibility/math-expected.txt:
* platform/iphone-simulator/accessibility/math.html:
     Math objects now include "math" as the landmark type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago32-bit build fix.
Geoffrey Garen [Wed, 24 Apr 2013 18:16:22 +0000 (18:16 +0000)]
32-bit build fix.

Unreviewed.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): Explicitly
truncate to 32-bit to avoid compiler warnings. It's safe to truncate
because the payload of a boolean is the low bits on both 64-bit and 32-bit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
zandobersek [Wed, 24 Apr 2013 18:06:53 +0000 (18:06 +0000)]
[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
https://bugs.webkit.org/show_bug.cgi?id=115094

Reviewed by Tim Horton.

The method was introduced in r149004 (and a stub implementation for the GTK port added in r149017).
Implement the method for the GTK port in the same manner it is implemented under the Mac port,
calling setContentsOpaque on the non-composited content layer.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Update build dependencies
commit-queue [Wed, 24 Apr 2013 17:50:29 +0000 (17:50 +0000)]
[GTK] Update build dependencies
https://bugs.webkit.org/show_bug.cgi?id=115111

Patch by Simon Pena <simon.pena@samsung.com> on 2013-04-24
Reviewed by Martin Robinson.

The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.

* gtk/install-dependencies: Added a dependency on libegl1-mesa
for both apt and yum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCSS attribute selectors cause unnecessary style recalc when setting attribute to...
akling [Wed, 24 Apr 2013 17:43:14 +0000 (17:43 +0000)]
CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
<http://webkit.org/b/115116>
<rdar://problem/13727709>

Reviewed by Simon Fraser.

The logic that dirties the style if there's a relevant attribute selector in the document
shouldn't run if the attribute is being overwritten with an identical value.
Move this into willModifyAttribute() instead, since we need access to both the old and the new value.

This reduces unnecessary style recalculation in Mac App Store content.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove the Chromium-specific helper from run_webkit_tests.py
commit-queue [Wed, 24 Apr 2013 17:07:01 +0000 (17:07 +0000)]
Remove the Chromium-specific helper from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=114996

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
commit-queue [Wed, 24 Apr 2013 16:12:04 +0000 (16:12 +0000)]
[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
https://bugs.webkit.org/show_bug.cgi?id=114850

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-04-24
Reviewed by Andreas Kling.

Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.

That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.

This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.

This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.

* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago2013-04-24 Simon Cooper <scooper@apple.com>
Alexey Proskuryakov [Wed, 24 Apr 2013 16:08:32 +0000 (16:08 +0000)]
2013-04-24  Simon Cooper  <scooper@apple.com>

        <rdar://problem/13614117> Refine the Flash Player profile
        https://bugs.webkit.org/show_bug.cgi?id=115016

        Reviewed by Alexey Proskuryakov.

        Add some refinements to the Flash Player profile. Make a non-/ home
        directory work. Fixes that allow file uploading via user selected files.

        * Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[BlackBerry] Do not clear focus on a node when tapping on form controls
commit-queue [Wed, 24 Apr 2013 15:59:54 +0000 (15:59 +0000)]
[BlackBerry] Do not clear focus on a node when tapping on form controls
https://bugs.webkit.org/show_bug.cgi?id=115055

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-24
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[BlackBerry] Fixes the San Angeles demo on khronos.org
commit-queue [Wed, 24 Apr 2013 15:49:12 +0000 (15:49 +0000)]
[BlackBerry] Fixes the San Angeles demo on khronos.org
https://bugs.webkit.org/show_bug.cgi?id=115106

Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-24
Reviewed by Rob Buis
Internally Reviewed by Jeremy Nicholl and Arvid Nilsson

Fixes a bug in which the currently bound vertex array object's vertex array
state was being modified as opposed to the default vertex array state.

* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(EGLImageLayerWebKitThread::blitToFrontBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFilled out more cases of branch folding in the DFG
Geoffrey Garen [Wed, 24 Apr 2013 15:48:55 +0000 (15:48 +0000)]
Filled out more cases of branch folding in the DFG
https://bugs.webkit.org/show_bug.cgi?id=115088

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

No change on the benchmarks we track, but a 3X speedup on a
microbenchmark that uses these techniques.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): (!/=)= and (!/=)== can constant
fold all types, not just numbers, because true constants have no
side effects when type-converted at runtime.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean): Added support for fixing up
boolean uses, like we do for other types like number.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare): Peephole fuse
boolean compare and/or compare-branch, now that we have the types for
them.

* dfg/DFGSpeculativeJIT.h: Updated declarations.

LayoutTests:

* fast/js/regress/script-tests/branch-fold.js:
(g): Added some boolean and constant-folded cases.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFold RenderThemeMacShared into RenderThemeMac
Nico Weber [Wed, 24 Apr 2013 15:44:57 +0000 (15:44 +0000)]
Fold RenderThemeMacShared into RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=115086

Reviewed by Anders Carlsson.

No intended functionality change.

* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderThemeMac.h:
(RenderThemeMac):
(WebCore::RenderThemeMac::supportsControlTints):
(WebCore::RenderThemeMac::scrollbarControlSizeForPart):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors):
(WebCore::RenderThemeMac::supportsClosedCaptioning):
(WebCore::RenderThemeMac::updateActiveState):
* rendering/RenderThemeMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
(WebCore):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformFocusRingColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMac::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::systemColor):
(WebCore::RenderThemeMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::updateCheckedState):
(WebCore::RenderThemeMac::updateEnabledState):
(WebCore::RenderThemeMac::updateFocusedState):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintTextArea):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::popupButtonMargins):
(WebCore::RenderThemeMac::popupButtonSizes):
(WebCore::RenderThemeMac::popupButtonPadding):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
(WebCore::RenderThemeMac::levelIndicatorStyleFor):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::menuListSizes):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::searchFieldSizes):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::cancelButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
(WebCore::RenderThemeMac::fileListNameForWidth):
* rendering/RenderThemeMacShared.h: Removed.
* rendering/RenderThemeMacShared.mm: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][AC] Visible rect doesn't update after resizing a window.
commit-queue [Wed, 24 Apr 2013 15:36:26 +0000 (15:36 +0000)]
[GTK][AC] Visible rect doesn't update after resizing a window.
https://bugs.webkit.org/show_bug.cgi?id=115096

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

Once we set actor's a clip rect, we should update the rect when resizing the actor.

No new tests since no new functionality.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][AC] Fix unexpected clear of ClutterContent.
commit-queue [Wed, 24 Apr 2013 15:34:35 +0000 (15:34 +0000)]
[GTK][AC] Fix unexpected clear of ClutterContent.
https://bugs.webkit.org/show_bug.cgi?id=115099

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
it would be cleared unexpectedly by smart pointer when escaping a function.

No new tests, no functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWild build fix attempt.
akling [Wed, 24 Apr 2013 15:30:54 +0000 (15:30 +0000)]
Wild build fix attempt.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding...
commit-queue [Wed, 24 Apr 2013 15:26:24 +0000 (15:26 +0000)]
[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=115098

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-24
Reviewed by Martin Robinson.

r148963 introduced a new WKView.h header in a directory not listed
as a platform prefix in generate-forwarding-headers.pl.

* Scripts/generate-forwarding-headers.pl: Replace unused chromium
plaform prefix with CoordinatedGraphics that is used now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAssertion failure (crash in release) attempting to delete database storage in WK1...
Jessie Berlin [Wed, 24 Apr 2013 15:15:50 +0000 (15:15 +0000)]
Assertion failure (crash in release) attempting to delete database storage in WK1 without
creating a WebView first
https://bugs.webkit.org/show_bug.cgi?id=115065

Reviewed by Brady Eidson.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
Remove WebDatabaseManagerInternal.h.

Source/WebKit/mac:

Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager.

* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager init]):
Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to
WebPlatformStrategies::initializeIfNecessary.

* Storage/WebDatabaseManagerInternal.h: Removed.

* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Change "initialize" to "initalizeIfNecessary".
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::initializeIfNecessary):
Only call setPlatformStrategies once.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Updated for the name change from initialize to initializeIfNecessary.
Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager
sharedWebDatabaseManager].
(+[WebView _setLoadResourcesSerially:]):
Updated for the name change from initialize to initializeIfNecessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDOMFileSystemBase: fix multiple definitions in the BlackBerry port
commit-queue [Wed, 24 Apr 2013 14:27:13 +0000 (14:27 +0000)]
DOMFileSystemBase: fix multiple definitions in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114950

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-24
Reviewed by Xan Lopez.

The following  methods are already defined in DOMFileSystemBlackBerry.cpp:

crackFileSystemURL()
createFileSystemURL()
isValidType()
supportsToURL()

* Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[BlackBerry] Add support for JPEG image quality during encoding.
commit-queue [Wed, 24 Apr 2013 14:10:47 +0000 (14:10 +0000)]
[BlackBerry] Add support for JPEG image quality during encoding.
https://bugs.webkit.org/show_bug.cgi?id=105773

Patch by George Staikos <gstaikos@rim.com> on 2013-04-24
Reviewed by Xan Lopez.

PR 271611
Internally reviewed by Liam Quinn.

Pass the quality flag into the encoder, with a default of 65

Covered by existing tests.

* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
* platform/image-encoders/JPEGImageEncoder.h:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Add unit test cases for ewk_settings APIs
commit-queue [Wed, 24 Apr 2013 13:54:27 +0000 (13:54 +0000)]
[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

* tests/test_ewk_setting.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
Csaba Osztrogonác [Wed, 24 Apr 2013 13:11:58 +0000 (13:11 +0000)]
Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
https://bugs.webkit.org/show_bug.cgi?id=115036

Reviewed by Benjamin Poulain.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed EFL gardening.
ch.dumez [Wed, 24 Apr 2013 13:03:45 +0000 (13:03 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/js/constructor-length.html for EFL port after
r148997.

* platform/efl/fast/js/constructor-length-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unnecessary MutableStylePropertySet casts.
akling [Wed, 24 Apr 2013 12:33:33 +0000 (12:33 +0000)]
Remove unnecessary MutableStylePropertySet casts.
<http://webkit.org/b/115075>

Reviewed by Geoffrey Garen.

Get rid of some now-unneeded static_casts that were left from the StylePropertySet
refactoring last weekend.

* css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Minor code cleanup] Remove duplicated condition check
kangil.han [Wed, 24 Apr 2013 12:17:32 +0000 (12:17 +0000)]
[Minor code cleanup] Remove duplicated condition check
https://bugs.webkit.org/show_bug.cgi?id=115082

Reviewed by Andreas Kling.

areRectsPartiallyAligned() has duplicated condition check, so remove it.

* page/SpatialNavigation.cpp:
(WebCore::areRectsPartiallyAligned):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
ch.dumez [Wed, 24 Apr 2013 12:01:37 +0000 (12:01 +0000)]
[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
https://bugs.webkit.org/show_bug.cgi?id=115095

Reviewed by Antonio Gomes.

Use different subfolders under DumpRenderTree Temp folder for every
functionality (icon database, cache, localstorage, ...). This makes
sure there is no conflict between the functionalities.

In EFL's case, libsoup cache was causing problems for the icon
database if sharing the same folder.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Fix build warnings caused by missing images attributes for default buttons
commit-queue [Wed, 24 Apr 2013 11:21:54 +0000 (11:21 +0000)]
[EFL] Fix build warnings caused by missing images attributes for default buttons
https://bugs.webkit.org/show_bug.cgi?id=114955

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added default image for each button from mediacontrol catalog.

No new tests, because there is no change in behavior.

* platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
* platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
* platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
* platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
* platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
* platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Add number to list from remote web inspector.
commit-queue [Wed, 24 Apr 2013 10:50:40 +0000 (10:50 +0000)]
Web Inspector: Add number to list from remote web inspector.
https://bugs.webkit.org/show_bug.cgi?id=115014

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

* UIProcess/InspectorServer/front-end/inspectorPageIndex.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Rebaselining after r148944
commit-queue [Wed, 24 Apr 2013 10:48:26 +0000 (10:48 +0000)]
[EFL] Rebaselining after r148944
https://bugs.webkit.org/show_bug.cgi?id=115085

Unreviewed gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24

* platform/efl/TestExpectations:
* platform/efl/fast/table/giantRowspan-expected.txt:
* platform/efl/fast/table/giantRowspan2-expected.png:
* platform/efl/fast/table/giantRowspan2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
* platform/efl/tables/mozilla/bugs/bug8858-expected.png:
* platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
* platform/efl/tables/mozilla/core/bloomberg-expected.png:
* platform/efl/tables/mozilla/core/bloomberg-expected.txt:
* platform/efl/tables/mozilla/core/row_span-expected.png:
* platform/efl/tables/mozilla/core/row_span-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix test style issues following the commit of
abucur [Wed, 24 Apr 2013 09:01:29 +0000 (09:01 +0000)]
Fix test style issues following the commit of
https://bugs.webkit.org/show_bug.cgi?id=114412

Unreviewed gardening.

* css3/compositing/effect-background-blend-mode-color.html:
* css3/compositing/effect-background-blend-mode-color2.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago--minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h...
commit-queue [Wed, 24 Apr 2013 08:44:51 +0000 (08:44 +0000)]
--minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: decode is not a member of WebCore::TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=114367

Patch by Vlad Vasilyeu <vasvlad@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

Include WebCoreArgumentCoders.h to WebEditorClientEfl.cpp from
WebKit2/Shared/ for successfully building with option --minimal

* WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix with gstreamer 0.10.x after r147555.
ch.dumez [Wed, 24 Apr 2013 08:23:27 +0000 (08:23 +0000)]
Unreviewed build fix with gstreamer 0.10.x after r147555.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRoll deps^H^H^H^HChangeLogs.
Mark Rowe [Wed, 24 Apr 2013 08:11:10 +0000 (08:11 +0000)]
Roll deps^H^H^H^HChangeLogs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
anilsson [Wed, 24 Apr 2013 08:09:55 +0000 (08:09 +0000)]
[BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
https://bugs.webkit.org/show_bug.cgi?id=115092

Reviewed by Carlos Garcia Campos.

With the Skia backend, we had an optimization to detect solid color
layers. The Skia code has been purged, but these bits remained. With
BlackBerry::Platform::Graphics::PlatformGraphicsContext, only the solid
color will be drawn anyway, so we don't need to detect such layers at
the WebCore level. Fixed by removing the setContentsToColor flavor of
LayerTiler::TextureJob.

BlackBerry::WebKit::WebOverlay still uses
TextureCacheCompositingThread::textureForColor() so that one can stay
for now.

This was dead code so no new tests.

* platform/graphics/blackberry/LayerTile.cpp:
* platform/graphics/blackberry/LayerTile.h:
(LayerTile):
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::performTileJob):
* platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::TextureJob::setContents):
(TextureJob):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Move image decoders, some other GStreamer, Cairo and Soup sources to libPlatform
zandobersek [Wed, 24 Apr 2013 07:43:11 +0000 (07:43 +0000)]
[GTK] Move image decoders, some other GStreamer, Cairo and Soup sources to libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115050

Reviewed by Martin Robinson.

Source/Platform:

* GNUmakefile.am: Add the image-decoders directory and its subdirectories to the list of header inclusion directories.
List the Cairo, GStreamer and Libsoup cppflags under the cppflags libPlatform uses for compiling its sources.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.list.am: Move the image decoders source files and a couple of GStreamer, Cairo and Libsoup source
files under the libPlatform's list of files to build. All of these are already free of platform layer violations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild break after r149004
csaavedra [Wed, 24 Apr 2013 07:25:09 +0000 (07:25 +0000)]
Build break after r149004
https://bugs.webkit.org/show_bug.cgi?id=115091

Reviewed by Csaba Osztrogonác.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):
(WebKit): Add dummy method for new virtual method.
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFG CFA filters CheckFunction in a really weird way, and assumes that the function...
Filip Pizlo [Wed, 24 Apr 2013 03:18:04 +0000 (03:18 +0000)]
DFG CFA filters CheckFunction in a really weird way, and assumes that the function's structure won't change
https://bugs.webkit.org/show_bug.cgi?id=115077

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The filtering did three things that are unusual:

1) AbstractValue::filterByValue() assumed that the passed value's structure wouldn't change, in
   the sense that at it assumed it could use that value's *current* structure to do structure
   filtering. Filtering by structure only makes sense if you can prove that the given value will
   always have that structure (for example by either using a watchpoing or emitting code that
   checks that structure at run-time).

2) AbstractValue::filterByValue() and the CheckFunction case in AbstractState::executeEffects()
   tried to invalidate the CFA based on whether the filtration led to an empty value. This is
   well-intentioned, but it's not how the CFA currently works. It's inconsistent with other
   parts of the CFA. We shouldn't introduce this feature into just one kind of filtration and
   not have it elsewhere.

3) The attempt to detect when the value was empty was actually implemented incorrectly. It
   relied on AbstractValue::validate(). That method says that a concrete value does not belong
   to the abstract value if it has a different structure. This makes sense for the other place
   where AbstractValue::validate() is called: during OSR entry, where we are talking about a
   JSValue that we see *right now*. It doesn't make sense in the CFA, since in the CFA any
   value we observe in the code is a value whose structure may change when the code starts
   running, and so we cannot use the value's current structure to infer things about the code
   when it starts running.

I fixed the above problems by (1) changing filterByValue() to not filter the structure, (2)
changing filterByValue() and the CheckFunction case to not invalidate the CFA, and (3)
making sure that nobody else was misusing AbstractValue::validate() (they weren't).

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filterByValue):

LayoutTests:

Reviewed by Oliver Hunt.

This hilarious test fails prior to the rest of this patch.

* fast/js/dfg-check-function-change-structure-expected.txt: Added.
* fast/js/dfg-check-function-change-structure.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-check-function-change-structure.js: Added.
(foo):
(bar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove TextFieldDecoration feature
Kent Tamura [Wed, 24 Apr 2013 01:59:21 +0000 (01:59 +0000)]
Remove TextFieldDecoration feature
https://bugs.webkit.org/show_bug.cgi?id=115068

Reviewed by Andreas Kling.

Only Chromium port used this feature.

* dom/Element.h: Remove isTextFieldDecoration.
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
Update a comment.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.
* html/shadow/TextFieldDecorationElement.cpp: Removed.
* html/shadow/TextFieldDecorationElement.h: Removed.
* page/ChromeClient.h:
(ChromeClient): Remove willAddTextFieldDecorationsTo and
addTextFieldDecorationsTo

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDefault ParserError() initialiser doesn't initialise all fields
Oliver Hunt [Wed, 24 Apr 2013 01:23:42 +0000 (01:23 +0000)]
Default ParserError() initialiser doesn't initialise all fields
https://bugs.webkit.org/show_bug.cgi?id=115074

Reviewed by Joseph Pecoraro.

Only the jsc command prompt depended on this, but we'll fix it to
be on the safe side.

* parser/ParserError.h:
(JSC::ParserError::ParserError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMicro-optimize Length::initFromLength().
akling [Wed, 24 Apr 2013 01:10:51 +0000 (01:10 +0000)]
Micro-optimize Length::initFromLength().
<http://webkit.org/b/115073>

From Blink r148621 by <timloh@chromium.org>:

This appears to improve html5-full-render by 1-2% on my system (gcc 4.6.3) by using memcpy
instead of copying members (and branching to copy the union).

* platform/Length.h:
(WebCore::Length::initFromLength):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd missing copyright header to ColorChooserClient.h
Kent Tamura [Wed, 24 Apr 2013 01:06:01 +0000 (01:06 +0000)]
Add missing copyright header to ColorChooserClient.h
https://bugs.webkit.org/show_bug.cgi?id=115067

Reviewed by Andreas Kling.

* platform/ColorChooserClient.h:
This was added in 2011 by a Google employee.
http://trac.webkit.org/changeset/103168

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCall the correct superclass in RenderSlider::layout().
akling [Wed, 24 Apr 2013 00:55:21 +0000 (00:55 +0000)]
Call the correct superclass in RenderSlider::layout().
<http://webkit.org/b/115071>

From Blink r147850 by <cbiesinger@chromium.org>:

The superclass is RenderFlexibleBox, not RenderBlock.

* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd platform support for -webkit-background-blend-mode to CG context with background...
commit-queue [Wed, 24 Apr 2013 00:53:42 +0000 (00:53 +0000)]
Add platform support for -webkit-background-blend-mode to CG context with background color
https://bugs.webkit.org/show_bug.cgi?id=114412

Patch by Mihai Tica <mitica@adobe.com> on 2013-04-23
Reviewed by Darin Adler.

Source/WebCore:

Tests: css3/compositing/effect-background-blend-mode-color.html, css3/compositing/effect-background-blend-mode-color2.html

This patch adds support for blending on background colors to the Core Graphics port of WebKit.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
* platform/graphics/GraphicsContext.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding pixel tests for -webkit-background-blend-mode with bg-color
effect-background-blend-mode-color.html uses accelerated compositing
effect-background-blend-mode-color2.html uses software rendering

* css3/compositing/effect-background-blend-mode-color-expected.txt: Added.
* css3/compositing/effect-background-blend-mode-color.html: Added.
* platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Added.
* css3/compositing/effect-background-blend-mode-color2-expected.txt: Added.
* css3/compositing/effect-background-blend-mode-color2.html: Added.
* platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove an unused member variable erroneously added in r149007.
Ryosuke Niwa [Wed, 24 Apr 2013 00:33:19 +0000 (00:33 +0000)]
Remove an unused member variable erroneously added in r149007.

* rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(LogicalSelectionOffsetCaches):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL][WK2] Build break after r149004
Ryuan Choi [Wed, 24 Apr 2013 00:20:09 +0000 (00:20 +0000)]
[EFL][WK2] Build break after r149004
https://bugs.webkit.org/show_bug.cgi?id=115066

Reviewed by Tim Horton.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged):
Added dummy method for new virtual method.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agologicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth(...
Ryosuke Niwa [Wed, 24 Apr 2013 00:18:27 +0000 (00:18 +0000)]
logicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth() multiple times
https://bugs.webkit.org/show_bug.cgi?id=113479

Reviewed by David Hyatt.

Introduced LogicalSelectionOffsetCaches to cache the containing blocks and their logical left and right
selection offsets in computing selection gaps. An instance of this class stores the containing block for
each position type and caches their logical selection offsets when none of their block ancestors up until
its nearest selection root do no have any floating objects or regions and exclusions.

When blockSelectionGaps recurses to another level, it creates a new cache instance by "inheriting"
(like RenderStyle) from the old cache, overriding those containing blocks that are replaced by "this".

This eliminates the need to traverse containing block ancestors in RenderBlock::logicalLeftSelectionOffset
and RenderBlock::logicalRightSelectionOffset, and improves WebKit's performance by roughly 20%.

Performance Tests: Interactive/SelectAll.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:

* rendering/LogicalSelectionOffsetCaches.h: Added.
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Moved from RenderObject.h.
(WebCore::isNonRenderBlockInline): Ditto.
(WebCore::containingBlockForFixedPosition): Extracted from RenderObject::containingBlock.
(WebCore::containingBlockForAbsolutePosition): Ditto.
(WebCore::containingBlockForObjectInFlow): Ditto.

(WebCore::LogicalSelectionOffsetCaches): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock): Added. m_hasFloatsOrRegions is
or'ed with itself when ContainingBlockInfo is copy constructed since m_hasFloatsOrRegions needs be true
for a block when any of its containing block ancestors have floats or regions.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::block): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::cache): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset): Added. Caches
the logical selection offset if it hasn't.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset): Ditto.

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches): The first constructor is used
for a selection root. The second one is used for inheriting from another cache. In the latter case,
copy all containing block information except ones that need to be overridden by this block.
(WebCore::LogicalSelectionOffsetCaches::containingBlockInfo): Returns a ContainingBlockInfo based on
object's position value.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps): Exit before instantiating a new LogicalSelectionOffsetCaches
if there is no child to recurse.
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset): Use LogicalSelectionOffsetCaches to get its containing
block and its logical selection offset.
(WebCore::RenderBlock::logicalRightSelectionOffset): Ditto.

* rendering/RenderBlock.h:
(WebCore::RenderBlock):

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Extracted code into LogicalSelectionOffsetCaches.h.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSelectionGap):

* rendering/RootInlineBox.h:
(WebCore::RootInlineBox):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTurn off tiled drawing in the Web Inspector
Simon Fraser [Tue, 23 Apr 2013 23:44:41 +0000 (23:44 +0000)]
Turn off tiled drawing in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=115064

Reviewed by Tim Horton.

We get little benefit from making the Web Inspector use tiled drawing;
it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
Not using tiled drawing also means that we won't make compositing
layers for position: -webkit-sticky, which avoids a number of issues
with compositing layer proliferation in the inspector.

Also turn off accelerated drawing, since that pref will force a single
compositing layer.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
* UIProcess/mac/WebInspectorProxyMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] forced subtitle track should change when audio track language changes
Eric Carlson [Tue, 23 Apr 2013 23:35:12 +0000 (23:35 +0000)]
[Mac] forced subtitle track should change when audio track language changes
https://bugs.webkit.org/show_bug.cgi?id=115043

Reviewed by Jer Noble.

No new tests, it isn't possible to test this automatically because there is currently no way
to enable/disable audio tracks.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Set m_forcedOrAutomaticSubtitleTrackLanguage.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):  Call markCaptionAndSubtitleTracksAsUnconfigured
    after a delay if the language of the primary audio track changes.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): markCaptionAndSubtitleTracksAsUnconfigured API change.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Take parameter to allow
    the reconfiguration to happen after a delay to avoid doing it during a callback from the
    media engine. Clear the ConfigureTextTracks bit in m_pendingActionFlags to cancel any pending
    asynch configuration.
* html/HTMLMediaElement.h:

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Clean up logic.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Call characteristicChanged when
    the primary audio track language changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWhen the web page transparency changes, DrawingAreaImpl needs to know about it
Simon Fraser [Tue, 23 Apr 2013 23:02:08 +0000 (23:02 +0000)]
When the web page transparency changes, DrawingAreaImpl needs to know about it
https://bugs.webkit.org/show_bug.cgi?id=115062

Reviewed by Tim Horton.

The non-composited contents layer owned by LayerTreeHostMac needs to
be marked as opaque or not depending on whether the WebPage draws
a background (or transparent background). It computed this at creation,
but did not dynamically update the state. Fix it so it does.

This fixes cases of garbage pixels in the Web Inspector toolbar area
in some configurations.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageBackgroundTransparencyChanged):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::pageBackgroundTransparencyChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CSS Exclusions] Improve ExclusionPolygon smart pointer safety
hmuller [Tue, 23 Apr 2013 22:43:19 +0000 (22:43 +0000)]
[CSS Exclusions] Improve ExclusionPolygon smart pointer safety
https://bugs.webkit.org/show_bug.cgi?id=114984

Reviewed by Dirk Schulze.

Assign newly allocated objects to PassOwnPtrs as early as possible to reduce the
chances of future leaks. No new tests were added, this change adds no new functionality.

* rendering/ExclusionPolygon.cpp:
(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
(WebCore::ExclusionPolygon::shapePaddingBounds):
(WebCore::ExclusionPolygon::shapeMarginBounds):
* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRevert "Throttle resize events during live window resize."
akling [Tue, 23 Apr 2013 22:36:20 +0000 (22:36 +0000)]
Revert "Throttle resize events during live window resize."
<http://webkit.org/b/114292>
<rdar://problem/13411454>
<rdar://problem/13694839>

Reviewed by Geoffrey Garen.

It appears that this caused more glitches than it helped resize performance.

* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEvent):

    Turn the null-check of m_frame into an assertion since this method is
    no longer called asynchronously.

(WebCore::FrameView::willEndLiveResize):

    Ninja fix: call up to the closest superclass implementation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGlobal constructors should be configurable and not enumerable
ch.dumez [Tue, 23 Apr 2013 22:34:46 +0000 (22:34 +0000)]
Global constructors should be configurable and not enumerable
https://bugs.webkit.org/show_bug.cgi?id=110573

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update JSObject::deleteProperty() so that mark to set the property
value to undefined if it is in static hashtable of properties. The
previous code was not doing anything in this case and this meant
we could not remove builtin DOMWindow properties such as
"ProgressEvent" even if marked as Deletable.

* runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
* runtime/Lookup.h:
(JSC):
(JSC::putEntry):
(JSC::lookupPut):

Source/WebCore:

Update JSC Code generator so that global constructors now have the following
attributes:
{ [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
instead of previously:
{ [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: false }

The new behavior is according to the Web IDL specification (section 4.4):
http://dev.w3.org/cvsweb/~checkout~/2006/webapi/WebIDL/Overview.html?rev=1.617;content-type=text%2Fhtml#es-interfaces

This also matches the behavior of Firefox.

Tests: fast/js/global-constructors-attributes.html
       fast/js/global-constructors-deletable.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):

LayoutTests:

Add new tests to make sure that the global constructors have the
right attributes and to check that they are 'Deletable'.

* canvas/philip/tests/type.delete-expected.txt: Removed.
* canvas/philip/tests/type.delete.html: Removed. It was checking that global constructor
could NOT be deleted, which is no longer according to the Web IDL specification.
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/script-tests/constructed-objects-prototypes.js: Update test to hardcode a few
global constructors as they are no longer enumerable.
* fast/js/getOwnPropertyDescriptor-expected.txt:
* fast/js/global-constructors.html: Removed. It was relying on the global constructors
to be 'Enumerable', which is not to the latest Web IDL specification.
* fast/js/global-constructors-attributes-expected.txt: Added.
* fast/js/global-constructors-attributes.html: Added.
* fast/js/global-constructors-deletable-expected.txt: Added.
* fast/js/global-constructors-deletable.html: Added.
* fast/js/global-constructors-expected.txt: Removed.
* fast/js/resources/getOwnPropertyDescriptor.js:
* fast/js/script-tests/global-constructors-attributes.js: Added.
* fast/js/script-tests/global-constructors-deletable.js: Added.
* fast/js/script-tests/global-constructors.js: Removed.
* platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
* platform/efl/fast/js/global-constructors-expected.txt: Removed.
* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
* platform/gtk/fast/js/global-constructors-expected.txt: Removed.
* platform/mac/fast/js/global-constructors-expected.txt: Removed.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
* platform/qt/fast/js/global-constructors-expected.txt: Removed.
* platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
* platform/win/fast/js/global-constructors-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Remove myself from watchlist.
David Grogan [Tue, 23 Apr 2013 22:23:54 +0000 (22:23 +0000)]
Unreviewed. Remove myself from watchlist.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/JavaScriptCore: Filled out more cases of branch folding in bytecode when emitting
Geoffrey Garen [Tue, 23 Apr 2013 22:18:18 +0000 (22:18 +0000)]
Source/JavaScriptCore: Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

This covers a few cases like:

    - while (true) { }
    - while (1) { }
    - if (x) break;
    - if (x) continue;
    - if (boolean_expr == boolean_const) { }
    - if (boolean_expr == 1_or_0) { }
    - if (bitop == 1_or_0) { }

This also works, but will bring shame on your family:

    - while ("hello world") { }

No change on the benchmarks we track, but a 2.5X speedup on a microbenchmark
that uses these techniques.

* JavaScriptCore.order: Order!

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::shouldEmitDebugHooks): Updated ancillary code
for interface simplifications.

* bytecompiler/NodesCodegen.cpp:
(JSC::ConstantNode::emitBytecodeInConditionContext): Constants can
jump unconditionally when used within a condition context.

(JSC::ConstantNode::emitBytecode):
(JSC::StringNode::jsValue): Gave constants a common base class so I
could implement their codegen just once.

(JSC::BinaryOpNode::emitBytecodeInConditionContext):
(JSC::canFoldToBranch):
(JSC::BinaryOpNode::tryFoldToBranch): Fold (!/=)= and (!/=)== where
appropriate. A lot of cases are not appropriate because of the surprising
type conversion semantics of ==. For example, if (number == true) { } is
not the same as if (number) { } because the former will up-convert true
to number and then do numeric comparison.

(JSC::singleStatement):
(JSC::IfElseNode::tryFoldBreakAndContinue):
(JSC::IfElseNode::emitBytecode):
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget): Fold "if (expression) break" and
"if (expression) continue" into direct jumps from expression.

* parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createIfStatement):
* parser/NodeConstructors.h:
(JSC::ConstantNode::ConstantNode):
(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfElseNode::IfElseNode):
* parser/Nodes.h:
(JSC::ExpressionNode::isConstant):
(JSC::ExpressionNode::isBoolean):
(JSC::StatementNode::isBreak):
(JSC::StatementNode::isContinue):
(ConstantNode):
(JSC::ConstantNode::isPure):
(JSC::ConstantNode::isConstant):
(NullNode):
(JSC::NullNode::jsValue):
(JSC::BooleanNode::value):
(JSC::BooleanNode::isBoolean):
(JSC::BooleanNode::jsValue):
(JSC::NumberNode::value):
(NumberNode):
(JSC::NumberNode::jsValue):
(StringNode):
(BinaryOpNode):
(IfElseNode):
(ContinueNode):
(JSC::ContinueNode::isContinue):
(BreakNode):
(JSC::BreakNode::isBreak):
* parser/Parser.cpp:
(JSC::::parseIfStatement):
* parser/ResultType.h:
(JSC::ResultType::definitelyIsBoolean):
(ResultType):
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
* runtime/JSCell.h:
* runtime/JSCellInlines.h:
(JSC::JSCell::pureToBoolean): Updated for interface changes above.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

* wtf/TriState.h:
(WTF::triState):
(WTF):

LayoutTests: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a performance test for interesting branch types.

* fast/js/regress/branch-fold-expected.txt: Added.
* fast/js/regress/branch-fold.html: Added.
* fast/js/regress/script-tests/branch-fold.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDon't create compositing layers for sticky position unless using the ScrollingCoordinator
Simon Fraser [Tue, 23 Apr 2013 22:01:05 +0000 (22:01 +0000)]
Don't create compositing layers for sticky position unless using the ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=115060

Source/WebCore:

Reviewed by Tim Horton.

Creating compositing layers for sticky position elements is only useful
when we're using a ScrollingCoordinator, so don't create them if
we're not in a frame that uses a scrolling coordinator.

Tests: compositing/layer-creation/no-compositing-for-sticky.html
       platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Tim Horton.

Tests that we create layers for sticky position when in tiled drawing mode,
and that we have no layers when not.

* compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
* compositing/layer-creation/no-compositing-for-sticky.html: Added.
* platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago'length' property of DOM bindings functions returns wrong value
ch.dumez [Tue, 23 Apr 2013 21:59:26 +0000 (21:59 +0000)]
'length' property of DOM bindings functions returns wrong value
https://bugs.webkit.org/show_bug.cgi?id=110569

Reviewed by Geoffrey Garen.

Source/WebCore:

Make the 'length' property of Function objects and Interface
objects behave according to the latest Web IDL specification
editor draft:
http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
http://dev.w3.org/2006/webapi/WebIDL/#es-operations

As a result, only mandatory arguments are taken into account
when computing the value for the 'length' property. This
behavior is consistent with Firefox and Blink.

Tests: fast/js/constructor-length.html
       fast/js/function-length.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorHelperMethods):
Update the JSC code generator to only account for mandatory parameters
when computing the value for the 'length' property of Function objects
and constructors.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
Rebaseline bindings tests results.

* fileapi/Blob.idl:
Remove 'ConstructorParameters=2' extended attribute as the correct value
is 0, given that a Blob can be constructed without parameter.

* html/canvas/DataView.idl:
Update ConstructorParameters extended attribute value from 3 to 1 as only
one of the 3 parameters is mandatory.

* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
Remove 'ConstructorParameters=1' extended attribute from interfaces using
'ConstructorTemplate=TypedArray' as the bindings generator now properly
compute the number of constructor parameters for such interfaces.

* page/WebKitPoint.idl:
Remove 'ConstructorParameters=2' extended attribute as the correct value
should be 0, given that a WebKitPoint can be constructed without parameters.

LayoutTests:

Update fast/js/constructor-length.html test case now that only
mandatory arguments are considered for the constructor length.

Also add a new fast/js/function-length.html test to make sure
that the 'length' property of Function objects from DOM
bindings behaves according to the Web IDL specification as
this was not covered by existing tests.

* fast/files/blob-constructor-expected.txt: Rebaseline.
* fast/files/script-tests/blob-constructor.js: Update test now that Blob constructor
length is 0 instead of 2.
* fast/js/constructor-length.html:
* fast/js/function-length-expected.txt: Added.
* fast/js/function-length.html: Added.
* platform/blackberry/fast/js/constructor-length-expected.txt: Rebaseline.
* platform/efl/TestExpectations: Unskip fast/js/constructor-length.html for EFL port.
* platform/efl/fast/js/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/fast/js/constructor-length-expected.txt.
* platform/gtk/fast/js/constructor-length-expected.txt: Rebaseline.
* platform/mac/fast/js/constructor-length-expected.txt: Rebaseline.
* platform/qt/fast/js/constructor-length-expected.txt: Rebaseline.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNRWT: confusing warning about a line being in a Skipped file when it is really just...
commit-queue [Tue, 23 Apr 2013 21:58:28 +0000 (21:58 +0000)]
NRWT: confusing warning about a line being in a Skipped file when it is really just listed
in _missing_symbol_to_skipped_tests in base.py
https://bugs.webkit.org/show_bug.cgi?id=108884

Patch by Jessie Berlin <jberlin@apple.com> on 2013-04-23
Reviewed by Tim Horton.

Tools:

Remove symbol-based skipped list detection.

* Scripts/webkitpy/port/base.py:
(Port._missing_feature_to_skipped_tests):
(Port._skipped_tests_for_unsupported_features):
* Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_path_to_test_expectations_file):

LayoutTests:

Explicitly skip the mhtml tests on the Mac and Win ports.

* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r148922): Crash opening web archives or loading web pages
Anders Carlsson [Tue, 23 Apr 2013 21:56:59 +0000 (21:56 +0000)]
REGRESSION(r148922): Crash opening web archives or loading web pages
https://bugs.webkit.org/show_bug.cgi?id=115061
<rdar://problem/13714228>

Reviewed by Sam Weinig.

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
Calling ResourceLoader::didReceiveResponse can cause the WebResourceLoader object to go away,
so protect it here and guard against a null core loader.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove the WebKit layer of wxWebKit
Benjamin Poulain [Tue, 23 Apr 2013 21:35:51 +0000 (21:35 +0000)]
Remove the WebKit layer of wxWebKit
https://bugs.webkit.org/show_bug.cgi?id=115006

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Anders Carlsson.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

* wx/WebBrowserShell.cpp: Removed.
* wx/WebBrowserShell.h: Removed.
* wx/WebDOMSelection.cpp: Removed.
* wx/WebDOMSelection.h: Removed.
* wx/WebEdit.cpp: Removed.
* wx/WebEdit.h: Removed.
* wx/WebFrame.cpp: Removed.
* wx/WebFrame.h: Removed.
* wx/WebFramePrivate.h: Removed.
* wx/WebKitDefines.h: Removed.
* wx/WebKitSupport/ChromeClientWx.cpp: Removed.
* wx/WebKitSupport/ChromeClientWx.h: Removed.
* wx/WebKitSupport/ContextMenuClientWx.cpp: Removed.
* wx/WebKitSupport/ContextMenuClientWx.h: Removed.
* wx/WebKitSupport/DragClientWx.cpp: Removed.
* wx/WebKitSupport/DragClientWx.h: Removed.
* wx/WebKitSupport/EditCommandWx.h: Removed.
* wx/WebKitSupport/EditorClientWx.cpp: Removed.
* wx/WebKitSupport/EditorClientWx.h: Removed.
* wx/WebKitSupport/FrameLoaderClientWx.cpp: Removed.
* wx/WebKitSupport/FrameLoaderClientWx.h: Removed.
* wx/WebKitSupport/FrameNetworkingContextWx.h: Removed.
* wx/WebKitSupport/InspectorClientWx.cpp: Removed.
* wx/WebKitSupport/InspectorClientWx.h: Removed.
* wx/WebSettings.cpp: Removed.
* wx/WebSettings.h: Removed.
* wx/WebView.cpp: Removed.
* wx/WebView.h: Removed.
* wx/WebViewPrivate.h: Removed.
* wx/bindings/python/samples/simple.py: Removed.
* wx/bindings/python/webview.i: Removed.
* wx/bindings/python/wscript: Removed.
* wx/wscript: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148994 268f45cc-cd09-0410-ab3c-d52691b4dbfc