webkit:webkit.git
5 years agoExpose security origin to BundleFrame
Jon Lee [Sun, 4 Nov 2012 22:26:02 +0000 (22:26 +0000)]
Expose security origin to BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=101139
<rdar://problem/12629900>

Reviewed by Darin Adler.

Create a WebSecurityOrigin instance, sharing the security origin instance
that comes directly from the frame's document. We can do this because the
WK2 API only retrieves information about the origin, and because those
results are returned as copies. The security origin holds no references
that could lead to a retain cycle, avoiding the possibility that the
injected bundle accidentally keeps something alive.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI): Create copied API for WebCore::SecurityOrigin
instances.
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create): Add a new create() function that
takes a PassRefPtr to a WebCore SecurityOrigin instance.
(WebKit::WebSecurityOrigin::createFromString): Refactor to use new create()
function.
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Refactor to
use new create() function.
(WebKit::WebSecurityOrigin::create): Refactor to use new create()
function.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySecurityOrigin): Add function to retrieve the security
origin as a WK2 API object.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMissing ASCIILiteral in a place of accessibility
Gyuyoung Kim [Sun, 4 Nov 2012 17:27:45 +0000 (17:27 +0000)]
Missing ASCIILiteral in a place of accessibility
https://bugs.webkit.org/show_bug.cgi?id=101160

Reviewed by Darin Adler.

ASCIILiteral usage is being missed in a spot of accessibliity.

* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeDisplay::accessibilityDescription):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Unify transforms in WK2
Kenneth Rohde Christiansen [Sun, 4 Nov 2012 16:02:29 +0000 (16:02 +0000)]
[EFL] Unify transforms in WK2
https://bugs.webkit.org/show_bug.cgi?id=101051

Reviewed by Simon Hausmann.

Move our transforms into EwkViewImpl and use them
everywhere needed.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::smartData):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::transformToScene):
(EwkViewImpl::transformToScreen):
(EwkViewImpl::displayTimerFired):
* UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(ewk_view_feed_touch_event):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] Add a now-failing test. Unreviewed.
Stephen White [Sun, 4 Nov 2012 14:57:52 +0000 (14:57 +0000)]
[chromium] Add a now-failing test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
Balazs Kelemen [Sun, 4 Nov 2012 14:07:02 +0000 (14:07 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Reland with build fixes.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):  Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoColor-profile property triggers assert
fmalita [Sun, 4 Nov 2012 13:26:58 +0000 (13:26 +0000)]
Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080

Reviewed by Dirk Schulze.

Source/WebCore:

CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
unimplemented property assert. Adding a stub entry to avoid that.

Test: svg/css/color-profile-crash.html

* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):

LayoutTests:

* svg/css/color-profile-crash-expected.txt: Added.
* svg/css/color-profile-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.
Csaba Osztrogonác [Sun, 4 Nov 2012 12:30:46 +0000 (12:30 +0000)]
[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Updated after r133019.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Updated after r133019.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Updated after r133019.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt] Unreviewed weekend gardening, skip one more failing test.
Csaba Osztrogonác [Sun, 4 Nov 2012 10:55:33 +0000 (10:55 +0000)]
[Qt] Unreviewed weekend gardening, skip one more failing test.

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt] Unreviewed weekend gardening, skip new failing tests.
Csaba Osztrogonác [Sun, 4 Nov 2012 10:31:25 +0000 (10:31 +0000)]
[Qt] Unreviewed weekend gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnable to copy text on disabled input fields on long press gesture
kaustubh [Sun, 4 Nov 2012 09:20:13 +0000 (09:20 +0000)]
Unable to copy text on disabled input fields on long press gesture
https://bugs.webkit.org/show_bug.cgi?id=99698

Reviewed by Ryosuke Niwa.

Text from disabled input/text should be allowed to select. Replaced isContentEditable()
with canStartSelection()

Source/WebCore:

Test: fast/events/touch/gesture/disabled-input-text-selection.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):

LayoutTests:

* fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Added.
* fast/events/touch/gesture/disabled-input-text-selection.html: Added.
* platform/chromium/TestExpectations: Not Valid for chromium desktop.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt] udis86_itab.c is always regenerated
Csaba Osztrogonác [Sun, 4 Nov 2012 08:07:41 +0000 (08:07 +0000)]
[Qt] udis86_itab.c is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=100756

Reviewed by Simon Hausmann.

* DerivedSources.pri: Generate sources to the generated directory.
* disassembler/udis86/differences.txt:
* disassembler/udis86/itab.py: Add --outputDir option.
(UdItabGenerator.__init__):
(genItabH):
(genItabC):
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133381.
Csaba Osztrogonác [Sun, 4 Nov 2012 08:03:03 +0000 (08:03 +0000)]
Unreviewed, rolling out r133381.
http://trac.webkit.org/changeset/133381
https://bugs.webkit.org/show_bug.cgi?id=101161

It made webkit-patch useless (Requested by Ossy_weekend on

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.__init__):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] Remove some no-longer-flaky tests. Unreviewed.
Stephen White [Sun, 4 Nov 2012 07:43:52 +0000 (07:43 +0000)]
[chromium] Remove some no-longer-flaky tests.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] Remove some a no-longer-flaky test. Unreviewed.
Stephen White [Sun, 4 Nov 2012 01:06:56 +0000 (01:06 +0000)]
[chromium] Remove some a no-longer-flaky test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133403, r133404, and r133409.
Balazs Kelemen [Sun, 4 Nov 2012 00:57:14 +0000 (00:57 +0000)]
Unreviewed, rolling out r133403, r133404, and r133409.
http://trac.webkit.org/changeset/133403
http://trac.webkit.org/changeset/133404
http://trac.webkit.org/changeset/133409
https://bugs.webkit.org/show_bug.cgi?id=101158

"Broke tests" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of USE(CFURLSTORAGESESSIONS)
Alexey Proskuryakov [Sun, 4 Nov 2012 00:35:30 +0000 (00:35 +0000)]
Get rid of USE(CFURLSTORAGESESSIONS)
https://bugs.webkit.org/show_bug.cgi?id=101131

Reviewed by Sam Weinig.

Source/WebCore:

This is always enabled on CFNetwork based platforms.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled):
* platform/mac/CookieJar.mm:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore):
(WebCore::currentCFHTTPCookieStorage):
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
* platform/network/cf/ResourceRequest.h:
(ResourceRequest):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore):
* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore):
(WebCore::ResourceRequest::setStorageSession):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
CFURLSTORAGESESSIONS probably doesn't need to stay here.

Source/WebKit/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
(+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
* WebView/WebView.mm:
(-[WebView _cachedResponseForURL:]):

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/Cookies/mac/WebCookieManagerMac.mm:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::switchNetworkLoaderToNewTestingSession):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):

Source/WTF:

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
Balazs Kelemen [Sun, 4 Nov 2012 00:14:20 +0000 (00:14 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

2nd unreviewed buildfix.

* MiniBrowser/qt/MiniBrowserApplication.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] Remove some now-passing tests. Unreviewed.
Stephen White [Sun, 4 Nov 2012 00:09:12 +0000 (00:09 +0000)]
[chromium] Remove some now-passing tests.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
Balazs Kelemen [Sat, 3 Nov 2012 23:47:28 +0000 (23:47 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Unreviewed buildfix.

* WebKitTestRunner/Target.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
Balazs Kelemen [Sat, 3 Nov 2012 22:52:04 +0000 (22:52 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Reland with build fix.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):  Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] New baselines for no-longer-flaky tests. Unreviewed.
Stephen White [Sat, 3 Nov 2012 22:36:29 +0000 (22:36 +0000)]
[chromium] New baselines for no-longer-flaky tests.  Unreviewed.

* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk1/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png.
* platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] Unreviewed gardening.
Stephen White [Sat, 3 Nov 2012 22:27:24 +0000 (22:27 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133397.
Balazs Kelemen [Sat, 3 Nov 2012 21:42:48 +0000 (21:42 +0000)]
Unreviewed, rolling out r133397.
http://trac.webkit.org/changeset/133397
https://bugs.webkit.org/show_bug.cgi?id=101155

"Broke Qt. No way to force the damn bots to do a clean build.
I'm giving up." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative fix to eliminate flakiness in
Stephen White [Sat, 3 Nov 2012 20:52:17 +0000 (20:52 +0000)]
Speculative fix to eliminate flakiness in
css3/filters/blur-filter-page-scroll-self.html
https://bugs.webkit.org/show_bug.cgi?id=91620.
Suspicion is that a prior test is setting
window.internals.settings.setEnableCompositingForFixedPosition(true),
causing this test to be intermittely run on the GPU, giving different
pixel results depending on test order.

Reviewed by Jochen Eisinger.

Covered by css3/filters/blur-filter-page-scroll-self.html

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a...
Mark Rowe [Sat, 3 Nov 2012 20:48:08 +0000 (20:48 +0000)]
REGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a nil string

Reviewed by Anders Carlsson.

The changes in r132858 introduced an overload of AtomicString::add for CFStrings. However, the overload
that was introduced is not null safe.

* platform/text/cf/AtomicStringCF.cpp:
(WTF::AtomicString::add): Handle a null string by returning a null StringImpl.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
Balazs Kelemen [Sat, 3 Nov 2012 20:36:05 +0000 (20:36 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement HTMLFormElement#requestAutocomplete and associated events
commit-queue [Sat, 3 Nov 2012 16:08:40 +0000 (16:08 +0000)]
Implement HTMLFormElement#requestAutocomplete and associated events
https://bugs.webkit.org/show_bug.cgi?id=100557

Patch by Dan Beam <dbeam@chromium.org> on 2012-11-03
Reviewed by Adam Barth.

Source/WebCore:

Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient.  At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.

Test: fast/forms/form-request-autocomplete.html

* dom/EventNames.h:
(WebCore):

Added autocomplete and autocompleteerror events. The autocomplete event is dispatched after a user adds more
information to a form using the future UI. This is not currently dispatched in any implementation (including Chrome)
but will be in the future. The autocompleteerror event is dispatched when the form has [autocomplete="off"] on the
node being asked for an interactive autocomplete. The user agent may also dispatch this event if it doesn't implement
this API but has turned on the feature flag, can't currently show an autocomplete UI (e.g. running headlessly or in
an HTML notification, security concerns, or any other reason it desires).

* html/HTMLAttributeNames.in:

Added onautocomplete and onautocompleteerror attributes so they can be parsed when creating form elements and used
as event listeners. For example:

  <form onautocomplete="/* when autocomplete succeeds */" autocompleteerror="/* when autocomplete fails */">

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore):

Added m_requestAutocompleteTimer (a timer that's used to dispatch events asynchronously) to the initializer list that
triggers requestAutocompleteTimerFired when it times out.

(WebCore::HTMLFormElement::requestAutocomplete):

Called when HTMLFormElement#requestAutocomplete is called from JS (also see HTMLFormElement.idl) and decides whether
to dispatch an error and exit early (in the case where autocomplete="off") or pass the request on to the
FrameLoaderClient.

(WebCore::HTMLFormElement::finishRequestAutocomplete):

Called when the request for an interactive autocomplete is finished with either a success or error result. This
causes an event to queue and fired after a 0 second delay. Events are owned by HTMLFormElement and reference the
target element (this) until fired.

(WebCore::HTMLFormElement::requestAutocompleteTimerFired):

Called when the event timer runs out to pump the queue of current events. Events are released on dispatch.

(WebCore::HTMLFormElement::parseAttribute):

Encountering onautocomplete or onautocompleteerror attributes while parsing HTMLFormElements now adds event listeners
for autocomplete an autocompleteerror events (respectively) to dispatch the value of the attribute as a script.

* html/HTMLFormElement.h:
(HTMLFormElement):

Added various methods and data members as required by the implementation.

* html/HTMLFormElement.idl:

Added the method requestAutocomplete and associated DOM event handler attributes (onautocomplete/onautocompleteerror)
to HTMLFormElement's public DOM API (unprefixed, as per Ian Hickson's advice). All are require the Conditional
REQUEST_AUTOCOMPLETE to be enabled to be activated.

* loader/EmptyClients.cpp:
(WebCore):
(WebCore::EmptyFrameLoaderClient::didRequestAutocomplete):

Added noop implementation for FrameLoader::didRequestAutocomplete.

* loader/EmptyClients.h:
(EmptyFrameLoaderClient):

Added FrameLoader::didRequestAutocomplete to EmptyFrameLoaderClient interface.

* loader/FrameLoaderClient.h:
(FrameLoaderClient):

Added noop implementation to FrameLoaderClient interface (which is implemented chromium's FrameLoaderLoaderImpl.cpp).

Source/WebKit/chromium:

Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient.  At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.

Test: fast/forms/form-request-autocomplete.html

* public/WebAutofillClient.h:
(WebKit):
(WebAutofillClient):
(WebKit::WebAutofillClient::didRequestAutocomplete):

Added WebAutofillClient::didRequestAutocomplete to chrome's public WebKit interface.

* public/WebFormElement.h:

Added an enum that matches HTMLFormElement::AutocompleteResult (and added compile time assert) and a public method
(WebFormElement::finishRequestAutocomplete) to WebFormElement's public interface.

* src/AssertMatchingEnums.cpp:

Added a compile time assert to guarantee the HTMLFormElement::AutocompleteResult enum matches the
WebFormElement::AutocompleteResult enum.

* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::didRequestAutocomplete):

Implemented the added FrameLoaderClient::didRequestAutocomplete, which simply passes through to the
WebAutofillClient.

* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Implementing FrameLoaderClient::didRequestAutocomplete.

* src/WebFormElement.cpp:
(WebKit::WebFormElement::finishRequestAutocomplete):
(WebKit):

Added WebFormElement::finishRequestAutocomplete to allow chromium's renderer a public API to call to finish the
autocomplete request on a WebFormElement.

LayoutTests:

Adds tests for an initial implementation of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing
for autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently the implementation is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled, so the test
is expected to fail. This test verifies that currently no client implements this method on HTMLFormElement
(HTMLFormElement#requestAutocomplete) and returns. When the chrome-side lands I'll add a success case in
LayoutTests/platform/chromium/fast/forms/ with the expected successful results.

* fast/forms/form-request-autocomplete-expected.txt: Added.
* fast/forms/form-request-autocomplete.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: %d, %i, and %f log formatters have same result
Pavel Feldman [Sat, 3 Nov 2012 15:32:41 +0000 (15:32 +0000)]
Web Inspector: %d, %i, and %f log formatters have same result
https://bugs.webkit.org/show_bug.cgi?id=101148

Reviewed by Alexander Pavlov.

Source/WebCore:

Added separate formatters for %f, %i, %d and %s.

Test: inspector/console/console-message-format.html

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.ConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.ConsoleMessageImpl.prototype.integerFormatter):

LayoutTests:

* inspector/console/console-format-expected.txt:
* inspector/console/console-format.html:
* inspector/console/console-message-format-expected.txt: Added.
* inspector/console/console-message-format.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDecouple Attr logic from ElementAttributeData.
Andreas Kling [Sat, 3 Nov 2012 11:55:58 +0000 (11:55 +0000)]
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>

Reviewed by Antti Koivisto.

Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.

Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.

* dom/Element.h:
* dom/ElementAttributeData.h:
* dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):

    Move everything Attr-related into Element.cpp while simplifying some loops and remove
    conditions that are no longer needed as they used to depend on having an attributeData().

* dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):

    Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().

* dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):

    Remove awkward indirection and let the call site deal with removing the Attr node from
    the Element's list of Attr nodes.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):

    Remove now-unused Element* argument.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r132014-r132047): Webkit Inspector Window docking broken
Pavel Feldman [Sat, 3 Nov 2012 11:36:03 +0000 (11:36 +0000)]
REGRESSION (r132014-r132047): Webkit Inspector Window docking broken
https://bugs.webkit.org/show_bug.cgi?id=101125

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Added "bottom" as default docked state.

* inspector/front-end/DockController.js:
(WebInspector.DockController):

Source/WebKit2:

Migrated from ?docked= to ?dockSide= format.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Shadow] ShadowRoot should be able to know the existence of <content>
shinyak [Sat, 3 Nov 2012 06:40:16 +0000 (06:40 +0000)]
[Shadow] ShadowRoot should be able to know the existence of <content>
https://bugs.webkit.org/show_bug.cgi?id=100921

Reviewed by Dimitri Glazkov.

Source/WebCore:

When <content> is inserted into or removed from a shadow subtree, ShadowRoot counts the number of <content>.
It provides O(1) method to check the existence of <content>.

This is necessary when we implement a fast checking path for distribution invalidation when an element attribute
is changed. Larger context is explained in Bug 100451.

Test: fast/dom/shadow/has-content-elements.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::hasInsertionPoint): Since we track both <content> and <shadow>, we don't need to traverse
all the descendants of ShadowRoot anymore.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::registerContentElement):
(WebCore::ShadowRoot::unregisterContentElement):
(WebCore::ShadowRoot::hasContentElement):
(ShadowRoot):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::insertedInto): When <content> is inserted into ShadowDOM subtree,
we notify it to the ShadowRoot. Note that only active <content> element is counted.
(WebCore):
(WebCore::HTMLContentElement::removedFrom):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* testing/Internals.cpp:
(WebCore::Internals::hasContentElement):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/has-content-elements-expected.txt: Added.
* fast/dom/shadow/has-content-elements.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agosCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in...
commit-queue [Sat, 3 Nov 2012 06:29:26 +0000 (06:29 +0000)]
sCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in the middle
https://bugs.webkit.org/show_bug.cgi?id=99990

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Darin Adler.

Move initialization code for sCurrentPaintTimeStamp to the below of early returns,
because it was not reset after early return.

* page/FrameView.cpp:
(WebCore::FrameView::paintContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build warning in PluginView.cpp on release build
commit-queue [Sat, 3 Nov 2012 06:26:10 +0000 (06:26 +0000)]
Fix build warning in PluginView.cpp on release build
https://bugs.webkit.org/show_bug.cgi?id=101049

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Kentaro Hara.

The protocol, host, port parameters are not used when LOG_DISABLED
Use UNUSED_PARAM macro for removing -Wunused-parameter warning

* plugins/PluginView.cpp:
(WebCore::PluginView::getAuthenticationInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Move soup authentication from GtkAuthenticationDialog to WebCore
Martin Robinson [Sat, 3 Nov 2012 04:38:40 +0000 (04:38 +0000)]
[GTK] Move soup authentication from GtkAuthenticationDialog to WebCore
https://bugs.webkit.org/show_bug.cgi?id=99914

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Move the actual soup authentication code from the GtkAuthenticationDialog to ResourceHandleSoup.
This allows a more generic implementation of authentication, for example, one where a WebKit2
client can completely handle authentication.

No new tests. This does not change behavior.

* platform/gtk/GtkAuthenticationDialog.cpp: Remove references to the SoupPasswordManager, which
is going away in the next release of Gnome. Instead we always assume that the authentication backend has
support for remembering passwords and pass that information along with the answer to the authentication
request.

The rest of the changes to this class can be summarized as:
1. Getting the information from the AuthenticationChallenge instead of directly from the libsoup
   objects.
2. Using the AuthenticationClient to accomplish the authentication instead of talking to libsoup
   directly.
* platform/gtk/GtkAuthenticationDialog.h:
(GtkAuthenticationDialog): Remove members which are no longer used.
* platform/network/ResourceHandle.h:
(ResourceHandle): ResourceHandleSoup now implements the entire AuthenticationClient interface.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveAuthenticationChallenge): Don't handle authentication
for synchronous handles.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Now set the current challenge on
the internal data structure.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Added.
(WebCore::ResourceHandle::receivedCredential): Added.
(WebCore::ResourceHandle::receivedCancellation): Added.
(WebCore::authenicateCallback): Pass the handle as the authentication client.

Source/WebKit/gtk:

The calls which actually authenticate a soup message are gone from the GtkAuthenticationDialog. Since the
GtkAuthenticationDialog exposed by the WebKitSoupAuthentication class in the GTK+ API work without a
ResourceHandle (they are more general), we add a WebKitSoupAuthDialogAuthenticationClient added to avoid
breaking API. This is unused by either Epiphany or internally in WebKitGTK+.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): The authentication dialog
now just takes the AuthenticationChallenge instead of the libsoup objects.
* webkit/webkitsoupauthdialog.cpp:
(WebKitSoupAuthDialogAuthenticationClient): Added this helper.
(sessionAuthenticate): Use the new WebKitSoupAuthDialogAuthenticationClient.

Source/WebKit2:

Instead of passing the libsoup objects to the GtkAuthenticationDialog, pass the
AuthenticationChallenge itself.

* WebProcess/WebCoreSupport/gtk/WebFrameLoaderClientGtk.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImprove CSSParser::setupParser() since the prefix/suffix are literals
Benjamin Poulain [Sat, 3 Nov 2012 03:32:37 +0000 (03:32 +0000)]
Improve CSSParser::setupParser() since the prefix/suffix are literals
https://bugs.webkit.org/show_bug.cgi?id=101107

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-11-02
Reviewed by Andreas Kling.

* css/CSSParser.cpp:
(WebCore::CSSParser::setupParser):
* css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::setupParser):
CSSParser::setupParser() is only used with literals prefix and suffix. We do not have
to compute the length at runtime, we can direclty encode it in the binary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133375.
commit-queue [Sat, 3 Nov 2012 01:48:24 +0000 (01:48 +0000)]
Unreviewed, rolling out r133375.
http://trac.webkit.org/changeset/133375
https://bugs.webkit.org/show_bug.cgi?id=101138

Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

Source/WebCore:

* platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
* platform/text/TextBreakIterator.h:
(WebCore):
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
* platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/RenderText.h:
(WebCore):
* rendering/break_lines.cpp:
(WebCore):
(WebCore::isBreakableSpace):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
* rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):

LayoutTests:

* css3/line-break/line-break-auto-centered-expected.html: Removed.
* css3/line-break/line-break-auto-centered.html: Removed.
* css3/line-break/line-break-auto-half-kana-expected.html: Removed.
* css3/line-break/line-break-auto-half-kana.html: Removed.
* css3/line-break/line-break-auto-hyphens-expected.html: Removed.
* css3/line-break/line-break-auto-hyphens.html: Removed.
* css3/line-break/line-break-auto-inseparables-expected.html: Removed.
* css3/line-break/line-break-auto-inseparables.html: Removed.
* css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
* css3/line-break/line-break-auto-iteration-marks.html: Removed.
* css3/line-break/line-break-auto-postfixes-expected.html: Removed.
* css3/line-break/line-break-auto-postfixes.html: Removed.
* css3/line-break/line-break-auto-prefixes-expected.html: Removed.
* css3/line-break/line-break-auto-prefixes.html: Removed.
* css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
* css3/line-break/line-break-auto-sound-marks.html: Removed.
* css3/line-break/line-break-loose-centered-expected.html: Removed.
* css3/line-break/line-break-loose-centered.html: Removed.
* css3/line-break/line-break-loose-half-kana-expected.html: Removed.
* css3/line-break/line-break-loose-half-kana.html: Removed.
* css3/line-break/line-break-loose-hyphens-expected.html: Removed.
* css3/line-break/line-break-loose-hyphens.html: Removed.
* css3/line-break/line-break-loose-inseparables-expected.html: Removed.
* css3/line-break/line-break-loose-inseparables.html: Removed.
* css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
* css3/line-break/line-break-loose-iteration-marks.html: Removed.
* css3/line-break/line-break-loose-postfixes-expected.html: Removed.
* css3/line-break/line-break-loose-postfixes.html: Removed.
* css3/line-break/line-break-loose-prefixes-expected.html: Removed.
* css3/line-break/line-break-loose-prefixes.html: Removed.
* css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
* css3/line-break/line-break-loose-sound-marks.html: Removed.
* css3/line-break/line-break-normal-centered-expected.html: Removed.
* css3/line-break/line-break-normal-centered.html: Removed.
* css3/line-break/line-break-normal-half-kana-expected.html: Removed.
* css3/line-break/line-break-normal-half-kana.html: Removed.
* css3/line-break/line-break-normal-hyphens-expected.html: Removed.
* css3/line-break/line-break-normal-hyphens.html: Removed.
* css3/line-break/line-break-normal-inseparables-expected.html: Removed.
* css3/line-break/line-break-normal-inseparables.html: Removed.
* css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
* css3/line-break/line-break-normal-iteration-marks.html: Removed.
* css3/line-break/line-break-normal-postfixes-expected.html: Removed.
* css3/line-break/line-break-normal-postfixes.html: Removed.
* css3/line-break/line-break-normal-prefixes-expected.html: Removed.
* css3/line-break/line-break-normal-prefixes.html: Removed.
* css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
* css3/line-break/line-break-normal-sound-marks.html: Removed.
* css3/line-break/line-break-strict-centered-expected.html: Removed.
* css3/line-break/line-break-strict-centered.html: Removed.
* css3/line-break/line-break-strict-half-kana-expected.html: Removed.
* css3/line-break/line-break-strict-half-kana.html: Removed.
* css3/line-break/line-break-strict-hyphens-expected.html: Removed.
* css3/line-break/line-break-strict-hyphens.html: Removed.
* css3/line-break/line-break-strict-inseparables-expected.html: Removed.
* css3/line-break/line-break-strict-inseparables.html: Removed.
* css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
* css3/line-break/line-break-strict-iteration-marks.html: Removed.
* css3/line-break/line-break-strict-postfixes-expected.html: Removed.
* css3/line-break/line-break-strict-postfixes.html: Removed.
* css3/line-break/line-break-strict-prefixes-expected.html: Removed.
* css3/line-break/line-break-strict-prefixes.html: Removed.
* css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
* css3/line-break/line-break-strict-sound-marks.html: Removed.
* platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Removed.
* platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCut overgrown ElementAttributeData bitfield.
Andreas Kling [Sat, 3 Nov 2012 01:39:15 +0000 (01:39 +0000)]
Cut overgrown ElementAttributeData bitfield.
<http://webkit.org/b/101129>

Reviewed by Anders Carlsson.

Make sure the ElementAttributeData bitfield fits into 32 bits. Added a compile-time assertion
to guard against future bloatage.

* dom/ElementAttributeData.cpp:
(SameSizeAsElementAttributeData):
* dom/ElementAttributeData.h:
(ElementAttributeData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
commit-queue [Sat, 3 Nov 2012 01:21:53 +0000 (01:21 +0000)]
[CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
https://bugs.webkit.org/show_bug.cgi?id=100704

Patch by Bear Travis <betravis@adobe.com> on 2012-11-02
Reviewed by Dirk Schulze.

Factor out the pixel snapping behavior from polygon tests to be shared with
the rounded rectangle tests. In sub-pixel layout, the rounding behavior may be
slightly different. This adds a new file, subpixel-utils.js, which tests for the
feature availability and provides functions for rounding at line left & line right.
I've also taken the opportunity to factor the window.internal.settings code into
rounded-rectangle.js and simple-polygon.js.

* fast/exclusions/resources/rounded-rectangle.js:
(simulateShape): Use the new subpixel rounding code.
* fast/exclusions/resources/simple-polygon.js:
(polygonXIntercepts): Ditto.
* fast/exclusions/resources/subpixel-utils.js: Added.
(SubPixelLayout): Adding the SubPixelLayout object which has helper methods
for determining how line edges should round, and whether subpixel layout is enabled.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-001.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-002.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-003.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004-expected.html:
* fast/exclusions/shape-inside/shape-inside-simple-polygon-004.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRebaseline some webaudio tests due to increased precision in AudioParamTimeline
Chris Rogers [Sat, 3 Nov 2012 00:58:19 +0000 (00:58 +0000)]
Rebaseline some webaudio tests due to increased precision in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=101134

Unreviewed rebaseline.

* platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav:
* platform/chromium/webaudio/audiobuffersource-loop-points-expected.wav: Copied from LayoutTests/platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav.
* platform/chromium/webaudio/audiobuffersource-playbackrate-expected.wav: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowebkit-patch rebaseline is broken
Dirk Pranke [Sat, 3 Nov 2012 00:51:03 +0000 (00:51 +0000)]
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101081

Reviewed by Ojan Vafai.

I broke this in r133061 and the unit tests weren't covering this
code path. Fixed the issue and the tests. --results-directory
doesn't make sense for either 'webkit-patch rebaseline' or
'webkit-patch rebaseline-expectations', so we don't want to expose
that as a command line option, but they all call a common
_rebaseline() routine that references options.results_directory,
so we need to set a default value.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations.execute):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline):
(TestRebaseline.test_rebaseline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agolint-webkitpy doesn't autoinstall pylint properly
Dirk Pranke [Sat, 3 Nov 2012 00:50:04 +0000 (00:50 +0000)]
lint-webkitpy doesn't autoinstall pylint properly
https://bugs.webkit.org/show_bug.cgi?id=101106

Reviewed by Ojan Vafai.

Turns out the autoinstalling code for pylint didn't install
pylint's dependencies, and the autoinstaller code didn't work
using nested directories (e.g., "logilab/astng"). Fix those issues,
clean up the autoinstaller code, and add tests to make sure everything
imports successfully.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agonrwt prints an awkward result message for missing results
Dirk Pranke [Sat, 3 Nov 2012 00:48:53 +0000 (00:48 +0000)]
nrwt prints an awkward result message for missing results
https://bugs.webkit.org/show_bug.cgi?id=100915

Reviewed by Ojan Vafai.

Completely rework how we print out the description of
each tests's result - we now will print either "passed" or "failed",
followed by " unexpectedly" if we weren't expecting the result,
followed by a short description of each type of failure that happened
(in parentheses). Also reworked the description of each type of
failure slightly to be clearer.

Also rework the tests to make sure we have coverage of all of the
messages. Examples of the new output are posted as an attachment to
the bug.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureTimeout.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):
(FailureEarlyExit.message):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_result_summary_entry):
(Printer.print_finished_test):
(Printer._result_message):
(Printer._print_unexpected_results):
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVery speculative ArgumentDecoder crash fix
Anders Carlsson [Sat, 3 Nov 2012 00:23:10 +0000 (00:23 +0000)]
Very speculative ArgumentDecoder crash fix
https://bugs.webkit.org/show_bug.cgi?id=101130
<rdar://problem/11917046>

Reviewed by Sam Weinig.

Switch from fastMalloc/fastFree to system malloc/free in the hopes that it'll give more information about
a crash inside TCMalloc when freeing the argument data. (It seems unlikely that this is a bug in TCMalloc, but
switching to the system malloc could potentially give better error reporting).

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrash calling is8Bit() in visitedLinkHash()
Michael Saboff [Sat, 3 Nov 2012 00:02:30 +0000 (00:02 +0000)]
Crash calling is8Bit() in visitedLinkHash()
https://bugs.webkit.org/show_bug.cgi?id=101119

Reviewed by Filip Pizlo.

Added an isEmpty() check to AttributeURL and KURL.

* platform/LinkHash.cpp:
(WebCore::visitedLinkHash):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd support to -webkit-line-break property for CSS3 Text line-break property values...
commit-queue [Fri, 2 Nov 2012 23:55:47 +0000 (23:55 +0000)]
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235

Patch by Glenn Adams <glenn@skynav.com> on 2012-11-02
Reviewed by Eric Seidel.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

Source/WebCore:

Web exposed changes include:
(1) The default (initial) value for -webkit-line-break becomes 'auto', instead of 'normal';
(2) The values 'auto', 'loose', 'normal', and 'strict' are added to -webkit-line-break;
(3) See [2] above for details regarding interpretation.

Tests: css3/line-break/line-break-auto-centered.html
       css3/line-break/line-break-auto-half-kana.html
       css3/line-break/line-break-auto-hyphens.html
       css3/line-break/line-break-auto-inseparables.html
       css3/line-break/line-break-auto-iteration-marks.html
       css3/line-break/line-break-auto-postfixes.html
       css3/line-break/line-break-auto-prefixes.html
       css3/line-break/line-break-auto-sound-marks.html
       css3/line-break/line-break-loose-centered.html
       css3/line-break/line-break-loose-half-kana.html
       css3/line-break/line-break-loose-hyphens.html
       css3/line-break/line-break-loose-inseparables.html
       css3/line-break/line-break-loose-iteration-marks.html
       css3/line-break/line-break-loose-postfixes.html
       css3/line-break/line-break-loose-prefixes.html
       css3/line-break/line-break-loose-sound-marks.html
       css3/line-break/line-break-normal-centered.html
       css3/line-break/line-break-normal-half-kana.html
       css3/line-break/line-break-normal-hyphens.html
       css3/line-break/line-break-normal-inseparables.html
       css3/line-break/line-break-normal-iteration-marks.html
       css3/line-break/line-break-normal-postfixes.html
       css3/line-break/line-break-normal-prefixes.html
       css3/line-break/line-break-normal-sound-marks.html
       css3/line-break/line-break-strict-centered.html
       css3/line-break/line-break-strict-half-kana.html
       css3/line-break/line-break-strict-hyphens.html
       css3/line-break/line-break-strict-inseparables.html
       css3/line-break/line-break-strict-iteration-marks.html
       css3/line-break/line-break-strict-postfixes.html
       css3/line-break/line-break-strict-prefixes.html
       css3/line-break/line-break-strict-sound-marks.html

* platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
(LineBreakIteratorPool):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.

* platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.

* platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().

* rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.

* rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.

* rendering/break_lines.cpp:
(WebCore):
Introduce two (local) enums NBSPBehavior and LooseBehavior for expanding template on nextBreakablePosition
to include loose mode parameter.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Introduce loose mode behavior template parameter to optimize loose mode behavior code path in order
to prevent regression to non loose mode path.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use new template parameter enums described above.
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::nextBreakablePositionLoose):
Introduce two additional 'loose' mode flavors of NBP template expansions.

* rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.

LayoutTests:

* css3/line-break/line-break-auto-centered-expected.html: Added.
* css3/line-break/line-break-auto-centered.html: Added.
* css3/line-break/line-break-auto-half-kana-expected.html: Added.
* css3/line-break/line-break-auto-half-kana.html: Added.
* css3/line-break/line-break-auto-hyphens-expected.html: Added.
* css3/line-break/line-break-auto-hyphens.html: Added.
* css3/line-break/line-break-auto-inseparables-expected.html: Added.
* css3/line-break/line-break-auto-inseparables.html: Added.
* css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
* css3/line-break/line-break-auto-iteration-marks.html: Added.
* css3/line-break/line-break-auto-postfixes-expected.html: Added.
* css3/line-break/line-break-auto-postfixes.html: Added.
* css3/line-break/line-break-auto-prefixes-expected.html: Added.
* css3/line-break/line-break-auto-prefixes.html: Added.
* css3/line-break/line-break-auto-sound-marks-expected.html: Added.
* css3/line-break/line-break-auto-sound-marks.html: Added.
* css3/line-break/line-break-loose-centered-expected.html: Added.
* css3/line-break/line-break-loose-centered.html: Added.
* css3/line-break/line-break-loose-half-kana-expected.html: Added.
* css3/line-break/line-break-loose-half-kana.html: Added.
* css3/line-break/line-break-loose-hyphens-expected.html: Added.
* css3/line-break/line-break-loose-hyphens.html: Added.
* css3/line-break/line-break-loose-inseparables-expected.html: Added.
* css3/line-break/line-break-loose-inseparables.html: Added.
* css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
* css3/line-break/line-break-loose-iteration-marks.html: Added.
* css3/line-break/line-break-loose-postfixes-expected.html: Added.
* css3/line-break/line-break-loose-postfixes.html: Added.
* css3/line-break/line-break-loose-prefixes-expected.html: Added.
* css3/line-break/line-break-loose-prefixes.html: Added.
* css3/line-break/line-break-loose-sound-marks-expected.html: Added.
* css3/line-break/line-break-loose-sound-marks.html: Added.
* css3/line-break/line-break-normal-centered-expected.html: Added.
* css3/line-break/line-break-normal-centered.html: Added.
* css3/line-break/line-break-normal-half-kana-expected.html: Added.
* css3/line-break/line-break-normal-half-kana.html: Added.
* css3/line-break/line-break-normal-hyphens-expected.html: Added.
* css3/line-break/line-break-normal-hyphens.html: Added.
* css3/line-break/line-break-normal-inseparables-expected.html: Added.
* css3/line-break/line-break-normal-inseparables.html: Added.
* css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
* css3/line-break/line-break-normal-iteration-marks.html: Added.
* css3/line-break/line-break-normal-postfixes-expected.html: Added.
* css3/line-break/line-break-normal-postfixes.html: Added.
* css3/line-break/line-break-normal-prefixes-expected.html: Added.
* css3/line-break/line-break-normal-prefixes.html: Added.
* css3/line-break/line-break-normal-sound-marks-expected.html: Added.
* css3/line-break/line-break-normal-sound-marks.html: Added.
* css3/line-break/line-break-strict-centered-expected.html: Added.
* css3/line-break/line-break-strict-centered.html: Added.
* css3/line-break/line-break-strict-half-kana-expected.html: Added.
* css3/line-break/line-break-strict-half-kana.html: Added.
* css3/line-break/line-break-strict-hyphens-expected.html: Added.
* css3/line-break/line-break-strict-hyphens.html: Added.
* css3/line-break/line-break-strict-inseparables-expected.html: Added.
* css3/line-break/line-break-strict-inseparables.html: Added.
* css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
* css3/line-break/line-break-strict-iteration-marks.html: Added.
* css3/line-break/line-break-strict-postfixes-expected.html: Added.
* css3/line-break/line-break-strict-postfixes.html: Added.
* css3/line-break/line-break-strict-prefixes-expected.html: Added.
* css3/line-break/line-break-strict-prefixes.html: Added.
* css3/line-break/line-break-strict-sound-marks-expected.html: Added.
* css3/line-break/line-break-strict-sound-marks.html: Added.
* platform/chromium-linux/css3/line-break/line-break-auto-half-kana-expected.html: Added.
* platform/chromium-linux/css3/line-break/line-break-auto-sound-marks-expected.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReplace NodeRareData hash map with a union on m_renderer
commit-queue [Fri, 2 Nov 2012 23:39:42 +0000 (23:39 +0000)]
Replace NodeRareData hash map with a union on m_renderer
https://bugs.webkit.org/show_bug.cgi?id=100057

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-02
Reviewed by Eric Seidel.

Use a union on Node::m_renderer between NodeRareData* and RenderObject*. This removes
the overhead of accessing rare data and the memory from the map.

This is an 8% improvement on Bindings/get-elements-by-tag-name.html which tested
document.getElementsByTagName and was previously optimized in Bug 90059 for a 5%
improvement. As this is better than even the special casing for document that was
done in that bug, general node list access should see an even greater win.

This reduces the memory usage on nytimes.com by 250k per Bug 101052 by
removing the rare data map overhead.

This is also a 15% improvement on Parser/textarea-parsing.html

By removing the performance overhead of rareData() this patch addresses the performance
issues raised in Bugs 73853, 87034 and 89635.

I ran Parser/html5-full-render.html and there was no performance regression after
tuning Text::recalcTextStyle and the refactor that was done in r132684.

No new tests, this is just a refactor.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Node::Node):
* dom/Element.cpp:
(WebCore::Element::elementRareData):
* dom/Node.cpp:
(WebCore::Node::rareData):
(WebCore::Node::ensureRareData):
(WebCore::Node::clearRareData):
(WebCore::Node::renderBox):
(WebCore::Node::renderBoxModelObject):
(WebCore::Node::reportMemoryUsage):
* dom/Node.h:
(NodeRareDataBase):
  Base class for NodeRareData that knows about the renderer so we can
  inline the accesses in Node.h
(WebCore::NodeRareDataBase::renderer):
(WebCore::NodeRareDataBase::setRenderer):
(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(WebCore):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
* dom/NodeRareData.h:
* dom/NodeRenderStyle.h:
(WebCore::Node::renderStyle):
* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
  This method appears very hot in html5-full-render.html and accessing the
  renderer 4 times caused a 2% performance regression with this patch. I
  reduced it to 1 access and there's no longer any performance regression.
* dom/WebCoreMemoryInstrumentation.cpp:
  Removed tracking of the rare data map memory usage as there is no longer
  a map to track.
* dom/WebCoreMemoryInstrumentation.h:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't instantiate the Java plug-in if it's inactive
Anders Carlsson [Fri, 2 Nov 2012 23:39:33 +0000 (23:39 +0000)]
Don't instantiate the Java plug-in if it's inactive
https://bugs.webkit.org/show_bug.cgi?id=101102
<rdar://problem/12595679>

Reviewed by Andreas Kling.

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
The RenderEmbeddedObject::PluginInactive reason should always result in a button being shown.

(WebChromeClient::unavailablePluginButtonClicked):
If the Java plug-in is inactive, call WKJLReportWebComponentsUsed() to reactivate the plug-in and
then reload the page.

* WebCoreSupport/WebFrameLoaderClient.mm:
(isOracleJavaPlugIn):
(isPlugInInactive):
Helper functions.

(WebFrameLoaderClient::createPlugin):
If the plug-in is inactive, set the appropriate unavailability reason on the renderer.

Source/WebKit2:

* Shared/Plugins/PluginModuleInfo.h:
Add a PluginModuleLoadPolicy enum.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::policyForPlugin):
* UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
Rename shouldBlockPlugin to policyForPlugin and make it return an enum so we can handle inactive plug-ins.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
Add helper function.

(WebKit::PluginInfoStore::policyForPlugin):
If the Java plug-in is inactive, return PluginModuleInactive.

(WebKit::PluginInfoStore::reactivateInactivePlugin):
If the given plug-in is the Java plug-in, call WKJLReportWebComponentsUsed() to reactivate it.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
If the plug-in is inactive, try to reactivate it and reload the page if reactivation succeeded.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath):
* UIProcess/WebProcessProxy.h:
This now returns a plug-in load policy.

* UIProcess/WebProcessProxy.messages.in:
GetPluginPack now returns a load policy enum.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
Change this to a switch statement and always return true for RenderEmbeddedObject::PluginInactive.

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Add RenderEmbeddedObject::PluginInactive to the assertion.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Update now that GetPluginPath returns a pluginLoadPolicy enum.

(WebKit::canPluginHandleResponse):
Ditto.

WebKitLibraries:

Update WebKitSystemInterface to a version that has WKJLReportWebComponentsUsed.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:
Roll WebKitSystemInterface DERPS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Generalising flakiness for fast/forms/formaction-attribute...
Alice Boxhall [Fri, 2 Nov 2012 23:29:21 +0000 (23:29 +0000)]
Unreviewed gardening. Generalising flakiness for fast/forms/formaction-attribute.html.
https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLLInt 32-bit put_by_val ArrayStorage case should use the right register (t3, not...
Filip Pizlo [Fri, 2 Nov 2012 23:19:03 +0000 (23:19 +0000)]
LLInt 32-bit put_by_val ArrayStorage case should use the right register (t3, not t2) for the index in the publicLength updating path
https://bugs.webkit.org/show_bug.cgi?id=101118

Reviewed by Gavin Barraclough.

* llint/LowLevelInterpreter32_64.asm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago [Mac] ResourceHandle changes for network process
Alexey Proskuryakov [Fri, 2 Nov 2012 23:11:25 +0000 (23:11 +0000)]
    [Mac] ResourceHandle changes for network process
        https://bugs.webkit.org/show_bug.cgi?id=101111

        Reviewed by Jessie Berlin.

        With NSOperationQueue, we'll be getting NetworkProcess delegate method calls
        on secondary threads, and so we won't block other requests while consulting with WebProcess.

        * platform/network/NetworkingContext.h:
        (WebCore::NetworkingContext::scheduledRunLoopPairs):
        (WebCore::NetworkingContext::scheduledOperationQueue):
        Add an ability to schedule on an NSOperationQueue. Now that scheduling on run loop
        is not a must, give scheduledRunLoopPairs() a default implementation.

        * platform/network/mac/ResourceHandleMac.mm: Removed isInitializingConnection
        static. It was only used to catch a long obsolete bug with debug logging, and
        cannot work with multiple threads.
        (WebCore::ResourceHandle::start): Scedule on a operation queue if applicable.
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Removed a
        check that used isInitializingConnection.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAutomating gain AudioParam with linearRampToValueAtTime introduces buzzing distortion
Chris Rogers [Fri, 2 Nov 2012 23:10:51 +0000 (23:10 +0000)]
Automating gain AudioParam with linearRampToValueAtTime introduces buzzing distortion
https://bugs.webkit.org/show_bug.cgi?id=100885

Reviewed by Kenneth Russell.

AudioParamTimeline needs to use double-precision for time-values to avoid drift and precision issues.

Covered by existing tests.

* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateTimelineValues):
* Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
* Modules/webaudio/AudioParamTimeline.h:
(AudioParamTimeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Fixing duplicate marking of video-media-source-state-changes...
Alice Boxhall [Fri, 2 Nov 2012 23:09:20 +0000 (23:09 +0000)]
Unreviewed gardening. Fixing duplicate marking of video-media-source-state-changes.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=96725

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDFG::Node::converToStructureTransitionWatchpoint should take kindly to ArrayifyToStru...
Filip Pizlo [Fri, 2 Nov 2012 22:58:40 +0000 (22:58 +0000)]
DFG::Node::converToStructureTransitionWatchpoint should take kindly to ArrayifyToStructure
https://bugs.webkit.org/show_bug.cgi?id=101117

Reviewed by Gavin Barraclough.

We have logic to convert ArrayifyToStructure to StructureTransitionWatchpoint, which is awesome, except
that previously convertToStructureTransitionWatchpoint was (a) asserting that it never saw an
ArrayifyToStructure and (b) would incorrectly create a ForwardStructureTransitionWatchpoint if it did.

* dfg/DFGNode.h:
(JSC::DFG::Node::convertToStructureTransitionWatchpoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReduce redundant code in SimpleFontData[platform]
schenney [Fri, 2 Nov 2012 22:30:14 +0000 (22:30 +0000)]
Reduce redundant code in SimpleFontData[platform]
https://bugs.webkit.org/show_bug.cgi?id=97245

Reviewed by Eric Seidel.

Move duplicated code out of platform specific files and into the common file.
This represents all of the methods in SimpleFontData that do not have genuine
platform specific code.

No new tests because there is no change at all in the functionality.

* platform/graphics/SimpleFontData.cpp:
(WebCore):
(WebCore::SimpleFontData::smallCapsFontData): Implementation from platform files.
(WebCore::SimpleFontData::emphasisMarkFontData): Implementation from platform files.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore): Removed common code.
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore): Removed common code.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore): Removed common code.
* platform/graphics/pango/SimpleFontDataPango.cpp:
(WebCore): Removed common code.
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore): Removed common code.
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore): Removed common code.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore): Removed common code.
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore): Removed common code.
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore): Removed common code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDFG::SpeculativeJIT::typedArrayDescriptor should use the Float64Array descriptor...
Filip Pizlo [Fri, 2 Nov 2012 22:27:19 +0000 (22:27 +0000)]
DFG::SpeculativeJIT::typedArrayDescriptor should use the Float64Array descriptor for Float64Arrays
https://bugs.webkit.org/show_bug.cgi?id=101114

Reviewed by Gavin Barraclough.

As in https://bugs.webkit.org/show_bug.cgi?id=101112, this was only wrong when Float64Array descriptors
hadn't been initialized yet. That happens rarely, but when it does happen, we would crash.

This would also become much more wrong if we ever put type size info (num bytes, etc) in the descriptor
and used that directly. So it's good to fix it.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Mark video-media-source-state-changes.html as flaky.
Alice Boxhall [Fri, 2 Nov 2012 22:25:16 +0000 (22:25 +0000)]
Unreviewed gardening. Mark video-media-source-state-changes.html as flaky.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJIT::privateCompileGetByVal should use the uint8ClampedArrayDescriptor for compiling...
Filip Pizlo [Fri, 2 Nov 2012 22:21:34 +0000 (22:21 +0000)]
JIT::privateCompileGetByVal should use the uint8ClampedArrayDescriptor for compiling accesses to Uint8ClampedArrays
https://bugs.webkit.org/show_bug.cgi?id=101112

Reviewed by Gavin Barraclough.

The only reason why the code was wrong to use uint8ArrayDescriptor instead is that if we're just using
Uint8ClampedArrays then the descriptor for Uint8Array may not have been initialized.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMarkedBlocks should use something other than the mark bits to indicate liveness for...
Mark Hahnenberg [Fri, 2 Nov 2012 22:14:28 +0000 (22:14 +0000)]
MarkedBlocks should use something other than the mark bits to indicate liveness for newly allocated objects
https://bugs.webkit.org/show_bug.cgi?id=100877

Reviewed by Filip Pizlo.

Currently when we canonicalize cell liveness data in MarkedBlocks, we set the mark bit for every cell in the
block except for those in the free list. This allows us to consider objects that were allocated since the
previous collection to be considered live until they have a chance to be properly marked by the collector.

If we want to use the mark bits to signify other types of information, e.g. using sticky mark bits for generational
collection, we will have to keep track of newly allocated objects in a different fashion when we canonicalize cell liveness.

One method would be to allocate a separate set of bits while canonicalizing liveness data. These bits would
track the newly allocated objects in the block separately from those objects who had already been marked. We would
then check these bits, along with the mark bits, when determining liveness.

* heap/Heap.h:
(Heap):
(JSC::Heap::isLive): We now check for the presence of the newlyAllocated Bitmap.
(JSC):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep): We clear the newlyAllocated Bitmap if we're creating a free list. This
will happen if we canonicalize liveness data for some other reason than collection (e.g. forEachCell) and
then start allocating again.
(JSC::SetNewlyAllocatedFunctor::SetNewlyAllocatedFunctor):
(SetNewlyAllocatedFunctor):
(JSC::SetNewlyAllocatedFunctor::operator()): We set the newlyAllocated bits for all the objects
that aren't already marked. We undo the bits for the objects in the free list later in canonicalizeCellLivenessData.
(JSC::MarkedBlock::canonicalizeCellLivenessData): We should never have a FreeListed block with a newlyAllocated Bitmap.
We allocate the new Bitmap, set the bits for all the objects that aren't already marked, and then unset all of the
bits for the items currently in the FreeList.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::clearMarks): We clear the newlyAllocated bitmap if it exists because at this point we don't need it
any more.
(JSC::MarkedBlock::isEmpty): If we have some objects that are newlyAllocated, we are not empty.
(JSC::MarkedBlock::isNewlyAllocated):
(JSC):
(JSC::MarkedBlock::setNewlyAllocated):
(JSC::MarkedBlock::clearNewlyAllocated):
(JSC::MarkedBlock::isLive): We now check the newlyAllocated Bitmap, if it exists, when determining liveness of a cell in
a block that is Marked.
* heap/WeakBlock.cpp:
(JSC::WeakBlock::visit): We need to make sure we don't finalize objects that are in the newlyAllocated Bitmap.
(JSC::WeakBlock::reap): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJIT::privateCompileGetByVal should use MacroAssemblerCodePtr::createFromExecutableAdd...
Filip Pizlo [Fri, 2 Nov 2012 22:12:40 +0000 (22:12 +0000)]
JIT::privateCompileGetByVal should use MacroAssemblerCodePtr::createFromExecutableAddress like JIT::privateCompilePutByVal
https://bugs.webkit.org/show_bug.cgi?id=101109

Reviewed by Gavin Barraclough.

This fixes crashes on ARMv7 resulting from the return address already being tagged with the THUMB2 bit.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoreport-blocked-uri-cross-origin.html is failing
tsepez [Fri, 2 Nov 2012 22:01:49 +0000 (22:01 +0000)]
report-blocked-uri-cross-origin.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101096

Reviewed by Adam Barth.

Don't actually create a report file during the syntax-only test for when
the report directive comes before the mode directive in an X-XSS-Protection
header. Thus, we avoid having to clean it up later.

* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomemory-instrumentation-cached-images.html is crashing
Adam Barth [Fri, 2 Nov 2012 21:54:54 +0000 (21:54 +0000)]
memory-instrumentation-cached-images.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=101103

Unreviewed.

Restore code deleted in http://trac.webkit.org/changeset/133331.

* bindings/v8/IntrusiveDOMWrapperMap.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnable SUBPIXEL_LAYOUT on Mac
Simon Fraser [Fri, 2 Nov 2012 21:35:02 +0000 (21:35 +0000)]
Enable SUBPIXEL_LAYOUT on Mac
https://bugs.webkit.org/show_bug.cgi?id=101076

Reviewed by Dave Hyatt.

Source/JavaScriptCore:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Update results affected by subpixel layout.

* platform/mac/accessibility/svg-bounds-expected.txt:
* platform/mac/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/platform/mac/accessibility/svg-bounds-expected.txt.
* platform/mac/animations/keyframes-comma-separated-expected.txt: Added.
* platform/mac/compositing/direct-image-compositing-expected.txt:
* platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
* platform/mac/compositing/shadows/shadow-drawing-expected.txt:
* platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/mac/css1/basic/inheritance-expected.txt:
* platform/mac/css1/box_properties/acid_test-expected.txt:
* platform/mac/css1/box_properties/clear_float-expected.txt:
* platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
* platform/mac/css1/box_properties/margin-expected.txt:
* platform/mac/css1/box_properties/margin_bottom-expected.txt:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/margin_top-expected.txt:
* platform/mac/css1/box_properties/padding-expected.txt:
* platform/mac/css1/box_properties/padding_bottom-expected.txt:
* platform/mac/css1/box_properties/padding_left-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/css1/box_properties/padding_top-expected.txt:
* platform/mac/css1/box_properties/width-expected.txt:
* platform/mac/css1/color_and_background/background_attachment-expected.txt:
* platform/mac/css1/font_properties/font-expected.txt:
* platform/mac/css1/font_properties/font_size-expected.txt:
* platform/mac/css1/font_properties/font_weight-expected.txt:
* platform/mac/css1/formatting_model/floating_elements-expected.txt:
* platform/mac/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/mac/css1/formatting_model/inline_elements-expected.txt:
* platform/mac/css1/formatting_model/replaced_elements-expected.txt:
* platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
* platform/mac/css1/text_properties/text_indent-expected.txt:
* platform/mac/css1/text_properties/vertical_align-expected.txt:
* platform/mac/css1/units/percentage_units-expected.txt:
* platform/mac/css1/units/rounding-expected.txt: Added.
* platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt:
* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt:
* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt:
* platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
* platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
* platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
* platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
* platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
* platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
* platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
* platform/mac/css2.1/t1506-c525-font-wt-00-b-expected.txt:
* platform/mac/css2.1/t1508-c527-font-09-b-expected.txt:
* platform/mac/css2.1/t1602-c43-center-00-d-ag-expected.txt:
* platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
* platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
* platform/mac/editing/inserting/editing-empty-divs-expected.txt:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/4397952-expected.txt:
* platform/mac/editing/selection/5240265-expected.txt:
* platform/mac/editing/selection/5354455-2-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
* platform/mac/editing/selection/caret-ltr-expected.txt:
* platform/mac/editing/selection/caret-ltr-right-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/editing/selection/caret-rtl-right-expected.txt:
* platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
* platform/mac/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt:
* platform/mac/editing/selection/selection-button-text-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/mac/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/mac/fast/block/basic/001-expected.txt:
* platform/mac/fast/block/basic/011-expected.txt:
* platform/mac/fast/block/basic/014-expected.txt:
* platform/mac/fast/block/basic/015-expected.txt:
* platform/mac/fast/block/basic/016-expected.txt:
* platform/mac/fast/block/basic/019-expected.txt:
* platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
* platform/mac/fast/block/float/013-expected.txt:
* platform/mac/fast/block/float/025-expected.txt:
* platform/mac/fast/block/float/026-expected.txt:
* platform/mac/fast/block/float/027-expected.txt:
* platform/mac/fast/block/float/028-expected.txt:
* platform/mac/fast/block/float/032-expected.txt:
* platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt:
* platform/mac/fast/block/float/float-avoidance-expected.txt:
* platform/mac/fast/block/float/float-in-float-painting-expected.txt:
* platform/mac/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/mac/fast/block/margin-collapse/100-expected.txt:
* platform/mac/fast/block/margin-collapse/103-expected.txt:
* platform/mac/fast/block/positioning/047-expected.txt:
* platform/mac/fast/block/positioning/051-expected.txt:
* platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
* platform/mac/fast/borders/bidi-002-expected.txt:
* platform/mac/fast/borders/bidi-009a-expected.txt:
* platform/mac/fast/borders/bidi-012-expected.txt:
* platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Added.
* platform/mac/fast/borders/rtl-border-01-expected.txt:
* platform/mac/fast/borders/rtl-border-02-expected.txt:
* platform/mac/fast/borders/rtl-border-03-expected.txt:
* platform/mac/fast/box-sizing/box-sizing-expected.txt:
* platform/mac/fast/canvas/webgl/oes-element-index-uint-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
* platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/mac/fast/css-generated-content/011-expected.txt:
* platform/mac/fast/css-generated-content/012-expected.txt:
* platform/mac/fast/css-generated-content/013-expected.txt:
* platform/mac/fast/css-generated-content/014-expected.txt:
* platform/mac/fast/css-generated-content/015-expected.txt:
* platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
* platform/mac/fast/css/003-expected.txt:
* platform/mac/fast/css/004-expected.txt:
* platform/mac/fast/css/005-expected.txt:
* platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
* platform/mac/fast/css/continuationCrash-expected.txt:
* platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt:
* platform/mac/fast/css/css2-system-fonts-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/ex-after-font-variant-expected.txt:
* platform/mac/fast/css/fieldset-display-row-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/h1-in-section-elements-expected.txt:
* platform/mac/fast/css/hsl-color-expected.txt:
* platform/mac/fast/css/hsla-color-expected.txt:
* platform/mac/fast/css/inline-properties-important-expected.txt:
* platform/mac/fast/css/invalid-percentage-property-expected.txt:
* platform/mac/fast/css/large-number-round-trip-expected.txt: Added.
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/percentage-non-integer-expected.txt:
* platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
* platform/mac/fast/css/rgb-float-expected.txt:
* platform/mac/fast/css/rtl-ordering-expected.txt:
* platform/mac/fast/css/selector-set-attribute-expected.txt:
* platform/mac/fast/css/text-align-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
* platform/mac/fast/css/transform-default-parameter-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
* platform/mac/fast/css/word-space-extra-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
* platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
* platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
* platform/mac/fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/early-acid3-65-excerpt-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/early-acid3-66-excerpt-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/insert-row-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/rows-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/tBodies-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
* platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
* platform/mac/fast/dynamic/012-expected.txt:
* platform/mac/fast/dynamic/anchor-lock-expected.txt:
* platform/mac/fast/dynamic/subtree-parent-static-y-expected.txt:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
* platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
* platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
* platform/mac/fast/events/document-elementFromPoint-expected.txt: Added.
* platform/mac/fast/events/pointer-events-2-expected.txt:
* platform/mac/fast/flexbox/flex-hang-expected.txt: Added.
* platform/mac/fast/forms/001-expected.txt:
* platform/mac/fast/forms/006-expected.txt:
* platform/mac/fast/forms/007-expected.txt:
* platform/mac/fast/forms/basic-buttons-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
* platform/mac/fast/forms/blankbuttons-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
* platform/mac/fast/forms/button-default-title-expected.txt:
* platform/mac/fast/forms/button-generated-content-expected.txt:
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/button-sizes-expected.txt:
* platform/mac/fast/forms/button-style-color-expected.txt:
* platform/mac/fast/forms/button-table-styles-expected.txt:
* platform/mac/fast/forms/button-text-transform-expected.txt:
* platform/mac/fast/forms/button-white-space-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/fieldset-align-expected.txt:
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
* platform/mac/fast/forms/fieldset-with-float-expected.txt:
* platform/mac/fast/forms/file/file-input-direction-expected.txt:
* platform/mac/fast/forms/file/file-input-disabled-expected.txt:
* platform/mac/fast/forms/file/input-file-re-render-expected.txt:
* platform/mac/fast/forms/float-before-fieldset-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove-expected.txt:
* platform/mac/fast/forms/formmove2-expected.txt:
* platform/mac/fast/forms/formmove3-expected.txt:
* platform/mac/fast/forms/indeterminate-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-button-sizes-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/mac/fast/forms/menulist-clip-expected.txt:
* platform/mac/fast/forms/minWidthPercent-expected.txt:
* platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/mac/fast/forms/range/slider-mouse-events-expected.txt: Added.
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/select-baseline-expected.txt:
* platform/mac/fast/forms/targeted-frame-submission-expected.txt:
* platform/mac/fast/forms/textAreaLineHeight-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
* platform/mac/fast/gradients/crash-on-zero-radius-expected.txt:
* platform/mac/fast/gradients/generated-gradients-expected.txt:
* platform/mac/fast/gradients/radial-centered-expected.txt:
* platform/mac/fast/gradients/simple-gradients-expected.txt:
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/mac/fast/html/details-add-child-1-expected.txt:
* platform/mac/fast/html/details-add-child-2-expected.txt:
* platform/mac/fast/html/details-add-details-child-1-expected.txt:
* platform/mac/fast/html/details-add-details-child-2-expected.txt:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-1-expected.txt:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-10-expected.txt:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-2-expected.txt:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-3-expected.txt:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-4-expected.txt:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-5-expected.txt:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-6-expected.txt:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-7-expected.txt:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-8-expected.txt:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-9-expected.txt:
* platform/mac/fast/html/details-add-summary-child-1-expected.txt:
* platform/mac/fast/html/details-add-summary-child-2-expected.txt:
* platform/mac/fast/html/details-marker-style-expected.txt: Added.
* platform/mac/fast/html/details-nested-1-expected.txt:
* platform/mac/fast/html/details-nested-2-expected.txt:
* platform/mac/fast/html/details-no-summary1-expected.txt:
* platform/mac/fast/html/details-no-summary2-expected.txt:
* platform/mac/fast/html/details-no-summary3-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open1-expected.txt:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open3-expected.txt:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-open5-expected.txt:
* platform/mac/fast/html/details-open6-expected.txt:
* platform/mac/fast/html/details-position-expected.txt:
* platform/mac/fast/html/details-remove-child-1-expected.txt:
* platform/mac/fast/html/details-remove-child-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-expected.txt:
* platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
* platform/mac/fast/html/details-replace-summary-child-expected.txt:
* platform/mac/fast/html/details-replace-text-expected.txt:
* platform/mac/fast/html/details-writing-mode-expected.txt:
* platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
* platform/mac/fast/images/zoomed-img-size-expected.txt: Added.
* platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/mac/fast/inline/002-expected.txt:
* platform/mac/fast/inline/continuation-outlines-expected.txt:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
* platform/mac/fast/inline/inline-box-background-expected.txt:
* platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
* platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/mac/fast/inline/outline-continuations-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
* platform/mac/fast/invalid/010-expected.txt:
* platform/mac/fast/invalid/014-expected.txt:
* platform/mac/fast/invalid/junk-data-expected.txt:
* platform/mac/fast/invalid/missing-end-tag-expected.txt:
* platform/mac/fast/invalid/nestedh3s-expected.txt:
* platform/mac/fast/invalid/residual-style-expected.txt:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/008-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
* platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Added.
* platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
* platform/mac/fast/multicol/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/float-multicol-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/nested-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/overflow-across-columns-expected.txt.
* platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
* platform/mac/fast/multicol/scrolling-overflow-expected.txt:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-flexbox-expected.txt: Added.
* platform/mac/fast/multicol/span/clone-summary-expected.txt: Added.
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
* platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/mac/fast/overflow/007-expected.txt:
* platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/mac/fast/overflow/infiniteRecursionGuard-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/mac/fast/overflow/overflow_hidden-expected.txt:
* platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* platform/mac/fast/overflow/scrollRevealButton-expected.txt:
* platform/mac/fast/parser/bad-xml-slash-expected.txt:
* platform/mac/fast/parser/entity-comment-in-style-expected.txt:
* platform/mac/fast/parser/style-script-head-test-expected.txt: Added.
* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
* platform/mac/fast/reflections/reflection-with-zoom-expected.txt:
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/repaint/control-clip-expected.txt:
* platform/mac/fast/repaint/delete-into-nested-block-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
* platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/mac/fast/repaint/transform-translate-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/table-percent-height-expected.txt: Added.
* platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
* platform/mac/fast/replaced/width100percent-button-expected.txt:
* platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/mac/fast/replaced/width100percent-radio-expected.txt:
* platform/mac/fast/ruby/ruby-inline-table-expected.txt:
* platform/mac/fast/selectors/032-expected.txt:
* platform/mac/fast/selectors/166-expected.txt:
* platform/mac/fast/selectors/unqualified-hover-quirks-expected.txt:
* platform/mac/fast/selectors/unqualified-hover-strict-expected.txt:
* platform/mac/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Added.
* platform/mac/fast/table/009-expected.txt:
* platform/mac/fast/table/014-expected.txt:
* platform/mac/fast/table/040-expected.txt:
* platform/mac/fast/table/040-vertical-expected.txt:
* platform/mac/fast/table/041-expected.txt:
* platform/mac/fast/table/absolute-table-at-bottom-expected.txt:
* platform/mac/fast/table/append-cells2-expected.txt:
* platform/mac/fast/table/border-collapsing/004-expected.txt:
* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
* platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
* platform/mac/fast/table/nested-percent-height-table-expected.txt:
* platform/mac/fast/table/overflowHidden-expected.txt:
* platform/mac/fast/table/percent-heights-expected.txt:
* platform/mac/fast/table/remove-td-display-none-expected.txt:
* platform/mac/fast/table/table-display-types-strict-expected.txt:
* platform/mac/fast/table/table-hspace-align-center-expected.txt:
* platform/mac/fast/text/basic/012-expected.txt:
* platform/mac/fast/text/basic/013-expected.txt:
* platform/mac/fast/text/basic/generic-family-reset-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/thai-line-breaks-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/line-breaks-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt:
* platform/mac/fast/text/whitespace/024-expected.txt:
* platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
* platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
* platform/mac/fast/transforms/transforms-with-zoom-expected.txt: Added.
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/mac/fast/writing-mode/fieldsets-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
* platform/mac/http/tests/cookies/multiple-cookies-expected.txt: Added.
* platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
* platform/mac/http/tests/misc/acid3-expected.txt: Added.
* platform/mac/http/tests/misc/iframe404-expected.txt:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
* platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Added.
* platform/mac/http/tests/webarchive/test-preload-resources-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/controls-without-preload-expected.txt:
* platform/mac/media/media-controls-clone-expected.txt:
* platform/mac/media/media-element-play-after-eos-expected.txt: Added.
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-empty-source-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:
* platform/mac/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
* platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/platform/mac/fast/text/x-height-expected.txt: Added.
* platform/mac/plugins/netscape-dom-access-and-reload-expected.txt: Added.
* platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
* platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
* platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
* platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
* platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt.
* platform/mac/svg/custom/bug45331-expected.txt:
* platform/mac/svg/custom/fractional-rects-expected.txt: Added.
* platform/mac/svg/custom/image-parent-translation-expected.txt:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/custom/js-update-container-expected.txt: Added.
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/custom/object-sizing-expected.txt:
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/path-bad-data-expected.txt:
* platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Added.
* platform/mac/svg/custom/use-font-face-crash-expected.txt:
* platform/mac/svg/custom/viewBox-hit-expected.txt: Added.
* platform/mac/svg/hixie/error/012-expected.txt:
* platform/mac/svg/text/small-fonts-in-html5-expected.txt:
* platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
* platform/mac/svg/transforms/svg-css-transforms-expected.txt:
* platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: Added.
* platform/mac/svg/webarchive/svg-feimage-subresources-expected.txt: Added.
* platform/mac/svg/webarchive/svg-script-subresouces-expected.txt: Added.
* platform/mac/svg/wicd/rightsizing-grid-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-a-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
* platform/mac/svg/wicd/test-scalable-background-image1-expected.txt:
* platform/mac/svg/wicd/test-scalable-background-image2-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
* platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug10269-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
* platform/mac/tables/mozilla/bugs/bug11384q-expected.txt:
* platform/mac/tables/mozilla/bugs/bug11384s-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
* platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
* platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
* platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17130-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17130-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
* platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3309-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
* platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
* platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
* platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46480-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46480-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
* platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
* platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
* platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
* platform/mac/tables/mozilla/bugs/bug67915-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7112-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7112-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac/tables/mozilla/bugs/bug8032-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug83786-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9271-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9271-2-expected.txt:
* platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* platform/mac/tables/mozilla/core/bloomberg-expected.txt:
* platform/mac/tables/mozilla/core/margins-expected.txt:
* platform/mac/tables/mozilla/core/misc-expected.txt:
* platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/mac/tables/mozilla/other/move_row-expected.txt:
* platform/mac/tables/mozilla/other/test3-expected.txt:
* platform/mac/tables/mozilla/other/test6-expected.txt:
* platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/mac/transforms/2d/hindi-rotated-expected.txt:
* platform/mac/transforms/2d/zoom-menulist-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-opacity-expected.txt: Added.
* platform/mac/transforms/svg-vs-css-expected.txt:
* platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt: Added.
* platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.txt: Added.
* platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.txt: Added.
* platform/mac/webarchive/archive-empty-frame-dom-expected.txt: Added.
* platform/mac/webarchive/archive-empty-frame-source-expected.txt: Added.
* platform/mac/webarchive/archive-with-unencoded-url-expected.txt: Added.
* platform/mac/webarchive/css-page-rule-crash-expected.txt: Added.
* platform/mac/webarchive/doctype-expected.txt: Added.
* platform/mac/webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
* platform/mac/webarchive/test-body-background-expected.txt: Added.
* platform/mac/webarchive/test-css-import-expected.txt: Added.
* platform/mac/webarchive/test-duplicate-resources-expected.txt: Added.
* platform/mac/webarchive/test-frameset-expected.txt: Added.
* platform/mac/webarchive/test-img-src-expected.txt: Added.
* platform/mac/webarchive/test-input-src-expected.txt: Added.
* platform/mac/webarchive/test-link-href-expected.txt: Added.
* platform/mac/webarchive/test-link-rel-icon-beforeload-expected.txt: Added.
* platform/mac/webarchive/test-object-data-expected.txt: Added.
* platform/mac/webarchive/test-script-src-expected.txt: Added.
* platform/mac/webarchive/test-table-background-expected.txt: Added.
* platform/mac/webarchive/test-td-background-expected.txt: Added.
* platform/mac/webarchive/test-xml-stylesheet-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Chromium] Unreviewed gardening. Some new Mac baselines, and
Stephen White [Fri, 2 Nov 2012 21:32:43 +0000 (21:32 +0000)]
[Chromium] Unreviewed gardening.  Some new Mac baselines, and
add real bugs in place of Bug(senorblanco).

* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[BlackBerry] Fix compile-time warning of a possible empty-body if statement
commit-queue [Fri, 2 Nov 2012 21:32:01 +0000 (21:32 +0000)]
[BlackBerry] Fix compile-time warning of a possible empty-body if statement
https://bugs.webkit.org/show_bug.cgi?id=101095

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.
Internally reviewed by Jeff Rogers.

BBLOG might be compiled out leaving an if statement with an empty
body. This is giving us a warning at the moment. Simply putting braces
around it will fail as well because then we'd have braces around a
single-line if. So, in following with the style observed in other parts
of BackingStore.cpp, break up the log message and add braces.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notifica...
Tony Chang [Fri, 2 Nov 2012 21:28:37 +0000 (21:28 +0000)]
[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
https://bugs.webkit.org/show_bug.cgi?id=100887

Reviewed by Ojan Vafai.

The tests were racing the load time of js-test-post.js and the test completion.
Previously, js-test-post.js would already be in the cache, so it would always load first.
Now that we clear the cache, sometimes js-test-post.js would run after the other test output.
Fix this by setting window.jsTestIsAsync = true and calling finishJSTest() when the test
ends (this delays the js-test-post.js output until finishJSTest() is called).

* platform/chromium/TestExpectations:
* platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt:
* platform/chromium/accessibility/is-ignored-change-sends-notification.html:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html:
* platform/chromium/accessibility/text-change-notification-expected.txt:
* platform/chromium/accessibility/text-change-notification.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed baselines for chromium-mac.
vollick [Fri, 2 Nov 2012 21:14:26 +0000 (21:14 +0000)]
Unreviewed baselines for chromium-mac.

* platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed baselines for chromium-mac.
vollick [Fri, 2 Nov 2012 21:12:06 +0000 (21:12 +0000)]
Unreviewed baselines for chromium-mac.

* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[BlackBerry] Optimize backspace key handling
commit-queue [Fri, 2 Nov 2012 21:11:44 +0000 (21:11 +0000)]
[BlackBerry] Optimize backspace key handling
https://bugs.webkit.org/show_bug.cgi?id=101083

PR233591
Optimize backspace key handling. Some of these calls are not
required by IMF since the input_service already processes the backspace key
and updates the state before passing us the key.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.

Blocking calls with a flag that we clear immediately after
processing a backspace keydown.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient...
commit-queue [Fri, 2 Nov 2012 21:07:51 +0000 (21:07 +0000)]
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
https://bugs.webkit.org/show_bug.cgi?id=101082

Internal PR: 235410.
Patch suggested by George Staikos, prepared by Lyon Chen.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-02
Reviewed by Yong Li.

ResourceHandle::cancel() should call setClient(0) to close the window
during which it has been cancelled but its client is still there and can
be called.

No new tests as it's a code improvement without obvious bug.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::cancel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowebkitpy: clean up logging in common.system.autoinstall
Dirk Pranke [Fri, 2 Nov 2012 20:55:01 +0000 (20:55 +0000)]
webkitpy: clean up logging in common.system.autoinstall
https://bugs.webkit.org/show_bug.cgi?id=101090

Reviewed by Ojan Vafai.

This module logged way too much, much of which was logging that
was either really redundant or useful only during initial development.
This patch deletes a lot of code and tweaks the remaining log messages
to be more useful now.

Also, clean up a bunch of lint errors and warnings.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller.__init__):
(AutoInstaller._write_file):
(AutoInstaller._set_up_target_dir):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._url_downloaded_path):
(AutoInstaller._is_downloaded):
(AutoInstaller._record_url_downloaded):
(AutoInstaller._extract_targz):
(AutoInstaller._extract_all):
(AutoInstaller._unzip):
(AutoInstaller._download_to_stream):
(AutoInstaller._download):
(AutoInstaller._install):
(AutoInstaller.install):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Mark report-blocked-uri-cross-origin.html as failing.
Alice Boxhall [Fri, 2 Nov 2012 20:53:13 +0000 (20:53 +0000)]
Unreviewed gardening. Mark report-blocked-uri-cross-origin.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=101096

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a PluginInactive plug-in unavailability reason
Anders Carlsson [Fri, 2 Nov 2012 20:43:27 +0000 (20:43 +0000)]
Add a PluginInactive plug-in unavailability reason
https://bugs.webkit.org/show_bug.cgi?id=101089

Reviewed by Sam Weinig.

Source/WebCore:

This is to be used by Mac WebKit and WebKit2 shortly.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/LocalizedStrings.h:
(WebCore):
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::inactivePluginText):
(WebCore):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:

Source/WebKit/chromium:

* src/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):

Source/WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMAKE] Remove QNX specific section
Rob Buis [Fri, 2 Nov 2012 20:27:02 +0000 (20:27 +0000)]
[CMAKE] Remove QNX specific section
https://bugs.webkit.org/show_bug.cgi?id=101063

Reviewed by Daniel Bates.

We do not need the QNX section anymore, so also remove the FEATURE_DEFINES_CSS variable as it
equals FEATURE_DEFINES_WITH_SPACE_SEPARATOR.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agovisitedHashLink() converts 8 bit URLs and attributes to 16 bits.
Michael Saboff [Fri, 2 Nov 2012 20:21:56 +0000 (20:21 +0000)]
visitedHashLink() converts 8 bit URLs and attributes to 16 bits.
https://bugs.webkit.org/show_bug.cgi?id=101014

Reviewed by Geoffrey Garen.

Converted most of the static methods to templated based on character type.  Changed visitedHashLink to
check bitness of both the base URL and attribute.  If both are 8 bit, then we process using the LChar
version of the templated methods.  Otherwise we use the 16 bit flavor.

Changes covered by existing tests.

* platform/LinkHash.cpp:
(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::containsColonSlashSlash):
(WebCore::squeezeOutNullCharacters):
(WebCore::cleanSlashDotDotSlashes):
(WebCore::mergeDoubleSlashes):
(WebCore::cleanSlashDotSlashes):
(WebCore::cleanPath):
(WebCore::matchLetter):
(WebCore::needsTrailingSlash):
(WebCore::visitedURLInline):
(WebCore::visitedURL):
(WebCore::visitedLinkHash):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRegExp.prototype.toString Should Produce an 8 bit JSString if possible.
Michael Saboff [Fri, 2 Nov 2012 20:20:50 +0000 (20:20 +0000)]
RegExp.prototype.toString Should Produce an 8 bit JSString if possible.
https://bugs.webkit.org/show_bug.cgi?id=101003

Reviewed by Geoffrey Garen.

Took the logic of regExpObjectSource() and created two templated helpers that uses the
source character type when appending to the StringBuilder.

* runtime/RegExpObject.cpp:
(JSC::appendLineTerminatorEscape): Checks line terminate type to come up with escaped version.
(JSC::regExpObjectSourceInternal): Templated version of original.
(JSC::regExpObjectSource): Wrapper function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSupport invalidation tracking for composited layers
vollick [Fri, 2 Nov 2012 19:58:52 +0000 (19:58 +0000)]
Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801

Reviewed by Simon Fraser.

GraphicsLayers now store invalidated rects and can include them in
the layer tree dump.

Source/WebCore:

Test: compositing/repaint/invalidations-on-composited-layers.html

* WebCore.exp.in:
  Exports FrameView::resetTrackedRepaints()
* page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
  Notifies each compositor that we are starting/stopping repaints.
(WebCore::FrameView::resetTrackedRepaints):
  Moved implementation to the cpp file.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
  Clears the repaint rects associated with this layer.
(WebCore::GraphicsLayer::resetTrackedRepaints):
  Clears the repaint rects associated with this layer.
  Note that the repaint rects are stored in a statically allocated
  HashMap to avoid using space on the graphics layers.
(WebCore::GraphicsLayer::addRepaintRect):
  Adds a repaint rect to list associated with this layer in the
  hash map mentioned above.
(WebCore::GraphicsLayer::dumpProperties):
  This has been modified to include the repaint rects in the dump
  if they've been requested.
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::isTrackingRepaints):
  This is how graphics layers check if repaint tracking is happening.
  Returns false by default.
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
  Now calls GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setNeedsDisplay):
(WebCore::GraphicsLayerClutter::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isTrackingRepaints):
  Required since this is a GraphicsLayerClient.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
  Now accepts a flag to include the repaint rects in the layer tree
  dump.
(WebCore::resetTrackedRepaintRectsRecursive):
  Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
  Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::isTrackingRepaints):
  Required since this is a GraphicsLayerClient.
* testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
* testing/Internals.h:
* testing/Internals.idl:
  The internals changes plumb the new flag for including the repaint
  rects in the layer tree dump.

Source/WebKit/chromium:

(WebKit::WebWidget::isTrackingRepaints):
  Used by the NonCompositedContentHost to determine if we are tracking
  repaint rects.
(WebKit::WebWidget::isTrackingRepaints):
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::updateGeometry):
  Now calls GraphicsLayer::addRepaintRect when invalidated.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::isTrackingRepaints):
  Required as this is a GraphicsLayerClient.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isTrackingRepaints):
  Implementation of WebWidget::isTrackingRepaints.

LayoutTests:

* compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* compositing/repaint/invalidations-on-composited-layers.html: Added.
* platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
Adam Barth [Fri, 2 Nov 2012 19:22:24 +0000 (19:22 +0000)]
[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
https://bugs.webkit.org/show_bug.cgi?id=100973

Reviewed by Stephen White.

This is the first step towards using intrusive DOM wrapper maps more
widely in WebCore (see
http://lists.webkit.org/pipermail/webkit-dev/2012-November/022686.html
for more context).

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoASSERT in RenderLayer::hitTestContents can fire
Adam Barth [Fri, 2 Nov 2012 19:15:30 +0000 (19:15 +0000)]
ASSERT in RenderLayer::hitTestContents can fire
https://bugs.webkit.org/show_bug.cgi?id=99656

Reviewed by Eric Seidel.

Source/WebCore:

The issue is that updateHitTestResult and addNodeToRectBasedTestResult
are using two different nodes. Since they aren't consistent, we violate
assertions about only setting the inner node if we're doing a
rect-based hit test. This patch makes the two consistent.

Test: fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest):
(WebCore):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::updateHitTestResult):
* rendering/RenderBlock.h:
(RenderBlock):

LayoutTests:

This test ensures that we don't trigger the assert.

* fast/dom/nodesFromRect/nodesFromRect-continuation-crash-expected.txt: Added.
* fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPrefer 'Content-Security-Policy' to 'X-WebKit-CSP'.
mkwst [Fri, 2 Nov 2012 19:05:34 +0000 (19:05 +0000)]
Prefer 'Content-Security-Policy' to 'X-WebKit-CSP'.
https://bugs.webkit.org/show_bug.cgi?id=101043

Reviewed by Adam Barth.

The canonical 'Content-Security-Policy' header landed in 133095, but we
missed a few tests while updating to the new hotness. We also should
start using the canonical header for the inspector.

This patch should have no visible change; tests should continue to pass
with the new header, just as they did with the old header.

Source/WebCore:

* inspector/front-end/inspector.html:

LayoutTests:

* http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace.html:
* http/tests/security/contentSecurityPolicy/img-blocked-no-gc-crash.html:
* http/tests/security/isolatedWorld/bypass-main-world-csp.html:
* inspector/console/console-eval-blocked.html:
* inspector/debugger/debugger-pause-on-blocked-event-handler.html:
* inspector/debugger/debugger-pause-on-blocked-script-injection.html:
* inspector/debugger/debugger-pause-on-blocked-script-url.html:
* inspector/debugger/eval-on-pause-blocked.html:
* inspector/elements/resolve-node-blocked.html:
* media/csp-blocks-video.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowebkit-patch analyze-baselines output is weak
Dirk Pranke [Fri, 2 Nov 2012 19:02:30 +0000 (19:02 +0000)]
webkit-patch analyze-baselines output is weak
https://bugs.webkit.org/show_bug.cgi?id=100998

Reviewed by Ojan Vafai.

Currently analyze-baselines prints a list of baselines that have
the same checksum per line, but the format is hard to read;
this patch cleans up the output to print by directory instead
and use the same format I recently added for debugging optimize-baselines,
then refactors the code so that we share and adds tests for
analyze-baselines (which was untested).

Also, I got rid of a couple of unnecessarily-hardcoded port names,
and modified the baseline optimizer to log the current world when
optimize fails.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer.read_results_by_directory):
(BaselineOptimizer.write_by_directory):
(BaselineOptimizer.optimize):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.execute):
(AnalyzeBaselines.__init__):
(AnalyzeBaselines._write):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_FakeOptimizer):
(_FakeOptimizer.read_results_by_directory):
(TestAnalyzeBaselines):
(TestAnalyzeBaselines.setUp):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Marking object-clip-rects-assertion.html as flaky.
Alice Boxhall [Fri, 2 Nov 2012 19:02:28 +0000 (19:02 +0000)]
Unreviewed gardening. Marking object-clip-rects-assertion.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=86909

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
Adam Barth [Fri, 2 Nov 2012 19:01:01 +0000 (19:01 +0000)]
ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
https://bugs.webkit.org/show_bug.cgi?id=100711

Reviewed by Eric Seidel.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No one is actively working on ENABLE(UNDO_MANAGER). There are some
tricky lifetime issues in the UndoManager API that are complicating
ongoing work to improve the interaction between WebCore and the garbage
collector. Rather than leave this code in a broken state, we should
remove it for the time being. We can always restore it from the svn
history when there is an active owner for this code.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.features.am:
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMTransaction.cpp: Removed.
* bindings/js/DOMTransaction.h: Removed.
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSUndoManagerCustom.cpp: Removed.
* bindings/v8/DOMTransaction.cpp: Removed.
* bindings/v8/DOMTransaction.h: Removed.
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8DOMTransactionCustom.cpp: Removed.
* bindings/v8/custom/V8UndoManagerCustom.cpp: Removed.
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore):
(Document):
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
* editing/CompositeEditCommand.h:
* editing/DOMTransaction.idl: Removed.
* editing/DOMTransactionStep.cpp: Removed.
* editing/DOMTransactionStep.h: Removed.
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::canUndo):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo):
(WebCore::Editor::redo):
* editing/UndoManager.cpp: Removed.
* editing/UndoManager.h: Removed.
* editing/UndoManager.idl: Removed.
* editing/UndoStep.h:
(UndoStep):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMeasure the usage of the various CSP headers.
mkwst [Fri, 2 Nov 2012 18:54:46 +0000 (18:54 +0000)]
Measure the usage of the various CSP headers.
https://bugs.webkit.org/show_bug.cgi?id=100974

Reviewed by Adam Barth.

Currently, we're collecting metrics regarding usage of the
'X-WebKit-CSP' and 'X-WebKit-CSP-Report-Only' HTTP headers. We've
recently added support for the canonical 'Content-Security-Policy'
and 'Content-Security-Policy-Report-Only' headers. This patch adds
those headers explicitly into the metrics, giving insight into uptake
of the unprefixed header, and into usage of pure reporting vs.
enforcement.

No visible functionality should change; all Content Security Policy
tests should continue to pass.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
    Convert the CSP header type into a FeatureObserver::Feature, and
    observe it.
* page/FeatureObserver.h:
    Add three new values to the enum to cover the new header types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix silly mistake from http://trac.webkit.org/changeset/133315.
Ojan Vafai [Fri, 2 Nov 2012 18:53:00 +0000 (18:53 +0000)]
Fix silly mistake from trac.webkit.org/changeset/133315.
Forgot to remove the "!".

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSupport X-XSS-Protection: report=URL header syntax in XSSAuditor.
tsepez [Fri, 2 Nov 2012 18:50:57 +0000 (18:50 +0000)]
Support X-XSS-Protection: report=URL header syntax in XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=100892

Reviewed by Adam Barth.

Source/WebCore:

This patch adds a security feature which allows a violation report to be sent back
to a site when the XSSAuditor detects a reflected XSS against it.  It uses the same
reporting mechanism as for CSP violation reports.

Tests: http/tests/security/xssAuditor/malformed-xss-protection-header-5.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-6.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-7.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-8.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-9.html
       http/tests/security/xssAuditor/report-script-tag.html
       http/tests/security/xssAuditor/xss-protection-parsing-03.html
       http/tests/security/xssAuditor/xss-protection-parsing-04.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
Invoke Ping loader's violation reporting, if requested, when a reflected
XSS is detected.

* html/parser/XSSAuditor.h:
XSSAuditor class need to store the report URL as well as the undigested versions
of the request URL and request body for reporting.

* loader/MixedContentChecker.cpp:
(WebCore):
* loader/MixedContentChecker.h:
(MixedContentChecker):
Make isMixedContent() method public.

* loader/PingLoader.cpp:
(WebCore::PingLoader::sendViolationReport):
* loader/PingLoader.h:
(PingLoader):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
Renamed reportContentSecurityPolicyViolation() method to sendViolationReport(),
since this is now used to send more than just CSP violations.

* platform/network/HTTPParsers.cpp:
(WebCore):
(WebCore::skipEquals):
(WebCore::skipValue):
(WebCore::parseXSSProtectionHeader):
* platform/network/HTTPParsers.h:
Parse and return report= directive in X-XSS-Protection header.

LayoutTests:

* http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-5.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-6.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-7.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-8.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-9.html: Added.
* http/tests/security/xssAuditor/report-script-tag-expected.txt: Added.
* http/tests/security/xssAuditor/report-script-tag.html: Added.
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-03.html: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-04.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing...
vollick [Fri, 2 Nov 2012 18:45:09 +0000 (18:45 +0000)]
[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523

Reviewed by Simon Fraser.

The repaint-subrect-grid.html layout test is now text-based and
doesn't use testRunner.displayInvalidatedRegion().

* fast/images/repaint-subrect-grid-expected.txt:
* fast/images/repaint-subrect-grid.html:
* platform/chromium/fast/images/repaint-subrect-grid-expected.png: Removed.
* platform/efl/fast/images/repaint-subrect-grid-expected.png: Removed.
* platform/mac/TestExpectations:
* platform/mac/fast/images/repaint-subrect-grid-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133313.
Stephen White [Fri, 2 Nov 2012 18:43:30 +0000 (18:43 +0000)]
Unreviewed, rolling out r133313.
http://trac.webkit.org/changeset/133313
https://bugs.webkit.org/show_bug.cgi?id=101078

"A lot of tests hit the ASSERTs introduced by this patch"
(Requested by haraken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Marking some repaint tests as flaky.
Alice Boxhall [Fri, 2 Nov 2012 18:39:44 +0000 (18:39 +0000)]
Unreviewed gardening. Marking some repaint tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=84720

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r132913.
Ojan Vafai [Fri, 2 Nov 2012 18:33:58 +0000 (18:33 +0000)]
Unreviewed, rolling out r132913.
http://trac.webkit.org/changeset/132913
https://bugs.webkit.org/show_bug.cgi?id=91850

Caused performance regressions.
See https://bugs.webkit.org/show_bug.cgi?id=100872 for details.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::visitExternalStrings):
* bindings/v8/V8StringResource.cpp:
(StringTraits):
(WebCore::v8StringToWebCoreString):
* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
(WebCore::WebCoreStringResource::visitStrings):
* bindings/v8/V8ValueCache.h:
(WebCore::WebCoreStringResource::WebCoreStringResource):
(WebCore::WebCoreStringResource::~WebCoreStringResource):
(WebCore::WebCoreStringResource::data):
(WebCoreStringResource):
(WebCore::WebCoreStringResource::length):
(WebCore::WebCoreStringResource::atomicString):
(WebCore::WebCoreStringResource::toStringResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageCli...
commit-queue [Fri, 2 Nov 2012 18:27:22 +0000 (18:27 +0000)]
[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.

Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
if other objects keep a reference to the WebPageProxy and try to use
it after the view (and therefore the PageClient) is destroyed.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::~EwkViewImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Remove dependency on SoupPasswordManager
commit-queue [Fri, 2 Nov 2012 18:05:42 +0000 (18:05 +0000)]
[GTK] Remove dependency on SoupPasswordManager
https://bugs.webkit.org/show_bug.cgi?id=100775

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-11-02
Reviewed by Carlos Garcia Campos.

.:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* configure.ac: Look for libsecret using the pkg-config configuration macro.

Source/WebCore:

Remember passwords using libsecret instead of SoupPasswordManager. We accomplish this using
a new class, CredentialBackingStore. CredentialBackingStore will soon be the thing that backs
CredentialStoreGtk. The name is based on the name of a similar class from the BlackBerry port.

No new tests. This does not change behavior.

* GNUmakefile.am: Add libsecret flags to the build and the new directory to the include list.
* GNUmakefile.list.am: Add new files to the source list.
* platform/gtk/GRefPtrGtk.cpp: Add support for SecretValue to GRefPtrGtk.
* platform/gtk/GtkAuthenticationDialog.cpp: Replace interaction with SoupPasswordManger with
interaction with the CredentialBackingStore. Remove all conditional SoupPasswordManager guards.
* platform/gtk/GtkAuthenticationDialog.h: Ditto.
* platform/network/gtk/CredentialBackingStore.cpp: Added.
* platform/network/gtk/CredentialBackingStore.h: Added.

Source/WebKit/gtk:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* GNUmakefile.am: Use libsecret libs during WebKit1 library compilation.

Source/WebKit2:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* GNUmakefile.am: Add libsecret CFLAGS to the WebKit2 build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build warning [-Wswitch]
commit-queue [Fri, 2 Nov 2012 17:57:43 +0000 (17:57 +0000)]
Fix build warning [-Wswitch]
https://bugs.webkit.org/show_bug.cgi?id=101029

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.

Fix build warning message: enumeration value ‘Viewport’ not handled in switch [-Wswitch]
in Source/WebCore/css/StyleSheetContents.cpp.
Add case statement for 'Viewport' with the CSS_DEVICE_ADAPTATION macro.

* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove m_element checks out of canShareStyle into locateSharedStyle
Ojan Vafai [Fri, 2 Nov 2012 17:54:02 +0000 (17:54 +0000)]
Move m_element checks out of canShareStyle into locateSharedStyle
https://bugs.webkit.org/show_bug.cgi?id=101070

Reviewed by Darin Adler.

Can shareStyleWithElement is called for each sibling as we look for a
shareElement. locateSharedStyle is called once for the element we're
trying to find a style for. Checks that only depend on the latter
element should, thus be in locateSharedStyle.

No new tests. There should be no change in behavior, except possibly
a performance improvement in some cases.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[BlackBerry] Adding window.external to our port
commit-queue [Fri, 2 Nov 2012 17:46:55 +0000 (17:46 +0000)]
[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-02
Reviewed by Rob Buis.
PR 158809

Patch up an error where we were dereferencing a null pointer.

* WebCoreSupport/ExternalExtension.cpp:
(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
Kentaro Hara [Fri, 2 Nov 2012 17:42:50 +0000 (17:42 +0000)]
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054

Reviewed by Adam Barth.

I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942

I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImrpove scoring in touch adjustment to address bias towards smaller targets.
commit-queue [Fri, 2 Nov 2012 17:19:09 +0000 (17:19 +0000)]
Imrpove scoring in touch adjustment to address bias towards smaller targets.
https://bugs.webkit.org/show_bug.cgi?id=101046

Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-02
Reviewed by Antonio Gomes.

Source/WebCore:

Update the touch overlap score for touch adjustmetn to normalize
with respect to the maximum possible overlap rather than the size
of the target element.  This change enables good overlap scores for
small and large targets alike.  Prior to the patch it was not possible
to get a good overlap score for a sufficiently larget target.

Covered by existing tests, which have been updated to reflect the
intended behavior.

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::hybridDistanceFunction):

LayoutTests:

Add missing mouse handlers to ensure proper handling of nested
elements.  Nested elements with explicit handlers are favored over
ancestor elements.  The change to scoring in touch adjustment,
which removes bias towards small targets, broke two of the layout
tests.  The updated tests more accurately reflect intended
behavior.

* touchadjustment/nested-shadow-node.html:
* touchadjustment/rotated-node.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Repeated errors are rendered incorrectly: link is not floating to...
mkwst [Fri, 2 Nov 2012 17:10:51 +0000 (17:10 +0000)]
Web Inspector: Repeated errors are rendered incorrectly: link is not floating to the right.
https://bugs.webkit.org/show_bug.cgi?id=101032

Reviewed by Yury Semikhatsky.

https://bugs.webkit.org/show_bug.cgi?id=100525 incorrectly added
'-webkit-flex: 1' only to the list generated for errors in the console.
It should have been added to normal warning text as well. This patch
fixes the problem.

* inspector/front-end/inspector.css:
(.repeated-message .outline-disclosure, .repeated-message > .console-message-text):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Timeline: show popup for CPU bars.
commit-queue [Fri, 2 Nov 2012 17:07:21 +0000 (17:07 +0000)]
Web Inspector: Timeline: show popup for CPU bars.
https://bugs.webkit.org/show_bug.cgi?id=100951

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-02
Reviewed by Pavel Feldman.

Each CPU bar can represent a combination of several shorter messages.
We should show information about combined messages - start time,
total duration, CPU time, message count.

* English.lproj/localizedStrings.js: Added "Message Count" string.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Supply elements with underlying info.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Network panel grid UI is misaligned after r132888
commit-queue [Fri, 2 Nov 2012 16:58:55 +0000 (16:58 +0000)]
Web Inspector: Network panel grid UI is misaligned after r132888
https://bugs.webkit.org/show_bug.cgi?id=101050

Rollback the change to basic data grid css and move it to the native memory
snapshot datagrid css.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-02
Reviewed by Alexander Pavlov.

* inspector/front-end/dataGrid.css:
(.data-grid td):
* inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid td):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r133303.
Balazs Kelemen [Fri, 2 Nov 2012 16:43:31 +0000 (16:43 +0000)]
Unreviewed, rolling out r133303.
http://trac.webkit.org/changeset/133303
https://bugs.webkit.org/show_bug.cgi?id=101068

"Broke qt wk2 build (seems like bots fails to rerun qmake if
needed)" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/PlatformStrategies.cpp:
(WebCore):
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133308 268f45cc-cd09-0410-ab3c-d52691b4dbfc