Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
authorTony Chang <tony@chromium.org>
Mon, 15 Oct 2012 20:54:50 +0000 (20:54 +0000)
committerTony Chang <tony@chromium.org>
Mon, 15 Oct 2012 20:54:50 +0000 (20:54 +0000)
commitc4ac2f5c446d3c4b1a722ef090134589d61f651e
tree6c8de469f06840172679ecb5794d23ac984777f1
parent5d88ffc0ee3f86fd52ef63e88cf78731f897f4ca
Add computeLogicalHeight override methods to RenderView and RenderMultiColumnSet
https://bugs.webkit.org/show_bug.cgi?id=99348

Reviewed by Ojan Vafai.

Add computeLogicalHeight to the last 2 RenderBoxes that override the method.
I'm unable to remove RenderMultiColumnSet::updateLogicalHeight and make the method
non-virtual since it sets ComputedColumnHeight.  I'd like to remove this
eventually.

No new tests, this is just a code refactor.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::updateLogicalHeight): Set computedColumnHeight.
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore):
* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeLogicalHeight):
* rendering/RenderView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderMultiColumnSet.cpp
Source/WebCore/rendering/RenderMultiColumnSet.h
Source/WebCore/rendering/RenderView.cpp
Source/WebCore/rendering/RenderView.h