In Skia's ImageFrame, only set the isOpaque flag when the frame is complete
authorMike Reed <reed@google.com>
Mon, 15 Oct 2012 22:15:46 +0000 (22:15 +0000)
committerMike Reed <reed@google.com>
Mon, 15 Oct 2012 22:15:46 +0000 (22:15 +0000)
commit3d39e6f51a06899e3d0f32213bb2fde6d652971e
tree7ce492325daf3a7d266a00e61faccbbbac6974b7
parent8b18dc5c72845a338b8c6494c1d4bced3f671204
In Skia's ImageFrame, only set the isOpaque flag when the frame is complete
https://bugs.webkit.org/show_bug.cgi?id=99326

Reviewed by Stephen White.

No new tests -- existing layouttests exercise this, esp.
  png-partial-load-no-alpha.html
  webp-partial-load.html
These two fail if skia is told that these are opaque, which it is w/o this CL.

At the moment, Skia has a hack to ignore the opaque-setting, so that these tests will pass as is.
This change is to first, correct webkit to only set isOpaque when the frame is complete, so that
in a later change, Skia can remove the hack, and re-enable its opaqueness optimization.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/platform/image-decoders/ImageDecoder.h
Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp