2011-06-09 Robert Hogan <robert@webkit.org>
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Wed, 24 Aug 2011 14:59:28 +0000 (11:59 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Thu, 25 Aug 2011 14:22:19 +0000 (11:22 -0300)
commitf3847b9e81180f185bac7338520edb9732b687fa
treea1c3368065a1bf865403931cb61eca529bac41d3
parentb0ff91f953d5f3781d24c842c5616d29be04fca6
2011-06-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        Teach Qt about window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61074

        Unskip fast/harness/internals-object.html

        * platform/qt/Skipped:
2011-06-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        Teach Qt about window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61074

        A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
        away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
        Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
        where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
        is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
        Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
        and others. The only alternative seems like a compile time guard which we would have to teach the bots about.

        * CodeGenerators.pri:
        * WebCore.pri:
        * WebCore.pro:
2011-06-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        Teach Qt about window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61074

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::injectInternalsObject):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-09  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        Teach Qt about window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61074

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::initJSObjects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
LayoutTests/ChangeLog
LayoutTests/platform/qt/Skipped
Source/WebCore/ChangeLog
Source/WebCore/CodeGenerators.pri
Source/WebCore/WebCore.pri
Source/WebCore/WebCore.pro
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Tools/ChangeLog
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp