2011-05-31 Berend-Jan Wever <skylined@chromium.org>
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Wed, 1 Jun 2011 17:11:25 +0000 (14:11 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Wed, 1 Jun 2011 17:36:57 +0000 (14:36 -0300)
commitf1148b921a13971d52c3fa7cce6c9d34e8840b5d
treebfac184a94191f78e9092da6d9ad9a14d461a2c0
parent2b120eb4525ef15cd8e0089a0441a550626caad6
2011-05-31  Berend-Jan Wever  <skylined@chromium.org>

        Reviewed by Adam Barth.

        Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
        when no error callback is supplied does not cause a NULL ptr.
        https://bugs.webkit.org/show_bug.cgi?id=49539

        * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
        * fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.
2011-05-31  B.J. Wever  <skylined@chromium.org>

        Reviewed by Adam Barth.

        requestFileSystem and resolveLocalFileSystemURI are not checking if
        errorCallback is NULL before scheduling a callback on error.
        https://bugs.webkit.org/show_bug.cgi?id=49539

        Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html

        * fileapi/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::scheduleCallback): Only call callback if
          one is supplied.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/fileapi/DOMFileSystem.h
LayoutTests/ChangeLog
LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/fileapi/DOMFileSystem.h