1 2011-07-01 Jade Han <jade.han@nokia.com>
3 [Qt][Symbian] Update .def file for Symbian to build Tools
4 https://bugs.webkit.org/show_bug.cgi?id=61200
6 Reviewed by Laszlo Gombos.
8 Add newly introduced symbols to fix building the Tools directory for Symbian.
10 * symbian/eabi/QtWebKitu.def:
12 2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
14 Reviewed by Benjamin Poulain.
16 [Qt] Fix tst_QWebFrame::renderGeometry() API test
17 https://bugs.webkit.org/show_bug.cgi?id=63236
19 This test required a security origin with granted permission to request local resources.
20 By default, only local files can load local resources. So modified baseUrl to be a local file.
22 * tests/qwebframe/tst_qwebframe.cpp:
23 (tst_QWebFrame::renderGeometry):
25 2011-07-01 Jade Han <jade.han@nokia.com>
27 Reviewed by Laszlo Gombos.
29 [Qt][Symbian] Update .def file for Symbian
30 https://bugs.webkit.org/show_bug.cgi?id=61200
32 Add newly introduced symbols to fix the Symbian build.
34 * symbian/eabi/QtWebKitu.def:
36 2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>
38 Reviewed by Benjamin Poulain.
40 [Qt] QML Webview causes performance drops
41 https://bugs.webkit.org/show_bug.cgi?id=57554
43 Remove tiledBackingStoreEnabled from QML WebView.
45 * declarative/qdeclarativewebview.cpp:
46 (QDeclarativeWebView::setPage):
48 2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
50 Reviewed by Benjamin Poulain.
52 [Qt] Add Qt dependencies in QtWebKit's main pro file.
53 https://bugs.webkit.org/show_bug.cgi?id=63639
55 syncqt, the script which generates the headers inside Qt parses
56 the main pro file of QtWebKit to check the Qt dependencies. It used
57 to be WebCore.pro but after the build reorganization QtWebKit.pro is
58 the new main pro file so we need to add the network dependency just like
59 we did in WebCore.pro.
63 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
65 Rubber-stamped by Andreas Kling.
67 [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
68 https://bugs.webkit.org/show_bug.cgi?id=63235
70 [Qt] Fix tst_QWebFrame::renderGeometry() API test
71 https://bugs.webkit.org/show_bug.cgi?id=63236
73 [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
74 https://bugs.webkit.org/show_bug.cgi?id=63237
76 * tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
77 (tst_QWebFrame::setHtmlWithResource):
78 (tst_QWebFrame::renderGeometry):
80 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
82 Rubber-stamped by Andreas Kling.
84 [Qt] Fix tst_QWebPage::showModalDialog() API test
85 https://bugs.webkit.org/show_bug.cgi?id=63244
87 [Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
88 https://bugs.webkit.org/show_bug.cgi?id=63245
90 * tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
91 (tst_QWebPage::showModalDialog):
92 (tst_QWebPage::testStopScheduledPageRefresh):
94 2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
96 Reviewed by Andreas Kling.
98 [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
99 https://bugs.webkit.org/show_bug.cgi?id=63562
101 Some Qt auto-tests rely on <QtX/x.h> types of includes.
103 * Api/qwebkitplatformplugin.h:
104 * symbian/platformplugin/qwebkitplatformplugin.h:
106 2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
108 Reviewed by Andreas Kling.
110 [Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
111 https://bugs.webkit.org/show_bug.cgi?id=63533
113 We need to use the new QtQuick 1.x imports rather than the old deprecated
116 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
117 * tests/qdeclarativewebview/resources/webviewtest.qml:
118 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
120 2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
122 Reviewed by Andreas Kling.
124 [Qt] tst_QWebFrame::overloadedSlots() fails
125 https://bugs.webkit.org/show_bug.cgi?id=37319
127 * tests/qwebframe/tst_qwebframe.cpp:
128 (tst_QWebFrame::overloadedSlots): Remove expected failure and
131 2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
133 Reviewed by Kenneth Rohde Christiansen.
135 [Qt] Remove Phonon MediaPlayer from the tree.
136 https://bugs.webkit.org/show_bug.cgi?id=63448
138 Remove Phonon related stuff.
140 * docs/qtwebkit.qdocconf:
141 * qt_webkit_version.pri:
143 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
145 Rubber-stamped by Andreas Kling.
147 [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
148 https://bugs.webkit.org/show_bug.cgi?id=63235
150 [Qt] Fix tst_QWebFrame::renderGeometry() API test
151 https://bugs.webkit.org/show_bug.cgi?id=63236
153 [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
154 https://bugs.webkit.org/show_bug.cgi?id=63237
156 * tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
157 (tst_QWebFrame::setHtmlWithResource):
158 (tst_QWebFrame::renderGeometry):
160 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
162 Rubber-stamped by Andreas Kling.
164 [Qt] Fix tst_QWebPage::showModalDialog() API test
165 https://bugs.webkit.org/show_bug.cgi?id=63244
167 [Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
168 https://bugs.webkit.org/show_bug.cgi?id=63245
170 * tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
171 (tst_QWebPage::showModalDialog):
172 (tst_QWebPage::testStopScheduledPageRefresh):
174 2011-06-23 Joe Wild <joseph.wild@nokia.com>
176 Reviewed by Laszlo Gombos.
178 [Qt] Export files under Symbian Qt WebKit build
179 https://bugs.webkit.org/show_bug.cgi?id=61207
181 Export files for the Symbian platform as this is needed by the
182 production build system.
184 Janne Koskinen provided the suggestion to use target_predeps,
185 which is an improvement over the originally suggested patch.
189 2011-06-23 Joe Wild <joseph.wild@nokia.com>
191 Reviewed by Laszlo Gombos.
193 [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
194 https://bugs.webkit.org/show_bug.cgi?id=61200
196 Revert r87060 as it broke compatibility with QtWebKit 2.1 release
197 and add some newly introduce symbols.
199 * symbian/eabi/QtWebKitu.def:
201 2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
203 Reviewed by Holger Freyther.
205 [Qt] Fix Qt namespace on QDeclarativeWebView autotest
206 https://bugs.webkit.org/show_bug.cgi?id=63147
208 Applications (such as the test runner) are not supposed to be wrapped
209 by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
210 QtWebKit) with a specific namespace won't work (will result in main
213 This was the only test wrapped by these macros, all others are fine.
215 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
218 2011-06-21 Yael Aharon <yael.aharon@nokia.com>
220 Reviewed by Andreas Kling.
222 [Qt] Regression(60942) wrong default action for drag-and-drop.
223 https://bugs.webkit.org/show_bug.cgi?id=63004
225 Added special handling for the case that dragOperation is not initialized.
226 Save the last dropOperation and pass it to the dropEvent, so that it can
227 be accepted by QDrag.
228 Call event->accepted() and not event->acceptProposedAction(), because the
229 later ignores the dropAction specified in JavaScript.
231 Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
232 and did not see any issue.
233 Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
237 (dropActionToDragOp):
238 (QWebPagePrivate::dragMoveEvent):
239 (QWebPagePrivate::dropEvent):
241 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
243 Unreviewed, rolling out r88796.
244 http://trac.webkit.org/changeset/88796
245 https://bugs.webkit.org/show_bug.cgi?id=62790
247 It made fast/dom/nodesFromRect-basic.html time out on Qt,
248 64-bit, debug mode (Requested by Ossy on #webkit).
250 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
251 (DumpRenderTreeSupportQt::plainText):
252 (DumpRenderTreeSupportQt::nodesFromRect):
253 * WebCoreSupport/DumpRenderTreeSupportQt.h:
254 * tests/qwebframe/tst_qwebframe.cpp:
255 (tst_QWebFrame::overloadedSlots):
256 (tst_QWebFrame::domCycles):
258 2011-06-17 Alexis Menard <alexis.menard@openbossa.org>
260 Reviewed by Andreas Kling.
262 [Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
263 https://bugs.webkit.org/show_bug.cgi?id=62815
265 Partially revert r85870 which assumed that QtWebKit will never be build inside Qt
266 anymore. Everything inside !QTDIR_build condition is not needed in the Qt tree because
267 qbase.pri is doing the job for us, i.e. using includes generated by syncqt to
268 setup the mac framework. It also use a correct QMAKE_LFLAGS_SONAME making possible
269 to actually run an application linked against QtWebKit.
273 2011-06-15 Diego Gonzalez <diegohcg@webkit.org>
275 Reviewed by Kenneth Rohde Christiansen.
277 [Qt] Inconsistent behavior on a form submit request...
278 https://bugs.webkit.org/show_bug.cgi?id=45523
280 The inconsistency occurs when a form submission requests a new window.
281 Two windows are opened (instead of only one) and the first window is opened
284 By default each page is put into their own unique page group, which affects popup windows
285 and visited links. Page groups (per process only) is a feature making it possible to use
286 separate settings for each group, so that for instance an integrated browser/email reader
287 can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
288 as expected out of the box, we use a default group similar to what other ports are doing.
292 2011-06-14 Andreas Kling <kling@webkit.org>
294 Reviewed by Benjamin Poulain.
296 [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
297 https://bugs.webkit.org/show_bug.cgi?id=62632
299 * WebCoreSupport/FrameNetworkingContextQt.cpp:
301 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
303 Reviewed by Andreas Kling.
305 [Qt] tst_QWebFrame::overloadedSlots() fails
306 https://bugs.webkit.org/show_bug.cgi?id=37319
308 Since the implicit conversion was removed, change support functions of DRT to
309 expect a QVariantMap instead of a QWebElement. This matches the exposed function
310 in the controller, which takes 'document' and not 'document.documentElement'.
312 And now that Element -> QWebElement is a perfect match, we must use QWebElement
313 instead of QVariantMap, like in plainText().
315 * WebCoreSupport/DumpRenderTreeSupportQt.h:
316 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
317 (DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
318 QVariantMap when getting the startContainer. Also use QVariantMap directly,
319 bridge will do conversion for us now.
321 (getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
322 QVariantMap that Qt bridge gives us when 'document' is passed from JS.
324 (DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
326 * tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
327 different tests. In practice, the original test just checked whether we could
328 create a QVariantMap representing 'document' without infinite looping due to
329 cycles in the DOM. This was more evident before since we haven't a conversion
330 from JSElement to QWebElement, but from JSElement to QVariantMap.
332 (tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
333 'documentElement' from it. Compares to QWebFrame::documentElement().
335 (tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
338 (tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
340 2011-06-10 Andreas Kling <kling@webkit.org>
342 Reviewed by Benjamin Poulain.
344 [Qt] Fix 'headers' autotest when building inside Qt.
345 https://bugs.webkit.org/show_bug.cgi?id=62449
347 * Api/qwebkitplatformplugin.h:
349 2011-06-09 Andras Becsi <abecsi@webkit.org>
351 Reviewed by Andreas Kling.
353 [Qt] Fix the in-tree build on Linux
354 https://bugs.webkit.org/show_bug.cgi?id=62378
356 In case of an in-tree build qmake generates defect prl dependencies for
357 the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
359 * QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
361 2011-06-08 Andreas Kling <kling@webkit.org>
363 Reviewed by Benjamin Poulain.
365 [Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
366 https://bugs.webkit.org/show_bug.cgi?id=62274
368 Vector::find() returns size_t (which is unsigned), so we should check
369 for WTF::notFound instead of -1.
371 * WebCoreSupport/FrameLoaderClientQt.cpp:
372 (WebCore::FrameLoaderClientQt::createPlugin):
374 2011-06-07 Aravind Akella <aravind.akella@nokia.com>
376 Reviewed by Laszlo Gombos.
378 [Qt][Symbian] API test failure qdeclarativewebview
379 https://bugs.webkit.org/show_bug.cgi?id=59481
381 QML files cannot be loaded on Symbian due to difference
382 in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
383 A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
384 missing is observed when dynamically loading the QML plugin.
386 * declarative/declarative.pro: Match capabilities in QtWebKit.pro.
387 * symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs.
388 Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL,
389 and causes build warnings about undefined VENDOR_VID.
390 * tests/tests.pri: Add WriteDeviceData capability for API tests.
392 2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>
394 Reviewed by Andreas Kling.
396 [Qt] It made two Qt API tests fail
397 https://bugs.webkit.org/show_bug.cgi?id=58847
399 Modified failing test's base url so it could get a valid origin
400 and make use of local storage. Also added another test that checks
401 local storage visibility in both scenarios.
403 * tests/qwebpage/tst_qwebpage.cpp:
404 (tst_QWebPage::testOptionalJSObjects):
405 (checkLocalStorageVisibility):
406 (tst_QWebPage::testLocalStorageVisibility):
408 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
410 Reviewed by Andreas Kling.
412 [Qt] Warning fixes on comparisons between a signed and an unsigned.
414 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
415 (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
416 (DumpRenderTreeSupportQt::nodesFromRect):
418 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
420 Reviewed by Andreas Kling.
422 To support building namespaced Qt, we require that forward-declarations
423 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
425 * WebCoreSupport/FrameLoaderClientQt.h:
427 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
429 Unreviewed build fix after r87902.
431 To support building namespaced Qt, we require that forward-declarations
432 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
433 only on classes inside Qt.
435 * WebCoreSupport/DumpRenderTreeSupportQt.h:
437 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
439 Reviewed by Benjamin Poulain.
441 Some warning fixes. Values in switch not handled, and
442 a comparison between a signed and an unsigned.
445 (QWebPagePrivate::inputMethodEvent):
446 (QWebPagePrivate::dynamicPropertyChangeEvent):
449 2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
451 Unreviewed build fix for Qt and QuickTime backend.
453 r87328 added a new system interface, we need to add it too.
455 * WebCoreSupport/WebSystemInterface.mm:
456 (InitWebCoreSystemInterface):
458 2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
460 Reviewed by Eric Carlson.
462 [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
463 https://bugs.webkit.org/show_bug.cgi?id=61279
465 Enable the usage of QuickTime backend for the Qt port. It can be enabled by
466 passing DEFINES+=USE_QTKIT=1 when calling build-webkit.
469 (QWebPagePrivate::QWebPagePrivate):
471 * WebCoreSupport/FullScreenVideoQt.cpp:
472 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
473 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
474 (WebCore::FullScreenVideoQt::isValid):
475 * WebCoreSupport/WebSystemInterface.h: Added.
476 * WebCoreSupport/WebSystemInterface.mm: Added.
477 (InitWebCoreSystemInterface):
479 2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
481 Reviewed by Andreas Kling.
483 [Qt] Fix enum order in qwebpage.h public API header
484 https://bugs.webkit.org/show_bug.cgi?id=61959
486 Since qwebpage.h is a public header, we can't change the values of
487 the enumerations. This patch moves the new enumeration to the end
488 of the list. As a bonus, adds a missing entry in
489 editorCommandWebActions table.
494 2011-06-02 Andreas Kling <kling@webkit.org>
496 Rubber-stamped by Simon Hausmann.
498 Remove Qt's precompiled header hack as it was broken, and was not even
499 used unless building WebKit inside a Qt tree.
501 * WebKit_pch.h: Removed.
503 2011-06-01 Andreas Kling <kling@webkit.org>
505 Reviewed by Benjamin Poulain.
507 REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
508 https://bugs.webkit.org/show_bug.cgi?id=49650
510 Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
511 This lets the QNAM backend finish with the reply without handing over ownership to the user code.
513 No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.
515 To correctly solve this issue, we need changes to Qt, tracked here:
516 http://bugreports.qt.nokia.com/browse/QTBUG-18718
518 * WebCoreSupport/FrameLoaderClientQt.cpp:
519 (WebCore::FrameLoaderClientQt::setFrame):
520 (WebCore::FrameLoaderClientQt::download):
521 * WebCoreSupport/FrameLoaderClientQt.h:
523 2011-06-02 Andreas Kling <kling@webkit.org>
525 Unreviewed build fix.
527 To support building namespaced Qt, we require that forward-declarations
528 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
530 * WebCoreSupport/DumpRenderTreeSupportQt.h:
532 2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
534 Reviewed by Kenneth Rohde Christiansen.
536 [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
537 https://bugs.webkit.org/show_bug.cgi?id=59345
539 KURL and QUrl disagree whether certain URLs are valid or not. The regression here
540 was caused by the fact that now KURL accepts "http:/example.com" (note only one
541 slash) and our test case used a strange edge case that's transformed into a
542 "one-slash" URL that now KURL can handle.
544 QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
545 can understand it. So I've updated the test to use a more meaningful example and
546 show that an invalid URL gets converted to a valid URL if possible.
548 * tests/qwebframe/tst_qwebframe.cpp:
549 (tst_QWebFrame::setUrlToInvalid):
551 2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
553 Reviewed by Tor Arne Vestbø.
555 [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
556 https://bugs.webkit.org/show_bug.cgi?id=61739
558 The skipped test was imported from Qt source repository, and used private headers
559 to peek in the QML Grid element. This patch changes the QML used to expose the
560 information we want to test: number of pages opened and the first page opened.
562 * tests/qdeclarativewebview/resources/newwindows.html:
563 Added <body> tags. We have no reason to not use them in the test.
565 * tests/qdeclarativewebview/resources/newwindows.qml:
566 Moved the timer out of the page component, used anchors for setting webview size,
567 changed the way we count pages opened. Also changed coding style a bit.
569 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
570 (tst_QDeclarativeWebView::multipleWindows):
571 We now look for properties with the information we want in the rootItem: pagesOpened and
574 2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
576 Reviewed by Andreas Kling.
578 [Qt] tst_QWebFrame::render() failing
579 https://bugs.webkit.org/show_bug.cgi?id=60893
581 The test was expecting the frame contents to be already loaded
582 before rendering it into a QPicture. Renamed the test to fit
583 its real purpose more accordingly.
585 * tests/qwebframe/tst_qwebframe.cpp:
586 (tst_QWebFrame::renderGeometry):
588 2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
590 Reviewed by Andreas Kling.
592 [Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
593 https://bugs.webkit.org/show_bug.cgi?id=61711
595 The loadFinished() signal was emitted directly inside the call for setHtml, so
596 the test was waiting the loadFinished() signal with a big timeout. Change this by
597 a very small timeout and a verification with signal spy.
599 In practice, setHtml() will either directly call loadFinished() or queue it to
600 the next event loop run, and test will work for both situations.
602 * tests/qwebframe/tst_qwebframe.cpp:
603 (tst_QWebFrame::scrollbarsOff):
605 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
607 Reviewed by Benjamin Poulain.
609 [Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
610 https://bugs.webkit.org/show_bug.cgi?id=60372
612 * tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
613 (tst_QWebElement::style):
615 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
617 Reviewed by Benjamin Poulain.
619 [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
620 https://bugs.webkit.org/show_bug.cgi?id=61042
622 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
623 (tst_QDeclarativeWebView::basicProperties):
624 (tst_QDeclarativeWebView::historyNav):
626 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
628 Reviewed by Benjamin Poulain.
630 [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
631 https://bugs.webkit.org/show_bug.cgi?id=61045
633 * tests/qwebpage/tst_qwebpage.cpp:
634 (tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.
636 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
638 Reviewed by Benjamin Poulain.
640 [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
641 https://bugs.webkit.org/show_bug.cgi?id=59345
643 * tests/qwebframe/tst_qwebframe.cpp:
644 (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
646 2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
648 Reviewed by Csaba Osztrogonác.
650 [Qt] tst_QWebPage creates temporary files in the current working dir
651 https://bugs.webkit.org/show_bug.cgi?id=60497
653 tst_QWebPage was using QDir::currentPath when creating temporary dirs
654 and leaving them after the test was run. I basically borrowed the fix
655 from tst_QDeclarativeWebView.
657 * tests/qwebpage/tst_qwebpage.cpp:
659 (tst_QWebPage::tmpDirPath):
660 (tst_QWebPage::cleanupFiles):
661 (tst_QWebPage::database):
662 (tst_QWebPage::multiplePageGroupsAndLocalStorage):
664 2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
666 Reviewed by Csaba Osztrogonác.
668 [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
669 https://bugs.webkit.org/show_bug.cgi?id=61044
671 Make sure to set the active window on the application too.
673 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
674 (tst_QGraphicsWebView::setPalette):
676 2011-05-23 Luiz Agostini <luiz.agostini@openbossa.org>
678 Reviewed by Andreas Kling.
680 [Qt] When opening a combo-box the popup renders badly.
681 https://bugs.webkit.org/show_bug.cgi?id=61288
683 Removing combobox palette changes from QtFallbackWebPopup::show() because they
684 are causing rendering problems for some styles.
686 The changes in palette are not needed because the background and foreground
687 colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
688 in method QtFallbackWebPopup::populate().
690 * WebCoreSupport/QtFallbackWebPopup.cpp:
691 (WebCore::QtFallbackWebPopup::show):
693 2011-05-23 Joe Wild <joseph.wild@nokia.com>
695 Reviewed by Andreas Kling.
697 [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
698 https://bugs.webkit.org/show_bug.cgi?id=61200
700 * symbian/eabi/QtWebKitu.def:
702 2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
704 Reviewed by Laszlo Gombos.
706 [Qt] Upstream Symbian platform plugin
707 https://bugs.webkit.org/show_bug.cgi?id=58435
709 Upstream Symbian platform plugin with html5 video player.
711 * symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
712 (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
713 (HTML5FullScreenVideoHandler::enterFullScreen):
714 (HTML5FullScreenVideoHandler::exitFullScreen):
715 (HTML5FullScreenVideoHandler::onPlayerError):
716 (HTML5FullScreenVideoHandler::onPlayerStateChanged):
717 (HTML5FullScreenVideoHandler::onMediaStatusChanged):
718 (HTML5VideoPlugin::supportsExtension):
719 (HTML5VideoPlugin::createExtension):
720 * symbian/platformplugin/HTML5VideoPlugin.h: Added.
721 (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
722 (HTML5FullScreenVideoHandler::isFullScreen):
723 (HTML5FullScreenVideoHandler::updateScreenRect):
724 * symbian/platformplugin/HTML5VideoWidget.cpp: Added.
725 (HTML5VideoWidget::HTML5VideoWidget):
726 (HTML5VideoWidget::setDuration):
727 (HTML5VideoWidget::mousePressEvent):
728 (HTML5VideoWidget::onPlayerStopped):
729 (HTML5VideoWidget::onPlayerError):
730 (HTML5VideoWidget::onEndOfMedia):
731 (HTML5VideoWidget::onBufferingMedia):
732 (HTML5VideoWidget::onBufferedMedia):
733 (HTML5VideoWidget::onControlClicked):
734 (HTML5VideoWidget::onPositionChanged):
735 (HTML5VideoWidget::onSliderMoved):
736 (HTML5VideoWidget::onCloseClicked):
737 (HTML5VideoWidget::showFullScreen):
738 (HTML5VideoWidget::setVolume):
739 * symbian/platformplugin/HTML5VideoWidget.h: Added.
740 * symbian/platformplugin/OverlayWidget.cpp: Added.
741 (OverlayWidget::OverlayWidget):
742 (OverlayWidget::~OverlayWidget):
743 (OverlayWidget::setDuration):
744 (OverlayWidget::setPosition):
745 (OverlayWidget::setVolume):
746 (OverlayWidget::mousePressEvent):
747 (OverlayWidget::onPlayerStopped):
748 (OverlayWidget::onPlayerError):
749 (OverlayWidget::onEndOfMedia):
750 (OverlayWidget::onBufferingMedia):
751 (OverlayWidget::onBufferedMedia):
752 (OverlayWidget::timeToString):
753 (OverlayWidget::applyStyleSheet):
754 (OverlayWidget::onControlClicked):
755 (OverlayWidget::onSliderMoved):
756 (OverlayWidget::onSoundClicked):
757 (OverlayWidget::onCloseClicked):
758 (OverlayWidget::onVolumeSliderReleased):
759 (OverlayWidget::onVolumeSliderMoved):
760 (OverlayWidget::onTimerTimeout):
761 (OverlayWidget::showFullScreen):
762 * symbian/platformplugin/OverlayWidget.h: Added.
763 * symbian/platformplugin/PlayerButton.cpp: Added.
764 (PlayerButton::PlayerButton):
765 (PlayerButton::event):
766 * symbian/platformplugin/PlayerButton.h: Added.
767 * symbian/platformplugin/PlayerLabel.cpp: Added.
768 (PlayerLabel::PlayerLabel):
769 (PlayerLabel::onPlayerError):
770 (PlayerLabel::startBufferingAnimation):
771 (PlayerLabel::stopBufferingAnimation):
772 (PlayerLabel::onAnimationTimeout):
773 * symbian/platformplugin/PlayerLabel.h: Added.
774 * symbian/platformplugin/WebPlugin.cpp:
775 (WebPlugin::createExtension):
776 * symbian/platformplugin/images: Added.
777 * symbian/platformplugin/images/button_cannotplay.png: Added.
778 * symbian/platformplugin/images/button_close.png: Added.
779 * symbian/platformplugin/images/button_pause.png: Added.
780 * symbian/platformplugin/images/button_play.png: Added.
781 * symbian/platformplugin/images/button_sound_off.png: Added.
782 * symbian/platformplugin/images/button_sound_on.png: Added.
783 * symbian/platformplugin/images/loading_buffering_1.png: Added.
784 * symbian/platformplugin/images/loading_buffering_2.png: Added.
785 * symbian/platformplugin/images/loading_buffering_3.png: Added.
786 * symbian/platformplugin/images/loading_buffering_4.png: Added.
787 * symbian/platformplugin/platformplugin.pro:
788 * symbian/platformplugin/platformplugin.qrc: Added.
789 * symbian/platformplugin/qss: Added.
790 * symbian/platformplugin/qss/OverlayWidget.qss: Added.
792 2011-05-18 Yi Shen <yi.4.shen@nokia.com>
794 Reviewed by Andreas Kling.
796 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
797 https://bugs.webkit.org/show_bug.cgi?id=33179
799 Remove the implementation of the handleInputMethodKeydown, which introduces
800 a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
802 * WebCoreSupport/EditorClientQt.cpp:
803 (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
804 * tests/qwebpage/tst_qwebpage.cpp:
805 (tst_QWebPage::inputMethods): Add more tests.
807 2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
809 Reviewed by Andreas Kling.
811 [Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
812 https://bugs.webkit.org/show_bug.cgi?id=60978
814 Backslash to escape newlines was confusing both prepare-ChangeLog and the
815 QtCreator highlight system.
817 * tests/qwebframe/tst_qwebframe.cpp:
818 (tst_QWebFrame::evalJSV):
819 Remove usage of backslash to escape newlines in string literal.
821 2011-05-16 Andreas Kling <kling@webkit.org>
823 Reviewed by Kenneth Rohde Christiansen.
825 REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
826 https://bugs.webkit.org/show_bug.cgi?id=60892
828 Don't set the ItemClipsChildrenToShape flag for the root platform layer,
829 since that is now the overflow controls layer. The clip layer, which was
830 previously the root platform layer, already gets the flag by way of
831 the GraphicsLayer mask-to-bounds flag.
833 * WebCoreSupport/PageClientQt.cpp:
834 (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
836 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
838 Reviewed by nobody, build fix.
840 [Qt] Fix build on MSVC.
842 qobject_cast<> requires the class to be exported on MSVC,
843 removing it since the code that needs it is commented out for
846 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
847 (tst_QDeclarativeWebView::elementAreaAt):
849 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
851 Reviewed by nobody, build fix.
853 [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
857 2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
859 Reviewed by Simon Hausmann.
861 Install correct header files for webkit.
863 Since WebKit is no longer inside Qt, we can remove the detection for
866 [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
867 https://bugs.webkit.org/show_bug.cgi?id=57621
871 2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
873 Reviewed by Andreas Kling.
875 [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
876 https://bugs.webkit.org/show_bug.cgi?id=60224
878 We should use nullptr rather than 0. nullptr will be added in the new C++ standard
879 but WebKit already has a nullptr class if there is no c++0x support.
881 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
882 (DumpRenderTreeSupportQt::addUserStyleSheet):
884 2011-05-04 Cris Neckar <cdn@chromium.org>
886 Reviewed by Adam Barth.
888 Expose WebView directly through ChromeClient.
889 https://bugs.webkit.org/show_bug.cgi?id=49902
891 * WebCoreSupport/ChromeClientQt.h:
892 (WebCore::ChromeClientQt::webView):
894 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
896 Unreviewed warning fix.
898 The variable is just unused.
900 * tests/qwebpage/tst_qwebpage.cpp:
901 (tst_QWebPage::inputMethods):
903 2011-05-04 Tao Bai <michaelbai@chromium.org>
905 Reviewed by David Kilzer.
907 Populate touch-icon url to FrameLoaderClient
908 https://bugs.webkit.org/show_bug.cgi?id=59143
910 Respect the interface change in FrameLoaderClient.
912 * WebCoreSupport/FrameLoaderClientQt.cpp:
913 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
914 * WebCoreSupport/FrameLoaderClientQt.h:
916 2011-03-31 Luiz Agostini <luiz.agostini@openbossa.org>
918 Reviewed by Kenneth Rohde Christiansen.
920 [Qt] Qt WebKit updates view on HTTP 204 response
921 https://bugs.webkit.org/show_bug.cgi?id=42529
923 Ignoring http responses which have status code equal to 204 (No Content)
924 or 205 (Reset Content).
926 * WebCoreSupport/FrameLoaderClientQt.cpp:
927 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
929 2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
931 Reviewed by Benjamin Poulain.
933 [Qt] Fix signals emitted in FakeReply used in autotests
934 https://bugs.webkit.org/show_bug.cgi?id=60049
936 The signals emitted for each case of FakeReply were swapped (error case
937 emitting metaDataChanged() and redirect case emitting error()). Emitting
938 readyRead() is not necessary.
940 * tests/qwebframe/tst_qwebframe.cpp:
941 (FakeReply::FakeReply):
942 Choose the different continue function for each case of FakeReply. This removes
943 the need of the if-statement in timeout() and let us replace timeout() with two
946 (FakeReply::continueRedirect):
947 (FakeReply::continueError):
948 Continuation cases, emitting the minimal set of signals needed for each case.
950 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
952 Reviewed by Dimitri Glazkov.
954 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
955 https://bugs.webkit.org/show_bug.cgi?id=58703
957 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
958 (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
960 2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
962 Reviewed by Andreas Kling.
964 [Qt] QtDeclarative Webview element has a fixed white background
965 https://bugs.webkit.org/show_bug.cgi?id=40918
967 QProperty REVISION feature is not present in certain Qt Trunk clones.
968 These builds report their version as 4.8.0, and therefore break on the
969 prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
970 the existance of Q_REVISION.
972 * declarative/plugin.cpp:
973 (WebKitQmlPlugin::registerTypes):
974 * declarative/qdeclarativewebview.cpp:
975 * declarative/qdeclarativewebview_p.h:
977 2011-05-01 Sam Weinig <sam@webkit.org>
979 Reviewed by Anders Carlsson.
981 Prune some unnecessary #includes
982 https://bugs.webkit.org/show_bug.cgi?id=59895
984 Start getting rid of unnecessary #includes and forward declares.
986 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
988 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
990 Reviewed by Adam Barth.
992 Enable strict OwnPtr for Qt
993 https://bugs.webkit.org/show_bug.cgi?id=59667
996 (QWebPagePrivate::QWebPagePrivate):
998 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1000 Reviewed by Simon Hausmann.
1002 ENABLE(QT_BEARER) -> USE(QT_BEARER)
1004 * Api/qwebsettings.cpp:
1006 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1008 Reviewed by Simon Hausmann.
1010 ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
1014 2011-04-28 Yael Aharon <yael.aharon@nokia.com>
1016 Reviewed by Andreas Kling.
1018 Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1019 https://bugs.webkit.org/show_bug.cgi?id=59704
1021 * WebCoreSupport/QtFallbackWebPopup.cpp:
1022 (WebCore::QtFallbackWebPopup::show):
1023 * WebCoreSupport/QtFallbackWebPopup.h:
1025 2011-04-27 Yi Shen <yi.4.shen@nokia.com>
1027 Reviewed by Kenneth Rohde Christiansen.
1029 [Qt] Upstream Symbian platform plugin
1030 https://bugs.webkit.org/show_bug.cgi?id=58435
1032 Upstream Symbian platform plugin.
1034 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
1035 * symbian/platformplugin: Added.
1036 * symbian/platformplugin/WebPlugin.cpp: Added.
1037 (ItemListDelegate::ItemListDelegate):
1038 (ItemListDelegate::paint):
1040 (Popup::resizeEvent):
1041 (Popup::populateList):
1042 (Popup::onItemSelected):
1043 (Popup::updateSelectionsBeforeDialogClosing):
1044 (Popup::updateAndClose):
1045 (WebPopup::WebPopup):
1046 (WebPopup::~WebPopup):
1047 (WebPopup::createSingleSelectionPopup):
1048 (WebPopup::createMultipleSelectionPopup):
1049 (WebPopup::createPopup):
1052 (WebPopup::popupClosed):
1053 (WebPopup::itemClicked):
1054 (SingleSelectionPopup::SingleSelectionPopup):
1055 (MultipleSelectionPopup::MultipleSelectionPopup):
1056 (WebNotificationPresenter::showNotification):
1057 (WebPlugin::supportsExtension):
1058 (WebPlugin::createExtension):
1059 * symbian/platformplugin/WebPlugin.h: Added.
1060 (Popup::preSelectedIndices):
1061 (Popup::listWidget):
1062 (WebNotificationPresenter::WebNotificationPresenter):
1063 (WebNotificationPresenter::~WebNotificationPresenter):
1064 * symbian/platformplugin/platformplugin.pro: Added.
1065 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
1066 (QWebSelectData::~QWebSelectData):
1067 (QWebSelectMethod::~QWebSelectMethod):
1068 (QWebNotificationData::~QWebNotificationData):
1069 (QWebNotificationPresenter::QWebNotificationPresenter):
1070 (QWebNotificationPresenter::~QWebNotificationPresenter):
1071 (QWebTouchModifier::~QWebTouchModifier):
1072 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
1073 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
1074 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
1076 2011-04-26 Yi Shen <yi.4.shen@nokia.com>
1078 Reviewed by Tor Arne Vestbø.
1080 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
1081 https://bugs.webkit.org/show_bug.cgi?id=56946
1083 Deployed the missing resource for Symbian platform.
1085 * tests/qwebframe/qwebframe.pro:
1087 2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
1089 Reviewed by Andreas Kling.
1091 [Qt] Build fix: QtDeclarative Webview element has a fixed white background
1092 https://bugs.webkit.org/show_bug.cgi?id=40918
1094 Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
1096 * declarative/plugin.cpp: Bump up required version to 4.7.4+
1097 (WebKitQmlPlugin::registerTypes):
1098 * declarative/qdeclarativewebview.cpp: ditto
1099 * declarative/qdeclarativewebview_p.h: ditto
1100 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
1102 2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1104 Reviewed by Csaba Osztrogonác.
1106 [Qt] Implement LayoutTestController::setAutofilled
1107 https://bugs.webkit.org/show_bug.cgi?id=59439
1109 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1110 (DumpRenderTreeSupportQt::setAutofilled):
1111 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1113 2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
1115 Unreviewed, rolling out r84627.
1116 http://trac.webkit.org/changeset/84627
1117 https://bugs.webkit.org/show_bug.cgi?id=59271
1119 It broke Symbian build (Requested by Ossy on #webkit).
1122 * symbian/platformplugin/WebPlugin.cpp: Removed.
1123 * symbian/platformplugin/WebPlugin.h: Removed.
1124 * symbian/platformplugin/platformplugin.pro: Removed.
1125 * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
1127 2011-04-22 Sam Weinig <sam@webkit.org>
1131 * Api/qwebelement.cpp:
1132 (setupScriptContext):
1134 2011-04-22 Yi Shen <yi.4.shen@nokia.com>
1136 Reviewed by Kenneth Rohde Christiansen.
1138 [Qt] Upstream Symbian platform plugin
1139 https://bugs.webkit.org/show_bug.cgi?id=58435
1141 Upstream Symbian platform plugin.
1143 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
1144 * symbian/platformplugin: Added.
1145 * symbian/platformplugin/WebPlugin.cpp: Added.
1146 (ItemListDelegate::ItemListDelegate):
1147 (ItemListDelegate::paint):
1149 (Popup::resizeEvent):
1150 (Popup::populateList):
1151 (Popup::onItemSelected):
1152 (Popup::updateSelectionsBeforeDialogClosing):
1153 (Popup::updateAndClose):
1154 (WebPopup::WebPopup):
1155 (WebPopup::~WebPopup):
1156 (WebPopup::createSingleSelectionPopup):
1157 (WebPopup::createMultipleSelectionPopup):
1158 (WebPopup::createPopup):
1161 (WebPopup::popupClosed):
1162 (WebPopup::itemClicked):
1163 (SingleSelectionPopup::SingleSelectionPopup):
1164 (MultipleSelectionPopup::MultipleSelectionPopup):
1165 (WebNotificationPresenter::showNotification):
1166 (WebPlugin::supportsExtension):
1167 (WebPlugin::createExtension):
1168 * symbian/platformplugin/WebPlugin.h: Added.
1169 (Popup::preSelectedIndices):
1170 (Popup::listWidget):
1171 (WebNotificationPresenter::WebNotificationPresenter):
1172 (WebNotificationPresenter::~WebNotificationPresenter):
1173 * symbian/platformplugin/platformplugin.pro: Added.
1174 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
1175 (QWebSelectData::~QWebSelectData):
1176 (QWebSelectMethod::~QWebSelectMethod):
1177 (QWebNotificationData::~QWebNotificationData):
1178 (QWebNotificationPresenter::QWebNotificationPresenter):
1179 (QWebNotificationPresenter::~QWebNotificationPresenter):
1180 (QWebTouchModifier::~QWebTouchModifier):
1181 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
1182 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
1183 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
1185 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1187 Reviewed by Sam Weinig.
1189 Add Frame* to the argument lists of canCopyCut and canPaste
1190 https://bugs.webkit.org/show_bug.cgi?id=59153
1192 * WebCoreSupport/EditorClientQt.cpp:
1193 (WebCore::EditorClientQt::canCopyCut):
1194 (WebCore::EditorClientQt::canPaste):
1195 * WebCoreSupport/EditorClientQt.h:
1197 2011-04-21 Yi Shen <yi.4.shen@nokia.com>
1199 Reviewed by Antonio Gomes.
1201 [Qt] Fix the style issue for Api/qwebkitplatformplugin.h
1202 https://bugs.webkit.org/show_bug.cgi?id=59097
1204 Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
1206 * Api/qwebkitplatformplugin.h:
1208 2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1210 Reviewed by Csaba Osztrogonác.
1212 [Qt] REGRESSION(84057): It made 4 API tests fail
1213 https://bugs.webkit.org/show_bug.cgi?id=58848
1215 After MIME sniffing support was added, some autotests are failing because
1216 the sniffer doesn't recognize our HTML pages.
1218 This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
1219 and tst_QWebFrame::horizontalScrollAfterBack().
1221 * tests/qwebframe/resources/testiframe.html:
1222 * tests/qwebframe/resources/testiframe2.html:
1223 Remove spurious </html> in beginning of the document.
1225 * tests/qwebpage/resources/framedindex.html:
1226 * tests/qwebpage/resources/index.html:
1227 Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
1228 possible starting tag for HTML document.
1230 * tests/qwebpage/tst_qwebpage.cpp:
1231 (tst_QWebPage::errorPageExtensionInFrameset):
1232 Verify if we do have a main frame and the main frame has the children frames we
1233 expect. This will avoid crashing if for some reason children frames are not
1236 2011-04-20 Dominic Cooney <dominicc@chromium.org>
1238 Reviewed by Dimitri Glazkov.
1240 layoutTestController can create and destroy shadow DOM
1241 https://bugs.webkit.org/show_bug.cgi?id=59058
1243 Support for new methods in Qt DRT.
1245 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1246 (DumpRenderTreeSupportQt::ensureShadowRoot):
1247 (DumpRenderTreeSupportQt::removeShadowRoot):
1248 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1250 2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
1252 Reviewed by Csaba Osztrogonác.
1254 [Qt] Cleanup includepath adjustment for generated files
1255 https://bugs.webkit.org/show_bug.cgi?id=58869
1257 * QtWebKit.pro: Revert the hacky fix in r84174. Remove
1260 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
1262 Reviewed by Andreas Kling.
1264 [Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
1265 https://bugs.webkit.org/show_bug.cgi?id=57254
1267 Skip test for setPalette() which doesn't work
1268 when WTF_USE_QT_MOBILE_THEME is defined.
1270 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1271 * tests/qwebview/tst_qwebview.cpp:
1274 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
1276 Reviewed by Laszlo Gombos.
1278 [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
1279 https://bugs.webkit.org/show_bug.cgi?id=58044
1281 Fixing this test by disabling the scrollbars on the graphics view
1282 since QtWebKit handles scrolling and scrollbar automatically and correctly.
1284 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1285 (tst_QGraphicsWebView::widgetsRenderingThroughCache):
1287 2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
1289 Reviewed by Andreas Kling.
1291 [Qt] X11: Text selection is causing oncopy event to be called
1292 https://bugs.webkit.org/show_bug.cgi?id=58656
1294 Always when text is selected the oncopy event is fired, this behavior does
1295 not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
1296 is making multi part-copies (with rich text metadata), the multi-part
1297 data can be obtained by data transfer items interface when supported by QtWebKit.
1298 Also, copies to the clipboard of a selected image, is not supported by Chrome and
1299 Firefox and was removed from QtWebKit.
1303 (QWebPagePrivate::handleClipboard):
1305 2011-04-18 Csaba Osztrogonác <ossy@webkit.org>
1307 [Qt][WK2] Unreviewed buildfix after r84174.
1309 * QtWebKit.pro: Missing includepath added.
1311 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
1313 Reviewed by Laszlo Gombos.
1315 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
1316 https://bugs.webkit.org/show_bug.cgi?id=57546
1318 Disable the fullscreen VKB when testing inputFieldFocus().
1320 * tests/qwebframe/tst_qwebframe.cpp:
1322 2011-04-18 Andreas Kling <kling@webkit.org>
1324 [Qt] DRT: Unreviewed test fix after r84168.
1326 Dump the original request KURL for blocked access attempts.
1327 Turns out converting it to a QUrl lower-cases the hostname.
1329 * WebCoreSupport/FrameLoaderClientQt.cpp:
1330 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1332 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
1334 Reviewed by Laszlo Gombos.
1336 [Qt] Fix Api tests for QWebPage on Symbian
1337 https://bugs.webkit.org/show_bug.cgi?id=56924
1339 Ignores the style attribute that selectedHtml() returns.
1341 * tests/qwebpage/tst_qwebpage.cpp:
1342 (tst_QWebPage::cursorMovements):
1343 (tst_QWebPage::textSelection):
1344 (tst_QWebPage::findText):
1346 2011-04-18 Andreas Kling <kling@webkit.org>
1348 Reviewed by Adam Barth.
1350 REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
1351 https://bugs.webkit.org/show_bug.cgi?id=58779
1353 KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
1354 QUrl instead to match the behavior of other ports.
1356 * WebCoreSupport/FrameLoaderClientQt.cpp:
1357 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1359 2011-04-18 Dominic Cooney <dominicc@chromium.org>
1361 Reviewed by Andreas Kling.
1363 Add layoutTestController.shadowRoot to Qt DRT.
1364 https://bugs.webkit.org/show_bug.cgi?id=58759
1366 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1367 (DumpRenderTreeSupportQt::shadowRoot): Added.
1368 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1370 2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1372 Reviewed by Andreas Kling.
1374 [Qt] Autotest got missed in the handover of the QML WebView element
1375 https://bugs.webkit.org/show_bug.cgi?id=41449
1377 Importing WebView QML element test cases from Qt repository. I did some
1378 style modifications and simplifications in the original code but hopefully
1379 without changing the behavior.
1381 Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
1382 issues currently are:
1384 - pixelCache() test checked the usage of pixel cache by using a subclass of
1385 QDeclarativeWebView. We can't do that right now because this class is not
1386 exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
1388 - elementAtArea() test uses a function that is not exported. But in this case
1389 I think we should test it's user, the public method "heuristicZoom".
1391 * tests/qdeclarativewebview/resources/basic.html: Added.
1392 * tests/qdeclarativewebview/resources/basic.png: Added.
1393 * tests/qdeclarativewebview/resources/basic.qml: Added.
1394 * tests/qdeclarativewebview/resources/elements.html: Added.
1395 * tests/qdeclarativewebview/resources/elements.qml: Added.
1396 * tests/qdeclarativewebview/resources/forward.html: Added.
1397 * tests/qdeclarativewebview/resources/forward.png: Added.
1398 * tests/qdeclarativewebview/resources/javaScript.html: Added.
1399 * tests/qdeclarativewebview/resources/javaScript.qml: Added.
1400 * tests/qdeclarativewebview/resources/loadError.qml: Added.
1401 * tests/qdeclarativewebview/resources/newwindows.html: Added.
1402 * tests/qdeclarativewebview/resources/newwindows.qml: Added.
1403 * tests/qdeclarativewebview/resources/propertychanges.qml: Added.
1404 * tests/qdeclarativewebview/resources/sethtml.qml: Added.
1405 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1406 (tst_QDeclarativeWebView::tmpDir):
1410 (tst_QDeclarativeWebView::cleanupTestCase):
1411 (tst_QDeclarativeWebView::basicProperties):
1412 (tst_QDeclarativeWebView::elementAreaAt):
1413 (tst_QDeclarativeWebView::historyNav):
1414 (callEvaluateJavaScript):
1415 (tst_QDeclarativeWebView::javaScript):
1416 (tst_QDeclarativeWebView::loadError):
1417 (tst_QDeclarativeWebView::multipleWindows):
1418 (tst_QDeclarativeWebView::newWindowComponent):
1419 (tst_QDeclarativeWebView::newWindowParent):
1420 (tst_QDeclarativeWebView::pressGrabTime):
1421 (tst_QDeclarativeWebView::renderingEnabled):
1422 (tst_QDeclarativeWebView::setHtml):
1423 (tst_QDeclarativeWebView::settings):
1424 (tst_QDeclarativeWebView::checkNoErrors):
1425 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1427 2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
1429 Reviewed by Kenneth Rohde Christiansen.
1431 [Qt] QWebPage MIME type handling inconsistency with other web browsers
1432 https://bugs.webkit.org/show_bug.cgi?id=46968
1434 Implementing mime type sniffing based on
1435 http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
1437 * WebCoreSupport/FrameLoaderClientQt.cpp:
1438 (WebCore::FrameLoaderClientQt::createNetworkingContext):
1439 * WebCoreSupport/FrameNetworkingContextQt.cpp:
1440 (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
1441 (WebCore::FrameNetworkingContextQt::create):
1442 (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
1443 * WebCoreSupport/FrameNetworkingContextQt.h:
1444 * tests/MIMESniffing/MIMESniffing.pro: Added.
1445 * tests/MIMESniffing/TestData.h: Added.
1446 * tests/MIMESniffing/resources.qrc: Added.
1447 * tests/MIMESniffing/resources/application_atom+xml: Added.
1448 * tests/MIMESniffing/resources/application_ogg: Added.
1449 * tests/MIMESniffing/resources/application_pdf: Added.
1450 * tests/MIMESniffing/resources/application_postscript: Added.
1451 * tests/MIMESniffing/resources/application_rdf+xml: Added.
1452 * tests/MIMESniffing/resources/application_rss+xml: Added.
1453 * tests/MIMESniffing/resources/application_x-gzip: Added.
1454 * tests/MIMESniffing/resources/application_x-rar-compressed: Added.
1455 * tests/MIMESniffing/resources/application_zip: Added.
1456 * tests/MIMESniffing/resources/audio_x-wave: Added.
1457 * tests/MIMESniffing/resources/image_bmp: Added.
1458 * tests/MIMESniffing/resources/image_gif: Added.
1459 * tests/MIMESniffing/resources/image_jpeg: Added.
1460 * tests/MIMESniffing/resources/image_png: Added.
1461 * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
1462 * tests/MIMESniffing/resources/image_webp: Added.
1463 * tests/MIMESniffing/resources/text_html: Added.
1464 * tests/MIMESniffing/resources/text_xml: Added.
1465 * tests/MIMESniffing/resources/video_webm: Added.
1466 * tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
1467 (tst_MIMESniffing::tst_MIMESniffing):
1469 (tst_MIMESniffing::testCase1):
1472 2011-04-15 Andreas Kling <kling@webkit.org>
1474 Reviewed by Antonio Gomes.
1476 [Qt] DRT: Block access to external URLs.
1478 Implement the "Blocked access to external URL" behavior for Qt's DRT,
1479 based on what other ports are doing.
1481 Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
1483 * WebCoreSupport/FrameLoaderClientQt.cpp:
1484 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1486 2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
1488 Reviewed by Antonio Gomes.
1490 [Qt] Web Inspector does not highlight elements
1491 https://bugs.webkit.org/show_bug.cgi?id=35125
1493 Adjust Web inspector to highlight elements on the page when the mouse
1494 hovers the element on DOM inspector.
1496 * Api/qwebframe.cpp:
1497 (QWebFramePrivate::renderRelativeCoords):
1498 * WebCoreSupport/InspectorClientQt.cpp:
1499 (WebCore::InspectorClientQt::highlight):
1500 (WebCore::InspectorClientQt::hideHighlight):
1502 2011-04-12 George Guo <George.Guo@nokia.com>
1504 Reviewed by Laszlo Gombos.
1506 [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
1507 http://bugs.webkit.org/show_bug.cgi?id=58141
1509 If QtWebKit is already in Symbian ROM, we need package to be
1514 2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
1516 Reviewed by Andreas Kling.
1518 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
1519 https://bugs.webkit.org/show_bug.cgi?id=58251
1521 Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
1523 * Api/qwebframe.cpp:
1524 (QWebFrame::QWebFrame):
1526 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
1528 Reviewed by Benjamin Poulain.
1530 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
1531 https://bugs.webkit.org/show_bug.cgi?id=58251
1533 Qt coding conventions states that private slots should be located in private implementation of
1534 the class. This allows us to rename/delete the slots in the future without breaking anything.
1536 No new tests added, just a simple refactoring.
1538 * Api/qwebframe.cpp:
1539 (QWebFramePrivate::_q_orientationChanged):
1541 * Api/qwebframe_p.h:
1543 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
1545 Reviewed by Kenneth Rohde Christiansen.
1547 [Qt] Sub-Frame content is not updated when scrolling in certain circumstances
1548 https://bugs.webkit.org/show_bug.cgi?id=50373
1550 Make sure that we invalidate the backing store when using TILED_BACKING_STORE
1551 and the page contains sub frames. This bug appears only when frame flattening is
1552 disabled and scrollable subframes.
1554 Original patch from Thomas Thrainer.
1556 * WebCoreSupport/ChromeClientQt.cpp:
1557 (WebCore::ChromeClientQt::invalidateWindow):
1559 2011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com>
1561 Reviewed by Andreas Kling.
1563 [Qt] HTML5 Drag and Drop demos not working
1564 https://bugs.webkit.org/show_bug.cgi?id=56486
1566 Handling the drop with JavaScript was not working with Qt because if the action is ignored
1567 in response to DragEnter, no further events are sent to the view.
1569 Drag and drop is defined and used differently by webpages. The drag move events are determining
1570 what action should take place. To adopt this behavior for Qt, we always accept drag enter events
1574 (QWebPagePrivate::dragEnterEvent):
1576 2011-04-11 Andras Becsi <abecsi@webkit.org>
1578 Reviewed by Andreas Kling.
1580 [Qt] REGRESSION(83122): tst_QWebElement::style() fails
1581 https://bugs.webkit.org/show_bug.cgi?id=58032
1583 According to the documentation of QWebElement the styleProperty method should
1584 not respect style inheritance and other CSS rules for the InlineStyle enum.
1586 r83122 fixed this behaviour.
1588 * tests/qwebelement/tst_qwebelement.cpp:
1589 (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
1591 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
1593 Build fix after r83436.
1595 * WebCoreSupport/FrameLoaderClientQt.cpp:
1596 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
1598 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
1600 Reviewed by Benjamin Poulain.
1602 [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
1604 * WebCoreSupport/FrameLoaderClientQt.cpp:
1605 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
1606 for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
1607 This is in line with the Mac port.
1609 2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
1611 Unreviewed, rolling out r83295.
1612 http://trac.webkit.org/changeset/83295
1613 https://bugs.webkit.org/show_bug.cgi?id=58144
1615 Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
1617 * WebCoreSupport/EditorClientQt.cpp:
1618 (WebCore::EditorClientQt::handleInputMethodKeydown):
1620 2011-04-08 Yi Shen <yi.4.shen@nokia.com>
1622 Reviewed by Antonio Gomes.
1624 [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
1625 https://bugs.webkit.org/show_bug.cgi?id=57472
1627 Avoid to insert new line for both keydown event & keypress event.
1629 * WebCoreSupport/EditorClientQt.cpp:
1630 (WebCore::EditorClientQt::handleInputMethodKeydown):
1632 2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1634 Reviewed by Benjamin Poulain.
1636 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
1637 https://bugs.webkit.org/show_bug.cgi?id=32723
1639 When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
1640 use an invalid URL (the begin() without arguments). Clearing the document
1641 with the same URL was causing problems when we had a fragment because it assume that
1642 only scrolling was enough and did not loaded the document again.
1644 When setUrl() is called but fails, url() is expected to return the requested value. The
1645 begin(url) guaranteed that before. This patch adds a member to track the URL, which is
1646 updated when the URL changes and also when setUrl() is called.
1648 KURL was used for the member so that when setUrl() is called, and then url() is checked
1649 before the page gets loaded, we perform the same conversion that will be performed by a
1650 successful load, e.g. add trailing '/' to an address. This behavior is checked by
1651 tst_QWebFrame::requestedUrl() test.
1653 For the record: the second QWebPage::setUrl() worked because the load was considered a
1654 FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
1655 needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
1657 * Api/qwebframe.cpp:
1658 (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
1661 (QWebFrame::setUrl):
1663 (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
1664 the baseURL, e.g. by using the <base> tag.
1665 * Api/qwebframe_p.h:
1667 * WebCoreSupport/FrameLoaderClientQt.cpp:
1668 (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
1669 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1671 * tests/qwebframe/tst_qwebframe.cpp:
1672 (tst_QWebFrame::setUrlWithFragment): unskip test.
1674 2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
1676 Reviewed by Kenneth Rohde Christiansen.
1678 Build fix when using Phonon as a backend for the multimedia support.
1680 * WebCoreSupport/ChromeClientQt.cpp:
1681 (WebCore::ChromeClientQt::ChromeClientQt):
1682 (WebCore::ChromeClientQt::~ChromeClientQt):
1683 * WebCoreSupport/ChromeClientQt.h:
1685 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
1687 Reviewed by Kenneth Rohde Christiansen.
1689 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1690 https://bugs.webkit.org/show_bug.cgi?id=56086
1692 Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
1693 from the LayoutTestController.
1695 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1696 (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
1697 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1699 2011-04-06 Anders Bakken <agbakken@gmail.com>
1701 Reviewed by Kenneth Rohde Christiansen.
1703 [Qt] FrameLoaderClientQt.cpp has coding-style errors
1704 https://bugs.webkit.org/show_bug.cgi?id=40254
1706 * WebCoreSupport/FrameLoaderClientQt.cpp:
1707 (drtDescriptionSuitableForTestResult):
1708 (WebCore::FrameLoaderClientQt::hasWebView):
1709 (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1710 (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1711 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1712 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
1713 (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1714 (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1715 (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
1716 (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
1717 (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1718 (WebCore::FrameLoaderClientQt::willChangeTitle):
1719 (WebCore::FrameLoaderClientQt::didChangeTitle):
1720 (WebCore::FrameLoaderClientQt::finishedLoading):
1721 (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1722 (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1723 (WebCore::FrameLoaderClientQt::didFinishLoad):
1724 (WebCore::FrameLoaderClientQt::setTitle):
1725 (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1726 (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
1727 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1728 (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
1729 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
1730 (WebCore::FrameLoaderClientQt::committedLoad):
1731 (WebCore::FrameLoaderClientQt::download):
1732 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1733 (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
1734 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1735 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1736 (WebCore::FrameLoaderClientQt::createFrame):
1737 (WebCore::FrameLoaderClientQt::objectContentType):
1738 (WebCore::FrameLoaderClientQt::createPlugin):
1740 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1742 Reviewed by Andreas Kling.
1744 [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1745 https://bugs.webkit.org/show_bug.cgi?id=57974
1747 We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1749 No new tests needed, just a config flag rename.
1751 * Api/qwebkitplatformplugin.h:
1752 * WebCoreSupport/ChromeClientQt.cpp:
1753 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1754 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1755 * WebCoreSupport/FullScreenVideoQt.cpp:
1756 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1757 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1758 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1759 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1760 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1761 (WebCore::FullScreenVideoQt::isValid):
1762 * WebCoreSupport/FullScreenVideoQt.h:
1763 * WebCoreSupport/QtPlatformPlugin.cpp:
1764 * WebCoreSupport/QtPlatformPlugin.h:
1765 * examples/platformplugin/WebPlugin.cpp:
1766 (WebPlugin::supportsExtension):
1767 (WebPlugin::createExtension):
1768 * examples/platformplugin/WebPlugin.h:
1769 * examples/platformplugin/platformplugin.pro:
1770 * examples/platformplugin/qwebkitplatformplugin.h:
1771 * tests/qwebpage/tst_qwebpage.cpp:
1772 (tst_QWebPage::loadHtml5Video):
1775 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1777 Reviewed by Andreas Kling.
1779 [Qt] Implement fullscreen playback for the GStreamer backend.
1780 https://bugs.webkit.org/show_bug.cgi?id=56826
1782 Implement support for fullscreen playback when building the
1783 Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
1784 The implementation is done in FullScreenVideoQt alongside with
1785 the Qt Multimedia support.
1787 No new tests because layout tests cover it. They are not yet activated
1788 but will be any time soon.
1791 * WebCoreSupport/ChromeClientQt.cpp:
1792 (WebCore::ChromeClientQt::ChromeClientQt):
1793 (WebCore::ChromeClientQt::~ChromeClientQt):
1794 (WebCore::ChromeClientQt::enterFullscreenForNode):
1795 (WebCore::ChromeClientQt::exitFullscreenForNode):
1796 * WebCoreSupport/ChromeClientQt.h:
1797 * WebCoreSupport/FullScreenVideoQt.cpp:
1798 (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
1799 (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
1800 (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
1801 (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
1802 (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
1803 (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
1804 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1805 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1806 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1807 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1808 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1809 (WebCore::FullScreenVideoQt::isValid):
1810 * WebCoreSupport/FullScreenVideoQt.h:
1811 (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
1813 2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1815 Reviewed by Kenneth Rohde Christiansen.
1817 [Qt] Improve tests for QWebFrame::url() and related methods
1818 https://bugs.webkit.org/show_bug.cgi?id=57865
1820 * tests/qwebframe/tst_qwebframe.cpp:
1821 (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
1822 (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
1823 that fails and a load() that fails (for a different URL).
1825 (tst_QWebFrame::setUrlWithFragment_data):
1826 (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
1827 the URL in the frame before the test starts.
1829 (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
1830 the same URL as argument.
1833 (tst_QWebFrame::setUrlThenLoads_data):
1834 (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
1835 sequence of set and loads. Those tests are interesting because the properties
1836 react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
1837 is used or after the load() is committed and baseUrl() is similar to url() but also depends
1838 on the contents of the page when it loads.
1840 2011-04-04 MORITA Hajime <morrita@google.com>
1842 Reviewed by Ryosuke Niwa.
1844 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1845 https://bugs.webkit.org/show_bug.cgi?id=56085
1847 * WebCoreSupport/EditorClientQt.h:
1848 (WebCore::EditorClientQt::requestCheckingOfString):
1850 2011-04-04 Chang Shu <cshu@webkit.org>
1852 Reviewed by Ryosuke Niwa.
1854 setContentEditable with true/false/inherit string is not working properly
1855 https://bugs.webkit.org/show_bug.cgi?id=52058
1857 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
1858 as rendererIsEditable is for WebCore internal use.
1860 * WebCoreSupport/EditorClientQt.cpp:
1861 (WebCore::EditorClientQt::handleKeyboardEvent):
1863 2011-04-01 Carol Szabo <carol.szabo@nokia.com>
1865 Reviewed by Benjamin Poulain.
1867 Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
1868 Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
1870 Tiled painting still causes synchronous layout when
1871 accelerated compositing and texture mapper are enabled
1872 https://bugs.webkit.org/show_bug.cgi?id=56929
1874 * Api/qwebframe.cpp:
1875 (QWebFramePrivate::renderFromTiledBackingStore):
1876 (QWebFramePrivate::renderRelativeCoords):
1877 (QWebFramePrivate::renderFrameWidgets):
1878 * Api/qwebframe_p.h:
1880 2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
1882 Reviewed by Benjamin Poulain.
1884 [Qt] DragClientQt.h has coding-style errors
1885 https://bugs.webkit.org/show_bug.cgi?id=40425
1887 * WebCoreSupport/DragClientQt.h:
1889 2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
1891 Reviewed by Kenneth Rohde Christiansen.
1893 [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
1894 https://bugs.webkit.org/show_bug.cgi?id=57017
1896 Build fix. No new tests.
1900 2011-03-31 Evan Martin <evan@chromium.org>
1904 * WebCoreSupport/FrameLoaderClientQt.cpp:
1905 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1907 2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
1909 Reviewed by Benjamin Poulain.
1911 [Qt] ChromeClientQt.h has coding-style errors
1912 https://bugs.webkit.org/show_bug.cgi?id=40239
1914 * WebCoreSupport/ChromeClientQt.h:
1915 (WebCore::ChromeClientQt::scrollbarsModeDidChange):
1916 (WebCore::ChromeClientQt::needTouchEvents):
1917 (WebCore::ChromeClientQt::formStateDidChange):
1918 (WebCore::ChromeClientQt::scrollRectIntoView):
1919 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1920 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1922 2011-03-31 Evan Martin <evan@chromium.org>
1924 Build fix from previous change.
1926 * Api/qwebframe.cpp:
1929 2011-03-31 Evan Martin <evan@chromium.org>
1931 Reviewed by Eric Seidel.
1933 <title> should support dir attribute
1934 https://bugs.webkit.org/show_bug.cgi?id=50961
1936 Update to new FrameLoaderClient interface.
1938 * WebCoreSupport/FrameLoaderClientQt.cpp:
1939 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1940 (WebCore::FrameLoaderClientQt::setTitle):
1941 * WebCoreSupport/FrameLoaderClientQt.h:
1943 2011-03-30 Yi Shen <yi.4.shen@nokia.com>
1945 Reviewed by Kenneth Rohde Christiansen.
1947 [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
1948 https://bugs.webkit.org/show_bug.cgi?id=57020
1950 Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
1952 * tests/qwebview/tst_qwebview.cpp:
1953 (tst_QWebView::focusInputTypes):
1955 2011-03-30 Robert Hogan <robert@webkit.org>
1957 Reviewed by Antonio Gomes.
1959 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1961 Add DRT support for loading an alternate HTML string
1962 for error pages. This allows Qt to unskip
1963 http/tests/navigation/go-back-to-error-page.html.
1965 https://bugs.webkit.org/show_bug.cgi?id=52614
1967 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1968 (DumpRenderTreeSupportQt::setAlternateHtml):
1969 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1971 2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
1973 Unreviewed build fix for build-webkit -minimal.
1975 Breakage introduced by http://trac.webkit.org/changeset/82238.
1976 The minimal option has no support for shortcuts.
1978 * WebCoreSupport/EditorClientQt.cpp:
1979 (WebCore::EditorClientQt::handleInputMethodKeydown):
1981 2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
1983 Reviewed by Kenneth Rohde Christiansen.
1985 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
1986 https://bugs.webkit.org/show_bug.cgi?id=33179
1988 Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
1990 * WebCoreSupport/EditorClientQt.cpp:
1991 (WebCore::EditorClientQt::handleInputMethodKeydown):
1992 * tests/qwebpage/tst_qwebpage.cpp:
1993 (tst_QWebPage::inputMethods):
1995 2011-03-29 Andreas Kling <kling@webkit.org>
1997 Reviewed by Simon Hausmann.
1999 [Qt] Fix documentation for QWebPage::repaintRequested()
2001 This signal is always emitted when the page is dirtied, so remove
2002 reference to old behavior where we would only emit the signal for
2007 2011-03-28 Andreas Kling <kling@webkit.org>
2009 Reviewed by Benjamin Poulain.
2011 [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
2013 * WebCoreSupport/FrameLoaderClientQt.cpp:
2014 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2016 2011-03-28 Andreas Kling <kling@webkit.org>
2018 Reviewed by Benjamin Poulain.
2020 [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
2021 https://bugs.webkit.org/show_bug.cgi?id=52629
2023 * WebCoreSupport/ChromeClientQt.cpp:
2024 (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
2025 QWebPage::repaintRequested() use a Qt::QueuedConnection.
2027 * tests/qwebpage/tst_qwebpage.cpp:
2028 (RepaintRequestedRenderer::RepaintRequestedRenderer):
2029 (RepaintRequestedRenderer::onRepaintRequested):
2030 (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
2031 QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
2032 doesn't cause recursive signal emissions.
2034 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
2036 Reviewed by Andreas Kling.
2038 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2039 https://bugs.webkit.org/show_bug.cgi?id=57087
2041 * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
2042 * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
2043 since they are applications, not libraries.
2045 2011-03-28 Andras Becsi <abecsi@webkit.org>
2047 Reviewed by Csaba Osztrogonác.
2049 [Qt] QtWebKit does not link with --3d-canvas using MinGW
2050 https://bugs.webkit.org/show_bug.cgi?id=57225
2052 * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
2054 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
2056 Reviewed by Andreas Kling.
2058 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
2059 https://bugs.webkit.org/show_bug.cgi?id=57183
2061 Windows buildfix after r82065.
2063 * Api/DerivedSources.pro: Readding escaping on Windows platforms.
2065 2011-03-27 Andreas Kling <kling@webkit.org>
2067 Fix build warning about IconDatabaseClient.h (wrong path.)
2071 2011-03-27 Andreas Kling <kling@webkit.org>
2073 Reviewed by Kenneth Rohde Christiansen.
2075 [Qt] Support for CSS color and background-color properties on select element's dropdown list
2076 https://bugs.webkit.org/show_bug.cgi?id=51627
2078 Extend the QWebSelectData interface with background and foreground colors
2079 for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
2080 getters in RenderMenuList.
2082 * Api/qwebkitplatformplugin.h:
2083 * WebCoreSupport/PopupMenuQt.cpp:
2084 (SelectData::backgroundColor):
2085 (SelectData::foregroundColor):
2086 (SelectData::itemBackgroundColor):
2087 (SelectData::itemForegroundColor):
2088 * WebCoreSupport/QtFallbackWebPopup.cpp:
2089 (WebCore::QtFallbackWebPopup::show):
2090 (WebCore::QtFallbackWebPopup::populate):
2092 2011-03-27 Yi Shen <yi.4.shen@nokia.com>
2094 Reviewed by Andreas Kling.
2096 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
2097 https://bugs.webkit.org/show_bug.cgi?id=57108
2099 Since the canvas is not self-closing tag, we need to add '</canvas>'.
2101 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2102 (tst_QGraphicsWebView::microFocusCoordinates):
2103 * tests/qwebview/tst_qwebview.cpp:
2104 (tst_QWebView::microFocusCoordinates):
2106 2011-03-27 Kwang Yul Seo <skyul@company100.net>
2108 Reviewed by Eric Seidel.
2110 [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
2111 https://bugs.webkit.org/show_bug.cgi?id=57143
2113 Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
2114 define WTF_USE_TEXTURE_MAPPER=1.
2118 2011-03-27 Andreas Kling <kling@webkit.org>
2120 Reviewed by Benjamin Poulain.
2122 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
2123 https://bugs.webkit.org/show_bug.cgi?id=57183
2125 The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
2126 which was due to the outputting code previously being wrapped in eval().
2128 * Api/DerivedSources.pro:
2130 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2132 Reviewed by Andreas Kling.
2134 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2135 https://bugs.webkit.org/show_bug.cgi?id=57087
2137 Use explicit conversion for string to avoid depending on the default codec
2138 installed by the user code.
2140 * Api/qwebkitversion.cpp:
2143 (QWebPagePrivate::dynamicPropertyChangeEvent):
2144 (QWebPage::javaScriptConsoleMessage):
2145 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2146 (convertToPropertyName):
2147 (DumpRenderTreeSupportQt::setEditingBehavior):
2148 (DumpRenderTreeSupportQt::plainText):
2149 * WebCoreSupport/EditorClientQt.cpp:
2151 * WebCoreSupport/FrameLoaderClientQt.cpp:
2152 (drtDescriptionSuitableForTestResult):
2153 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
2154 * WebCoreSupport/InspectorClientQt.cpp:
2155 (WebCore::InspectorClientQt::openInspectorFrontend):
2156 * WebCoreSupport/InspectorServerQt.cpp:
2157 (WebCore::parseWebSocketChallengeNumber):
2158 (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
2160 2011-03-26 Andreas Kling <kling@webkit.org>
2162 Reviewed by Kenneth Rohde Christiansen.
2164 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
2165 https://bugs.webkit.org/show_bug.cgi?id=57157
2167 Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
2168 is always emitted when appropriate.
2170 * QtWebKit.pro: Add new files.
2172 * WebCoreSupport/IconDatabaseClientQt.h: Added.
2173 * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
2174 (WebCore::IconDatabaseClientQt::instance):
2175 (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
2176 (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
2177 (WebCore::IconDatabaseClientQt::performImport):
2178 (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
2179 (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
2180 (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
2181 (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
2182 (WebCore::IconDatabaseClientQt::didFinishURLImport):
2184 * WebCoreSupport/FrameLoaderClientQt.h:
2185 * WebCoreSupport/FrameLoaderClientQt.cpp:
2186 (WebCore::FrameLoaderClientQt::registerForIconNotification):
2187 (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
2188 to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
2189 QWebFrame::iconChanged() signal when the IconDatabases finishes loading
2190 a cached favicon for the frame's URL.
2192 * Api/qwebsettings.cpp:
2193 (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
2194 instantiated. An IconDatabaseClient has to be registered before the IconDatabase
2195 spawns its reader thread.
2197 2011-03-25 Andy Estes <aestes@apple.com>
2199 Reviewed by Adele Peterson.
2201 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2202 https://bugs.webkit.org/show_bug.cgi?id=49016
2204 Update objectContentType() implementation to handle the
2205 shouldPreferPlugInsForImages flag.
2207 * WebCoreSupport/FrameLoaderClientQt.cpp:
2208 (WebCore::FrameLoaderClientQt::objectContentType):
2209 * WebCoreSupport/FrameLoaderClientQt.h:
2211 2011-03-25 Chang Shu <cshu@webkit.org>
2213 Reviewed by Ryosuke Niwa.
2215 rename Node::isContentEditable and all call sites to rendererIsEditable
2216 https://bugs.webkit.org/show_bug.cgi?id=54290
2218 This is part of the effort to separate JS API HTMLElement isContentEditable from
2219 internal Node::rendererIsEditable.
2221 * WebCoreSupport/EditorClientQt.cpp:
2222 (WebCore::EditorClientQt::handleKeyboardEvent):
2224 2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
2226 Reviewed by Andreas Kling.
2228 [Qt] The keyboard shortcuts during fullscreen playback do not work.
2229 https://bugs.webkit.org/show_bug.cgi?id=57095
2231 We need to explicitely set the focus on the widget in order to receive the keyboard events.
2233 * WebCoreSupport/FullScreenVideoWidget.cpp:
2234 (WebCore::FullScreenVideoWidget::show):
2236 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
2238 Unreviewed, rolling out r81916 and r81917.
2239 http://trac.webkit.org/changeset/81916
2240 http://trac.webkit.org/changeset/81917
2241 https://bugs.webkit.org/show_bug.cgi?id=57071
2243 broke a test on platforms that do not have QuickTime installed
2244 (Requested by estes on #webkit).
2246 * WebCoreSupport/FrameLoaderClientQt.cpp:
2247 (WebCore::FrameLoaderClientQt::objectContentType):
2248 * WebCoreSupport/FrameLoaderClientQt.h:
2250 2011-03-24 Andy Estes <aestes@apple.com>
2252 Reviewed by Darin Adler.
2254 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2255 https://bugs.webkit.org/show_bug.cgi?id=49016
2257 Update objectContentType() implementation to handle the
2258 shouldPreferPlugInsForImages flag.
2260 * WebCoreSupport/FrameLoaderClientQt.cpp:
2261 (WebCore::FrameLoaderClientQt::objectContentType):
2262 * WebCoreSupport/FrameLoaderClientQt.h:
2264 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
2266 Reviewed by Kenneth Rohde Christiansen.
2268 [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
2269 https://bugs.webkit.org/show_bug.cgi?id=40884
2271 Add tests and benchmarks for the software fallback of WebGL.
2273 * tests/benchmarks/webgl/10000_triangles.html: Added.
2274 * tests/benchmarks/webgl/tst_webgl.cpp: Added.
2275 (GraphicsView::GraphicsView):
2276 (GraphicsView::resizeEvent):
2277 (tst_WebGlPerformance::init):
2278 (tst_WebGlPerformance::cleanup):
2279 (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
2280 (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
2281 (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
2282 (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
2283 (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
2284 * tests/benchmarks/webgl/tst_webgl.qrc: Added.
2285 * tests/benchmarks/webgl/webgl.pro: Added.
2286 * tests/qgraphicswebview/qgraphicswebview.pro:
2287 * tests/qgraphicswebview/resources/pointing_right.html: Added.
2288 * tests/qgraphicswebview/resources/pointing_up.html: Added.
2289 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2290 (compareImagesFuzzyPixelCount):
2291 (GraphicsView::GraphicsView):
2292 (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
2293 (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
2294 (tst_QGraphicsWebView::compareCanvasToImage):
2295 * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
2298 2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
2300 Reviewed by Benjamin Poulain.
2302 Avoided ASCII-cast warnings for WebKit.
2304 Normally they won't be enabled anyway, but if you build webkit from
2305 within the Qt mother repository it will pick up Qt's default build
2306 settings, which do enable it. We need to disable them because
2307 warnings are treated as errors and there are way too many of them in
2310 [Qt] Avoid ASCII-cast warnings for WebKit.
2311 https://bugs.webkit.org/show_bug.cgi?id=57016
2315 2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2317 Reviewed by Benjamin Poulain.
2319 [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
2320 https://bugs.webkit.org/show_bug.cgi?id=29595
2322 Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
2323 ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
2324 prepending the current directory.
2326 By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
2327 will end up loading "about:blank", but keeping it as a requested URL.
2329 This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
2330 is filled for the loaded URLs as well, we can use it in every case.
2332 Three new autotests were added, to better cover the expected behavior of setting
2333 the QUrl() in a QWebFrame.
2335 * Api/qwebframe.cpp:
2336 (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
2337 (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
2339 * WebCoreSupport/FrameLoaderClientQt.cpp:
2340 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
2341 anymore, since we always rely on it even for loaded frames.
2343 * tests/qwebframe/tst_qwebframe.cpp:
2344 (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
2345 the reduction of the bug report.
2346 (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
2347 (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
2349 2011-03-23 Brady Eidson <beidson@apple.com>
2351 Reviewed by Sam Weinig.
2353 Change IconDatabase opening to allow for arbitrary filenames
2354 https://bugs.webkit.org/show_bug.cgi?id=56977
2356 * Api/qwebsettings.cpp:
2357 (QWebSettings::setIconDatabasePath):
2359 2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
2361 Reviewed by Andreas Kling.
2363 [Qt] QtWebKit rendering problem when maximizing and doing a back
2364 https://bugs.webkit.org/show_bug.cgi?id=56669
2367 Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
2369 * tests/qwebview/tst_qwebview.cpp:
2370 (tst_QWebView::rendering):
2372 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
2374 Reviewed by Pavel Feldman.
2376 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2377 https://bugs.webkit.org/show_bug.cgi?id=56843
2379 * WebCoreSupport/InspectorClientQt.cpp:
2380 (WebCore::InspectorClientQt::openInspectorFrontend):
2382 2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
2384 Reviewed by Benjamin Poulain.
2386 [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
2387 https://bugs.webkit.org/show_bug.cgi?id=54138
2389 * tests/qwebpage/tst_qwebpage.cpp:
2390 (webGLScreenshotWithoutView):
2391 (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
2392 (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
2393 Render a QWebPage (with and without accelerated compositing)
2394 with a WebGL context that has no owning view. Shouldn't crash.
2396 2011-03-21 Chang Shu <cshu@webkit.org>
2398 Reviewed by Alexey Proskuryakov.
2400 REGRESSION (r79953): Can't type in MS Outlook 2011
2401 https://bugs.webkit.org/show_bug.cgi?id=56665
2403 r79953 removed the WebView level editablity which is persistent no matter whether
2404 underlying document itself is changed and editability gets lost. The resolution is to
2405 set this WebView editable value to WebCore. This avoids the callback from WebCore to
2406 WebKit which was the main goal in r79953 to improve performance.
2409 (QWebPage::setContentEditable):
2410 (QWebPage::isContentEditable):
2412 2011-03-19 Andreas Kling <kling@webkit.org>
2414 Reviewed by Benjamin Poulain.
2416 [Qt] Remove support for Qt 4.6
2417 https://bugs.webkit.org/show_bug.cgi?id=56712
2419 * Api/qwebframe.cpp:
2422 (QWebPagePrivate::QWebPagePrivate):
2423 * Api/qwebsettings.cpp:
2424 (QWebSettings::QWebSettings):
2425 * WebCoreSupport/GeolocationClientQt.cpp:
2426 (WebCore::GeolocationClientQt::positionUpdated):
2428 2011-03-19 Andreas Kling <kling@webkit.org>
2430 Reviewed by Antonio Gomes.
2432 [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
2433 https://bugs.webkit.org/show_bug.cgi?id=56711
2435 Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
2436 ownership of the reply is transferred to the receiving slot.
2440 2011-03-17 Brady Eidson <beidson@apple.com>
2442 Reviewed by Sam Weinig.
2444 https://bugs.webkit.org/show_bug.cgi?id=56425
2445 More groundwork for WebKit2 IconDatabase
2447 Update already-used function names:
2448 * Api/qwebhistory.cpp:
2449 (QWebHistoryItem::icon):
2450 * Api/qwebsettings.cpp:
2451 (QWebSettings::iconForUrl):
2453 2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
2455 Reviewed by Benjamin Poulain.
2457 [Qt] console.log not being exposed to QmlViewer
2458 https://bugs.webkit.org/show_bug.cgi?id=56536
2460 The documentation is bogus the feature does not exist.
2462 * declarative/qdeclarativewebview.cpp:
2464 2011-03-17 Andreas Kling <kling@webkit.org>
2466 Reviewed by Kenneth Rohde Christiansen.
2468 [Qt] QML WebView emits iconChanged() when the page title changes
2469 https://bugs.webkit.org/show_bug.cgi?id=56570
2471 * declarative/qdeclarativewebview.cpp:
2472 (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
2473 signal to the view's iconChanged signal.
2475 2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
2477 Reviewed by Benjamin Poulain.
2479 [Qt] Videos look ugly when using QGraphicsWebView.
2480 https://bugs.webkit.org/show_bug.cgi?id=56580
2482 We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
2483 QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
2484 by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
2485 QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
2486 ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
2487 in addition of what could be set on the painter. In order to not break the rendering of all the items in the
2488 scene we set back the painter to its original state when QGraphicsWebView is rendered.
2490 * Api/qgraphicswebview.cpp:
2491 (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
2492 (QGraphicsWebView::paint):
2493 (QGraphicsWebView::renderHints):
2494 (QGraphicsWebView::setRenderHints):
2495 (QGraphicsWebView::setRenderHint):
2496 * Api/qgraphicswebview.h:
2497 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2498 (tst_QGraphicsWebView::renderHints):
2500 2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
2502 Reviewed by Kenneth Rohde Christiansen.
2504 Viewport no longer allows an auto value for "user-scalable"
2505 https://bugs.webkit.org/show_bug.cgi?id=55416
2507 Make the default value for userScalable be true.
2510 (QWebPage::viewportAttributesForSize):
2511 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2512 (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
2514 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
2516 Reviewed by Darin Adler.
2518 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2519 info into the headers rather than in export symbol definition files, but disable it on
2520 all platforms initially so we can deal with port build issues one port at a time.
2522 https://bugs.webkit.org/show_bug.cgi?id=27551
2524 * WebCoreSupport/GeolocationClientQt.cpp:
2525 * WebCoreSupport/PopupMenuQt.cpp:
2527 2011-03-14 Brady Eidson <beidson@apple.com>
2529 Reviewed by Anders Carlsson.
2531 https://bugs.webkit.org/show_bug.cgi?id=56320
2532 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2534 * Api/qwebhistory.cpp:
2535 (QWebHistoryItem::icon): Use IconDatabase directly.
2537 2011-03-11 Brady Eidson <beidson@apple.com>
2539 Reviewed by attempt at build fix!
2541 https://bugs.webkit.org/show_bug.cgi?id=56216
2542 Fix the Qt build following the same pattern of the patch.
2544 * Api/qwebsettings.cpp:
2545 (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
2547 2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
2549 Reviewed by Ariya Hidayat.
2551 [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
2552 https://bugs.webkit.org/show_bug.cgi?id=56181
2554 We need to stop the auto hide cursor timer when closing the widget otherwise the timer
2555 might get fired and therefore hide the cursor even when the fullscreen widget is closed.
2557 * WebCoreSupport/FullScreenVideoWidget.cpp:
2558 (WebCore::FullScreenVideoWidget::closeEvent):
2560 2011-03-10 David Boddie <david.boddie@nokia.com>
2562 Reviewed by Andreas Kling.
2564 Fixed a qdoc warning and terminology (WebKit instead of Webkit).
2565 https://bugs.webkit.org/show_bug.cgi?id=55756
2567 * Api/qwebhistoryinterface.cpp:
2569 2011-03-10 Andreas Kling <kling@webkit.org>
2571 Unreviewed build fix after r80774.
2573 QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
2574 See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
2576 * declarative/plugin.cpp:
2577 (WebKitQmlPlugin::registerTypes):
2578 * declarative/qdeclarativewebview.cpp:
2579 * declarative/qdeclarativewebview_p.h:
2580 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2582 2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
2584 Reviewed by Andreas Kling.
2586 [Qt] QtDeclarative Webview element has a fixed white background
2587 https://bugs.webkit.org/show_bug.cgi?id=40918
2589 Implement a way to change the background color of the WebView QML element.
2590 This feature is activated for QtWebKit 1.1 version of the plugin.
2592 * declarative/plugin.cpp:
2593 (WebKitQmlPlugin::registerTypes):
2594 * declarative/qdeclarativewebview.cpp:
2595 (QDeclarativeWebView::backgroundColor):
2596 (QDeclarativeWebView::setBackgroundColor):
2597 * declarative/qdeclarativewebview_p.h:
2598 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
2599 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2600 (tst_QDeclarativeWebView::backgroundColor):
2601 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2603 2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
2605 Reviewed by Laszlo Gombos.
2607 [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
2608 https://bugs.webkit.org/show_bug.cgi?id=55945
2610 Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
2611 set interval used to trigger when decoded data in dead list of object cache will
2612 be purged from object cache.
2615 (QWebPagePrivate::dynamicPropertyChangeEvent):
2617 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2619 Reviewed by Antonio Gomes.
2621 Simplify how QWebFrame::requestedUrl() is obtained
2622 https://bugs.webkit.org/show_bug.cgi?id=55842
2624 When a load starts, store the requested URL until we know that it'll be
2625 available for us in the document loader -- after load finished.
2627 The existing auto tests cover the three different code paths in
2628 requestedUrl() and the new code passes the autotests. In each of those
2629 cases, we looked for the information in a different place, but in all
2630 of them, dispatchDidStartProvisionalLoad was called.
2632 This simplification will be useful to fix bug 32723. The way requestedUrl()
2633 is implementent, we can't use it as a fallback for url() when the setUrl()
2634 was called with an invalid URL.
2636 * Api/qwebframe.cpp:
2637 (QWebFrame::requestedUrl):
2638 * WebCoreSupport/FrameLoaderClientQt.cpp:
2639 (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
2640 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
2641 * WebCoreSupport/FrameLoaderClientQt.h:
2642 (WebCore::FrameLoaderClientQt::lastRequestedUrl):
2644 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2646 Reviewed by Kenneth Rohde Christiansen.
2648 Tiled backing store's delegated scroll request uses incorrect convention
2649 https://bugs.webkit.org/show_bug.cgi?id=56011
2651 Adapt internal API to match the change from delta to point on the
2652 WebCore side, and convert the point to a delta for the public API.
2654 * WebCoreSupport/ChromeClientQt.cpp:
2655 (WebCore::ChromeClientQt::delegatedScrollRequested):
2656 * WebCoreSupport/ChromeClientQt.h:
2658 2011-03-09 Peter Kasting <pkasting@google.com>
2660 Reviewed by Mihai Parparita.
2662 Unify Windows version checks.
2663 https://bugs.webkit.org/show_bug.cgi?id=55979
2666 (QWebPage::userAgentForUrl):
2668 2011-03-07 Sam Weinig <sam@webkit.org>
2670 Reviewed by Anders Carlsson.
2672 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2673 https://bugs.webkit.org/show_bug.cgi?id=55827
2675 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2676 and pass the entire response, instead of just the MIMEType.
2678 * WebCoreSupport/FrameLoaderClientQt.cpp:
2679 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
2680 * WebCoreSupport/FrameLoaderClientQt.h:
2682 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
2684 Reviewed by Laszlo Gombos.
2686 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
2687 https://bugs.webkit.org/show_bug.cgi?id=48636
2689 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
2692 (QWebPage::userAgentForUrl):
2694 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
2696 Reviewed by Kenneth Rohde Christiansen.
2698 [QT] Implement mock client-based geolocation for layout testing
2699 https://bugs.webkit.org/show_bug.cgi?id=54334
2701 Implement layout testing for Client-Based geolocation. If drt_run is set
2702 then create mock geolocationClient and update the same with controller.
2705 (QWebPagePrivate::QWebPagePrivate):
2706 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2707 (DumpRenderTreeSupportQt::mockGeolocationReset):
2708 (DumpRenderTreeSupportQt::setMockGeolocationPermission):
2709 (DumpRenderTreeSupportQt::setMockGeolocationPosition):
2710 (DumpRenderTreeSupportQt::setMockGeolocationError):
2711 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2712 * WebCoreSupport/GeolocationClientQt.cpp:
2713 (WebCore::GeolocationClientQt::GeolocationClientQt):
2714 * WebCoreSupport/GeolocationClientQt.h:
2716 2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2718 Reviewed by Kenneth Rohde Christiansen.
2720 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
2721 https://bugs.webkit.org/show_bug.cgi?id=32723
2723 Create an auto-test for Qt based on the bug description.
2725 * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
2727 2011-03-03 Brady Eidson <beidson@apple.com>
2729 Reviewed by Darin Adler.
2731 https://bugs.webkit.org/show_bug.cgi?id=55721
2732 Global IconDatabase should be returned by reference, not as a pointer
2734 * Api/qwebsettings.cpp:
2735 (QWebSettings::setIconDatabasePath):
2736 (QWebSettings::iconDatabasePath):
2737 (QWebSettings::clearIconDatabase):
2738 (QWebSettings::iconForUrl):
2740 2011-03-03 Alexey Proskuryakov <ap@apple.com>
2742 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2745 * WebCoreSupport/ChromeClientQt.h:
2747 2011-03-02 Alexey Proskuryakov <ap@apple.com>
2749 Reviewed by Darin Adler.
2751 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2752 https://bugs.webkit.org/show_bug.cgi?id=55633
2753 <rdar://problem/8963023>
2755 * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
2756 * WebCoreSupport/ChromeClientQt.h:
2757 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2758 this platform doesn't observe or have full keyboard access state.
2760 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
2762 Reviewed by Andreas Kling.
2764 [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
2765 https://bugs.webkit.org/show_bug.cgi?id=55568
2767 We should use updateMicroFocus() from QGraphicsItem rather than the implementation
2768 in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
2769 In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
2772 * Api/qgraphicswebview.cpp:
2773 (QGraphicsWebView::setPage):
2774 * Api/qgraphicswebview.h:
2776 2011-03-03 Peter Kasting <pkasting@google.com>
2778 Reviewed by James Robinson.
2780 Drop redundant "Windows; " from the Windows-specific User Agent string.
2781 https://bugs.webkit.org/show_bug.cgi?id=54567
2784 (QWebPage::userAgentForUrl):
2786 2011-03-01 Brian Weinstein <bweinstein@apple.com>
2788 Reviewed by Adam Roben.
2790 Part of WebKit2: Need a way to send notifications to client when cookies change
2791 https://bugs.webkit.org/show_bug.cgi?id=55427
2792 <rdar://problem/9056027>
2794 Add stubs for CookiesStrategy on Qt WebKit1.
2796 * WebCoreSupport/WebPlatformStrategies.cpp:
2797 (WebPlatformStrategies::createCookiesStrategy):
2798 (WebPlatformStrategies::notifyCookiesChanged):
2799 * WebCoreSupport/WebPlatformStrategies.h:
2801 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2803 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
2806 (QWebPage::viewportAttributesForSize):
2807 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2808 (DumpRenderTreeSupportQt::viewportAsText):
2810 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2812 Reviewed by Kenneth Rohde Christiansen.
2814 Viewport Warning/Error Messages Are Now Inaccurate
2815 https://bugs.webkit.org/show_bug.cgi?id=53707
2818 (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
2819 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2820 (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
2822 2011-03-01 Andras Becsi <abecsi@webkit.org>
2824 Reviewed by Csaba Osztrogonác.
2826 [Qt] Clean up the project files and move common options to WebKit.pri.
2828 * QtWebKit.pro: Move common options to WebKit.pri.
2830 2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
2832 Reviewed by Simon Hausmann.
2834 [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
2835 https://bugs.webkit.org/show_bug.cgi?id=55319
2837 The test case required internet connection to be able to connect to
2838 google.com. Added new html file which refers to local html file.
2840 * tests/qwebpage/resources/content.html: Added.
2841 * tests/qwebpage/resources/frame_c.html: Added.
2842 * tests/qwebpage/resources/framedindex.html: Added.
2843 * tests/qwebpage/tst_qwebpage.cpp:
2844 (tst_QWebPage::backActionUpdate):
2845 * tests/qwebpage/tst_qwebpage.qrc:
2847 2011-02-25 Steve Block <steveblock@google.com>
2849 Reviewed by Jeremy Orlow.
2851 Bridge.h should not include BridgeJSC.h
2852 https://bugs.webkit.org/show_bug.cgi?id=55212
2854 Include BridgeJSC.h directly instead.
2856 * Api/qwebframe.cpp:
2858 2011-02-28 Chang Shu <cshu@webkit.org>
2860 Reviewed by Ryosuke Niwa.
2862 Remove the support of Frame::isContentEditable and its dependencies.
2863 https://bugs.webkit.org/show_bug.cgi?id=54292
2865 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2868 (QWebPagePrivate::QWebPagePrivate):
2869 (QWebPage::setContentEditable):
2870 (QWebPage::isContentEditable):
2872 * WebCoreSupport/EditorClientQt.cpp:
2873 * WebCoreSupport/EditorClientQt.h:
2875 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2877 Reviewed by Oliver Hunt.
2879 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
2881 * Api/qwebelement.cpp:
2882 (QWebElement::evaluateJavaScript):
2884 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2886 Reviewed by Andreas Kling.
2888 [Qt]tst_QDeclarativeWebView - 8 test cases fail
2889 https://bugs.webkit.org/show_bug.cgi?id=55214
2891 Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
2892 if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
2893 I also refactored the tests so we don't use the network but instead a local html file.
2894 QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
2896 * tests/qdeclarativewebview/resources/sample.html: Added.
2897 * tests/qdeclarativewebview/resources/webviewtest.qml:
2898 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
2899 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2900 (tst_QDeclarativeWebView::preferredWidthTest):
2901 (tst_QDeclarativeWebView::preferredHeightTest):
2902 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
2903 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
2904 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2906 2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
2908 Reviewed by Andreas Kling.
2910 [Qt] Add clipped version of QWebElement::render method.
2911 Allows faster rendering of web element part.
2912 https://bugs.webkit.org/show_bug.cgi?id=50311
2914 * Api/qwebelement.cpp:
2915 (QWebElement::render):
2916 * Api/qwebelement.h:
2917 * tests/qwebelement/tst_qwebelement.cpp:
2918 (tst_QWebElement::render):
2920 2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
2922 Reviewed by Andreas Kling.
2924 Added full webkit module profile and a syncqt profile.
2926 This is for modularized Qt.
2928 [Qt] WebKit patches required to work with a modularized version of Qt
2929 https://bugs.webkit.org/show_bug.cgi?id=53916
2931 * qt_webkit_version.pri:
2933 2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
2935 Reviewed by Antonio Gomes.
2937 [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
2938 https://bugs.webkit.org/show_bug.cgi?id=53917
2940 Adding test case to check the scenario to avoid regressions in the
2943 * tests/qwebframe/tst_qwebframe.cpp:
2945 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2947 Reviewed by Andreas Kling.
2949 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
2950 https://bugs.webkit.org/show_bug.cgi?id=55322
2952 Documentation update, add a reference to the QtWebKit bridge page.
2954 * Api/qwebframe.cpp:
2956 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2958 Reviewed by Pavel Feldman.
2960 DumpRenderTree should reset frame opener between tests.
2961 https://bugs.webkit.org/show_bug.cgi?id=54874
2963 Added clearOpener method to DumpRenderTreeSupportQT.
2965 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2966 (DumpRenderTreeSupportQt::clearOpener):
2967 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2969 2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
2971 Reviewed by Andreas Kling.
2973 Make it possible to test the targetdensity-dpi support
2974 https://bugs.webkit.org/show_bug.cgi?id=55142
2976 Test the viewport meta tag feature targetdensity-dpi by
2977 adding extra arguments to dumpConfigurationForViewport
2979 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2980 (DumpRenderTreeSupportQt::viewportAsText):
2981 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2983 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
2985 Unreviewed, rolling out r79764.
2986 http://trac.webkit.org/changeset/79764
2987 https://bugs.webkit.org/show_bug.cgi?id=55295
2989 "broke Chromium builds" (Requested by rniwa on #webkit).
2991 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2992 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2994 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2996 Reviewed by Pavel Feldman.
2998 DumpRenderTree should reset frame opener between tests.
2999 https://bugs.webkit.org/show_bug.cgi?id=54874
3001 Added clearOpener method to DumpRenderTreeSupportQT.
3003 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3004 (DumpRenderTreeSupportQt::clearOpener):
3005 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3007 2011-02-25 Andras Becsi <abecsi@webkit.org>
3009 Reviewed by Csaba Osztrogonác.
3011 [Qt] Make the WebKit2 build system less confusing for non-Qt developers
3012 https://bugs.webkit.org/show_bug.cgi?id=55213
3014 * QtWebKit.pro: Move the WebKit2 API into a project include file
3015 in the WebKit2 directory and include the pri file here.
3017 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
3019 Unreviewed build fix for Intel ICC and MSVC.
3021 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3022 (tst_QGraphicsWebView::setPalette):
3023 * tests/qwebview/tst_qwebview.cpp:
3024 (tst_QWebView::setPalette):
3026 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
3028 Reviewed by Kenneth Rohde Christiansen.
3030 [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
3031 https://bugs.webkit.org/show_bug.cgi?id=31742
3033 Discovered while looking at 31742. When we set a palette on the
3034 QGraphicsWebView we need to propagate it to the page like QWebView.
3035 I have added the same tests as QWebView to be sure to catch potential
3036 regressions as well as two extras QVERIFY to check the palette propagation.
3038 * Api/qgraphicswebview.cpp:
3039 (QGraphicsWebView::event):
3040 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3041 (tst_QGraphicsWebView::setPalette_data):
3042 (tst_QGraphicsWebView::setPalette):
3044 2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
3046 Unreviewed buildfix after r79672.
3048 [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
3053 2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
3055 Reviewed by Kenneth Rohde Christiansen.
3057 [Qt] QML WebView inside a Flickable shows checkers pattern at startup
3058 https://bugs.webkit.org/show_bug.cgi?id=50222.
3060 This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
3062 * declarative/qdeclarativewebview.cpp:
3063 (QDeclarativeWebView::init):
3064 * tests/qdeclarativewebview: Added.
3065 * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
3066 * tests/qdeclarativewebview/resources: Added.
3067 * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
3068 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
3069 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
3070 (tst_QDeclarativeWebView::initTestCase):
3071 (tst_QDeclarativeWebView::cleanupTestCase):
3072 (tst_QDeclarativeWebView::init):
3073 (tst_QDeclarativeWebView::cleanup):
3074 (tst_QDeclarativeWebView::preferredWidthTest):
3075 (tst_QDeclarativeWebView::preferredHeightTest):
3076 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
3077 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
3078 (tst_QDeclarativeWebView::checkNoErrors):
3082 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
3084 Reviewed by Andreas Kling.
3086 [Qt] Revert the support for QNAM affined to a different thread.
3087 https://bugs.webkit.org/show_bug.cgi?id=55149
3089 Qt 4.8 will have QNAM use its own thread internally by default,
3090 no need to keep this complexity in WebKit.
3092 This mainly reverts:
3093 http://trac.webkit.org/changeset/73710
3094 http://trac.webkit.org/changeset/73712
3096 * WebCoreSupport/FrameLoaderClientQt.cpp:
3097 (WebCore::FrameLoaderClientQt::download):
3098 * tests/qwebpage/tst_qwebpage.cpp:
3100 2011-02-24 Sam Weinig <sam@webkit.org>
3102 Try to fix the Qt build.
3106 2011-02-24 Peter Kasting <pkasting@google.com>
3108 Reviewed by Eric Seidel.
3110 Drop the "U; " encryption level from the User Agent string.
3111 https://bugs.webkit.org/show_bug.cgi?id=54566
3114 (QWebPage::userAgentForUrl):
3116 2011-02-24 Andrew Wilson <atwilson@chromium.org>
3118 Unreviewed, rolling out r79570.
3119 http://trac.webkit.org/changeset/79570
3120 https://bugs.webkit.org/show_bug.cgi?id=54874
3122 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
3125 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3126 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3128 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
3130 Reviewed by Alexey Proskuryakov.
3132 DumpRenderTree should reset frame opener between tests.
3133 https://bugs.webkit.org/show_bug.cgi?id=54874
3135 Added clearOpener method to DumpRenderTreeSupportQT.
3137 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3138 (DumpRenderTreeSupportQt::clearOpener):
3139 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3141 2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
3143 Reviewed by Andreas Kling.
3145 [Qt] tst_QWebView::setPalette(activeFG) fails
3146 https://bugs.webkit.org/show_bug.cgi?id=55029
3148 This time it should be the proper fix. The window needs to be shown before we
3149 call activateWindow() otherwise there is no active windows for the application.
3151 * tests/qwebview/tst_qwebview.cpp:
3152 (tst_QWebView::setPalette):
3154 2011-02-24 Andras Becsi <abecsi@webkit.org>
3156 Reviewed by Laszlo Gombos.
3158 [Qt] MinGW build fails to link
3159 https://bugs.webkit.org/show_bug.cgi?id=55050
3161 Prepend the libraries of subcomponents instead of appending them
3162 to fix the library order according to the dependency of the libraries
3164 * QtWebKit.pro: prepend libraries in the correct order
3166 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
3168 Reviewed by Ariya Hidayat.
3170 [Qt] tst_QWebView::setPalette(activeFG) fails
3171 https://bugs.webkit.org/show_bug.cgi?id=55029
3173 Attempt to make the test more robust. By investigating with the bot virtual machine
3174 I discovered that the activation can take some time. In this patch we make sure that
3175 the active window we want to have is the same as the QApplication.
3177 * tests/qwebview/tst_qwebview.cpp:
3178 (tst_QWebView::setPalette):
3180 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
3182 Reviewed by Dan Bernstein.
3184 [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
3185 http://trac.webkit.org/changeset/79167 refactored the way the bound size of
3186 the frame is handled. A new API setBoundsSize was added, we need to call it
3187 in addition to setFrameRect. I could call setBoundSize after setFrameRect but
3188 I thought It would be more elegant to use the resize method.
3191 (QWebPage::setViewportSize):
3193 2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
3195 Reviewed by Laszlo Gombos.
3197 [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
3198 https://bugs.webkit.org/show_bug.cgi?id=54976
3202 * WebCoreSupport/InspectorClientQt.cpp:
3204 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
3206 Reviewed by Andreas Kling.
3208 [Qt] QWebView ignores a palette set with QWebView::setPalette()
3209 https://bugs.webkit.org/show_bug.cgi?id=31742
3211 Test case to check that the palette sets on the QWebView is taken
3214 * tests/qwebview/tst_qwebview.cpp:
3215 (tst_QWebView::setPalette_data):
3216 (tst_QWebView::setPalette):
3218 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
3220 Reviewed by Alexey Proskuryakov.
3222 Drop the language tag part from the User Agent string
3223 https://bugs.webkit.org/show_bug.cgi?id=54560
3226 (QWebPage::userAgentForUrl):
3228 * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
3231 2011-02-22 Chang Shu <cshu@webkit.org>
3233 Reviewed by Csaba Osztrogonác.
3235 [Qt] editing/deleting/5408255.html fails
3236 https://bugs.webkit.org/show_bug.cgi?id=54964
3238 Move WebCore resource file to QtWebKit since they are referred in WebKit.
3242 2011-02-22 Andras Becsi <abecsi@webkit.org>
3244 Reviewed by Csaba Osztrogonác.
3246 [Qt] Redesign the build system
3247 https://bugs.webkit.org/show_bug.cgi?id=51339
3249 Move inspector's resource files into the final build step to fix the layout test regression.
3251 * QtWebKit.pro: Add inspector's reaource files.
3253 2011-02-22 Andras Becsi <abecsi@webkit.org>
3255 Reviewed by Laszlo Gombos.
3256 Rubber-stamped by Csaba Osztrogonác.
3258 [Qt] Redesign the build system
3259 https://bugs.webkit.org/show_bug.cgi?id=51339
3261 The patch landed in r79320 didn't contain the cleanup
3262 which was already addressed in the last attachment.
3264 * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
3266 2011-02-22 Andras Becsi <abecsi@webkit.org>
3268 Reviewed by Laszlo Gombos.
3270 [Qt] Redesign the build system
3271 https://bugs.webkit.org/show_bug.cgi?id=51339
3275 Build WebCore as a static library, compile the WebKit API and WebKit2 API
3276 in a final step and link to WebKit2, WebCore and JSC libraries to fix
3277 linking issues resulting from stripped away symbols.
3279 * QtWebKit.pro: Added.
3280 Project file for the final build step.
3282 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
3284 Reviewed by Kent Tamura.
3286 Rename Position::node() to Position::deprecatedNode()
3287 https://bugs.webkit.org/show_bug.cgi?id=54622
3289 Replaced the call to node() by a call to containerNode() because the returned node is
3290 used to determine whether or not the selected contents are editable and such a check
3291 must be done against the container node.
3293 * WebCoreSupport/EditorClientQt.cpp:
3294 (WebCore::EditorClientQt::handleKeyboardEvent):
3296 2011-02-19 Charlie Reis <creis@chromium.org>
3298 Reviewed by Mihai Parparita.
3300 Ensure loading has stopped in HistoryController::goToItem
3301 https://bugs.webkit.org/show_bug.cgi?id=54517
3303 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
3305 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
3307 * WebCoreSupport/FrameLoaderClientQt.cpp:
3308 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
3309 * WebCoreSupport/FrameLoaderClientQt.h:
3311 2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
3313 Reviewed by Eric Seidel.
3315 Remove reduntant checks.
3316 https://bugs.webkit.org/show_bug.cgi?id=54764
3319 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3320 (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
3321 * WebCoreSupport/NotificationPresenterClientQt.cpp:
3322 (WebCore::NotificationPresenterClientQt::toPage):
3324 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
3328 [Qt] Buildfix for platforms with geolocation disabled.
3330 * Api/qwebpage.cpp: Add the missing guard.
3332 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
3334 Reviewed by Kenneth Rohde Christiansen.
3336 [Qt] Implement client based geolocation for qtport
3337 https://bugs.webkit.org/show_bug.cgi?id=42629
3339 Implements client based geolocation for qtwebkit.
3340 New client based geolocation contains permission API's as well,
3341 so removed the implementation from ChromeClientQt.cpp.
3344 (QWebPagePrivate::QWebPagePrivate):
3345 * WebCoreSupport/ChromeClientQt.cpp:
3346 * WebCoreSupport/ChromeClientQt.h:
3347 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
3348 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
3349 * WebCoreSupport/GeolocationClientQt.cpp: Added.
3350 (WebCore::GeolocationClientQt::GeolocationClientQt):
3351 (WebCore::GeolocationClientQt::~GeolocationClientQt):
3352 (WebCore::GeolocationClientQt::geolocationDestroyed):
3353 (WebCore::GeolocationClientQt::positionUpdated):
3354 (WebCore::GeolocationClientQt::startUpdating):
3355 (WebCore::GeolocationClientQt::stopUpdating):
3356 (WebCore::GeolocationClientQt::setEnableHighAccuracy):
3357 (WebCore::GeolocationClientQt::requestPermission):
3358 (WebCore::GeolocationClientQt::cancelPermissionRequest):
3359 * WebCoreSupport/GeolocationClientQt.h: Added.
3360 (WebCore::GeolocationClientQt::lastPosition):
3362 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
3364 Reviewed by Adam Roben.
3366 HTML5 <details> and <summary>: localized text
3367 https://bugs.webkit.org/show_bug.cgi?id=54260
3369 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
3370 provide the default label to be used by a <details> tag that has no <summary> child.
3372 * WebCoreSupport/WebPlatformStrategies.cpp:
3373 (WebPlatformStrategies::defaultDetailsSummaryText):
3374 * WebCoreSupport/WebPlatformStrategies.h:
3376 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
3378 Reviewed by Laszlo Gombos.
3380 The URL of HTML5 Video Element is percent encoded at websites such as youtube.
3381 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
3382 the HTTP GET request for the video to be rejected by the service provider.
3383 https://bugs.webkit.org/show_bug.cgi?id=53973.
3385 The bug is fixed by constructing QUrl from the encoded URL in
3386 MediaPlayerPrivateQt::commitLoad.
3388 New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
3389 HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
3390 is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
3391 A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
3392 is skipped if Qt Multimedia is not available.
3394 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3395 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
3396 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3397 * tests/qwebpage/tst_qwebpage.cpp:
3398 (tst_QWebPage::loadHtml5Video):
3401 2011-02-17 Andreas Kling <kling@webkit.org>
3403 Reviewed by Antti Koivisto.
3405 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
3406 https://bugs.webkit.org/show_bug.cgi?id=49216
3408 * tests/qwebframe/tst_qwebframe.cpp:
3410 == Rolled over to ChangeLog-2011-02-16 ==