2011-06-27 Joe Wild <joseph.wild@nokia.com>
authorcommit-queue <commit-queue@webkit.org>
Mon, 27 Jun 2011 23:26:18 +0000 (23:26 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 28 Jun 2011 14:48:18 +0000 (11:48 -0300)
commitdad7a554ae7d1437be3383ea019e8dd146acdcf0
treef9c88456165583b955df117d6fc8b8453bc516ce
parent8fea0b27b1215b2b77a08a99698c01ff9325af9d
2011-06-27  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Simon Fraser.

        Crash on www.crave.cnet.com in FrameView::windowClipRect()
        https://bugs.webkit.org/show_bug.cgi?id=56393

        Tests that a plugin of a swf file in a hidden iframe will not
        crash. This test required more than 1 content file and a
        timeout or else it would not repeat the error condition.

        This test will only crash on platforms (like Symbian) that
        don't allow nonvirtual functions to have a null this pointer.

        * plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
        * plugins/hidden-iframe-with-swf-plugin.html: Added.
        * plugins/resources/iframe-content-with-swf-plugin.html: Added.
2011-06-27  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Simon Fraser.

        Crash on www.crave.cnet.com in FrameView::windowClipRect()
        https://bugs.webkit.org/show_bug.cgi?id=56393

        Check for a null renderer to fix a crash. This situation can
        arise when external content/plugins is referenced from html
        elements with style="display:none".

        Test: plugins/hidden-iframe-with-swf-plugin.html

        * page/FrameView.cpp:
        (WebCore::FrameView::windowClipRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/plugins/hidden-iframe-with-swf-plugin-expected.txt [new file with mode: 0644]
LayoutTests/plugins/hidden-iframe-with-swf-plugin.html [new file with mode: 0644]
LayoutTests/plugins/resources/iframe-content-with-swf-plugin.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/page/FrameView.cpp