2010-10-04 Yael Aharon <yael.aharon@nokia.com>
authorYael Aharon <yael.aharon@nokia.com>
Tue, 5 Oct 2010 04:28:54 +0000 (04:28 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 5 Oct 2010 14:50:53 +0000 (16:50 +0200)
commitcb60b0d1f829c12cb63ebba579fb4d630c0f4563
tree680ba5b723de8963c1b100f46ba2d3b69c01ba26
parente6e21bedda8dd6b0c039910eb2853efb49d4a5c3
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        * fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-multiple-select.html: Added.
        * fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-single-select.html: Added.
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
        to navigate out of the select element. That is because select element currently uses the
        arrow keys to change the selected element.
        Change the behavior of select element so it does not change selection, if Spatial Navigation
        is on.

        This patch is addressing the case where Spatial Navigation is used
        in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
        In the future we can add support for the case where the flag is off, and
        the user needs to traverse the select element inline.

        Tests: fast/events/spatial-navigation/snav-multiple-select.html
               fast/events/spatial-navigation/snav-single-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/events/spatial-navigation/snav-multiple-select-expected.txt [new file with mode: 0644]
LayoutTests/fast/events/spatial-navigation/snav-multiple-select.html [new file with mode: 0644]
LayoutTests/fast/events/spatial-navigation/snav-single-select-expected.txt [new file with mode: 0644]
LayoutTests/fast/events/spatial-navigation/snav-single-select.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/dom/SelectElement.cpp