2011-05-20 Andy Estes <aestes@apple.com>
authorAndy Estes <aestes@apple.com>
Sat, 21 May 2011 01:07:16 +0000 (01:07 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Mon, 23 May 2011 14:27:24 +0000 (11:27 -0300)
commitc6d8071e014a5ad07aa4919671a1e6a5d9b3be2f
treea4c8031e0ea1c622ea0f5985a2391c4589dd7d4f
parent1aba52447192ce236234ae365d3bb9c698113bc7
2011-05-20  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
        https://bugs.webkit.org/show_bug.cgi?id=61229

        Test that an object element with a non-empty classid, a valid MIME
        type and no fallback content is allowed to load.

        * fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt:
        * fast/replaced/object-with-non-empty-classid-triggers-fallback.html:
2011-05-20  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r70748): WebKit cannot play videos created by Podcast Producer.
        https://bugs.webkit.org/show_bug.cgi?id=61229

        Podcast Producer uses an object tag with a classid attribute to embed
        QuickTime Player into a page. In r70748, we changed our behavior to
        render the object's fallback content when a non-empty classid is
        encountered, per HTML5. Since Podcast Producer videos have no fallback
        content, this change in behavior causes the video to fail to load.

        Since the object tag has a valid type attribute, we would be able to
        load it if weren't for the non-empty classid. This patch changes our
        policy to allow objects with non-empty classids if there is no fallback
        content. We still continue to prefer fallback content if it exists,
        however.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::hasValidClassId): Treat a non-empty
        classid as valid if the object has no fallback content.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt
LayoutTests/fast/replaced/object-with-non-empty-classid-triggers-fallback.html
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLObjectElement.cpp