2010-09-09 Simon Fraser <simon.fraser@apple.com>
authorSimon Fraser <simon.fraser@apple.com>
Fri, 10 Sep 2010 01:07:58 +0000 (01:07 +0000)
committerSimon Hausmann <simon.hausmann@nokia.com>
Thu, 30 Sep 2010 14:00:33 +0000 (16:00 +0200)
commitbf85131bbb1f9679c66cdc87bf86bca53b4afde1
treef085c8874d89eeeeaf7d48ace6aa0784a8e91185
parent9615fdd44e325a1e0fa5052073f41de3baefec06
2010-09-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=45509
        <rdar://problem/8142166> REGRESSION: WebView setDrawsBackground:NO no
        longer works without setBackgroundColor:clearColor

        r61215 caused RenderView to paint the viewport background when the
        document element's renderer is known to not fill opaquely paint
        the entire viewport, i.e. more often than it did before.

        This exposed a latent, long-standing bug which was introduced
        in r14638 (the RenderCanvas -> RenderView rename), where a call
        to view()->isTransparent() was not converted to frameView()->isTransparent(),
        yet happened to still compile because of RenderObject::isTransparent().

        This resulted in us painting the viewport background, even when
        WebView clients explicitly said that they wanted a transparent
        WebView.

        Fixed by calling frameView()->isTransparent(), as intended.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/rendering/RenderView.cpp