2011-05-13 Abhishek Arya <inferno@chromium.org>
authorAbhishek Arya <inferno@chromium.org>
Fri, 13 May 2011 18:17:12 +0000 (18:17 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 17 May 2011 14:41:53 +0000 (11:41 -0300)
commitb3f49dca0ced5dbe834f32f89230bb6852d483d4
tree376eec88eca6a2f0b81ba82295c8a211931cfcce
parent457a0f01f64329b3d064f4855ba9a98ce426371f
2011-05-13  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Regression(r75823): Revert initialization back to the first RenderBlock
        in the parent chain.
        https://bugs.webkit.org/show_bug.cgi?id=60780

        Test: fast/block/float/float-not-removed-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
        In r75823, I forgot to initialize parentBlock, when the original code
        did and Hyatt did mention in c#5. Now, initializing parentBlock to the
        first RenderBlock in the parent chain.
2011-05-13  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to access a deleted float.
        https://bugs.webkit.org/show_bug.cgi?id=60780

        * fast/block/float/float-not-removed-crash-expected.txt: Added.
        * fast/block/float/float-not-removed-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/block/float/float-not-removed-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/float/float-not-removed-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.cpp