2011-06-23 Abhishek Arya <inferno@chromium.org>
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Thu, 30 Jun 2011 17:49:47 +0000 (14:49 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Thu, 30 Jun 2011 17:49:47 +0000 (14:49 -0300)
commitab9eda4db60e443eb6ef477c80da64031102ba6e
tree8730e2adab9c7bd70a1ef299659940585931874b
parent6f7f62f4fa45217da4dba868c80c7d715674bcc3
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        In RenderBlock, RenderWidget and RenderReplaced destroy functions,
        call dirtyLinesFromChangedChild to tell our parent that we are going away.
        https://bugs.webkit.org/show_bug.cgi?id=60307

        Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html
              fast/block/block-not-removed-from-parent-lineboxes-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::destroy):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::destroy):
        * rendering/RenderReplaced.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Tests that we do not crash when failing to remove the linebreak
        object(widget, block, replaced, etc) from parent block lineboxes. The
        testcase tries to fuzz over the list of html and svg tags.
        https://bugs.webkit.org/show_bug.cgi?id=60307

        * fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
        * fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added.
        * fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
        * fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/rendering/RenderReplaced.h
LayoutTests/ChangeLog
LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html [new file with mode: 0644]
LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RenderReplaced.cpp
Source/WebCore/rendering/RenderReplaced.h
Source/WebCore/rendering/RenderWidget.cpp