webkit:qtwebkit.git
11 years agoTry to make some xssAuditor tests less flakey.
Ademar de Souza Reis Jr [Wed, 11 May 2011 19:45:53 +0000 (16:45 -0300)]
Try to make some xssAuditor tests less flakey.
https://bugs.webkit.org/show_bug.cgi?id=44749

Reviewed by Simon Fraser.

Use postMessage() to communicate to the top window each time a
beforeload event fires in the iframe. When the top window has seen a
beforeload event from each widget in the iframe, it calls notifyDone().
This prevents the test from exiting before all the widgets have had a
chance to load, therefore ensuring that all relevant XSS Auditor
messages have been emitted.

* http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-control-char.html:
* http/tests/security/xssAuditor/object-embed-tag-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char.html:
* http/tests/security/xssAuditor/object-embed-tag.html:
* http/tests/security/xssAuditor/object-src-inject.html:
* http/tests/security/xssAuditor/object-tag-javascript-url.html:
* http/tests/security/xssAuditor/object-tag.html:
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* http/tests/security/xssAuditor/resources/echo-object-src.pl:
* http/tests/security/xssAuditor/resources/utilities.js:
(notifyDoneAfterReceivingBeforeloadFromIds):
* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/mac/Skipped

11 years agoFix more LayoutTests (expectation changes after 06e2e7d) qtwebkit-2.1.x-week18
Ademar de Souza Reis Jr [Mon, 9 May 2011 14:47:48 +0000 (11:47 -0300)]
Fix more LayoutTests (expectation changes after 06e2e7d)

Patch from Laszlo Gombos <laszlo.1.gombos@nokia.com> for the qtwebkit-2.1
branch, unreviewed.

11 years agoFix LayoutTests (Skipped list + expected results)
Ademar de Souza Reis Jr [Mon, 9 May 2011 14:37:27 +0000 (11:37 -0300)]
Fix LayoutTests (Skipped list + expected results)

Patch from Laszlo Gombos <laszlo.1.gombos@nokia.com> for the
qtwebkit-2.1 branch, unreviewed.

11 years agoFlaky Test: fast/events/tabindex-focus-blur-all.html
Ademar de Souza Reis Jr [Mon, 9 May 2011 14:33:53 +0000 (11:33 -0300)]
Flaky Test: fast/events/tabindex-focus-blur-all.html
https://bugs.webkit.org/show_bug.cgi?id=52115

* platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped

11 years ago2010-10-04 Sriram Neelakandan <sriram.neelakandan@gmail.com> qtwebkit-2.1.x-week17
commit-queue [Tue, 5 Oct 2010 04:16:20 +0000 (04:16 +0000)]
2010-10-04  Sriram Neelakandan  <sriram.neelakandan@gmail.com>

        Reviewed by Andreas Kling.

        [Qt] QNetworkReplyHandler forces buffered output for FormData with files
        https://bugs.webkit.org/show_bug.cgi?id=46259

        No new tests. Existing form submit tests should cover this change.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::FormDataIODevice::FormDataIODevice):
        (WebCore::FormDataIODevice::computeSize):
         Add computeSize() for computing form device size
        (WebCore::QNetworkReplyHandler::start):
         Call computeSize(), fill Content-Length and prevent UploadData buffering
        * platform/network/qt/QNetworkReplyHandler.h:
        (WebCore::FormDataIODevice::getFormDataSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crash when trying to access the enclosing layer without a renderer
Ademar de Souza Reis Jr [Fri, 29 Apr 2011 13:42:48 +0000 (10:42 -0300)]
Fix crash when trying to access the enclosing layer without a renderer

https://bugs.webkit.org/show_bug.cgi?id=56393
Without checking whether renderer of the element exists,tries to find the layer

This patch has not been accepted on trunk yet due to the lack of tests.

Patch from Kundu Suchismita <suchi.kundu@nokia.com>

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x qtwebkit-2.1.1-beta1 qtwebkit-2.1.x-week15 qtwebkit-2.1.x-week16
Ademar de Souza Reis Jr [Fri, 15 Apr 2011 15:34:46 +0000 (12:34 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years agoSkip failing tests which are not going to be fixed in the short term qtwebkit-2.1.0
Ademar de Souza Reis Jr [Fri, 15 Apr 2011 14:32:17 +0000 (11:32 -0300)]
Skip failing tests which are not going to be fixed in the short term

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com>

11 years ago2011-04-08 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Ademar de Souza Reis Jr [Wed, 13 Apr 2011 18:25:46 +0000 (15:25 -0300)]
2011-04-08  Misha Tyutyunik  <michael.tyutyunik@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Plugin is not scrolled together with page content or jumping
        when content is rendered using cache (backing store).
        https://bugs.webkit.org/show_bug.cgi?id=56130

        This is a Symbian portion of the fix. For Linux it looks like
        it's enough to call set geometry which should be addressed in
        https://bugs.webkit.org/show_bug.cgi?id=57179

        No new tests required. This can be tested with manual tests from
        WebCore/manual-tests/qt and WebCore/manual-tests/plugins

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::updatePluginWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/plugins/symbian/PluginViewSymbian.cpp

11 years ago2010-08-20 Abhishek Arya <inferno@chromium.org>
inferno [Fri, 20 Aug 2010 18:00:21 +0000 (18:00 +0000)]
2010-08-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Prevent use of stale notification presenter pointer in notifications by instead using
        a notification center pointer and deriving the presenter from it. Notification presenter
        gets properly destroyed using disconnectFrame function inside notification center. Add
        null checks for notification presenter.
        https://bugs.webkit.org/show_bug.cgi?id=43645

        Test: fast/notifications/notifications-window-close-crash.html

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        (WebCore::Notification::create):
        (WebCore::Notification::show):
        (WebCore::Notification::cancel):
        (WebCore::Notification::contextDestroyed):
        (WebCore::Notification::finishLoading):
        * notifications/Notification.h:
        (WebCore::Notification::detachPresenter):
        * notifications/NotificationCenter.h:
        (WebCore::NotificationCenter::createHTMLNotification):
        (WebCore::NotificationCenter::createNotification):
2010-08-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Manual test to check that canceling the notification on a closed window does
        not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=43645

        * fast/notifications/notifications-window-close-crash-expected.txt: Added.
        * fast/notifications/notifications-window-close-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix mistake during cherry-pick of r74220 qtwebkit-2.1.x-week14
Caio Marcelo de Oliveira Filho [Fri, 8 Apr 2011 13:42:21 +0000 (10:42 -0300)]
Fix mistake during cherry-pick of r74220

Rubber stamped by Laszlo Gombos.

Fabrizio noticed that the cherry-pick of r74220 in commit
dcbf037442a531c9da18a879f91bedfe141aaea0 was incorrect. This commit
fix it and add an early return to simplify the code (like the
implementation in trunk).

https://bugs.webkit.org/show_bug.cgi?id=51208

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x qtwebkit-2.1.x-week13
Luiz Agostini [Thu, 31 Mar 2011 18:37:00 +0000 (15:37 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years agoInput[type=number] should step by 1. by default qtwebkit-2.1-week12-1 qtwebkit-2.1-week13 qtwebkit-2.1-week14
Luiz Agostini [Thu, 31 Mar 2011 18:10:33 +0000 (15:10 -0300)]
Input[type=number] should step by 1. by default
https://bugs.webkit.org/show_bug.cgi?id=56054

Patch by Fabrizio Machado <fabrizio.machado@nokia.com> on 2011-03-29
Reviewed by Laszlo Gombos.

If current value of input element is not finite when stepping up/down, set it current to zero
and then set current's value on the input element.  This prevents a garbage value from appearing
the input box after user activates and presses up/down key.

Test:  no test, this fix already exists in trunk, we are cherry picking the needed code for 2.1.x branch

* html/HTMLInputElement.cpp:
(HTMLInputElement::stepUpFromRenderer):

11 years ago[Qt] Text layout is broken on Symbian
Luiz Agostini [Wed, 30 Mar 2011 16:17:54 +0000 (13:17 -0300)]
[Qt] Text layout is broken on Symbian
https://bugs.webkit.org/show_bug.cgi?id=56046

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-03-09
Reviewed by Laszlo Gombos.

Change integers included into bitfields to be signed by default on RVCT
compiler as a lot of other compilers do (gcc, msvc, winsc).
There are a lot of places in webkit where integers included in bitfield
are assumed to be signed.

* WebKit.pri:

11 years ago2010-12-17 Ariya Hidayat <ariya@sencha.com> qtwebkit-2.1.x-week12
Ariya Hidayat [Fri, 17 Dec 2010 16:26:55 +0000 (16:26 +0000)]
2010-12-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        Adjust the test since SmoothPixmapTransform is set by default.

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::renderHints):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-16 Ariya Hidayat <ariya@sencha.com>
Ariya Hidayat [Fri, 17 Dec 2010 01:44:53 +0000 (01:44 +0000)]
2010-12-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        GraphicsContext does not override SmoothPixmapTransform (see also
        r62762). To keep the same behavior, canvas default image interpolation
        quality is set to medium and QWebView's render hints by default also
        include SmoothPixmapTransform.

        * html/HTMLCanvasElement.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2010-12-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        Add some checks to ensure that GraphicsContext (via QWebFrame)
        does not clobber the render hints.

        * Api/qwebview.cpp:
        (QWebViewPrivate::QWebViewPrivate):
        * tests/qwebframe/tst_qwebframe.cpp:

QtWebKit 2.1.x notes:
    Minor change in the patch to fit into this branch version of
    GraphicsContextPlatformPrivate constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-23 Matthew Delaney <mdelaney@apple.com>
commit-queue [Fri, 24 Sep 2010 00:29:35 +0000 (00:29 +0000)]
2010-09-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Oliver Hunt.

        Lower the default canvas interpolation quality for platforms that use CG
        https://bugs.webkit.org/show_bug.cgi?id=45722

        Lowered the default image interpolation quality for platforms that
        use CG down to low since this is as good as if not better than
        other graphics platforms defaults (being bilinear interpolation).

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer):
        * html/HTMLCanvasElement.h: Moved in macros for default canvas interp quality.
        * platform/graphics/GraphicsContext.h: Moved out macros for default canvas interp quality. It makes more sense for them to be housed where they're used.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Caio Marcelo de Oliveira Filho [Mon, 28 Mar 2011 13:28:22 +0000 (10:28 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

* qtwebkit-2.1:
  2011-02-17 Csaba Osztrogonác <ossy@webkit.org>

11 years ago2011-02-17 Csaba Osztrogonác <ossy@webkit.org> qtwebkit-2.1-week12
Csaba Osztrogonác [Thu, 17 Feb 2011 17:41:32 +0000 (17:41 +0000)]
2011-02-17 Csaba Osztrogonác <ossy@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] ImageDiff sometimes hangs
        https://bugs.webkit.org/show_bug.cgi?id=54641

        * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison.
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Caio Marcelo de Oliveira Filho [Thu, 24 Mar 2011 12:41:28 +0000 (09:41 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

* qtwebkit-2.1:
  2011-03-23  Csaba Osztrogonác  <ossy@webkit.org>

11 years ago2011-03-23 Csaba Osztrogonác <ossy@webkit.org>
Caio Marcelo de Oliveira Filho [Thu, 24 Mar 2011 12:39:55 +0000 (09:39 -0300)]
2011-03-23  Csaba Osztrogonác  <ossy@webkit.org>

        Rubber-stamped by Andreas Kling

        [Qt] Fix bugs when building WebKit with Qt 4.7.1
        https://bugs.webkit.org/show_bug.cgi?id=46248

        Migrate to Qt 4.7.2 (step 2): Add failing tests to the Skipped list,
        remove passing tests from Skipped list, update expected files.

        * platform/qt/Skipped:
        * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
        * platform/qt/fast/text/international/hindi-whitespace-expected.txt:
        * platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Caio Marcelo de Oliveira Filho [Wed, 23 Mar 2011 15:46:12 +0000 (12:46 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

* qtwebkit-2.1:
  2011-03-23  Csaba Osztrogonác  <ossy@webkit.org>

11 years ago2011-03-23 Csaba Osztrogonác <ossy@webkit.org>
Caio Marcelo de Oliveira Filho [Wed, 23 Mar 2011 15:35:50 +0000 (12:35 -0300)]
2011-03-23  Csaba Osztrogonác  <ossy@webkit.org>

        Rubber-stamped by Andreas Kling

        [Qt] Fix bugs when building WebKit with Qt 4.7.1
        https://bugs.webkit.org/show_bug.cgi?id=46248

        Migrate to Qt 4.7.1 (step 1): update expected files.

        * platform/qt/css1/basic/class_as_selector-expected.txt:
        * platform/qt/css1/basic/comments-expected.txt:
        * platform/qt/css1/basic/containment-expected.txt:
        * platform/qt/css1/basic/contextual_selectors-expected.txt:
        * platform/qt/css1/basic/grouping-expected.txt:
        * platform/qt/css1/basic/id_as_selector-expected.txt:
        * platform/qt/css1/basic/inheritance-expected.txt:
        * platform/qt/css1/box_properties/border-expected.txt:
        * platform/qt/css1/box_properties/border_bottom-expected.txt:
        * platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
        * platform/qt/css1/box_properties/border_bottom_width-expected.txt:
        * platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
        * platform/qt/css1/box_properties/border_color-expected.txt:
        * platform/qt/css1/box_properties/border_color_inline-expected.txt:
        * platform/qt/css1/box_properties/border_inline-expected.txt:
        * platform/qt/css1/box_properties/border_left-expected.txt:
        * platform/qt/css1/box_properties/border_left_inline-expected.txt:
        * platform/qt/css1/box_properties/border_left_width-expected.txt:
        * platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
        * platform/qt/css1/box_properties/border_right-expected.txt:
        * platform/qt/css1/box_properties/border_right_inline-expected.txt:
        * platform/qt/css1/box_properties/border_right_width-expected.txt:
        * platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
        * platform/qt/css1/box_properties/border_style-expected.txt:
        * platform/qt/css1/box_properties/border_style_inline-expected.txt:
        * platform/qt/css1/box_properties/border_top-expected.txt:
        * platform/qt/css1/box_properties/border_top_inline-expected.txt:
        * platform/qt/css1/box_properties/border_top_width-expected.txt:
        * platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
        * platform/qt/css1/box_properties/border_width-expected.txt:
        * platform/qt/css1/box_properties/border_width_inline-expected.txt:
        * platform/qt/css1/box_properties/clear-expected.txt:
        * platform/qt/css1/box_properties/clear_float-expected.txt:
        * platform/qt/css1/box_properties/float-expected.txt:
        * platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
        * platform/qt/css1/box_properties/float_margin-expected.txt:
        * platform/qt/css1/box_properties/height-expected.txt:
        * platform/qt/css1/box_properties/margin-expected.txt:
        * platform/qt/css1/box_properties/margin_bottom-expected.txt:
        * platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
        * platform/qt/css1/box_properties/margin_inline-expected.txt:
        * platform/qt/css1/box_properties/margin_left-expected.txt:
        * platform/qt/css1/box_properties/margin_left_inline-expected.txt:
        * platform/qt/css1/box_properties/margin_right-expected.txt:
        * platform/qt/css1/box_properties/margin_right_inline-expected.txt:
        * platform/qt/css1/box_properties/margin_top-expected.txt:
        * platform/qt/css1/box_properties/margin_top_inline-expected.txt:
        * platform/qt/css1/box_properties/padding-expected.txt:
        * platform/qt/css1/box_properties/padding_bottom-expected.txt:
        * platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
        * platform/qt/css1/box_properties/padding_inline-expected.txt:
        * platform/qt/css1/box_properties/padding_left-expected.txt:
        * platform/qt/css1/box_properties/padding_left_inline-expected.txt:
        * platform/qt/css1/box_properties/padding_right-expected.txt:
        * platform/qt/css1/box_properties/padding_right_inline-expected.txt:
        * platform/qt/css1/box_properties/padding_top-expected.txt:
        * platform/qt/css1/box_properties/padding_top_inline-expected.txt:
        * platform/qt/css1/box_properties/width-expected.txt:
        * platform/qt/css1/cascade/cascade_order-expected.txt:
        * platform/qt/css1/cascade/important-expected.txt:
        * platform/qt/css1/classification/display-expected.txt:
        * platform/qt/css1/classification/list_style-expected.txt:
        * platform/qt/css1/classification/list_style_image-expected.txt:
        * platform/qt/css1/classification/list_style_position-expected.txt:
        * platform/qt/css1/classification/list_style_type-expected.txt:
        * platform/qt/css1/color_and_background/background-expected.txt:
        * platform/qt/css1/color_and_background/background_attachment-expected.txt:
        * platform/qt/css1/color_and_background/background_color-expected.txt:
        * platform/qt/css1/color_and_background/background_image-expected.txt:
        * platform/qt/css1/color_and_background/background_position-expected.txt:
        * platform/qt/css1/color_and_background/background_repeat-expected.txt:
        * platform/qt/css1/color_and_background/color-expected.txt:
        * platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
        * platform/qt/css1/font_properties/font-expected.txt:
        * platform/qt/css1/font_properties/font_family-expected.txt:
        * platform/qt/css1/font_properties/font_size-expected.txt:
        * platform/qt/css1/font_properties/font_style-expected.txt:
        * platform/qt/css1/font_properties/font_variant-expected.txt:
        * platform/qt/css1/font_properties/font_weight-expected.txt:
        * platform/qt/css1/formatting_model/canvas-expected.txt:
        * platform/qt/css1/formatting_model/floating_elements-expected.txt:
        * platform/qt/css1/formatting_model/height_of_lines-expected.txt:
        * platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
        * platform/qt/css1/formatting_model/inline_elements-expected.txt:
        * platform/qt/css1/formatting_model/replaced_elements-expected.txt:
        * platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
        * platform/qt/css1/pseudo/anchor-expected.txt:
        * platform/qt/css1/pseudo/firstletter-expected.txt:
        * platform/qt/css1/pseudo/firstline-expected.txt:
        * platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
        * platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
        * platform/qt/css1/text_properties/letter_spacing-expected.txt:
        * platform/qt/css1/text_properties/line_height-expected.txt:
        * platform/qt/css1/text_properties/text_align-expected.txt:
        * platform/qt/css1/text_properties/text_decoration-expected.txt:
        * platform/qt/css1/text_properties/text_indent-expected.txt:
        * platform/qt/css1/text_properties/text_transform-expected.txt:
        * platform/qt/css1/text_properties/vertical_align-expected.txt:
        * platform/qt/css1/text_properties/word_spacing-expected.txt:
        * platform/qt/css1/units/color_units-expected.txt:
        * platform/qt/css1/units/length_units-expected.txt:
        * platform/qt/css1/units/percentage_units-expected.txt:
        * platform/qt/css1/units/urls-expected.txt:
        * platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
        * platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
        * platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
        * platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
        * platform/qt/editing/pasteboard/5027857-expected.txt:
        * platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
        * platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-019-expected.txt:
        * platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/qt/fast/forms/isindex-placeholder-expected.txt:
        * platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
        * platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
        * platform/qt/svg/custom/bug45331-expected.txt: Added.

11 years agoRemove spurious file from cherry-pick in commit c31f2f45391daa3c786ab30465ef30f7c9fe0f0f. qtwebkit-2.1.x-week11
Caio Marcelo de Oliveira Filho [Mon, 21 Mar 2011 18:59:03 +0000 (15:59 -0300)]
Remove spurious file from cherry-pick in commit c31f2f45391daa3c786ab30465ef30f7c9fe0f0f.

This file is not part of the build system in QtWebKit 2.1.x so it didn't caused any harm.

The cherry-pick mentioned apply the correct change to the correct file, so no more change is needed.

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x qtwebkit-2.1.x-week10
Luiz Agostini [Tue, 15 Mar 2011 20:44:18 +0000 (17:44 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years ago2011-03-09 Janne Koskinen <janne.p.koskinen@digia.com> qtwebkit-2.1-week10 qtwebkit-2.1-week11
Luiz Agostini [Tue, 15 Mar 2011 18:52:32 +0000 (15:52 -0300)]
2011-03-09  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

11 years ago2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
commit-queue [Thu, 10 Mar 2011 23:10:58 +0000 (23:10 +0000)]
2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
        https://bugs.webkit.org/show_bug.cgi?id=55945

        Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
        set interval used to trigger when decoded data in dead list of object cache will
        be purged from object cache.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed trivial fix for unsucesful merge of 2.1 into 2.1.x qtwebkit-2.1.x-week09
Ademar de Souza Reis Jr [Fri, 4 Mar 2011 19:36:38 +0000 (16:36 -0300)]
Unreviewed trivial fix for unsucesful merge of 2.1 into 2.1.x

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Ademar de Souza Reis Jr [Fri, 4 Mar 2011 18:56:07 +0000 (15:56 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

Conflicts:
WebCore/WebCore.pri

11 years ago2011-03-04 Qi Zhang <qi.2.zhang@nokia.com> qtwebkit-2.1-week09
Ademar de Souza Reis Jr [Fri, 4 Mar 2011 18:45:27 +0000 (15:45 -0300)]
2011-03-04  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
        https://bugs.webkit.org/show_bug.cgi?id=48636

        ***
            This is a backport provided by Qi Zhang and Reviewed by Laszlo
            of the "patch2" patch attached to the bug https://bugs.webkit.org/attachment.cgi?id=84733

            At this time It has not been added to trunk yet.
        ***

        Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

        * WebCore.pri:

2011-03-04  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
        https://bugs.webkit.org/show_bug.cgi?id=48636

        ***
            This is a backport provided by Qi Zhang and Reviewed by Laszlo
            of the "patch2" patch attached to the bug https://bugs.webkit.org/attachment.cgi?id=84733

            At this time It has not been added to trunk yet.
        ***

        Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

11 years ago2011-03-02 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Ademar de Souza Reis Jr [Fri, 4 Mar 2011 14:38:59 +0000 (11:38 -0300)]
2011-03-02  Misha Tyutyunik  <michael.tyutyunik@nokia.com>

        Rubber-stamped by Laszlo Gombos

        [Qt] No way to paint unclipped frame contents with current Qt API.
        https://bugs.webkit.org/show_bug.cgi?id=50311

        This is temporary patch for qtwebkit 2.1.x until a proper fix is not pulled
        from webkit trunk. We are using dynamic property _q_ClipRenderToViewport to
        turn off clipping in QWebFramePrivate::renderRelativeCoords().
        No changes in the public API. Unless the property is changes the default
        behavior left untouched.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderRelativeCoords):
        (QWebFrame::event):
        * Api/qwebframe_p.h:
        (QWebFramePrivate::QWebFramePrivate):

11 years agoUnreviewed buildfix after r79672.
Ademar de Souza Reis Jr [Thu, 3 Mar 2011 18:52:43 +0000 (15:52 -0300)]
Unreviewed buildfix after r79672.

[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.

* tests/tests.pri:
* tests/tests.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog

11 years ago2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
Ademar de Souza Reis Jr [Thu, 3 Mar 2011 18:49:39 +0000 (15:49 -0300)]
2011-02-25  Gopal Raghavan  <gopal.1.raghavan@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QML WebView inside a Flickable shows checkers pattern at startup
        https://bugs.webkit.org/show_bug.cgi?id=50222.

        This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::init):
        * tests/qdeclarativewebview: Added.
        * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
        * tests/qdeclarativewebview/resources: Added.
        * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
        * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
        (tst_QDeclarativeWebView::initTestCase):
        (tst_QDeclarativeWebView::cleanupTestCase):
        (tst_QDeclarativeWebView::init):
        (tst_QDeclarativeWebView::cleanup):
        (tst_QDeclarativeWebView::preferredWidthTest):
        (tst_QDeclarativeWebView::preferredHeightTest):
        (tst_QDeclarativeWebView::preferredWidthDefaultTest):
        (tst_QDeclarativeWebView::preferredHeightDefaultTest):
        (tst_QDeclarativeWebView::checkNoErrors):
        * tests/tests.pri:
        * tests/tests.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x qtwebkit-2.1.x-week08
Ademar de Souza Reis Jr [Mon, 28 Feb 2011 22:22:41 +0000 (19:22 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years ago2011-02-26 Andreas Kling <kling@webkit.org>
Ademar de Souza Reis Jr [Mon, 28 Feb 2011 22:00:16 +0000 (19:00 -0300)]
2011-02-26  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable usage of synchronous HTTP feature in Qt
        https://bugs.webkit.org/show_bug.cgi?id=37191

        Currently, we spin an event loop when doing synchronous calls to
        wait for completion. This patch uses synchronous requests in Qt,
        if available, and spins the event loop as a fallback solution.

        Based on work by Simon Hausmann and Peter Hartmann.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::WebCoreSynchronousLoader::setReplyFinished):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp
Source/WebCore/platform/network/qt/QNetworkReplyHandler.h
Source/WebCore/platform/network/qt/ResourceHandleQt.cpp

11 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Mon, 28 Feb 2011 21:32:59 +0000 (18:32 -0300)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
        https://bugs.webkit.org/show_bug.cgi?id=55252

        Need to invoke a callback function to notify the HTMLMediaElement
        when MediaPlayerPrivateQt's playback state gets changed.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
        (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
        (WebCore::MediaPlayerPrivateQt::stateChanged):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp
Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h

11 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Mon, 28 Feb 2011 21:28:38 +0000 (18:28 -0300)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Carlson.

        Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
        https://bugs.webkit.org/show_bug.cgi?id=55147

        When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
        a volumechangeEvent event should be fired if the volume gets changed.

        Test: media/event-attributes.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
        (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLMediaElement.cpp

11 years ago2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
Ademar de Souza Reis Jr [Mon, 28 Feb 2011 21:23:59 +0000 (18:23 -0300)]
2011-02-22  Fabrizio Machado  <fabrizio.machado@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
        https://bugs.webkit.org/show_bug.cgi?id=54976

        Test not needed.

        * WebCoreSupport/InspectorClientQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp

11 years ago2011-02-24 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Ademar de Souza Reis Jr [Fri, 25 Feb 2011 20:08:39 +0000 (17:08 -0300)]
2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] add android 2.2 user agent to QtTestBrowser
        https://bugs.webkit.org/show_bug.cgi?id=55085

        Credit to Forrest Hodgkins to find right user-agent which works for youtube.
        * QtTestBrowser/useragentlist.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Tools
Tools/ChangeLog

11 years ago2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>
Ademar de Souza Reis Jr [Fri, 25 Feb 2011 19:52:47 +0000 (16:52 -0300)]
2011-02-24  Misha Tyutyunik  <michael.tyutyunik@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
        (2048Kb for now).
        https://bugs.webkit.org/show_bug.cgi?id=54887

        No new tests required.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache):
        (WebCore::GraphicsLayerQtImpl::drawLayerContent):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp

11 years agoNavigating downwards / upwards does not focus on the links spread across more than... qtwebkit-2.1-week08
Ademar de Souza Reis Jr [Fri, 25 Feb 2011 19:16:03 +0000 (16:16 -0300)]
Navigating downwards / upwards does not focus on the links spread across more than one line.
https://bugs.webkit.org/show_bug.cgi?id=54639

Reviewed by Antonio Gomes.

Source/WebCore:

When 2 anchor elements span more than one line each, and one ends on the same line that the
second starts on, the rects reported by their renderers are overlapping. When handling
2 overlapping nodes, check for this case, and don't assume that one of the nodes is on a higher layer.

Test: fast/spatial-navigation/snav-two-elements-one-line.html

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
* page/SpatialNavigation.cpp:
(WebCore::areElementsOnSameLine):
(WebCore::distanceDataForNode):
* page/SpatialNavigation.h:

LayoutTests:

* fast/spatial-navigation/snav-two-elements-one-line-expected.txt: Added.
* fast/spatial-navigation/snav-two-elements-one-line.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/page/FocusController.cpp
Source/WebCore/page/SpatialNavigation.cpp
Source/WebCore/page/SpatialNavigation.h

11 years ago2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:59:54 +0000 (17:59 -0300)]
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        * fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-crash.html: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
        * fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        Frame flattening algorithm requires that layout always starts from the main frame, since layout of
        subframes impacts the layout of their parents.
        There are places in the code that call view->layout() not on the main frame.
        Instead of changing all the callsites, I changed FrameView::layout()
        to force layout from the main frame if frame flattening is enabled.
        In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
        Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
        because calling the from layout() leads to a crash in pages that have a selection in an iframe.

        Tests: fast/frames/flattening/iframe-flattening-crash.html
               fast/frames/flattening/iframe-flattening-selection-crash.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::performPostLayoutTasks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/page/FrameView.cpp

11 years ago2011-01-15 Robert Hogan <robert@webkit.org>
Ademar de Souza Reis Jr [Fri, 25 Feb 2011 18:56:20 +0000 (15:56 -0300)]
2011-01-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] plugins/no-mime-with-valid-extension.html fails

        Check extension of resource against installed
        plugins when determining mime-type.

        https://bugs.webkit.org/show_bug.cgi?id=52288
        https://bugs.webkit.org/show_bug.cgi?id=50657
        * platform/qt/Skipped:
2011-01-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] plugins/no-mime-with-valid-extension.html fails
        Check extension of resource against installed
        plugins when determining mime-type.

        https://bugs.webkit.org/show_bug.cgi?id=52288
        https://bugs.webkit.org/show_bug.cgi?id=50657

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::objectContentType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped

11 years ago2011-02-22 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Ademar de Souza Reis Jr [Tue, 22 Feb 2011 17:37:01 +0000 (14:37 -0300)]
2011-02-22  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Crash in QGraphicsVideoItem when closing a scene in fullscreen mode.
        https://bugs.webkit.org/show_bug.cgi?id=53774

        [this is a patch for 2.1.x only, as this issue doesn't affect trunk]

        Disable ACCELERATED_COMPOSITING only for video use case on maemo/symbian platforms when PlatformPlugin supports FullScreen playing.
        There are couple of issues with AC enabled with combination of PlatformPlugin fullscreen player,
        which are already fixed in trunk code with TEXTURE_MAPPING changes and this hack is needed only for the branch.

        No new tests added as only disabling feature for maemo/symbian platforms

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x qtwebkit-2.1.x-week07
Ademar de Souza Reis Jr [Mon, 21 Feb 2011 21:07:30 +0000 (18:07 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years agoUpdate API to support displaying last character in function makeSecure(). qtwebkit-2.1-week07
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 22:04:03 +0000 (19:04 -0300)]
Update API to support displaying last character in function makeSecure().

Patch 3, by Chang Shu, from:
https://bugs.webkit.org/show_bug.cgi?id=32509

Patch not accepted in trunk yet.

11 years ago<http://webkit.org/b/49848> Make it possible to display the last character of a secur...
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 22:10:38 +0000 (19:10 -0300)]
<webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured

Reviewed by Darin Adler.

* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not.  Implemented behavior.
* wtf/text/StringImpl.h:
(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

JavaScriptCore/JavaScriptCore.exp
JavaScriptCore/wtf/text/StringImpl.cpp

11 years ago2010-12-21 Ryosuke Niwa <rniwa@webkit.org>
Ryosuke Niwa [Wed, 22 Dec 2010 01:59:09 +0000 (01:59 +0000)]
2010-12-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        CharacterData needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51426

        Extracted CharacterData::setDataAndNotify and CharacterData::updateRenderer.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Calls setDataAndUpdate.
        (WebCore::CharacterData::parserAppendData): Ditto.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setDataAndUpdate): Added.
        (WebCore::CharacterData::updateRenderer): Added.
        (WebCore::CharacterData::dispatchModifiedEvent): Renamed prevValue to oldData.
        * dom/CharacterData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=41948
Geoffrey Garen [Wed, 27 Oct 2010 17:59:57 +0000 (17:59 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

Reviewed by Oliver Hunt.

SunSpider reports no change.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException): Walk the stack to calculate the high
water mark currently in use. It's not safe to assume that the current
CallFrame's high water mark is the highest high water mark because
calls do not always set up at the end of a CallFrame. A large caller
CallFrame can encompass a small callee CallFrame.

* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall): Make sure to set a 0 CodeBlock
in the CallFrame of a host call, like the Interpreter does, instead of
leaving the CodeBlock field uninitialized. The backtracing code requires
a valid CodeBlock field in each CallFrame.

LayoutTests: Added a test for:

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception

* fast/js/exception-registerfile-shrink-expected.txt: Added.
* fast/js/exception-registerfile-shrink.html: Added.
* fast/js/script-tests/exception-registerfile-shrink.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Ademar de Souza Reis Jr [Mon, 21 Feb 2011 13:58:33 +0000 (10:58 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years ago2011-02-18 Yi Shen <yi.4.shen@nokia.com>
Yi Shen [Sat, 19 Feb 2011 03:58:37 +0000 (03:58 +0000)]
2011-02-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Always display the media controls when requiresFullscreenForVideoPlayback() is true
        https://bugs.webkit.org/show_bug.cgi?id=54308

        For video element, it should have controls when
        Chrome::requiresFullscreenForVideoPlayback() is true.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::controls):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/ChangeLog
WebCore/html/HTMLMediaElement.cpp

11 years ago2011-02-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 21 Feb 2011 13:48:25 +0000 (10:48 -0300)]
2011-02-18  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] The localized vendor name for Qt SIS packages should be "Nokia"
        https://bugs.webkit.org/show_bug.cgi?id=54742

        This change was applied in the Qt repository (qt/src/3rdparty/webkit),
        so we should do the same here in QtWebKit.

        Patch by Eckhart Koppen <eckhart.koppen@nokia.com>
        a8a84f1667966acfa093c4be0b7d4b0900ddd3d9:

        The previously used name "Nokia, Qt" was not usable for Nokia
        Content Signing, which only allows "Nokia" as the visible vendor
        name. The unique vendor ID remains as "Nokia, Qt"

        * WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/WebCore.pro

11 years ago3rd try: Fix regression introduced by a workaround for a Symbian bug on media play
Ademar de Souza Reis Jr [Fri, 18 Feb 2011 15:46:16 +0000 (12:46 -0300)]
3rd try: Fix regression introduced by a workaround for a Symbian bug on media play

Someone please shoot me if it's wrong this time. :-)

Thanks to Nancy Piedra <nancy.piedra@nokia.com> for the fix.

429bbaa92d60a22a2264e0a1d909dd3f070249a7 is a workaround for a problem
that happens on symbian due to a qtmultimedia bug.

11 years ago2011-02-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Ademar de Souza Reis Jr [Thu, 17 Feb 2011 20:42:26 +0000 (17:42 -0300)]
2011-02-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] wmode gets overridden even if already windowless in QGraphicsWebView
        Do not override wmode if it is not set to "window".
        https://bugs.webkit.org/show_bug.cgi?id=50495

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

11 years ago2011-02-17 Hui Huang <hui.2.huang@nokia.com>
Ademar de Souza Reis Jr [Thu, 17 Feb 2011 20:38:00 +0000 (17:38 -0300)]
2011-02-17  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Laszlo Gombos.

        The URL of HTML5 Video Element is percent encoded at websites such as youtube.
        It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
        the HTTP GET request for the video to be rejected by the service provider.
        https://bugs.webkit.org/show_bug.cgi?id=53973.

        The bug is fixed by constructing QUrl from the encoded URL.

        New test function tst_QWebPage::loadHtml5Video() is added in
        Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-17  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Laszlo Gombos.

        The URL of HTML5 Video Element is percent encoded at websites such as youtube.
        It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
        the HTTP GET request for the video to be rejected by the service provider.
        https://bugs.webkit.org/show_bug.cgi?id=53973.

        The bug is fixed by constructing QUrl from the encoded URL in
        MediaPlayerPrivateQt::commitLoad.

        New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
        HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
        is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
        A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
        is skipped if Qt Multimedia is not available.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::loadHtml5Video):
        * tests/tests.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

11 years agoRevert fix for bug 52449 (Crash when logging into gmail.com ...)
Ademar de Souza Reis Jr [Thu, 17 Feb 2011 20:04:00 +0000 (17:04 -0300)]
Revert fix for bug 52449 (Crash when logging into gmail.com ...)

This reverts commit ea0fd5669d4eb734657db04af651a4510f2d31eb.

Causes a regression on flash content rendering on Symbian
(see discussion at the end of
https://bugs.webkit.org/show_bug.cgi?id=52449)

11 years ago2nd try: Fix regression introduced by a workaround for a Symbian bug on media play
Ademar de Souza Reis Jr [Wed, 16 Feb 2011 21:29:57 +0000 (18:29 -0300)]
2nd try: Fix regression introduced by a workaround for a Symbian bug on media play

Fix is for real this time. :-)

Thanks to Norbert Leser <norbert.leser@nokia.com> for reporting this.

429bbaa92d60a22a2264e0a1d909dd3f070249a7 is a workaround for a problem
that happens on symbian due to a qtmultimedia bug. The fix was not
guarded with proper #ifdefs and caused a regression, at least on
Maemo6/Meego.

11 years agoFix regression introduced by a workaround for a Symbian bug on media play
Ademar de Souza Reis Jr [Wed, 16 Feb 2011 16:06:29 +0000 (13:06 -0300)]
Fix regression introduced by a workaround for a Symbian bug on media play

429bbaa92d60a22a2264e0a1d909dd3f070249a7 is a workaround for a problem
that happens on symbian due to a qtmultimedia bug. The fix was not
guarded with proper #ifdefs and caused a regression, at least on
Maemo6/Meego.

Reported by Norbert Leser <norbert.leser@nokia.com> via e-mail.

11 years ago2011-02-08 Yael Aharon <yael.aharon@nokia.com> qtwebkit-2.1.x-week06
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:59:54 +0000 (17:59 -0300)]
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        * fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-crash.html: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
        * fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antti Koivisto.

        Crash when logging into gmail.com with frame flattening turned on.
        https://bugs.webkit.org/show_bug.cgi?id=52449

        Frame flattening algorithm requires that layout always starts from the main frame, since layout of
        subframes impacts the layout of their parents.
        There are places in the code that call view->layout() not on the main frame.
        Instead of changing all the callsites, I changed FrameView::layout()
        to force layout from the main frame if frame flattening is enabled.
        In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
        Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
        because calling the from layout() leads to a crash in pages that have a selection in an iframe.

        Tests: fast/frames/flattening/iframe-flattening-crash.html
               fast/frames/flattening/iframe-flattening-selection-crash.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::performPostLayoutTasks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/page/FrameView.cpp

11 years agoVariable name change. m_shouldFirePostLayoutTimer is now
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:37:44 +0000 (17:37 -0300)]
Variable name change. m_shouldFirePostLayoutTimer is now
m_hasPendingPostLayoutTasks

Rubber-stamped by Dan Bernstein..

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
* page/FrameView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/page/FrameView.h

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=44828 FrameView
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:34:34 +0000 (17:34 -0300)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=44828 FrameView
should make more calls to postLayoutTasks() using the timer
-and corresponding-
<rdar://problem/8064938>

Reviewed by Dave Hyatt.

WebCore:

This change only allows synchronous calls to postLayoutTasks() if
we are not already in a synchronous call to postLayoutTasks().
Furthermore, it de-couples the notion of "the post layout timer
should fire" from m_postLayoutTasksTimer.isActive(), instead using
a boolean to track the need to use the timer.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::unscheduleRelayout):
(WebCore::FrameView::performPostLayoutTasks):
* page/FrameView.h:

LayoutTests:

* fast/events/change-overflow-on-overflow-change-expected.txt: Added.
* fast/events/change-overflow-on-overflow-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/page/FrameView.cpp
WebCore/page/FrameView.h

11 years agoWorkaround for QtMultimedia bug (QTMOBILITY-1090)
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:22:42 +0000 (17:22 -0300)]
Workaround for QtMultimedia bug (QTMOBILITY-1090)

Patch from Yi Shen <yi.4.shen@nokia.com> to workaround a QtMobility bug
that affects webkit but is a WONTFIX on trunk:

    [Qt][Symbian] HTML5 audio/video can't play after click the play button
    https://bugs.webkit.org/show_bug.cgi?id=53682

    On symbian platform, it never gets BufferedMedia status if NOT calls
    QMediaPlayer::play(). So, we need to pre-roll to get the correct
    buffer-status.

    Covered by existing tests.

    * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
    (WebCore::MediaPlayerPrivateQt::commitLoad):

11 years agoMerge branch 'qtwebkit-2.1' into qtwebkit-2.1.x
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 20:13:36 +0000 (17:13 -0300)]
Merge branch 'qtwebkit-2.1' into qtwebkit-2.1.x

11 years ago2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com> qtwebkit-2.1-week06
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 19:53:32 +0000 (16:53 -0300)]
2011-02-11  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Andreas Kling.

        [Qt][S60] Vertical borders of buttons and frames are misaligned
        https://bugs.webkit.org/show_bug.cgi?id=51169

        Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
        OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
        without anti-aliasing. Patch idea by Laszlo Agocs.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

11 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 18:13:31 +0000 (15:13 -0300)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Misc documentation fixes/updates
        https://bugs.webkit.org/show_bug.cgi?id=54236

        There are a few commits in the Qt repository (master and 4.7 branches)
        with QtWebKit documentation fixes:

        84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
        Clarified documentation of loadFinished() signal

        eebe205b306daaa3674d9746de11a73bef4bd0de
        Doc: Fixed QML, unindented snippet

        b0d64717d2c541976dc5524e4100c62f060e206f
        doc: Changed a table into 3 tables to eliminate a \raw.

        As these are all minor doc changes, I decided to group them
        into one single patch.

        * Api/qwebpage.cpp:
        * declarative/qdeclarativewebview.cpp:
        * docs/qtwebkit.qdoc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/Api/qwebpage.cpp
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp
Source/WebKit/qt/docs/qtwebkit.qdoc

11 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 18:09:54 +0000 (15:09 -0300)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix assert in QDeclarativeWebView
        https://bugs.webkit.org/show_bug.cgi?id=54240

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-14278

        Instantiating a QDeclarativeWebView twice will trigger an assertion
        when in debug mode.

        Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
        reviewed (there) by Aaron Kennedy
        f532679ca11914b453e22342f2ae5e9f790ce47a

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp

11 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 17:56:44 +0000 (14:56 -0300)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Ensure WebView press delay timer is cancelled when grab is taken
        https://bugs.webkit.org/show_bug.cgi?id=54242

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-15529

        Flickable steals the grab, but the timer was not stopped and the
        keepGrab flag is set and the mouse grabbed. This means that the WebView
        now has the grab and subsequent clicks on another element are ignored.

        Original patch from Martin Jones <martin.jones@nokia.com>
        reviewed (there) by Joona Petrell
        52068f57f9c32098a90cc217730a530f85590f65

        * declarative/qdeclarativewebview.cpp:
        (GraphicsWebView::sceneEvent):
        * declarative/qdeclarativewebview_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp

11 years ago2011-01-24 Chang Shu <chang.shu@nokia.com> qtwebkit-2.1.x-week05
chang.shu [Mon, 24 Jan 2011 17:40:37 +0000 (17:40 +0000)]
2011-01-24  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        Move contentEditable related test cases to the right place as they are DOM
        related instead of editing related.
        https://bugs.webkit.org/show_bug.cgi?id=53010

        * editing/editability: Removed.
        * editing/editability/attr-empty-string-expected.txt: Removed.
        * editing/editability/attr-empty-string.html: Removed.
        * editing/editability/attr-false-string-expected.txt: Removed.
        * editing/editability/attr-false-string.html: Removed.
        * editing/editability/attr-invalid-string-expected.txt: Removed.
        * editing/editability/attr-invalid-string.html: Removed.
        * editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
        * editing/editability/attr-missing-ancestor-false.html: Removed.
        * editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
        * editing/editability/attr-missing-ancestor-true.html: Removed.
        * editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
        * editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
        * editing/editability/attr-missing-parent-false-expected.txt: Removed.
        * editing/editability/attr-missing-parent-false.html: Removed.
        * editing/editability/attr-missing-parent-true-expected.txt: Removed.
        * editing/editability/attr-missing-parent-true.html: Removed.
        * editing/editability/attr-true-string-expected.txt: Removed.
        * editing/editability/attr-true-string.html: Removed.
        * editing/editability/set-false-expected.txt: Removed.
        * editing/editability/set-false.html: Removed.
        * editing/editability/set-inherit-parent-false-expected.txt: Removed.
        * editing/editability/set-inherit-parent-false.html: Removed.
        * editing/editability/set-inherit-parent-true-expected.txt: Removed.
        * editing/editability/set-inherit-parent-true.html: Removed.
        * editing/editability/set-invalid-value-expected.txt: Removed.
        * editing/editability/set-invalid-value.html: Removed.
        * editing/editability/set-true-expected.txt: Removed.
        * editing/editability/set-true.html: Removed.
        * editing/editability/set-value-caseinsensitive-expected.txt: Removed.
        * editing/editability/set-value-caseinsensitive.html: Removed.
        * fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
        * fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
        * fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
        * fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
        * fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
        * fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
        * fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
        * fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
        * fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
        * fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
        * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
        * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
        * fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
        * fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
        * fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
        * fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
        * fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
        * fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
        * fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
        * fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
        * fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
        * fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
        * fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
        * fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
        * fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
        * fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
        * fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
        * fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
        * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
        * fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia... qtwebkit-2.1.x-week04
Ademar de Souza Reis Jr [Fri, 28 Jan 2011 19:49:31 +0000 (16:49 -0300)]
2011-01-27  Yi Shen  <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Add fullscreen media control button for html video
        https://bugs.webkit.org/show_bug.cgi?id=51543

        Implement media control fullscreen button for QtWebKit html5 video.

        * css/mediaControlsQt.css:
        (video::-webkit-media-controls-fullscreen-button):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/qt/RenderThemeQt.cpp

11 years ago2011-01-20 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Fri, 28 Jan 2011 19:45:18 +0000 (16:45 -0300)]
2011-01-20  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Carlson.

        Clean up the Media Controls CSS for Qt
        https://bugs.webkit.org/show_bug.cgi?id=52822

        Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
        in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
        rules from mediaControlsQtFullscreen.css.

        * css/mediaControlsQt.css:
        (audio::-webkit-media-controls-panel):
        (video::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-mute-button):
        (video::-webkit-media-controls-mute-button):
        (audio::-webkit-media-controls-play-button):
        (video::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-timeline-container):
        (video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display):
        (video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display):
        (video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline):
        (video::-webkit-media-controls-timeline):
        (audio::-webkit-media-controls-volume-slider-container):
        (video::-webkit-media-controls-volume-slider-container):
        (audio::-webkit-media-controls-volume-slider):
        (video::-webkit-media-controls-volume-slider):
        (audio::-webkit-media-controls-seek-back-button):
        (video::-webkit-media-controls-seek-back-button):
        (audio::-webkit-media-controls-seek-forward-button):
        (video::-webkit-media-controls-seek-forward-button):
        (audio::-webkit-media-controls-fullscreen-button):
        (video::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-rewind-button):
        (video::-webkit-media-controls-rewind-button):
        (audio::-webkit-media-controls-return-to-realtime-button):
        (video::-webkit-media-controls-return-to-realtime-button):
        (audio::-webkit-media-controls-toggle-closed-captions-button):
        (video::-webkit-media-controls-toggle-closed-captions-button):
        * css/mediaControlsQtFullscreen.css:
        (video::-webkit-media-controls-time-remaining-display):
        (video::-webkit-media-controls-seek-back-button):
        (video::-webkit-media-controls-seek-forward-button):
        (video::-webkit-media-controls-rewind-button):
        (video::-webkit-media-controls-return-to-realtime-button):
        (video::-webkit-media-controls-toggle-closed-captions-button):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog

11 years ago[Qt] Fix missing default controls for stand-alone media elements
Tor Arne Vestbø [Tue, 17 Aug 2010 11:38:43 +0000 (11:38 +0000)]
[Qt] Fix missing default controls for stand-alone media elements

Reviewed by Kenneth Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=35427

* css/mediaControlsQt.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-25 Chang Shu <chang.shu@nokia.com>
Ademar de Souza Reis Jr [Fri, 28 Jan 2011 19:14:49 +0000 (16:14 -0300)]
2010-10-25  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Should use eventSender for simulating keyboard events instead of using js
        event.initKeyboardEvent. Otherwise, inside WebCore, the keyboardevent
        object does not have a "PlatformKeyboardEvent" associated with it and this
        results different behavior as the real key press.
        This code change unveils that test snav-multiple-select.html is broken. It
        alos causes snav-single-select.html hangs on Mac. These will be fixed in
        seperate patches.
        https://bugs.webkit.org/show_bug.cgi?id=48134

        * fast/events/spatial-navigation/resources/spatial-navigation-utils.js:
        (doMove):
        * fast/events/spatial-navigation/snav-multiple-select-expected.txt:
        * platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/mac/Skipped

11 years agoFix layout tests related to setContentEditable
Ademar de Souza Reis Jr [Fri, 28 Jan 2011 19:03:40 +0000 (16:03 -0300)]
Fix layout tests related to setContentEditable

These tests are working on 2.1.x, but need more changes to work on trunk
(Bug 52058). This commit fixes the test expectations by removing the
FIXME and DEBUG notes.

Patch from Chang Shu <Chang.Shu@nokia.com>

For more details, see:
https://bugs.webkit.org/show_bug.cgi?id=52059#c9

11 years ago2011-01-20 Chang Shu <chang.shu@nokia.com>
Ademar de Souza Reis Jr [Wed, 26 Jan 2011 21:16:13 +0000 (18:16 -0300)]
2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Updated expected results after the fix. Also corrected test cases.

        * editing/editability/set-invalid-value-expected.txt:
        * editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
        * editing/editability/set-value-caseinsensitive-expected.txt:
        * editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
        * fast/dom/element-attribute-js-null-expected.txt:
        * fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.
2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Implemented exception throwing for setContentEditable according to the following spec:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
        Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
        string 'inherit' then the content attribute must be removed, if the new value is an ASCII
        case-insensitive match for the string 'true' then the content attribute must be set to the
        string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
        then the content attribute must be set to the string 'false', and otherwise the attribute
        setter must raise a SYNTAX_ERR exception."

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
        * html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
        * html/HTMLElement.idl: Add exception throwing support for contentEditable setter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLElement.cpp
Source/WebCore/html/HTMLElement.h
Source/WebCore/html/HTMLElement.idl

11 years ago2010-10-27 Crystal Zhang <haizhang@rim.com>
commit-queue [Wed, 27 Oct 2010 19:53:07 +0000 (19:53 +0000)]
2010-10-27  Crystal Zhang  <haizhang@rim.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=48446

        Fix an issue where we were passing the wrong parameter
        to MIMETypeRegistry::getMIMETypeForExtension().

        * platform/MIMETypeRegistry.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-13 Andreas Kling <andreas.kling@nokia.com>
Ademar de Souza Reis Jr [Wed, 26 Jan 2011 21:05:18 +0000 (18:05 -0300)]
2010-09-13  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Don't add empty strings to list of supported image MIME types
        https://bugs.webkit.org/show_bug.cgi?id=45643

        After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
        returns an empty string instead of "application/octet-stream" for unsupported
        extensions. Don't add these to the list of supported types, and clean out
        the logic that removed "application/octet-stream" from supported types.

        Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
        a HashSet<String>.

        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypes):
        (WebCore::initializeSupportedImageMIMETypesForEncoding):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/platform/MIMETypeRegistry.cpp

11 years ago2010-09-12 Robert Hogan <robert@webkit.org>
robert [Mon, 13 Sep 2010 00:19:43 +0000 (00:19 +0000)]
2010-09-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix http/tests/navigation/reload-subframe-object.html

        Unskip http/tests/navigation/reload-subframe-object.html

        https://bugs.webkit.org/show_bug.cgi?id=45613

        * platform/qt/Skipped:
2010-09-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix http/tests/navigation/reload-subframe-object.html

        We need to bring our use of getMimeTypeForPath() and
        getMimeTypeForExtension() into line with WebCore expectations.

        We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
        where an empty mimetype should be returned if no match is found, and
        MIMETypeRegistry::getMIMETypeForPath() for cases where
        'application/octet-stream' should be returned if no match is found.

        Fixes http/tests/navigation/reload-subframe-object.html

        Based on findings in webkit.org/b/31398 and webkit.org/b/15554.

        https://bugs.webkit.org/show_bug.cgi?id=45613

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/qt/MIMETypeRegistryQt.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSet QtWebKit version to 4.8.1
Ademar de Souza Reis Jr [Wed, 26 Jan 2011 16:50:40 +0000 (13:50 -0300)]
Set QtWebKit version to 4.8.1

4.8.0 is going to be 2.1.0, so 4.8.1 is the logical
increment.

11 years ago2010-12-17 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Mon, 24 Jan 2011 21:11:22 +0000 (18:11 -0300)]
2010-12-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage sends out a RequestSoftwareInputPanel event
        incorrectly in particular case
        https://bugs.webkit.org/show_bug.cgi?id=50419

        Add HitTestResult check before firing RequestSoftwareInputPanel event.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::mouseReleaseEvent):
        (QWebPagePrivate::handleSoftwareInputPanel):
        * Api/qwebpage_p.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (clickOnPage):
        (tst_QWebPage::inputMethods):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
    WebKit/qt/Api/qwebpage.cpp

11 years ago2011-01-19 Chang Shu <chang.shu@nokia.com>
Ademar de Souza Reis Jr [Mon, 24 Jan 2011 21:33:13 +0000 (18:33 -0300)]
2011-01-19  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=52056
        1. Fixed test cases in the above bug;
        2. Partially fixed test cases in other contentEditable bugs;
        3. Updated expected result for fast/dom/element-attribute-js-null.html.
           However, the test itself should be fixed later in bug 52057.

        * editing/editability/attr-invalid-string-expected.txt:
        * editing/editability/attr-invalid-string.html:
        * editing/editability/attr-missing-ancestor-false-expected.txt:
        * editing/editability/attr-missing-ancestor-false.html:
        * editing/editability/attr-missing-ancestor-true-expected.txt:
        * editing/editability/attr-missing-ancestor-true.html:
        * editing/editability/attr-missing-parent-ancestor-missing-expected.txt:
        * editing/editability/attr-missing-parent-ancestor-missing.html:
        * editing/editability/attr-missing-parent-false-expected.txt:
        * editing/editability/attr-missing-parent-false.html:
        * editing/editability/attr-missing-parent-true-expected.txt:
        * editing/editability/attr-missing-parent-true.html:
        * editing/editability/set-false-expected.txt:
        * editing/editability/set-inherit-parent-false-expected.txt:
        * editing/editability/set-inherit-parent-true-expected.txt:
        * editing/editability/set-invalid-value-expected.txt:
        * editing/editability/set-true-expected.txt:
        * editing/editability/set-value-caseinsensitive-expected.txt:
        * fast/dom/element-attribute-js-null-expected.txt:
2011-01-19  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        The return value of contentEditable() function should depend on the DOM attribute
        instead of render style userModify. The code change fixed test cases in the bug
        and partially fixed test cases in other contentEditable bugs;

        https://bugs.webkit.org/show_bug.cgi?id=52056

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::contentEditable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLElement.cpp

11 years ago2011-01-08 Chang Shu <chang.shu@nokia.com>
chang.shu [Sat, 8 Jan 2011 22:55:24 +0000 (22:55 +0000)]
2011-01-08  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Ryosuke Niwa.

        Added test contents for contentEditable DOM attribute.
        https://bugs.webkit.org/show_bug.cgi?id=51957

        * editing/editability: Added.
        * editing/editability/attr-empty-string-expected.txt: Added.
        * editing/editability/attr-empty-string.html: Added.
        * editing/editability/attr-false-string-expected.txt: Added.
        * editing/editability/attr-false-string.html: Added.
        * editing/editability/attr-invalid-string-expected.txt: Added.
        * editing/editability/attr-invalid-string.html: Added.
        * editing/editability/attr-missing-ancestor-false-expected.txt: Added.
        * editing/editability/attr-missing-ancestor-false.html: Added.
        * editing/editability/attr-missing-ancestor-true-expected.txt: Added.
        * editing/editability/attr-missing-ancestor-true.html: Added.
        * editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Added.
        * editing/editability/attr-missing-parent-ancestor-missing.html: Added.
        * editing/editability/attr-missing-parent-false-expected.txt: Added.
        * editing/editability/attr-missing-parent-false.html: Added.
        * editing/editability/attr-missing-parent-true-expected.txt: Added.
        * editing/editability/attr-missing-parent-true.html: Added.
        * editing/editability/attr-true-string-expected.txt: Added.
        * editing/editability/attr-true-string.html: Added.
        * editing/editability/set-false-expected.txt: Added.
        * editing/editability/set-false.html: Added.
        * editing/editability/set-inherit-parent-false-expected.txt: Added.
        * editing/editability/set-inherit-parent-false.html: Added.
        * editing/editability/set-inherit-parent-true-expected.txt: Added.
        * editing/editability/set-inherit-parent-true.html: Added.
        * editing/editability/set-invalid-value-expected.txt: Added.
        * editing/editability/set-invalid-value.html: Added.
        * editing/editability/set-true-expected.txt: Added.
        * editing/editability/set-true.html: Added.
        * editing/editability/set-value-caseinsensitive-expected.txt: Added.
        * editing/editability/set-value-caseinsensitive.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-10-11 Joseph Pecoraro <joepeck@webkit.org>
Joseph Pecoraro [Mon, 11 Oct 2010 19:03:08 +0000 (19:03 +0000)]
2010-10-11  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Eric Carlson.

        CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
        https://bugs.webkit.org/show_bug.cgi?id=46777

        Another case that could lead to an improper set of states between
        m_currentNode and m_loadingState. Also added an ASSERT and early
        return to prevent crashes if this case can still happen in other ways.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-01-22 Andreas Kling <kling@webkit.org>
Ademar de Souza Reis Jr [Mon, 24 Jan 2011 15:40:02 +0000 (12:40 -0300)]
2011-01-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] fast/backgrounds/svg-as-mask.html fails
        https://bugs.webkit.org/show_bug.cgi?id=52906

        Transparency layers should start out with in SourceOver mode with
        alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)

        * platform/graphics/qt/TransparencyLayer.h:
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/qt/TransparencyLayer.h

11 years ago2011-01-17 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Fri, 21 Jan 2011 21:27:55 +0000 (18:27 -0300)]
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Make MediaPlayerPrivateQt support a fullscreen player.

        No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
        However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
        So, still skip it for Qt.

        * WebCore.pro:
        * features.pri:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
        (WebCore::MediaPlayerPrivateQt::removeVideoItem):
        (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
        (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-17  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Add a new webkit platform plugin interface to support full screen video handler.

        * Api/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::fullScreenVideo):
        (WebCore::ChromeClientQt::supportsFullscreenForNode):
        (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp: Added.
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::aboutToClose):
        (WebCore::FullScreenVideoQt::mediaPlayer):
        (WebCore::FullScreenVideoQt::mediaPlayerForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        * WebCoreSupport/FullScreenVideoQt.h: Added.
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (FullScreenVideoWidget::FullScreenVideoWidget):
        (FullScreenVideoWidget::event):
        (FullScreenVideoWidget::keyPressEvent):
        (FullScreenVideoHandler::FullScreenVideoHandler):
        (FullScreenVideoHandler::~FullScreenVideoHandler):
        (FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
        (FullScreenVideoHandler::enterFullScreen):
        (FullScreenVideoHandler::exitFullScreen):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        (FullScreenVideoWidget::~FullScreenVideoWidget):
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/ChangeLog
Source/WebCore/WebCore.pro
Source/WebCore/features.pri
Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp
Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h
Source/WebKit/qt/Api/qwebkitplatformplugin.h
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
Source/WebKit/qt/WebCoreSupport/ChromeClientQt.h
Source/WebKit/qt/WebCoreSupport/QtPlatformPlugin.cpp
Source/WebKit/qt/WebCoreSupport/QtPlatformPlugin.h
Source/WebKit/qt/examples/platformplugin/qwebkitplatformplugin.h

11 years ago[Qt] Disconnect signals before destroying MediaPlayerPrivateQt
Tor Arne Vestbø [Thu, 7 Oct 2010 11:38:36 +0000 (11:38 +0000)]
[Qt] Disconnect signals before destroying MediaPlayerPrivateQt

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=47073

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Ensure we always report a valid size for the video
Tor Arne Vestbø [Thu, 30 Sep 2010 12:29:03 +0000 (12:29 +0000)]
[Qt] Ensure we always report a valid size for the video

Reviewed by Simon Hausmann.

Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):
* platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Ensure that the media player backend does not leave any resources around
Tor Arne Vestbø [Thu, 30 Sep 2010 12:00:26 +0000 (12:00 +0000)]
[Qt] Ensure that the media player backend does not leave any resources around

Reviewed by Simon Hausmann.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMinor cleanup of MediaPlayerPrivateQt
Tor Arne Vestbø [Thu, 30 Sep 2010 11:50:51 +0000 (11:50 +0000)]
Minor cleanup of MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-29 Joseph Pecoraro <joepeck@webkit.org>
Joseph Pecoraro [Wed, 29 Sep 2010 20:56:32 +0000 (20:56 +0000)]
2010-09-29  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Simon Fraser.

        CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
        https://bugs.webkit.org/show_bug.cgi?id=46777

        It should not be possible to get to be in the LoadingFromSourceElement
        state with a null current source node. This was a possible scenario
        where the current source node was cleared but the load state was not
        cleared as well. Tried and could not create a test case for this.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Rename member variable in MediaPlayerPrivateQt
Tor Arne Vestbø [Tue, 28 Sep 2010 17:03:47 +0000 (17:03 +0000)]
[Qt] Rename member variable in MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Rename MediaPlayerPrivate to MediaPlayerPrivateQt/Phonon
Ademar de Souza Reis Jr [Thu, 20 Jan 2011 18:27:00 +0000 (15:27 -0300)]
[Qt] Rename MediaPlayerPrivate to MediaPlayerPrivateQt/Phonon

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=36663

* platform/graphics/MediaPlayer.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.h:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
* platform/graphics/qt/MediaPlayerPrivatePhonon.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/platform/graphics/MediaPlayer.cpp

11 years ago2010-09-23 Eric Carlson <eric.carlson@apple.com>
Ademar de Souza Reis Jr [Thu, 20 Jan 2011 18:25:29 +0000 (15:25 -0300)]
2010-09-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser

        'seeking' event should always fire
        https://bugs.webkit.org/show_bug.cgi?id=45694

        Update seek algorithm to match current spec.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setReadyState): Don't need to fire 'seeking' event here.
        (WebCore::HTMLMediaElement::seek): Always fire 'seeking'. Update comments.
        (WebCore::HTMLMediaElement::finishSeek): Update comments.
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.

2010-09-23  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser

        'seeking' event should always fire
        https://bugs.webkit.org/show_bug.cgi?id=45694

        * media/event-attributes-expected.txt: Update for changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/html/HTMLMediaElement.cpp

11 years agoAdd mediaPlayerPlaybackStateChanged to MediaPlayerClient
Tor Arne Vestbø [Wed, 8 Sep 2010 09:18:27 +0000 (09:18 +0000)]
Add mediaPlayerPlaybackStateChanged to MediaPlayerClient

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=45263

The platform backend may change state, for example as a result
of an external plugin controlling the backend, so we need to
react to this situation by syncing up the WebCore state with the
platform backend.

We call playInternal()/pauseInternal() depending on the backend
state, to trigger the corresponding DOM events to match the state.

updatePlayState() is then refactored to take into account the
situation where the backend is already in the correct state but
WebCore is not, so that we update the playback progress timer
and set m_playing correctly.

updatePlayState() changes Should be covered by existing tests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
(WebCore::HTMLMediaElement::updatePlayState):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::playbackStateChanged):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPlaybackStateChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement MediaPlayerPrivate::platformMedia() for the Qt port
Tor Arne Vestbø [Wed, 8 Sep 2010 08:32:11 +0000 (08:32 +0000)]
Implement MediaPlayerPrivate::platformMedia() for the Qt port

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=45264

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-07 Eric Carlson <eric.carlson@apple.com>
Eric Carlson [Tue, 7 Sep 2010 18:29:29 +0000 (18:29 +0000)]
2010-09-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Media elements should derive from ActiveDOMObjects
        https://bugs.webkit.org/show_bug.cgi?id=45306
        <rdar://problem/7929062>

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize ActiveDOMObject
        (WebCore::HTMLMediaElement::stop): Call suspend, we want to do the same thing in both cases.
        (WebCore::HTMLMediaElement::suspend): Rename from documentWillBecomeInactive.
        (WebCore::HTMLMediaElement::resume): Rename from documentDidBecomeActive.
        (WebCore::HTMLMediaElement::hasPendingActivity): Return true if the event queue is not empty
        so the element can't be collected before they are sent.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::canSuspend):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-31 Eric Carlson <eric.carlson@apple.com>
Eric Carlson [Tue, 31 Aug 2010 21:51:45 +0000 (21:51 +0000)]
2010-08-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        canPlayType("application/octet-stream") must return ""
        https://bugs.webkit.org/show_bug.cgi?id=44985

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::supportsType): Always return IsNotSupported for application/octet-stream

2010-08-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        canPlayType("application/octet-stream") must return ""
        https://bugs.webkit.org/show_bug.cgi?id=44985

        * media/media-can-play-octet-stream-expected.txt:
        * media/media-can-play-octet-stream.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-28 Eric Carlson <eric.carlson@apple.com>
Ademar de Souza Reis Jr [Thu, 20 Jan 2011 18:23:39 +0000 (15:23 -0300)]
2010-08-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Crash reloading fast/events/tabindex-focus-blur-all.html test
        https://bugs.webkit.org/show_bug.cgi?id=44743

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::asyncEventTimerFired): If m_isWaitingToDecrementLoadEventDelayCount
        is true, call setShouldDelayLoadEvent(false) and set the timer to fire the pending events
        on the next idle.
        (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): Don't clear the delay from within a
        media engine callback because document 'load' event handlers that cause the page to become
        inactive will delete the media engine.
        * html/HTMLMediaElement.h: Add m_isWaitingToDecrementLoadEventDelayCount.

2010-08-28  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Crash reloading fast/events/tabindex-focus-blur-all.html test
        https://bugs.webkit.org/show_bug.cgi?id=44743

        * platform/mac/Skipped: Remove tabindex-focus-blur-all.html from the skip list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/mac/Skipped

11 years ago2010-08-26 Eric Carlson <eric.carlson@apple.com>
Ademar de Souza Reis Jr [Thu, 20 Jan 2011 18:23:08 +0000 (15:23 -0300)]
2010-08-26  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler and Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=44013
        HTMLMediaElement should delay document load event

        Test: media/video-delay-load-event.html

        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize incrementLoadEventDelayCount.
        (WebCore::Document::decrementLoadEventDelayCount): New, decrement incrementLoadEventDelayCount
        and call loader->checkCompleted() when it reaches zero.
        * dom/Document.h:
        (WebCore::Document::incrementLoadEventDelayCount): New.
        (WebCore::Document::isDelayingLoadEvent): New.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::~HTMLMediaElement): Stop delaying the load event if necessary.
        (WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Ditto.
        (WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Delay the load event if we don't the
        meta data for the movie yet.
        (WebCore::HTMLMediaElement::prepareForLoad): Delay the load event.
        (WebCore::HTMLMediaElement::selectMediaResource): Don't delay the load event when there are
        no more sources to consider. Don't change m_delayingTheLoadEvent directly, call
        setShouldDelayLoadEvent() instead.
        (WebCore::HTMLMediaElement::waitForSourceChange): Stop delaying the load event.
        (WebCore::HTMLMediaElement::noneSupported): Ditto.
        (WebCore::HTMLMediaElement::mediaEngineError): Ditto.
        (WebCore::HTMLMediaElement::setReadyState): Ditto.
        (WebCore::HTMLMediaElement::userCancelledLoad): Ditto.
        (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): New, increment/decrement the document's
        load event delay count.
        * html/HTMLMediaElement.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted): See if the document wants to delay completion for
        elements that don't go through a FrameLoader.
        (WebCore::FrameLoader::checkCallImplicitClose): Ditto
        * page/Frame.cpp:

2010-08-26  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler and Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=44013
        HTMLMediaElement should delay document load event

        * media/video-delay-load-event-expected.txt: Added.
        * media/video-delay-load-event.html: Added.
        * media/video-layer-crash.html: Trigger test with script inline in the <body> instead
        of from an onload handler as that runs too late. Reformat script to make it readable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/dom/Document.h

11 years ago2010-08-25 Eric Carlson <eric.carlson@apple.com>
Eric Carlson [Wed, 25 Aug 2010 17:51:26 +0000 (17:51 +0000)]
2010-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        HTMLMediaElement.canPlayType must be case insensitive for MIME type.
        https://bugs.webkit.org/show_bug.cgi?id=44577

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load):
        (WebCore::MediaPlayer::supportsType):

2010-08-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        HTMLMediaElement.canPlayType must be case insensitive for MIME type.
        https://bugs.webkit.org/show_bug.cgi?id=44577

        * media/media-can-play-octet-stream-expected.txt:
        * media/media-can-play-octet-stream.html:
        * media/media-can-play-ogg-expected.txt:
        * media/media-can-play-ogg.html:
        * media/video-can-play-type-expected.txt:
        * media/video-can-play-type.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-21 Eric Carlson <eric.carlson@apple.com>
Eric Carlson [Sat, 21 Aug 2010 18:40:01 +0000 (18:40 +0000)]
2010-08-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Media engine should not be asked to open all urls
        https://bugs.webkit.org/show_bug.cgi?id=44370

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): Do nothing with urls with a type attribute that would be
        rejected by canPlayType().

2010-08-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Media engine should not be asked to open all urls
        https://bugs.webkit.org/show_bug.cgi?id=44370

        * media/video-source-none-supported-expected.txt:
        * media/video-source-none-supported.html:
        * media/video-source-type.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65779 268f45cc-cd09-0410-ab3c-d52691b4dbfc