2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
authorNikolas Zimmermann <zimmermann@kde.org>
Sun, 9 Aug 2009 15:41:24 +0000 (15:41 +0000)
committerNikolas Zimmermann <zimmermann@kde.org>
Sun, 9 Aug 2009 15:41:24 +0000 (15:41 +0000)
commit0c1dfd43608ce1927b34b112b7f31cade319b189
tree9ddf8f2d8db1dc1700b89775c96882bc2ebee0f7
parent9cbb5667e6619e6a38593dc241a4f156f99ec36b
2009-08-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] manual-tests/wml/onevent-prev.wml crashes
        https://bugs.webkit.org/show_bug.cgi?id=27722

        Fix intrinsic event execution, leading to crashes.
        First finish parsing the document, then execute the events. Not the other way round.
        -> exposes bugs all over the WML layout tests, which relied on that quirk.

        Fixes manual-tests/wml/onevent-prev.wml.

        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::WMLDocument):
        (WebCore::WMLDocument::finishedParsing):
        (WebCore::WMLDocument::initialize):
        * wml/WMLDocument.h:

2009-08-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] manual-tests/wml/onevent-prev.wml crashes
        https://bugs.webkit.org/show_bug.cgi?id=27722

        Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.

        * http/tests/wml/resources/go-task-get-method-accept-charset.js:
        * http/tests/wml/resources/go-task-get-method.js:
        * http/tests/wml/resources/go-task-post-method-accept-charset.js:
        * http/tests/wml/resources/go-task-post-method.js:
        * http/tests/wml/resources/post-data-to-server.js:
        * wml/resources/WMLTestCase.js:
        (onloadHandler):
        (createStaticWMLTestCase):
        (createDynamicWMLTestCase):
        (createWMLTestCase.iframeElement.onload):
        (createWMLTestCase):
        * wml/resources/enter-card-with-events.js:
        (executeTest):
        * wml/resources/enter-first-card-with-events.js:
        (setupTestDocument):
        (prepareTest):
        (executeTest):
        * wml/resources/go-task-get-method-external-deck-with-href.js:
        * wml/resources/go-task-get-method-external-deck.js:
        * wml/resources/go-task-get-method-same-deck.js:
        * wml/resources/input-format.js:
        * wml/resources/newcontext-same-deck.js:
        (setupTestDocument):
        (executeTest):
        * wml/resources/onenterforward-event.js:
        (executeTest):
        * wml/resources/onenterforward-inline-event.js:
        * wml/resources/ontimer-event.js:
        (executeTest):
        * wml/resources/ontimer-inline-event.js:
        (executeTest):
        * wml/resources/option-element-onpick.js:
        * wml/resources/select-element-variables.js:
        * wml/resources/variable-reference-invalid-character.js:
        * wml/resources/variable-reference-valid.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
25 files changed:
LayoutTests/ChangeLog
LayoutTests/http/tests/wml/resources/go-task-get-method-accept-charset.js
LayoutTests/http/tests/wml/resources/go-task-get-method.js
LayoutTests/http/tests/wml/resources/go-task-post-method-accept-charset.js
LayoutTests/http/tests/wml/resources/go-task-post-method.js
LayoutTests/http/tests/wml/resources/post-data-to-server.js
LayoutTests/wml/resources/WMLTestCase.js
LayoutTests/wml/resources/enter-card-with-events.js
LayoutTests/wml/resources/enter-first-card-with-events.js
LayoutTests/wml/resources/go-task-get-method-external-deck-with-href.js
LayoutTests/wml/resources/go-task-get-method-external-deck.js
LayoutTests/wml/resources/go-task-get-method-same-deck.js
LayoutTests/wml/resources/input-format.js
LayoutTests/wml/resources/newcontext-same-deck.js
LayoutTests/wml/resources/onenterforward-event.js
LayoutTests/wml/resources/onenterforward-inline-event.js
LayoutTests/wml/resources/ontimer-event.js
LayoutTests/wml/resources/ontimer-inline-event.js
LayoutTests/wml/resources/option-element-onpick.js
LayoutTests/wml/resources/select-element-variables.js
LayoutTests/wml/resources/variable-reference-invalid-character.js
LayoutTests/wml/resources/variable-reference-valid.js
WebCore/ChangeLog
WebCore/wml/WMLDocument.cpp
WebCore/wml/WMLDocument.h