2010-08-03 Abhishek Arya <inferno@chromium.org>
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Aug 2010 13:25:38 +0000 (13:25 +0000)
committerSimon Hausmann <simon.hausmann@nokia.com>
Wed, 4 Aug 2010 18:09:44 +0000 (20:09 +0200)
commit9723f6393c030d9a03826afea2d3e670d50f7584
tree3ff4ce943746ee720d613ff4213d253fed340e3d
parent9c3db15122b4609fcb6a36ba4820ef04a44dae63
2010-08-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Null the script execution context when disconnecting frame in notifications.
        Make sure that script execution context is valid in notification requestPermission.
        https://bugs.webkit.org/show_bug.cgi?id=43295

        Tests: fast/notifications/notifications-document-close-crash.html

        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::V8NotificationCenter::requestPermissionCallback):
        * notifications/NotificationCenter.cpp:
        (WebCore::NotificationCenter::disconnectFrame):
2010-08-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Tests that requesting notification permission on a closed document does
        not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=43295

        * fast/notifications/notifications-document-close-crash-expected.txt: Added.
        * fast/notifications/notifications-document-close-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/notifications/notifications-document-close-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/notifications/notifications-document-close-crash.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/bindings/v8/custom/V8NotificationCenterCustom.cpp
WebCore/notifications/NotificationCenter.cpp