webkit:qtwebkit.git
7 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 18:09:54 +0000 (15:09 -0300)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix assert in QDeclarativeWebView
        https://bugs.webkit.org/show_bug.cgi?id=54240

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-14278

        Instantiating a QDeclarativeWebView twice will trigger an assertion
        when in debug mode.

        Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
        reviewed (there) by Aaron Kennedy
        f532679ca11914b453e22342f2ae5e9f790ce47a

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp

7 years ago2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Ademar de Souza Reis Jr [Mon, 14 Feb 2011 17:56:44 +0000 (14:56 -0300)]
2011-02-10  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Ensure WebView press delay timer is cancelled when grab is taken
        https://bugs.webkit.org/show_bug.cgi?id=54242

        As reported in:
        http://bugreports.qt.nokia.com/browse/QTBUG-15529

        Flickable steals the grab, but the timer was not stopped and the
        keepGrab flag is set and the mouse grabbed. This means that the WebView
        now has the grab and subsequent clicks on another element are ignored.

        Original patch from Martin Jones <martin.jones@nokia.com>
        reviewed (there) by Joona Petrell
        52068f57f9c32098a90cc217730a530f85590f65

        * declarative/qdeclarativewebview.cpp:
        (GraphicsWebView::sceneEvent):
        * declarative/qdeclarativewebview_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebKit/qt/ChangeLog
Source/WebKit/qt/declarative/qdeclarativewebview.cpp

7 years agoAdd a Tools --> WebKitTools symlink qtwebkit-2.1-week03 qtwebkit-2.1-week04
Ademar de Souza Reis Jr [Wed, 19 Jan 2011 20:26:03 +0000 (17:26 -0300)]
Add a Tools --> WebKitTools symlink

Mostly to make the bots and some tools happy, as this was
renamed on trunk.

7 years agoRemove TransformActionEvent support (2/2) qtwebkit-2.1-week02
Ademar de Souza Reis Jr [Thu, 13 Jan 2011 17:28:04 +0000 (14:28 -0300)]
Remove TransformActionEvent support (2/2)

This reverts commit 22fb1b1ccf3188a08dda9ee1a057b55047d5eabe:
    Add TransformActionEvent support
    https://bugs.webkit.org/show_bug.cgi?id=39757

We won't support TransformAction events in QtWebKit-2.1 as the current
implementation is not standard, is not in trunk and is not
required by anyone.

7 years agoRemove TransformActionEvent support (1/2)
Ademar de Souza Reis Jr [Thu, 13 Jan 2011 17:20:17 +0000 (14:20 -0300)]
Remove TransformActionEvent support (1/2)

This reverts commit 5472c61287b584c180800572d5549fde0839953c:
    Generate TransformAction events from touch gestures
    https://bugs.webkit.org/show_bug.cgi?id=39979

We won't support TransformAction events in QtWebKit-2.1 as the current
implementation is not standard, is not in trunk and is not
required by anyone.

Conflicts:
WebCore/WebCore.pro

7 years agoUpdate .def file for symbian winscw qtwebkit-2.1-week01
Ademar de Souza Reis Jr [Mon, 10 Jan 2011 19:47:42 +0000 (16:47 -0300)]
Update .def file for symbian winscw

Patch from Misha Tyutyunik <Michael.Tyutyunik@nokia.com>,
reviewed by Laszlo Gombos.

(https://bug-49373-attachments.webkit.org/attachment.cgi?id=78418)

7 years ago2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Ademar de Souza Reis Jr [Thu, 6 Jan 2011 19:42:21 +0000 (16:42 -0300)]
2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
        https://bugs.webkit.org/show_bug.cgi?id=51464

        Added a way to bind any QObject created as a plugin to JavaScript,
        by adding a custom member (qtObject) to WebCore::Widget.
        Added a test to tst_qwebpage to make sure plugins created
        as QGraphicsWidget are accessible through JavaScript.

        * bindings/js/ScriptControllerQt.cpp:
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * platform/Widget.h:
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::setBindingObject):
        (WebCore::Widget::bindingObject):
2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
        https://bugs.webkit.org/show_bug.cgi?id=51464

        Added a way to bind any QObject created as a plugin to JavaScript,
        by adding a custom membe to WebCore::Widget.
        Added a test to make sure plugins created as QGraphicsWidget are
        accessible through JavaScript.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * tests/qwebpage/tst_qwebpage.cpp:
        (PluginPage::createPlugin):
        (tst_QWebPage::graphicsWidgetPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/platform/Widget.h

7 years agoRevert "Added haptics implementation that is based on the haptics CSS properties... qtwebkit-2.1-week51 qtwebkit-2.1-week52
Ademar de Souza Reis Jr [Tue, 21 Dec 2010 17:58:36 +0000 (14:58 -0300)]
Revert "Added haptics implementation that is based on the haptics CSS properties and uses the haptics platform plugin interface"

This reverts commit 1be06f69d34d362b029bee53b1864f81c43fbff8.

We won't support haptics on QtWebKit-2.1, so it's being removed.

Conflicts:

WebCore/platform/qt/PlatformHapticsQt.cpp

7 years agoTemporary fix for #39958 (TextBreakIterator QT performance) qtwebkit-2.1-week50
Ademar de Souza Reis Jr [Mon, 20 Dec 2010 18:44:06 +0000 (15:44 -0300)]
Temporary fix for #39958 (TextBreakIterator QT performance)

[Qt] TextBreakIterator QT performance
https://bugs.webkit.org/show_bug.cgi?id=39958

The bug is still open and the the fix for trunk is under discussion,
(tests and detailed performance reviews), but we decided to push this
patch to 2.1 as it fixes the problem by now.

Patch by Raju Kunnath <raju.kunnath@nokia.com>, review mostly
done by Kenneth Rohde Christiansen.

7 years ago2010-12-09 Yael Aharon <yael.aharon@nokia.com> qtwebkit-2.1-week49
Ademar de Souza Reis Jr [Mon, 13 Dec 2010 20:24:03 +0000 (17:24 -0300)]
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        * fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
        that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
        thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
        navigation algorithm.

        Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html

        * page/FocusController.cpp:
        (WebCore::updateFocusCandidateIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/page/FocusController.cpp

7 years ago2010-11-29 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue [Mon, 29 Nov 2010 12:05:56 +0000 (12:05 +0000)]
2010-11-29  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        QtWebKit asserts when selecting elided text.
        https://bugs.webkit.org/show_bug.cgi?id=45391

        Ensure that the length passed to fromRawDataWithoutRef() does
        not exceed the length of the string.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::selectionRectForSimpleText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew fix for #9787: QtWebKit does not respond properly to QInputMethodEvents with... qtwebkit-2.1-week48.1
Ademar de Souza Reis Jr [Thu, 2 Dec 2010 19:40:52 +0000 (16:40 -0300)]
New fix for #9787: QtWebKit does not respond properly to QInputMethodEvents with replacement text in them

https://bugs.webkit.org/show_bug.cgi?id=49787

This is a qtwebkit-2.1-only fix, we still need to investigate this issue
on trunk, where the original patch was applied and a regression is
probably present (see comments on bug 49787).

7 years agoBackport of all necessary fixes for #43852
Ademar de Souza Reis Jr [Wed, 1 Dec 2010 15:01:51 +0000 (12:01 -0300)]
Backport of all necessary fixes for #43852

This is a consolidation of all necessary patches we need to fix #43852:

[Qt] resizeToContent seems to trigger infinite resize on some pages
https://bugs.webkit.org/show_bug.cgi?id=43852

Original work on the patch consolidation was done by
Nancy Piedra <nancy.piedra@nokia.com>

7 years ago2010-07-29 Michael Saboff <msaboff@apple.com>
commit-queue [Thu, 29 Jul 2010 21:33:19 +0000 (21:33 +0000)]
2010-07-29  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Fixed issue where RegExp greedy jit code loops when no input is
        consumed.  Changed the code to only loop if some input was consumed,
        but fall through if we successfully match an alternative that
        doesn't consume any input.
        https://bugs.webkit.org/show_bug.cgi?id=42664

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
2010-07-29  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Added tests to correspond to the changes made in
        JavaScriptCore/yarr/RegexJIT.cpp to fix
        https://bugs.webkit.org/show_bug.cgi?id=42664.
        Note that some of the new test cases fail due to one or more
        unrelated bugs in the pcre interpreter.  The expected results
        for these tests will need to be updated when the implementation
        conforms to the JS standard.

        * fast/js/regexp-look-ahead-empty-expected.txt: Added.
        * fast/js/regexp-look-ahead-empty.html: Added.
        * fast/js/script-tests/regexp-look-ahead-empty.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-12-02 Norbert Leser <norbert.leser@nokia.com> qtwebkit-2.1-week48
Ademar de Souza Reis Jr [Thu, 2 Dec 2010 21:15:28 +0000 (18:15 -0300)]
2010-12-02  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Reintroduce compiler optimizations for JSC
        https://bugs.webkit.org/show_bug.cgi?id=50270

        Add compiler optimization (symbian ARM target) which was lost after split from WebCore.
        Tested via Sunspider and V8 - both of which show significant performance improvement.

        * JavaScriptCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

JavaScriptCore/JavaScriptCore.pro

7 years agoBitmap.h has no default constructor
zherczeg [Sat, 7 Aug 2010 17:34:19 +0000 (17:34 +0000)]
Bitmap.h has no default constructor
https://bugs.webkit.org/show_bug.cgi?id=43619

Reviewed by Eric Seidel.

Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.

Csaba Osztrogonác helped to find this bug.

* wtf/Bitmap.h:
(WTF::::Bitmap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert "Backport fix for #49787 to qtwebkit-2.1"
Ademar de Souza Reis Jr [Thu, 2 Dec 2010 13:13:32 +0000 (10:13 -0300)]
Revert "Backport fix for #49787 to qtwebkit-2.1"

This reverts commit 85a22e12280f290c4eb0ccb4aec2ec9f13ffb7af.

As reported by Janne Koskinen on bugzilla
(https://bugs.webkit.org/show_bug.cgi?id=49787#c22), this breaks input
on symbian: "Each character entered gets deleted right after entering".

A new fix/backport for #49787 is being worked on.

7 years ago2010-08-25 Dawit Alemayehu <adawit@kde.org> qtwebkit-2.1-week47
Girish Ramakrishnan [Wed, 25 Aug 2010 16:33:34 +0000 (16:33 +0000)]
2010-08-25  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Ariya Hidayat.

        Proper workaround for missing Gtk initialization in Adobe's flash plugins.
        https://bugs.webkit.org/show_bug.cgi?id=44405

        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::initializeGtk):
        (WebCore::PluginPackage::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regressions introduced by the spatial navigation fixes (#49442 and #49382)
Yael Aharon [Sat, 27 Nov 2010 02:07:56 +0000 (21:07 -0500)]
Fix regressions introduced by the spatial navigation fixes (#49442 and #49382)

0f2e0cc960f49a04e4bd86a7f36373697b660bda introduced a few regressions on
layout tests. This commit fixes the regressions while keeping the intended
functionality in place.

See comments on https://bugs.webkit.org/show_bug.cgi?id=49382 for
details.

7 years agoUpdate symbian .def files after recent API changes
Ademar de Souza Reis Jr [Thu, 25 Nov 2010 18:52:19 +0000 (15:52 -0300)]
Update symbian .def files after recent API changes

Includes the following changes:

[Qt] Add an API for overriding the actual visible content rect in WebCore
https://bugs.webkit.org/show_bug.cgi?id=49373

[Qt] Support nodesFromRect in DRT
https://bugs.webkit.org/show_bug.cgi?id=48716

[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

7 years agoBackport fix for #49787 to qtwebkit-2.1
Ademar de Souza Reis Jr [Wed, 24 Nov 2010 22:02:17 +0000 (19:02 -0300)]
Backport fix for #49787 to qtwebkit-2.1

Based on patches from Kristian Amlie <kristian.amlie@nokia.com>
(https://bugs.webkit.org/show_bug.cgi?id=49787)

Original Changelog:

    2010-11-24  Kristian Amlie  <kristian.amlie@nokia.com>

            Reviewed by Andreas Kling.

            Fixed handling of QInputMethodEvents with nonzero replacementLength.

            These types of events replace text that is already in the widget, but
            WebKit did not check for replacementLength at all.

            https://bugs.webkit.org/show_bug.cgi?id=49787

            * Api/qwebpage.cpp:
            (QWebPagePrivate::inputMethodEvent):
            * tests/qwebpage/tst_qwebpage.cpp:
            (tst_QWebPage::inputMethods):

7 years agoBackport to qtwebkit-2.1 the fixes for #49442 and #49382
Yael Aharon [Wed, 24 Nov 2010 01:55:31 +0000 (20:55 -0500)]
Backport to qtwebkit-2.1 the fixes for #49442 and #49382

Patch from Yael Aharon <yael.aharon@nokia.com>
http://gitorious.org/~yael/webkit/yaels-qtwebkit/commit/d7788b5e68b9a6909e4a6c545e4b233729921d38

Original changelogs:

    Spatial Navigation: Code cleanup
    https://bugs.webkit.org/show_bug.cgi?id=49442

    Remove code that is not used anymore after http://trac.webkit.org/changeset/72522.
    Added const to canBeScrolledIntoView.
    No new tests because this is only code cleanup.

and

    Spatial Navigation: issues with the node selection algorithm.
    https://bugs.webkit.org/show_bug.cgi?id=49382

    Modify the Spatial Navigation algorithm, to better handle initial focus and
    navigation between frames.
    The new algorithm takes the rect of the focused node as the startingRect,
    instead of the node itself. That allows us to construct a virtual rect if
    there is no focused node, or if it is off the screen.
    The virtual rect is the edge of the container in the direction of the navigation.

    With this patch, scrollable containers and frames will scroll regardless of weather
    they have focusable content. Users will be able to use arrow keys to view all the
    content of such a container. The only exception is if the container has style overflow:hidden.
    We will not scroll in that case.

    With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
    we do a hit test and only the node on top can get focus.

    hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
    its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
    and cannot scroll.

    calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
    the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
    allowed to scroll.

7 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:24:06 +0000 (14:24 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Renamed requestPermissionFromUser to featurePermissionRequested
and cancelRequestsForPermission to featurePermissionRequestCanceled.

WebKit/qt:

* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::featurePermissionRequestCanceled):
* QtTestBrowser/webpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:46 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename setUserPermission to setFeaturePermission

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setFeaturePermission):
* Api/qwebpage.h:
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:24 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
and GeolocationPermissionDomain to Geolocation.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::geolocationPermissionSet):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::cancelRequestsForPermission):
* QtTestBrowser/webpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Review the setUserPermission & friends API
hausmann@webkit.org [Tue, 23 Nov 2010 14:22:59 +0000 (14:22 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Add a ByUser suffix to PermissionGranted/Denied. In the future
we can add PermissionGrantedByDefault.

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::setPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove synchronous QWebPage::checkPermissions signal
hausmann@webkit.org [Tue, 16 Nov 2010 16:28:14 +0000 (16:28 +0000)]
[Qt] Remove synchronous QWebPage::checkPermissions signal
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Andreas Kling.

WebKit/qt:

As decided in the API review, we remove this signal and replace its only use currently
with cached credentials.

* Api/qwebpage.cpp:
(QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.
* Api/qwebpage.h:
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
signal emission with hash lookup of previously granted permission (or not).
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
any previously cached/granted permission for the given script execution context.
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
only serve pending permission requests but before calling the JS callbacks, remember
the permission for subsequent synchronous checkPermission() calls.
* WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission): When granting
permission, grant it directly on the QWebPage/Frame, that will remember it.
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
* QtTestBrowser/webpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit/qt:
Simon Hausmann [Tue, 23 Nov 2010 14:50:38 +0000 (15:50 +0100)]
WebKit/qt:

2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Andreas Kling

        Remove QWebSettings::WebGLEnabled in the 2.1 branch, as it is
        not implemented.

7 years agoRevert "Spatial Navigation: issues with the node selection algorithm." qtwebkit-2.1-week46
Ademar de Souza Reis Jr [Mon, 22 Nov 2010 18:50:40 +0000 (15:50 -0300)]
Revert "Spatial Navigation: issues with the node selection algorithm."

This reverts commit a55b9748a5061297fc72984e623f5cb342378bad.

Looked simple at first (no major conflicts!), but requires
changes not present in qtwebkit-2.1 which are non-trivial.

In particular, it requires 5329478a3cb8b58d19d748790fa69e6a87b14a65
(https://bugs.webkit.org/show_bug.cgi?id=48157)

7 years agoSpatial Navigation: issues with the node selection algorithm.
Ademar de Souza Reis Jr [Mon, 22 Nov 2010 15:59:58 +0000 (12:59 -0300)]
Spatial Navigation: issues with the node selection algorithm.
https://bugs.webkit.org/show_bug.cgi?id=49382

Patch by Yael Aharon  <yael.aharon@nokia.com>, Chang Shu <chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.

WebCore:

Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.

With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.

With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.

hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.

calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/FocusController.h:
* page/FrameView.h:
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
* page/SpatialNavigation.h:

LayoutTests:

Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.

* fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
* fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/page/FrameView.h

7 years agoFix for #49718: [Qt] Canvas doesn't animate on OpenVG backend
Ademar de Souza Reis Jr [Thu, 18 Nov 2010 13:23:18 +0000 (10:23 -0300)]
Fix for #49718: [Qt] Canvas doesn't animate on OpenVG backend

https://bugs.webkit.org/show_bug.cgi?id=49718
(this commit is a kind of a hack for 2.1 only and will not be
applied to trunk, so the bug is still open)

Patch from Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Andreas Kling (for 2.1)

7 years agoImplemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
commit-queue [Thu, 14 Oct 2010 22:16:34 +0000 (22:16 +0000)]
Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
https://bugs.webkit.org/show_bug.cgi?id=34539

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-10-14
Reviewed by Andreas Kling

These missing NPN functions cause Java applets to crash in ports such
as QtWebkit that rely on webkit for Java applet support.

Patch backported by Diego Gonzalez <diegohcg@webkit.org>
to work without NetworkingContext running on top of Qt WebKit Release 2.1

Rubberstamped by Ademar de Souza Reis Jr.

* plugins/PluginDebug.cpp:
(WebCore::prettyNameForNPNURLVariable):
* plugins/PluginDebug.h:
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::initializeBrowserFuncs):
* plugins/PluginView.cpp:
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
(WebCore::PluginView::getAuthenticationInfo):
* plugins/PluginView.h:
* plugins/npapi.cpp:
(NPN_GetValueForURL):
(NPN_SetValueForURL):
(NPN_GetAuthenticationInfo):
* platform/network/ProxyServer.h:
* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyServersForURL):
* platform/network/qt/ProxyServerQt.cpp:
(WebCore::proxyServersForURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo.
Anders Carlsson [Fri, 1 Oct 2010 23:49:58 +0000 (23:49 +0000)]
Fix typo.

* platform/network/qt/ProxyServerQt.cpp:
(WebCore::proxyServersForURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Qt ProxyServer stub.
Anders Carlsson [Fri, 1 Oct 2010 23:45:33 +0000 (23:45 +0000)]
Add Qt ProxyServer stub.

* WebCore.pro:
* platform/network/qt/ProxyServerQt.cpp: Added.
(WebCore::proxyServersForURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd proxy server query function proxyServersForURL and change the Mac plug-in code...
Anders Carlsson [Fri, 1 Oct 2010 23:28:17 +0000 (23:28 +0000)]
Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
https://bugs.webkit.org/show_bug.cgi?id=47022
<rdar://problem/8504712>

Reviewed by Dan Bernstein.

WebCore:

* WebCore.exp.in:
Export proxyServersForURL and toString.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

* platform/network/ProxyServer.cpp: Added.
(WebCore::appendProxyServerString):
(WebCore::toString):
New function that converts a vector of ProxyServers into a PAC style string.

* platform/network/ProxyServer.h: Added.
(WebCore::ProxyServer::ProxyServer):
(WebCore::ProxyServer::type):
(WebCore::ProxyServer::hostName):
(WebCore::ProxyServer::port):
Add ProxyServer class.

* platform/network/cf/ProxyServerCFNet.cpp: Added.
(WebCore::proxyServersForURL):
(WebCore::addProxyServersForURL):
Query CFNetwork for the proxy servers given a URL.

WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getProxy):
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:forURL:value:length:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-27 Dawit Alemayehu <adawit@kde.org>
commit-queue [Fri, 27 Aug 2010 17:35:18 +0000 (17:35 +0000)]
2010-08-27  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Simon Hausmann.

        [Qt] Search the Windows registry for the location of the Java plugin DLL.
        https://bugs.webkit.org/show_bug.cgi?id=38911

        This change, in addition to the ones 34539 and 38911, is needed to
        make Java applet work in QtWebKit on the Windows platform.

        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::addJavaPluginDirectory):
        (WebCore::PluginDatabase::defaultPluginDirectories):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert "Fix HTML Canvas not updating properly with VG backend"
Ademar de Souza Reis Jr [Tue, 16 Nov 2010 19:04:19 +0000 (16:04 -0300)]
Revert "Fix HTML Canvas not updating properly with VG backend"

This reverts commit 4364e9073001e0469fae0c4a86f989fa1c5268a5.

Committed by mistake, since qtwebkit-2.1 is frozen and this
fix is not part of the release-critical bugs (#39121).

Please follow the procedure documented on
http://trac.webkit.org/wiki/QtWebKitReleases when requesting the
inclusion of patches on a release branch. :-)

7 years agoFix HTML Canvas not updating properly with VG backend
Janne Koskinen [Tue, 16 Nov 2010 11:50:03 +0000 (13:50 +0200)]
Fix HTML Canvas not updating properly with VG backend

Force copying of pixmap to VGImage by calling paintEngine()
thus updating the image data in VG memory

Task-number: QT-4002
Reviewed-by: Jason Barron
7 years ago2010-11-12 Yael Aharon <yael.aharon@nokia.com> qtwebkit-2.1-week45
Ademar de Souza Reis Jr [Tue, 16 Nov 2010 00:25:39 +0000 (21:25 -0300)]
2010-11-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Need better way to control size of content in tests.
        https://bugs.webkit.org/show_bug.cgi?id=49398

        Add an image and use it in a layout test to define fixed size for all ports.
        This also fixes https://bugs.webkit.org/show_bug.cgi?id=43030

        * fast/events/spatial-navigation/resources/green.png: Added.
        * fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
        * fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped

7 years ago2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue [Fri, 12 Nov 2010 17:30:51 +0000 (17:30 +0000)]
2010-11-12  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Button's background style from default Qt Mobile Theme  is overriding facebook's button style
        https://bugs.webkit.org/show_bug.cgi?id=48198

        Instead of creating gradients that goes from white to grey and cover the whole element the gradients
        are created by varying the alpha channel of a dark color. This way the effect will not override the
        background color of the elements.

        * css/themeQtMobile.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTentative update of symbian .def files to remove QWebScriptWorld symbols
Ademar de Souza Reis Jr [Fri, 12 Nov 2010 20:20:40 +0000 (17:20 -0300)]
Tentative update of symbian .def files to remove QWebScriptWorld symbols

Hopefully it's correct :-)

7 years agoRevert "[Qt] Support evaluateScriptInIsolatedWorld()"
Ademar de Souza Reis Jr [Fri, 12 Nov 2010 20:08:27 +0000 (17:08 -0300)]
Revert "[Qt] Support evaluateScriptInIsolatedWorld()"

This reverts commit ee8a75c0ec05ad840b1a239e7e3138ad1fa1374e.
(https://bugs.webkit.org/show_bug.cgi?id=40079)

Part of:
    [Qt] QWebScriptWorld should not be in QtWebKit 2.1
    https://bugs.webkit.org/show_bug.cgi?id=49372

Conflicts:
WebKit/qt/Api/qwebframe.cpp
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

7 years agoRevert "[Qt] Support evaluateScriptInIsolatedWorld()"
Ademar de Souza Reis Jr [Fri, 12 Nov 2010 20:03:03 +0000 (17:03 -0300)]
Revert "[Qt] Support evaluateScriptInIsolatedWorld()"

This reverts commit 7d166d593bd2d3170b655be42b9404571dbcfe90.
(https://bugs.webkit.org/show_bug.cgi?id=40079)

Part of:
    [Qt] QWebScriptWorld should not be in QtWebKit 2.1
    https://bugs.webkit.org/show_bug.cgi?id=49372

Conflicts:
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

7 years agoRevert "[Qt] Prospective build fix for MSVC"
Ademar de Souza Reis Jr [Fri, 12 Nov 2010 19:39:33 +0000 (16:39 -0300)]
Revert "[Qt] Prospective build fix for MSVC"

This reverts commit c408009a96fc33f131dd4d8f988d4453d95a9cc9.

Part of:
    [Qt] QWebScriptWorld should not be in QtWebKit 2.1
    https://bugs.webkit.org/show_bug.cgi?id=49372

7 years ago2010-11-03 Antonio Gomes <tonikitoo@webkit.org>, Andre Pedralho <andre.pedralho...
Ademar de Souza Reis Jr [Thu, 11 Nov 2010 19:06:22 +0000 (16:06 -0300)]
2010-11-03  Antonio Gomes  <tonikitoo@webkit.org>, Andre Pedralho  <andre.pedralho@gmail.com>

        Reviewed by Kenneth Rohde Christiansen and Antti Koivisto.

        [Qt] Making effective use of nodesFromRect.
        https://bugs.webkit.org/show_bug.cgi?id=44089

        Patch adds a helper class (named TouchAdjuster) to improve tap actions
        on mobile touch devices. TouchAdjuster makes use of the newly added rect
        based hit test extension through the Document::nodesFromRect method.
        Given a rectangle as input, nodesFromRect returns a z-index ordered list
        of nodes whose boundaries intersect the rectangle.

        Basically the TouchAdjuster class intercepts the QGraphicsSceneMouseEvent
        passed to both QWebPagePrivate::mouse{Press,Release}Event methods before
        they are passed down to WebCore. The goal is to infer the target click position.
        For that, a rectangle is built up using the event position as a center point and
        expanding it based on the values and directions set in the Platform Plugin
        QWebTouchModifier::hitTestPadding.

        TouchAdjuster iterates over the list of nodes returned by nodesFromRect and
        picks the clickable one that has the largest intersection area with the hit
        test rectangle. The target position is then the center point of this intersection
        area.

        In case of no clickable node intersects the hit test area, the click position
        is not altered.

        TouchAdjuster is *only* working for QGraphicsWebView based views.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::mousePressEvent):
        (QWebPagePrivate::mouseReleaseEvent):
        (QWebPagePrivate::adjustPointForClicking):
        (QWebPagePrivate::TouchAdjuster::TouchAdjuster):
        (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
        (isClickableElement):
        (hasMouseListener):
        (isValidFrameOwner):
        (nodeToElement):
        * Api/qwebpage_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebKit/qt/Api/qwebpage.cpp

7 years agodocument.nodesFromRect() needs to be removed from Document.idl
Ademar de Souza Reis Jr [Thu, 11 Nov 2010 20:10:53 +0000 (17:10 -0300)]
document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

* dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

* fast/dom/Window/window-properties-expected.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac/Skipped
LayoutTests/platform/qt/Skipped
LayoutTests/platform/win/Skipped

7 years agoMake Document::nodesFromRect more flexible
Ademar de Souza Reis Jr [Thu, 11 Nov 2010 19:48:22 +0000 (16:48 -0300)]
Make Document::nodesFromRect more flexible
https://bugs.webkit.org/show_bug.cgi?id=46336

Patch by Antonio Gomes <agomes@rim.com> on 2010-09-23
Reviewed by Kenneth Christiansen.

The patch changes the API for the Document::nodesFromRect() method as follows:

from
- RefPtf<NodeList> nodesFromRect(int x, int y, unsigned horizontalPadding, unsigned verticalPadding, bool ignoreClipping)

to
- RefPtf<NodeList> nodesFromRect(int x, int y, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding,
                                 unsigned leftPadding, bool ignoreClipping)

Previously the method was receiving as parameter horizontal and vertical padding values.
In practice, the horizontal padding was being used to expand a given center point in both
right and left directions, while vertical padding was expanding it to the top and bottom directions.

Although this design makes it possible to improve the touch experience on mobile devices
(Document::nodesFromRect exposes the rect based hit testing system), empirical experiments
showed that, specially in capacitive touch screens, users tend to tap below elements. So
for even more accurate results (which means here the possibility of pleasant tapping experience),
it makes sense to use a region that is offset more above the touch point, favoring elements
above the touch point.

The patch basically implements that, increasing the API flexible and power by making it possible
to specify different padding values for each direction in a given orientation.

Changes were made accordingly to the HitTestResult, RenderLayer, RenderImage and RenderLineBoxList
classes.

WebCore:

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* dom/Document.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint): For simplicity, I did not change the signature
    but the way the padding value passed in as parameter is being used to construct a HitTestResult.
* rendering/HitTestResult.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings
    for each direction.
(WebCore::HitTestResult::HitTestResult): Ditto.
(WebCore::HitTestResult::operator=): Ditto.
(WebCore::HitTestResult::rectFromPoint): Ditton.
* rendering/HitTestResult.h:
(WebCore::HitTestResult::topPadding): getter for the top padding.
(WebCore::HitTestResult::rightPadding): getter for the right padding.
(WebCore::HitTestResult::bottomPadding): getter for the bottom padding.
(WebCore::HitTestResult::leftPadding): getter for the left padding.
(WebCore::HitTestResult::rectFromPoint): Added a static method that given a center point and padding values for
    each direction, returns the rect that is going to be used in WebCore's hit testing processing.
* rendering/RenderImage.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings for each direction.
(WebCore::RenderImage::nodeAtPoint): Ditto.
* rendering/RenderLayer.cpp: Ditto.
(WebCore::RenderLayer::hitTestLayer): Ditto.
(WebCore::RenderLayer::hitTestList): Ditto.
* rendering/RenderLineBoxList.cpp: Ditto.
(WebCore::RenderLineBoxList::hitTest): Ditto.

LayoutTests:

* fast/dom/nodesFromRect-basic-expected.txt:
* fast/dom/nodesFromRect-basic.html:
* fast/dom/resources/nodesFromRect.js:
(check):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/WebCore.exp.in

7 years ago[Mac][DRT] Implement LayoutTestController::nodesFromRect
Ademar de Souza Reis Jr [Thu, 11 Nov 2010 19:43:44 +0000 (16:43 -0300)]
[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580

Patch by Antonio Gomes <agomes@rim.comg> on 2010-09-26
Reviewed by Kenneth Christiansen.

WebCore:

Symbol files updated.

* WebCore.exp.in: Added symbols to Document::nodesFromRect and bits of JSDocument now
needed in WebKit/mac.
* WebCore.xcodeproj/project.pbxproj: Set both JSDocument.h and JSNodeList as private headers
now that they are referred in WebKit/mac.

WebKit/mac:

Implement nodesFromRect as a private method to access non-exposed Document
methods, similarly to computedStyleIncludingVisitedInfo.

* WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
These headers makes it possible to:
1) Get a Document off of a JSDocument;
2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
gotten from Document::nodesFromRect to JS bindings.
(-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
* WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.

WebKitTools:

Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.

* DumpRenderTree/LayoutTestController.cpp:
(nodesFromRectCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::LayoutTestController::nodesFromRect):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::nodesFromRect):

LayoutTests:

Unskipping fast/dom/nodesFromRect-based.html on Mac, and changes it
so that it calls layoutTestController.nodesFromRect() instead of
document.nodesFromRect().

* fast/dom/resources/nodesFromRect.js:
(check):
* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/mac/Skipped
WebCore/WebCore.exp.in
WebCore/WebCore.xcodeproj/project.pbxproj

7 years agoBuild fix (leftover from previous commit)
Ademar de Souza Reis Jr [Tue, 9 Nov 2010 17:58:58 +0000 (14:58 -0300)]
Build fix (leftover from previous commit)

ee16ad6 ("[Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu")
includes remote inspector support, which is not available on qtwebkit-2.1.

7 years ago2010-10-24 Yi Shen <yi.4.shen@nokia.com>
Ademar de Souza Reis Jr [Tue, 9 Nov 2010 17:51:15 +0000 (14:51 -0300)]
2010-10-24  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
        https://bugs.webkit.org/show_bug.cgi?id=48141

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::init):
        (LauncherWindow::initializeView):
        (LauncherWindow::toggleWebView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebKitTools/QtTestBrowser/launcherwindow.cpp

7 years agoFix for #43874: Downloading using XHR is much slower than before qtwebkit-2.1-week44
Ademar de Souza Reis Jr [Wed, 3 Nov 2010 18:20:50 +0000 (15:20 -0300)]
Fix for #43874: Downloading using XHR is much slower than before

https://bugs.webkit.org/show_bug.cgi?id=43987
Give ScriptString a rope to avoid slowness when building strings
with the += operator (used by XHR).

Patch by Andreas Kling <kling@webkit.org>
Rubberstamped by Kenneth Rohde Christiansen.

7 years ago2010-11-03 Andre Pedralho <andre.pedralho@gmail.com>
commit-queue [Thu, 4 Nov 2010 03:55:33 +0000 (03:55 +0000)]
2010-11-03  Andre Pedralho  <andre.pedralho@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Using the Platform Plugin to define the default values for the padding of HitTestResult.
        https://bugs.webkit.org/show_bug.cgi?id=48450

        * Api/qwebkitplatformplugin.h:
        (QWebTouchModifier::~QWebTouchModifier):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createTouchModifier):
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        (TouchModifier::hitTestPaddingForTouch):
        * examples/platformplugin/qwebkitplatformplugin.h:
        (QWebTouchModifier::~QWebTouchModifier):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-20 Chang Shu <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>
Ademar de Souza Reis Jr [Fri, 5 Nov 2010 14:49:49 +0000 (11:49 -0300)]
2010-10-20  Chang Shu  <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>

        Reviewed by Simon Fraser.

        Spatial Navigation: add support to <input type=text> and <textarea>
        https://bugs.webkit.org/show_bug.cgi?id=37153

        Before this patch, the focus cannot move away from input box once it is in. This patch allows focus
        move to neighbor nodes when the caret reaches the edge of the texts. This patch does not support yet
        cases where the focused <input> has a JS handler for the arrow keys.

        WebCore:

        Tests: fast/events/spatial-navigation/snav-input.html
        fast/events/spatial-navigation/snav-textarea.html

        * editing/EditorCommand.cpp:
        (WebCore::executeMoveDown):
        (WebCore::executeMoveLeft):
        (WebCore::executeMoveRight):
        (WebCore::executeMoveUp):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify):

        WebKit/qt:

        * WebCoreSupport/EditorClientQt.cpp:
        WebCore::EditorClientQt::handleKeyboardEvent):

        LayoutTests:

        * fast/events/spatial-navigation/snav-input-expected.txt: Added.
        * fast/events/spatial-navigation/snav-input.html: Added.
        * fast/events/spatial-navigation/snav-textarea-expected.txt: Added.
        * fast/events/spatial-navigation/snav-textarea.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/gtk/Skipped

7 years ago2010-11-03 George Guo <George.Guo@Nokia.com>
commit-queue [Thu, 4 Nov 2010 03:40:13 +0000 (03:40 +0000)]
2010-11-03  George Guo  <George.Guo@Nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
        https://bugs.webkit.org/show_bug.cgi?id=48767

        Paging is needd on Symbian devices to support benchmarks tests like
        dromaeo.com and Celtic Kane that need a lot of memory to run

        * QtTestBrowser/QtTestBrowser.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-26 Yi Shen <yi.4.shen@nokia.com>
commit-queue [Tue, 26 Oct 2010 19:49:01 +0000 (19:49 +0000)]
2010-10-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Skipping popup focus test for symbian
        https://bugs.webkit.org/show_bug.cgi?id=48324

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-29 Andreas Kling <kling@webkit.org>
Andreas Kling [Fri, 29 Oct 2010 23:24:56 +0000 (23:24 +0000)]
2010-10-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
        https://bugs.webkit.org/show_bug.cgi?id=48692

        * Api/qwebpage.cpp:
        (QWebPage::event): Add missing break statement.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-11-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue [Tue, 2 Nov 2010 02:20:35 +0000 (02:20 +0000)]
2010-11-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][Symbian] QtTestBrowser runs out of memory with most of javascript benchmarks.
        https://bugs.webkit.org/show_bug.cgi?id=48730

        Increase the maximum heap size on Symbian to 256 MB.

        * WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-22 Yi Shen <yi.4.shen@nokia.com>
commit-queue [Fri, 22 Oct 2010 15:35:38 +0000 (15:35 +0000)]
2010-10-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] InspectorClientQt crashes when deleting a qwebpage which has an inspector
        https://bugs.webkit.org/show_bug.cgi?id=48079

        * Api/qwebpage.cpp:
        (QWebPagePrivate::~QWebPagePrivate):
        (QWebPage::~QWebPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the gap in the def files that was accidentially introduced in
Simon Hausmann [Fri, 29 Oct 2010 09:45:40 +0000 (11:45 +0200)]
Fix the gap in the def files that was accidentially introduced in
commit e90c2b23b7bc9bf2d41759593b06b007969c8b98

Backported def file from trunk and marked the symbols that fill the
gap as absent.

7 years ago[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot...
Jocelyn Turcotte [Tue, 19 Oct 2010 10:34:56 +0000 (10:34 +0000)]
[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809

Reviewed by Andreas Kling.

Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.

* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
* QtTestBrowser/urlloader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-27 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Jocelyn Turcotte [Wed, 27 Oct 2010 19:39:42 +0000 (19:39 +0000)]
2010-10-27  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix tst_QWebFrame::popupFocus().
        https://bugs.webkit.org/show_bug.cgi?id=48432

        - Call setFocus() before show() to work around a but in Qt.
        - Remove the check on combo at the end since hidePopup() leads
          indirectly to its destruction and segfault.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Benjamin Poulain [Thu, 30 Sep 2010 07:10:01 +0000 (07:10 +0000)]
2010-09-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Fix tst_QWebPage::geolocationRequestJS()
        https://bugs.webkit.org/show_bug.cgi?id=46814

        Disable the test. This test cannot pass with a
        standard build of WebKit, it is disabled until the API is finilized.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::geolocationRequestJS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Jocelyn Turcotte [Tue, 26 Oct 2010 19:47:41 +0000 (19:47 +0000)]
2010-10-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix an assert with QtPixmapInstance creation.
        https://bugs.webkit.org/show_bug.cgi?id=48323

        This places the newly refcounted QtPixmapInstance in a RefPtr
        to prevent an assert on the first ref() call.

        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-26 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Jocelyn Turcotte [Tue, 26 Oct 2010 19:35:31 +0000 (19:35 +0000)]
2010-10-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Unit tests: setHtml("data:text/html,...") -> load(QUrl("data:text/html,..."))
        https://bugs.webkit.org/show_bug.cgi?id=48319

        These tests were failing since the new HTML parser.
        This patch removes the content type from the error page as well.

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::crashOnViewlessWebPages):
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::frame):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::loadFinished):
        (ErrorPage::extension):
        (tst_QWebPage::errorPageExtension):
        (tst_QWebPage::errorPageExtensionInIFrames):
        (tst_QWebPage::errorPageExtensionInFrameset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Ademar de Souza Reis Jr [Fri, 22 Oct 2010 20:38:19 +0000 (17:38 -0300)]
2010-10-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Layout tests for fix focusing of control elements on mouse click.
        https://bugs.webkit.org/show_bug.cgi?id=40641

        * fast/events/click-focus-control-expected.txt: Added.
        * fast/events/click-focus-control.html: Added.
        * platform/mac/fast/events/click-focus-control-expected.txt: Added.
        * platform/win/Skipped:
2010-10-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Fix focusing of control elements on mouse click.
        Brings GTK fix to Qt platform.
        https://bugs.webkit.org/show_bug.cgi?id=40641

        Test: fast/events/click-focus-control.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isMouseFocusable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/win/Skipped

7 years ago2010-10-21 Robert Hogan <robert@webkit.org> qtwebkit-2.1-week42
Ademar de Souza Reis Jr [Fri, 22 Oct 2010 19:09:45 +0000 (16:09 -0300)]
2010-10-21  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Sending a QInputMethodEvent::Selection event forces the
             Editor to go into Composition mode

        Improve QWebPage handling of input method events:
         - Selections don't trigger entering composition mode.
         - Handle multiple selections

        Also remove redundant cancellation of composition in tst_qwebpage.
        There is no composition in progress at that point.

        Finally, move infiniteLoopJS() to the end of the tst_qwebpage unit
        tests - so you don't have to wait for it to complete when running
        other tests.

        https://bugs.webkit.org/show_bug.cgi?id=39625

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        (QWebPage::inputMethodQuery):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebKit/qt/Api/qwebpage.cpp
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

7 years ago[Qt] Windowless mode 64-bit Flash/X11 freezes when right-click is sent.
Girish Ramakrishnan [Tue, 12 Oct 2010 21:12:27 +0000 (21:12 +0000)]
[Qt] Windowless mode 64-bit Flash/X11 freezes when right-click is sent.

Reviewed by Ariya Hidayat.

Adds a new quirk PluginQuirkIgnoreRightClickInWindowlessMode. This
quirk is enabled only for 64-bit Flash/X11 and should not affect other
plugins. The freeze itself is in Flash code and the backtrace is not
useful.

https://bugs.webkit.org/show_bug.cgi?id=47545

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
* plugins/PluginQuirkSet.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::handleMouseEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-05 Andreas Kling <kling@webkit.org>
Andreas Kling [Tue, 5 Oct 2010 21:41:41 +0000 (21:41 +0000)]
2010-10-05  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Re-enable single-NPP_SetWindow quirk for 64-bit
        https://bugs.webkit.org/show_bug.cgi?id=45363

        This is still causing trouble for people, so let's put the
        quirk back until we can figure this out properly.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::determineQuirks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-27 Andreas Kling <andreas.kling@nokia.com>
Andreas Kling [Mon, 27 Sep 2010 11:45:31 +0000 (11:45 +0000)]
2010-09-27  Andreas Kling  <andreas.kling@nokia.com>

        Rubber-stamped by Kenneth Rohde Christiansen.

        [Qt] 32-bit Flash crashes on repeated SetWindow calls
        https://bugs.webkit.org/show_bug.cgi?id=46616

        Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

        We incorrectly thought this was fixed in Flash 10, but it turns out it
        was just never broken on 64-bit.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::determineQuirks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue [Tue, 19 Oct 2010 05:37:04 +0000 (05:37 +0000)]
2010-10-18  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Export QWebPage::ViewportAttributes class.
        https://bugs.webkit.org/show_bug.cgi?id=47845

        * Api/qwebpage.h:
        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-18 Yi Shen <yi.4.shen@nokia.com>
commit-queue [Mon, 18 Oct 2010 15:41:14 +0000 (15:41 +0000)]
2010-10-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [QT] Unable to load pages on QtTestBrowser after canceling a page load.
        https://bugs.webkit.org/show_bug.cgi?id=43827

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-04 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue [Wed, 4 Aug 2010 18:08:46 +0000 (18:08 +0000)]
2010-08-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Variable max heap size between target/emulator
        https://bugs.webkit.org/show_bug.cgi?id=41480

        * WebKit.pri: Symbian-only code block for EPOCHEAPSIZE configuration

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up the winscw changes
Dinu Jacob [Mon, 18 Oct 2010 12:23:19 +0000 (14:23 +0200)]
Clean up the winscw changes

Guard some winscw specific changes with COMPILER(WINSCW), to make sure that
the other compiler/platform builds are not affected.

Signed-off-by: Simon Hausmann <simon.hausmann@nokia.com>
7 years agoUpdated the def file for winscw
Simon Hausmann [Thu, 7 Oct 2010 13:17:33 +0000 (15:17 +0200)]
Updated the def file for winscw

7 years agoFix winscw cast when returning bool on methods which return Value
Ademar de Souza Reis Jr [Fri, 8 Oct 2010 09:19:08 +0000 (11:19 +0200)]
Fix winscw cast when returning bool on methods which return Value

7 years agoWinscw build fix
Ademar de Souza Reis Jr [Thu, 7 Oct 2010 08:36:54 +0000 (10:36 +0200)]
Winscw build fix

Based on patch made by Yael Aharon <yael.aharon@nokia.com>.

Original patch (from 2010-09-06) here:
http://gitorious.org/~ekoppen/webkit/qtwebkit-symbian-qtp/commit/a7086cc3132a5bf78c73b941f372b84d7da29467

7 years ago2010-10-15 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue [Fri, 15 Oct 2010 16:27:27 +0000 (16:27 +0000)]
2010-10-15  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] window.close() doesn't work in qt
        https://bugs.webkit.org/show_bug.cgi?id=46186

        Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-13 Yi Shen <yi.4.shen@nokia.com> qtwebkit-2.1-week41
commit-queue [Wed, 13 Oct 2010 23:58:00 +0000 (23:58 +0000)]
2010-10-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser shows two Url input fields
        https://bugs.webkit.org/show_bug.cgi?id=47613

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::buildUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-08 Hui Huang <hui.2.huang@nokia.com>
commit-queue [Fri, 8 Oct 2010 13:58:11 +0000 (13:58 +0000)]
2010-10-08  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Simon Hausmann.

        ifdef out code that rewrites Flash Plug-in wmode for Symbian build
        https://bugs.webkit.org/show_bug.cgi?id=43484

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-13 Dinu Jacob <dinu.jacob@nokia.com>
commit-queue [Wed, 13 Oct 2010 11:56:12 +0000 (11:56 +0000)]
2010-10-13  Dinu Jacob  <dinu.jacob@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Update .def file for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=47540

        Updated symbols for Symbian - added viewportAttributesForSize and
        made viewportConfigurationForSize absent based on the API change in
        47325

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-12 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 12 Oct 2010 14:47:24 +0000 (14:47 +0000)]
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        * fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
        * fast/events/scroll-after-click-on-tab-index.html: Added.
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        Remove calls to editor()->command() when we are not in editable content.
        There is no value in doing that, and in some cases, it prevents scrolling.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-12 David Leong <david.leong@nokia.com>
commit-queue [Wed, 13 Oct 2010 04:29:24 +0000 (04:29 +0000)]
2010-10-12  David Leong  <david.leong@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable Netscape plugin metadata caching on Linux
        https://bugs.webkit.org/show_bug.cgi?id=46287

        QWebSettings::enablePersistentStorage will now store the netscape
        plugin cache to QDesktopServices::CacheLocation.

        * Api/qwebsettings.cpp:
        (QWebSettings::enablePersistentStorage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
Andreas Kling [Wed, 13 Oct 2010 14:11:32 +0000 (16:11 +0200)]
2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

        Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
        different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
        were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
        all page specific stuff to the UI.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::initializeView):
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::buildUI):
        (MainWindow::setPage):
        * QtTestBrowser/mainwindow.h:

7 years agoWindowless flash plugin is not rendered in Symbian qtwebkit-2.1-week40
Simon Hausmann [Thu, 7 Oct 2010 09:11:44 +0000 (09:11 +0000)]
Windowless flash plugin is not rendered in Symbian
https://bugs.webkit.org/show_bug.cgi?id=47172

Patch by Zraly Mike <mike.zraly@nokia.com> on 2010-10-07
Reviewed by Andreas Kling.

* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformStart):
Add call to updatePluginWidget() following changes to
platform widget.  This is needed to set PluginView's
m_windowRect and m_clipRect members properly after
the proxy widget and its container get created.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-07 Andreas Kling <kling@webkit.org>
commit-queue [Thu, 7 Oct 2010 19:41:44 +0000 (19:41 +0000)]
2010-10-07  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] API: ViewportConfiguration => ViewportArguments
        https://bugs.webkit.org/show_bug.cgi?id=47325

        * Api/qwebpage.cpp:
        (QWebPage::ViewportAttributes::ViewportAttributes):
        (QWebPage::ViewportAttributes::~ViewportAttributes):
        (QWebPage::ViewportAttributes::operator=):
        (QWebPage::viewportAttributesForSize):
        * Api/qwebpage.h:
        * Api/qwebpage_p.h:
        (QtViewportAttributesPrivate::QtViewportAttributesPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue [Wed, 6 Oct 2010 17:34:24 +0000 (17:34 +0000)]
2010-10-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
        https://bugs.webkit.org/show_bug.cgi?id=47268

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

        * dom/ViewportArguments.cpp:
        (WebCore::findConfigurationForViewportData):
        * dom/ViewportArguments.h:
2010-10-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
        https://bugs.webkit.org/show_bug.cgi?id=47268

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

        * Api/qwebpage.cpp:
        (QWebPage::viewportConfigurationForSize):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Re-enable the web inspector for maemo6 builds
hausmann@webkit.org [Thu, 7 Oct 2010 11:17:10 +0000 (11:17 +0000)]
[Qt] Re-enable the web inspector for maemo6 builds

Rubber-stamped by Tor Arne Vestbø.

Yeah, it's strange :), but they really want it.

* WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix due to unsuccessful merge (b2d63cf)
Ademar de Souza Reis Jr [Wed, 6 Oct 2010 15:11:03 +0000 (17:11 +0200)]
Build fix due to unsuccessful merge (b2d63cf)

The merge on
b2d63cf26fad312ca53ba30506e2ea4e7d448042 was faulty, this is a
trivial fix.

7 years agoUnreviewed build fix.
Simon Hausmann [Tue, 5 Oct 2010 13:27:36 +0000 (13:27 +0000)]
Unreviewed build fix.

[Symbian] Fix build issue due to gaps in ordinals in the def file

Restore previously removed symbols and mark them absent instead. We must
not remove symbols from this file, because it breaks binary compatibility
(when re-assigning the ordinals of the following symbols) or it causes build
breakage when instead having a gap in the ordinal sequence. Instead removing
a symbol is done by marking it as absent.

* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove setDeviceSize methods
Kenneth Rohde Christiansen [Tue, 28 Sep 2010 00:31:09 +0000 (00:31 +0000)]
[Qt] Remove setDeviceSize methods

https://bugs.webkit.org/show_bug.cgi?id=46347

Reviewed by Antonio Gomes.

Remove our setDeviceHeight() API and obtain it automatically from the
system. Also for testing purposes, make it possible to override the
values via two newly introduced environment variables.

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebpage.cpp:
(getintenv):
(queryDeviceSizeForScreenContainingWidget):
(QWebPage::viewportConfigurationForSize):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::windowRect):
* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
commit-queue [Sat, 2 Oct 2010 00:24:10 +0000 (00:24 +0000)]
2010-10-01  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Segmentation fault during zoom out
        https://bugs.webkit.org/show_bug.cgi?id=46984

        * platform/qt/QtMobileWebStyle.cpp:
        (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Andreas Kling [Fri, 1 Oct 2010 13:52:33 +0000 (13:52 +0000)]
2010-10-01  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] New buttons style for Qt Mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=46920

        Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
        Adjust new Qt mobile style for buttons, radios, checks and combos.

        * WebCore.pro:
        * css/themeQtMobile.css: Adjust gradient color for buttons and combos.
        (select):
        (select:active):
        * platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme.
        (QtMobileWebStyle::QtMobileWebStyle):
        (drawRectangularControlBackground):
        (QtMobileWebStyle::drawChecker):
        (QtMobileWebStyle::findChecker):
        (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton.
        (QtMobileWebStyle::findRadio):
        (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox.
        (QtMobileWebStyle::drawMultipleComboButton):
        (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow.
        (QtMobileWebStyle::getButtonImageSize):
        (QtMobileWebStyle::findComboButton):
        (QtMobileWebStyle::drawComplexControl):
        * platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::RenderThemeQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-27 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Diego Gonzalez [Mon, 27 Sep 2010 15:56:51 +0000 (15:56 +0000)]
2010-09-27  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] New input style for Qt Mobile theme
    https://bugs.webkit.org/show_bug.cgi?id=46461

    Rename themeQtMaemo5.css to themeQtMobile.css since it is the theme for all Qt mobile platform.
    Adjust new input style.

    * WebCore.pri:
    * css/themeQtMobile.css: Renamed from css/themeQtMaemo5.css
    (select):
    (select:disabled):
    (select:active):
    (select:active:disabled):
    (textarea):
    (textarea:disabled):
    (textarea:active):
    * platform/qt/RenderThemeQt.cpp:
    (WebCore::RenderThemeQt::extraDefaultStyleSheet): Renamed themeQtMaemo5UserAgentStyleSheet to themeQtMobileUserAgentStyleSheet to match renamed file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] On Maemo platform, web style is missing for some inputs
Diego Gonzalez [Wed, 22 Sep 2010 12:10:25 +0000 (12:10 +0000)]
[Qt] On Maemo platform, web style is missing for some inputs
https://bugs.webkit.org/show_bug.cgi?id=46182

Patch by Ragner Magalhaes <ragner.magalhaes@openbossa.org> on 2010-09-21
Reviewed by Kenneth Rohde Christiansen.

* css/themeQtMaemo5.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix RVCT 2.2 def files on Symbian.
Keith Kyzivat [Tue, 5 Oct 2010 18:18:31 +0000 (20:18 +0200)]
Fix RVCT 2.2 def files on Symbian.
viewportConfigurationForSize incorrect.

Reviewed by: Simon Hausmann

7 years agoMerge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit...
Ademar de Souza Reis Jr [Tue, 5 Oct 2010 15:26:37 +0000 (17:26 +0200)]
Merge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit into qtwebkit-2.1

7 years ago2010-10-04 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 5 Oct 2010 05:43:54 +0000 (05:43 +0000)]
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <input type="radio">
        https://bugs.webkit.org/show_bug.cgi?id=46993

        * fast/events/spatial-navigation/snav-radio-expected.txt: Added.
        * fast/events/spatial-navigation/snav-radio-group-expected.txt: Added.
        * fast/events/spatial-navigation/snav-radio-group.html: Added.
        * fast/events/spatial-navigation/snav-radio.html: Added.
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <input type="radio">
        https://bugs.webkit.org/show_bug.cgi?id=46993

        When using Spatial Navigation, every radio button should be focusable and
        users should be able to navigate from one button to the next without moving the selection.

        Tests: fast/events/spatial-navigation/snav-radio-group.html
               fast/events/spatial-navigation/snav-radio.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable):
        Every radio button should be keyboard focusable, if using Spatial Navigation.
        (WebCore::HTMLInputElement::defaultEventHandler):
        Disable the algorithm for selecting the next radio button within a group, if using Spatial Navigation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQtWebkit API 2.1 cleanup.
Keith Kyzivat [Tue, 5 Oct 2010 15:08:28 +0000 (17:08 +0200)]
QtWebkit API 2.1 cleanup.

Remove InputSpeechButtonGraphic from QWebSettings API created in
bc30b43f024...
It is an incomplete feature on the trunk, and Qt 2.1 doesn't support it.

Reviewed-by: Andreas Kling
7 years ago2010-10-04 Chang Shu <chang.shu@nokia.com>
chang.shu [Tue, 5 Oct 2010 04:03:35 +0000 (04:03 +0000)]
2010-10-04  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key "arrowdown" will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        * fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
        * fast/events/spatial-navigation/snav-1st-stop.html: Added.
2010-10-04  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key "arrowdown" will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        Test: fast/events/spatial-navigation/snav-1st-stop.html

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-04 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 5 Oct 2010 04:28:54 +0000 (04:28 +0000)]
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        * fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-multiple-select.html: Added.
        * fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-single-select.html: Added.
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
        to navigate out of the select element. That is because select element currently uses the
        arrow keys to change the selected element.
        Change the behavior of select element so it does not change selection, if Spatial Navigation
        is on.

        This patch is addressing the case where Spatial Navigation is used
        in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
        In the future we can add support for the case where the flag is off, and
        the user needs to traverse the select element inline.

        Tests: fast/events/spatial-navigation/snav-multiple-select.html
               fast/events/spatial-navigation/snav-single-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69068 268f45cc-cd09-0410-ab3c-d52691b4dbfc