Crash in RenderObjectChildList::destroyLeftOverChildren()
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 6 Sep 2011 16:52:26 +0000 (13:52 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 6 Sep 2011 16:52:26 +0000 (13:52 -0300)
commit8f786a9e023aa21e6a7a17aba7fde33f4ca60a52
tree0d04478301b1a6228618b21965c164c0edce21df
parenta2bd2bb1b19949c6807da38e25bfa7d210bb4b17
Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Author: Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

* fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
* fast/multicol/column-span-parent-continuation-crash.html: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt
LayoutTests/platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt
LayoutTests/ChangeLog
LayoutTests/fast/multicol/column-span-parent-continuation-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/multicol/column-span-parent-continuation-crash.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png
LayoutTests/platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt
LayoutTests/platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png
LayoutTests/platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp