webkit:qtwebkit.git
6 years ago[Qt] Unreviewed build fix for mac.
Alexis Menard [Wed, 27 Jul 2011 14:20:07 +0000 (14:20 +0000)]
[Qt] Unreviewed build fix for mac.

QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.

* DerivedSources.pro:
* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPatch by Julien Chaffraix <jchaffraix@webkit.org> on 2011-07-07
Ademar de Souza Reis Jr [Tue, 2 Aug 2011 18:08:51 +0000 (15:08 -0300)]
Patch by Julien Chaffraix <jchaffraix@webkit.org> on 2011-07-07
Reviewed by David Hyatt.

Partial layout when a flex-box has visibility: collapse
https://bugs.webkit.org/show_bug.cgi?id=63776

Source/WebCore:

Tests: fast/flexbox/crash-button-input-autofocus.html
       fast/flexbox/crash-button-keygen.html
       fast/flexbox/crash-button-relayout.html

The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.

LayoutTests:

Those tests checks some variation of the same underlying issue.

* fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
* fast/flexbox/crash-button-input-autofocus.html: Added.
* fast/flexbox/crash-button-keygen-expected.txt: Added.
* fast/flexbox/crash-button-keygen.html: Added.
* fast/flexbox/crash-button-relayout-expected.txt: Added.
* fast/flexbox/crash-button-relayout.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

6 years ago2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Julien Chaffraix [Thu, 30 Jun 2011 21:51:17 +0000 (21:51 +0000)]
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        * svg/custom/crash-textPath-attributes-expected.txt: Added.
        * svg/custom/crash-textPath-attributes.html: Added.
        * svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        Test: svg/custom/crash-textPath-attributes.html

        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
        to update its positioning information.

        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
        like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).

        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
        our cached layout attributes every time we invalidate them. This avoids keeping stale
        attribute that have a backpointer to a RenderObject.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
John Knottenbelt [Wed, 13 Jul 2011 14:11:14 +0000 (14:11 +0000)]
Reference Geolocation object from GeoNotifier and Geolocation::setIsAllowed.
https://bugs.webkit.org/show_bug.cgi?id=64363

Reviewed by Tony Gentilcore.

Source/WebCore:

Test: fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html

* page/Geolocation.cpp:
(WebCore::Geolocation::setIsAllowed):
* page/Geolocation.h:

LayoutTests:

* fast/dom/Geolocation/remove-remote-context-in-error-callback-crash.html: Added.
* fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html: Added.
* fast/dom/Geolocation/script-tests/remove-remote-context-in-error-callback-crash.js: Added.
* fast/dom/Geolocation/remove-remote-context-in-error-callback-crash-expected.txt: Added.
(gc):
(onIframeReady):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-26 Adam Barth <abarth@webkit.org>
Adam Barth [Mon, 27 Jun 2011 03:43:39 +0000 (03:43 +0000)]
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Kent Tamura.

        m_formElementsWithFormAttribute doesn't ref the objects it holds
        https://bugs.webkit.org/show_bug.cgi?id=62956

        * fast/forms/form-associated-element-crash3-expected.txt: Added.
        * fast/forms/form-associated-element-crash3.html: Added.
2011-06-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Kent Tamura.

        m_formElementsWithFormAttribute doesn't ref the objects it holds
        https://bugs.webkit.org/show_bug.cgi?id=62956

        Test: fast/forms/form-associated-element-crash3.html

        * dom/Document.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-26 David Levin <levin@chromium.org>
David Levin [Fri, 27 May 2011 02:16:21 +0000 (02:16 +0000)]
2011-05-26  David Levin  <levin@chromium.org>

        Reviewed by Dmitry Titov.

        WebKit's font notification has problems when the WebKit main thread != UI thread.
        https://bugs.webkit.org/show_bug.cgi?id=61391

        This doesn't happen in DumpRenderTree, so it needs a unit test which is taking me
        some time to write correctly. In the meantime, this issues happens to be causing
        some crashes in Chrome so here's the fix alone for the time being.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::invalidateFontCache): Ensure that FontCache::invalidate is only called on WebKit's main thread.
        (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Call common function for font cache invalidation.
         Note that the call to fontCache() is fine since the singleton is initialized well before calling this function. Theoretically,
         there could be a problem due to a lack of a memory barrier but that is highly unlikely and this is debug only code.
        (WebCore::fontCacheATSNotificationCallback): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReviewed by Alexey Proskuryakov.
Ademar de Souza Reis Jr [Tue, 2 Aug 2011 17:46:43 +0000 (14:46 -0300)]
Reviewed by Alexey Proskuryakov.

fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60097

The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher.  This patch
uses a CachedResourceHandle to keep the CachedResource alive.

Source/WebCore:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test.  The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::stopLoading):

LayoutTests:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test.  The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.

* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped

6 years ago2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Ilya Tikhonovsky [Thu, 9 Jun 2011 12:42:40 +0000 (12:42 +0000)]
2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
        https://bugs.webkit.org/show_bug.cgi?id=52791

        No new tests. The problem can be reproduced by trying to create InspectorValue
        from 1.0e-100 and call ->toJSONString() on this.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        export 2 functions DecimalNumber::bufferLengthForStringExponential and
        DecimalNumber::toStringExponential.

2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
        https://bugs.webkit.org/show_bug.cgi?id=52791

        No new tests. The problem can be reproduced by trying to create InspectorValue
        from 1.0e-100 and call ->toJSONString() on this.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        export 2 functions DecimalNumber::bufferLengthForStringExponential and
        DecimalNumber::toStringExponential.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][ARM]REGRESSION(r91752): It made audio related tests fail qtwebkit-2.2-week30
Ademar de Souza Reis Jr [Fri, 29 Jul 2011 15:24:00 +0000 (12:24 -0300)]
[Qt][ARM]REGRESSION(r91752): It made audio related tests fail
https://bugs.webkit.org/show_bug.cgi?id=65369

* platform/qt-arm/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt-arm/Skipped

6 years agoUnreviewed build fix for Qt/Linux.
Alexis Menard [Tue, 26 Jul 2011 21:49:03 +0000 (21:49 +0000)]
Unreviewed build fix for Qt/Linux.

On platforms with no glib and gstreamer we should not build javascriptcore
with the Glib support. This is related to http://trac.webkit.org/changeset/91752.

* wtf/wtf.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Disable video support on linux if the dependencies are not found.
Alexis Menard [Tue, 26 Jul 2011 19:14:38 +0000 (19:14 +0000)]
[Qt] Disable video support on linux if the dependencies are not found.

If we can't find the necessary dependencies to build the GStreamer media player
we disable the video support. This is related to http://trac.webkit.org/changeset/91752.

Reviewed by Holger Freyther.

No new tests, it's a build fix.

* features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPatch by Alexis Menard <alexis.menard@openbossa.org> on 2011-07-26
Andras Becsi [Tue, 26 Jul 2011 13:34:26 +0000 (13:34 +0000)]
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-07-26
Reviewed by Andreas Kling.

[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
https://bugs.webkit.org/show_bug.cgi?id=63472

Source/JavaScriptCore:

Enable the bits needed for GStreamer only when QtMultimedia is not used.

* wtf/wtf.pri:

Source/WebCore:

Enable the GStreamer backend and the QuickTime backend as default media players
for the Qt port on Mac and Linux. QtMultimedia is now a fallback option that you
can enable by passing DEFINES+=USE_QT_MULTIMEDIA=1 to enforce its usage.

No new tests. The media layout tests are disabled on the Qt port but hopefully with this
switch we can enable them again.

* WebCore.pri:
* WebCore.pro:
* features.pri:

Source/WebKit/qt:

Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
exist anymore, it's the default. Ditto for GStreamer.

* QtWebKit.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Alexis Menard <alexis.menard@openbossa.org>
Alexis Menard [Thu, 23 Jun 2011 21:42:52 +0000 (21:42 +0000)]
2011-06-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Implement fullscreen support on Mac with the QuickTime backend.
        https://bugs.webkit.org/show_bug.cgi?id=61728

        Implement fullscreen support for Qt when using the QuickTime backend.
        We mostly use what is already done for the Mac port.

        * DerivedSources.pro: We use the mac files and they have <WebCore/x> type
        of includes. We need to generate those headers.
        * WebCore.pro:
        * platform/mac/WebVideoFullscreenController.h:
        * platform/mac/WebVideoFullscreenController.mm:
        * platform/mac/WebVideoFullscreenHUDWindowController.h:
        * platform/mac/WebVideoFullscreenHUDWindowController.mm:
        * platform/qt/WebCoreSystemInterface.h:
        * platform/qt/WebCoreSystemInterface.mm:
2011-06-23  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Implement fullscreen support on Mac with the QuickTime backend.
        https://bugs.webkit.org/show_bug.cgi?id=61728

        Implement fullscreen support for Qt when using the QuickTime backend.
        We mostly use what is already done for the Mac port.

        * QtWebKit.pro:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
        * WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added.
        (QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler):
        (QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler):
        (QTKitFullScreenVideoHandler::enterFullScreen):
        (QTKitFullScreenVideoHandler::exitFullScreen):
        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Fix Mac build in some configurations.
Alexey Proskuryakov [Tue, 21 Jun 2011 22:35:00 +0000 (22:35 +0000)]
    Fix Mac build in some configurations.

        * platform/mac/WebCoreSystemInterface.h: Added an enum matching WKSI one, since we cannot use
        WKSI in WebCore.

        * platform/mac/WebVideoFullscreenHUDWindowController.mm: Removed an include of WebKitSystemInterface.h.
        It's not meant to be used from WebCore, and if included, a wrong copy may be used.
        (createControlWithMediaUIControlType): Added a FIXME about problems with Leopard build.
        (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Ditto. Switched enum values to
        WCSI style (lower level "wk").

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix; Fix Leopard WebCore build.
Jer Noble [Mon, 20 Jun 2011 22:21:48 +0000 (22:21 +0000)]
Unreviewed build fix; Fix Leopard WebCore build.

* platform/mac/WebVideoFullscreenHUDWindowController.mm: On Leopard, NSWindowDelegate
    is a category, not a protocol.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix; Fix 32-bit build.
Jer Noble [Mon, 20 Jun 2011 21:56:15 +0000 (21:56 +0000)]
Unreviewed build fix; Fix 32-bit build.

Code recently moved from WebKit -> WebCore does not pass WebCore's more strict compiler warnings.  Use
CGFloat, and float constants wherever possible, and use narrowPrecisionToFloat() where not.

* WebCore.xcodeproj/project.pbxproj: Add '-Wno-undef' flag for WebVideoFullScreenController.mm
* platform/mac/WebVideoFullscreenController.mm:
(constrainFrameToRatioOfFrame): Use CGFloat instead of Double.
(-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]): Use float constant.
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController updateVolume]): Use float for volume.
(-[WebVideoFullscreenHUDWindowController maxVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController volumeChanged:]): Ditto.
(-[WebVideoFullscreenHUDWindowController decrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController incrementVolume]): Ditto.
(-[WebVideoFullscreenHUDWindowController volume]): Ditto.
(-[WebVideoFullscreenHUDWindowController setVolume:]): Ditto.
(timeToString): Narrow precision to float when converting to seconds.
* platform/mac/WebWindowAnimation.mm:
(scaledRect): Use CGFloat.
(-[WebWindowScaleAnimation init]): Use float constant.
(-[WebWindowScaleAnimation currentValue]): Ditto.
(-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]): Ditto.
(-[WebWindowFadeAnimation currentAlpha]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-01 Jer Noble <jer.noble@apple.com>
Jer Noble [Mon, 20 Jun 2011 19:29:39 +0000 (19:29 +0000)]
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Move Full Screen Controllers into WebCore.

        Remove dependency on QTKit from wekitExitFullscreen()
        https://bugs.webkit.org/show_bug.cgi?id=61843

        No new tests; the existing media full screen tests are sufficient.

        * WebCore.exp.in: Add new exports.
        * WebCore.xcodeproj/project.pbxproj: Add references to moved files.
        * platform/mac/WebCoreSystemInterface.h: Add new WCSI interfaces to WKSI functions.
        * platform/mac/WebCoreSystemInterface.mm:
        * platform/mac/WebVideoFullscreenController.h: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenController.h.
        * platform/mac/WebVideoFullscreenController.mm: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenController.mm.

        The following functions have had UNUSED_PARAM added:
        (-[WebVideoFullscreenController applicationDidResignActive:]):
        (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
        (-[WebVideoFullscreenWindow mouseMoved:]):

Source/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.h.
        * platform/mac/WebVideoFullscreenHUDWindowController.mm: Renamed from Source/WebKit/mac/WebView/WebVideoFullscreenHUDWindowController.mm.

        The following functions have had UNUSED_PARAM added:
        (-[WebVideoFullscreenHUDWindow cancelOperation:]):
        (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
        (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
        (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
        (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
        (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
        (-[WebVideoFullscreenHUDWindowController mouseExited:]):
        (-[WebVideoFullscreenHUDWindowController rewind:]):
        (-[WebVideoFullscreenHUDWindowController fastForward:]):
        (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
        (-[WebVideoFullscreenHUDWindowController windowDidClose:]):

        The following functions have had WKSI calls converted to WCSI ones:
        (createControlWithMediaUIControlType):
        (createTimeTextField):

        * platform/mac/WebWindowAnimation.h: Renamed from Source/WebKit/mac/WebView/WebWindowAnimation.h.
        * platform/mac/WebWindowAnimation.mm: Renamed from Source/WebKit/mac/WebView/WebWindowAnimation.m.
        (WebWindowAnimationDurationFromDuration):

        The following functions have had WKSI calls converted to WCSI ones:
        (-[WebWindowScaleAnimation setCurrentProgress:]):
        (-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Move Full Screen Controllers into WebCore.

        Remove dependency on QTKit from wekitExitFullscreen()
        https://bugs.webkit.org/show_bug.cgi?id=61843

        WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
        have been moved into WebCore.

        * WebKit.xcodeproj/project.pbxproj:
2011-06-01  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Move Full Screen Controllers into WebCore.

        Remove dependency on QTKit from wekitExitFullscreen()
        https://bugs.webkit.org/show_bug.cgi?id=61843

        WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
        have been moved into WebCore.

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
        * WebView/WebFullScreenController.mm: Remove unused #include.
        * WebView/WebView.mm: Change the include location of
            WebVideoFullscreenController.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] QtWebkit never finishes loading sites when they are loaded after an initial...
Caio Marcelo de Oliveira Filho [Wed, 27 Jul 2011 17:40:57 +0000 (17:40 +0000)]
[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
https://bugs.webkit.org/show_bug.cgi?id=61328

Reviewed by Andreas Kling.

Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
emitting signals in the progress notification functions, we use the
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
that loading code is prepared to handle load() when inside those functions.

The crash was being caused by setUrl() (and load()) being called when
loadFinished(false) was emitted. The problem here is that when
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
call again, because it was still the ProvisionalLoadState but with the
provisionalDocumentLoader already removed.

To emulate the same behavior that QtWebKit had when using
postProgressFinishedNotification, we now keep track of the frame originating the
load, and emit the signals when this frame's client is called.

The patch keeps the existing semantics for QWebPage signals, but we now emit the
QWebFrame signals everytime, not only when they are the originating frame for
loading.

* Api/qwebframe.cpp:
(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.

* WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep
track whether the frame is originating the load. Remove the signals from
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.

(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
signals to our signals for load/finished, signal emission will be done manually.

(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
loadStarted() signal and make the first notification of estimation change, that
Qt API tests expect to exist and notify 10%.

(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
m_loadError and emit loadFinished() signal.

(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
emission and mark the originating load as true, since only the originating frame
gets this call in its client.

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
emission.

(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
was successful or not. This wasn't necessary before because a successful call for
error page would lead to a load(), that cleared the m_loadError.
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
to m_loadError and emit finished signal indicating error if ErrorPage extension
doesn't handle it.
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.

(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
for the QWebFrame, and if the originating load also do for the QWebPage.

(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
loadFinished(). Take care to reset the originating load flag before the signals
are emitted, since they might want to set it back again.

* tests/qwebframe/tst_qwebframe.cpp:
(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
when a certain signal is emitted in the frame.

(URLSetter::execute):
(tst_QWebFrame::loadInSignalHandlers_data):
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
crashes without this patch applied.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Add more tests to cover the behavior of loadFinished() signal
Caio Marcelo de Oliveira Filho [Mon, 25 Jul 2011 15:51:16 +0000 (15:51 +0000)]
[Qt] Add more tests to cover the behavior of loadFinished() signal
https://bugs.webkit.org/show_bug.cgi?id=63490

Reviewed by Benjamin Poulain.

* tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply):
(FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.

(tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
after a 404 error without contents.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
is true when we use error page extension to produce our own error pages.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCalling window.find immediately after mutating the document crashes WebKit.
Ryosuke Niwa [Thu, 28 Jul 2011 05:24:41 +0000 (05:24 +0000)]
Calling window.find immediately after mutating the document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=65296

Reviewed by Darin Adler.

Source/WebCore:

Don't forget to layout first.

Test: editing/text-iterator/find-after-mutation.html

* editing/TextIterator.cpp:
(WebCore::findPlainText):

LayoutTests:

Added a test to ensure WebKit doesn't crash when searching for string after mutating the document.

* editing/text-iterator/find-after-mutation-expected.txt: Added.
* editing/text-iterator/find-after-mutation.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Inconsistent state of TreeScope reference.
MORITA Hajime [Thu, 28 Jul 2011 03:44:57 +0000 (03:44 +0000)]
Source/WebCore: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

The tree scope pointers on shadow tree nodes didn't cleared.
even when the tree scope (shadow root) is destroyed.
This change clear these poitners before detaching the shadow root.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/tree-scope-crash.html

* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):

LayoutTests: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/tree-scope-crash-expected.txt: Added.
* fast/dom/shadow/tree-scope-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-22 Dominic Cooney <dominicc@chromium.org>
Dominic Cooney [Sun, 22 May 2011 15:56:02 +0000 (15:56 +0000)]
2011-05-22  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        When removing a shadow root, also remove it from the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=61245

        * platform/mac/Skipped: Unskip shadow tests.
2011-05-22  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        When removing a shadow root, also remove it from the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=61245

        Test: existing fast/dom/shadow/layout-tests-can-access-shadow.html

        * dom/Element.cpp:
        (WebCore::Element::removeShadowRoot): Call detach if attached.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPerform the JavaScript navigation check on a complete URL
Ademar de Souza Reis Jr [Fri, 29 Jul 2011 14:40:54 +0000 (11:40 -0300)]
Perform the JavaScript navigation check on a complete URL
https://bugs.webkit.org/show_bug.cgi?id=65038

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-07-22
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-document-baseURI-javascript.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

LayoutTests:

* http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt: Added.
* http/tests/security/xss-DENIED-document-baseURI-javascript.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/page/DOMWindow.cpp

6 years agoFix crash in IDBRequest::abort
commit-queue [Fri, 22 Jul 2011 17:07:15 +0000 (17:07 +0000)]
Fix crash in IDBRequest::abort
https://bugs.webkit.org/show_bug.cgi?id=64740

Patch by David Grogan <dgrogan@chromium.org> on 2011-07-22
Reviewed by Nate Chapin.

Tested manually with the testcase in the bug.

* storage/IDBRequest.cpp:
(WebCore::IDBRequest::~IDBRequest):
(WebCore::IDBRequest::abort):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r85964): Improper relayout of some nested positioned elements
Daniel Bates [Mon, 25 Jul 2011 18:55:58 +0000 (18:55 +0000)]
REGRESSION (r85964): Improper relayout of some nested positioned elements
https://bugs.webkit.org/show_bug.cgi?id=64286

Reviewed by David Hyatt.

Source/WebCore:

Fixes an issue when traversing up the containing block hierarchy after skipping
relatively positioned inlines.

When processing a positioned element we skip any intermediate inlines to get to
to enclosing block B, but don't use the containing block for B (call this P_B) to
properly continue traversing up the containing block hierarchy. So, B may be
considered again instead of looking at P_B. Hence, we don't set the correct dirty
bits for P_B and may not schedule a relayout with respect to the correct layout node.

Test: fast/block/positioning/relayout-nested-positioned-elements-crash.html

* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Add test case to ensure we don't regress relayout of nested positioned elements.

* fast/block/positioning/relayout-nested-positioned-elements-expected-crash.txt: Added.
* fast/block/positioning/relayout-nested-positioned-elements-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=60778
David Hyatt [Tue, 26 Jul 2011 20:39:25 +0000 (20:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60778

Use after free because of line box culling optimization regression.

In the case of a child with no line box being removed (typically
a <br> in quirks mode), if there is no previous sibling with a line
box, then we have a potential problem with the culling optimization.

The culled inline may still have other leaf line box children, but
they may follow the removed <br>. In this case we can't rely on
them, since we need a line box that comes before the <br>.

The fix is to simply recur up to the parent if we are a culled inline
and could not find a previous line box.

Reviewed by Dan Bernstein.

Added editing/execCommand/crash-line-break-after-outdent.html

Source/WebCore:

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

LayoutTests:

* editing/execCommand/crash-line-break-after-outdent-expected.txt: Added.
* editing/execCommand/crash-line-break-after-outdent.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable test that is timing out in our 2.2 bots
Ademar de Souza Reis Jr [Tue, 26 Jul 2011 20:58:28 +0000 (17:58 -0300)]
Disable test that is timing out in our 2.2 bots

plugins/mouse-click-plugin-clears-selection.html is timing out on 2.2
bots (qt-4.7 and qt-4.8), but it passes on trunk and in our test
environments. No time to investigate it more.

6 years agoSource/WebCore: Crash when removing unrenderered nodes in replacement fragment. qtwebkit-2.2-week29
Abhishek Arya [Tue, 19 Jul 2011 17:39:03 +0000 (17:39 +0000)]
Source/WebCore: Crash when removing unrenderered nodes in replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes):

LayoutTests: Tests that we do not crash when removing unrendering nodes
in a replacement fragment.
https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

* editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
* editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build breakage introduced by a previous cherry-pick
Ademar de Souza Reis Jr [Fri, 22 Jul 2011 15:23:47 +0000 (12:23 -0300)]
Fix build breakage introduced by a previous cherry-pick

isDeprecatedFlexibleBox() is a new name on trunk for isFlexibleBox(). It
was renamed (refactoring only) in r90773 (bad4cd2).

cherry-pick that broke the build is:

    Stale pointer due to floats not removed (flexible box display)
    https://bugs.webkit.org/show_bug.cgi?id=64603

6 years agoExtend the protector of a CSS style sheet. Because checkLoaded() can recursively...
gavinp [Thu, 21 Jul 2011 23:53:30 +0000 (23:53 +0000)]
Extend the protector of a CSS style sheet.  Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.

https://bugs.webkit.org/show_bug.cgi?id=64736

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/css-imports-2.html

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::checkLoaded):

LayoutTests:

* fast/css/css-imports-2-expected.txt: Added.
* fast/css/css-imports-2.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStale pointer due to floats not removed (flexible box display)
Tony Chang [Wed, 20 Jul 2011 19:01:55 +0000 (19:01 +0000)]
Stale pointer due to floats not removed (flexible box display)
https://bugs.webkit.org/show_bug.cgi?id=64603

Reviewed by David Hyatt.

Source/WebCore:

Flexbox items should avoid floats.

Test: fast/flexbox/horizontal-box-float-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::avoidsFloats):
* rendering/RenderBox.h:
(WebCore::RenderBox::isDeprecatedFlexItem):

LayoutTests:

* fast/flexbox/horizontal-box-float-crash-expected.txt: Added.
* fast/flexbox/horizontal-box-float-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix compiling errors with QtWebkit 2.2 WINSCW build.
Ademar de Souza Reis Jr [Wed, 20 Jul 2011 16:48:24 +0000 (13:48 -0300)]
[Qt] Fix compiling errors with QtWebkit 2.2 WINSCW build.
https://bugs.webkit.org/show_bug.cgi?id=64391

Patch by Hui Huang  <Hui.2.Huang@nokia.com>
Reviewed by Laszlo Gombos.

This is a QtWebKit-2.2 only patch, it's too intrusive
to be accepted on trunk.

If something breaks in one of the 2.2 buildbots with
this commit it'll be reverted.

* parser/JSParser.cpp:
* runtime/JSONObject.cpp:
* wtf/PageAllocatorSymbian.h:
* wtf/Platform.h:
* wtf/text/AtomicString.h:
* wtf/text/StringStatics.cpp:
* bindings/generic/ActiveDOMCallback.cpp:
* css/CSSStyleSelector.h:
* page/PrintContext.cpp:
* page/PrintContext.h:
* platform/network/HTTPHeaderMap.cpp:
* xml/XPathFunctions.cpp:
* xml/XPathPredicate.cpp:
* xml/XPathResult.cpp:
* symbian/bwins/QtWebKitu.def:

6 years ago[Qt] Improve documentation of QWebView::setPage()
Caio Marcelo de Oliveira Filho [Wed, 20 Jul 2011 05:31:12 +0000 (05:31 +0000)]
[Qt] Improve documentation of QWebView::setPage()
https://bugs.webkit.org/show_bug.cgi?id=64827

Reviewed by Noam Rosenthal.

* Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDOMWindow::open performs a security check on a wrong window qtwebkit-2.2-week28
commit-queue [Sat, 16 Jul 2011 20:12:51 +0000 (20:12 +0000)]
DOMWindow::open performs a security check on a wrong window
https://bugs.webkit.org/show_bug.cgi?id=64651

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-07-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-window-open-parent.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):

LayoutTests:

* http/tests/security/resources/xss-DENIED-window-open-parent-attacker.html: Added.
* http/tests/security/xss-DENIED-window-open-parent-expected.txt: Added.
* http/tests/security/xss-DENIED-window-open-parent.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe beforeload event allows tracking URI changes in a frame
Adam Barth [Fri, 15 Jul 2011 02:16:09 +0000 (02:16 +0000)]
The beforeload event allows tracking URI changes in a frame
https://bugs.webkit.org/show_bug.cgi?id=64482

Reviewed by Nate Chapin.

Source/WebCore:

Tests: http/tests/security/beforeload-iframe-client-redirect.html
       http/tests/security/beforeload-iframe-server-redirect.html

Only dispatch the beforeload event for a frame if we haven't yet
committed our first real load.  The URL that we send to our parent will
be the same URL the parent seens in the src attribute.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests:

Test whether the beforeload event is fired for various kinds of redirects.

* http/tests/security/beforeload-iframe-client-redirect-expected.txt: Added.
* http/tests/security/beforeload-iframe-client-redirect.html: Added.
* http/tests/security/beforeload-iframe-server-redirect-expected.txt: Added.
* http/tests/security/beforeload-iframe-server-redirect.html: Added.
* http/tests/security/resources/post-done.html: Added.
* http/tests/security/resources/client-redir.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClear SVGElementInstance's children immediately upon detachment
commit-queue [Thu, 14 Jul 2011 16:57:44 +0000 (16:57 +0000)]
Clear SVGElementInstance's children immediately upon detachment
https://bugs.webkit.org/show_bug.cgi?id=63739
<rdar://problem/9705708>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-14
Reviewed by Nikolas Zimmermann.

In addition to clearing the instance's children in the destructor,
clear them when the instance is detached from its <use>. This way,
we won't attempt to use them after we're detached but before the
destructor has been called.

Source/WebCore:

Test: svg/custom/use-crash-using-children-before-destroy.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):
* svg/SVGElementInstance.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance):

LayoutTests:

* svg/custom/use-crash-using-children-before-destroy-expected.txt: Added.
* svg/custom/use-crash-using-children-before-destroy.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-30 Leandro Pereira <leandro@profusion.mobi>
commit-queue [Thu, 30 Jun 2011 07:42:09 +0000 (07:42 +0000)]
2011-06-30  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Simon Hausmann.

        generate-webkitversion.pl should not "use Switch"
        https://bugs.webkit.org/show_bug.cgi?id=63628

        Switch got deprecated on recent Perl versions and the script wasn't
        using the switch statement.

        * scripts/generate-webkitversion.pl: Remove "use Switch;" line.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-20 Andras Becsi <abecsi@webkit.org>
Andras Becsi [Mon, 20 Jun 2011 18:51:12 +0000 (18:51 +0000)]
2011-06-20  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        make-hash-tools.pl: Perl 5.14 compatibility
        https://bugs.webkit.org/show_bug.cgi?id=61890

        No new tests needed.

        * make-hash-tools.pl: Use if/elsif instead of switch/case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert "Build fix on Linux when using the GStreamer backend"
Ademar de Souza Reis Jr [Fri, 15 Jul 2011 14:38:53 +0000 (11:38 -0300)]
Revert "Build fix on Linux when using the GStreamer backend"

This reverts commit 1755be48f4fff45afff06c4073d5a2656665a44f.

This commit should not have been cherry-picked, as the changes that
introduced the breakage are not in the branch.

6 years agoSource/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
Abhishek Arya [Wed, 13 Jul 2011 18:51:44 +0000 (18:51 +0000)]
Source/WebCore: Patch by Abhishek Arya <inferno@chromium.org> on 2011-07-13
Reviewed by Adam Barth.

Issue with Frame lifetime due to deletion in beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Copy the Frame protector higher in the stack from loadWithDocumentLoader
to loadFrameRequest since any of loadPostRequest or loadURL can call
loadWithDocumentLoader, thereby dispatching the beforeload event and
blowing away the frame. This deleted frame will be later accessed in
the loadFrameRequest function causing a crash.

Test: fast/events/form-iframe-target-before-load-crash2.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests: Tests that we do not crash when frame is blown away in a beforeload
event.
https://bugs.webkit.org/show_bug.cgi?id=64457

Reviewed by Adam Barth.

* fast/events/form-iframe-target-before-load-crash.html:
* fast/events/form-iframe-target-before-load-crash2-expected.txt: Added.
* fast/events/form-iframe-target-before-load-crash2.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-16 Robert Hogan <robert@webkit.org>
Ademar de Souza Reis Jr [Wed, 13 Jul 2011 21:56:32 +0000 (18:56 -0300)]
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        https://bugs.webkit.org/show_bug.cgi?id=54051

       * platform/qt/Skipped: Unskip plugins/invalidate_rect.html
       * platform/qt-mac/Skipped: Skip plugins/invalidate_rect.html
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        Add ChromeClientQt::allowsAcceleratedCompositing().

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowsAcceleratedCompositing):
        * WebCoreSupport/ChromeClientQt.h:
2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        plugins/invalidate_rect.html fails on linux ports

        - Make the unix test netscape plugin recognize the onPaintEvent
          and windowedPlugin parameters.

        https://bugs.webkit.org/show_bug.cgi?id=54051

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventX11):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::displayInvalidatedRegion):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):
        (webkit_test_plugin_handle_event):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt-mac/Skipped

6 years ago2011-07-03 Robert Hogan <robert@webkit.org>
Robert Hogan [Sun, 3 Jul 2011 15:51:21 +0000 (15:51 +0000)]
2011-07-03  Robert Hogan  <robert@webkit.org>

        Add platform-specific results after r90338

        Unreviewed, add platform-specific results for new rendertree test.
        https://bugs.webkit.org/show_bug.cgi?id=30355

        http://trac.webkit.org/changeset/90338

        * platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * plugins/mouse-click-plugin-clears-selection-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReviewed by Andreas Kling.
Ademar de Souza Reis Jr [Wed, 13 Jul 2011 16:47:22 +0000 (13:47 -0300)]
Reviewed by Andreas Kling.

Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717

QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.

Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)

* wtf/DateMath.cpp: fix usage of abs/labs
* wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
* wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/JavaScriptCore/wtf/DateMath.cpp

6 years ago2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Fri, 3 Jun 2011 13:47:02 +0000 (13:47 +0000)]
2011-06-03  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Frame flattening is broken with nested frames
        https://bugs.webkit.org/show_bug.cgi?id=61491

        * fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
        * fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
2011-06-03  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Frame flattening is broken with nested frames
        https://bugs.webkit.org/show_bug.cgi?id=61491

        Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.

        Test: fast/frames/flattening/iframe-flattening-out-of-view.html
              fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
              fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html

        * rendering/RenderIFrame.cpp:
        (WebCore::RenderIFrame::flattenFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Robert Hogan <robert@webkit.org>
Robert Hogan [Sun, 3 Jul 2011 15:04:28 +0000 (15:04 +0000)]
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        Unfortunately this has to be a rendertree test, as there is no rendertext way of
        determining if a selection is still highlighted.

        * platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
        * plugins/mouse-click-plugin-clears-selection.html: Added.
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        Test: plugins/mouse-click-plugin-clears-selection.html

        PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
        in order to clear the FrameSelection in the currently focused node. In its platform-specific
        code Chromium already does this (WebPluginContainerImpl.cpp).

        * WebCore.exp.in: Add symbol for FocusController::setFocusedNode
        * plugins/PluginView.cpp:
        (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
                                                   the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
                                                   redundant, since it calls both.
2011-06-23  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
        https://bugs.webkit.org/show_bug.cgi?id=30355

        PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
        in order to clear the FrameSelection in the currently focused node. In its platform-specific
        code Chromium already does this (WebPluginContainerImpl.cpp).

        * WebProcess/Plugins/PluginView.cpp:
        (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
                                                   the call to FocusController:setFocusedFrame() redundant, since the
                                                   former calls it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix unaligned userspace access for SH4 platforms. qtwebkit-2.2-week27
Patrick Gansterer [Sat, 9 Jul 2011 20:43:09 +0000 (20:43 +0000)]
Fix unaligned userspace access for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=62993

Patch by Thouraya Andolsi <thouraya.andolsi@st.com> on 2011-07-09

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue [Tue, 5 Jul 2011 19:45:00 +0000 (19:45 +0000)]
2011-07-05  Rafael Brandao  <rafael.lobo@openbossa.org>

        [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
        https://bugs.webkit.org/show_bug.cgi?id=63235

        Modified baseUrl to be a local file in order to get a security origin
        that is allowed to request local resources. Removed QSignalSpy from it
        as loadFinished always happens, and the original test was split into two.

        Reviewed by Benjamin Poulain.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setHtmlWithImageResource):
        (tst_QWebFrame::setHtmlWithStylesheetResource):
        (tst_QWebFrame::setHtmlWithBaseURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-07-01 Jade Han <jade.han@nokia.com> qtwebkit-2.2-week26
commit-queue@webkit.org [Fri, 1 Jul 2011 21:09:03 +0000 (21:09 +0000)]
2011-07-01  Jade Han  <jade.han@nokia.com>

        [Qt][Symbian] Update .def file for Symbian to build Tools
        https://bugs.webkit.org/show_bug.cgi?id=61200

        Reviewed by Laszlo Gombos.

        Add newly introduced symbols to fix building the Tools directory for Symbian.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip test introduced in r90068 that fails on qtwebkit-2.2
Ademar de Souza Reis Jr [Fri, 1 Jul 2011 20:58:49 +0000 (17:58 -0300)]
Skip test introduced in r90068 that fails on qtwebkit-2.2

Works fine on trunk, we're probably missing something on the branch.

Skipping test to keep the bots green, under investigation.

6 years ago2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Julien Chaffraix [Thu, 30 Jun 2011 20:50:16 +0000 (20:50 +0000)]
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
        https://bugs.webkit.org/show_bug.cgi?id=63076

        * svg/custom/crash-text-in-textpath-expected.txt: Added.
        * svg/custom/crash-text-in-textpath.svg: Added.
        Original crashing test case.

        * svg/custom/text-node-in-text-invalidated-expected.txt: Added.
        * svg/custom/text-node-in-text-invalidated.svg: Added.
        This test case was not crashing. However it is good to make sure this change
        did not regress that.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
        https://bugs.webkit.org/show_bug.cgi?id=63076

        Tests: svg/custom/crash-text-in-textpath.svg
               svg/custom/text-node-in-text-invalidated.svg

        The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
        doing our layout, we would not update the attributes on our SVGRenderInlineText as
        we would not lay it out.

        This was caused by childrenChanged being overridden on SVGTextPositioningElement but
        not on SVGTextPathElement.

        As both classes shared the same mother class, it made sense to move the logic here.
        There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
        are the only classes deriving from SVGTextContentElement.

        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
        * svg/SVGTextContentElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
        removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
        * svg/SVGTextPositioningElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue [Thu, 30 Jun 2011 23:30:18 +0000 (23:30 +0000)]
2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Fix tst_QWebFrame::renderGeometry() API test
        https://bugs.webkit.org/show_bug.cgi?id=63236

        This test required a security origin with granted permission to request local resources.
        By default, only local files can load local resources. So modified baseUrl to be a local file.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::renderGeometry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-07-01 Jade Han <jade.han@nokia.com>
commit-queue [Fri, 1 Jul 2011 14:29:12 +0000 (14:29 +0000)]
2011-07-01  Jade Han  <jade.han@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Update .def file for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=61200

        Add newly introduced symbols to fix the Symbian build.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>
commit-queue [Thu, 30 Jun 2011 13:59:41 +0000 (13:59 +0000)]
2011-06-30  Fabrizio Machado  <fabrizio.machado@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] QML Webview causes performance drops
        https://bugs.webkit.org/show_bug.cgi?id=57554

        Remove tiledBackingStoreEnabled from QML WebView.

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::setPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-30 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 30 Jun 2011 17:00:48 +0000 (17:00 +0000)]
2011-06-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Ryosuke Niwa.

        Crash when calling DOMSubtreeModified event when extracting range
        contents.
        https://bugs.webkit.org/show_bug.cgi?id=63650

        Convert a few nodes to RefPtrs and add commonRoot verification checks
        for Range::processContents.

        Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
               fast/dom/Range/range-extract-contents-event-fire-crash2.html

        * dom/Range.cpp:
        (WebCore::childOfCommonRootBeforeOffset):
        (WebCore::Range::processContents):
        (WebCore::Range::processContentsBetweenOffsets):
        (WebCore::Range::processAncestorsAndTheirSiblings):
2011-06-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Ryosuke Niwa.

        Crash when calling DOMSubtreeModified event when extracting range
        contents.
        https://bugs.webkit.org/show_bug.cgi?id=63650

        * fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt: Added.
        * fast/dom/Range/range-extract-contents-event-fire-crash.html: Added.
        * fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt: Added.
        * fast/dom/Range/range-extract-contents-event-fire-crash2.html: Added.
        * fast/dom/Range/range-extractContents.html: remove the appending of fragment
        in this crasher test since we now refptr the nodes and leftContents will be visible.
        This crasher test does not need to show the extractContents fragment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Abhishek Arya <inferno@chromium.org>
Ademar de Souza Reis Jr [Thu, 30 Jun 2011 17:49:47 +0000 (14:49 -0300)]
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        In RenderBlock, RenderWidget and RenderReplaced destroy functions,
        call dirtyLinesFromChangedChild to tell our parent that we are going away.
        https://bugs.webkit.org/show_bug.cgi?id=60307

        Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html
              fast/block/block-not-removed-from-parent-lineboxes-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::destroy):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::destroy):
        * rendering/RenderReplaced.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Tests that we do not crash when failing to remove the linebreak
        object(widget, block, replaced, etc) from parent block lineboxes. The
        testcase tries to fuzz over the list of html and svg tags.
        https://bugs.webkit.org/show_bug.cgi?id=60307

        * fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
        * fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added.
        * fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
        * fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/rendering/RenderReplaced.h

6 years ago<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds...
David Hyatt [Thu, 5 May 2011 20:04:01 +0000 (20:04 +0000)]
<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Darin Adler.

Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).

Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 29 Jun 2011 19:18:02 +0000 (19:18 +0000)]
2011-06-29  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Add Qt dependencies in QtWebKit's main pro file.
        https://bugs.webkit.org/show_bug.cgi?id=63639

        syncqt, the script which generates the headers inside Qt parses
        the main pro file of QtWebKit to check the Qt dependencies. It used
        to be WebCore.pro but after the build reorganization QtWebKit.pro is
        the new main pro file so we need to add the network dependency just like
        we did in WebCore.pro.

        * QtWebKit.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
Ademar de Souza Reis Jr [Wed, 29 Jun 2011 17:43:26 +0000 (14:43 -0300)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Test that a generated block child + counter within a <ruby> doesn't crash.
        (Test as provided by original reporter).

        * fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-counter-doesnt-crash.html: Added.
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Don't set style type BEFORE/AFTER on anonymous wrapper block.
        Rather, check style type on generated wrapped child.

        Tests: fast/ruby/generated-after-counter-doesnt-crash.html
               fast/ruby/generated-before-and-after-counter-doesnt-crash.html
               fast/ruby/generated-before-counter-doesnt-crash.html

        * rendering/RenderRuby.cpp:
        (WebCore::isAnonymousRubyInlineBlock):
        (WebCore::isRubyBeforeBlock):
        (WebCore::isRubyAfterBlock):
        (WebCore::rubyBeforeBlock):
        (WebCore::rubyAfterBlock):
        (WebCore::createAnonymousRubyInlineBlock):
        (WebCore::RenderRubyAsInline::addChild):
        (WebCore::RenderRubyAsBlock::addChild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

Source/WebCore/rendering/RenderRuby.cpp

6 years ago2011-05-23 Matthew Delaney <mdelaney@apple.com>
Matt Delaney [Mon, 23 May 2011 22:33:39 +0000 (22:33 +0000)]
2011-05-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
        https://bugs.webkit.org/show_bug.cgi?id=58216

        * wtf/MathExtras.h:
        (clampToInteger):
        (clampToPositiveInteger):
2011-05-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
        https://bugs.webkit.org/show_bug.cgi?id=58216

        No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.

        * platform/graphics/FloatRect.cpp:
        (WebCore::enclosingIntRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
Csaba Osztrogonác [Thu, 23 Jun 2011 12:48:37 +0000 (12:48 +0000)]
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237

* tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix tst_QWebPage::showModalDialog() API test
Csaba Osztrogonác [Thu, 23 Jun 2011 12:45:34 +0000 (12:45 +0000)]
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245

* tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
Alexis Menard [Tue, 28 Jun 2011 21:13:25 +0000 (21:13 +0000)]
2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
        https://bugs.webkit.org/show_bug.cgi?id=63562

        Some Qt auto-tests rely on <QtX/x.h> types of includes.

        * Api/qwebkitplatformplugin.h:
        * symbian/platformplugin/qwebkitplatformplugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Joe Wild <joseph.wild@nokia.com>
commit-queue [Mon, 27 Jun 2011 23:26:18 +0000 (23:26 +0000)]
2011-06-27  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Simon Fraser.

        Crash on www.crave.cnet.com in FrameView::windowClipRect()
        https://bugs.webkit.org/show_bug.cgi?id=56393

        Tests that a plugin of a swf file in a hidden iframe will not
        crash. This test required more than 1 content file and a
        timeout or else it would not repeat the error condition.

        This test will only crash on platforms (like Symbian) that
        don't allow nonvirtual functions to have a null this pointer.

        * plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
        * plugins/hidden-iframe-with-swf-plugin.html: Added.
        * plugins/resources/iframe-content-with-swf-plugin.html: Added.
2011-06-27  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Simon Fraser.

        Crash on www.crave.cnet.com in FrameView::windowClipRect()
        https://bugs.webkit.org/show_bug.cgi?id=56393

        Check for a null renderer to fix a crash. This situation can
        arise when external content/plugins is referenced from html
        elements with style="display:none".

        Test: plugins/hidden-iframe-with-swf-plugin.html

        * page/FrameView.cpp:
        (WebCore::FrameView::windowClipRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
Alexis Menard [Tue, 28 Jun 2011 14:22:44 +0000 (14:22 +0000)]
2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
        https://bugs.webkit.org/show_bug.cgi?id=63533

        We need to use the new QtQuick 1.x imports rather than the old deprecated
        version.

        * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
        * tests/qdeclarativewebview/resources/webviewtest.qml:
        * tests/qdeclarativewebview/resources/webviewtestdefault.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-15 Jer Noble <jer.noble@apple.com> qtwebkit-2.2-beta1 qtwebkit-2.2-week25
Jer Noble [Wed, 15 Jun 2011 16:51:31 +0000 (16:51 +0000)]
2011-06-15  Jer Noble  <jer.noble@apple.com>

        Reviewed by Timothy Hatcher.

        Full-screen live streams have status text in wrong location
        https://bugs.webkit.org/show_bug.cgi?id=62733

        Fix a misspelling in the user-agent stylesheet for full-screen mode.

        * css/fullscreenQuickTime.css:
        (video:-webkit-full-screen::-webkit-media-controls-status-display):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Caio Marcelo de Oliveira Filho [Mon, 27 Jun 2011 17:18:24 +0000 (17:18 +0000)]
2011-06-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::overloadedSlots() fails
        https://bugs.webkit.org/show_bug.cgi?id=37319

        This patch is based on Noam Rosenthal original patch in the same bug.

        When hinted with QWebElement metatype, we qualify the conversion
        from JSElement as a "perfect match".

        The test was failing because the wrong slot was called, since the QWebElement
        match was taken as equal to the others and not chosen when the metacall happened.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement
        to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason
        why we have the implicit conversion.
2011-06-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::overloadedSlots() fails
        https://bugs.webkit.org/show_bug.cgi?id=37319

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::overloadedSlots): Remove expected failure and
        fix the comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Mon, 27 Jun 2011 17:48:45 +0000 (17:48 +0000)]
2011-06-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Fix removal of overhanging floats on style changes to absolute/fixed position.
        https://bugs.webkit.org/show_bug.cgi?id=63355

        1. If we are not currently positioned.
        2. And we are not floating. (If we are floating, then this will be automatically
           done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
        3. And we have overhanging floats from previous sibling blocks.
        4. And our new new style tells that we will have absolute or fixed position.

        Then, we mark all our descendants with floats for layout. This will make sure that
        overhanging floats are removed. Also, it is important to do that since if that previous
        sibling block goes away, it is not able to tell us that to remove those floats thinking
        that being a positioned block, we should have removed them already.

        Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html
               fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
               fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
               fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
               fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
               fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
               fast/block/float/overhanging-float-add-in-static-position-block.html
               fast/block/float/overhanging-float-add-in-static-position-block2.html
               fast/block/float/overhanging-float-remove-from-absolute-position-block.html
               fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
               fast/block/float/overhanging-float-remove-from-fixed-position-block.html
               fast/block/float/overhanging-float-remove-from-fixed-position-block2.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleWillChange):
2011-06-27  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests that overhanging floats are removed during style changes to absolute/fixed
        position and gets added back when coming back to static position.
        https://bugs.webkit.org/show_bug.cgi?id=63355

        * fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
        * fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
        * fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
        * fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
        * fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
        * fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
        * fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
        * fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
        * fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
        * fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
        * fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
        * fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
        * platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
        * platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
        * platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
        * platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
Ryosuke Niwa [Mon, 27 Jun 2011 17:21:39 +0000 (17:21 +0000)]
2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Crash in TextIterator
        https://bugs.webkit.org/show_bug.cgi?id=63334

        Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
        and check !m_offset when handling first letter.

        Also add more assertions to help detecting similar bugs.

        Test: editing/text-iterator/first-letter-rtl-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextNode):
        (WebCore::TextIterator::emitText):
2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Crash in TextIterator
        https://bugs.webkit.org/show_bug.cgi?id=63334

        Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
        with first-letter rule applied where letters are not contiguous.

        * editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
        * editing/text-iterator/first-letter-rtl-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Huang Dongsung <luxtella@company100.net>
commit-queue [Mon, 27 Jun 2011 08:10:54 +0000 (08:10 +0000)]
2011-06-27  Huang Dongsung  <luxtella@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
        error.
        https://bugs.webkit.org/show_bug.cgi?id=62422

        REGRESSION(r77286): Remove bottomRight().
        REGRESSION(r77312): Change the logic to get the bottom right point.
        REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
        REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
        REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

        If the viewport width equals the contents width, especially in the mobile
        device, TiledBackingStore endlessly creates and deletes the rightmost
        column and bottom row of tiles.
        In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
        deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
        tiles infinitely.
        Modified TiledDrawingAreaProxy also.

        * platform/graphics/TiledBackingStore.cpp:
        (WebCore::innerBottomRight):
        (WebCore::TiledBackingStore::invalidate):
        (WebCore::TiledBackingStore::paint):
        (WebCore::TiledBackingStore::createTiles):
2011-06-27  Huang Dongsung  <luxtella@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
        error.
        https://bugs.webkit.org/show_bug.cgi?id=62422

        REGRESSION(r77286): Remove bottomRight().
        REGRESSION(r77312): Change the logic to get the bottom right point.
        REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
        REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
        REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.

        If the viewport width equals the contents width, especially in the mobile
        device, TiledBackingStore endlessly creates and deletes the rightmost
        column and bottom row of tiles.
        In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
        deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
        tiles infinitely.
        Modified TiledDrawingAreaProxy also.

        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::innerBottomRight):
        (WebKit::TiledDrawingAreaProxy::invalidate):
        (WebKit::TiledDrawingAreaProxy::paint):
        (WebKit::TiledDrawingAreaProxy::createTiles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
Alexis Menard [Mon, 27 Jun 2011 17:26:32 +0000 (17:26 +0000)]
2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove Phonon MediaPlayer from the tree.
        https://bugs.webkit.org/show_bug.cgi?id=63448

        Remvove from the build.

        * Source/WebKit.pri:
2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove Phonon MediaPlayer from the tree.
        https://bugs.webkit.org/show_bug.cgi?id=63448

        Remove Phonon mediaplayer as it is unused, not finished and
        unmaintained.

        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * features.pri:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
        * platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.
2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove Phonon MediaPlayer from the tree.
        https://bugs.webkit.org/show_bug.cgi?id=63448

        Remove Phonon related stuff.

        * docs/qtwebkit.qdocconf:
        * qt_webkit_version.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-10 Darin Adler <darin@apple.com>
Darin Adler [Fri, 10 Jun 2011 17:05:31 +0000 (17:05 +0000)]
2011-06-10  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION: Fullscreen video controller can't be dragged
        https://bugs.webkit.org/show_bug.cgi?id=62462

        No regression test because we don't have machinery for testing the fullscreen
        mode. We may find a way to add this in the future.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
        booleans related to dragging.
        (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
        is allowed and a drag isn't already in progress.
        (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
        dragging is already in progress.
        (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
        done during the dragging process.
        (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
        using explicit top/left.
        (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
        done by setPosition.
        (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
        continueDrag, and endDrag in response to mouse events.
        (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
        * html/shadow/MediaControlElements.h: Added new function and data members
        as mentioned above.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
        so you can drag the panel while in fullscreen.
        (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
        so you can't drag the panel while not in fullscreen. Also call resetPosition so
        position changes from dragging don't affect the panel in other contexts.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>
Dimitri Glazkov [Sat, 25 Jun 2011 17:04:40 +0000 (17:04 +0000)]
2011-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
        https://bugs.webkit.org/show_bug.cgi?id=63373

        * fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
        * fast/css/unknown-pseudo-element-matching.html: Added more tests.
2011-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
        https://bugs.webkit.org/show_bug.cgi?id=63373

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement.
        (WebCore::CSSStyleSelector::pushParent): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::parentOrHostElement): Added.
        * dom/Node.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Rubber-stamped by Maciej Stachowiak.
Alexey Proskuryakov [Sat, 25 Jun 2011 00:03:25 +0000 (00:03 +0000)]
    Rubber-stamped by Maciej Stachowiak.

        REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

        No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
        the rollout will re-introduce the older less frequent crash).

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix
        for bug 62764.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-24 Alexis Menard <alexis.menard@openbossa.org>
Alexis Menard [Fri, 24 Jun 2011 20:54:58 +0000 (20:54 +0000)]
2011-06-24  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix.

        Build fix on Linux when using the GStreamer backend.

        No new tests, just a build fix.

        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::keyPressEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 23 Jun 2011 18:30:55 +0000 (18:30 +0000)]
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Tests that we do not crash when doing a media query match.
        https://bugs.webkit.org/show_bug.cgi?id=63264

        * fast/css/media-query-evaluator-crash-expected.txt: Added.
        * fast/css/media-query-evaluator-crash.html: Added.
2011-06-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        RefPtr m_style in MediaQueryEvaluator in case of callers like
        MediaQueryMatcher::prepareEvaluator that do not retain its reference.
        https://bugs.webkit.org/show_bug.cgi?id=63264

        Test: fast/css/media-query-evaluator-crash.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryEvaluator.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
Csaba Osztrogonác [Thu, 23 Jun 2011 12:48:37 +0000 (12:48 +0000)]
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236

[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237

* tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix tst_QWebPage::showModalDialog() API test
Csaba Osztrogonác [Thu, 23 Jun 2011 12:45:34 +0000 (12:45 +0000)]
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244

Rubber-stamped by Andreas Kling.

[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245

* tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-22 Annie Sullivan <sullivan@chromium.org>
commit-queue [Wed, 22 Jun 2011 23:18:57 +0000 (23:18 +0000)]
2011-06-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
        https://bugs.webkit.org/show_bug.cgi?id=61594

        Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
        and places the cursor in the correct position.

        * editing/inserting/return-key-before-br-in-span-expected.txt: Added.
        * editing/inserting/return-key-before-br-in-span.html: Added.
        * editing/inserting/return-key-middle-of-span-expected.txt: Added.
        * editing/inserting/return-key-middle-of-span.html: Added.
2011-06-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
        https://bugs.webkit.org/show_bug.cgi?id=61594

        When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
        split at to be at the end of a text node. The code assumes the position is at the start of the node, so
        pass the correct node into splitTreeToNode() in that case.

        Tests: editing/inserting/return-key-before-br-in-span.html
               editing/inserting/return-key-middle-of-span.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-24 Matthew Delaney <mdelaney@apple.com>
Matt Delaney [Tue, 24 May 2011 18:04:36 +0000 (18:04 +0000)]
2011-05-24  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Clamp coordinates to integers for canvas create/getImageData routines
        https://bugs.webkit.org/show_bug.cgi?id=61135

        * fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt: Added.
        * fast/canvas/canvas-getImageData-largeNonintegralDimensions.html: Added.
2011-05-24  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Clamp coordinates to integers for canvas create/getImageData routines
        https://bugs.webkit.org/show_bug.cgi?id=61135

        Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createImageData):
        (WebCore::CanvasRenderingContext2D::getImageData):
        * platform/graphics/cg/ImageBufferDataCG.cpp:
        (WebCore::ImageBufferData::getData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-09 Adam Barth <abarth@webkit.org>
Adam Barth [Thu, 9 Jun 2011 08:41:56 +0000 (08:41 +0000)]
2011-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Running script from attach can remove elements from the stack of open elements
        https://bugs.webkit.org/show_bug.cgi?id=62160

        * fast/parser/document-write-onload-clear-expected.txt: Added.
        * fast/parser/document-write-onload-clear.html: Added.
2011-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Running script from attach can remove elements from the stack of open elements
        https://bugs.webkit.org/show_bug.cgi?id=62160

        When the tree build runs script synchronously, that script can remove
        arbitrary elements from the stack of open elements.  We need to hold a
        reference to |parent| in attach instead of rely upon the reference in
        the stack of open elements.

        Test: fast/parser/document-write-onload-clear.html

        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-09 Mike Lawther <mikelawther@chromium.org>
Mike Lawther [Thu, 9 Jun 2011 14:12:56 +0000 (14:12 +0000)]
2011-06-09  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Kent Tamura.

        Parsing issue with -webkit-calc
        https://bugs.webkit.org/show_bug.cgi?id=62276

        Set the CSSParserString for the calc functions.

        * css3/calc/regression-62276-expected.txt: Added.
        * css3/calc/regression-62276.html: Added.
2011-06-09  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Kent Tamura.

        Parsing issue with -webkit-calc
        https://bugs.webkit.org/show_bug.cgi?id=62276

        Set the CSSParserString for the calc functions.

        Test: css3/calc/regression-62276.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::lex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Joe Wild <joseph.wild@nokia.com>
commit-queue [Thu, 23 Jun 2011 15:44:58 +0000 (15:44 +0000)]
2011-06-23  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Export files under Symbian Qt WebKit build
        https://bugs.webkit.org/show_bug.cgi?id=61207

        Export files for the Symbian platform as this is needed by the
        production build system.

        Janne Koskinen provided the suggestion to use target_predeps,
        which is an improvement over the originally suggested patch.

        * QtWebKit.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-23 Joe Wild <joseph.wild@nokia.com>
commit-queue [Thu, 23 Jun 2011 22:02:45 +0000 (22:02 +0000)]
2011-06-23  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
        https://bugs.webkit.org/show_bug.cgi?id=61200

        Revert r87060 as it broke compatibility with QtWebKit 2.1 release
        and add some newly introduce symbols.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Ademar de Souza Reis Junior [Wed, 22 Jun 2011 18:57:04 +0000 (18:57 +0000)]
2011-06-22  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Holger Freyther.

        [Qt] Fix Qt namespace on QDeclarativeWebView autotest
        https://bugs.webkit.org/show_bug.cgi?id=63147

        Applications (such as the test runner) are not supposed to be wrapped
        by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
        QtWebKit) with a specific namespace won't work (will result in main
        being undefined).

        This was the only test wrapped by these macros, all others are fine.

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
        namespace macros.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed expectations update.
Csaba Osztrogonác [Fri, 6 May 2011 07:39:11 +0000 (07:39 +0000)]
Unreviewed expectations update.

* platform/mac-wk2/Skipped:
 - Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
* platform/qt-arm/Skipped:
 - Add fast/css/hover-update.html, because it fails intermittently.
 - Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
* platform/qt-wk2/Skipped:
 - Add new but failing test: editing/pasteboard/paste-placeholder-input.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-21 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 21 Jun 2011 19:18:11 +0000 (19:18 +0000)]
2011-06-21  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Regression(60942) wrong default action for drag-and-drop.
        https://bugs.webkit.org/show_bug.cgi?id=63004

        Added special handling for the case that dragOperation is not initialized.
        Save the last dropOperation and pass it to the dropEvent, so that it can
        be accepted by QDrag.
        Call event->accepted() and not event->acceptProposedAction(), because the
        later ignores the dropAction specified in JavaScript.

        Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
        and did not see any issue.
        Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
        and they all pass.

        * Api/qwebpage.cpp:
        (dropActionToDragOp):
        (QWebPagePrivate::dragMoveEvent):
        (QWebPagePrivate::dropEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-20 Oliver Hunt <oliver@apple.com>
Oliver Hunt [Mon, 20 Jun 2011 19:46:23 +0000 (19:46 +0000)]
2011-06-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r79060): Searching for a flight at united.com fails
        https://bugs.webkit.org/show_bug.cgi?id=63003

        Roll out tests that were added by the patch we're rolling out, and add
        a test for the united.com Date.

        * fast/js/date-parse-test-expected.txt:
        * fast/js/script-tests/date-parse-test.js:
2011-06-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r79060): Searching for a flight at united.com fails
        https://bugs.webkit.org/show_bug.cgi?id=63003

        This original change also broke Twitter, and we attempted to refine the fix to
        address that problem (http://trac.webkit.org/changeset/80542), but since it still breaks United,
        we need to revert the change until we understand the problem better.

        * wtf/DateMath.cpp:
        (WTF::parseDateFromNullTerminatedCharacters):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-20 Adam Barth <abarth@webkit.org>
Adam Barth [Mon, 20 Jun 2011 17:51:40 +0000 (17:51 +0000)]
2011-06-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
        https://bugs.webkit.org/show_bug.cgi?id=61774

        * fast/parser/attributes-on-close-script-expected.txt: Added.
        * fast/parser/attributes-on-close-script.html: Added.
2011-06-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
        https://bugs.webkit.org/show_bug.cgi?id=61774

        This ASSERT triggers for the same underlying issue that causes
        Bug 62971: When we tokenize a </script> tag, we don't realize that
        we've already consumed the "</script>" from the input stream when we
        extracted the previous token.  That causes the source tracker to be
        out-of-sync, triggering the incorrect view-source highlighting and this
        ASSERT.

        For now, let's just silence the assert while we work on Bug 62971.

        Test: fast/parser/attributes-on-close-script.html

        * html/parser/HTMLToken.h:
        (WebCore::HTMLToken::appendToAttributeName):
        (WebCore::AtomicHTMLToken::initializeAttributes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-16 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 16 Jun 2011 21:27:30 +0000 (21:27 +0000)]
2011-06-16  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        RefPtr frame since it can get removed in
        FrameLoader::finishedParsing.
        https://bugs.webkit.org/show_bug.cgi?id=62812

        Tests: already tested by fast/parser/document-write-into-initial-document.html.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-07 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Tue, 7 Jun 2011 22:45:14 +0000 (22:45 +0000)]
2011-06-07  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Replicate WidthIterator.cpp fix from r88139.
        https://bugs.webkit.org/show_bug.cgi?id=62238

        No new tests. Covered by existing layout tests on XP debug bots.

        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::advance):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 2 Jun 2011 02:49:37 +0000 (02:49 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Coding style nit. Move ec=0 initialization, change
        recommended by Alexey in bug.
        https://bugs.webkit.org/show_bug.cgi?id=60831

        * dom/Document.cpp:
        (WebCore::Document::setBody):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Wed, 1 Jun 2011 23:13:53 +0000 (23:13 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix setting of document.body
        https://bugs.webkit.org/show_bug.cgi?id=60831

        1. Only allowing setting to an element if it has a body tag.
        2. If element is from another document, import it.

        Test: fast/dom/document-set-body.html

        * dom/Document.cpp:
        (WebCore::Document::setBody):
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Tests setting document.body to non body elements, elements in other
        documents.
        https://bugs.webkit.org/show_bug.cgi?id=60831

        * fast/dom/document-set-body-expected.txt: Added.
        * fast/dom/document-set-body.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-01 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Wed, 1 Jun 2011 18:12:53 +0000 (18:12 +0000)]
2011-06-01  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Antti Koivisto.

        Do not use the pushed style selector if it is not equal to the
        parent document's style selector. It usually means that it is
        in a bad state, e.g. already cleared.
        https://bugs.webkit.org/show_bug.cgi?id=61737

        * dom/Element.cpp:
        (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-08 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Mon, 9 May 2011 16:32:26 +0000 (16:32 +0000)]
2011-05-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Add a crash test for r85964.
        https://bugs.webkit.org/show_bug.cgi?id=59473

        * fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
        * fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-05 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 5 May 2011 21:42:59 +0000 (21:42 +0000)]
2011-05-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Minor rebaselines for qt after my r85876.

        * platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-06-17 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Fri, 17 Jun 2011 20:19:10 +0000 (20:19 +0000)]
2011-06-17  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when unable to remove floats from
        parent's next siblings blocks.
        https://bugs.webkit.org/show_bug.cgi?id=62875

        * fast/block/float/float-not-removed-from-next-sibling5-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling5.html: Added.
2011-06-17  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        When we lose ability to propagate floats, need to find topmost
        parent with that overhanging float, and then iterate over its
        sibling blocks to remove the float.
        https://bugs.webkit.org/show_bug.cgi?id=62875

        Test: fast/block/float/float-not-removed-from-next-sibling5.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleDidChange):
        (WebCore::RenderBlock::hasOverhangingFloat):
        * rendering/RenderBlock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-10 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Tue, 10 May 2011 16:40:35 +0000 (16:40 +0000)]
2011-05-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Add containsFloats call to hasOverhangingFloats.
        https://bugs.webkit.org/show_bug.cgi?id=60537

        Test: fast/block/float/no-overhanging-float-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::hasOverhangingFloats):
2011-05-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests that we do not crash due to wrong result from
        hasOverhangingFloats.
        https://bugs.webkit.org/show_bug.cgi?id=60537

        * fast/block/float/no-overhanging-float-crash-expected.txt: Added.
        * fast/block/float/no-overhanging-float-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2011-05-05 Abhishek Arya <inferno@chromium.org>
Abhishek Arya [Thu, 5 May 2011 21:07:52 +0000 (21:07 +0000)]
2011-05-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        When style changes for a RenderBlock and we lose our ability to intrude into
        floats in the next siblings block (e.g a position change), make sure to mark
        our childs with floats for layout and iterate through our next sibling block
        chain to see which ones contain the float that also exists in our floating
        objects list and clear those using markAllDescendantsWithFloatsForLayout.
        https://bugs.webkit.org/show_bug.cgi?id=56299

        Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
               fast/block/float/float-not-removed-from-next-sibling.html
               fast/block/float/float-not-removed-from-next-sibling2.html
               fast/block/float/float-not-removed-from-next-sibling3.html
               fast/block/float/float-not-removed-from-next-sibling4.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleWillChange):
        (WebCore::RenderBlock::styleDidChange):
        (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
        * rendering/RenderBlock.h:
2011-05-04  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to add overflow from a float not in the
        descendant list and whose renderer is already removed.
        https://bugs.webkit.org/show_bug.cgi?id=56299

        * fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
        * fast/block/float/float-not-removed-from-next-sibling.html: Added. Black
        text boxes should be inside the silver float. Failing test will have float
        added to the text div block which will push the text downward.
        * fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black
        text boxes should be inside the silver float. Failing test will have float
        added to the text div block which will push the text downward.
        * fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance
        between the silver float and black text boxes should be less than height of
        silver float. Failing test will have float overflow added to the text div
        block which will cause large space between silver float and and black text boxes.
        * fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance
        between the silver float and black text boxes should be less than height of
        silver float. Failing test will have float overflow added to the text div
        block which will cause large space between silver float and and black text boxes.
        * fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agonew test introduced in r89118, but fail on Qt
Ademar de Souza Reis Jr [Tue, 21 Jun 2011 17:13:07 +0000 (14:13 -0300)]
new test introduced in r89118, but fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=62847

* platform/qt/Skipped: Skip fast/parser/xhtml-innerhtml-null-byte.xhtml.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/qt/Skipped

6 years ago2011-06-16 Gabor Loki <loki@webkit.org>
Gabor Loki [Fri, 17 Jun 2011 06:56:00 +0000 (06:56 +0000)]
2011-06-16 Gabor Loki <loki@webkit.org>

        [Qt] Unreviewed, build fix after r89118.

        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::initializeParserContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89122 268f45cc-cd09-0410-ab3c-d52691b4dbfc