1 2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
3 Reviewed by Laszlo Gombos.
5 [Qt] Upstream Symbian platform plugin
6 https://bugs.webkit.org/show_bug.cgi?id=58435
8 Upstream Symbian platform plugin with html5 video player.
10 * symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
11 (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
12 (HTML5FullScreenVideoHandler::enterFullScreen):
13 (HTML5FullScreenVideoHandler::exitFullScreen):
14 (HTML5FullScreenVideoHandler::onPlayerError):
15 (HTML5FullScreenVideoHandler::onPlayerStateChanged):
16 (HTML5FullScreenVideoHandler::onMediaStatusChanged):
17 (HTML5VideoPlugin::supportsExtension):
18 (HTML5VideoPlugin::createExtension):
19 * symbian/platformplugin/HTML5VideoPlugin.h: Added.
20 (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
21 (HTML5FullScreenVideoHandler::isFullScreen):
22 (HTML5FullScreenVideoHandler::updateScreenRect):
23 * symbian/platformplugin/HTML5VideoWidget.cpp: Added.
24 (HTML5VideoWidget::HTML5VideoWidget):
25 (HTML5VideoWidget::setDuration):
26 (HTML5VideoWidget::mousePressEvent):
27 (HTML5VideoWidget::onPlayerStopped):
28 (HTML5VideoWidget::onPlayerError):
29 (HTML5VideoWidget::onEndOfMedia):
30 (HTML5VideoWidget::onBufferingMedia):
31 (HTML5VideoWidget::onBufferedMedia):
32 (HTML5VideoWidget::onControlClicked):
33 (HTML5VideoWidget::onPositionChanged):
34 (HTML5VideoWidget::onSliderMoved):
35 (HTML5VideoWidget::onCloseClicked):
36 (HTML5VideoWidget::showFullScreen):
37 (HTML5VideoWidget::setVolume):
38 * symbian/platformplugin/HTML5VideoWidget.h: Added.
39 * symbian/platformplugin/OverlayWidget.cpp: Added.
40 (OverlayWidget::OverlayWidget):
41 (OverlayWidget::~OverlayWidget):
42 (OverlayWidget::setDuration):
43 (OverlayWidget::setPosition):
44 (OverlayWidget::setVolume):
45 (OverlayWidget::mousePressEvent):
46 (OverlayWidget::onPlayerStopped):
47 (OverlayWidget::onPlayerError):
48 (OverlayWidget::onEndOfMedia):
49 (OverlayWidget::onBufferingMedia):
50 (OverlayWidget::onBufferedMedia):
51 (OverlayWidget::timeToString):
52 (OverlayWidget::applyStyleSheet):
53 (OverlayWidget::onControlClicked):
54 (OverlayWidget::onSliderMoved):
55 (OverlayWidget::onSoundClicked):
56 (OverlayWidget::onCloseClicked):
57 (OverlayWidget::onVolumeSliderReleased):
58 (OverlayWidget::onVolumeSliderMoved):
59 (OverlayWidget::onTimerTimeout):
60 (OverlayWidget::showFullScreen):
61 * symbian/platformplugin/OverlayWidget.h: Added.
62 * symbian/platformplugin/PlayerButton.cpp: Added.
63 (PlayerButton::PlayerButton):
64 (PlayerButton::event):
65 * symbian/platformplugin/PlayerButton.h: Added.
66 * symbian/platformplugin/PlayerLabel.cpp: Added.
67 (PlayerLabel::PlayerLabel):
68 (PlayerLabel::onPlayerError):
69 (PlayerLabel::startBufferingAnimation):
70 (PlayerLabel::stopBufferingAnimation):
71 (PlayerLabel::onAnimationTimeout):
72 * symbian/platformplugin/PlayerLabel.h: Added.
73 * symbian/platformplugin/WebPlugin.cpp:
74 (WebPlugin::createExtension):
75 * symbian/platformplugin/images: Added.
76 * symbian/platformplugin/images/button_cannotplay.png: Added.
77 * symbian/platformplugin/images/button_close.png: Added.
78 * symbian/platformplugin/images/button_pause.png: Added.
79 * symbian/platformplugin/images/button_play.png: Added.
80 * symbian/platformplugin/images/button_sound_off.png: Added.
81 * symbian/platformplugin/images/button_sound_on.png: Added.
82 * symbian/platformplugin/images/loading_buffering_1.png: Added.
83 * symbian/platformplugin/images/loading_buffering_2.png: Added.
84 * symbian/platformplugin/images/loading_buffering_3.png: Added.
85 * symbian/platformplugin/images/loading_buffering_4.png: Added.
86 * symbian/platformplugin/platformplugin.pro:
87 * symbian/platformplugin/platformplugin.qrc: Added.
88 * symbian/platformplugin/qss: Added.
89 * symbian/platformplugin/qss/OverlayWidget.qss: Added.
91 2011-05-18 Yi Shen <yi.4.shen@nokia.com>
93 Reviewed by Andreas Kling.
95 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
96 https://bugs.webkit.org/show_bug.cgi?id=33179
98 Remove the implementation of the handleInputMethodKeydown, which introduces
99 a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
101 * WebCoreSupport/EditorClientQt.cpp:
102 (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
103 * tests/qwebpage/tst_qwebpage.cpp:
104 (tst_QWebPage::inputMethods): Add more tests.
106 2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
108 Reviewed by Andreas Kling.
110 [Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
111 https://bugs.webkit.org/show_bug.cgi?id=60978
113 Backslash to escape newlines was confusing both prepare-ChangeLog and the
114 QtCreator highlight system.
116 * tests/qwebframe/tst_qwebframe.cpp:
117 (tst_QWebFrame::evalJSV):
118 Remove usage of backslash to escape newlines in string literal.
120 2011-05-16 Andreas Kling <kling@webkit.org>
122 Reviewed by Kenneth Rohde Christiansen.
124 REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
125 https://bugs.webkit.org/show_bug.cgi?id=60892
127 Don't set the ItemClipsChildrenToShape flag for the root platform layer,
128 since that is now the overflow controls layer. The clip layer, which was
129 previously the root platform layer, already gets the flag by way of
130 the GraphicsLayer mask-to-bounds flag.
132 * WebCoreSupport/PageClientQt.cpp:
133 (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
135 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
137 Reviewed by nobody, build fix.
139 [Qt] Fix build on MSVC.
141 qobject_cast<> requires the class to be exported on MSVC,
142 removing it since the code that needs it is commented out for
145 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
146 (tst_QDeclarativeWebView::elementAreaAt):
148 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
150 Reviewed by nobody, build fix.
152 [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
156 2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
158 Reviewed by Simon Hausmann.
160 Install correct header files for webkit.
162 Since WebKit is no longer inside Qt, we can remove the detection for
165 [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
166 https://bugs.webkit.org/show_bug.cgi?id=57621
170 2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
172 Reviewed by Andreas Kling.
174 [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
175 https://bugs.webkit.org/show_bug.cgi?id=60224
177 We should use nullptr rather than 0. nullptr will be added in the new C++ standard
178 but WebKit already has a nullptr class if there is no c++0x support.
180 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
181 (DumpRenderTreeSupportQt::addUserStyleSheet):
183 2011-05-04 Cris Neckar <cdn@chromium.org>
185 Reviewed by Adam Barth.
187 Expose WebView directly through ChromeClient.
188 https://bugs.webkit.org/show_bug.cgi?id=49902
190 * WebCoreSupport/ChromeClientQt.h:
191 (WebCore::ChromeClientQt::webView):
193 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
195 Unreviewed warning fix.
197 The variable is just unused.
199 * tests/qwebpage/tst_qwebpage.cpp:
200 (tst_QWebPage::inputMethods):
202 2011-05-04 Tao Bai <michaelbai@chromium.org>
204 Reviewed by David Kilzer.
206 Populate touch-icon url to FrameLoaderClient
207 https://bugs.webkit.org/show_bug.cgi?id=59143
209 Respect the interface change in FrameLoaderClient.
211 * WebCoreSupport/FrameLoaderClientQt.cpp:
212 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
213 * WebCoreSupport/FrameLoaderClientQt.h:
215 2011-03-31 Luiz Agostini <luiz.agostini@openbossa.org>
217 Reviewed by Kenneth Rohde Christiansen.
219 [Qt] Qt WebKit updates view on HTTP 204 response
220 https://bugs.webkit.org/show_bug.cgi?id=42529
222 Ignoring http responses which have status code equal to 204 (No Content)
223 or 205 (Reset Content).
225 * WebCoreSupport/FrameLoaderClientQt.cpp:
226 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
228 2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
230 Reviewed by Benjamin Poulain.
232 [Qt] Fix signals emitted in FakeReply used in autotests
233 https://bugs.webkit.org/show_bug.cgi?id=60049
235 The signals emitted for each case of FakeReply were swapped (error case
236 emitting metaDataChanged() and redirect case emitting error()). Emitting
237 readyRead() is not necessary.
239 * tests/qwebframe/tst_qwebframe.cpp:
240 (FakeReply::FakeReply):
241 Choose the different continue function for each case of FakeReply. This removes
242 the need of the if-statement in timeout() and let us replace timeout() with two
245 (FakeReply::continueRedirect):
246 (FakeReply::continueError):
247 Continuation cases, emitting the minimal set of signals needed for each case.
249 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
251 Reviewed by Dimitri Glazkov.
253 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
254 https://bugs.webkit.org/show_bug.cgi?id=58703
256 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
257 (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
259 2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
261 Reviewed by Andreas Kling.
263 [Qt] QtDeclarative Webview element has a fixed white background
264 https://bugs.webkit.org/show_bug.cgi?id=40918
266 QProperty REVISION feature is not present in certain Qt Trunk clones.
267 These builds report their version as 4.8.0, and therefore break on the
268 prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
269 the existance of Q_REVISION.
271 * declarative/plugin.cpp:
272 (WebKitQmlPlugin::registerTypes):
273 * declarative/qdeclarativewebview.cpp:
274 * declarative/qdeclarativewebview_p.h:
276 2011-05-01 Sam Weinig <sam@webkit.org>
278 Reviewed by Anders Carlsson.
280 Prune some unnecessary #includes
281 https://bugs.webkit.org/show_bug.cgi?id=59895
283 Start getting rid of unnecessary #includes and forward declares.
285 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
287 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
289 Reviewed by Adam Barth.
291 Enable strict OwnPtr for Qt
292 https://bugs.webkit.org/show_bug.cgi?id=59667
295 (QWebPagePrivate::QWebPagePrivate):
297 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
299 Reviewed by Simon Hausmann.
301 ENABLE(QT_BEARER) -> USE(QT_BEARER)
303 * Api/qwebsettings.cpp:
305 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
307 Reviewed by Simon Hausmann.
309 ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
313 2011-04-28 Yael Aharon <yael.aharon@nokia.com>
315 Reviewed by Andreas Kling.
317 Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
318 https://bugs.webkit.org/show_bug.cgi?id=59704
320 * WebCoreSupport/QtFallbackWebPopup.cpp:
321 (WebCore::QtFallbackWebPopup::show):
322 * WebCoreSupport/QtFallbackWebPopup.h:
324 2011-04-27 Yi Shen <yi.4.shen@nokia.com>
326 Reviewed by Kenneth Rohde Christiansen.
328 [Qt] Upstream Symbian platform plugin
329 https://bugs.webkit.org/show_bug.cgi?id=58435
331 Upstream Symbian platform plugin.
333 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
334 * symbian/platformplugin: Added.
335 * symbian/platformplugin/WebPlugin.cpp: Added.
336 (ItemListDelegate::ItemListDelegate):
337 (ItemListDelegate::paint):
339 (Popup::resizeEvent):
340 (Popup::populateList):
341 (Popup::onItemSelected):
342 (Popup::updateSelectionsBeforeDialogClosing):
343 (Popup::updateAndClose):
344 (WebPopup::WebPopup):
345 (WebPopup::~WebPopup):
346 (WebPopup::createSingleSelectionPopup):
347 (WebPopup::createMultipleSelectionPopup):
348 (WebPopup::createPopup):
351 (WebPopup::popupClosed):
352 (WebPopup::itemClicked):
353 (SingleSelectionPopup::SingleSelectionPopup):
354 (MultipleSelectionPopup::MultipleSelectionPopup):
355 (WebNotificationPresenter::showNotification):
356 (WebPlugin::supportsExtension):
357 (WebPlugin::createExtension):
358 * symbian/platformplugin/WebPlugin.h: Added.
359 (Popup::preSelectedIndices):
361 (WebNotificationPresenter::WebNotificationPresenter):
362 (WebNotificationPresenter::~WebNotificationPresenter):
363 * symbian/platformplugin/platformplugin.pro: Added.
364 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
365 (QWebSelectData::~QWebSelectData):
366 (QWebSelectMethod::~QWebSelectMethod):
367 (QWebNotificationData::~QWebNotificationData):
368 (QWebNotificationPresenter::QWebNotificationPresenter):
369 (QWebNotificationPresenter::~QWebNotificationPresenter):
370 (QWebTouchModifier::~QWebTouchModifier):
371 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
372 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
373 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
375 2011-04-26 Yi Shen <yi.4.shen@nokia.com>
377 Reviewed by Tor Arne Vestbø.
379 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
380 https://bugs.webkit.org/show_bug.cgi?id=56946
382 Deployed the missing resource for Symbian platform.
384 * tests/qwebframe/qwebframe.pro:
386 2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
388 Reviewed by Andreas Kling.
390 [Qt] Build fix: QtDeclarative Webview element has a fixed white background
391 https://bugs.webkit.org/show_bug.cgi?id=40918
393 Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
395 * declarative/plugin.cpp: Bump up required version to 4.7.4+
396 (WebKitQmlPlugin::registerTypes):
397 * declarative/qdeclarativewebview.cpp: ditto
398 * declarative/qdeclarativewebview_p.h: ditto
399 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
401 2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
403 Reviewed by Csaba Osztrogonác.
405 [Qt] Implement LayoutTestController::setAutofilled
406 https://bugs.webkit.org/show_bug.cgi?id=59439
408 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
409 (DumpRenderTreeSupportQt::setAutofilled):
410 * WebCoreSupport/DumpRenderTreeSupportQt.h:
412 2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
414 Unreviewed, rolling out r84627.
415 http://trac.webkit.org/changeset/84627
416 https://bugs.webkit.org/show_bug.cgi?id=59271
418 It broke Symbian build (Requested by Ossy on #webkit).
421 * symbian/platformplugin/WebPlugin.cpp: Removed.
422 * symbian/platformplugin/WebPlugin.h: Removed.
423 * symbian/platformplugin/platformplugin.pro: Removed.
424 * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
426 2011-04-22 Sam Weinig <sam@webkit.org>
430 * Api/qwebelement.cpp:
431 (setupScriptContext):
433 2011-04-22 Yi Shen <yi.4.shen@nokia.com>
435 Reviewed by Kenneth Rohde Christiansen.
437 [Qt] Upstream Symbian platform plugin
438 https://bugs.webkit.org/show_bug.cgi?id=58435
440 Upstream Symbian platform plugin.
442 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
443 * symbian/platformplugin: Added.
444 * symbian/platformplugin/WebPlugin.cpp: Added.
445 (ItemListDelegate::ItemListDelegate):
446 (ItemListDelegate::paint):
448 (Popup::resizeEvent):
449 (Popup::populateList):
450 (Popup::onItemSelected):
451 (Popup::updateSelectionsBeforeDialogClosing):
452 (Popup::updateAndClose):
453 (WebPopup::WebPopup):
454 (WebPopup::~WebPopup):
455 (WebPopup::createSingleSelectionPopup):
456 (WebPopup::createMultipleSelectionPopup):
457 (WebPopup::createPopup):
460 (WebPopup::popupClosed):
461 (WebPopup::itemClicked):
462 (SingleSelectionPopup::SingleSelectionPopup):
463 (MultipleSelectionPopup::MultipleSelectionPopup):
464 (WebNotificationPresenter::showNotification):
465 (WebPlugin::supportsExtension):
466 (WebPlugin::createExtension):
467 * symbian/platformplugin/WebPlugin.h: Added.
468 (Popup::preSelectedIndices):
470 (WebNotificationPresenter::WebNotificationPresenter):
471 (WebNotificationPresenter::~WebNotificationPresenter):
472 * symbian/platformplugin/platformplugin.pro: Added.
473 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
474 (QWebSelectData::~QWebSelectData):
475 (QWebSelectMethod::~QWebSelectMethod):
476 (QWebNotificationData::~QWebNotificationData):
477 (QWebNotificationPresenter::QWebNotificationPresenter):
478 (QWebNotificationPresenter::~QWebNotificationPresenter):
479 (QWebTouchModifier::~QWebTouchModifier):
480 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
481 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
482 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
484 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
486 Reviewed by Sam Weinig.
488 Add Frame* to the argument lists of canCopyCut and canPaste
489 https://bugs.webkit.org/show_bug.cgi?id=59153
491 * WebCoreSupport/EditorClientQt.cpp:
492 (WebCore::EditorClientQt::canCopyCut):
493 (WebCore::EditorClientQt::canPaste):
494 * WebCoreSupport/EditorClientQt.h:
496 2011-04-21 Yi Shen <yi.4.shen@nokia.com>
498 Reviewed by Antonio Gomes.
500 [Qt] Fix the style issue for Api/qwebkitplatformplugin.h
501 https://bugs.webkit.org/show_bug.cgi?id=59097
503 Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
505 * Api/qwebkitplatformplugin.h:
507 2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
509 Reviewed by Csaba Osztrogonác.
511 [Qt] REGRESSION(84057): It made 4 API tests fail
512 https://bugs.webkit.org/show_bug.cgi?id=58848
514 After MIME sniffing support was added, some autotests are failing because
515 the sniffer doesn't recognize our HTML pages.
517 This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
518 and tst_QWebFrame::horizontalScrollAfterBack().
520 * tests/qwebframe/resources/testiframe.html:
521 * tests/qwebframe/resources/testiframe2.html:
522 Remove spurious </html> in beginning of the document.
524 * tests/qwebpage/resources/framedindex.html:
525 * tests/qwebpage/resources/index.html:
526 Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
527 possible starting tag for HTML document.
529 * tests/qwebpage/tst_qwebpage.cpp:
530 (tst_QWebPage::errorPageExtensionInFrameset):
531 Verify if we do have a main frame and the main frame has the children frames we
532 expect. This will avoid crashing if for some reason children frames are not
535 2011-04-20 Dominic Cooney <dominicc@chromium.org>
537 Reviewed by Dimitri Glazkov.
539 layoutTestController can create and destroy shadow DOM
540 https://bugs.webkit.org/show_bug.cgi?id=59058
542 Support for new methods in Qt DRT.
544 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
545 (DumpRenderTreeSupportQt::ensureShadowRoot):
546 (DumpRenderTreeSupportQt::removeShadowRoot):
547 * WebCoreSupport/DumpRenderTreeSupportQt.h:
549 2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
551 Reviewed by Csaba Osztrogonác.
553 [Qt] Cleanup includepath adjustment for generated files
554 https://bugs.webkit.org/show_bug.cgi?id=58869
556 * QtWebKit.pro: Revert the hacky fix in r84174. Remove
559 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
561 Reviewed by Andreas Kling.
563 [Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
564 https://bugs.webkit.org/show_bug.cgi?id=57254
566 Skip test for setPalette() which doesn't work
567 when WTF_USE_QT_MOBILE_THEME is defined.
569 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
570 * tests/qwebview/tst_qwebview.cpp:
573 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
575 Reviewed by Laszlo Gombos.
577 [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
578 https://bugs.webkit.org/show_bug.cgi?id=58044
580 Fixing this test by disabling the scrollbars on the graphics view
581 since QtWebKit handles scrolling and scrollbar automatically and correctly.
583 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
584 (tst_QGraphicsWebView::widgetsRenderingThroughCache):
586 2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
588 Reviewed by Andreas Kling.
590 [Qt] X11: Text selection is causing oncopy event to be called
591 https://bugs.webkit.org/show_bug.cgi?id=58656
593 Always when text is selected the oncopy event is fired, this behavior does
594 not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
595 is making multi part-copies (with rich text metadata), the multi-part
596 data can be obtained by data transfer items interface when supported by QtWebKit.
597 Also, copies to the clipboard of a selected image, is not supported by Chrome and
598 Firefox and was removed from QtWebKit.
602 (QWebPagePrivate::handleClipboard):
604 2011-04-18 Csaba Osztrogonác <ossy@webkit.org>
606 [Qt][WK2] Unreviewed buildfix after r84174.
608 * QtWebKit.pro: Missing includepath added.
610 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
612 Reviewed by Laszlo Gombos.
614 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
615 https://bugs.webkit.org/show_bug.cgi?id=57546
617 Disable the fullscreen VKB when testing inputFieldFocus().
619 * tests/qwebframe/tst_qwebframe.cpp:
621 2011-04-18 Andreas Kling <kling@webkit.org>
623 [Qt] DRT: Unreviewed test fix after r84168.
625 Dump the original request KURL for blocked access attempts.
626 Turns out converting it to a QUrl lower-cases the hostname.
628 * WebCoreSupport/FrameLoaderClientQt.cpp:
629 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
631 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
633 Reviewed by Laszlo Gombos.
635 [Qt] Fix Api tests for QWebPage on Symbian
636 https://bugs.webkit.org/show_bug.cgi?id=56924
638 Ignores the style attribute that selectedHtml() returns.
640 * tests/qwebpage/tst_qwebpage.cpp:
641 (tst_QWebPage::cursorMovements):
642 (tst_QWebPage::textSelection):
643 (tst_QWebPage::findText):
645 2011-04-18 Andreas Kling <kling@webkit.org>
647 Reviewed by Adam Barth.
649 REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
650 https://bugs.webkit.org/show_bug.cgi?id=58779
652 KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
653 QUrl instead to match the behavior of other ports.
655 * WebCoreSupport/FrameLoaderClientQt.cpp:
656 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
658 2011-04-18 Dominic Cooney <dominicc@chromium.org>
660 Reviewed by Andreas Kling.
662 Add layoutTestController.shadowRoot to Qt DRT.
663 https://bugs.webkit.org/show_bug.cgi?id=58759
665 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
666 (DumpRenderTreeSupportQt::shadowRoot): Added.
667 * WebCoreSupport/DumpRenderTreeSupportQt.h:
669 2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
671 Reviewed by Andreas Kling.
673 [Qt] Autotest got missed in the handover of the QML WebView element
674 https://bugs.webkit.org/show_bug.cgi?id=41449
676 Importing WebView QML element test cases from Qt repository. I did some
677 style modifications and simplifications in the original code but hopefully
678 without changing the behavior.
680 Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
681 issues currently are:
683 - pixelCache() test checked the usage of pixel cache by using a subclass of
684 QDeclarativeWebView. We can't do that right now because this class is not
685 exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
687 - elementAtArea() test uses a function that is not exported. But in this case
688 I think we should test it's user, the public method "heuristicZoom".
690 * tests/qdeclarativewebview/resources/basic.html: Added.
691 * tests/qdeclarativewebview/resources/basic.png: Added.
692 * tests/qdeclarativewebview/resources/basic.qml: Added.
693 * tests/qdeclarativewebview/resources/elements.html: Added.
694 * tests/qdeclarativewebview/resources/elements.qml: Added.
695 * tests/qdeclarativewebview/resources/forward.html: Added.
696 * tests/qdeclarativewebview/resources/forward.png: Added.
697 * tests/qdeclarativewebview/resources/javaScript.html: Added.
698 * tests/qdeclarativewebview/resources/javaScript.qml: Added.
699 * tests/qdeclarativewebview/resources/loadError.qml: Added.
700 * tests/qdeclarativewebview/resources/newwindows.html: Added.
701 * tests/qdeclarativewebview/resources/newwindows.qml: Added.
702 * tests/qdeclarativewebview/resources/propertychanges.qml: Added.
703 * tests/qdeclarativewebview/resources/sethtml.qml: Added.
704 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
705 (tst_QDeclarativeWebView::tmpDir):
709 (tst_QDeclarativeWebView::cleanupTestCase):
710 (tst_QDeclarativeWebView::basicProperties):
711 (tst_QDeclarativeWebView::elementAreaAt):
712 (tst_QDeclarativeWebView::historyNav):
713 (callEvaluateJavaScript):
714 (tst_QDeclarativeWebView::javaScript):
715 (tst_QDeclarativeWebView::loadError):
716 (tst_QDeclarativeWebView::multipleWindows):
717 (tst_QDeclarativeWebView::newWindowComponent):
718 (tst_QDeclarativeWebView::newWindowParent):
719 (tst_QDeclarativeWebView::pressGrabTime):
720 (tst_QDeclarativeWebView::renderingEnabled):
721 (tst_QDeclarativeWebView::setHtml):
722 (tst_QDeclarativeWebView::settings):
723 (tst_QDeclarativeWebView::checkNoErrors):
724 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
726 2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
728 Reviewed by Kenneth Rohde Christiansen.
730 [Qt] QWebPage MIME type handling inconsistency with other web browsers
731 https://bugs.webkit.org/show_bug.cgi?id=46968
733 Implementing mime type sniffing based on
734 http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
736 * WebCoreSupport/FrameLoaderClientQt.cpp:
737 (WebCore::FrameLoaderClientQt::createNetworkingContext):
738 * WebCoreSupport/FrameNetworkingContextQt.cpp:
739 (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
740 (WebCore::FrameNetworkingContextQt::create):
741 (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
742 * WebCoreSupport/FrameNetworkingContextQt.h:
743 * tests/MIMESniffing/MIMESniffing.pro: Added.
744 * tests/MIMESniffing/TestData.h: Added.
745 * tests/MIMESniffing/resources.qrc: Added.
746 * tests/MIMESniffing/resources/application_atom+xml: Added.
747 * tests/MIMESniffing/resources/application_ogg: Added.
748 * tests/MIMESniffing/resources/application_pdf: Added.
749 * tests/MIMESniffing/resources/application_postscript: Added.
750 * tests/MIMESniffing/resources/application_rdf+xml: Added.
751 * tests/MIMESniffing/resources/application_rss+xml: Added.
752 * tests/MIMESniffing/resources/application_x-gzip: Added.
753 * tests/MIMESniffing/resources/application_x-rar-compressed: Added.
754 * tests/MIMESniffing/resources/application_zip: Added.
755 * tests/MIMESniffing/resources/audio_x-wave: Added.
756 * tests/MIMESniffing/resources/image_bmp: Added.
757 * tests/MIMESniffing/resources/image_gif: Added.
758 * tests/MIMESniffing/resources/image_jpeg: Added.
759 * tests/MIMESniffing/resources/image_png: Added.
760 * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
761 * tests/MIMESniffing/resources/image_webp: Added.
762 * tests/MIMESniffing/resources/text_html: Added.
763 * tests/MIMESniffing/resources/text_xml: Added.
764 * tests/MIMESniffing/resources/video_webm: Added.
765 * tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
766 (tst_MIMESniffing::tst_MIMESniffing):
768 (tst_MIMESniffing::testCase1):
771 2011-04-15 Andreas Kling <kling@webkit.org>
773 Reviewed by Antonio Gomes.
775 [Qt] DRT: Block access to external URLs.
777 Implement the "Blocked access to external URL" behavior for Qt's DRT,
778 based on what other ports are doing.
780 Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
782 * WebCoreSupport/FrameLoaderClientQt.cpp:
783 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
785 2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
787 Reviewed by Antonio Gomes.
789 [Qt] Web Inspector does not highlight elements
790 https://bugs.webkit.org/show_bug.cgi?id=35125
792 Adjust Web inspector to highlight elements on the page when the mouse
793 hovers the element on DOM inspector.
796 (QWebFramePrivate::renderRelativeCoords):
797 * WebCoreSupport/InspectorClientQt.cpp:
798 (WebCore::InspectorClientQt::highlight):
799 (WebCore::InspectorClientQt::hideHighlight):
801 2011-04-12 George Guo <George.Guo@nokia.com>
803 Reviewed by Laszlo Gombos.
805 [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
806 http://bugs.webkit.org/show_bug.cgi?id=58141
808 If QtWebKit is already in Symbian ROM, we need package to be
813 2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
815 Reviewed by Andreas Kling.
817 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
818 https://bugs.webkit.org/show_bug.cgi?id=58251
820 Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
823 (QWebFrame::QWebFrame):
825 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
827 Reviewed by Benjamin Poulain.
829 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
830 https://bugs.webkit.org/show_bug.cgi?id=58251
832 Qt coding conventions states that private slots should be located in private implementation of
833 the class. This allows us to rename/delete the slots in the future without breaking anything.
835 No new tests added, just a simple refactoring.
838 (QWebFramePrivate::_q_orientationChanged):
842 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
844 Reviewed by Kenneth Rohde Christiansen.
846 [Qt] Sub-Frame content is not updated when scrolling in certain circumstances
847 https://bugs.webkit.org/show_bug.cgi?id=50373
849 Make sure that we invalidate the backing store when using TILED_BACKING_STORE
850 and the page contains sub frames. This bug appears only when frame flattening is
851 disabled and scrollable subframes.
853 Original patch from Thomas Thrainer.
855 * WebCoreSupport/ChromeClientQt.cpp:
856 (WebCore::ChromeClientQt::invalidateWindow):
858 2011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com>
860 Reviewed by Andreas Kling.
862 [Qt] HTML5 Drag and Drop demos not working
863 https://bugs.webkit.org/show_bug.cgi?id=56486
865 Handling the drop with JavaScript was not working with Qt because if the action is ignored
866 in response to DragEnter, no further events are sent to the view.
868 Drag and drop is defined and used differently by webpages. The drag move events are determining
869 what action should take place. To adopt this behavior for Qt, we always accept drag enter events
873 (QWebPagePrivate::dragEnterEvent):
875 2011-04-11 Andras Becsi <abecsi@webkit.org>
877 Reviewed by Andreas Kling.
879 [Qt] REGRESSION(83122): tst_QWebElement::style() fails
880 https://bugs.webkit.org/show_bug.cgi?id=58032
882 According to the documentation of QWebElement the styleProperty method should
883 not respect style inheritance and other CSS rules for the InlineStyle enum.
885 r83122 fixed this behaviour.
887 * tests/qwebelement/tst_qwebelement.cpp:
888 (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
890 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
892 Build fix after r83436.
894 * WebCoreSupport/FrameLoaderClientQt.cpp:
895 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
897 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
899 Reviewed by Benjamin Poulain.
901 [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
903 * WebCoreSupport/FrameLoaderClientQt.cpp:
904 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
905 for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
906 This is in line with the Mac port.
908 2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
910 Unreviewed, rolling out r83295.
911 http://trac.webkit.org/changeset/83295
912 https://bugs.webkit.org/show_bug.cgi?id=58144
914 Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
916 * WebCoreSupport/EditorClientQt.cpp:
917 (WebCore::EditorClientQt::handleInputMethodKeydown):
919 2011-04-08 Yi Shen <yi.4.shen@nokia.com>
921 Reviewed by Antonio Gomes.
923 [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
924 https://bugs.webkit.org/show_bug.cgi?id=57472
926 Avoid to insert new line for both keydown event & keypress event.
928 * WebCoreSupport/EditorClientQt.cpp:
929 (WebCore::EditorClientQt::handleInputMethodKeydown):
931 2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
933 Reviewed by Benjamin Poulain.
935 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
936 https://bugs.webkit.org/show_bug.cgi?id=32723
938 When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
939 use an invalid URL (the begin() without arguments). Clearing the document
940 with the same URL was causing problems when we had a fragment because it assume that
941 only scrolling was enough and did not loaded the document again.
943 When setUrl() is called but fails, url() is expected to return the requested value. The
944 begin(url) guaranteed that before. This patch adds a member to track the URL, which is
945 updated when the URL changes and also when setUrl() is called.
947 KURL was used for the member so that when setUrl() is called, and then url() is checked
948 before the page gets loaded, we perform the same conversion that will be performed by a
949 successful load, e.g. add trailing '/' to an address. This behavior is checked by
950 tst_QWebFrame::requestedUrl() test.
952 For the record: the second QWebPage::setUrl() worked because the load was considered a
953 FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
954 needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
957 (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
962 (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
963 the baseURL, e.g. by using the <base> tag.
966 * WebCoreSupport/FrameLoaderClientQt.cpp:
967 (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
968 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
970 * tests/qwebframe/tst_qwebframe.cpp:
971 (tst_QWebFrame::setUrlWithFragment): unskip test.
973 2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
975 Reviewed by Kenneth Rohde Christiansen.
977 Build fix when using Phonon as a backend for the multimedia support.
979 * WebCoreSupport/ChromeClientQt.cpp:
980 (WebCore::ChromeClientQt::ChromeClientQt):
981 (WebCore::ChromeClientQt::~ChromeClientQt):
982 * WebCoreSupport/ChromeClientQt.h:
984 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
986 Reviewed by Kenneth Rohde Christiansen.
988 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
989 https://bugs.webkit.org/show_bug.cgi?id=56086
991 Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
992 from the LayoutTestController.
994 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
995 (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
996 * WebCoreSupport/DumpRenderTreeSupportQt.h:
998 2011-04-06 Anders Bakken <agbakken@gmail.com>
1000 Reviewed by Kenneth Rohde Christiansen.
1002 [Qt] FrameLoaderClientQt.cpp has coding-style errors
1003 https://bugs.webkit.org/show_bug.cgi?id=40254
1005 * WebCoreSupport/FrameLoaderClientQt.cpp:
1006 (drtDescriptionSuitableForTestResult):
1007 (WebCore::FrameLoaderClientQt::hasWebView):
1008 (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1009 (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1010 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1011 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
1012 (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1013 (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1014 (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
1015 (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
1016 (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1017 (WebCore::FrameLoaderClientQt::willChangeTitle):
1018 (WebCore::FrameLoaderClientQt::didChangeTitle):
1019 (WebCore::FrameLoaderClientQt::finishedLoading):
1020 (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1021 (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1022 (WebCore::FrameLoaderClientQt::didFinishLoad):
1023 (WebCore::FrameLoaderClientQt::setTitle):
1024 (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1025 (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
1026 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1027 (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
1028 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
1029 (WebCore::FrameLoaderClientQt::committedLoad):
1030 (WebCore::FrameLoaderClientQt::download):
1031 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1032 (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
1033 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1034 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1035 (WebCore::FrameLoaderClientQt::createFrame):
1036 (WebCore::FrameLoaderClientQt::objectContentType):
1037 (WebCore::FrameLoaderClientQt::createPlugin):
1039 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1041 Reviewed by Andreas Kling.
1043 [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1044 https://bugs.webkit.org/show_bug.cgi?id=57974
1046 We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1048 No new tests needed, just a config flag rename.
1050 * Api/qwebkitplatformplugin.h:
1051 * WebCoreSupport/ChromeClientQt.cpp:
1052 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1053 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1054 * WebCoreSupport/FullScreenVideoQt.cpp:
1055 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1056 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1057 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1058 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1059 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1060 (WebCore::FullScreenVideoQt::isValid):
1061 * WebCoreSupport/FullScreenVideoQt.h:
1062 * WebCoreSupport/QtPlatformPlugin.cpp:
1063 * WebCoreSupport/QtPlatformPlugin.h:
1064 * examples/platformplugin/WebPlugin.cpp:
1065 (WebPlugin::supportsExtension):
1066 (WebPlugin::createExtension):
1067 * examples/platformplugin/WebPlugin.h:
1068 * examples/platformplugin/platformplugin.pro:
1069 * examples/platformplugin/qwebkitplatformplugin.h:
1070 * tests/qwebpage/tst_qwebpage.cpp:
1071 (tst_QWebPage::loadHtml5Video):
1074 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1076 Reviewed by Andreas Kling.
1078 [Qt] Implement fullscreen playback for the GStreamer backend.
1079 https://bugs.webkit.org/show_bug.cgi?id=56826
1081 Implement support for fullscreen playback when building the
1082 Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
1083 The implementation is done in FullScreenVideoQt alongside with
1084 the Qt Multimedia support.
1086 No new tests because layout tests cover it. They are not yet activated
1087 but will be any time soon.
1090 * WebCoreSupport/ChromeClientQt.cpp:
1091 (WebCore::ChromeClientQt::ChromeClientQt):
1092 (WebCore::ChromeClientQt::~ChromeClientQt):
1093 (WebCore::ChromeClientQt::enterFullscreenForNode):
1094 (WebCore::ChromeClientQt::exitFullscreenForNode):
1095 * WebCoreSupport/ChromeClientQt.h:
1096 * WebCoreSupport/FullScreenVideoQt.cpp:
1097 (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
1098 (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
1099 (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
1100 (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
1101 (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
1102 (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
1103 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1104 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1105 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1106 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1107 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1108 (WebCore::FullScreenVideoQt::isValid):
1109 * WebCoreSupport/FullScreenVideoQt.h:
1110 (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
1112 2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1114 Reviewed by Kenneth Rohde Christiansen.
1116 [Qt] Improve tests for QWebFrame::url() and related methods
1117 https://bugs.webkit.org/show_bug.cgi?id=57865
1119 * tests/qwebframe/tst_qwebframe.cpp:
1120 (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
1121 (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
1122 that fails and a load() that fails (for a different URL).
1124 (tst_QWebFrame::setUrlWithFragment_data):
1125 (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
1126 the URL in the frame before the test starts.
1128 (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
1129 the same URL as argument.
1132 (tst_QWebFrame::setUrlThenLoads_data):
1133 (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
1134 sequence of set and loads. Those tests are interesting because the properties
1135 react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
1136 is used or after the load() is committed and baseUrl() is similar to url() but also depends
1137 on the contents of the page when it loads.
1139 2011-04-04 MORITA Hajime <morrita@google.com>
1141 Reviewed by Ryosuke Niwa.
1143 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1144 https://bugs.webkit.org/show_bug.cgi?id=56085
1146 * WebCoreSupport/EditorClientQt.h:
1147 (WebCore::EditorClientQt::requestCheckingOfString):
1149 2011-04-04 Chang Shu <cshu@webkit.org>
1151 Reviewed by Ryosuke Niwa.
1153 setContentEditable with true/false/inherit string is not working properly
1154 https://bugs.webkit.org/show_bug.cgi?id=52058
1156 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
1157 as rendererIsEditable is for WebCore internal use.
1159 * WebCoreSupport/EditorClientQt.cpp:
1160 (WebCore::EditorClientQt::handleKeyboardEvent):
1162 2011-04-01 Carol Szabo <carol.szabo@nokia.com>
1164 Reviewed by Benjamin Poulain.
1166 Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
1167 Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
1169 Tiled painting still causes synchronous layout when
1170 accelerated compositing and texture mapper are enabled
1171 https://bugs.webkit.org/show_bug.cgi?id=56929
1173 * Api/qwebframe.cpp:
1174 (QWebFramePrivate::renderFromTiledBackingStore):
1175 (QWebFramePrivate::renderRelativeCoords):
1176 (QWebFramePrivate::renderFrameWidgets):
1177 * Api/qwebframe_p.h:
1179 2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
1181 Reviewed by Benjamin Poulain.
1183 [Qt] DragClientQt.h has coding-style errors
1184 https://bugs.webkit.org/show_bug.cgi?id=40425
1186 * WebCoreSupport/DragClientQt.h:
1188 2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
1190 Reviewed by Kenneth Rohde Christiansen.
1192 [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
1193 https://bugs.webkit.org/show_bug.cgi?id=57017
1195 Build fix. No new tests.
1199 2011-03-31 Evan Martin <evan@chromium.org>
1203 * WebCoreSupport/FrameLoaderClientQt.cpp:
1204 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1206 2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
1208 Reviewed by Benjamin Poulain.
1210 [Qt] ChromeClientQt.h has coding-style errors
1211 https://bugs.webkit.org/show_bug.cgi?id=40239
1213 * WebCoreSupport/ChromeClientQt.h:
1214 (WebCore::ChromeClientQt::scrollbarsModeDidChange):
1215 (WebCore::ChromeClientQt::needTouchEvents):
1216 (WebCore::ChromeClientQt::formStateDidChange):
1217 (WebCore::ChromeClientQt::scrollRectIntoView):
1218 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1219 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1221 2011-03-31 Evan Martin <evan@chromium.org>
1223 Build fix from previous change.
1225 * Api/qwebframe.cpp:
1228 2011-03-31 Evan Martin <evan@chromium.org>
1230 Reviewed by Eric Seidel.
1232 <title> should support dir attribute
1233 https://bugs.webkit.org/show_bug.cgi?id=50961
1235 Update to new FrameLoaderClient interface.
1237 * WebCoreSupport/FrameLoaderClientQt.cpp:
1238 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1239 (WebCore::FrameLoaderClientQt::setTitle):
1240 * WebCoreSupport/FrameLoaderClientQt.h:
1242 2011-03-30 Yi Shen <yi.4.shen@nokia.com>
1244 Reviewed by Kenneth Rohde Christiansen.
1246 [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
1247 https://bugs.webkit.org/show_bug.cgi?id=57020
1249 Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
1251 * tests/qwebview/tst_qwebview.cpp:
1252 (tst_QWebView::focusInputTypes):
1254 2011-03-30 Robert Hogan <robert@webkit.org>
1256 Reviewed by Antonio Gomes.
1258 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1260 Add DRT support for loading an alternate HTML string
1261 for error pages. This allows Qt to unskip
1262 http/tests/navigation/go-back-to-error-page.html.
1264 https://bugs.webkit.org/show_bug.cgi?id=52614
1266 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1267 (DumpRenderTreeSupportQt::setAlternateHtml):
1268 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1270 2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
1272 Unreviewed build fix for build-webkit -minimal.
1274 Breakage introduced by http://trac.webkit.org/changeset/82238.
1275 The minimal option has no support for shortcuts.
1277 * WebCoreSupport/EditorClientQt.cpp:
1278 (WebCore::EditorClientQt::handleInputMethodKeydown):
1280 2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
1282 Reviewed by Kenneth Rohde Christiansen.
1284 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
1285 https://bugs.webkit.org/show_bug.cgi?id=33179
1287 Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
1289 * WebCoreSupport/EditorClientQt.cpp:
1290 (WebCore::EditorClientQt::handleInputMethodKeydown):
1291 * tests/qwebpage/tst_qwebpage.cpp:
1292 (tst_QWebPage::inputMethods):
1294 2011-03-29 Andreas Kling <kling@webkit.org>
1296 Reviewed by Simon Hausmann.
1298 [Qt] Fix documentation for QWebPage::repaintRequested()
1300 This signal is always emitted when the page is dirtied, so remove
1301 reference to old behavior where we would only emit the signal for
1306 2011-03-28 Andreas Kling <kling@webkit.org>
1308 Reviewed by Benjamin Poulain.
1310 [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
1312 * WebCoreSupport/FrameLoaderClientQt.cpp:
1313 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1315 2011-03-28 Andreas Kling <kling@webkit.org>
1317 Reviewed by Benjamin Poulain.
1319 [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
1320 https://bugs.webkit.org/show_bug.cgi?id=52629
1322 * WebCoreSupport/ChromeClientQt.cpp:
1323 (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
1324 QWebPage::repaintRequested() use a Qt::QueuedConnection.
1326 * tests/qwebpage/tst_qwebpage.cpp:
1327 (RepaintRequestedRenderer::RepaintRequestedRenderer):
1328 (RepaintRequestedRenderer::onRepaintRequested):
1329 (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
1330 QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
1331 doesn't cause recursive signal emissions.
1333 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
1335 Reviewed by Andreas Kling.
1337 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1338 https://bugs.webkit.org/show_bug.cgi?id=57087
1340 * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
1341 * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
1342 since they are applications, not libraries.
1344 2011-03-28 Andras Becsi <abecsi@webkit.org>
1346 Reviewed by Csaba Osztrogonác.
1348 [Qt] QtWebKit does not link with --3d-canvas using MinGW
1349 https://bugs.webkit.org/show_bug.cgi?id=57225
1351 * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
1353 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
1355 Reviewed by Andreas Kling.
1357 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
1358 https://bugs.webkit.org/show_bug.cgi?id=57183
1360 Windows buildfix after r82065.
1362 * Api/DerivedSources.pro: Readding escaping on Windows platforms.
1364 2011-03-27 Andreas Kling <kling@webkit.org>
1366 Fix build warning about IconDatabaseClient.h (wrong path.)
1370 2011-03-27 Andreas Kling <kling@webkit.org>
1372 Reviewed by Kenneth Rohde Christiansen.
1374 [Qt] Support for CSS color and background-color properties on select element's dropdown list
1375 https://bugs.webkit.org/show_bug.cgi?id=51627
1377 Extend the QWebSelectData interface with background and foreground colors
1378 for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
1379 getters in RenderMenuList.
1381 * Api/qwebkitplatformplugin.h:
1382 * WebCoreSupport/PopupMenuQt.cpp:
1383 (SelectData::backgroundColor):
1384 (SelectData::foregroundColor):
1385 (SelectData::itemBackgroundColor):
1386 (SelectData::itemForegroundColor):
1387 * WebCoreSupport/QtFallbackWebPopup.cpp:
1388 (WebCore::QtFallbackWebPopup::show):
1389 (WebCore::QtFallbackWebPopup::populate):
1391 2011-03-27 Yi Shen <yi.4.shen@nokia.com>
1393 Reviewed by Andreas Kling.
1395 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
1396 https://bugs.webkit.org/show_bug.cgi?id=57108
1398 Since the canvas is not self-closing tag, we need to add '</canvas>'.
1400 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1401 (tst_QGraphicsWebView::microFocusCoordinates):
1402 * tests/qwebview/tst_qwebview.cpp:
1403 (tst_QWebView::microFocusCoordinates):
1405 2011-03-27 Kwang Yul Seo <skyul@company100.net>
1407 Reviewed by Eric Seidel.
1409 [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
1410 https://bugs.webkit.org/show_bug.cgi?id=57143
1412 Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
1413 define WTF_USE_TEXTURE_MAPPER=1.
1417 2011-03-27 Andreas Kling <kling@webkit.org>
1419 Reviewed by Benjamin Poulain.
1421 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
1422 https://bugs.webkit.org/show_bug.cgi?id=57183
1424 The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
1425 which was due to the outputting code previously being wrapped in eval().
1427 * Api/DerivedSources.pro:
1429 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
1431 Reviewed by Andreas Kling.
1433 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1434 https://bugs.webkit.org/show_bug.cgi?id=57087
1436 Use explicit conversion for string to avoid depending on the default codec
1437 installed by the user code.
1439 * Api/qwebkitversion.cpp:
1442 (QWebPagePrivate::dynamicPropertyChangeEvent):
1443 (QWebPage::javaScriptConsoleMessage):
1444 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1445 (convertToPropertyName):
1446 (DumpRenderTreeSupportQt::setEditingBehavior):
1447 (DumpRenderTreeSupportQt::plainText):
1448 * WebCoreSupport/EditorClientQt.cpp:
1450 * WebCoreSupport/FrameLoaderClientQt.cpp:
1451 (drtDescriptionSuitableForTestResult):
1452 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1453 * WebCoreSupport/InspectorClientQt.cpp:
1454 (WebCore::InspectorClientQt::openInspectorFrontend):
1455 * WebCoreSupport/InspectorServerQt.cpp:
1456 (WebCore::parseWebSocketChallengeNumber):
1457 (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
1459 2011-03-26 Andreas Kling <kling@webkit.org>
1461 Reviewed by Kenneth Rohde Christiansen.
1463 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
1464 https://bugs.webkit.org/show_bug.cgi?id=57157
1466 Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
1467 is always emitted when appropriate.
1469 * QtWebKit.pro: Add new files.
1471 * WebCoreSupport/IconDatabaseClientQt.h: Added.
1472 * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
1473 (WebCore::IconDatabaseClientQt::instance):
1474 (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
1475 (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
1476 (WebCore::IconDatabaseClientQt::performImport):
1477 (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
1478 (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
1479 (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
1480 (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
1481 (WebCore::IconDatabaseClientQt::didFinishURLImport):
1483 * WebCoreSupport/FrameLoaderClientQt.h:
1484 * WebCoreSupport/FrameLoaderClientQt.cpp:
1485 (WebCore::FrameLoaderClientQt::registerForIconNotification):
1486 (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
1487 to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
1488 QWebFrame::iconChanged() signal when the IconDatabases finishes loading
1489 a cached favicon for the frame's URL.
1491 * Api/qwebsettings.cpp:
1492 (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
1493 instantiated. An IconDatabaseClient has to be registered before the IconDatabase
1494 spawns its reader thread.
1496 2011-03-25 Andy Estes <aestes@apple.com>
1498 Reviewed by Adele Peterson.
1500 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1501 https://bugs.webkit.org/show_bug.cgi?id=49016
1503 Update objectContentType() implementation to handle the
1504 shouldPreferPlugInsForImages flag.
1506 * WebCoreSupport/FrameLoaderClientQt.cpp:
1507 (WebCore::FrameLoaderClientQt::objectContentType):
1508 * WebCoreSupport/FrameLoaderClientQt.h:
1510 2011-03-25 Chang Shu <cshu@webkit.org>
1512 Reviewed by Ryosuke Niwa.
1514 rename Node::isContentEditable and all call sites to rendererIsEditable
1515 https://bugs.webkit.org/show_bug.cgi?id=54290
1517 This is part of the effort to separate JS API HTMLElement isContentEditable from
1518 internal Node::rendererIsEditable.
1520 * WebCoreSupport/EditorClientQt.cpp:
1521 (WebCore::EditorClientQt::handleKeyboardEvent):
1523 2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
1525 Reviewed by Andreas Kling.
1527 [Qt] The keyboard shortcuts during fullscreen playback do not work.
1528 https://bugs.webkit.org/show_bug.cgi?id=57095
1530 We need to explicitely set the focus on the widget in order to receive the keyboard events.
1532 * WebCoreSupport/FullScreenVideoWidget.cpp:
1533 (WebCore::FullScreenVideoWidget::show):
1535 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
1537 Unreviewed, rolling out r81916 and r81917.
1538 http://trac.webkit.org/changeset/81916
1539 http://trac.webkit.org/changeset/81917
1540 https://bugs.webkit.org/show_bug.cgi?id=57071
1542 broke a test on platforms that do not have QuickTime installed
1543 (Requested by estes on #webkit).
1545 * WebCoreSupport/FrameLoaderClientQt.cpp:
1546 (WebCore::FrameLoaderClientQt::objectContentType):
1547 * WebCoreSupport/FrameLoaderClientQt.h:
1549 2011-03-24 Andy Estes <aestes@apple.com>
1551 Reviewed by Darin Adler.
1553 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1554 https://bugs.webkit.org/show_bug.cgi?id=49016
1556 Update objectContentType() implementation to handle the
1557 shouldPreferPlugInsForImages flag.
1559 * WebCoreSupport/FrameLoaderClientQt.cpp:
1560 (WebCore::FrameLoaderClientQt::objectContentType):
1561 * WebCoreSupport/FrameLoaderClientQt.h:
1563 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
1565 Reviewed by Kenneth Rohde Christiansen.
1567 [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
1568 https://bugs.webkit.org/show_bug.cgi?id=40884
1570 Add tests and benchmarks for the software fallback of WebGL.
1572 * tests/benchmarks/webgl/10000_triangles.html: Added.
1573 * tests/benchmarks/webgl/tst_webgl.cpp: Added.
1574 (GraphicsView::GraphicsView):
1575 (GraphicsView::resizeEvent):
1576 (tst_WebGlPerformance::init):
1577 (tst_WebGlPerformance::cleanup):
1578 (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
1579 (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
1580 (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
1581 (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
1582 (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
1583 * tests/benchmarks/webgl/tst_webgl.qrc: Added.
1584 * tests/benchmarks/webgl/webgl.pro: Added.
1585 * tests/qgraphicswebview/qgraphicswebview.pro:
1586 * tests/qgraphicswebview/resources/pointing_right.html: Added.
1587 * tests/qgraphicswebview/resources/pointing_up.html: Added.
1588 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1589 (compareImagesFuzzyPixelCount):
1590 (GraphicsView::GraphicsView):
1591 (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
1592 (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
1593 (tst_QGraphicsWebView::compareCanvasToImage):
1594 * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
1597 2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
1599 Reviewed by Benjamin Poulain.
1601 Avoided ASCII-cast warnings for WebKit.
1603 Normally they won't be enabled anyway, but if you build webkit from
1604 within the Qt mother repository it will pick up Qt's default build
1605 settings, which do enable it. We need to disable them because
1606 warnings are treated as errors and there are way too many of them in
1609 [Qt] Avoid ASCII-cast warnings for WebKit.
1610 https://bugs.webkit.org/show_bug.cgi?id=57016
1614 2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1616 Reviewed by Benjamin Poulain.
1618 [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
1619 https://bugs.webkit.org/show_bug.cgi?id=29595
1621 Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
1622 ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
1623 prepending the current directory.
1625 By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
1626 will end up loading "about:blank", but keeping it as a requested URL.
1628 This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
1629 is filled for the loaded URLs as well, we can use it in every case.
1631 Three new autotests were added, to better cover the expected behavior of setting
1632 the QUrl() in a QWebFrame.
1634 * Api/qwebframe.cpp:
1635 (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
1636 (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
1638 * WebCoreSupport/FrameLoaderClientQt.cpp:
1639 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
1640 anymore, since we always rely on it even for loaded frames.
1642 * tests/qwebframe/tst_qwebframe.cpp:
1643 (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
1644 the reduction of the bug report.
1645 (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
1646 (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
1648 2011-03-23 Brady Eidson <beidson@apple.com>
1650 Reviewed by Sam Weinig.
1652 Change IconDatabase opening to allow for arbitrary filenames
1653 https://bugs.webkit.org/show_bug.cgi?id=56977
1655 * Api/qwebsettings.cpp:
1656 (QWebSettings::setIconDatabasePath):
1658 2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
1660 Reviewed by Andreas Kling.
1662 [Qt] QtWebKit rendering problem when maximizing and doing a back
1663 https://bugs.webkit.org/show_bug.cgi?id=56669
1666 Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
1668 * tests/qwebview/tst_qwebview.cpp:
1669 (tst_QWebView::rendering):
1671 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
1673 Reviewed by Pavel Feldman.
1675 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1676 https://bugs.webkit.org/show_bug.cgi?id=56843
1678 * WebCoreSupport/InspectorClientQt.cpp:
1679 (WebCore::InspectorClientQt::openInspectorFrontend):
1681 2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
1683 Reviewed by Benjamin Poulain.
1685 [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
1686 https://bugs.webkit.org/show_bug.cgi?id=54138
1688 * tests/qwebpage/tst_qwebpage.cpp:
1689 (webGLScreenshotWithoutView):
1690 (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
1691 (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
1692 Render a QWebPage (with and without accelerated compositing)
1693 with a WebGL context that has no owning view. Shouldn't crash.
1695 2011-03-21 Chang Shu <cshu@webkit.org>
1697 Reviewed by Alexey Proskuryakov.
1699 REGRESSION (r79953): Can't type in MS Outlook 2011
1700 https://bugs.webkit.org/show_bug.cgi?id=56665
1702 r79953 removed the WebView level editablity which is persistent no matter whether
1703 underlying document itself is changed and editability gets lost. The resolution is to
1704 set this WebView editable value to WebCore. This avoids the callback from WebCore to
1705 WebKit which was the main goal in r79953 to improve performance.
1708 (QWebPage::setContentEditable):
1709 (QWebPage::isContentEditable):
1711 2011-03-19 Andreas Kling <kling@webkit.org>
1713 Reviewed by Benjamin Poulain.
1715 [Qt] Remove support for Qt 4.6
1716 https://bugs.webkit.org/show_bug.cgi?id=56712
1718 * Api/qwebframe.cpp:
1721 (QWebPagePrivate::QWebPagePrivate):
1722 * Api/qwebsettings.cpp:
1723 (QWebSettings::QWebSettings):
1724 * WebCoreSupport/GeolocationClientQt.cpp:
1725 (WebCore::GeolocationClientQt::positionUpdated):
1727 2011-03-19 Andreas Kling <kling@webkit.org>
1729 Reviewed by Antonio Gomes.
1731 [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
1732 https://bugs.webkit.org/show_bug.cgi?id=56711
1734 Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
1735 ownership of the reply is transferred to the receiving slot.
1739 2011-03-17 Brady Eidson <beidson@apple.com>
1741 Reviewed by Sam Weinig.
1743 https://bugs.webkit.org/show_bug.cgi?id=56425
1744 More groundwork for WebKit2 IconDatabase
1746 Update already-used function names:
1747 * Api/qwebhistory.cpp:
1748 (QWebHistoryItem::icon):
1749 * Api/qwebsettings.cpp:
1750 (QWebSettings::iconForUrl):
1752 2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
1754 Reviewed by Benjamin Poulain.
1756 [Qt] console.log not being exposed to QmlViewer
1757 https://bugs.webkit.org/show_bug.cgi?id=56536
1759 The documentation is bogus the feature does not exist.
1761 * declarative/qdeclarativewebview.cpp:
1763 2011-03-17 Andreas Kling <kling@webkit.org>
1765 Reviewed by Kenneth Rohde Christiansen.
1767 [Qt] QML WebView emits iconChanged() when the page title changes
1768 https://bugs.webkit.org/show_bug.cgi?id=56570
1770 * declarative/qdeclarativewebview.cpp:
1771 (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
1772 signal to the view's iconChanged signal.
1774 2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
1776 Reviewed by Benjamin Poulain.
1778 [Qt] Videos look ugly when using QGraphicsWebView.
1779 https://bugs.webkit.org/show_bug.cgi?id=56580
1781 We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
1782 QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
1783 by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
1784 QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
1785 ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
1786 in addition of what could be set on the painter. In order to not break the rendering of all the items in the
1787 scene we set back the painter to its original state when QGraphicsWebView is rendered.
1789 * Api/qgraphicswebview.cpp:
1790 (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
1791 (QGraphicsWebView::paint):
1792 (QGraphicsWebView::renderHints):
1793 (QGraphicsWebView::setRenderHints):
1794 (QGraphicsWebView::setRenderHint):
1795 * Api/qgraphicswebview.h:
1796 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1797 (tst_QGraphicsWebView::renderHints):
1799 2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
1801 Reviewed by Kenneth Rohde Christiansen.
1803 Viewport no longer allows an auto value for "user-scalable"
1804 https://bugs.webkit.org/show_bug.cgi?id=55416
1806 Make the default value for userScalable be true.
1809 (QWebPage::viewportAttributesForSize):
1810 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1811 (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
1813 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
1815 Reviewed by Darin Adler.
1817 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1818 info into the headers rather than in export symbol definition files, but disable it on
1819 all platforms initially so we can deal with port build issues one port at a time.
1821 https://bugs.webkit.org/show_bug.cgi?id=27551
1823 * WebCoreSupport/GeolocationClientQt.cpp:
1824 * WebCoreSupport/PopupMenuQt.cpp:
1826 2011-03-14 Brady Eidson <beidson@apple.com>
1828 Reviewed by Anders Carlsson.
1830 https://bugs.webkit.org/show_bug.cgi?id=56320
1831 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
1833 * Api/qwebhistory.cpp:
1834 (QWebHistoryItem::icon): Use IconDatabase directly.
1836 2011-03-11 Brady Eidson <beidson@apple.com>
1838 Reviewed by attempt at build fix!
1840 https://bugs.webkit.org/show_bug.cgi?id=56216
1841 Fix the Qt build following the same pattern of the patch.
1843 * Api/qwebsettings.cpp:
1844 (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
1846 2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
1848 Reviewed by Ariya Hidayat.
1850 [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
1851 https://bugs.webkit.org/show_bug.cgi?id=56181
1853 We need to stop the auto hide cursor timer when closing the widget otherwise the timer
1854 might get fired and therefore hide the cursor even when the fullscreen widget is closed.
1856 * WebCoreSupport/FullScreenVideoWidget.cpp:
1857 (WebCore::FullScreenVideoWidget::closeEvent):
1859 2011-03-10 David Boddie <david.boddie@nokia.com>
1861 Reviewed by Andreas Kling.
1863 Fixed a qdoc warning and terminology (WebKit instead of Webkit).
1864 https://bugs.webkit.org/show_bug.cgi?id=55756
1866 * Api/qwebhistoryinterface.cpp:
1868 2011-03-10 Andreas Kling <kling@webkit.org>
1870 Unreviewed build fix after r80774.
1872 QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
1873 See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
1875 * declarative/plugin.cpp:
1876 (WebKitQmlPlugin::registerTypes):
1877 * declarative/qdeclarativewebview.cpp:
1878 * declarative/qdeclarativewebview_p.h:
1879 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1881 2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
1883 Reviewed by Andreas Kling.
1885 [Qt] QtDeclarative Webview element has a fixed white background
1886 https://bugs.webkit.org/show_bug.cgi?id=40918
1888 Implement a way to change the background color of the WebView QML element.
1889 This feature is activated for QtWebKit 1.1 version of the plugin.
1891 * declarative/plugin.cpp:
1892 (WebKitQmlPlugin::registerTypes):
1893 * declarative/qdeclarativewebview.cpp:
1894 (QDeclarativeWebView::backgroundColor):
1895 (QDeclarativeWebView::setBackgroundColor):
1896 * declarative/qdeclarativewebview_p.h:
1897 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
1898 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1899 (tst_QDeclarativeWebView::backgroundColor):
1900 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1902 2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
1904 Reviewed by Laszlo Gombos.
1906 [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
1907 https://bugs.webkit.org/show_bug.cgi?id=55945
1909 Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
1910 set interval used to trigger when decoded data in dead list of object cache will
1911 be purged from object cache.
1914 (QWebPagePrivate::dynamicPropertyChangeEvent):
1916 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1918 Reviewed by Antonio Gomes.
1920 Simplify how QWebFrame::requestedUrl() is obtained
1921 https://bugs.webkit.org/show_bug.cgi?id=55842
1923 When a load starts, store the requested URL until we know that it'll be
1924 available for us in the document loader -- after load finished.
1926 The existing auto tests cover the three different code paths in
1927 requestedUrl() and the new code passes the autotests. In each of those
1928 cases, we looked for the information in a different place, but in all
1929 of them, dispatchDidStartProvisionalLoad was called.
1931 This simplification will be useful to fix bug 32723. The way requestedUrl()
1932 is implementent, we can't use it as a fallback for url() when the setUrl()
1933 was called with an invalid URL.
1935 * Api/qwebframe.cpp:
1936 (QWebFrame::requestedUrl):
1937 * WebCoreSupport/FrameLoaderClientQt.cpp:
1938 (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
1939 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
1940 * WebCoreSupport/FrameLoaderClientQt.h:
1941 (WebCore::FrameLoaderClientQt::lastRequestedUrl):
1943 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1945 Reviewed by Kenneth Rohde Christiansen.
1947 Tiled backing store's delegated scroll request uses incorrect convention
1948 https://bugs.webkit.org/show_bug.cgi?id=56011
1950 Adapt internal API to match the change from delta to point on the
1951 WebCore side, and convert the point to a delta for the public API.
1953 * WebCoreSupport/ChromeClientQt.cpp:
1954 (WebCore::ChromeClientQt::delegatedScrollRequested):
1955 * WebCoreSupport/ChromeClientQt.h:
1957 2011-03-09 Peter Kasting <pkasting@google.com>
1959 Reviewed by Mihai Parparita.
1961 Unify Windows version checks.
1962 https://bugs.webkit.org/show_bug.cgi?id=55979
1965 (QWebPage::userAgentForUrl):
1967 2011-03-07 Sam Weinig <sam@webkit.org>
1969 Reviewed by Anders Carlsson.
1971 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1972 https://bugs.webkit.org/show_bug.cgi?id=55827
1974 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1975 and pass the entire response, instead of just the MIMEType.
1977 * WebCoreSupport/FrameLoaderClientQt.cpp:
1978 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1979 * WebCoreSupport/FrameLoaderClientQt.h:
1981 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
1983 Reviewed by Laszlo Gombos.
1985 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
1986 https://bugs.webkit.org/show_bug.cgi?id=48636
1988 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
1991 (QWebPage::userAgentForUrl):
1993 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
1995 Reviewed by Kenneth Rohde Christiansen.
1997 [QT] Implement mock client-based geolocation for layout testing
1998 https://bugs.webkit.org/show_bug.cgi?id=54334
2000 Implement layout testing for Client-Based geolocation. If drt_run is set
2001 then create mock geolocationClient and update the same with controller.
2004 (QWebPagePrivate::QWebPagePrivate):
2005 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2006 (DumpRenderTreeSupportQt::mockGeolocationReset):
2007 (DumpRenderTreeSupportQt::setMockGeolocationPermission):
2008 (DumpRenderTreeSupportQt::setMockGeolocationPosition):
2009 (DumpRenderTreeSupportQt::setMockGeolocationError):
2010 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011 * WebCoreSupport/GeolocationClientQt.cpp:
2012 (WebCore::GeolocationClientQt::GeolocationClientQt):
2013 * WebCoreSupport/GeolocationClientQt.h:
2015 2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2017 Reviewed by Kenneth Rohde Christiansen.
2019 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
2020 https://bugs.webkit.org/show_bug.cgi?id=32723
2022 Create an auto-test for Qt based on the bug description.
2024 * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
2026 2011-03-03 Brady Eidson <beidson@apple.com>
2028 Reviewed by Darin Adler.
2030 https://bugs.webkit.org/show_bug.cgi?id=55721
2031 Global IconDatabase should be returned by reference, not as a pointer
2033 * Api/qwebsettings.cpp:
2034 (QWebSettings::setIconDatabasePath):
2035 (QWebSettings::iconDatabasePath):
2036 (QWebSettings::clearIconDatabase):
2037 (QWebSettings::iconForUrl):
2039 2011-03-03 Alexey Proskuryakov <ap@apple.com>
2041 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2044 * WebCoreSupport/ChromeClientQt.h:
2046 2011-03-02 Alexey Proskuryakov <ap@apple.com>
2048 Reviewed by Darin Adler.
2050 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2051 https://bugs.webkit.org/show_bug.cgi?id=55633
2052 <rdar://problem/8963023>
2054 * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
2055 * WebCoreSupport/ChromeClientQt.h:
2056 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2057 this platform doesn't observe or have full keyboard access state.
2059 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
2061 Reviewed by Andreas Kling.
2063 [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
2064 https://bugs.webkit.org/show_bug.cgi?id=55568
2066 We should use updateMicroFocus() from QGraphicsItem rather than the implementation
2067 in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
2068 In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
2071 * Api/qgraphicswebview.cpp:
2072 (QGraphicsWebView::setPage):
2073 * Api/qgraphicswebview.h:
2075 2011-03-03 Peter Kasting <pkasting@google.com>
2077 Reviewed by James Robinson.
2079 Drop redundant "Windows; " from the Windows-specific User Agent string.
2080 https://bugs.webkit.org/show_bug.cgi?id=54567
2083 (QWebPage::userAgentForUrl):
2085 2011-03-01 Brian Weinstein <bweinstein@apple.com>
2087 Reviewed by Adam Roben.
2089 Part of WebKit2: Need a way to send notifications to client when cookies change
2090 https://bugs.webkit.org/show_bug.cgi?id=55427
2091 <rdar://problem/9056027>
2093 Add stubs for CookiesStrategy on Qt WebKit1.
2095 * WebCoreSupport/WebPlatformStrategies.cpp:
2096 (WebPlatformStrategies::createCookiesStrategy):
2097 (WebPlatformStrategies::notifyCookiesChanged):
2098 * WebCoreSupport/WebPlatformStrategies.h:
2100 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2102 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
2105 (QWebPage::viewportAttributesForSize):
2106 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2107 (DumpRenderTreeSupportQt::viewportAsText):
2109 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2111 Reviewed by Kenneth Rohde Christiansen.
2113 Viewport Warning/Error Messages Are Now Inaccurate
2114 https://bugs.webkit.org/show_bug.cgi?id=53707
2117 (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
2118 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2119 (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
2121 2011-03-01 Andras Becsi <abecsi@webkit.org>
2123 Reviewed by Csaba Osztrogonác.
2125 [Qt] Clean up the project files and move common options to WebKit.pri.
2127 * QtWebKit.pro: Move common options to WebKit.pri.
2129 2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
2131 Reviewed by Simon Hausmann.
2133 [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
2134 https://bugs.webkit.org/show_bug.cgi?id=55319
2136 The test case required internet connection to be able to connect to
2137 google.com. Added new html file which refers to local html file.
2139 * tests/qwebpage/resources/content.html: Added.
2140 * tests/qwebpage/resources/frame_c.html: Added.
2141 * tests/qwebpage/resources/framedindex.html: Added.
2142 * tests/qwebpage/tst_qwebpage.cpp:
2143 (tst_QWebPage::backActionUpdate):
2144 * tests/qwebpage/tst_qwebpage.qrc:
2146 2011-02-25 Steve Block <steveblock@google.com>
2148 Reviewed by Jeremy Orlow.
2150 Bridge.h should not include BridgeJSC.h
2151 https://bugs.webkit.org/show_bug.cgi?id=55212
2153 Include BridgeJSC.h directly instead.
2155 * Api/qwebframe.cpp:
2157 2011-02-28 Chang Shu <cshu@webkit.org>
2159 Reviewed by Ryosuke Niwa.
2161 Remove the support of Frame::isContentEditable and its dependencies.
2162 https://bugs.webkit.org/show_bug.cgi?id=54292
2164 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2167 (QWebPagePrivate::QWebPagePrivate):
2168 (QWebPage::setContentEditable):
2169 (QWebPage::isContentEditable):
2171 * WebCoreSupport/EditorClientQt.cpp:
2172 * WebCoreSupport/EditorClientQt.h:
2174 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2176 Reviewed by Oliver Hunt.
2178 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
2180 * Api/qwebelement.cpp:
2181 (QWebElement::evaluateJavaScript):
2183 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2185 Reviewed by Andreas Kling.
2187 [Qt]tst_QDeclarativeWebView - 8 test cases fail
2188 https://bugs.webkit.org/show_bug.cgi?id=55214
2190 Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
2191 if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
2192 I also refactored the tests so we don't use the network but instead a local html file.
2193 QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
2195 * tests/qdeclarativewebview/resources/sample.html: Added.
2196 * tests/qdeclarativewebview/resources/webviewtest.qml:
2197 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
2198 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2199 (tst_QDeclarativeWebView::preferredWidthTest):
2200 (tst_QDeclarativeWebView::preferredHeightTest):
2201 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
2202 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
2203 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2205 2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
2207 Reviewed by Andreas Kling.
2209 [Qt] Add clipped version of QWebElement::render method.
2210 Allows faster rendering of web element part.
2211 https://bugs.webkit.org/show_bug.cgi?id=50311
2213 * Api/qwebelement.cpp:
2214 (QWebElement::render):
2215 * Api/qwebelement.h:
2216 * tests/qwebelement/tst_qwebelement.cpp:
2217 (tst_QWebElement::render):
2219 2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
2221 Reviewed by Andreas Kling.
2223 Added full webkit module profile and a syncqt profile.
2225 This is for modularized Qt.
2227 [Qt] WebKit patches required to work with a modularized version of Qt
2228 https://bugs.webkit.org/show_bug.cgi?id=53916
2230 * qt_webkit_version.pri:
2232 2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
2234 Reviewed by Antonio Gomes.
2236 [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
2237 https://bugs.webkit.org/show_bug.cgi?id=53917
2239 Adding test case to check the scenario to avoid regressions in the
2242 * tests/qwebframe/tst_qwebframe.cpp:
2244 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2246 Reviewed by Andreas Kling.
2248 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
2249 https://bugs.webkit.org/show_bug.cgi?id=55322
2251 Documentation update, add a reference to the QtWebKit bridge page.
2253 * Api/qwebframe.cpp:
2255 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2257 Reviewed by Pavel Feldman.
2259 DumpRenderTree should reset frame opener between tests.
2260 https://bugs.webkit.org/show_bug.cgi?id=54874
2262 Added clearOpener method to DumpRenderTreeSupportQT.
2264 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2265 (DumpRenderTreeSupportQt::clearOpener):
2266 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2268 2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
2270 Reviewed by Andreas Kling.
2272 Make it possible to test the targetdensity-dpi support
2273 https://bugs.webkit.org/show_bug.cgi?id=55142
2275 Test the viewport meta tag feature targetdensity-dpi by
2276 adding extra arguments to dumpConfigurationForViewport
2278 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2279 (DumpRenderTreeSupportQt::viewportAsText):
2280 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2282 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
2284 Unreviewed, rolling out r79764.
2285 http://trac.webkit.org/changeset/79764
2286 https://bugs.webkit.org/show_bug.cgi?id=55295
2288 "broke Chromium builds" (Requested by rniwa on #webkit).
2290 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2291 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2293 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2295 Reviewed by Pavel Feldman.
2297 DumpRenderTree should reset frame opener between tests.
2298 https://bugs.webkit.org/show_bug.cgi?id=54874
2300 Added clearOpener method to DumpRenderTreeSupportQT.
2302 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2303 (DumpRenderTreeSupportQt::clearOpener):
2304 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2306 2011-02-25 Andras Becsi <abecsi@webkit.org>
2308 Reviewed by Csaba Osztrogonác.
2310 [Qt] Make the WebKit2 build system less confusing for non-Qt developers
2311 https://bugs.webkit.org/show_bug.cgi?id=55213
2313 * QtWebKit.pro: Move the WebKit2 API into a project include file
2314 in the WebKit2 directory and include the pri file here.
2316 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
2318 Unreviewed build fix for Intel ICC and MSVC.
2320 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2321 (tst_QGraphicsWebView::setPalette):
2322 * tests/qwebview/tst_qwebview.cpp:
2323 (tst_QWebView::setPalette):
2325 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
2327 Reviewed by Kenneth Rohde Christiansen.
2329 [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
2330 https://bugs.webkit.org/show_bug.cgi?id=31742
2332 Discovered while looking at 31742. When we set a palette on the
2333 QGraphicsWebView we need to propagate it to the page like QWebView.
2334 I have added the same tests as QWebView to be sure to catch potential
2335 regressions as well as two extras QVERIFY to check the palette propagation.
2337 * Api/qgraphicswebview.cpp:
2338 (QGraphicsWebView::event):
2339 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2340 (tst_QGraphicsWebView::setPalette_data):
2341 (tst_QGraphicsWebView::setPalette):
2343 2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
2345 Unreviewed buildfix after r79672.
2347 [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
2352 2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
2354 Reviewed by Kenneth Rohde Christiansen.
2356 [Qt] QML WebView inside a Flickable shows checkers pattern at startup
2357 https://bugs.webkit.org/show_bug.cgi?id=50222.
2359 This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
2361 * declarative/qdeclarativewebview.cpp:
2362 (QDeclarativeWebView::init):
2363 * tests/qdeclarativewebview: Added.
2364 * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
2365 * tests/qdeclarativewebview/resources: Added.
2366 * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
2367 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
2368 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
2369 (tst_QDeclarativeWebView::initTestCase):
2370 (tst_QDeclarativeWebView::cleanupTestCase):
2371 (tst_QDeclarativeWebView::init):
2372 (tst_QDeclarativeWebView::cleanup):
2373 (tst_QDeclarativeWebView::preferredWidthTest):
2374 (tst_QDeclarativeWebView::preferredHeightTest):
2375 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
2376 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
2377 (tst_QDeclarativeWebView::checkNoErrors):
2381 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
2383 Reviewed by Andreas Kling.
2385 [Qt] Revert the support for QNAM affined to a different thread.
2386 https://bugs.webkit.org/show_bug.cgi?id=55149
2388 Qt 4.8 will have QNAM use its own thread internally by default,
2389 no need to keep this complexity in WebKit.
2391 This mainly reverts:
2392 http://trac.webkit.org/changeset/73710
2393 http://trac.webkit.org/changeset/73712
2395 * WebCoreSupport/FrameLoaderClientQt.cpp:
2396 (WebCore::FrameLoaderClientQt::download):
2397 * tests/qwebpage/tst_qwebpage.cpp:
2399 2011-02-24 Sam Weinig <sam@webkit.org>
2401 Try to fix the Qt build.
2405 2011-02-24 Peter Kasting <pkasting@google.com>
2407 Reviewed by Eric Seidel.
2409 Drop the "U; " encryption level from the User Agent string.
2410 https://bugs.webkit.org/show_bug.cgi?id=54566
2413 (QWebPage::userAgentForUrl):
2415 2011-02-24 Andrew Wilson <atwilson@chromium.org>
2417 Unreviewed, rolling out r79570.
2418 http://trac.webkit.org/changeset/79570
2419 https://bugs.webkit.org/show_bug.cgi?id=54874
2421 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2424 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2425 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2427 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
2429 Reviewed by Alexey Proskuryakov.
2431 DumpRenderTree should reset frame opener between tests.
2432 https://bugs.webkit.org/show_bug.cgi?id=54874
2434 Added clearOpener method to DumpRenderTreeSupportQT.
2436 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2437 (DumpRenderTreeSupportQt::clearOpener):
2438 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2440 2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
2442 Reviewed by Andreas Kling.
2444 [Qt] tst_QWebView::setPalette(activeFG) fails
2445 https://bugs.webkit.org/show_bug.cgi?id=55029
2447 This time it should be the proper fix. The window needs to be shown before we
2448 call activateWindow() otherwise there is no active windows for the application.
2450 * tests/qwebview/tst_qwebview.cpp:
2451 (tst_QWebView::setPalette):
2453 2011-02-24 Andras Becsi <abecsi@webkit.org>
2455 Reviewed by Laszlo Gombos.
2457 [Qt] MinGW build fails to link
2458 https://bugs.webkit.org/show_bug.cgi?id=55050
2460 Prepend the libraries of subcomponents instead of appending them
2461 to fix the library order according to the dependency of the libraries
2463 * QtWebKit.pro: prepend libraries in the correct order
2465 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
2467 Reviewed by Ariya Hidayat.
2469 [Qt] tst_QWebView::setPalette(activeFG) fails
2470 https://bugs.webkit.org/show_bug.cgi?id=55029
2472 Attempt to make the test more robust. By investigating with the bot virtual machine
2473 I discovered that the activation can take some time. In this patch we make sure that
2474 the active window we want to have is the same as the QApplication.
2476 * tests/qwebview/tst_qwebview.cpp:
2477 (tst_QWebView::setPalette):
2479 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
2481 Reviewed by Dan Bernstein.
2483 [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
2484 http://trac.webkit.org/changeset/79167 refactored the way the bound size of
2485 the frame is handled. A new API setBoundsSize was added, we need to call it
2486 in addition to setFrameRect. I could call setBoundSize after setFrameRect but
2487 I thought It would be more elegant to use the resize method.
2490 (QWebPage::setViewportSize):
2492 2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
2494 Reviewed by Laszlo Gombos.
2496 [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
2497 https://bugs.webkit.org/show_bug.cgi?id=54976
2501 * WebCoreSupport/InspectorClientQt.cpp:
2503 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
2505 Reviewed by Andreas Kling.
2507 [Qt] QWebView ignores a palette set with QWebView::setPalette()
2508 https://bugs.webkit.org/show_bug.cgi?id=31742
2510 Test case to check that the palette sets on the QWebView is taken
2513 * tests/qwebview/tst_qwebview.cpp:
2514 (tst_QWebView::setPalette_data):
2515 (tst_QWebView::setPalette):
2517 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2519 Reviewed by Alexey Proskuryakov.
2521 Drop the language tag part from the User Agent string
2522 https://bugs.webkit.org/show_bug.cgi?id=54560
2525 (QWebPage::userAgentForUrl):
2527 * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
2530 2011-02-22 Chang Shu <cshu@webkit.org>
2532 Reviewed by Csaba Osztrogonác.
2534 [Qt] editing/deleting/5408255.html fails
2535 https://bugs.webkit.org/show_bug.cgi?id=54964
2537 Move WebCore resource file to QtWebKit since they are referred in WebKit.
2541 2011-02-22 Andras Becsi <abecsi@webkit.org>
2543 Reviewed by Csaba Osztrogonác.
2545 [Qt] Redesign the build system
2546 https://bugs.webkit.org/show_bug.cgi?id=51339
2548 Move inspector's resource files into the final build step to fix the layout test regression.
2550 * QtWebKit.pro: Add inspector's reaource files.
2552 2011-02-22 Andras Becsi <abecsi@webkit.org>
2554 Reviewed by Laszlo Gombos.
2555 Rubber-stamped by Csaba Osztrogonác.
2557 [Qt] Redesign the build system
2558 https://bugs.webkit.org/show_bug.cgi?id=51339
2560 The patch landed in r79320 didn't contain the cleanup
2561 which was already addressed in the last attachment.
2563 * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
2565 2011-02-22 Andras Becsi <abecsi@webkit.org>
2567 Reviewed by Laszlo Gombos.
2569 [Qt] Redesign the build system
2570 https://bugs.webkit.org/show_bug.cgi?id=51339
2574 Build WebCore as a static library, compile the WebKit API and WebKit2 API
2575 in a final step and link to WebKit2, WebCore and JSC libraries to fix
2576 linking issues resulting from stripped away symbols.
2578 * QtWebKit.pro: Added.
2579 Project file for the final build step.
2581 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
2583 Reviewed by Kent Tamura.
2585 Rename Position::node() to Position::deprecatedNode()
2586 https://bugs.webkit.org/show_bug.cgi?id=54622
2588 Replaced the call to node() by a call to containerNode() because the returned node is
2589 used to determine whether or not the selected contents are editable and such a check
2590 must be done against the container node.
2592 * WebCoreSupport/EditorClientQt.cpp:
2593 (WebCore::EditorClientQt::handleKeyboardEvent):
2595 2011-02-19 Charlie Reis <creis@chromium.org>
2597 Reviewed by Mihai Parparita.
2599 Ensure loading has stopped in HistoryController::goToItem
2600 https://bugs.webkit.org/show_bug.cgi?id=54517
2602 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2604 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2606 * WebCoreSupport/FrameLoaderClientQt.cpp:
2607 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
2608 * WebCoreSupport/FrameLoaderClientQt.h:
2610 2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
2612 Reviewed by Eric Seidel.
2614 Remove reduntant checks.
2615 https://bugs.webkit.org/show_bug.cgi?id=54764
2618 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2619 (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
2620 * WebCoreSupport/NotificationPresenterClientQt.cpp:
2621 (WebCore::NotificationPresenterClientQt::toPage):
2623 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
2627 [Qt] Buildfix for platforms with geolocation disabled.
2629 * Api/qwebpage.cpp: Add the missing guard.
2631 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
2633 Reviewed by Kenneth Rohde Christiansen.
2635 [Qt] Implement client based geolocation for qtport
2636 https://bugs.webkit.org/show_bug.cgi?id=42629
2638 Implements client based geolocation for qtwebkit.
2639 New client based geolocation contains permission API's as well,
2640 so removed the implementation from ChromeClientQt.cpp.
2643 (QWebPagePrivate::QWebPagePrivate):
2644 * WebCoreSupport/ChromeClientQt.cpp:
2645 * WebCoreSupport/ChromeClientQt.h:
2646 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
2647 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
2648 * WebCoreSupport/GeolocationClientQt.cpp: Added.
2649 (WebCore::GeolocationClientQt::GeolocationClientQt):
2650 (WebCore::GeolocationClientQt::~GeolocationClientQt):
2651 (WebCore::GeolocationClientQt::geolocationDestroyed):
2652 (WebCore::GeolocationClientQt::positionUpdated):
2653 (WebCore::GeolocationClientQt::startUpdating):
2654 (WebCore::GeolocationClientQt::stopUpdating):
2655 (WebCore::GeolocationClientQt::setEnableHighAccuracy):
2656 (WebCore::GeolocationClientQt::requestPermission):
2657 (WebCore::GeolocationClientQt::cancelPermissionRequest):
2658 * WebCoreSupport/GeolocationClientQt.h: Added.
2659 (WebCore::GeolocationClientQt::lastPosition):
2661 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
2663 Reviewed by Adam Roben.
2665 HTML5 <details> and <summary>: localized text
2666 https://bugs.webkit.org/show_bug.cgi?id=54260
2668 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2669 provide the default label to be used by a <details> tag that has no <summary> child.
2671 * WebCoreSupport/WebPlatformStrategies.cpp:
2672 (WebPlatformStrategies::defaultDetailsSummaryText):
2673 * WebCoreSupport/WebPlatformStrategies.h:
2675 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
2677 Reviewed by Laszlo Gombos.
2679 The URL of HTML5 Video Element is percent encoded at websites such as youtube.
2680 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
2681 the HTTP GET request for the video to be rejected by the service provider.
2682 https://bugs.webkit.org/show_bug.cgi?id=53973.
2684 The bug is fixed by constructing QUrl from the encoded URL in
2685 MediaPlayerPrivateQt::commitLoad.
2687 New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
2688 HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
2689 is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
2690 A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
2691 is skipped if Qt Multimedia is not available.
2693 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2694 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
2695 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2696 * tests/qwebpage/tst_qwebpage.cpp:
2697 (tst_QWebPage::loadHtml5Video):
2700 2011-02-17 Andreas Kling <kling@webkit.org>
2702 Reviewed by Antti Koivisto.
2704 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
2705 https://bugs.webkit.org/show_bug.cgi?id=49216
2707 * tests/qwebframe/tst_qwebframe.cpp:
2709 == Rolled over to ChangeLog-2011-02-16 ==