2010-12-09 Yael Aharon <yael.aharon@nokia.com> qtwebkit-2.1-week49
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Mon, 13 Dec 2010 20:24:03 +0000 (17:24 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Mon, 13 Dec 2010 20:24:03 +0000 (17:24 -0300)
commit7bebc59c2dfbd8ce7a21164c51295710c303a519
treeb50f723e297ca0701d3d75b7746ea149f39c63da
parent6aef00a1c7b6aaba9ac32d110f3732c36bc70e5d
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        * fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-iframe-zero-size.html: Added.
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Crash when handling iframe of size 0.
        https://bugs.webkit.org/show_bug.cgi?id=50730

        if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is
        that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node,
        thus restarts itself. The solution is to avoid considering iframes with size 0 for the spatial
        navigation algorithm.

        Test: fast/spatial-navigation/snav-hidden-iframe-zero-size.html

        * page/FocusController.cpp:
        (WebCore::updateFocusCandidateIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

WebCore/page/FocusController.cpp
LayoutTests/ChangeLog
LayoutTests/fast/spatial-navigation/snav-hidden-iframe-zero-size-expected.txt [new file with mode: 0644]
LayoutTests/fast/spatial-navigation/snav-hidden-iframe-zero-size.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/page/FocusController.cpp