2011-05-12 Carol Szabo <carol@webkit.org>
authorAbhishek Arya <inferno@chromium.org>
Thu, 12 May 2011 17:56:30 +0000 (17:56 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Fri, 13 May 2011 15:16:00 +0000 (12:16 -0300)
commit777307fad1869270ccf077aa41f1de83d6076ce5
tree133945f9f093b876681c6227d07ff0e6001023c8
parentbc995207bb359c4c127bf3a767fc7960a26315f8
2011-05-12  Carol Szabo  <carol@webkit.org>

        Reviewed by David Hyatt.

        Fix reparenting and destruction of counter nodes.
        https://bugs.webkit.org/show_bug.cgi?id=57929

        Fixed several issues related to not met assertions.
        See below in the per file description.

        Test: fast/css/counters/element-removal-crash.xhtml

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChildren):
        Fixed the fact that Node::detach() used to be called
        while the DOM tree was in an inconsistent state.
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::rendererRemovedFromTree):
        Introduced this function to remove counters from
        descendents of renderers removed from the renderer
        tree not only from the removed renderers themselves.
        * rendering/RenderCounter.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        Changed to call RenderCounter::rendererRemovedFromTree
        instead of RenderCounter::destroyCounters.
2011-05-08 Abhishek Arya <inferno@chromium.org> and Carol Szabo  <carol@webkit.org>

        Reviewed by David Hyatt.

        Fix reparenting and destruction of counter nodes.
        https://bugs.webkit.org/show_bug.cgi?id=57929

        * fast/css/counters/element-removal-crash-expected.txt: Added.
        * fast/css/counters/element-removal-crash.xhtml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/css/counters/element-removal-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/css/counters/element-removal-crash.xhtml [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/dom/ContainerNode.cpp
Source/WebCore/rendering/RenderCounter.cpp
Source/WebCore/rendering/RenderCounter.h
Source/WebCore/rendering/RenderObjectChildList.cpp