2011-05-23 Julien Chaffraix <jchaffraix@codeaurora.org>
authorAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 24 May 2011 13:26:43 +0000 (10:26 -0300)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 24 May 2011 13:26:43 +0000 (10:26 -0300)
commit6d4125a919bba9236b30daf13f53910cfe139f12
treee4e6192523b1794a594acfb877b1708b209cc7b4
parentca2dab5b8026aff72d5260374c7d5cd13c83ebc0
2011-05-23  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Darin Adler.

        Test for: Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
        https://bugs.webkit.org/show_bug.cgi?id=57140
        <rdar://problem/9191214>

        * fast/storage/storage-detached-iframe-expected.txt: Added.
        * fast/storage/storage-detached-iframe.html: Added.

        * platform/chromium/test_expectations.txt: Marked the test as CRASH
        on Chromium - Linux.
2011-05-23  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Darin Adler.

        Crash from null pointer dereference below WebCore::StorageAreaImpl::setItem()
        https://bugs.webkit.org/show_bug.cgi?id=57140

        Test: fast/storage/storage-detached-iframe.html

        Access of localStorage on a detached iframe was causing a crash because a detached
        iframe has a null m_page, and WebCore::privateBrowsingEnabled() wasn't testing for such.

        * storage/StorageAreaImpl.cpp:
        (WebCore::privateBrowsingEnabled): check that child->page() is non-null before
        accessing it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/ChangeLog
LayoutTests/fast/storage/storage-detached-iframe-expected.txt [new file with mode: 0644]
LayoutTests/fast/storage/storage-detached-iframe.html [new file with mode: 0644]
LayoutTests/platform/chromium/test_expectations.txt
Source/WebCore/ChangeLog
Source/WebCore/storage/StorageAreaImpl.cpp