2010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
authorJocelyn Turcotte <jocelyn.turcotte@nokia.com>
Tue, 21 Sep 2010 14:30:51 +0000 (14:30 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 21 Sep 2010 17:32:18 +0000 (14:32 -0300)
commit6160419648b1ce7afe1a2d96db544ef4532de039
tree4c7fa2dc7e49053b469a0b800073875a2c9967bd
parenta47890e7d591cf1ec6cf022de156e0d49220ea8e
2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Check if the reply has been deleted before finishing a network request
        https://bugs.webkit.org/show_bug.cgi?id=46174

        A crash can happen with the following sequence:
        1. QNetworkReplyHandler::abort() emits reply->deleteLater()
        2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
        3. event loop would call reply->deleteLater()
        However a crash occurs since m_reply == 0 on step 2.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/platform/network/qt/QNetworkReplyHandler.cpp