2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
authorcommit-queue <commit-queue@webkit.org>
Wed, 1 Sep 2010 12:31:19 +0000 (12:31 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Thu, 2 Sep 2010 14:41:07 +0000 (11:41 -0300)
commit5da1b423861c071a2ea012e62d2a37603d96ab68
treed44210bccea6c1c15e447a315c7585be2572efa6
parentc121913db5cec9acebf477036324051b8b1d3660
2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QWebPage::allowGeolocationRequest should be async API
        https://bugs.webkit.org/show_bug.cgi?id=41364

        Enable all geolocation delayed permission layout test for Qt port

        * platform/qt/Skipped:
2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QWebPage::allowGeolocationRequest should be async API
        https://bugs.webkit.org/show_bug.cgi?id=41364

        Adding GeolocationPermissionClientQt.cpp/h to build script

        * WebCore.pro:
2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QWebPage::allowGeolocationRequest should be async API
        https://bugs.webkit.org/show_bug.cgi?id=41364

        Provides a new async API for geolocation permission. Using
        Notification API approach from qtwebkit. GeolocationPermissionClientQt
        maintains list of pending requests from WebCore and intimates them
        when client either allowes/denies the request. Also implements
        ChromeClientQt::cancelGeolocationPermissionRequestForFrame.

        * Api/qwebpage.cpp:
        (QWebPage::setUserPermission):
        * Api/qwebpage.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
        (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/GeolocationPermissionClientQt.cpp: Added.
        (WebCore::GeolocationPermissionClientQt::geolocationPermissionClient):
        (WebCore::GeolocationPermissionClientQt::GeolocationPermissionClientQt):
        (WebCore::GeolocationPermissionClientQt::~GeolocationPermissionClientQt):
        (WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
        (WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
        (WebCore::GeolocationPermissionClientQt::setPermission):
        * WebCoreSupport/GeolocationPermissionClientQt.h: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (JSTestPage::requestPermission):
        (tst_QWebPage::geolocationRequestJS):
2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QWebPage::allowGeolocationRequest should be async API
        https://bugs.webkit.org/show_bug.cgi?id=41364

        Implements new async API for geolocation permission similar to
        Notification. WebPage maintains list of geolocation permission request
        QtWebkit and set's when LayoutTestController gets the access from test JS

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        (WebCore::WebPage::requestPermission):
        (WebCore::WebPage::cancelPermission):
        (WebCore::WebPage::permissionSet):
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::processLine):
        (WebCore::DumpRenderTree::geolocationPermissionSet):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setGeolocationPermissionCommon):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
17 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/qt/Skipped
WebCore/ChangeLog
WebCore/WebCore.pro
WebKit/qt/Api/qwebpage.cpp
WebKit/qt/Api/qwebpage.h
WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
WebKit/qt/WebCoreSupport/ChromeClientQt.h
WebKit/qt/WebCoreSupport/GeolocationPermissionClientQt.cpp [new file with mode: 0644]
WebKit/qt/WebCoreSupport/GeolocationPermissionClientQt.h [new file with mode: 0644]
WebKit/qt/tests/qwebpage/tst_qwebpage.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.h
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h