2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
authorCaio Marcelo de Oliveira Filho <cmarcelo@webkit.org>
Wed, 1 Jun 2011 12:16:09 +0000 (12:16 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Wed, 1 Jun 2011 17:58:09 +0000 (14:58 -0300)
commit52da9d6e54502d9207e795e56a861dd9228a6c52
tree89033fce2138186af8933fe8dce92a80ddd10513
parentf3934e4791a2328078b7f3c4226a9e809b0e9101
2011-06-01  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
        https://bugs.webkit.org/show_bug.cgi?id=61739

        The skipped test was imported from Qt source repository, and used private headers
        to peek in the QML Grid element. This patch changes the QML used to expose the
        information we want to test: number of pages opened and the first page opened.

        * tests/qdeclarativewebview/resources/newwindows.html:
        Added <body> tags. We have no reason to not use them in the test.

        * tests/qdeclarativewebview/resources/newwindows.qml:
        Moved the timer out of the page component, used anchors for setting webview size,
        changed the way we count pages opened. Also changed coding style a bit.

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::multipleWindows):
        We now look for properties with the information we want in the rootItem: pagesOpened and
        firstPageOpened.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.html
Source/WebKit/qt/tests/qdeclarativewebview/resources/newwindows.qml
Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp