2011-05-31 Abhishek Arya <inferno@chromium.org>
authorAbhishek Arya <inferno@chromium.org>
Tue, 31 May 2011 18:16:13 +0000 (18:16 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Fri, 3 Jun 2011 20:38:10 +0000 (17:38 -0300)
commit49d1a0a3e604ebc4f45d8679c00ad2afe477ddb1
tree5e29fc591203b0ccf283c74600443fe216377364
parent3ab8247712de7429b325b991280b86d769102965
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Improve hasMediaControls logic to check that node has
        media controls. This can be false when cloning nodes.
        https://bugs.webkit.org/show_bug.cgi?id=61765

        Test: media/media-controls-clone-crash.html

        * dom/Node.h:
        (WebCore::Node::isMediaControls):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaControls):
        (WebCore::HTMLMediaElement::hasMediaControls):
        * html/shadow/MediaControls.h:
        (WebCore::MediaControls::isMediaControls):
        (WebCore::toMediaControls):
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that cloning an audio element with media controls does
        not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=61765

        * media/media-controls-clone-crash-expected.txt: Added.
        * media/media-controls-clone-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/media-controls-clone-crash-expected.txt [new file with mode: 0644]
LayoutTests/media/media-controls-clone-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/dom/Node.h
Source/WebCore/html/HTMLMediaElement.cpp
Source/WebCore/html/shadow/MediaControls.h