Robert Hogan [Sun, 3 Jul 2011 15:51:21 +0000 (15:51 +0000)]
2011-07-03 Robert Hogan <robert@webkit.org>
Add platform-specific results after r90338
Unreviewed, add platform-specific results for new rendertree test.
https://bugs.webkit.org/show_bug.cgi?id=30355
http://trac.webkit.org/changeset/90338
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
* platform/qt-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
* plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Wed, 13 Jul 2011 16:47:22 +0000 (13:47 -0300)]
Reviewed by Andreas Kling.
Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717
QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.
Original patch by Ritt Konstantin <ritt.ks@gmail.com>, also
tested by him on QNX v6.5 (x86)
* wtf/DateMath.cpp: fix usage of abs/labs
* wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
* wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/JavaScriptCore/wtf/DateMath.cpp
Yael Aharon [Fri, 3 Jun 2011 13:47:02 +0000 (13:47 +0000)]
2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
* fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
* fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
* fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
* platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
2011-06-03 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491
Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
Test: fast/frames/flattening/iframe-flattening-out-of-view.html
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Robert Hogan [Sun, 3 Jul 2011 15:04:28 +0000 (15:04 +0000)]
2011-06-23 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355
Unfortunately this has to be a rendertree test, as there is no rendertext way of
determining if a selection is still highlighted.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
* plugins/mouse-click-plugin-clears-selection.html: Added.
2011-06-23 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355
Test: plugins/mouse-click-plugin-clears-selection.html
PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).
* WebCore.exp.in: Add symbol for FocusController::setFocusedNode
* plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
redundant, since it calls both.
2011-06-23 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
https://bugs.webkit.org/show_bug.cgi?id=30355
PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
in order to clear the FrameSelection in the currently focused node. In its platform-specific
code Chromium already does this (WebPluginContainerImpl.cpp).
* WebProcess/Plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
the call to FocusController:setFocusedFrame() redundant, since the
former calls it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Patrick Gansterer [Sat, 9 Jul 2011 20:43:09 +0000 (20:43 +0000)]
Fix unaligned userspace access for SH4 platforms.
https://bugs.webkit.org/show_bug.cgi?id=62993
Patch by Thouraya Andolsi <thouraya.andolsi@st.com> on 2011-07-09
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Tue, 5 Jul 2011 19:45:00 +0000 (19:45 +0000)]
2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235
Modified baseUrl to be a local file in order to get a security origin
that is allowed to request local resources. Removed QSignalSpy from it
as loadFinished always happens, and the original test was split into two.
Reviewed by Benjamin Poulain.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setHtmlWithImageResource):
(tst_QWebFrame::setHtmlWithStylesheetResource):
(tst_QWebFrame::setHtmlWithBaseURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 1 Jul 2011 21:09:03 +0000 (21:09 +0000)]
2011-07-01 Jade Han <jade.han@nokia.com>
[Qt][Symbian] Update .def file for Symbian to build Tools
https://bugs.webkit.org/show_bug.cgi?id=61200
Reviewed by Laszlo Gombos.
Add newly introduced symbols to fix building the Tools directory for Symbian.
* symbian/eabi/QtWebKitu.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Fri, 1 Jul 2011 20:58:49 +0000 (17:58 -0300)]
Skip test introduced in r90068 that fails on qtwebkit-2.2
Works fine on trunk, we're probably missing something on the branch.
Skipping test to keep the bots green, under investigation.
Julien Chaffraix [Thu, 30 Jun 2011 20:50:16 +0000 (20:50 +0000)]
2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Nikolas Zimmermann.
Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076
* svg/custom/crash-text-in-textpath-expected.txt: Added.
* svg/custom/crash-text-in-textpath.svg: Added.
Original crashing test case.
* svg/custom/text-node-in-text-invalidated-expected.txt: Added.
* svg/custom/text-node-in-text-invalidated.svg: Added.
This test case was not crashing. However it is good to make sure this change
did not regress that.
2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Nikolas Zimmermann.
Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
https://bugs.webkit.org/show_bug.cgi?id=63076
Tests: svg/custom/crash-text-in-textpath.svg
svg/custom/text-node-in-text-invalidated.svg
The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
doing our layout, we would not update the attributes on our SVGRenderInlineText as
we would not lay it out.
This was caused by childrenChanged being overridden on SVGTextPositioningElement but
not on SVGTextPathElement.
As both classes shared the same mother class, it made sense to move the logic here.
There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
are the only classes deriving from SVGTextContentElement.
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
* svg/SVGTextContentElement.h:
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
* svg/SVGTextPositioningElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Thu, 30 Jun 2011 23:30:18 +0000 (23:30 +0000)]
2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236
This test required a security origin with granted permission to request local resources.
By default, only local files can load local resources. So modified baseUrl to be a local file.
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::renderGeometry):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Fri, 1 Jul 2011 14:29:12 +0000 (14:29 +0000)]
2011-07-01 Jade Han <jade.han@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=61200
Add newly introduced symbols to fix the Symbian build.
* symbian/eabi/QtWebKitu.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Thu, 30 Jun 2011 13:59:41 +0000 (13:59 +0000)]
2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] QML Webview causes performance drops
https://bugs.webkit.org/show_bug.cgi?id=57554
Remove tiledBackingStoreEnabled from QML WebView.
* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::setPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 30 Jun 2011 17:00:48 +0000 (17:00 +0000)]
2011-06-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650
Convert a few nodes to RefPtrs and add commonRoot verification checks
for Range::processContents.
Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
fast/dom/Range/range-extract-contents-event-fire-crash2.html
* dom/Range.cpp:
(WebCore::childOfCommonRootBeforeOffset):
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processAncestorsAndTheirSiblings):
2011-06-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Crash when calling DOMSubtreeModified event when extracting range
contents.
https://bugs.webkit.org/show_bug.cgi?id=63650
* fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt: Added.
* fast/dom/Range/range-extract-contents-event-fire-crash.html: Added.
* fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt: Added.
* fast/dom/Range/range-extract-contents-event-fire-crash2.html: Added.
* fast/dom/Range/range-extractContents.html: remove the appending of fragment
in this crasher test since we now refptr the nodes and leftContents will be visible.
This crasher test does not need to show the extractContents fragment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Thu, 30 Jun 2011 17:49:47 +0000 (14:49 -0300)]
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
In RenderBlock, RenderWidget and RenderReplaced destroy functions,
call dirtyLinesFromChangedChild to tell our parent that we are going away.
https://bugs.webkit.org/show_bug.cgi?id=60307
Test: fast/block/child-not-removed-from-parent-lineboxes-crash.html
fast/block/block-not-removed-from-parent-lineboxes-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::destroy):
* rendering/RenderReplaced.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Tests that we do not crash when failing to remove the linebreak
object(widget, block, replaced, etc) from parent block lineboxes. The
testcase tries to fuzz over the list of html and svg tags.
https://bugs.webkit.org/show_bug.cgi?id=60307
* fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
* fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added.
* fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added.
* fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebCore/rendering/RenderReplaced.h
David Hyatt [Thu, 5 May 2011 20:04:01 +0000 (20:04 +0000)]
<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
Reviewed by Darin Adler.
Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).
Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 29 Jun 2011 19:18:02 +0000 (19:18 +0000)]
2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] Add Qt dependencies in QtWebKit's main pro file.
https://bugs.webkit.org/show_bug.cgi?id=63639
syncqt, the script which generates the headers inside Qt parses
the main pro file of QtWebKit to check the Qt dependencies. It used
to be WebCore.pro but after the build reorganization QtWebKit.pro is
the new main pro file so we need to add the network dependency just like
we did in WebCore.pro.
* QtWebKit.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Wed, 29 Jun 2011 17:43:26 +0000 (14:43 -0300)]
2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930
Test that a generated block child + counter within a <ruby> doesn't crash.
(Test as provided by original reporter).
* fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
* fast/ruby/generated-after-counter-doesnt-crash.html: Added.
* fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
* fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
* fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
* fast/ruby/generated-before-counter-doesnt-crash.html: Added.
2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
https://bugs.webkit.org/show_bug.cgi?id=55930
Don't set style type BEFORE/AFTER on anonymous wrapper block.
Rather, check style type on generated wrapped child.
Tests: fast/ruby/generated-after-counter-doesnt-crash.html
fast/ruby/generated-before-and-after-counter-doesnt-crash.html
fast/ruby/generated-before-counter-doesnt-crash.html
* rendering/RenderRuby.cpp:
(WebCore::isAnonymousRubyInlineBlock):
(WebCore::isRubyBeforeBlock):
(WebCore::isRubyAfterBlock):
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsBlock::addChild):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebCore/rendering/RenderRuby.cpp
Matt Delaney [Mon, 23 May 2011 22:33:39 +0000 (22:33 +0000)]
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
* wtf/MathExtras.h:
(clampToInteger):
(clampToPositiveInteger):
2011-05-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Remove safeFloatToInt() in FloatRect.cpp and replace with working version of clampToInteger()
https://bugs.webkit.org/show_bug.cgi?id=58216
No new tests. The SVG tests mask-excessive-malloc.svg and pattern-excessive-malloc.svg exercise this code path.
* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Csaba Osztrogonác [Thu, 23 Jun 2011 12:48:37 +0000 (12:48 +0000)]
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235
Rubber-stamped by Andreas Kling.
[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236
[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237
* tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Csaba Osztrogonác [Thu, 23 Jun 2011 12:45:34 +0000 (12:45 +0000)]
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244
Rubber-stamped by Andreas Kling.
[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245
* tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Tue, 28 Jun 2011 21:13:25 +0000 (21:13 +0000)]
2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
https://bugs.webkit.org/show_bug.cgi?id=63562
Some Qt auto-tests rely on <QtX/x.h> types of includes.
* Api/qwebkitplatformplugin.h:
* symbian/platformplugin/qwebkitplatformplugin.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Mon, 27 Jun 2011 23:26:18 +0000 (23:26 +0000)]
2011-06-27 Joe Wild <joseph.wild@nokia.com>
Reviewed by Simon Fraser.
Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393
Tests that a plugin of a swf file in a hidden iframe will not
crash. This test required more than 1 content file and a
timeout or else it would not repeat the error condition.
This test will only crash on platforms (like Symbian) that
don't allow nonvirtual functions to have a null this pointer.
* plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
* plugins/hidden-iframe-with-swf-plugin.html: Added.
* plugins/resources/iframe-content-with-swf-plugin.html: Added.
2011-06-27 Joe Wild <joseph.wild@nokia.com>
Reviewed by Simon Fraser.
Crash on www.crave.cnet.com in FrameView::windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=56393
Check for a null renderer to fix a crash. This situation can
arise when external content/plugins is referenced from html
elements with style="display:none".
Test: plugins/hidden-iframe-with-swf-plugin.html
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Tue, 28 Jun 2011 14:22:44 +0000 (14:22 +0000)]
2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
https://bugs.webkit.org/show_bug.cgi?id=63533
We need to use the new QtQuick 1.x imports rather than the old deprecated
version.
* tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
* tests/qdeclarativewebview/resources/webviewtest.qml:
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Jer Noble [Wed, 15 Jun 2011 16:51:31 +0000 (16:51 +0000)]
2011-06-15 Jer Noble <jer.noble@apple.com>
Reviewed by Timothy Hatcher.
Full-screen live streams have status text in wrong location
https://bugs.webkit.org/show_bug.cgi?id=62733
Fix a misspelling in the user-agent stylesheet for full-screen mode.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-status-display):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Caio Marcelo de Oliveira Filho [Mon, 27 Jun 2011 17:18:24 +0000 (17:18 +0000)]
2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
This patch is based on Noam Rosenthal original patch in the same bug.
When hinted with QWebElement metatype, we qualify the conversion
from JSElement as a "perfect match".
The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant): Identify the conversion between JSElement
to QWebElement as a "perfect match" (dist = 0). Add comments to explain the reason
why we have the implicit conversion.
2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::overloadedSlots): Remove expected failure and
fix the comment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Mon, 27 Jun 2011 17:48:45 +0000 (17:48 +0000)]
2011-06-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Fix removal of overhanging floats on style changes to absolute/fixed position.
https://bugs.webkit.org/show_bug.cgi?id=63355
1. If we are not currently positioned.
2. And we are not floating. (If we are floating, then this will be automatically
done in RenderBox::styleWillChange as part of removeFloatingOrPositionedChildFromBlockLists)
3. And we have overhanging floats from previous sibling blocks.
4. And our new new style tells that we will have absolute or fixed position.
Then, we mark all our descendants with floats for layout. This will make sure that
overhanging floats are removed. Also, it is important to do that since if that previous
sibling block goes away, it is not able to tell us that to remove those floats thinking
that being a positioned block, we should have removed them already.
Tests: fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html
fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html
fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html
fast/block/float/overhanging-float-add-in-static-position-block.html
fast/block/float/overhanging-float-add-in-static-position-block2.html
fast/block/float/overhanging-float-remove-from-absolute-position-block.html
fast/block/float/overhanging-float-remove-from-absolute-position-block2.html
fast/block/float/overhanging-float-remove-from-fixed-position-block.html
fast/block/float/overhanging-float-remove-from-fixed-position-block2.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
2011-06-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that overhanging floats are removed during style changes to absolute/fixed
position and gets added back when coming back to static position.
https://bugs.webkit.org/show_bug.cgi?id=63355
* fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html: Added.
* fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html: Added.
* fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position.html: Added.
* fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2.html: Added.
* fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position.html: Added.
* fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2.html: Added.
* fast/block/float/overhanging-float-add-in-static-position-block.html: Added.
* fast/block/float/overhanging-float-add-in-static-position-block2.html: Added.
* fast/block/float/overhanging-float-remove-from-absolute-position-block.html: Added.
* fast/block/float/overhanging-float-remove-from-absolute-position-block2.html: Added.
* fast/block/float/overhanging-float-remove-from-fixed-position-block.html: Added.
* fast/block/float/overhanging-float-remove-from-fixed-position-block2.html: Added.
* platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
* platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
* platform/mac/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
* platform/mac/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ryosuke Niwa [Mon, 27 Jun 2011 17:21:39 +0000 (17:21 +0000)]
2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334
Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
and check !m_offset when handling first letter.
Also add more assertions to help detecting similar bugs.
Test: editing/text-iterator/first-letter-rtl-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::emitText):
2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Crash in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=63334
Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
with first-letter rule applied where letters are not contiguous.
* editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
* editing/text-iterator/first-letter-rtl-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Mon, 27 Jun 2011 08:10:54 +0000 (08:10 +0000)]
2011-06-27 Huang Dongsung <luxtella@company100.net>
Reviewed by Kenneth Rohde Christiansen.
TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422
REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.
If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::innerBottomRight):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::createTiles):
2011-06-27 Huang Dongsung <luxtella@company100.net>
Reviewed by Kenneth Rohde Christiansen.
TiledBackingStore endlessly creates and destroys tiles due to an off-by-one
error.
https://bugs.webkit.org/show_bug.cgi?id=62422
REGRESSION(r77286): Remove bottomRight().
REGRESSION(r77312): Change the logic to get the bottom right point.
REGRESSION(r77928): Cause off-by-one error in TiledBackingStore.
REGRESSION(r78783): Cause off-by-one error in TiledDrawingAreaProxy.
REGRESSION(r78785): Cause off-by-one error in TiledDrawingAreaProxy.
If the viewport width equals the contents width, especially in the mobile
device, TiledBackingStore endlessly creates and deletes the rightmost
column and bottom row of tiles.
In the detail, dropTilesOutsideRect() in TiledBackingStore::createTiles()
deletes tiles and setTile(coordinate, Tile::create(this, coordinate)) creates
tiles infinitely.
Modified TiledDrawingAreaProxy also.
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::innerBottomRight):
(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Mon, 27 Jun 2011 17:26:32 +0000 (17:26 +0000)]
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448
Remvove from the build.
* Source/WebKit.pri:
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448
Remove Phonon mediaplayer as it is unused, not finished and
unmaintained.
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Removed.
* platform/graphics/qt/MediaPlayerPrivatePhonon.h: Removed.
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove Phonon MediaPlayer from the tree.
https://bugs.webkit.org/show_bug.cgi?id=63448
Remove Phonon related stuff.
* docs/qtwebkit.qdocconf:
* qt_webkit_version.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Darin Adler [Fri, 10 Jun 2011 17:05:31 +0000 (17:05 +0000)]
2011-06-10 Darin Adler <darin@apple.com>
Reviewed by Eric Carlson.
REGRESSION: Fullscreen video controller can't be dragged
https://bugs.webkit.org/show_bug.cgi?id=62462
No regression test because we don't have machinery for testing the fullscreen
mode. We may find a way to add this in the future.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
booleans related to dragging.
(WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
is allowed and a drag isn't already in progress.
(WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
dragging is already in progress.
(WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
done during the dragging process.
(WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
using explicit top/left.
(WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
done by setPosition.
(WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
continueDrag, and endDrag in response to mouse events.
(WebCore::MediaControlPanelElement::setCanBeDragged): Added.
* html/shadow/MediaControlElements.h: Added new function and data members
as mentioned above.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
so you can drag the panel while in fullscreen.
(WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
so you can't drag the panel while not in fullscreen. Also call resetPosition so
position changes from dragging don't affect the panel in other contexts.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Dimitri Glazkov [Sat, 25 Jun 2011 17:04:40 +0000 (17:04 +0000)]
2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373
* fast/css/unknown-pseudo-element-matching-expected.txt: Updated results.
* fast/css/unknown-pseudo-element-matching.html: Added more tests.
2011-06-24 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION (r77740): Shadow DOM pseudo elements aren't matching when combined with descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=63373
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pushParentStackFrame): Changed to use parentOrHostElement.
(WebCore::CSSStyleSelector::pushParent): Ditto.
* dom/Node.cpp:
(WebCore::Node::parentOrHostElement): Added.
* dom/Node.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexey Proskuryakov [Sat, 25 Jun 2011 00:03:25 +0000 (00:03 +0000)]
Rubber-stamped by Maciej Stachowiak.
REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading
No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
the rollout will re-introduce the older less frequent crash).
* loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix
for bug 62764.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Fri, 24 Jun 2011 20:54:58 +0000 (20:54 +0000)]
2011-06-24 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed build fix.
Build fix on Linux when using the GStreamer backend.
No new tests, just a build fix.
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::keyPressEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 23 Jun 2011 18:30:55 +0000 (18:30 +0000)]
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Tests that we do not crash when doing a media query match.
https://bugs.webkit.org/show_bug.cgi?id=63264
* fast/css/media-query-evaluator-crash-expected.txt: Added.
* fast/css/media-query-evaluator-crash.html: Added.
2011-06-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
RefPtr m_style in MediaQueryEvaluator in case of callers like
MediaQueryMatcher::prepareEvaluator that do not retain its reference.
https://bugs.webkit.org/show_bug.cgi?id=63264
Test: fast/css/media-query-evaluator-crash.html
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryEvaluator.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Csaba Osztrogonác [Thu, 23 Jun 2011 12:48:37 +0000 (12:48 +0000)]
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235
Rubber-stamped by Andreas Kling.
[Qt] Fix tst_QWebFrame::renderGeometry() API test
https://bugs.webkit.org/show_bug.cgi?id=63236
[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
https://bugs.webkit.org/show_bug.cgi?id=63237
* tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
(tst_QWebFrame::setHtmlWithResource):
(tst_QWebFrame::renderGeometry):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Csaba Osztrogonác [Thu, 23 Jun 2011 12:45:34 +0000 (12:45 +0000)]
[Qt] Fix tst_QWebPage::showModalDialog() API test
https://bugs.webkit.org/show_bug.cgi?id=63244
Rubber-stamped by Andreas Kling.
[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
https://bugs.webkit.org/show_bug.cgi?id=63245
* tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
(tst_QWebPage::showModalDialog):
(tst_QWebPage::testStopScheduledPageRefresh):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Wed, 22 Jun 2011 23:18:57 +0000 (23:18 +0000)]
2011-06-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
and places the cursor in the correct position.
* editing/inserting/return-key-before-br-in-span-expected.txt: Added.
* editing/inserting/return-key-before-br-in-span.html: Added.
* editing/inserting/return-key-middle-of-span-expected.txt: Added.
* editing/inserting/return-key-middle-of-span.html: Added.
2011-06-22 Annie Sullivan <sullivan@chromium.org>
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
split at to be at the end of a text node. The code assumes the position is at the start of the node, so
pass the correct node into splitTreeToNode() in that case.
Tests: editing/inserting/return-key-before-br-in-span.html
editing/inserting/return-key-middle-of-span.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Matt Delaney [Tue, 24 May 2011 18:04:36 +0000 (18:04 +0000)]
2011-05-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135
* fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt: Added.
* fast/canvas/canvas-getImageData-largeNonintegralDimensions.html: Added.
2011-05-24 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Clamp coordinates to integers for canvas create/getImageData routines
https://bugs.webkit.org/show_bug.cgi?id=61135
Test: fast/canvas/canvas-getImageData-largeNonintegralDimensions.html
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::convertLogicalToDevice): clamp to ints
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Adam Barth [Thu, 9 Jun 2011 08:41:56 +0000 (08:41 +0000)]
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
* fast/parser/document-write-onload-clear-expected.txt: Added.
* fast/parser/document-write-onload-clear.html: Added.
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.
Test: fast/parser/document-write-onload-clear.html
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Mike Lawther [Thu, 9 Jun 2011 14:12:56 +0000 (14:12 +0000)]
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
* css3/calc/regression-62276-expected.txt: Added.
* css3/calc/regression-62276.html: Added.
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
Test: css3/calc/regression-62276.html
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Thu, 23 Jun 2011 15:44:58 +0000 (15:44 +0000)]
2011-06-23 Joe Wild <joseph.wild@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Export files under Symbian Qt WebKit build
https://bugs.webkit.org/show_bug.cgi?id=61207
Export files for the Symbian platform as this is needed by the
production build system.
Janne Koskinen provided the suggestion to use target_predeps,
which is an improvement over the originally suggested patch.
* QtWebKit.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Thu, 23 Jun 2011 22:02:45 +0000 (22:02 +0000)]
2011-06-23 Joe Wild <joseph.wild@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
https://bugs.webkit.org/show_bug.cgi?id=61200
Revert r87060 as it broke compatibility with QtWebKit 2.1 release
and add some newly introduce symbols.
* symbian/eabi/QtWebKitu.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Junior [Wed, 22 Jun 2011 18:57:04 +0000 (18:57 +0000)]
2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Holger Freyther.
[Qt] Fix Qt namespace on QDeclarativeWebView autotest
https://bugs.webkit.org/show_bug.cgi?id=63147
Applications (such as the test runner) are not supposed to be wrapped
by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
QtWebKit) with a specific namespace won't work (will result in main
being undefined).
This was the only test wrapped by these macros, all others are fine.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
namespace macros.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Csaba Osztrogonác [Fri, 6 May 2011 07:39:11 +0000 (07:39 +0000)]
Unreviewed expectations update.
* platform/mac-wk2/Skipped:
- Add http/tests/navigation/response204.html because of missing layoutTestController.queueLoad()
* platform/qt-arm/Skipped:
- Add fast/css/hover-update.html, because it fails intermittently.
- Add failing http/tests/websocket/tests/frame-lengths.html and http/tests/websocket/tests/simple-stress.html.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
* platform/qt-wk2/Skipped:
- Add new but failing test: editing/pasteboard/paste-placeholder-input.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Yael Aharon [Tue, 21 Jun 2011 19:18:11 +0000 (19:18 +0000)]
2011-06-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Regression(60942) wrong default action for drag-and-drop.
https://bugs.webkit.org/show_bug.cgi?id=63004
Added special handling for the case that dragOperation is not initialized.
Save the last dropOperation and pass it to the dropEvent, so that it can
be accepted by QDrag.
Call event->accepted() and not event->acceptProposedAction(), because the
later ignores the dropAction specified in JavaScript.
Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
and did not see any issue.
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
and they all pass.
* Api/qwebpage.cpp:
(dropActionToDragOp):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Oliver Hunt [Mon, 20 Jun 2011 19:46:23 +0000 (19:46 +0000)]
2011-06-20 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r79060): Searching for a flight at united.com fails
https://bugs.webkit.org/show_bug.cgi?id=63003
Roll out tests that were added by the patch we're rolling out, and add
a test for the united.com Date.
* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
2011-06-20 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r79060): Searching for a flight at united.com fails
https://bugs.webkit.org/show_bug.cgi?id=63003
This original change also broke Twitter, and we attempted to refine the fix to
address that problem (http://trac.webkit.org/changeset/80542), but since it still breaks United,
we need to revert the change until we understand the problem better.
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Adam Barth [Mon, 20 Jun 2011 17:51:40 +0000 (17:51 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774
* fast/parser/attributes-on-close-script-expected.txt: Added.
* fast/parser/attributes-on-close-script.html: Added.
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774
This ASSERT triggers for the same underlying issue that causes
Bug 62971: When we tokenize a </script> tag, we don't realize that
we've already consumed the "</script>" from the input stream when we
extracted the previous token. That causes the source tracker to be
out-of-sync, triggering the incorrect view-source highlighting and this
ASSERT.
For now, let's just silence the assert while we work on Bug 62971.
Test: fast/parser/attributes-on-close-script.html
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::AtomicHTMLToken::initializeAttributes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 16 Jun 2011 21:27:30 +0000 (21:27 +0000)]
2011-06-16 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
RefPtr frame since it can get removed in
FrameLoader::finishedParsing.
https://bugs.webkit.org/show_bug.cgi?id=62812
Tests: already tested by fast/parser/document-write-into-initial-document.html.
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Tue, 7 Jun 2011 22:45:14 +0000 (22:45 +0000)]
2011-06-07 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Replicate WidthIterator.cpp fix from r88139.
https://bugs.webkit.org/show_bug.cgi?id=62238
No new tests. Covered by existing layout tests on XP debug bots.
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 2 Jun 2011 02:49:37 +0000 (02:49 +0000)]
2011-06-01 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Coding style nit. Move ec=0 initialization, change
recommended by Alexey in bug.
https://bugs.webkit.org/show_bug.cgi?id=60831
* dom/Document.cpp:
(WebCore::Document::setBody):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Wed, 1 Jun 2011 23:13:53 +0000 (23:13 +0000)]
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix setting of document.body
https://bugs.webkit.org/show_bug.cgi?id=60831
1. Only allowing setting to an element if it has a body tag.
2. If element is from another document, import it.
Test: fast/dom/document-set-body.html
* dom/Document.cpp:
(WebCore::Document::setBody):
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Tests setting document.body to non body elements, elements in other
documents.
https://bugs.webkit.org/show_bug.cgi?id=60831
* fast/dom/document-set-body-expected.txt: Added.
* fast/dom/document-set-body.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Wed, 1 Jun 2011 18:12:53 +0000 (18:12 +0000)]
2011-06-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Do not use the pushed style selector if it is not equal to the
parent document's style selector. It usually means that it is
in a bad state, e.g. already cleared.
https://bugs.webkit.org/show_bug.cgi?id=61737
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Mon, 9 May 2011 16:32:26 +0000 (16:32 +0000)]
2011-05-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Add a crash test for r85964.
https://bugs.webkit.org/show_bug.cgi?id=59473
* fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
* fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 5 May 2011 21:42:59 +0000 (21:42 +0000)]
2011-05-05 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Minor rebaselines for qt after my r85876.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Fri, 17 Jun 2011 20:19:10 +0000 (20:19 +0000)]
2011-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash when unable to remove floats from
parent's next siblings blocks.
https://bugs.webkit.org/show_bug.cgi?id=62875
* fast/block/float/float-not-removed-from-next-sibling5-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling5.html: Added.
2011-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When we lose ability to propagate floats, need to find topmost
parent with that overhanging float, and then iterate over its
sibling blocks to remove the float.
https://bugs.webkit.org/show_bug.cgi?id=62875
Test: fast/block/float/float-not-removed-from-next-sibling5.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::hasOverhangingFloat):
* rendering/RenderBlock.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Tue, 10 May 2011 16:40:35 +0000 (16:40 +0000)]
2011-05-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Add containsFloats call to hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537
Test: fast/block/float/no-overhanging-float-crash.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::repaintOverhangingFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::hasOverhangingFloats):
2011-05-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that we do not crash due to wrong result from
hasOverhangingFloats.
https://bugs.webkit.org/show_bug.cgi?id=60537
* fast/block/float/no-overhanging-float-crash-expected.txt: Added.
* fast/block/float/no-overhanging-float-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 5 May 2011 21:07:52 +0000 (21:07 +0000)]
2011-05-05 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When style changes for a RenderBlock and we lose our ability to intrude into
floats in the next siblings block (e.g a position change), make sure to mark
our childs with floats for layout and iterate through our next sibling block
chain to see which ones contain the float that also exists in our floating
objects list and clear those using markAllDescendantsWithFloatsForLayout.
https://bugs.webkit.org/show_bug.cgi?id=56299
Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
fast/block/float/float-not-removed-from-next-sibling.html
fast/block/float/float-not-removed-from-next-sibling2.html
fast/block/float/float-not-removed-from-next-sibling3.html
fast/block/float/float-not-removed-from-next-sibling4.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
* rendering/RenderBlock.h:
2011-05-04 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash when trying to add overflow from a float not in the
descendant list and whose renderer is already removed.
https://bugs.webkit.org/show_bug.cgi?id=56299
* fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
* fast/block/float/float-not-removed-from-next-sibling.html: Added. Black
text boxes should be inside the silver float. Failing test will have float
added to the text div block which will push the text downward.
* fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
* fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black
text boxes should be inside the silver float. Failing test will have float
added to the text div block which will push the text downward.
* fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
* fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance
between the silver float and black text boxes should be less than height of
silver float. Failing test will have float overflow added to the text div
block which will cause large space between silver float and and black text boxes.
* fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
* fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance
between the silver float and black text boxes should be less than height of
silver float. Failing test will have float overflow added to the text div
block which will cause large space between silver float and and black text boxes.
* fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
* fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Tue, 21 Jun 2011 17:13:07 +0000 (14:13 -0300)]
new test introduced in r89118, but fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=62847
* platform/qt/Skipped: Skip fast/parser/xhtml-innerhtml-null-byte.xhtml.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
LayoutTests/platform/qt/Skipped
Gabor Loki [Fri, 17 Jun 2011 06:56:00 +0000 (06:56 +0000)]
2011-06-16 Gabor Loki <loki@webkit.org>
[Qt] Unreviewed, build fix after r89118.
* dom/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::initializeParserContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Fri, 17 Jun 2011 05:54:14 +0000 (05:54 +0000)]
2011-06-16 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Alexey Proskuryakov.
Using null bytes when setting innerHTML in XTHML results in assertion and a crash due to null-pointer dereference
https://bugs.webkit.org/show_bug.cgi?id=61053
Added test cases covering two cases of using innerHTML with null bytes in XHTML.
* fast/parser/xhtml-innerhtml-null-byte-expected.txt: Added.
* fast/parser/xhtml-innerhtml-null-byte-first-expected.txt: Added.
* fast/parser/xhtml-innerhtml-null-byte-first.xhtml: Added.
* fast/parser/xhtml-innerhtml-null-byte.xhtml: Added.
2011-06-16 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Alexey Proskuryakov.
Using null bytes when setting innerHTML in XTHML results in assertion and a crash due to null-pointer dereference
https://bugs.webkit.org/show_bug.cgi?id=61053
XML parsing in-memory XML chunks now passes around a string object instead of a C string, ensuring null characters are properly handled.
Tests: fast/parser/xhtml-innerhtml-null-byte-first.xhtml
fast/parser/xhtml-innerhtml-null-byte.xhtml
* dom/XMLDocumentParser.h:
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLParserContext::createMemoryParser):
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::XMLDocumentParser::appendFragmentSource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Thu, 16 Jun 2011 01:09:05 +0000 (01:09 +0000)]
2011-06-15 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Tests that accessing the parent stylesheet in nodes (not in document)
do not result in crash when document is cleared.
https://bugs.webkit.org/show_bug.cgi?id=62586
* fast/dom/body-clone-link-decl-parent-crash-expected.txt: Added.
* fast/dom/body-clone-link-decl-parent-crash.html: Added.
* fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt: Added.
* fast/dom/styled-clone-inline-style-decl-parent-crash.html: Added.
* fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt: Added.
* fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html: Added.
2011-06-15 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Revert speculative fix in r84151. It caused some issues with
stylesheet lifetimes.
https://bugs.webkit.org/show_bug.cgi?id=62586
Tests: fast/dom/body-clone-link-decl-parent-crash.html
fast/dom/styled-clone-inline-style-decl-parent-crash.html
fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Sam Weinig [Thu, 16 Jun 2011 00:12:12 +0000 (00:12 +0000)]
2011-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=62764
This is an non-reproducible high volume crash, so no test :(.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
Be conservative and stop loading when we detach a document loader from a frame.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Tue, 21 Jun 2011 16:55:41 +0000 (13:55 -0300)]
2011-06-14 Jeffrey Pfau <jpfau@apple.com>
Reviewed by David Hyatt.
Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028
Added test for spanning elements within an inline-block child of a multicol element.
* fast/multicol/span/span-as-nested-inline-block-child.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
2011-06-14 Jeffrey Pfau <jpfau@apple.com>
Reviewed by David Hyatt.
Null dereference in WebCore::RenderBlock::splitFlow regarding use of multicol, inline-block, and spanning elements
https://bugs.webkit.org/show_bug.cgi?id=60028
Ensure that the parent block of a spanning element, if it is not itself
a multicol element, is not inline.
Test: fast/multicol/span/span-as-nested-inline-block-child.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
LayoutTests/platform/chromium/test_expectations.txt
Ademar de Souza Reis Jr [Tue, 21 Jun 2011 16:22:37 +0000 (13:22 -0300)]
2011-06-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] GraphicsLayer: support plugins on symbian
https://bugs.webkit.org/show_bug.cgi?id=57418
Implement graphics layer for plugins on Symbian.
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::platformStart):
* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::shouldUseAcceleratedCompositing):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebCore/plugins/qt/PluginViewQt.cpp
commit-queue [Thu, 16 Jun 2011 08:50:21 +0000 (08:50 +0000)]
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88796.
http://trac.webkit.org/changeset/88796
https://bugs.webkit.org/show_bug.cgi?id=62790
It made fast/dom/nodesFromRect-basic.html time out on Qt,
64-bit, debug mode (Requested by Ossy on #webkit).
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88796.
http://trac.webkit.org/changeset/88796
https://bugs.webkit.org/show_bug.cgi?id=62790
It made fast/dom/nodesFromRect-basic.html time out on Qt,
64-bit, debug mode (Requested by Ossy on #webkit).
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::plainText):
(DumpRenderTreeSupportQt::nodesFromRect):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::overloadedSlots):
(tst_QWebFrame::domCycles):
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88796.
http://trac.webkit.org/changeset/88796
https://bugs.webkit.org/show_bug.cgi?id=62790
It made fast/dom/nodesFromRect-basic.html time out on Qt,
64-bit, debug mode (Requested by Ossy on #webkit).
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::nodesFromRect):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/PlainTextControllerQt.cpp:
(PlainTextController::plainText):
* DumpRenderTree/qt/PlainTextControllerQt.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Fri, 17 Jun 2011 15:08:09 +0000 (15:08 +0000)]
2011-06-17 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
https://bugs.webkit.org/show_bug.cgi?id=62815
Partially revert r85870 which assumed that QtWebKit will never be build inside Qt
anymore. Everything inside !QTDIR_build condition is not needed in the Qt tree because
qbase.pri is doing the job for us, i.e. using includes generated by syncqt to
setup the mac framework. It also use a correct QMAKE_LFLAGS_SONAME making possible
to actually run an application linked against QtWebKit.
* QtWebKit.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Diego Gonzalez [Wed, 15 Jun 2011 15:08:23 +0000 (15:08 +0000)]
2011-06-15 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Inconsistent behavior on a form submit request...
https://bugs.webkit.org/show_bug.cgi?id=45523
The inconsistency occurs when a form submission requests a new window.
Two windows are opened (instead of only one) and the first window is opened
as a blank page.
By default each page is put into their own unique page group, which affects popup windows
and visited links. Page groups (per process only) is a feature making it possible to use
separate settings for each group, so that for instance an integrated browser/email reader
can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
as expected out of the box, we use a default group similar to what other ports are doing.
* Api/qwebpage.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Andreas Kling [Tue, 14 Jun 2011 13:42:40 +0000 (13:42 +0000)]
2011-06-14 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Don't include convenience "QWebFoo" headers in WebKit code.
https://bugs.webkit.org/show_bug.cgi?id=62632
* WebCoreSupport/FrameNetworkingContextQt.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Mon, 13 Jun 2011 23:20:47 +0000 (23:20 +0000)]
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Added a test that tries to remove the children of munder, mover and munderover elements.
* mathml/munderover-remove-children-expected.txt: Added.
* mathml/munderover-remove-children.html: Added.
2011-06-13 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Darin Adler.
Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900
Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.
Test: mathml/munderover-remove-children.html
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::nonOperatorHeight):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ryosuke Niwa [Mon, 13 Jun 2011 20:46:24 +0000 (20:46 +0000)]
2011-06-13 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544
Fixed the crash by adding null pointer checks.
No new tests since there's no way to open dictionary panel.
* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
* editing/VisiblePosition.cpp:
(WebCore::makeRange):
* page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Tue, 14 Jun 2011 14:32:55 +0000 (11:32 -0300)]
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Increase the likeness that JSElements are converted to QWebElements. When hinted
with QWebElement metatype, we qualify the conversion from JSElement as a "perfect
match".
The test was failing because the wrong slot was called, since the QWebElement
match was taken as equal to the others and not chosen when the metacall happened.
We also remove the implicit conversion between JSDocument (which is not an
element) to QWebElement. The conversion only worked for calling slots, while
without hint it returned a QVariantMap (as can be seen in domCycles test). It was
added for supporting DRT, but since this change we can use it as QVariantMap and
get the value for "documentElement".
This patch is based on Noam Rosenthal original patch in the same bug.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::hintForRealType):
Extracted function to choose the metatype hint based on the JSValue type. Add
QWebElement metatype as a hint for JSElement objects, this way if no hint is
provided, JSElement objects will always be converted to QWebElements.
(JSC::Bindings::convertValueToQVariant):
Use previous function. Identify the conversion between JSElement to QWebElement
as a "perfect match" (dist = 0). And remove the implicit conversion when the hint
is QWebElement metatype and we have a JSDocument. Changed from JSHTMLElement to
JSElement to cover the 'documentElement'.
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Since the implicit conversion was removed, change support functions of DRT to
expect a QVariantMap instead of a QWebElement. This matches the exposed function
in the controller, which takes 'document' and not 'document.documentElement'.
And now that Element -> QWebElement is a perfect match, we must use QWebElement
instead of QVariantMap, like in plainText().
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
QVariantMap when getting the startContainer. Also use QVariantMap directly,
bridge will do conversion for us now.
(getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
QVariantMap that Qt bridge gives us when 'document' is passed from JS.
(DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
* tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
different tests. In practice, the original test just checked whether we could
create a QVariantMap representing 'document' without infinite looping due to
cycles in the DOM. This was more evident before since we haven't a conversion
from JSElement to QWebElement, but from JSElement to QVariantMap.
(tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
'documentElement' from it. Compares to QWebFrame::documentElement().
(tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
the documentElement.
(tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Andreas Kling.
[Qt] tst_QWebFrame::overloadedSlots() fails
https://bugs.webkit.org/show_bug.cgi?id=37319
Since we don't implictly convert 'document' object to QWebElement
in metacalls anymore, change the controller to expect QVariantMap instead.
The method plainText() was updated to use QVariantMap as well to let the bridge
do the conversion directly for us.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::nodesFromRect):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/PlainTextControllerQt.cpp:
(PlainTextController::plainText):
* DumpRenderTree/qt/PlainTextControllerQt.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
Dan Bernstein [Sun, 12 Jun 2011 18:27:00 +0000 (18:27 +0000)]
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N^2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557
Reviewed by Darin Adler.
Replaced the fix for bug 58500 with a refined version.
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Sat, 11 Jun 2011 16:37:59 +0000 (16:37 +0000)]
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
when removed from document, set them when reinserted into document.
https://bugs.webkit.org/show_bug.cgi?id=62230
When a HTMLBodyElement, StyledElement are removed from document,
we didn't clear out the parent pointers from their link, style declarations.
These parent pointers pointed to the document's element sheet which will
get removed when document is getting destroyed. It does make sense to
clear out parent pointers when we are getting removed from document and
readd them when we get inserted again.
Tests: fast/dom/body-link-decl-parent-crash.html
fast/dom/styled-inline-style-decl-parent-crash.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::insertedIntoDocument):
(WebCore::StyledElement::removedFromDocument):
* dom/StyledElement.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute):
(WebCore::HTMLBodyElement::insertedIntoDocument):
(WebCore::HTMLBodyElement::removedFromDocument):
(WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
* html/HTMLBodyElement.h:
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Simon Fraser.
Tests that accessing the parent element sheet of an inline style, link
declaration of styled, body elements which are removed from document,
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62230
* fast/dom/body-link-decl-parent-crash-expected.txt: Added.
* fast/dom/body-link-decl-parent-crash.html: Added.
* fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
* fast/dom/styled-inline-style-decl-parent-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Abhishek Arya [Fri, 10 Jun 2011 17:31:29 +0000 (17:31 +0000)]
2011-06-10 Abhishek Arya <inferno@chromium.org>
Reviewed by Tony Gentilcore.
Tests that trying to remove all document children while building a svg <use>
element shadow and instance tree does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62225
* svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
* svg/dom/use-style-recalc-script-execute-crash.html: Added.
2011-06-10 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
Don't execute scripts in shadow SVG.
https://bugs.webkit.org/show_bug.cgi?id=62225
Test: svg/dom/use-style-recalc-script-execute-crash.html
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Jian Li [Fri, 10 Jun 2011 01:09:11 +0000 (01:09 +0000)]
Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
* fast/files/blob-builder-crash-expected.txt: Added.
* fast/files/blob-builder-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Gavin Barraclough [Fri, 10 Jun 2011 00:30:21 +0000 (00:30 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Geoff Garen.
Fix geoff's review comments re static_cast.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Gavin Barraclough [Thu, 9 Jun 2011 23:46:54 +0000 (23:46 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Oliver Hunt.
There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.
Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.
These errors result in three test-262 failures.
Source/JavaScriptCore:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::push):
LayoutTests:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Thu, 9 Jun 2011 20:33:20 +0000 (20:33 +0000)]
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Adding test to cover the regression. The test actually uncovered
a bug in the way we handle alternate stylesheet and thus is
failing some parts.
* fast/css/link-disabled-attr-expected.txt: Added.
* fast/css/link-disabled-attr.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Test: fast/css/link-disabled-attr.html
Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!
The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
replaced by m_isEnabledViaScript.
(WebCore::HTMLLinkElement::setDisabled): Updated the logic after
m_disabledState removal. It also matches the spec by forwarding
the disabled state to our stylesheet if we have one.
(WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
handling of the disabledAttr.
(WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
(WebCore::HTMLLinkElement::isAlternate): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Andreas Kling [Fri, 10 Jun 2011 11:31:23 +0000 (11:31 +0000)]
2011-06-10 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] Fix 'headers' autotest when building inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=62449
* Api/qwebkitplatformplugin.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Simon Fraser [Thu, 9 Jun 2011 20:05:51 +0000 (20:05 +0000)]
2011-06-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159
Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Julien Chaffraix [Thu, 9 Jun 2011 19:52:27 +0000 (19:52 +0000)]
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
* fast/css/webkit-keyframes-crash-expected.txt: Added.
* fast/css/webkit-keyframes-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
to return a non-null pointer. Thus null-check here like the rest of the code.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Adam Barth [Thu, 9 Jun 2011 00:34:13 +0000 (00:34 +0000)]
2011-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use after free in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=62160
Test that we don't trigger asserts when re-entering the parser from
tree construction.
* fast/parser/document-write-onload-nesting-expected.txt: Added.
* fast/parser/document-write-onload-nesting.html: Added.
* fast/parser/document-write-onload-ordering-expected.txt: Added.
* fast/parser/document-write-onload-ordering.html: Added.
- The exact ordering of the script execution here differs a bit
between browsers. For example, Firefox executes the scripts in a
slightly different order because Firefox runs the parser on a
separate thread (and therefore cannot be re-entered from tree
construction). If/when we move the parser off the main thread,
we're likely to change the ordering here a bit, which should be
ok.
2011-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
constructTreeFromToken can re-enter parser, causing ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=62160
This patch clears the HTMLToken before constructing the tree from the
token, putting the HTMLDocumentParser in a good state to be re-entered.
Tests: fast/parser/document-write-onload-nesting.html
fast/parser/document-write-onload-ordering.html
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::isUninitialized):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Andras Becsi [Thu, 9 Jun 2011 16:05:08 +0000 (16:05 +0000)]
2011-06-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix the in-tree build on Linux
https://bugs.webkit.org/show_bug.cgi?id=62378
In case of an in-tree build qmake generates defect prl dependencies for
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
* QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Junior [Wed, 8 Jun 2011 17:14:30 +0000 (17:14 +0000)]
2011-06-08 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
Webkit on SPARC Solaris has wrong endian
https://bugs.webkit.org/show_bug.cgi?id=29407
Bug 57256 fixed one crash on misaligned reads on sparc/solaris, but
there are more ocurrences of the same code pattern in webkit.
This patch includes the check on these other parts of the code.
This is a speculative fix, I don't have a sparc machine to test and
don't know which kind of test would trigger a crash (but it's quite
obvious that it's the same code duplicated in different files).
* runtime/UString.h:
(JSC::UStringHash::equal):
* wtf/text/StringHash.h:
(WTF::StringHash::equal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Yael Aharon [Wed, 8 Jun 2011 15:28:27 +0000 (15:28 +0000)]
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -ljavascriptcore
into QtWebKit.prl.
No new tests, as this is just a build fix.
* JavaScriptCore.pri:
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
into QtWebKit.prl.
No new tests, as this is just a build fix.
* WebCore.pri:
2011-06-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Build fix for building QtWebKit inside of Qt.
https://bugs.webkit.org/show_bug.cgi?id=62280
Remove CONFIG=staticlib, because it causes the configure script to add -lwebkit2
into QtWebKit.prl.
* WebKit2.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Andreas Kling [Wed, 8 Jun 2011 12:52:34 +0000 (12:52 +0000)]
2011-06-08 Andreas Kling <kling@webkit.org>
Reviewed by Benjamin Poulain.
[Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
https://bugs.webkit.org/show_bug.cgi?id=62274
Vector::find() returns size_t (which is unsigned), so we should check
for WTF::notFound instead of -1.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Wed, 8 Jun 2011 14:41:31 +0000 (11:41 -0300)]
2011-06-08 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Laszlo Gombos.
[Symbian] Float{32,64}Array and Int16Array fail to build.
https://bugs.webkit.org/show_bug.cgi?id=62219
For some reason, RVCT 2.x is moaning about "class member designated by
a using-declaration must be visible in a direct base class".
Apply same fix as r69122 and r76592.
* html/canvas/Float32Array.h:
(WebCore::Float32Array::set):
* html/canvas/Float64Array.h:
(WebCore::Float64Array::set):
* html/canvas/Int16Array.h:
(WebCore::Int16Array::set):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebCore/html/canvas/Float64Array.h
Yi Shen [Wed, 8 Jun 2011 02:44:35 +0000 (02:44 +0000)]
2011-06-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901
Unskip the tests which are now passing.
* platform/qt/Skipped:
2011-06-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix the error code for media resource failures when using QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901
To indicate the media resource failures, set the network state to
MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
QMediaPlayer::ResourceError.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::updateStates):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 7 Jun 2011 19:17:41 +0000 (19:17 +0000)]
2011-06-07 Aravind Akella <aravind.akella@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] API test failure qdeclarativewebview
https://bugs.webkit.org/show_bug.cgi?id=59481
QML files cannot be loaded on Symbian due to difference
in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
missing is observed when dynamically loading the QML plugin.
* declarative/declarative.pro: Match capabilities in QtWebKit.pro.
* symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs.
Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL,
and causes build warnings about undefined VENDOR_VID.
* tests/tests.pri: Add WriteDeviceData capability for API tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Andreas Kling [Tue, 7 Jun 2011 13:22:31 +0000 (13:22 +0000)]
2011-06-07 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Fix Symbian build with RVCT 2.x
https://bugs.webkit.org/show_bug.cgi?id=62205
RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
option, so restrict it to version 4.x of the compiler.
* Source/WebKit.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Sun, 5 Jun 2011 18:34:07 +0000 (18:34 +0000)]
2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
Rebaseline tests.
* fast/viewport/viewport-45-expected.txt:
* fast/viewport/viewport-86-expected.txt:
* platform/qt/Skipped:
2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
fast/viewport/viewport-45.html fails in GTK+/Qt
https://bugs.webkit.org/show_bug.cgi?id=47481
computeViewportAttributes does many math operations with float point arithmetic
and in some cases there is loss of precision making tests have incorrect values.
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Mon, 6 Jun 2011 16:59:01 +0000 (13:59 -0300)]
Skip fast/forms/selectlist-minsize.html on mac
New test introduced in r88029, but fails on Qt-Mac. Also skipped in
trunk by r88141.
Ademar de Souza Reis Jr [Mon, 6 Jun 2011 16:49:31 +0000 (13:49 -0300)]
Skip editing/pasteboard tests on mac which are failing on QtWebKit-2.2
5 editing/pasteboard tests are failing on our 2.2 mac bots because
their actual results are including meta tags like this:
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
Disabling them for now.
Csaba Osztrogonác [Mon, 6 Jun 2011 14:52:19 +0000 (14:52 +0000)]
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
* QtTestBrowser/launcherwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Mon, 6 Jun 2011 13:19:23 +0000 (13:19 +0000)]
2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::downloadRequest):
(LauncherWindow::fileDownloadFinished):
* QtTestBrowser/launcherwindow.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Ademar de Souza Reis Jr [Mon, 6 Jun 2011 14:46:15 +0000 (11:46 -0300)]
2011-06-04 Abhishek Arya <inferno@chromium.org>
Reviewed by Kent Tamura.
Add some asserts for array boundary checks in TextRun. Fix
an integer issue in linux text controller code.
https://bugs.webkit.org/show_bug.cgi?id=62085
Testing ComplexTextControllerLinux change requires a testcase
> 32 kb which is not feasible. All other changes are tested by
existing layouttests.
* platform/graphics/TextRun.h:
(WebCore::TextRun::operator[]): add assert.
(WebCore::TextRun::data): add assert.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): bail early and prevent access
to one byte across the text run boundary.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::getNormalizedTextRun): wrong
int16 vs int comparison.
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunWalker::walk): bail early when from and to
is outside the text run boundary. this hit easily after adding
the assert when from = to = end and read in run.data(from).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Conflicts:
Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp
commit-queue [Sat, 4 Jun 2011 10:32:26 +0000 (10:32 +0000)]
2011-06-04 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Beth Dakin.
Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897
Added simple test that hits the relevant code.
* mathml/msubsup-remove-children-expected.txt: Added.
* mathml/msubsup-remove-children.xhtml: Added.
2011-06-04 Jeffrey Pfau <jpfau@apple.com>
Reviewed by Beth Dakin.
Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897
Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::baselinePosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue [Fri, 3 Jun 2011 21:53:04 +0000 (21:53 +0000)]
2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>
Reviewed by Andreas Kling.
[Qt] It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847
Modified failing test's base url so it could get a valid origin
and make use of local storage. Also added another test that checks
local storage visibility in both scenarios.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::testOptionalJSObjects):
(checkLocalStorageVisibility):
(tst_QWebPage::testLocalStorageVisibility):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
Alexis Menard [Fri, 3 Jun 2011 21:02:07 +0000 (21:02 +0000)]
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Warning fixes on comparisons between a signed and an unsigned.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
(DumpRenderTreeSupportQt::nodesFromRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Fri, 3 Jun 2011 20:32:47 +0000 (20:32 +0000)]
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
* WebCoreSupport/FrameLoaderClientQt.h:
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
* platform/network/qt/QtMIMETypeSniffer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
projects / webkit:qtwebkit.git / log