2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
authorLeo Yang <leo.yang@torchmobile.com.cn>
Wed, 25 May 2011 01:26:53 +0000 (01:26 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Wed, 25 May 2011 14:16:16 +0000 (11:16 -0300)
commit46706ea79a39428107c462ad040a3767ac9cb47a
treee7855035a47fcbbaa8155a7107fd9c9ad709eda7
parentf8d4988d5aa8f5d5e3255df77164d6fea6fef787
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
        before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.

        Test: editing/pasteboard/drag-drop-input-in-svg.svg

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Test case to verify dragging and dropping text between input fields
        inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.

        Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.

        * editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
        * editing/pasteboard/drag-drop-input-in-svg.svg: Added.
        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/pasteboard/drag-drop-input-in-svg-expected.txt [new file with mode: 0644]
LayoutTests/editing/pasteboard/drag-drop-input-in-svg.svg [new file with mode: 0644]
LayoutTests/platform/qt/Skipped
Source/WebCore/ChangeLog
Source/WebCore/editing/ReplaceSelectionCommand.cpp