2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com> qtwebkit-2.1-week39
authorBenjamin Poulain <benjamin.poulain@nokia.com>
Thu, 30 Sep 2010 07:22:51 +0000 (07:22 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Fri, 1 Oct 2010 13:10:50 +0000 (10:10 -0300)
commit35e5a3e35bd4fe217733925df252b74efda4d37e
treeccb56aea2b771e8d38940740c4e8d573a3f8eb5a
parent13e454d7c2a249d2e50298537c91d76d65f70c01
2010-09-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Crash if an scene with accelerated compositing layout during the paint event
        https://bugs.webkit.org/show_bug.cgi?id=46812

        Delay the deletion of the overlay after the current event is processed.

        Removing the overlay can sometimes be done inside the rendering code of
        the overlay itself. When the rendering code is using the reference after
        the deletion of the overlay, WebKit crashes.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::overlay):
        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
        (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
        * WebCoreSupport/PageClientQt.h:
        (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit/qt/Api/qgraphicswebview.cpp
WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/PageClientQt.cpp
WebKit/qt/WebCoreSupport/PageClientQt.h