2011-06-30 Julien Chaffraix <jchaffraix@webkit.org>
authorJulien Chaffraix <jchaffraix@webkit.org>
Thu, 30 Jun 2011 21:51:17 +0000 (21:51 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Tue, 2 Aug 2011 18:02:34 +0000 (15:02 -0300)
commit2f842a47d379271e800cf54584d6aca0a5d106c9
treef879cc2c064f1322cdf5af5ea310ca95d5cd3546
parent899ebf52af7b8e39652fb88f54ab7b9fbbaf68f1
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        * svg/custom/crash-textPath-attributes-expected.txt: Added.
        * svg/custom/crash-textPath-attributes.html: Added.
        * svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.
2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Update SVG position values on SVG DOM updates
        https://bugs.webkit.org/show_bug.cgi?id=62439

        Test: svg/custom/crash-textPath-attributes.html

        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
        to update its positioning information.

        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
        like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).

        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
        our cached layout attributes every time we invalidate them. This avoids keeping stale
        attribute that have a backpointer to a RenderObject.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/custom/crash-textPath-attributes-expected.txt [new file with mode: 0644]
LayoutTests/svg/custom/crash-textPath-attributes.html [new file with mode: 0755]
LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg [new file with mode: 0755]
Source/WebCore/ChangeLog
Source/WebCore/rendering/svg/RenderSVGInline.cpp
Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp
Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp