2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>
authorcommit-queue <commit-queue@webkit.org>
Fri, 3 Jun 2011 17:03:21 +0000 (17:03 +0000)
committerAdemar de Souza Reis Jr <ademar.reis@openbossa.org>
Fri, 3 Jun 2011 20:36:41 +0000 (17:36 -0300)
commit2e981d382127127856ecdd06e086dbb42ae1e52e
tree5cea11eef25e89faad53d86821d67a4df8ebdc88
parentdbda3e9596b836ab6eb88c500766dba6745759be
2011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt]The minimum size of the select menu list is incorrect for qtwebkit
        https://bugs.webkit.org/show_bug.cgi?id=56752

        The test is to get the render tree of select menu lists with varying widths based on content.
        Some select list based tests are rebaselined because minimum width of RenderMenuList changes
        based on the content with this fix.

        * fast/forms/selectlist-minsize.html: Added.
        * platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
        * platform/qt/editing/pasteboard/4641033-expected.txt:
        * platform/qt/editing/pasteboard/4944770-1-expected.txt:
        * platform/qt/editing/pasteboard/4944770-2-expected.txt:
        * platform/qt/editing/selection/caret-before-select-expected.txt:
        * platform/qt/fast/forms/003-expected.txt:
        * platform/qt/fast/forms/004-expected.txt:
        * platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
        * platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
        * platform/qt/fast/forms/basic-selects-expected.txt:
        * platform/qt/fast/forms/menulist-deselect-update-expected.txt:
        * platform/qt/fast/forms/menulist-separator-painting-expected.txt:
        * platform/qt/fast/forms/menulist-style-color-expected.txt:
        * platform/qt/fast/forms/option-script-expected.txt:
        * platform/qt/fast/forms/select-background-none-expected.txt:
        * platform/qt/fast/forms/select-baseline-expected.txt:
        * platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
        * platform/qt/fast/forms/select-empty-option-height-expected.txt:
        * platform/qt/fast/forms/select-size-expected.txt:
        * platform/qt/fast/forms/select-style-expected.txt:
        * platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
        * platform/qt/fast/invalid/014-expected.txt:
        * platform/qt/fast/replaced/replaced-breaking-expected.txt:
        * platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
        * platform/qt/fast/replaced/three-selects-break-expected.txt:
        * platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
        * platform/qt/tables/mozilla/core/margins-expected.txt:
2011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt]The minimum size of the select menu list is incorrect for qtwebkit
        https://bugs.webkit.org/show_bug.cgi?id=56752

        The minimum width of the select-box is calculated to be as small as possible
        instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
        This will avoid overapping the select lists in popular websites.

        Test: fast/forms/selectlist-minsize.html

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::minimumMenuListSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
31 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/forms/selectlist-minsize.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/selectlist-minsize-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/editing/pasteboard/4641033-expected.txt
LayoutTests/platform/qt/editing/pasteboard/4944770-1-expected.txt
LayoutTests/platform/qt/editing/pasteboard/4944770-2-expected.txt
LayoutTests/platform/qt/editing/selection/caret-before-select-expected.txt
LayoutTests/platform/qt/fast/forms/003-expected.txt
LayoutTests/platform/qt/fast/forms/004-expected.txt
LayoutTests/platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt
LayoutTests/platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt
LayoutTests/platform/qt/fast/forms/basic-selects-expected.txt
LayoutTests/platform/qt/fast/forms/menulist-deselect-update-expected.txt
LayoutTests/platform/qt/fast/forms/menulist-separator-painting-expected.txt
LayoutTests/platform/qt/fast/forms/menulist-style-color-expected.txt
LayoutTests/platform/qt/fast/forms/option-script-expected.txt
LayoutTests/platform/qt/fast/forms/select-background-none-expected.txt
LayoutTests/platform/qt/fast/forms/select-baseline-expected.txt
LayoutTests/platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt
LayoutTests/platform/qt/fast/forms/select-empty-option-height-expected.txt
LayoutTests/platform/qt/fast/forms/select-size-expected.txt
LayoutTests/platform/qt/fast/forms/select-style-expected.txt
LayoutTests/platform/qt/fast/forms/selectlist-minsize-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/fast/invalid/014-expected.txt
LayoutTests/platform/qt/fast/replaced/replaced-breaking-expected.txt
LayoutTests/platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt
LayoutTests/platform/qt/fast/replaced/three-selects-break-expected.txt
LayoutTests/platform/qt/tables/mozilla/bugs/bug29326-expected.txt
LayoutTests/platform/qt/tables/mozilla/core/margins-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/platform/qt/RenderThemeQt.cpp