1 2011-07-01 Jade Han <jade.han@nokia.com>
3 Reviewed by Laszlo Gombos.
5 [Qt][Symbian] Update .def file for Symbian
6 https://bugs.webkit.org/show_bug.cgi?id=61200
8 Add newly introduced symbols to fix the Symbian build.
10 * symbian/eabi/QtWebKitu.def:
12 2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>
14 Reviewed by Benjamin Poulain.
16 [Qt] QML Webview causes performance drops
17 https://bugs.webkit.org/show_bug.cgi?id=57554
19 Remove tiledBackingStoreEnabled from QML WebView.
21 * declarative/qdeclarativewebview.cpp:
22 (QDeclarativeWebView::setPage):
24 2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
26 Reviewed by Benjamin Poulain.
28 [Qt] Add Qt dependencies in QtWebKit's main pro file.
29 https://bugs.webkit.org/show_bug.cgi?id=63639
31 syncqt, the script which generates the headers inside Qt parses
32 the main pro file of QtWebKit to check the Qt dependencies. It used
33 to be WebCore.pro but after the build reorganization QtWebKit.pro is
34 the new main pro file so we need to add the network dependency just like
35 we did in WebCore.pro.
39 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
41 Rubber-stamped by Andreas Kling.
43 [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
44 https://bugs.webkit.org/show_bug.cgi?id=63235
46 [Qt] Fix tst_QWebFrame::renderGeometry() API test
47 https://bugs.webkit.org/show_bug.cgi?id=63236
49 [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
50 https://bugs.webkit.org/show_bug.cgi?id=63237
52 * tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
53 (tst_QWebFrame::setHtmlWithResource):
54 (tst_QWebFrame::renderGeometry):
56 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
58 Rubber-stamped by Andreas Kling.
60 [Qt] Fix tst_QWebPage::showModalDialog() API test
61 https://bugs.webkit.org/show_bug.cgi?id=63244
63 [Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
64 https://bugs.webkit.org/show_bug.cgi?id=63245
66 * tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
67 (tst_QWebPage::showModalDialog):
68 (tst_QWebPage::testStopScheduledPageRefresh):
70 2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
72 Reviewed by Andreas Kling.
74 [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
75 https://bugs.webkit.org/show_bug.cgi?id=63562
77 Some Qt auto-tests rely on <QtX/x.h> types of includes.
79 * Api/qwebkitplatformplugin.h:
80 * symbian/platformplugin/qwebkitplatformplugin.h:
82 2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
84 Reviewed by Andreas Kling.
86 [Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
87 https://bugs.webkit.org/show_bug.cgi?id=63533
89 We need to use the new QtQuick 1.x imports rather than the old deprecated
92 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
93 * tests/qdeclarativewebview/resources/webviewtest.qml:
94 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
96 2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
98 Reviewed by Andreas Kling.
100 [Qt] tst_QWebFrame::overloadedSlots() fails
101 https://bugs.webkit.org/show_bug.cgi?id=37319
103 * tests/qwebframe/tst_qwebframe.cpp:
104 (tst_QWebFrame::overloadedSlots): Remove expected failure and
107 2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
109 Reviewed by Kenneth Rohde Christiansen.
111 [Qt] Remove Phonon MediaPlayer from the tree.
112 https://bugs.webkit.org/show_bug.cgi?id=63448
114 Remove Phonon related stuff.
116 * docs/qtwebkit.qdocconf:
117 * qt_webkit_version.pri:
119 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
121 Rubber-stamped by Andreas Kling.
123 [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
124 https://bugs.webkit.org/show_bug.cgi?id=63235
126 [Qt] Fix tst_QWebFrame::renderGeometry() API test
127 https://bugs.webkit.org/show_bug.cgi?id=63236
129 [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
130 https://bugs.webkit.org/show_bug.cgi?id=63237
132 * tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
133 (tst_QWebFrame::setHtmlWithResource):
134 (tst_QWebFrame::renderGeometry):
136 2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
138 Rubber-stamped by Andreas Kling.
140 [Qt] Fix tst_QWebPage::showModalDialog() API test
141 https://bugs.webkit.org/show_bug.cgi?id=63244
143 [Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
144 https://bugs.webkit.org/show_bug.cgi?id=63245
146 * tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
147 (tst_QWebPage::showModalDialog):
148 (tst_QWebPage::testStopScheduledPageRefresh):
150 2011-06-23 Joe Wild <joseph.wild@nokia.com>
152 Reviewed by Laszlo Gombos.
154 [Qt] Export files under Symbian Qt WebKit build
155 https://bugs.webkit.org/show_bug.cgi?id=61207
157 Export files for the Symbian platform as this is needed by the
158 production build system.
160 Janne Koskinen provided the suggestion to use target_predeps,
161 which is an improvement over the originally suggested patch.
165 2011-06-23 Joe Wild <joseph.wild@nokia.com>
167 Reviewed by Laszlo Gombos.
169 [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
170 https://bugs.webkit.org/show_bug.cgi?id=61200
172 Revert r87060 as it broke compatibility with QtWebKit 2.1 release
173 and add some newly introduce symbols.
175 * symbian/eabi/QtWebKitu.def:
177 2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
179 Reviewed by Holger Freyther.
181 [Qt] Fix Qt namespace on QDeclarativeWebView autotest
182 https://bugs.webkit.org/show_bug.cgi?id=63147
184 Applications (such as the test runner) are not supposed to be wrapped
185 by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
186 QtWebKit) with a specific namespace won't work (will result in main
189 This was the only test wrapped by these macros, all others are fine.
191 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
194 2011-06-21 Yael Aharon <yael.aharon@nokia.com>
196 Reviewed by Andreas Kling.
198 [Qt] Regression(60942) wrong default action for drag-and-drop.
199 https://bugs.webkit.org/show_bug.cgi?id=63004
201 Added special handling for the case that dragOperation is not initialized.
202 Save the last dropOperation and pass it to the dropEvent, so that it can
203 be accepted by QDrag.
204 Call event->accepted() and not event->acceptProposedAction(), because the
205 later ignores the dropAction specified in JavaScript.
207 Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
208 and did not see any issue.
209 Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
213 (dropActionToDragOp):
214 (QWebPagePrivate::dragMoveEvent):
215 (QWebPagePrivate::dropEvent):
217 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
219 Unreviewed, rolling out r88796.
220 http://trac.webkit.org/changeset/88796
221 https://bugs.webkit.org/show_bug.cgi?id=62790
223 It made fast/dom/nodesFromRect-basic.html time out on Qt,
224 64-bit, debug mode (Requested by Ossy on #webkit).
226 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
227 (DumpRenderTreeSupportQt::plainText):
228 (DumpRenderTreeSupportQt::nodesFromRect):
229 * WebCoreSupport/DumpRenderTreeSupportQt.h:
230 * tests/qwebframe/tst_qwebframe.cpp:
231 (tst_QWebFrame::overloadedSlots):
232 (tst_QWebFrame::domCycles):
234 2011-06-17 Alexis Menard <alexis.menard@openbossa.org>
236 Reviewed by Andreas Kling.
238 [Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
239 https://bugs.webkit.org/show_bug.cgi?id=62815
241 Partially revert r85870 which assumed that QtWebKit will never be build inside Qt
242 anymore. Everything inside !QTDIR_build condition is not needed in the Qt tree because
243 qbase.pri is doing the job for us, i.e. using includes generated by syncqt to
244 setup the mac framework. It also use a correct QMAKE_LFLAGS_SONAME making possible
245 to actually run an application linked against QtWebKit.
249 2011-06-15 Diego Gonzalez <diegohcg@webkit.org>
251 Reviewed by Kenneth Rohde Christiansen.
253 [Qt] Inconsistent behavior on a form submit request...
254 https://bugs.webkit.org/show_bug.cgi?id=45523
256 The inconsistency occurs when a form submission requests a new window.
257 Two windows are opened (instead of only one) and the first window is opened
260 By default each page is put into their own unique page group, which affects popup windows
261 and visited links. Page groups (per process only) is a feature making it possible to use
262 separate settings for each group, so that for instance an integrated browser/email reader
263 can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
264 as expected out of the box, we use a default group similar to what other ports are doing.
268 2011-06-14 Andreas Kling <kling@webkit.org>
270 Reviewed by Benjamin Poulain.
272 [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
273 https://bugs.webkit.org/show_bug.cgi?id=62632
275 * WebCoreSupport/FrameNetworkingContextQt.cpp:
277 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
279 Reviewed by Andreas Kling.
281 [Qt] tst_QWebFrame::overloadedSlots() fails
282 https://bugs.webkit.org/show_bug.cgi?id=37319
284 Since the implicit conversion was removed, change support functions of DRT to
285 expect a QVariantMap instead of a QWebElement. This matches the exposed function
286 in the controller, which takes 'document' and not 'document.documentElement'.
288 And now that Element -> QWebElement is a perfect match, we must use QWebElement
289 instead of QVariantMap, like in plainText().
291 * WebCoreSupport/DumpRenderTreeSupportQt.h:
292 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
293 (DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
294 QVariantMap when getting the startContainer. Also use QVariantMap directly,
295 bridge will do conversion for us now.
297 (getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
298 QVariantMap that Qt bridge gives us when 'document' is passed from JS.
300 (DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
302 * tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
303 different tests. In practice, the original test just checked whether we could
304 create a QVariantMap representing 'document' without infinite looping due to
305 cycles in the DOM. This was more evident before since we haven't a conversion
306 from JSElement to QWebElement, but from JSElement to QVariantMap.
308 (tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
309 'documentElement' from it. Compares to QWebFrame::documentElement().
311 (tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
314 (tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
316 2011-06-10 Andreas Kling <kling@webkit.org>
318 Reviewed by Benjamin Poulain.
320 [Qt] Fix 'headers' autotest when building inside Qt.
321 https://bugs.webkit.org/show_bug.cgi?id=62449
323 * Api/qwebkitplatformplugin.h:
325 2011-06-09 Andras Becsi <abecsi@webkit.org>
327 Reviewed by Andreas Kling.
329 [Qt] Fix the in-tree build on Linux
330 https://bugs.webkit.org/show_bug.cgi?id=62378
332 In case of an in-tree build qmake generates defect prl dependencies for
333 the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
335 * QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
337 2011-06-08 Andreas Kling <kling@webkit.org>
339 Reviewed by Benjamin Poulain.
341 [Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
342 https://bugs.webkit.org/show_bug.cgi?id=62274
344 Vector::find() returns size_t (which is unsigned), so we should check
345 for WTF::notFound instead of -1.
347 * WebCoreSupport/FrameLoaderClientQt.cpp:
348 (WebCore::FrameLoaderClientQt::createPlugin):
350 2011-06-07 Aravind Akella <aravind.akella@nokia.com>
352 Reviewed by Laszlo Gombos.
354 [Qt][Symbian] API test failure qdeclarativewebview
355 https://bugs.webkit.org/show_bug.cgi?id=59481
357 QML files cannot be loaded on Symbian due to difference
358 in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
359 A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
360 missing is observed when dynamically loading the QML plugin.
362 * declarative/declarative.pro: Match capabilities in QtWebKit.pro.
363 * symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs.
364 Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL,
365 and causes build warnings about undefined VENDOR_VID.
366 * tests/tests.pri: Add WriteDeviceData capability for API tests.
368 2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>
370 Reviewed by Andreas Kling.
372 [Qt] It made two Qt API tests fail
373 https://bugs.webkit.org/show_bug.cgi?id=58847
375 Modified failing test's base url so it could get a valid origin
376 and make use of local storage. Also added another test that checks
377 local storage visibility in both scenarios.
379 * tests/qwebpage/tst_qwebpage.cpp:
380 (tst_QWebPage::testOptionalJSObjects):
381 (checkLocalStorageVisibility):
382 (tst_QWebPage::testLocalStorageVisibility):
384 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
386 Reviewed by Andreas Kling.
388 [Qt] Warning fixes on comparisons between a signed and an unsigned.
390 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
391 (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
392 (DumpRenderTreeSupportQt::nodesFromRect):
394 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
396 Reviewed by Andreas Kling.
398 To support building namespaced Qt, we require that forward-declarations
399 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
401 * WebCoreSupport/FrameLoaderClientQt.h:
403 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
405 Unreviewed build fix after r87902.
407 To support building namespaced Qt, we require that forward-declarations
408 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
409 only on classes inside Qt.
411 * WebCoreSupport/DumpRenderTreeSupportQt.h:
413 2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
415 Reviewed by Benjamin Poulain.
417 Some warning fixes. Values in switch not handled, and
418 a comparison between a signed and an unsigned.
421 (QWebPagePrivate::inputMethodEvent):
422 (QWebPagePrivate::dynamicPropertyChangeEvent):
425 2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
427 Unreviewed build fix for Qt and QuickTime backend.
429 r87328 added a new system interface, we need to add it too.
431 * WebCoreSupport/WebSystemInterface.mm:
432 (InitWebCoreSystemInterface):
434 2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
436 Reviewed by Eric Carlson.
438 [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
439 https://bugs.webkit.org/show_bug.cgi?id=61279
441 Enable the usage of QuickTime backend for the Qt port. It can be enabled by
442 passing DEFINES+=USE_QTKIT=1 when calling build-webkit.
445 (QWebPagePrivate::QWebPagePrivate):
447 * WebCoreSupport/FullScreenVideoQt.cpp:
448 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
449 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
450 (WebCore::FullScreenVideoQt::isValid):
451 * WebCoreSupport/WebSystemInterface.h: Added.
452 * WebCoreSupport/WebSystemInterface.mm: Added.
453 (InitWebCoreSystemInterface):
455 2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
457 Reviewed by Andreas Kling.
459 [Qt] Fix enum order in qwebpage.h public API header
460 https://bugs.webkit.org/show_bug.cgi?id=61959
462 Since qwebpage.h is a public header, we can't change the values of
463 the enumerations. This patch moves the new enumeration to the end
464 of the list. As a bonus, adds a missing entry in
465 editorCommandWebActions table.
470 2011-06-02 Andreas Kling <kling@webkit.org>
472 Rubber-stamped by Simon Hausmann.
474 Remove Qt's precompiled header hack as it was broken, and was not even
475 used unless building WebKit inside a Qt tree.
477 * WebKit_pch.h: Removed.
479 2011-06-01 Andreas Kling <kling@webkit.org>
481 Reviewed by Benjamin Poulain.
483 REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
484 https://bugs.webkit.org/show_bug.cgi?id=49650
486 Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
487 This lets the QNAM backend finish with the reply without handing over ownership to the user code.
489 No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.
491 To correctly solve this issue, we need changes to Qt, tracked here:
492 http://bugreports.qt.nokia.com/browse/QTBUG-18718
494 * WebCoreSupport/FrameLoaderClientQt.cpp:
495 (WebCore::FrameLoaderClientQt::setFrame):
496 (WebCore::FrameLoaderClientQt::download):
497 * WebCoreSupport/FrameLoaderClientQt.h:
499 2011-06-02 Andreas Kling <kling@webkit.org>
501 Unreviewed build fix.
503 To support building namespaced Qt, we require that forward-declarations
504 of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
506 * WebCoreSupport/DumpRenderTreeSupportQt.h:
508 2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
510 Reviewed by Kenneth Rohde Christiansen.
512 [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
513 https://bugs.webkit.org/show_bug.cgi?id=59345
515 KURL and QUrl disagree whether certain URLs are valid or not. The regression here
516 was caused by the fact that now KURL accepts "http:/example.com" (note only one
517 slash) and our test case used a strange edge case that's transformed into a
518 "one-slash" URL that now KURL can handle.
520 QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
521 can understand it. So I've updated the test to use a more meaningful example and
522 show that an invalid URL gets converted to a valid URL if possible.
524 * tests/qwebframe/tst_qwebframe.cpp:
525 (tst_QWebFrame::setUrlToInvalid):
527 2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
529 Reviewed by Tor Arne Vestbø.
531 [Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
532 https://bugs.webkit.org/show_bug.cgi?id=61739
534 The skipped test was imported from Qt source repository, and used private headers
535 to peek in the QML Grid element. This patch changes the QML used to expose the
536 information we want to test: number of pages opened and the first page opened.
538 * tests/qdeclarativewebview/resources/newwindows.html:
539 Added <body> tags. We have no reason to not use them in the test.
541 * tests/qdeclarativewebview/resources/newwindows.qml:
542 Moved the timer out of the page component, used anchors for setting webview size,
543 changed the way we count pages opened. Also changed coding style a bit.
545 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
546 (tst_QDeclarativeWebView::multipleWindows):
547 We now look for properties with the information we want in the rootItem: pagesOpened and
550 2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
552 Reviewed by Andreas Kling.
554 [Qt] tst_QWebFrame::render() failing
555 https://bugs.webkit.org/show_bug.cgi?id=60893
557 The test was expecting the frame contents to be already loaded
558 before rendering it into a QPicture. Renamed the test to fit
559 its real purpose more accordingly.
561 * tests/qwebframe/tst_qwebframe.cpp:
562 (tst_QWebFrame::renderGeometry):
564 2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
566 Reviewed by Andreas Kling.
568 [Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
569 https://bugs.webkit.org/show_bug.cgi?id=61711
571 The loadFinished() signal was emitted directly inside the call for setHtml, so
572 the test was waiting the loadFinished() signal with a big timeout. Change this by
573 a very small timeout and a verification with signal spy.
575 In practice, setHtml() will either directly call loadFinished() or queue it to
576 the next event loop run, and test will work for both situations.
578 * tests/qwebframe/tst_qwebframe.cpp:
579 (tst_QWebFrame::scrollbarsOff):
581 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
583 Reviewed by Benjamin Poulain.
585 [Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
586 https://bugs.webkit.org/show_bug.cgi?id=60372
588 * tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
589 (tst_QWebElement::style):
591 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
593 Reviewed by Benjamin Poulain.
595 [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
596 https://bugs.webkit.org/show_bug.cgi?id=61042
598 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
599 (tst_QDeclarativeWebView::basicProperties):
600 (tst_QDeclarativeWebView::historyNav):
602 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
604 Reviewed by Benjamin Poulain.
606 [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
607 https://bugs.webkit.org/show_bug.cgi?id=61045
609 * tests/qwebpage/tst_qwebpage.cpp:
610 (tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.
612 2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
614 Reviewed by Benjamin Poulain.
616 [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
617 https://bugs.webkit.org/show_bug.cgi?id=59345
619 * tests/qwebframe/tst_qwebframe.cpp:
620 (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
622 2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
624 Reviewed by Csaba Osztrogonác.
626 [Qt] tst_QWebPage creates temporary files in the current working dir
627 https://bugs.webkit.org/show_bug.cgi?id=60497
629 tst_QWebPage was using QDir::currentPath when creating temporary dirs
630 and leaving them after the test was run. I basically borrowed the fix
631 from tst_QDeclarativeWebView.
633 * tests/qwebpage/tst_qwebpage.cpp:
635 (tst_QWebPage::tmpDirPath):
636 (tst_QWebPage::cleanupFiles):
637 (tst_QWebPage::database):
638 (tst_QWebPage::multiplePageGroupsAndLocalStorage):
640 2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
642 Reviewed by Csaba Osztrogonác.
644 [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
645 https://bugs.webkit.org/show_bug.cgi?id=61044
647 Make sure to set the active window on the application too.
649 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
650 (tst_QGraphicsWebView::setPalette):
652 2011-05-23 Luiz Agostini <luiz.agostini@openbossa.org>
654 Reviewed by Andreas Kling.
656 [Qt] When opening a combo-box the popup renders badly.
657 https://bugs.webkit.org/show_bug.cgi?id=61288
659 Removing combobox palette changes from QtFallbackWebPopup::show() because they
660 are causing rendering problems for some styles.
662 The changes in palette are not needed because the background and foreground
663 colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
664 in method QtFallbackWebPopup::populate().
666 * WebCoreSupport/QtFallbackWebPopup.cpp:
667 (WebCore::QtFallbackWebPopup::show):
669 2011-05-23 Joe Wild <joseph.wild@nokia.com>
671 Reviewed by Andreas Kling.
673 [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
674 https://bugs.webkit.org/show_bug.cgi?id=61200
676 * symbian/eabi/QtWebKitu.def:
678 2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
680 Reviewed by Laszlo Gombos.
682 [Qt] Upstream Symbian platform plugin
683 https://bugs.webkit.org/show_bug.cgi?id=58435
685 Upstream Symbian platform plugin with html5 video player.
687 * symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
688 (HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
689 (HTML5FullScreenVideoHandler::enterFullScreen):
690 (HTML5FullScreenVideoHandler::exitFullScreen):
691 (HTML5FullScreenVideoHandler::onPlayerError):
692 (HTML5FullScreenVideoHandler::onPlayerStateChanged):
693 (HTML5FullScreenVideoHandler::onMediaStatusChanged):
694 (HTML5VideoPlugin::supportsExtension):
695 (HTML5VideoPlugin::createExtension):
696 * symbian/platformplugin/HTML5VideoPlugin.h: Added.
697 (HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
698 (HTML5FullScreenVideoHandler::isFullScreen):
699 (HTML5FullScreenVideoHandler::updateScreenRect):
700 * symbian/platformplugin/HTML5VideoWidget.cpp: Added.
701 (HTML5VideoWidget::HTML5VideoWidget):
702 (HTML5VideoWidget::setDuration):
703 (HTML5VideoWidget::mousePressEvent):
704 (HTML5VideoWidget::onPlayerStopped):
705 (HTML5VideoWidget::onPlayerError):
706 (HTML5VideoWidget::onEndOfMedia):
707 (HTML5VideoWidget::onBufferingMedia):
708 (HTML5VideoWidget::onBufferedMedia):
709 (HTML5VideoWidget::onControlClicked):
710 (HTML5VideoWidget::onPositionChanged):
711 (HTML5VideoWidget::onSliderMoved):
712 (HTML5VideoWidget::onCloseClicked):
713 (HTML5VideoWidget::showFullScreen):
714 (HTML5VideoWidget::setVolume):
715 * symbian/platformplugin/HTML5VideoWidget.h: Added.
716 * symbian/platformplugin/OverlayWidget.cpp: Added.
717 (OverlayWidget::OverlayWidget):
718 (OverlayWidget::~OverlayWidget):
719 (OverlayWidget::setDuration):
720 (OverlayWidget::setPosition):
721 (OverlayWidget::setVolume):
722 (OverlayWidget::mousePressEvent):
723 (OverlayWidget::onPlayerStopped):
724 (OverlayWidget::onPlayerError):
725 (OverlayWidget::onEndOfMedia):
726 (OverlayWidget::onBufferingMedia):
727 (OverlayWidget::onBufferedMedia):
728 (OverlayWidget::timeToString):
729 (OverlayWidget::applyStyleSheet):
730 (OverlayWidget::onControlClicked):
731 (OverlayWidget::onSliderMoved):
732 (OverlayWidget::onSoundClicked):
733 (OverlayWidget::onCloseClicked):
734 (OverlayWidget::onVolumeSliderReleased):
735 (OverlayWidget::onVolumeSliderMoved):
736 (OverlayWidget::onTimerTimeout):
737 (OverlayWidget::showFullScreen):
738 * symbian/platformplugin/OverlayWidget.h: Added.
739 * symbian/platformplugin/PlayerButton.cpp: Added.
740 (PlayerButton::PlayerButton):
741 (PlayerButton::event):
742 * symbian/platformplugin/PlayerButton.h: Added.
743 * symbian/platformplugin/PlayerLabel.cpp: Added.
744 (PlayerLabel::PlayerLabel):
745 (PlayerLabel::onPlayerError):
746 (PlayerLabel::startBufferingAnimation):
747 (PlayerLabel::stopBufferingAnimation):
748 (PlayerLabel::onAnimationTimeout):
749 * symbian/platformplugin/PlayerLabel.h: Added.
750 * symbian/platformplugin/WebPlugin.cpp:
751 (WebPlugin::createExtension):
752 * symbian/platformplugin/images: Added.
753 * symbian/platformplugin/images/button_cannotplay.png: Added.
754 * symbian/platformplugin/images/button_close.png: Added.
755 * symbian/platformplugin/images/button_pause.png: Added.
756 * symbian/platformplugin/images/button_play.png: Added.
757 * symbian/platformplugin/images/button_sound_off.png: Added.
758 * symbian/platformplugin/images/button_sound_on.png: Added.
759 * symbian/platformplugin/images/loading_buffering_1.png: Added.
760 * symbian/platformplugin/images/loading_buffering_2.png: Added.
761 * symbian/platformplugin/images/loading_buffering_3.png: Added.
762 * symbian/platformplugin/images/loading_buffering_4.png: Added.
763 * symbian/platformplugin/platformplugin.pro:
764 * symbian/platformplugin/platformplugin.qrc: Added.
765 * symbian/platformplugin/qss: Added.
766 * symbian/platformplugin/qss/OverlayWidget.qss: Added.
768 2011-05-18 Yi Shen <yi.4.shen@nokia.com>
770 Reviewed by Andreas Kling.
772 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
773 https://bugs.webkit.org/show_bug.cgi?id=33179
775 Remove the implementation of the handleInputMethodKeydown, which introduces
776 a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
778 * WebCoreSupport/EditorClientQt.cpp:
779 (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
780 * tests/qwebpage/tst_qwebpage.cpp:
781 (tst_QWebPage::inputMethods): Add more tests.
783 2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
785 Reviewed by Andreas Kling.
787 [Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
788 https://bugs.webkit.org/show_bug.cgi?id=60978
790 Backslash to escape newlines was confusing both prepare-ChangeLog and the
791 QtCreator highlight system.
793 * tests/qwebframe/tst_qwebframe.cpp:
794 (tst_QWebFrame::evalJSV):
795 Remove usage of backslash to escape newlines in string literal.
797 2011-05-16 Andreas Kling <kling@webkit.org>
799 Reviewed by Kenneth Rohde Christiansen.
801 REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
802 https://bugs.webkit.org/show_bug.cgi?id=60892
804 Don't set the ItemClipsChildrenToShape flag for the root platform layer,
805 since that is now the overflow controls layer. The clip layer, which was
806 previously the root platform layer, already gets the flag by way of
807 the GraphicsLayer mask-to-bounds flag.
809 * WebCoreSupport/PageClientQt.cpp:
810 (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
812 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
814 Reviewed by nobody, build fix.
816 [Qt] Fix build on MSVC.
818 qobject_cast<> requires the class to be exported on MSVC,
819 removing it since the code that needs it is commented out for
822 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
823 (tst_QDeclarativeWebView::elementAreaAt):
825 2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
827 Reviewed by nobody, build fix.
829 [Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
833 2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
835 Reviewed by Simon Hausmann.
837 Install correct header files for webkit.
839 Since WebKit is no longer inside Qt, we can remove the detection for
842 [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
843 https://bugs.webkit.org/show_bug.cgi?id=57621
847 2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
849 Reviewed by Andreas Kling.
851 [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
852 https://bugs.webkit.org/show_bug.cgi?id=60224
854 We should use nullptr rather than 0. nullptr will be added in the new C++ standard
855 but WebKit already has a nullptr class if there is no c++0x support.
857 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
858 (DumpRenderTreeSupportQt::addUserStyleSheet):
860 2011-05-04 Cris Neckar <cdn@chromium.org>
862 Reviewed by Adam Barth.
864 Expose WebView directly through ChromeClient.
865 https://bugs.webkit.org/show_bug.cgi?id=49902
867 * WebCoreSupport/ChromeClientQt.h:
868 (WebCore::ChromeClientQt::webView):
870 2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
872 Unreviewed warning fix.
874 The variable is just unused.
876 * tests/qwebpage/tst_qwebpage.cpp:
877 (tst_QWebPage::inputMethods):
879 2011-05-04 Tao Bai <michaelbai@chromium.org>
881 Reviewed by David Kilzer.
883 Populate touch-icon url to FrameLoaderClient
884 https://bugs.webkit.org/show_bug.cgi?id=59143
886 Respect the interface change in FrameLoaderClient.
888 * WebCoreSupport/FrameLoaderClientQt.cpp:
889 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
890 * WebCoreSupport/FrameLoaderClientQt.h:
892 2011-03-31 Luiz Agostini <luiz.agostini@openbossa.org>
894 Reviewed by Kenneth Rohde Christiansen.
896 [Qt] Qt WebKit updates view on HTTP 204 response
897 https://bugs.webkit.org/show_bug.cgi?id=42529
899 Ignoring http responses which have status code equal to 204 (No Content)
900 or 205 (Reset Content).
902 * WebCoreSupport/FrameLoaderClientQt.cpp:
903 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
905 2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
907 Reviewed by Benjamin Poulain.
909 [Qt] Fix signals emitted in FakeReply used in autotests
910 https://bugs.webkit.org/show_bug.cgi?id=60049
912 The signals emitted for each case of FakeReply were swapped (error case
913 emitting metaDataChanged() and redirect case emitting error()). Emitting
914 readyRead() is not necessary.
916 * tests/qwebframe/tst_qwebframe.cpp:
917 (FakeReply::FakeReply):
918 Choose the different continue function for each case of FakeReply. This removes
919 the need of the if-statement in timeout() and let us replace timeout() with two
922 (FakeReply::continueRedirect):
923 (FakeReply::continueError):
924 Continuation cases, emitting the minimal set of signals needed for each case.
926 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
928 Reviewed by Dimitri Glazkov.
930 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
931 https://bugs.webkit.org/show_bug.cgi?id=58703
933 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
934 (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
936 2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
938 Reviewed by Andreas Kling.
940 [Qt] QtDeclarative Webview element has a fixed white background
941 https://bugs.webkit.org/show_bug.cgi?id=40918
943 QProperty REVISION feature is not present in certain Qt Trunk clones.
944 These builds report their version as 4.8.0, and therefore break on the
945 prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
946 the existance of Q_REVISION.
948 * declarative/plugin.cpp:
949 (WebKitQmlPlugin::registerTypes):
950 * declarative/qdeclarativewebview.cpp:
951 * declarative/qdeclarativewebview_p.h:
953 2011-05-01 Sam Weinig <sam@webkit.org>
955 Reviewed by Anders Carlsson.
957 Prune some unnecessary #includes
958 https://bugs.webkit.org/show_bug.cgi?id=59895
960 Start getting rid of unnecessary #includes and forward declares.
962 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
964 2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
966 Reviewed by Adam Barth.
968 Enable strict OwnPtr for Qt
969 https://bugs.webkit.org/show_bug.cgi?id=59667
972 (QWebPagePrivate::QWebPagePrivate):
974 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
976 Reviewed by Simon Hausmann.
978 ENABLE(QT_BEARER) -> USE(QT_BEARER)
980 * Api/qwebsettings.cpp:
982 2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
984 Reviewed by Simon Hausmann.
986 ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
990 2011-04-28 Yael Aharon <yael.aharon@nokia.com>
992 Reviewed by Andreas Kling.
994 Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
995 https://bugs.webkit.org/show_bug.cgi?id=59704
997 * WebCoreSupport/QtFallbackWebPopup.cpp:
998 (WebCore::QtFallbackWebPopup::show):
999 * WebCoreSupport/QtFallbackWebPopup.h:
1001 2011-04-27 Yi Shen <yi.4.shen@nokia.com>
1003 Reviewed by Kenneth Rohde Christiansen.
1005 [Qt] Upstream Symbian platform plugin
1006 https://bugs.webkit.org/show_bug.cgi?id=58435
1008 Upstream Symbian platform plugin.
1010 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
1011 * symbian/platformplugin: Added.
1012 * symbian/platformplugin/WebPlugin.cpp: Added.
1013 (ItemListDelegate::ItemListDelegate):
1014 (ItemListDelegate::paint):
1016 (Popup::resizeEvent):
1017 (Popup::populateList):
1018 (Popup::onItemSelected):
1019 (Popup::updateSelectionsBeforeDialogClosing):
1020 (Popup::updateAndClose):
1021 (WebPopup::WebPopup):
1022 (WebPopup::~WebPopup):
1023 (WebPopup::createSingleSelectionPopup):
1024 (WebPopup::createMultipleSelectionPopup):
1025 (WebPopup::createPopup):
1028 (WebPopup::popupClosed):
1029 (WebPopup::itemClicked):
1030 (SingleSelectionPopup::SingleSelectionPopup):
1031 (MultipleSelectionPopup::MultipleSelectionPopup):
1032 (WebNotificationPresenter::showNotification):
1033 (WebPlugin::supportsExtension):
1034 (WebPlugin::createExtension):
1035 * symbian/platformplugin/WebPlugin.h: Added.
1036 (Popup::preSelectedIndices):
1037 (Popup::listWidget):
1038 (WebNotificationPresenter::WebNotificationPresenter):
1039 (WebNotificationPresenter::~WebNotificationPresenter):
1040 * symbian/platformplugin/platformplugin.pro: Added.
1041 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
1042 (QWebSelectData::~QWebSelectData):
1043 (QWebSelectMethod::~QWebSelectMethod):
1044 (QWebNotificationData::~QWebNotificationData):
1045 (QWebNotificationPresenter::QWebNotificationPresenter):
1046 (QWebNotificationPresenter::~QWebNotificationPresenter):
1047 (QWebTouchModifier::~QWebTouchModifier):
1048 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
1049 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
1050 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
1052 2011-04-26 Yi Shen <yi.4.shen@nokia.com>
1054 Reviewed by Tor Arne Vestbø.
1056 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
1057 https://bugs.webkit.org/show_bug.cgi?id=56946
1059 Deployed the missing resource for Symbian platform.
1061 * tests/qwebframe/qwebframe.pro:
1063 2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
1065 Reviewed by Andreas Kling.
1067 [Qt] Build fix: QtDeclarative Webview element has a fixed white background
1068 https://bugs.webkit.org/show_bug.cgi?id=40918
1070 Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
1072 * declarative/plugin.cpp: Bump up required version to 4.7.4+
1073 (WebKitQmlPlugin::registerTypes):
1074 * declarative/qdeclarativewebview.cpp: ditto
1075 * declarative/qdeclarativewebview_p.h: ditto
1076 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
1078 2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
1080 Reviewed by Csaba Osztrogonác.
1082 [Qt] Implement LayoutTestController::setAutofilled
1083 https://bugs.webkit.org/show_bug.cgi?id=59439
1085 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1086 (DumpRenderTreeSupportQt::setAutofilled):
1087 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1089 2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
1091 Unreviewed, rolling out r84627.
1092 http://trac.webkit.org/changeset/84627
1093 https://bugs.webkit.org/show_bug.cgi?id=59271
1095 It broke Symbian build (Requested by Ossy on #webkit).
1098 * symbian/platformplugin/WebPlugin.cpp: Removed.
1099 * symbian/platformplugin/WebPlugin.h: Removed.
1100 * symbian/platformplugin/platformplugin.pro: Removed.
1101 * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
1103 2011-04-22 Sam Weinig <sam@webkit.org>
1107 * Api/qwebelement.cpp:
1108 (setupScriptContext):
1110 2011-04-22 Yi Shen <yi.4.shen@nokia.com>
1112 Reviewed by Kenneth Rohde Christiansen.
1114 [Qt] Upstream Symbian platform plugin
1115 https://bugs.webkit.org/show_bug.cgi?id=58435
1117 Upstream Symbian platform plugin.
1119 * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
1120 * symbian/platformplugin: Added.
1121 * symbian/platformplugin/WebPlugin.cpp: Added.
1122 (ItemListDelegate::ItemListDelegate):
1123 (ItemListDelegate::paint):
1125 (Popup::resizeEvent):
1126 (Popup::populateList):
1127 (Popup::onItemSelected):
1128 (Popup::updateSelectionsBeforeDialogClosing):
1129 (Popup::updateAndClose):
1130 (WebPopup::WebPopup):
1131 (WebPopup::~WebPopup):
1132 (WebPopup::createSingleSelectionPopup):
1133 (WebPopup::createMultipleSelectionPopup):
1134 (WebPopup::createPopup):
1137 (WebPopup::popupClosed):
1138 (WebPopup::itemClicked):
1139 (SingleSelectionPopup::SingleSelectionPopup):
1140 (MultipleSelectionPopup::MultipleSelectionPopup):
1141 (WebNotificationPresenter::showNotification):
1142 (WebPlugin::supportsExtension):
1143 (WebPlugin::createExtension):
1144 * symbian/platformplugin/WebPlugin.h: Added.
1145 (Popup::preSelectedIndices):
1146 (Popup::listWidget):
1147 (WebNotificationPresenter::WebNotificationPresenter):
1148 (WebNotificationPresenter::~WebNotificationPresenter):
1149 * symbian/platformplugin/platformplugin.pro: Added.
1150 * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
1151 (QWebSelectData::~QWebSelectData):
1152 (QWebSelectMethod::~QWebSelectMethod):
1153 (QWebNotificationData::~QWebNotificationData):
1154 (QWebNotificationPresenter::QWebNotificationPresenter):
1155 (QWebNotificationPresenter::~QWebNotificationPresenter):
1156 (QWebTouchModifier::~QWebTouchModifier):
1157 (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
1158 (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
1159 (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
1161 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1163 Reviewed by Sam Weinig.
1165 Add Frame* to the argument lists of canCopyCut and canPaste
1166 https://bugs.webkit.org/show_bug.cgi?id=59153
1168 * WebCoreSupport/EditorClientQt.cpp:
1169 (WebCore::EditorClientQt::canCopyCut):
1170 (WebCore::EditorClientQt::canPaste):
1171 * WebCoreSupport/EditorClientQt.h:
1173 2011-04-21 Yi Shen <yi.4.shen@nokia.com>
1175 Reviewed by Antonio Gomes.
1177 [Qt] Fix the style issue for Api/qwebkitplatformplugin.h
1178 https://bugs.webkit.org/show_bug.cgi?id=59097
1180 Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
1182 * Api/qwebkitplatformplugin.h:
1184 2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1186 Reviewed by Csaba Osztrogonác.
1188 [Qt] REGRESSION(84057): It made 4 API tests fail
1189 https://bugs.webkit.org/show_bug.cgi?id=58848
1191 After MIME sniffing support was added, some autotests are failing because
1192 the sniffer doesn't recognize our HTML pages.
1194 This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
1195 and tst_QWebFrame::horizontalScrollAfterBack().
1197 * tests/qwebframe/resources/testiframe.html:
1198 * tests/qwebframe/resources/testiframe2.html:
1199 Remove spurious </html> in beginning of the document.
1201 * tests/qwebpage/resources/framedindex.html:
1202 * tests/qwebpage/resources/index.html:
1203 Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
1204 possible starting tag for HTML document.
1206 * tests/qwebpage/tst_qwebpage.cpp:
1207 (tst_QWebPage::errorPageExtensionInFrameset):
1208 Verify if we do have a main frame and the main frame has the children frames we
1209 expect. This will avoid crashing if for some reason children frames are not
1212 2011-04-20 Dominic Cooney <dominicc@chromium.org>
1214 Reviewed by Dimitri Glazkov.
1216 layoutTestController can create and destroy shadow DOM
1217 https://bugs.webkit.org/show_bug.cgi?id=59058
1219 Support for new methods in Qt DRT.
1221 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1222 (DumpRenderTreeSupportQt::ensureShadowRoot):
1223 (DumpRenderTreeSupportQt::removeShadowRoot):
1224 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1226 2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
1228 Reviewed by Csaba Osztrogonác.
1230 [Qt] Cleanup includepath adjustment for generated files
1231 https://bugs.webkit.org/show_bug.cgi?id=58869
1233 * QtWebKit.pro: Revert the hacky fix in r84174. Remove
1236 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
1238 Reviewed by Andreas Kling.
1240 [Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
1241 https://bugs.webkit.org/show_bug.cgi?id=57254
1243 Skip test for setPalette() which doesn't work
1244 when WTF_USE_QT_MOBILE_THEME is defined.
1246 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1247 * tests/qwebview/tst_qwebview.cpp:
1250 2011-04-19 Yi Shen <yi.4.shen@nokia.com>
1252 Reviewed by Laszlo Gombos.
1254 [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
1255 https://bugs.webkit.org/show_bug.cgi?id=58044
1257 Fixing this test by disabling the scrollbars on the graphics view
1258 since QtWebKit handles scrolling and scrollbar automatically and correctly.
1260 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1261 (tst_QGraphicsWebView::widgetsRenderingThroughCache):
1263 2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
1265 Reviewed by Andreas Kling.
1267 [Qt] X11: Text selection is causing oncopy event to be called
1268 https://bugs.webkit.org/show_bug.cgi?id=58656
1270 Always when text is selected the oncopy event is fired, this behavior does
1271 not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
1272 is making multi part-copies (with rich text metadata), the multi-part
1273 data can be obtained by data transfer items interface when supported by QtWebKit.
1274 Also, copies to the clipboard of a selected image, is not supported by Chrome and
1275 Firefox and was removed from QtWebKit.
1279 (QWebPagePrivate::handleClipboard):
1281 2011-04-18 Csaba Osztrogonác <ossy@webkit.org>
1283 [Qt][WK2] Unreviewed buildfix after r84174.
1285 * QtWebKit.pro: Missing includepath added.
1287 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
1289 Reviewed by Laszlo Gombos.
1291 [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
1292 https://bugs.webkit.org/show_bug.cgi?id=57546
1294 Disable the fullscreen VKB when testing inputFieldFocus().
1296 * tests/qwebframe/tst_qwebframe.cpp:
1298 2011-04-18 Andreas Kling <kling@webkit.org>
1300 [Qt] DRT: Unreviewed test fix after r84168.
1302 Dump the original request KURL for blocked access attempts.
1303 Turns out converting it to a QUrl lower-cases the hostname.
1305 * WebCoreSupport/FrameLoaderClientQt.cpp:
1306 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1308 2011-04-18 Yi Shen <yi.4.shen@nokia.com>
1310 Reviewed by Laszlo Gombos.
1312 [Qt] Fix Api tests for QWebPage on Symbian
1313 https://bugs.webkit.org/show_bug.cgi?id=56924
1315 Ignores the style attribute that selectedHtml() returns.
1317 * tests/qwebpage/tst_qwebpage.cpp:
1318 (tst_QWebPage::cursorMovements):
1319 (tst_QWebPage::textSelection):
1320 (tst_QWebPage::findText):
1322 2011-04-18 Andreas Kling <kling@webkit.org>
1324 Reviewed by Adam Barth.
1326 REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
1327 https://bugs.webkit.org/show_bug.cgi?id=58779
1329 KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
1330 QUrl instead to match the behavior of other ports.
1332 * WebCoreSupport/FrameLoaderClientQt.cpp:
1333 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1335 2011-04-18 Dominic Cooney <dominicc@chromium.org>
1337 Reviewed by Andreas Kling.
1339 Add layoutTestController.shadowRoot to Qt DRT.
1340 https://bugs.webkit.org/show_bug.cgi?id=58759
1342 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1343 (DumpRenderTreeSupportQt::shadowRoot): Added.
1344 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1346 2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1348 Reviewed by Andreas Kling.
1350 [Qt] Autotest got missed in the handover of the QML WebView element
1351 https://bugs.webkit.org/show_bug.cgi?id=41449
1353 Importing WebView QML element test cases from Qt repository. I did some
1354 style modifications and simplifications in the original code but hopefully
1355 without changing the behavior.
1357 Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
1358 issues currently are:
1360 - pixelCache() test checked the usage of pixel cache by using a subclass of
1361 QDeclarativeWebView. We can't do that right now because this class is not
1362 exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
1364 - elementAtArea() test uses a function that is not exported. But in this case
1365 I think we should test it's user, the public method "heuristicZoom".
1367 * tests/qdeclarativewebview/resources/basic.html: Added.
1368 * tests/qdeclarativewebview/resources/basic.png: Added.
1369 * tests/qdeclarativewebview/resources/basic.qml: Added.
1370 * tests/qdeclarativewebview/resources/elements.html: Added.
1371 * tests/qdeclarativewebview/resources/elements.qml: Added.
1372 * tests/qdeclarativewebview/resources/forward.html: Added.
1373 * tests/qdeclarativewebview/resources/forward.png: Added.
1374 * tests/qdeclarativewebview/resources/javaScript.html: Added.
1375 * tests/qdeclarativewebview/resources/javaScript.qml: Added.
1376 * tests/qdeclarativewebview/resources/loadError.qml: Added.
1377 * tests/qdeclarativewebview/resources/newwindows.html: Added.
1378 * tests/qdeclarativewebview/resources/newwindows.qml: Added.
1379 * tests/qdeclarativewebview/resources/propertychanges.qml: Added.
1380 * tests/qdeclarativewebview/resources/sethtml.qml: Added.
1381 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1382 (tst_QDeclarativeWebView::tmpDir):
1386 (tst_QDeclarativeWebView::cleanupTestCase):
1387 (tst_QDeclarativeWebView::basicProperties):
1388 (tst_QDeclarativeWebView::elementAreaAt):
1389 (tst_QDeclarativeWebView::historyNav):
1390 (callEvaluateJavaScript):
1391 (tst_QDeclarativeWebView::javaScript):
1392 (tst_QDeclarativeWebView::loadError):
1393 (tst_QDeclarativeWebView::multipleWindows):
1394 (tst_QDeclarativeWebView::newWindowComponent):
1395 (tst_QDeclarativeWebView::newWindowParent):
1396 (tst_QDeclarativeWebView::pressGrabTime):
1397 (tst_QDeclarativeWebView::renderingEnabled):
1398 (tst_QDeclarativeWebView::setHtml):
1399 (tst_QDeclarativeWebView::settings):
1400 (tst_QDeclarativeWebView::checkNoErrors):
1401 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
1403 2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
1405 Reviewed by Kenneth Rohde Christiansen.
1407 [Qt] QWebPage MIME type handling inconsistency with other web browsers
1408 https://bugs.webkit.org/show_bug.cgi?id=46968
1410 Implementing mime type sniffing based on
1411 http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
1413 * WebCoreSupport/FrameLoaderClientQt.cpp:
1414 (WebCore::FrameLoaderClientQt::createNetworkingContext):
1415 * WebCoreSupport/FrameNetworkingContextQt.cpp:
1416 (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
1417 (WebCore::FrameNetworkingContextQt::create):
1418 (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
1419 * WebCoreSupport/FrameNetworkingContextQt.h:
1420 * tests/MIMESniffing/MIMESniffing.pro: Added.
1421 * tests/MIMESniffing/TestData.h: Added.
1422 * tests/MIMESniffing/resources.qrc: Added.
1423 * tests/MIMESniffing/resources/application_atom+xml: Added.
1424 * tests/MIMESniffing/resources/application_ogg: Added.
1425 * tests/MIMESniffing/resources/application_pdf: Added.
1426 * tests/MIMESniffing/resources/application_postscript: Added.
1427 * tests/MIMESniffing/resources/application_rdf+xml: Added.
1428 * tests/MIMESniffing/resources/application_rss+xml: Added.
1429 * tests/MIMESniffing/resources/application_x-gzip: Added.
1430 * tests/MIMESniffing/resources/application_x-rar-compressed: Added.
1431 * tests/MIMESniffing/resources/application_zip: Added.
1432 * tests/MIMESniffing/resources/audio_x-wave: Added.
1433 * tests/MIMESniffing/resources/image_bmp: Added.
1434 * tests/MIMESniffing/resources/image_gif: Added.
1435 * tests/MIMESniffing/resources/image_jpeg: Added.
1436 * tests/MIMESniffing/resources/image_png: Added.
1437 * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
1438 * tests/MIMESniffing/resources/image_webp: Added.
1439 * tests/MIMESniffing/resources/text_html: Added.
1440 * tests/MIMESniffing/resources/text_xml: Added.
1441 * tests/MIMESniffing/resources/video_webm: Added.
1442 * tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
1443 (tst_MIMESniffing::tst_MIMESniffing):
1445 (tst_MIMESniffing::testCase1):
1448 2011-04-15 Andreas Kling <kling@webkit.org>
1450 Reviewed by Antonio Gomes.
1452 [Qt] DRT: Block access to external URLs.
1454 Implement the "Blocked access to external URL" behavior for Qt's DRT,
1455 based on what other ports are doing.
1457 Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
1459 * WebCoreSupport/FrameLoaderClientQt.cpp:
1460 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1462 2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
1464 Reviewed by Antonio Gomes.
1466 [Qt] Web Inspector does not highlight elements
1467 https://bugs.webkit.org/show_bug.cgi?id=35125
1469 Adjust Web inspector to highlight elements on the page when the mouse
1470 hovers the element on DOM inspector.
1472 * Api/qwebframe.cpp:
1473 (QWebFramePrivate::renderRelativeCoords):
1474 * WebCoreSupport/InspectorClientQt.cpp:
1475 (WebCore::InspectorClientQt::highlight):
1476 (WebCore::InspectorClientQt::hideHighlight):
1478 2011-04-12 George Guo <George.Guo@nokia.com>
1480 Reviewed by Laszlo Gombos.
1482 [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
1483 http://bugs.webkit.org/show_bug.cgi?id=58141
1485 If QtWebKit is already in Symbian ROM, we need package to be
1490 2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
1492 Reviewed by Andreas Kling.
1494 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
1495 https://bugs.webkit.org/show_bug.cgi?id=58251
1497 Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
1499 * Api/qwebframe.cpp:
1500 (QWebFrame::QWebFrame):
1502 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
1504 Reviewed by Benjamin Poulain.
1506 [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
1507 https://bugs.webkit.org/show_bug.cgi?id=58251
1509 Qt coding conventions states that private slots should be located in private implementation of
1510 the class. This allows us to rename/delete the slots in the future without breaking anything.
1512 No new tests added, just a simple refactoring.
1514 * Api/qwebframe.cpp:
1515 (QWebFramePrivate::_q_orientationChanged):
1517 * Api/qwebframe_p.h:
1519 2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
1521 Reviewed by Kenneth Rohde Christiansen.
1523 [Qt] Sub-Frame content is not updated when scrolling in certain circumstances
1524 https://bugs.webkit.org/show_bug.cgi?id=50373
1526 Make sure that we invalidate the backing store when using TILED_BACKING_STORE
1527 and the page contains sub frames. This bug appears only when frame flattening is
1528 disabled and scrollable subframes.
1530 Original patch from Thomas Thrainer.
1532 * WebCoreSupport/ChromeClientQt.cpp:
1533 (WebCore::ChromeClientQt::invalidateWindow):
1535 2011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com>
1537 Reviewed by Andreas Kling.
1539 [Qt] HTML5 Drag and Drop demos not working
1540 https://bugs.webkit.org/show_bug.cgi?id=56486
1542 Handling the drop with JavaScript was not working with Qt because if the action is ignored
1543 in response to DragEnter, no further events are sent to the view.
1545 Drag and drop is defined and used differently by webpages. The drag move events are determining
1546 what action should take place. To adopt this behavior for Qt, we always accept drag enter events
1550 (QWebPagePrivate::dragEnterEvent):
1552 2011-04-11 Andras Becsi <abecsi@webkit.org>
1554 Reviewed by Andreas Kling.
1556 [Qt] REGRESSION(83122): tst_QWebElement::style() fails
1557 https://bugs.webkit.org/show_bug.cgi?id=58032
1559 According to the documentation of QWebElement the styleProperty method should
1560 not respect style inheritance and other CSS rules for the InlineStyle enum.
1562 r83122 fixed this behaviour.
1564 * tests/qwebelement/tst_qwebelement.cpp:
1565 (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
1567 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
1569 Build fix after r83436.
1571 * WebCoreSupport/FrameLoaderClientQt.cpp:
1572 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
1574 2011-04-11 Andreas Kling <andreas.kling@nokia.com>
1576 Reviewed by Benjamin Poulain.
1578 [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
1580 * WebCoreSupport/FrameLoaderClientQt.cpp:
1581 (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
1582 for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
1583 This is in line with the Mac port.
1585 2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
1587 Unreviewed, rolling out r83295.
1588 http://trac.webkit.org/changeset/83295
1589 https://bugs.webkit.org/show_bug.cgi?id=58144
1591 Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
1593 * WebCoreSupport/EditorClientQt.cpp:
1594 (WebCore::EditorClientQt::handleInputMethodKeydown):
1596 2011-04-08 Yi Shen <yi.4.shen@nokia.com>
1598 Reviewed by Antonio Gomes.
1600 [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
1601 https://bugs.webkit.org/show_bug.cgi?id=57472
1603 Avoid to insert new line for both keydown event & keypress event.
1605 * WebCoreSupport/EditorClientQt.cpp:
1606 (WebCore::EditorClientQt::handleInputMethodKeydown):
1608 2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1610 Reviewed by Benjamin Poulain.
1612 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
1613 https://bugs.webkit.org/show_bug.cgi?id=32723
1615 When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
1616 use an invalid URL (the begin() without arguments). Clearing the document
1617 with the same URL was causing problems when we had a fragment because it assume that
1618 only scrolling was enough and did not loaded the document again.
1620 When setUrl() is called but fails, url() is expected to return the requested value. The
1621 begin(url) guaranteed that before. This patch adds a member to track the URL, which is
1622 updated when the URL changes and also when setUrl() is called.
1624 KURL was used for the member so that when setUrl() is called, and then url() is checked
1625 before the page gets loaded, we perform the same conversion that will be performed by a
1626 successful load, e.g. add trailing '/' to an address. This behavior is checked by
1627 tst_QWebFrame::requestedUrl() test.
1629 For the record: the second QWebPage::setUrl() worked because the load was considered a
1630 FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
1631 needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
1633 * Api/qwebframe.cpp:
1634 (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
1637 (QWebFrame::setUrl):
1639 (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
1640 the baseURL, e.g. by using the <base> tag.
1641 * Api/qwebframe_p.h:
1643 * WebCoreSupport/FrameLoaderClientQt.cpp:
1644 (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
1645 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1647 * tests/qwebframe/tst_qwebframe.cpp:
1648 (tst_QWebFrame::setUrlWithFragment): unskip test.
1650 2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
1652 Reviewed by Kenneth Rohde Christiansen.
1654 Build fix when using Phonon as a backend for the multimedia support.
1656 * WebCoreSupport/ChromeClientQt.cpp:
1657 (WebCore::ChromeClientQt::ChromeClientQt):
1658 (WebCore::ChromeClientQt::~ChromeClientQt):
1659 * WebCoreSupport/ChromeClientQt.h:
1661 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
1663 Reviewed by Kenneth Rohde Christiansen.
1665 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1666 https://bugs.webkit.org/show_bug.cgi?id=56086
1668 Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
1669 from the LayoutTestController.
1671 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1672 (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
1673 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1675 2011-04-06 Anders Bakken <agbakken@gmail.com>
1677 Reviewed by Kenneth Rohde Christiansen.
1679 [Qt] FrameLoaderClientQt.cpp has coding-style errors
1680 https://bugs.webkit.org/show_bug.cgi?id=40254
1682 * WebCoreSupport/FrameLoaderClientQt.cpp:
1683 (drtDescriptionSuitableForTestResult):
1684 (WebCore::FrameLoaderClientQt::hasWebView):
1685 (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
1686 (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
1687 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1688 (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
1689 (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
1690 (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
1691 (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
1692 (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
1693 (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
1694 (WebCore::FrameLoaderClientQt::willChangeTitle):
1695 (WebCore::FrameLoaderClientQt::didChangeTitle):
1696 (WebCore::FrameLoaderClientQt::finishedLoading):
1697 (WebCore::FrameLoaderClientQt::frameLoadCompleted):
1698 (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
1699 (WebCore::FrameLoaderClientQt::didFinishLoad):
1700 (WebCore::FrameLoaderClientQt::setTitle):
1701 (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
1702 (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
1703 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1704 (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
1705 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
1706 (WebCore::FrameLoaderClientQt::committedLoad):
1707 (WebCore::FrameLoaderClientQt::download):
1708 (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
1709 (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
1710 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
1711 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1712 (WebCore::FrameLoaderClientQt::createFrame):
1713 (WebCore::FrameLoaderClientQt::objectContentType):
1714 (WebCore::FrameLoaderClientQt::createPlugin):
1716 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1718 Reviewed by Andreas Kling.
1720 [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1721 https://bugs.webkit.org/show_bug.cgi?id=57974
1723 We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
1725 No new tests needed, just a config flag rename.
1727 * Api/qwebkitplatformplugin.h:
1728 * WebCoreSupport/ChromeClientQt.cpp:
1729 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1730 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
1731 * WebCoreSupport/FullScreenVideoQt.cpp:
1732 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1733 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1734 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1735 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1736 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1737 (WebCore::FullScreenVideoQt::isValid):
1738 * WebCoreSupport/FullScreenVideoQt.h:
1739 * WebCoreSupport/QtPlatformPlugin.cpp:
1740 * WebCoreSupport/QtPlatformPlugin.h:
1741 * examples/platformplugin/WebPlugin.cpp:
1742 (WebPlugin::supportsExtension):
1743 (WebPlugin::createExtension):
1744 * examples/platformplugin/WebPlugin.h:
1745 * examples/platformplugin/platformplugin.pro:
1746 * examples/platformplugin/qwebkitplatformplugin.h:
1747 * tests/qwebpage/tst_qwebpage.cpp:
1748 (tst_QWebPage::loadHtml5Video):
1751 2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
1753 Reviewed by Andreas Kling.
1755 [Qt] Implement fullscreen playback for the GStreamer backend.
1756 https://bugs.webkit.org/show_bug.cgi?id=56826
1758 Implement support for fullscreen playback when building the
1759 Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
1760 The implementation is done in FullScreenVideoQt alongside with
1761 the Qt Multimedia support.
1763 No new tests because layout tests cover it. They are not yet activated
1764 but will be any time soon.
1767 * WebCoreSupport/ChromeClientQt.cpp:
1768 (WebCore::ChromeClientQt::ChromeClientQt):
1769 (WebCore::ChromeClientQt::~ChromeClientQt):
1770 (WebCore::ChromeClientQt::enterFullscreenForNode):
1771 (WebCore::ChromeClientQt::exitFullscreenForNode):
1772 * WebCoreSupport/ChromeClientQt.h:
1773 * WebCoreSupport/FullScreenVideoQt.cpp:
1774 (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
1775 (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
1776 (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
1777 (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
1778 (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
1779 (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
1780 (WebCore::FullScreenVideoQt::FullScreenVideoQt):
1781 (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
1782 (WebCore::FullScreenVideoQt::enterFullScreenForNode):
1783 (WebCore::FullScreenVideoQt::exitFullScreenForNode):
1784 (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
1785 (WebCore::FullScreenVideoQt::isValid):
1786 * WebCoreSupport/FullScreenVideoQt.h:
1787 (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
1789 2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1791 Reviewed by Kenneth Rohde Christiansen.
1793 [Qt] Improve tests for QWebFrame::url() and related methods
1794 https://bugs.webkit.org/show_bug.cgi?id=57865
1796 * tests/qwebframe/tst_qwebframe.cpp:
1797 (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
1798 (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
1799 that fails and a load() that fails (for a different URL).
1801 (tst_QWebFrame::setUrlWithFragment_data):
1802 (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
1803 the URL in the frame before the test starts.
1805 (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
1806 the same URL as argument.
1809 (tst_QWebFrame::setUrlThenLoads_data):
1810 (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
1811 sequence of set and loads. Those tests are interesting because the properties
1812 react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
1813 is used or after the load() is committed and baseUrl() is similar to url() but also depends
1814 on the contents of the page when it loads.
1816 2011-04-04 MORITA Hajime <morrita@google.com>
1818 Reviewed by Ryosuke Niwa.
1820 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1821 https://bugs.webkit.org/show_bug.cgi?id=56085
1823 * WebCoreSupport/EditorClientQt.h:
1824 (WebCore::EditorClientQt::requestCheckingOfString):
1826 2011-04-04 Chang Shu <cshu@webkit.org>
1828 Reviewed by Ryosuke Niwa.
1830 setContentEditable with true/false/inherit string is not working properly
1831 https://bugs.webkit.org/show_bug.cgi?id=52058
1833 Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
1834 as rendererIsEditable is for WebCore internal use.
1836 * WebCoreSupport/EditorClientQt.cpp:
1837 (WebCore::EditorClientQt::handleKeyboardEvent):
1839 2011-04-01 Carol Szabo <carol.szabo@nokia.com>
1841 Reviewed by Benjamin Poulain.
1843 Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
1844 Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
1846 Tiled painting still causes synchronous layout when
1847 accelerated compositing and texture mapper are enabled
1848 https://bugs.webkit.org/show_bug.cgi?id=56929
1850 * Api/qwebframe.cpp:
1851 (QWebFramePrivate::renderFromTiledBackingStore):
1852 (QWebFramePrivate::renderRelativeCoords):
1853 (QWebFramePrivate::renderFrameWidgets):
1854 * Api/qwebframe_p.h:
1856 2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
1858 Reviewed by Benjamin Poulain.
1860 [Qt] DragClientQt.h has coding-style errors
1861 https://bugs.webkit.org/show_bug.cgi?id=40425
1863 * WebCoreSupport/DragClientQt.h:
1865 2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
1867 Reviewed by Kenneth Rohde Christiansen.
1869 [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
1870 https://bugs.webkit.org/show_bug.cgi?id=57017
1872 Build fix. No new tests.
1876 2011-03-31 Evan Martin <evan@chromium.org>
1880 * WebCoreSupport/FrameLoaderClientQt.cpp:
1881 (WebCore::FrameLoaderClientQt::updateGlobalHistory):
1883 2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
1885 Reviewed by Benjamin Poulain.
1887 [Qt] ChromeClientQt.h has coding-style errors
1888 https://bugs.webkit.org/show_bug.cgi?id=40239
1890 * WebCoreSupport/ChromeClientQt.h:
1891 (WebCore::ChromeClientQt::scrollbarsModeDidChange):
1892 (WebCore::ChromeClientQt::needTouchEvents):
1893 (WebCore::ChromeClientQt::formStateDidChange):
1894 (WebCore::ChromeClientQt::scrollRectIntoView):
1895 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
1896 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
1898 2011-03-31 Evan Martin <evan@chromium.org>
1900 Build fix from previous change.
1902 * Api/qwebframe.cpp:
1905 2011-03-31 Evan Martin <evan@chromium.org>
1907 Reviewed by Eric Seidel.
1909 <title> should support dir attribute
1910 https://bugs.webkit.org/show_bug.cgi?id=50961
1912 Update to new FrameLoaderClient interface.
1914 * WebCoreSupport/FrameLoaderClientQt.cpp:
1915 (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
1916 (WebCore::FrameLoaderClientQt::setTitle):
1917 * WebCoreSupport/FrameLoaderClientQt.h:
1919 2011-03-30 Yi Shen <yi.4.shen@nokia.com>
1921 Reviewed by Kenneth Rohde Christiansen.
1923 [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
1924 https://bugs.webkit.org/show_bug.cgi?id=57020
1926 Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
1928 * tests/qwebview/tst_qwebview.cpp:
1929 (tst_QWebView::focusInputTypes):
1931 2011-03-30 Robert Hogan <robert@webkit.org>
1933 Reviewed by Antonio Gomes.
1935 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1937 Add DRT support for loading an alternate HTML string
1938 for error pages. This allows Qt to unskip
1939 http/tests/navigation/go-back-to-error-page.html.
1941 https://bugs.webkit.org/show_bug.cgi?id=52614
1943 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1944 (DumpRenderTreeSupportQt::setAlternateHtml):
1945 * WebCoreSupport/DumpRenderTreeSupportQt.h:
1947 2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
1949 Unreviewed build fix for build-webkit -minimal.
1951 Breakage introduced by http://trac.webkit.org/changeset/82238.
1952 The minimal option has no support for shortcuts.
1954 * WebCoreSupport/EditorClientQt.cpp:
1955 (WebCore::EditorClientQt::handleInputMethodKeydown):
1957 2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
1959 Reviewed by Kenneth Rohde Christiansen.
1961 [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
1962 https://bugs.webkit.org/show_bug.cgi?id=33179
1964 Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
1966 * WebCoreSupport/EditorClientQt.cpp:
1967 (WebCore::EditorClientQt::handleInputMethodKeydown):
1968 * tests/qwebpage/tst_qwebpage.cpp:
1969 (tst_QWebPage::inputMethods):
1971 2011-03-29 Andreas Kling <kling@webkit.org>
1973 Reviewed by Simon Hausmann.
1975 [Qt] Fix documentation for QWebPage::repaintRequested()
1977 This signal is always emitted when the page is dirtied, so remove
1978 reference to old behavior where we would only emit the signal for
1983 2011-03-28 Andreas Kling <kling@webkit.org>
1985 Reviewed by Benjamin Poulain.
1987 [Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
1989 * WebCoreSupport/FrameLoaderClientQt.cpp:
1990 (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
1992 2011-03-28 Andreas Kling <kling@webkit.org>
1994 Reviewed by Benjamin Poulain.
1996 [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
1997 https://bugs.webkit.org/show_bug.cgi?id=52629
1999 * WebCoreSupport/ChromeClientQt.cpp:
2000 (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
2001 QWebPage::repaintRequested() use a Qt::QueuedConnection.
2003 * tests/qwebpage/tst_qwebpage.cpp:
2004 (RepaintRequestedRenderer::RepaintRequestedRenderer):
2005 (RepaintRequestedRenderer::onRepaintRequested):
2006 (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
2007 QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
2008 doesn't cause recursive signal emissions.
2010 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
2012 Reviewed by Andreas Kling.
2014 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2015 https://bugs.webkit.org/show_bug.cgi?id=57087
2017 * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
2018 * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
2019 since they are applications, not libraries.
2021 2011-03-28 Andras Becsi <abecsi@webkit.org>
2023 Reviewed by Csaba Osztrogonác.
2025 [Qt] QtWebKit does not link with --3d-canvas using MinGW
2026 https://bugs.webkit.org/show_bug.cgi?id=57225
2028 * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
2030 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
2032 Reviewed by Andreas Kling.
2034 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
2035 https://bugs.webkit.org/show_bug.cgi?id=57183
2037 Windows buildfix after r82065.
2039 * Api/DerivedSources.pro: Readding escaping on Windows platforms.
2041 2011-03-27 Andreas Kling <kling@webkit.org>
2043 Fix build warning about IconDatabaseClient.h (wrong path.)
2047 2011-03-27 Andreas Kling <kling@webkit.org>
2049 Reviewed by Kenneth Rohde Christiansen.
2051 [Qt] Support for CSS color and background-color properties on select element's dropdown list
2052 https://bugs.webkit.org/show_bug.cgi?id=51627
2054 Extend the QWebSelectData interface with background and foreground colors
2055 for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
2056 getters in RenderMenuList.
2058 * Api/qwebkitplatformplugin.h:
2059 * WebCoreSupport/PopupMenuQt.cpp:
2060 (SelectData::backgroundColor):
2061 (SelectData::foregroundColor):
2062 (SelectData::itemBackgroundColor):
2063 (SelectData::itemForegroundColor):
2064 * WebCoreSupport/QtFallbackWebPopup.cpp:
2065 (WebCore::QtFallbackWebPopup::show):
2066 (WebCore::QtFallbackWebPopup::populate):
2068 2011-03-27 Yi Shen <yi.4.shen@nokia.com>
2070 Reviewed by Andreas Kling.
2072 [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
2073 https://bugs.webkit.org/show_bug.cgi?id=57108
2075 Since the canvas is not self-closing tag, we need to add '</canvas>'.
2077 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2078 (tst_QGraphicsWebView::microFocusCoordinates):
2079 * tests/qwebview/tst_qwebview.cpp:
2080 (tst_QWebView::microFocusCoordinates):
2082 2011-03-27 Kwang Yul Seo <skyul@company100.net>
2084 Reviewed by Eric Seidel.
2086 [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
2087 https://bugs.webkit.org/show_bug.cgi?id=57143
2089 Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
2090 define WTF_USE_TEXTURE_MAPPER=1.
2094 2011-03-27 Andreas Kling <kling@webkit.org>
2096 Reviewed by Benjamin Poulain.
2098 REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
2099 https://bugs.webkit.org/show_bug.cgi?id=57183
2101 The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
2102 which was due to the outputting code previously being wrapped in eval().
2104 * Api/DerivedSources.pro:
2106 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2108 Reviewed by Andreas Kling.
2110 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2111 https://bugs.webkit.org/show_bug.cgi?id=57087
2113 Use explicit conversion for string to avoid depending on the default codec
2114 installed by the user code.
2116 * Api/qwebkitversion.cpp:
2119 (QWebPagePrivate::dynamicPropertyChangeEvent):
2120 (QWebPage::javaScriptConsoleMessage):
2121 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2122 (convertToPropertyName):
2123 (DumpRenderTreeSupportQt::setEditingBehavior):
2124 (DumpRenderTreeSupportQt::plainText):
2125 * WebCoreSupport/EditorClientQt.cpp:
2127 * WebCoreSupport/FrameLoaderClientQt.cpp:
2128 (drtDescriptionSuitableForTestResult):
2129 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
2130 * WebCoreSupport/InspectorClientQt.cpp:
2131 (WebCore::InspectorClientQt::openInspectorFrontend):
2132 * WebCoreSupport/InspectorServerQt.cpp:
2133 (WebCore::parseWebSocketChallengeNumber):
2134 (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
2136 2011-03-26 Andreas Kling <kling@webkit.org>
2138 Reviewed by Kenneth Rohde Christiansen.
2140 [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
2141 https://bugs.webkit.org/show_bug.cgi?id=57157
2143 Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
2144 is always emitted when appropriate.
2146 * QtWebKit.pro: Add new files.
2148 * WebCoreSupport/IconDatabaseClientQt.h: Added.
2149 * WebCoreSupport/IconDatabaseClientQt.cpp: Added.
2150 (WebCore::IconDatabaseClientQt::instance):
2151 (WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
2152 (WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
2153 (WebCore::IconDatabaseClientQt::performImport):
2154 (WebCore::IconDatabaseClientQt::didRemoveAllIcons):
2155 (WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
2156 (WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
2157 (WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
2158 (WebCore::IconDatabaseClientQt::didFinishURLImport):
2160 * WebCoreSupport/FrameLoaderClientQt.h:
2161 * WebCoreSupport/FrameLoaderClientQt.cpp:
2162 (WebCore::FrameLoaderClientQt::registerForIconNotification):
2163 (WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
2164 to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
2165 QWebFrame::iconChanged() signal when the IconDatabases finishes loading
2166 a cached favicon for the frame's URL.
2168 * Api/qwebsettings.cpp:
2169 (QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
2170 instantiated. An IconDatabaseClient has to be registered before the IconDatabase
2171 spawns its reader thread.
2173 2011-03-25 Andy Estes <aestes@apple.com>
2175 Reviewed by Adele Peterson.
2177 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2178 https://bugs.webkit.org/show_bug.cgi?id=49016
2180 Update objectContentType() implementation to handle the
2181 shouldPreferPlugInsForImages flag.
2183 * WebCoreSupport/FrameLoaderClientQt.cpp:
2184 (WebCore::FrameLoaderClientQt::objectContentType):
2185 * WebCoreSupport/FrameLoaderClientQt.h:
2187 2011-03-25 Chang Shu <cshu@webkit.org>
2189 Reviewed by Ryosuke Niwa.
2191 rename Node::isContentEditable and all call sites to rendererIsEditable
2192 https://bugs.webkit.org/show_bug.cgi?id=54290
2194 This is part of the effort to separate JS API HTMLElement isContentEditable from
2195 internal Node::rendererIsEditable.
2197 * WebCoreSupport/EditorClientQt.cpp:
2198 (WebCore::EditorClientQt::handleKeyboardEvent):
2200 2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
2202 Reviewed by Andreas Kling.
2204 [Qt] The keyboard shortcuts during fullscreen playback do not work.
2205 https://bugs.webkit.org/show_bug.cgi?id=57095
2207 We need to explicitely set the focus on the widget in order to receive the keyboard events.
2209 * WebCoreSupport/FullScreenVideoWidget.cpp:
2210 (WebCore::FullScreenVideoWidget::show):
2212 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
2214 Unreviewed, rolling out r81916 and r81917.
2215 http://trac.webkit.org/changeset/81916
2216 http://trac.webkit.org/changeset/81917
2217 https://bugs.webkit.org/show_bug.cgi?id=57071
2219 broke a test on platforms that do not have QuickTime installed
2220 (Requested by estes on #webkit).
2222 * WebCoreSupport/FrameLoaderClientQt.cpp:
2223 (WebCore::FrameLoaderClientQt::objectContentType):
2224 * WebCoreSupport/FrameLoaderClientQt.h:
2226 2011-03-24 Andy Estes <aestes@apple.com>
2228 Reviewed by Darin Adler.
2230 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2231 https://bugs.webkit.org/show_bug.cgi?id=49016
2233 Update objectContentType() implementation to handle the
2234 shouldPreferPlugInsForImages flag.
2236 * WebCoreSupport/FrameLoaderClientQt.cpp:
2237 (WebCore::FrameLoaderClientQt::objectContentType):
2238 * WebCoreSupport/FrameLoaderClientQt.h:
2240 2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
2242 Reviewed by Kenneth Rohde Christiansen.
2244 [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
2245 https://bugs.webkit.org/show_bug.cgi?id=40884
2247 Add tests and benchmarks for the software fallback of WebGL.
2249 * tests/benchmarks/webgl/10000_triangles.html: Added.
2250 * tests/benchmarks/webgl/tst_webgl.cpp: Added.
2251 (GraphicsView::GraphicsView):
2252 (GraphicsView::resizeEvent):
2253 (tst_WebGlPerformance::init):
2254 (tst_WebGlPerformance::cleanup):
2255 (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
2256 (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
2257 (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
2258 (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
2259 (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
2260 * tests/benchmarks/webgl/tst_webgl.qrc: Added.
2261 * tests/benchmarks/webgl/webgl.pro: Added.
2262 * tests/qgraphicswebview/qgraphicswebview.pro:
2263 * tests/qgraphicswebview/resources/pointing_right.html: Added.
2264 * tests/qgraphicswebview/resources/pointing_up.html: Added.
2265 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2266 (compareImagesFuzzyPixelCount):
2267 (GraphicsView::GraphicsView):
2268 (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
2269 (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
2270 (tst_QGraphicsWebView::compareCanvasToImage):
2271 * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
2274 2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
2276 Reviewed by Benjamin Poulain.
2278 Avoided ASCII-cast warnings for WebKit.
2280 Normally they won't be enabled anyway, but if you build webkit from
2281 within the Qt mother repository it will pick up Qt's default build
2282 settings, which do enable it. We need to disable them because
2283 warnings are treated as errors and there are way too many of them in
2286 [Qt] Avoid ASCII-cast warnings for WebKit.
2287 https://bugs.webkit.org/show_bug.cgi?id=57016
2291 2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2293 Reviewed by Benjamin Poulain.
2295 [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
2296 https://bugs.webkit.org/show_bug.cgi?id=29595
2298 Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
2299 ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
2300 prepending the current directory.
2302 By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
2303 will end up loading "about:blank", but keeping it as a requested URL.
2305 This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
2306 is filled for the loaded URLs as well, we can use it in every case.
2308 Three new autotests were added, to better cover the expected behavior of setting
2309 the QUrl() in a QWebFrame.
2311 * Api/qwebframe.cpp:
2312 (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
2313 (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
2315 * WebCoreSupport/FrameLoaderClientQt.cpp:
2316 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
2317 anymore, since we always rely on it even for loaded frames.
2319 * tests/qwebframe/tst_qwebframe.cpp:
2320 (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
2321 the reduction of the bug report.
2322 (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
2323 (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
2325 2011-03-23 Brady Eidson <beidson@apple.com>
2327 Reviewed by Sam Weinig.
2329 Change IconDatabase opening to allow for arbitrary filenames
2330 https://bugs.webkit.org/show_bug.cgi?id=56977
2332 * Api/qwebsettings.cpp:
2333 (QWebSettings::setIconDatabasePath):
2335 2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
2337 Reviewed by Andreas Kling.
2339 [Qt] QtWebKit rendering problem when maximizing and doing a back
2340 https://bugs.webkit.org/show_bug.cgi?id=56669
2343 Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
2345 * tests/qwebview/tst_qwebview.cpp:
2346 (tst_QWebView::rendering):
2348 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
2350 Reviewed by Pavel Feldman.
2352 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2353 https://bugs.webkit.org/show_bug.cgi?id=56843
2355 * WebCoreSupport/InspectorClientQt.cpp:
2356 (WebCore::InspectorClientQt::openInspectorFrontend):
2358 2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
2360 Reviewed by Benjamin Poulain.
2362 [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
2363 https://bugs.webkit.org/show_bug.cgi?id=54138
2365 * tests/qwebpage/tst_qwebpage.cpp:
2366 (webGLScreenshotWithoutView):
2367 (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
2368 (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
2369 Render a QWebPage (with and without accelerated compositing)
2370 with a WebGL context that has no owning view. Shouldn't crash.
2372 2011-03-21 Chang Shu <cshu@webkit.org>
2374 Reviewed by Alexey Proskuryakov.
2376 REGRESSION (r79953): Can't type in MS Outlook 2011
2377 https://bugs.webkit.org/show_bug.cgi?id=56665
2379 r79953 removed the WebView level editablity which is persistent no matter whether
2380 underlying document itself is changed and editability gets lost. The resolution is to
2381 set this WebView editable value to WebCore. This avoids the callback from WebCore to
2382 WebKit which was the main goal in r79953 to improve performance.
2385 (QWebPage::setContentEditable):
2386 (QWebPage::isContentEditable):
2388 2011-03-19 Andreas Kling <kling@webkit.org>
2390 Reviewed by Benjamin Poulain.
2392 [Qt] Remove support for Qt 4.6
2393 https://bugs.webkit.org/show_bug.cgi?id=56712
2395 * Api/qwebframe.cpp:
2398 (QWebPagePrivate::QWebPagePrivate):
2399 * Api/qwebsettings.cpp:
2400 (QWebSettings::QWebSettings):
2401 * WebCoreSupport/GeolocationClientQt.cpp:
2402 (WebCore::GeolocationClientQt::positionUpdated):
2404 2011-03-19 Andreas Kling <kling@webkit.org>
2406 Reviewed by Antonio Gomes.
2408 [Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
2409 https://bugs.webkit.org/show_bug.cgi?id=56711
2411 Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
2412 ownership of the reply is transferred to the receiving slot.
2416 2011-03-17 Brady Eidson <beidson@apple.com>
2418 Reviewed by Sam Weinig.
2420 https://bugs.webkit.org/show_bug.cgi?id=56425
2421 More groundwork for WebKit2 IconDatabase
2423 Update already-used function names:
2424 * Api/qwebhistory.cpp:
2425 (QWebHistoryItem::icon):
2426 * Api/qwebsettings.cpp:
2427 (QWebSettings::iconForUrl):
2429 2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
2431 Reviewed by Benjamin Poulain.
2433 [Qt] console.log not being exposed to QmlViewer
2434 https://bugs.webkit.org/show_bug.cgi?id=56536
2436 The documentation is bogus the feature does not exist.
2438 * declarative/qdeclarativewebview.cpp:
2440 2011-03-17 Andreas Kling <kling@webkit.org>
2442 Reviewed by Kenneth Rohde Christiansen.
2444 [Qt] QML WebView emits iconChanged() when the page title changes
2445 https://bugs.webkit.org/show_bug.cgi?id=56570
2447 * declarative/qdeclarativewebview.cpp:
2448 (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
2449 signal to the view's iconChanged signal.
2451 2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
2453 Reviewed by Benjamin Poulain.
2455 [Qt] Videos look ugly when using QGraphicsWebView.
2456 https://bugs.webkit.org/show_bug.cgi?id=56580
2458 We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
2459 QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
2460 by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
2461 QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
2462 ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
2463 in addition of what could be set on the painter. In order to not break the rendering of all the items in the
2464 scene we set back the painter to its original state when QGraphicsWebView is rendered.
2466 * Api/qgraphicswebview.cpp:
2467 (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
2468 (QGraphicsWebView::paint):
2469 (QGraphicsWebView::renderHints):
2470 (QGraphicsWebView::setRenderHints):
2471 (QGraphicsWebView::setRenderHint):
2472 * Api/qgraphicswebview.h:
2473 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2474 (tst_QGraphicsWebView::renderHints):
2476 2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
2478 Reviewed by Kenneth Rohde Christiansen.
2480 Viewport no longer allows an auto value for "user-scalable"
2481 https://bugs.webkit.org/show_bug.cgi?id=55416
2483 Make the default value for userScalable be true.
2486 (QWebPage::viewportAttributesForSize):
2487 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2488 (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
2490 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
2492 Reviewed by Darin Adler.
2494 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2495 info into the headers rather than in export symbol definition files, but disable it on
2496 all platforms initially so we can deal with port build issues one port at a time.
2498 https://bugs.webkit.org/show_bug.cgi?id=27551
2500 * WebCoreSupport/GeolocationClientQt.cpp:
2501 * WebCoreSupport/PopupMenuQt.cpp:
2503 2011-03-14 Brady Eidson <beidson@apple.com>
2505 Reviewed by Anders Carlsson.
2507 https://bugs.webkit.org/show_bug.cgi?id=56320
2508 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2510 * Api/qwebhistory.cpp:
2511 (QWebHistoryItem::icon): Use IconDatabase directly.
2513 2011-03-11 Brady Eidson <beidson@apple.com>
2515 Reviewed by attempt at build fix!
2517 https://bugs.webkit.org/show_bug.cgi?id=56216
2518 Fix the Qt build following the same pattern of the patch.
2520 * Api/qwebsettings.cpp:
2521 (QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
2523 2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
2525 Reviewed by Ariya Hidayat.
2527 [Qt] Entering fullscreen and leaving it may hide the cursor of the application.
2528 https://bugs.webkit.org/show_bug.cgi?id=56181
2530 We need to stop the auto hide cursor timer when closing the widget otherwise the timer
2531 might get fired and therefore hide the cursor even when the fullscreen widget is closed.
2533 * WebCoreSupport/FullScreenVideoWidget.cpp:
2534 (WebCore::FullScreenVideoWidget::closeEvent):
2536 2011-03-10 David Boddie <david.boddie@nokia.com>
2538 Reviewed by Andreas Kling.
2540 Fixed a qdoc warning and terminology (WebKit instead of Webkit).
2541 https://bugs.webkit.org/show_bug.cgi?id=55756
2543 * Api/qwebhistoryinterface.cpp:
2545 2011-03-10 Andreas Kling <kling@webkit.org>
2547 Unreviewed build fix after r80774.
2549 QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
2550 See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
2552 * declarative/plugin.cpp:
2553 (WebKitQmlPlugin::registerTypes):
2554 * declarative/qdeclarativewebview.cpp:
2555 * declarative/qdeclarativewebview_p.h:
2556 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2558 2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
2560 Reviewed by Andreas Kling.
2562 [Qt] QtDeclarative Webview element has a fixed white background
2563 https://bugs.webkit.org/show_bug.cgi?id=40918
2565 Implement a way to change the background color of the WebView QML element.
2566 This feature is activated for QtWebKit 1.1 version of the plugin.
2568 * declarative/plugin.cpp:
2569 (WebKitQmlPlugin::registerTypes):
2570 * declarative/qdeclarativewebview.cpp:
2571 (QDeclarativeWebView::backgroundColor):
2572 (QDeclarativeWebView::setBackgroundColor):
2573 * declarative/qdeclarativewebview_p.h:
2574 * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
2575 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2576 (tst_QDeclarativeWebView::backgroundColor):
2577 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2579 2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
2581 Reviewed by Laszlo Gombos.
2583 [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
2584 https://bugs.webkit.org/show_bug.cgi?id=55945
2586 Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
2587 set interval used to trigger when decoded data in dead list of object cache will
2588 be purged from object cache.
2591 (QWebPagePrivate::dynamicPropertyChangeEvent):
2593 2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2595 Reviewed by Antonio Gomes.
2597 Simplify how QWebFrame::requestedUrl() is obtained
2598 https://bugs.webkit.org/show_bug.cgi?id=55842
2600 When a load starts, store the requested URL until we know that it'll be
2601 available for us in the document loader -- after load finished.
2603 The existing auto tests cover the three different code paths in
2604 requestedUrl() and the new code passes the autotests. In each of those
2605 cases, we looked for the information in a different place, but in all
2606 of them, dispatchDidStartProvisionalLoad was called.
2608 This simplification will be useful to fix bug 32723. The way requestedUrl()
2609 is implementent, we can't use it as a fallback for url() when the setUrl()
2610 was called with an invalid URL.
2612 * Api/qwebframe.cpp:
2613 (QWebFrame::requestedUrl):
2614 * WebCoreSupport/FrameLoaderClientQt.cpp:
2615 (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
2616 (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
2617 * WebCoreSupport/FrameLoaderClientQt.h:
2618 (WebCore::FrameLoaderClientQt::lastRequestedUrl):
2620 2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2622 Reviewed by Kenneth Rohde Christiansen.
2624 Tiled backing store's delegated scroll request uses incorrect convention
2625 https://bugs.webkit.org/show_bug.cgi?id=56011
2627 Adapt internal API to match the change from delta to point on the
2628 WebCore side, and convert the point to a delta for the public API.
2630 * WebCoreSupport/ChromeClientQt.cpp:
2631 (WebCore::ChromeClientQt::delegatedScrollRequested):
2632 * WebCoreSupport/ChromeClientQt.h:
2634 2011-03-09 Peter Kasting <pkasting@google.com>
2636 Reviewed by Mihai Parparita.
2638 Unify Windows version checks.
2639 https://bugs.webkit.org/show_bug.cgi?id=55979
2642 (QWebPage::userAgentForUrl):
2644 2011-03-07 Sam Weinig <sam@webkit.org>
2646 Reviewed by Anders Carlsson.
2648 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2649 https://bugs.webkit.org/show_bug.cgi?id=55827
2651 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2652 and pass the entire response, instead of just the MIMEType.
2654 * WebCoreSupport/FrameLoaderClientQt.cpp:
2655 (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
2656 * WebCoreSupport/FrameLoaderClientQt.h:
2658 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
2660 Reviewed by Laszlo Gombos.
2662 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
2663 https://bugs.webkit.org/show_bug.cgi?id=48636
2665 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
2668 (QWebPage::userAgentForUrl):
2670 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
2672 Reviewed by Kenneth Rohde Christiansen.
2674 [QT] Implement mock client-based geolocation for layout testing
2675 https://bugs.webkit.org/show_bug.cgi?id=54334
2677 Implement layout testing for Client-Based geolocation. If drt_run is set
2678 then create mock geolocationClient and update the same with controller.
2681 (QWebPagePrivate::QWebPagePrivate):
2682 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2683 (DumpRenderTreeSupportQt::mockGeolocationReset):
2684 (DumpRenderTreeSupportQt::setMockGeolocationPermission):
2685 (DumpRenderTreeSupportQt::setMockGeolocationPosition):
2686 (DumpRenderTreeSupportQt::setMockGeolocationError):
2687 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2688 * WebCoreSupport/GeolocationClientQt.cpp:
2689 (WebCore::GeolocationClientQt::GeolocationClientQt):
2690 * WebCoreSupport/GeolocationClientQt.h:
2692 2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2694 Reviewed by Kenneth Rohde Christiansen.
2696 [Qt] QWebFrame::setUrl works only from second time if url fragment is present
2697 https://bugs.webkit.org/show_bug.cgi?id=32723
2699 Create an auto-test for Qt based on the bug description.
2701 * tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
2703 2011-03-03 Brady Eidson <beidson@apple.com>
2705 Reviewed by Darin Adler.
2707 https://bugs.webkit.org/show_bug.cgi?id=55721
2708 Global IconDatabase should be returned by reference, not as a pointer
2710 * Api/qwebsettings.cpp:
2711 (QWebSettings::setIconDatabasePath):
2712 (QWebSettings::iconDatabasePath):
2713 (QWebSettings::clearIconDatabase):
2714 (QWebSettings::iconForUrl):
2716 2011-03-03 Alexey Proskuryakov <ap@apple.com>
2718 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2721 * WebCoreSupport/ChromeClientQt.h:
2723 2011-03-02 Alexey Proskuryakov <ap@apple.com>
2725 Reviewed by Darin Adler.
2727 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2728 https://bugs.webkit.org/show_bug.cgi?id=55633
2729 <rdar://problem/8963023>
2731 * WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
2732 * WebCoreSupport/ChromeClientQt.h:
2733 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2734 this platform doesn't observe or have full keyboard access state.
2736 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
2738 Reviewed by Andreas Kling.
2740 [Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
2741 https://bugs.webkit.org/show_bug.cgi?id=55568
2743 We should use updateMicroFocus() from QGraphicsItem rather than the implementation
2744 in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
2745 In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
2748 * Api/qgraphicswebview.cpp:
2749 (QGraphicsWebView::setPage):
2750 * Api/qgraphicswebview.h:
2752 2011-03-03 Peter Kasting <pkasting@google.com>
2754 Reviewed by James Robinson.
2756 Drop redundant "Windows; " from the Windows-specific User Agent string.
2757 https://bugs.webkit.org/show_bug.cgi?id=54567
2760 (QWebPage::userAgentForUrl):
2762 2011-03-01 Brian Weinstein <bweinstein@apple.com>
2764 Reviewed by Adam Roben.
2766 Part of WebKit2: Need a way to send notifications to client when cookies change
2767 https://bugs.webkit.org/show_bug.cgi?id=55427
2768 <rdar://problem/9056027>
2770 Add stubs for CookiesStrategy on Qt WebKit1.
2772 * WebCoreSupport/WebPlatformStrategies.cpp:
2773 (WebPlatformStrategies::createCookiesStrategy):
2774 (WebPlatformStrategies::notifyCookiesChanged):
2775 * WebCoreSupport/WebPlatformStrategies.h:
2777 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2779 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
2782 (QWebPage::viewportAttributesForSize):
2783 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2784 (DumpRenderTreeSupportQt::viewportAsText):
2786 2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
2788 Reviewed by Kenneth Rohde Christiansen.
2790 Viewport Warning/Error Messages Are Now Inaccurate
2791 https://bugs.webkit.org/show_bug.cgi?id=53707
2794 (QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
2795 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2796 (DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
2798 2011-03-01 Andras Becsi <abecsi@webkit.org>
2800 Reviewed by Csaba Osztrogonác.
2802 [Qt] Clean up the project files and move common options to WebKit.pri.
2804 * QtWebKit.pro: Move common options to WebKit.pri.
2806 2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
2808 Reviewed by Simon Hausmann.
2810 [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
2811 https://bugs.webkit.org/show_bug.cgi?id=55319
2813 The test case required internet connection to be able to connect to
2814 google.com. Added new html file which refers to local html file.
2816 * tests/qwebpage/resources/content.html: Added.
2817 * tests/qwebpage/resources/frame_c.html: Added.
2818 * tests/qwebpage/resources/framedindex.html: Added.
2819 * tests/qwebpage/tst_qwebpage.cpp:
2820 (tst_QWebPage::backActionUpdate):
2821 * tests/qwebpage/tst_qwebpage.qrc:
2823 2011-02-25 Steve Block <steveblock@google.com>
2825 Reviewed by Jeremy Orlow.
2827 Bridge.h should not include BridgeJSC.h
2828 https://bugs.webkit.org/show_bug.cgi?id=55212
2830 Include BridgeJSC.h directly instead.
2832 * Api/qwebframe.cpp:
2834 2011-02-28 Chang Shu <cshu@webkit.org>
2836 Reviewed by Ryosuke Niwa.
2838 Remove the support of Frame::isContentEditable and its dependencies.
2839 https://bugs.webkit.org/show_bug.cgi?id=54292
2841 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2844 (QWebPagePrivate::QWebPagePrivate):
2845 (QWebPage::setContentEditable):
2846 (QWebPage::isContentEditable):
2848 * WebCoreSupport/EditorClientQt.cpp:
2849 * WebCoreSupport/EditorClientQt.h:
2851 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2853 Reviewed by Oliver Hunt.
2855 Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
2857 * Api/qwebelement.cpp:
2858 (QWebElement::evaluateJavaScript):
2860 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
2862 Reviewed by Andreas Kling.
2864 [Qt]tst_QDeclarativeWebView - 8 test cases fail
2865 https://bugs.webkit.org/show_bug.cgi?id=55214
2867 Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
2868 if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
2869 I also refactored the tests so we don't use the network but instead a local html file.
2870 QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
2872 * tests/qdeclarativewebview/resources/sample.html: Added.
2873 * tests/qdeclarativewebview/resources/webviewtest.qml:
2874 * tests/qdeclarativewebview/resources/webviewtestdefault.qml:
2875 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2876 (tst_QDeclarativeWebView::preferredWidthTest):
2877 (tst_QDeclarativeWebView::preferredHeightTest):
2878 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
2879 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
2880 * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
2882 2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
2884 Reviewed by Andreas Kling.
2886 [Qt] Add clipped version of QWebElement::render method.
2887 Allows faster rendering of web element part.
2888 https://bugs.webkit.org/show_bug.cgi?id=50311
2890 * Api/qwebelement.cpp:
2891 (QWebElement::render):
2892 * Api/qwebelement.h:
2893 * tests/qwebelement/tst_qwebelement.cpp:
2894 (tst_QWebElement::render):
2896 2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
2898 Reviewed by Andreas Kling.
2900 Added full webkit module profile and a syncqt profile.
2902 This is for modularized Qt.
2904 [Qt] WebKit patches required to work with a modularized version of Qt
2905 https://bugs.webkit.org/show_bug.cgi?id=53916
2907 * qt_webkit_version.pri:
2909 2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
2911 Reviewed by Antonio Gomes.
2913 [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
2914 https://bugs.webkit.org/show_bug.cgi?id=53917
2916 Adding test case to check the scenario to avoid regressions in the
2919 * tests/qwebframe/tst_qwebframe.cpp:
2921 2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2923 Reviewed by Andreas Kling.
2925 [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
2926 https://bugs.webkit.org/show_bug.cgi?id=55322
2928 Documentation update, add a reference to the QtWebKit bridge page.
2930 * Api/qwebframe.cpp:
2932 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2934 Reviewed by Pavel Feldman.
2936 DumpRenderTree should reset frame opener between tests.
2937 https://bugs.webkit.org/show_bug.cgi?id=54874
2939 Added clearOpener method to DumpRenderTreeSupportQT.
2941 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2942 (DumpRenderTreeSupportQt::clearOpener):
2943 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2945 2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
2947 Reviewed by Andreas Kling.
2949 Make it possible to test the targetdensity-dpi support
2950 https://bugs.webkit.org/show_bug.cgi?id=55142
2952 Test the viewport meta tag feature targetdensity-dpi by
2953 adding extra arguments to dumpConfigurationForViewport
2955 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2956 (DumpRenderTreeSupportQt::viewportAsText):
2957 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2959 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
2961 Unreviewed, rolling out r79764.
2962 http://trac.webkit.org/changeset/79764
2963 https://bugs.webkit.org/show_bug.cgi?id=55295
2965 "broke Chromium builds" (Requested by rniwa on #webkit).
2967 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2968 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2970 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2972 Reviewed by Pavel Feldman.
2974 DumpRenderTree should reset frame opener between tests.
2975 https://bugs.webkit.org/show_bug.cgi?id=54874
2977 Added clearOpener method to DumpRenderTreeSupportQT.
2979 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2980 (DumpRenderTreeSupportQt::clearOpener):
2981 * WebCoreSupport/DumpRenderTreeSupportQt.h:
2983 2011-02-25 Andras Becsi <abecsi@webkit.org>
2985 Reviewed by Csaba Osztrogonác.
2987 [Qt] Make the WebKit2 build system less confusing for non-Qt developers
2988 https://bugs.webkit.org/show_bug.cgi?id=55213
2990 * QtWebKit.pro: Move the WebKit2 API into a project include file
2991 in the WebKit2 directory and include the pri file here.
2993 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
2995 Unreviewed build fix for Intel ICC and MSVC.
2997 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
2998 (tst_QGraphicsWebView::setPalette):
2999 * tests/qwebview/tst_qwebview.cpp:
3000 (tst_QWebView::setPalette):
3002 2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
3004 Reviewed by Kenneth Rohde Christiansen.
3006 [Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
3007 https://bugs.webkit.org/show_bug.cgi?id=31742
3009 Discovered while looking at 31742. When we set a palette on the
3010 QGraphicsWebView we need to propagate it to the page like QWebView.
3011 I have added the same tests as QWebView to be sure to catch potential
3012 regressions as well as two extras QVERIFY to check the palette propagation.
3014 * Api/qgraphicswebview.cpp:
3015 (QGraphicsWebView::event):
3016 * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
3017 (tst_QGraphicsWebView::setPalette_data):
3018 (tst_QGraphicsWebView::setPalette):
3020 2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
3022 Unreviewed buildfix after r79672.
3024 [Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
3029 2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
3031 Reviewed by Kenneth Rohde Christiansen.
3033 [Qt] QML WebView inside a Flickable shows checkers pattern at startup
3034 https://bugs.webkit.org/show_bug.cgi?id=50222.
3036 This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
3038 * declarative/qdeclarativewebview.cpp:
3039 (QDeclarativeWebView::init):
3040 * tests/qdeclarativewebview: Added.
3041 * tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
3042 * tests/qdeclarativewebview/resources: Added.
3043 * tests/qdeclarativewebview/resources/webviewtest.qml: Added.
3044 * tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
3045 * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
3046 (tst_QDeclarativeWebView::initTestCase):
3047 (tst_QDeclarativeWebView::cleanupTestCase):
3048 (tst_QDeclarativeWebView::init):
3049 (tst_QDeclarativeWebView::cleanup):
3050 (tst_QDeclarativeWebView::preferredWidthTest):
3051 (tst_QDeclarativeWebView::preferredHeightTest):
3052 (tst_QDeclarativeWebView::preferredWidthDefaultTest):
3053 (tst_QDeclarativeWebView::preferredHeightDefaultTest):
3054 (tst_QDeclarativeWebView::checkNoErrors):
3058 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
3060 Reviewed by Andreas Kling.
3062 [Qt] Revert the support for QNAM affined to a different thread.
3063 https://bugs.webkit.org/show_bug.cgi?id=55149
3065 Qt 4.8 will have QNAM use its own thread internally by default,
3066 no need to keep this complexity in WebKit.
3068 This mainly reverts:
3069 http://trac.webkit.org/changeset/73710
3070 http://trac.webkit.org/changeset/73712
3072 * WebCoreSupport/FrameLoaderClientQt.cpp:
3073 (WebCore::FrameLoaderClientQt::download):
3074 * tests/qwebpage/tst_qwebpage.cpp:
3076 2011-02-24 Sam Weinig <sam@webkit.org>
3078 Try to fix the Qt build.
3082 2011-02-24 Peter Kasting <pkasting@google.com>
3084 Reviewed by Eric Seidel.
3086 Drop the "U; " encryption level from the User Agent string.
3087 https://bugs.webkit.org/show_bug.cgi?id=54566
3090 (QWebPage::userAgentForUrl):
3092 2011-02-24 Andrew Wilson <atwilson@chromium.org>
3094 Unreviewed, rolling out r79570.
3095 http://trac.webkit.org/changeset/79570
3096 https://bugs.webkit.org/show_bug.cgi?id=54874
3098 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
3101 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3102 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3104 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
3106 Reviewed by Alexey Proskuryakov.
3108 DumpRenderTree should reset frame opener between tests.
3109 https://bugs.webkit.org/show_bug.cgi?id=54874
3111 Added clearOpener method to DumpRenderTreeSupportQT.
3113 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3114 (DumpRenderTreeSupportQt::clearOpener):
3115 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3117 2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
3119 Reviewed by Andreas Kling.
3121 [Qt] tst_QWebView::setPalette(activeFG) fails
3122 https://bugs.webkit.org/show_bug.cgi?id=55029
3124 This time it should be the proper fix. The window needs to be shown before we
3125 call activateWindow() otherwise there is no active windows for the application.
3127 * tests/qwebview/tst_qwebview.cpp:
3128 (tst_QWebView::setPalette):
3130 2011-02-24 Andras Becsi <abecsi@webkit.org>
3132 Reviewed by Laszlo Gombos.
3134 [Qt] MinGW build fails to link
3135 https://bugs.webkit.org/show_bug.cgi?id=55050
3137 Prepend the libraries of subcomponents instead of appending them
3138 to fix the library order according to the dependency of the libraries
3140 * QtWebKit.pro: prepend libraries in the correct order
3142 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
3144 Reviewed by Ariya Hidayat.
3146 [Qt] tst_QWebView::setPalette(activeFG) fails
3147 https://bugs.webkit.org/show_bug.cgi?id=55029
3149 Attempt to make the test more robust. By investigating with the bot virtual machine
3150 I discovered that the activation can take some time. In this patch we make sure that
3151 the active window we want to have is the same as the QApplication.
3153 * tests/qwebview/tst_qwebview.cpp:
3154 (tst_QWebView::setPalette):
3156 2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
3158 Reviewed by Dan Bernstein.
3160 [Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
3161 http://trac.webkit.org/changeset/79167 refactored the way the bound size of
3162 the frame is handled. A new API setBoundsSize was added, we need to call it
3163 in addition to setFrameRect. I could call setBoundSize after setFrameRect but
3164 I thought It would be more elegant to use the resize method.
3167 (QWebPage::setViewportSize):
3169 2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
3171 Reviewed by Laszlo Gombos.
3173 [Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
3174 https://bugs.webkit.org/show_bug.cgi?id=54976
3178 * WebCoreSupport/InspectorClientQt.cpp:
3180 2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
3182 Reviewed by Andreas Kling.
3184 [Qt] QWebView ignores a palette set with QWebView::setPalette()
3185 https://bugs.webkit.org/show_bug.cgi?id=31742
3187 Test case to check that the palette sets on the QWebView is taken
3190 * tests/qwebview/tst_qwebview.cpp:
3191 (tst_QWebView::setPalette_data):
3192 (tst_QWebView::setPalette):
3194 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
3196 Reviewed by Alexey Proskuryakov.
3198 Drop the language tag part from the User Agent string
3199 https://bugs.webkit.org/show_bug.cgi?id=54560
3202 (QWebPage::userAgentForUrl):
3204 * tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
3207 2011-02-22 Chang Shu <cshu@webkit.org>
3209 Reviewed by Csaba Osztrogonác.
3211 [Qt] editing/deleting/5408255.html fails
3212 https://bugs.webkit.org/show_bug.cgi?id=54964
3214 Move WebCore resource file to QtWebKit since they are referred in WebKit.
3218 2011-02-22 Andras Becsi <abecsi@webkit.org>
3220 Reviewed by Csaba Osztrogonác.
3222 [Qt] Redesign the build system
3223 https://bugs.webkit.org/show_bug.cgi?id=51339
3225 Move inspector's resource files into the final build step to fix the layout test regression.
3227 * QtWebKit.pro: Add inspector's reaource files.
3229 2011-02-22 Andras Becsi <abecsi@webkit.org>
3231 Reviewed by Laszlo Gombos.
3232 Rubber-stamped by Csaba Osztrogonác.
3234 [Qt] Redesign the build system
3235 https://bugs.webkit.org/show_bug.cgi?id=51339
3237 The patch landed in r79320 didn't contain the cleanup
3238 which was already addressed in the last attachment.
3240 * QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
3242 2011-02-22 Andras Becsi <abecsi@webkit.org>
3244 Reviewed by Laszlo Gombos.
3246 [Qt] Redesign the build system
3247 https://bugs.webkit.org/show_bug.cgi?id=51339
3251 Build WebCore as a static library, compile the WebKit API and WebKit2 API
3252 in a final step and link to WebKit2, WebCore and JSC libraries to fix
3253 linking issues resulting from stripped away symbols.
3255 * QtWebKit.pro: Added.
3256 Project file for the final build step.
3258 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
3260 Reviewed by Kent Tamura.
3262 Rename Position::node() to Position::deprecatedNode()
3263 https://bugs.webkit.org/show_bug.cgi?id=54622
3265 Replaced the call to node() by a call to containerNode() because the returned node is
3266 used to determine whether or not the selected contents are editable and such a check
3267 must be done against the container node.
3269 * WebCoreSupport/EditorClientQt.cpp:
3270 (WebCore::EditorClientQt::handleKeyboardEvent):
3272 2011-02-19 Charlie Reis <creis@chromium.org>
3274 Reviewed by Mihai Parparita.
3276 Ensure loading has stopped in HistoryController::goToItem
3277 https://bugs.webkit.org/show_bug.cgi?id=54517
3279 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
3281 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
3283 * WebCoreSupport/FrameLoaderClientQt.cpp:
3284 (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
3285 * WebCoreSupport/FrameLoaderClientQt.h:
3287 2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
3289 Reviewed by Eric Seidel.
3291 Remove reduntant checks.
3292 https://bugs.webkit.org/show_bug.cgi?id=54764
3295 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3296 (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
3297 * WebCoreSupport/NotificationPresenterClientQt.cpp:
3298 (WebCore::NotificationPresenterClientQt::toPage):
3300 2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
3304 [Qt] Buildfix for platforms with geolocation disabled.
3306 * Api/qwebpage.cpp: Add the missing guard.
3308 2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
3310 Reviewed by Kenneth Rohde Christiansen.
3312 [Qt] Implement client based geolocation for qtport
3313 https://bugs.webkit.org/show_bug.cgi?id=42629
3315 Implements client based geolocation for qtwebkit.
3316 New client based geolocation contains permission API's as well,
3317 so removed the implementation from ChromeClientQt.cpp.
3320 (QWebPagePrivate::QWebPagePrivate):
3321 * WebCoreSupport/ChromeClientQt.cpp:
3322 * WebCoreSupport/ChromeClientQt.h:
3323 (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
3324 (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
3325 * WebCoreSupport/GeolocationClientQt.cpp: Added.
3326 (WebCore::GeolocationClientQt::GeolocationClientQt):
3327 (WebCore::GeolocationClientQt::~GeolocationClientQt):
3328 (WebCore::GeolocationClientQt::geolocationDestroyed):
3329 (WebCore::GeolocationClientQt::positionUpdated):
3330 (WebCore::GeolocationClientQt::startUpdating):
3331 (WebCore::GeolocationClientQt::stopUpdating):
3332 (WebCore::GeolocationClientQt::setEnableHighAccuracy):
3333 (WebCore::GeolocationClientQt::requestPermission):
3334 (WebCore::GeolocationClientQt::cancelPermissionRequest):
3335 * WebCoreSupport/GeolocationClientQt.h: Added.
3336 (WebCore::GeolocationClientQt::lastPosition):
3338 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
3340 Reviewed by Adam Roben.
3342 HTML5 <details> and <summary>: localized text
3343 https://bugs.webkit.org/show_bug.cgi?id=54260
3345 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
3346 provide the default label to be used by a <details> tag that has no <summary> child.
3348 * WebCoreSupport/WebPlatformStrategies.cpp:
3349 (WebPlatformStrategies::defaultDetailsSummaryText):
3350 * WebCoreSupport/WebPlatformStrategies.h:
3352 2011-02-17 Hui Huang <hui.2.huang@nokia.com>
3354 Reviewed by Laszlo Gombos.
3356 The URL of HTML5 Video Element is percent encoded at websites such as youtube.
3357 It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
3358 the HTTP GET request for the video to be rejected by the service provider.
3359 https://bugs.webkit.org/show_bug.cgi?id=53973.
3361 The bug is fixed by constructing QUrl from the encoded URL in
3362 MediaPlayerPrivateQt::commitLoad.
3364 New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
3365 HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
3366 is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
3367 A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
3368 is skipped if Qt Multimedia is not available.
3370 * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3371 (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
3372 * WebCoreSupport/DumpRenderTreeSupportQt.h:
3373 * tests/qwebpage/tst_qwebpage.cpp:
3374 (tst_QWebPage::loadHtml5Video):
3377 2011-02-17 Andreas Kling <kling@webkit.org>
3379 Reviewed by Antti Koivisto.
3381 [Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
3382 https://bugs.webkit.org/show_bug.cgi?id=49216
3384 * tests/qwebframe/tst_qwebframe.cpp:
3386 == Rolled over to ChangeLog-2011-02-16 ==