2010-07-22 Yael Aharon <yael.aharon@nokia.com>
authorYael Aharon <yael.aharon@nokia.com>
Thu, 22 Jul 2010 23:52:15 +0000 (23:52 +0000)
committerSimon Hausmann <simon.hausmann@nokia.com>
Tue, 3 Aug 2010 15:37:37 +0000 (17:37 +0200)
commit235046a1fbe4cae2938ffe6538e324035a4297e4
tree5c63aba458a35b94449e3239eb8ca2e309dae20f
parentb89b45507310ef7d86cef440784af0f9d1e81f7b
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Add a DRT API to set a flag so that notification requests are ignored,
        and add a test for cancelling a pending notification request.
        New API and test are disabled for Chromium port.

        * fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
        * fast/notifications/notifications-cancel-request-permission.html: Added.
        * fast/notifications/resources: Added.
        * fast/notifications/resources/notifications-cancel-request-permission.html: Added.
        * platform/chromium/test_expectations.txt:
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Remove DumpRenderTree private API and introduce new API.
        Also add support for informing the UI when a notification request is cancelled.

        * Api/qwebpage.cpp:
        (QWebPage::setUserPermission):
        * Api/qwebpage.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationPresenterClientQt::requestPermission):
        (WebCore::NotificationPresenterClientQt::checkPermission):
        (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
        (WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
        (WebCore::NotificationPresenterClientQt::toPage):
        (WebCore::NotificationPresenterClientQt::toFrame):
        * WebCoreSupport/NotificationPresenterClientQt.h:
2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=41413

        Update DumpRenderTree and QtTestBrowser to use the new API.
        Add new DRT API to flag that notifications permission requests should be ignored.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::requestPermission):
        (WebCore::WebPage::checkPermission):
        (WebCore::WebPage::cancelRequestsForPermission):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
        (LayoutTestController::checkDesktopNotificationPermission):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::ignoreReqestForPermission):
        * QtTestBrowser/main.cpp:
        (LauncherWindow::LauncherWindow):
        * QtTestBrowser/webpage.cpp:
        (WebPage::WebPage):
        (WebPage::requestPermission):
        (WebPage::checkPermission):
        (WebPage::cancelRequestsForPermission):
        * QtTestBrowser/webpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/notifications/notifications-cancel-request-permission-expected.txt [new file with mode: 0644]
LayoutTests/fast/notifications/notifications-cancel-request-permission.html [new file with mode: 0644]
LayoutTests/fast/notifications/resources/notifications-cancel-request-permission.html [new file with mode: 0644]
LayoutTests/platform/chromium/test_expectations.txt
WebKit/qt/Api/qwebpage.cpp
WebKit/qt/Api/qwebpage.h
WebKit/qt/ChangeLog
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp
WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.h
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h
WebKitTools/QtTestBrowser/main.cpp
WebKitTools/QtTestBrowser/webpage.cpp
WebKitTools/QtTestBrowser/webpage.h