webkit:qtwebkit.git
7 years ago2010-09-27 Andreas Kling <andreas.kling@nokia.com>
Andreas Kling [Mon, 27 Sep 2010 11:45:31 +0000 (11:45 +0000)]
2010-09-27  Andreas Kling  <andreas.kling@nokia.com>

        Rubber-stamped by Kenneth Rohde Christiansen.

        [Qt] 32-bit Flash crashes on repeated SetWindow calls
        https://bugs.webkit.org/show_bug.cgi?id=46616

        Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

        We incorrectly thought this was fixed in Flash 10, but it turns out it
        was just never broken on 64-bit.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::determineQuirks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue [Tue, 19 Oct 2010 05:37:04 +0000 (05:37 +0000)]
2010-10-18  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Export QWebPage::ViewportAttributes class.
        https://bugs.webkit.org/show_bug.cgi?id=47845

        * Api/qwebpage.h:
        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-18 Yi Shen <yi.4.shen@nokia.com>
commit-queue [Mon, 18 Oct 2010 15:41:14 +0000 (15:41 +0000)]
2010-10-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [QT] Unable to load pages on QtTestBrowser after canceling a page load.
        https://bugs.webkit.org/show_bug.cgi?id=43827

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-04 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue [Wed, 4 Aug 2010 18:08:46 +0000 (18:08 +0000)]
2010-08-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Variable max heap size between target/emulator
        https://bugs.webkit.org/show_bug.cgi?id=41480

        * WebKit.pri: Symbian-only code block for EPOCHEAPSIZE configuration

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up the winscw changes
Dinu Jacob [Mon, 18 Oct 2010 12:23:19 +0000 (14:23 +0200)]
Clean up the winscw changes

Guard some winscw specific changes with COMPILER(WINSCW), to make sure that
the other compiler/platform builds are not affected.

Signed-off-by: Simon Hausmann <simon.hausmann@nokia.com>
7 years agoUpdated the def file for winscw
Simon Hausmann [Thu, 7 Oct 2010 13:17:33 +0000 (15:17 +0200)]
Updated the def file for winscw

7 years agoFix winscw cast when returning bool on methods which return Value
Ademar de Souza Reis Jr [Fri, 8 Oct 2010 09:19:08 +0000 (11:19 +0200)]
Fix winscw cast when returning bool on methods which return Value

7 years agoWinscw build fix
Ademar de Souza Reis Jr [Thu, 7 Oct 2010 08:36:54 +0000 (10:36 +0200)]
Winscw build fix

Based on patch made by Yael Aharon <yael.aharon@nokia.com>.

Original patch (from 2010-09-06) here:
http://gitorious.org/~ekoppen/webkit/qtwebkit-symbian-qtp/commit/a7086cc3132a5bf78c73b941f372b84d7da29467

7 years ago2010-10-15 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue [Fri, 15 Oct 2010 16:27:27 +0000 (16:27 +0000)]
2010-10-15  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] window.close() doesn't work in qt
        https://bugs.webkit.org/show_bug.cgi?id=46186

        Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-13 Yi Shen <yi.4.shen@nokia.com> qtwebkit-2.1-week41
commit-queue [Wed, 13 Oct 2010 23:58:00 +0000 (23:58 +0000)]
2010-10-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser shows two Url input fields
        https://bugs.webkit.org/show_bug.cgi?id=47613

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::buildUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-08 Hui Huang <hui.2.huang@nokia.com>
commit-queue [Fri, 8 Oct 2010 13:58:11 +0000 (13:58 +0000)]
2010-10-08  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Simon Hausmann.

        ifdef out code that rewrites Flash Plug-in wmode for Symbian build
        https://bugs.webkit.org/show_bug.cgi?id=43484

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-13 Dinu Jacob <dinu.jacob@nokia.com>
commit-queue [Wed, 13 Oct 2010 11:56:12 +0000 (11:56 +0000)]
2010-10-13  Dinu Jacob  <dinu.jacob@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Update .def file for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=47540

        Updated symbols for Symbian - added viewportAttributesForSize and
        made viewportConfigurationForSize absent based on the API change in
        47325

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-12 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 12 Oct 2010 14:47:24 +0000 (14:47 +0000)]
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        * fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
        * fast/events/scroll-after-click-on-tab-index.html: Added.
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        Remove calls to editor()->command() when we are not in editable content.
        There is no value in doing that, and in some cases, it prevents scrolling.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-12 David Leong <david.leong@nokia.com>
commit-queue [Wed, 13 Oct 2010 04:29:24 +0000 (04:29 +0000)]
2010-10-12  David Leong  <david.leong@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable Netscape plugin metadata caching on Linux
        https://bugs.webkit.org/show_bug.cgi?id=46287

        QWebSettings::enablePersistentStorage will now store the netscape
        plugin cache to QDesktopServices::CacheLocation.

        * Api/qwebsettings.cpp:
        (QWebSettings::enablePersistentStorage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
Andreas Kling [Wed, 13 Oct 2010 14:11:32 +0000 (16:11 +0200)]
2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

        Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
        different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
        were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
        all page specific stuff to the UI.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::initializeView):
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::buildUI):
        (MainWindow::setPage):
        * QtTestBrowser/mainwindow.h:

7 years agoWindowless flash plugin is not rendered in Symbian qtwebkit-2.1-week40
Simon Hausmann [Thu, 7 Oct 2010 09:11:44 +0000 (09:11 +0000)]
Windowless flash plugin is not rendered in Symbian
https://bugs.webkit.org/show_bug.cgi?id=47172

Patch by Zraly Mike <mike.zraly@nokia.com> on 2010-10-07
Reviewed by Andreas Kling.

* plugins/symbian/PluginViewSymbian.cpp:
(WebCore::PluginView::platformStart):
Add call to updatePluginWidget() following changes to
platform widget.  This is needed to set PluginView's
m_windowRect and m_clipRect members properly after
the proxy widget and its container get created.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-07 Andreas Kling <kling@webkit.org>
commit-queue [Thu, 7 Oct 2010 19:41:44 +0000 (19:41 +0000)]
2010-10-07  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] API: ViewportConfiguration => ViewportArguments
        https://bugs.webkit.org/show_bug.cgi?id=47325

        * Api/qwebpage.cpp:
        (QWebPage::ViewportAttributes::ViewportAttributes):
        (QWebPage::ViewportAttributes::~ViewportAttributes):
        (QWebPage::ViewportAttributes::operator=):
        (QWebPage::viewportAttributesForSize):
        * Api/qwebpage.h:
        * Api/qwebpage_p.h:
        (QtViewportAttributesPrivate::QtViewportAttributesPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue [Wed, 6 Oct 2010 17:34:24 +0000 (17:34 +0000)]
2010-10-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
        https://bugs.webkit.org/show_bug.cgi?id=47268

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

        * dom/ViewportArguments.cpp:
        (WebCore::findConfigurationForViewportData):
        * dom/ViewportArguments.h:
2010-10-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
        https://bugs.webkit.org/show_bug.cgi?id=47268

        Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

        * Api/qwebpage.cpp:
        (QWebPage::viewportConfigurationForSize):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Re-enable the web inspector for maemo6 builds
hausmann@webkit.org [Thu, 7 Oct 2010 11:17:10 +0000 (11:17 +0000)]
[Qt] Re-enable the web inspector for maemo6 builds

Rubber-stamped by Tor Arne Vestbø.

Yeah, it's strange :), but they really want it.

* WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix due to unsuccessful merge (b2d63cf)
Ademar de Souza Reis Jr [Wed, 6 Oct 2010 15:11:03 +0000 (17:11 +0200)]
Build fix due to unsuccessful merge (b2d63cf)

The merge on
b2d63cf26fad312ca53ba30506e2ea4e7d448042 was faulty, this is a
trivial fix.

7 years agoUnreviewed build fix.
Simon Hausmann [Tue, 5 Oct 2010 13:27:36 +0000 (13:27 +0000)]
Unreviewed build fix.

[Symbian] Fix build issue due to gaps in ordinals in the def file

Restore previously removed symbols and mark them absent instead. We must
not remove symbols from this file, because it breaks binary compatibility
(when re-assigning the ordinals of the following symbols) or it causes build
breakage when instead having a gap in the ordinal sequence. Instead removing
a symbol is done by marking it as absent.

* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove setDeviceSize methods
Kenneth Rohde Christiansen [Tue, 28 Sep 2010 00:31:09 +0000 (00:31 +0000)]
[Qt] Remove setDeviceSize methods

https://bugs.webkit.org/show_bug.cgi?id=46347

Reviewed by Antonio Gomes.

Remove our setDeviceHeight() API and obtain it automatically from the
system. Also for testing purposes, make it possible to override the
values via two newly introduced environment variables.

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebpage.cpp:
(getintenv):
(queryDeviceSizeForScreenContainingWidget):
(QWebPage::viewportConfigurationForSize):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::windowRect):
* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
commit-queue [Sat, 2 Oct 2010 00:24:10 +0000 (00:24 +0000)]
2010-10-01  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Segmentation fault during zoom out
        https://bugs.webkit.org/show_bug.cgi?id=46984

        * platform/qt/QtMobileWebStyle.cpp:
        (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Andreas Kling [Fri, 1 Oct 2010 13:52:33 +0000 (13:52 +0000)]
2010-10-01  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] New buttons style for Qt Mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=46920

        Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
        Adjust new Qt mobile style for buttons, radios, checks and combos.

        * WebCore.pro:
        * css/themeQtMobile.css: Adjust gradient color for buttons and combos.
        (select):
        (select:active):
        * platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme.
        (QtMobileWebStyle::QtMobileWebStyle):
        (drawRectangularControlBackground):
        (QtMobileWebStyle::drawChecker):
        (QtMobileWebStyle::findChecker):
        (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton.
        (QtMobileWebStyle::findRadio):
        (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox.
        (QtMobileWebStyle::drawMultipleComboButton):
        (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow.
        (QtMobileWebStyle::getButtonImageSize):
        (QtMobileWebStyle::findComboButton):
        (QtMobileWebStyle::drawComplexControl):
        * platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::RenderThemeQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-27 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Diego Gonzalez [Mon, 27 Sep 2010 15:56:51 +0000 (15:56 +0000)]
2010-09-27  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] New input style for Qt Mobile theme
    https://bugs.webkit.org/show_bug.cgi?id=46461

    Rename themeQtMaemo5.css to themeQtMobile.css since it is the theme for all Qt mobile platform.
    Adjust new input style.

    * WebCore.pri:
    * css/themeQtMobile.css: Renamed from css/themeQtMaemo5.css
    (select):
    (select:disabled):
    (select:active):
    (select:active:disabled):
    (textarea):
    (textarea:disabled):
    (textarea:active):
    * platform/qt/RenderThemeQt.cpp:
    (WebCore::RenderThemeQt::extraDefaultStyleSheet): Renamed themeQtMaemo5UserAgentStyleSheet to themeQtMobileUserAgentStyleSheet to match renamed file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] On Maemo platform, web style is missing for some inputs
Diego Gonzalez [Wed, 22 Sep 2010 12:10:25 +0000 (12:10 +0000)]
[Qt] On Maemo platform, web style is missing for some inputs
https://bugs.webkit.org/show_bug.cgi?id=46182

Patch by Ragner Magalhaes <ragner.magalhaes@openbossa.org> on 2010-09-21
Reviewed by Kenneth Rohde Christiansen.

* css/themeQtMaemo5.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix RVCT 2.2 def files on Symbian.
Keith Kyzivat [Tue, 5 Oct 2010 18:18:31 +0000 (20:18 +0200)]
Fix RVCT 2.2 def files on Symbian.
viewportConfigurationForSize incorrect.

Reviewed by: Simon Hausmann

7 years agoMerge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit...
Ademar de Souza Reis Jr [Tue, 5 Oct 2010 15:26:37 +0000 (17:26 +0200)]
Merge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit into qtwebkit-2.1

7 years ago2010-10-04 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 5 Oct 2010 05:43:54 +0000 (05:43 +0000)]
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <input type="radio">
        https://bugs.webkit.org/show_bug.cgi?id=46993

        * fast/events/spatial-navigation/snav-radio-expected.txt: Added.
        * fast/events/spatial-navigation/snav-radio-group-expected.txt: Added.
        * fast/events/spatial-navigation/snav-radio-group.html: Added.
        * fast/events/spatial-navigation/snav-radio.html: Added.
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <input type="radio">
        https://bugs.webkit.org/show_bug.cgi?id=46993

        When using Spatial Navigation, every radio button should be focusable and
        users should be able to navigate from one button to the next without moving the selection.

        Tests: fast/events/spatial-navigation/snav-radio-group.html
               fast/events/spatial-navigation/snav-radio.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable):
        Every radio button should be keyboard focusable, if using Spatial Navigation.
        (WebCore::HTMLInputElement::defaultEventHandler):
        Disable the algorithm for selecting the next radio button within a group, if using Spatial Navigation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQtWebkit API 2.1 cleanup.
Keith Kyzivat [Tue, 5 Oct 2010 15:08:28 +0000 (17:08 +0200)]
QtWebkit API 2.1 cleanup.

Remove InputSpeechButtonGraphic from QWebSettings API created in
bc30b43f024...
It is an incomplete feature on the trunk, and Qt 2.1 doesn't support it.

Reviewed-by: Andreas Kling
7 years ago2010-10-04 Chang Shu <chang.shu@nokia.com>
chang.shu [Tue, 5 Oct 2010 04:03:35 +0000 (04:03 +0000)]
2010-10-04  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key "arrowdown" will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        * fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
        * fast/events/spatial-navigation/snav-1st-stop.html: Added.
2010-10-04  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key "arrowdown" will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        Test: fast/events/spatial-navigation/snav-1st-stop.html

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-04 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Tue, 5 Oct 2010 04:28:54 +0000 (04:28 +0000)]
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        * fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-multiple-select.html: Added.
        * fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
        * fast/events/spatial-navigation/snav-single-select.html: Added.
2010-10-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: select element does not release focus with Spatial Navigation
        https://bugs.webkit.org/show_bug.cgi?id=46896

        When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
        to navigate out of the select element. That is because select element currently uses the
        arrow keys to change the selected element.
        Change the behavior of select element so it does not change selection, if Spatial Navigation
        is on.

        This patch is addressing the case where Spatial Navigation is used
        in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
        In the future we can add support for the case where the flag is off, and
        the user needs to traverse the select element inline.

        Tests: fast/events/spatial-navigation/snav-multiple-select.html
               fast/events/spatial-navigation/snav-single-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-28 Luiz Agostini <luiz.agostini@openbossa.org>
Luiz Agostini [Mon, 4 Oct 2010 13:17:11 +0000 (13:17 +0000)]
2010-09-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport data change notifications
        https://bugs.webkit.org/show_bug.cgi?id=46755

        Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
        changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
        viewport data in Page as a reference, to be able to send notifications only when the current viewport
        has changed.

        * dom/Document.cpp:
        (WebCore::Document::processViewport):
        (WebCore::Document::setInPageCache):
        * dom/ViewportArguments.h:
        (WebCore::ViewportArguments::operator==):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::HTMLBodyElement):
        * page/Chrome.cpp:
        (WebCore::Chrome::viewportDataChanged):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::viewportDataChanged):
        * page/Page.cpp:
        (WebCore::Page::updateViewportArguments):
        * page/Page.h:
        (WebCore::Page::viewportArguments):
2010-09-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Viewport data change notifications
        https://bugs.webkit.org/show_bug.cgi?id=46755

        Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
        changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
        viewport data in Page as a reference, to be able to send notifications only when the current viewport
        has changed.

        * Api/qwebframe.cpp:
        * Api/qwebframe_p.h:
        * Api/qwebpage.cpp:
        (QWebPagePrivate::viewportArguments):
        (QWebPage::viewportConfigurationForSize):
        * Api/qwebpage_p.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::viewportDataChanged):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-10-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue [Fri, 1 Oct 2010 14:56:18 +0000 (14:56 +0000)]
2010-10-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Stack overflow on symbian platform.
        https://bugs.webkit.org/show_bug.cgi?id=40598

        Move big allocation in arrayProtoFuncToString from stack to heap.
        JSC::arrayProtoFuncToString function can be called recursivly and
        1K allocation on stack cahse stack overflow.
        Can be useful for other platforms with limited stack size.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix platform plugin support after r68128
hausmann@webkit.org [Mon, 4 Oct 2010 08:09:12 +0000 (08:09 +0000)]
[Qt] Fix platform plugin support after r68128

Rubber-stamped by Tor Arne Vestbø.

Replaced the qobject_cast from the QObject derived extension to a
static_cast. qobject_cast works by comparing pointers to meta-object
instances, of which there are two each: one compiled into WebKit and
one compiled into the plugin.

The platform plugin ensures the validity of the interface contract
through its version and the initial safe qobject_cast from QObject
to QWebKitPlatformPlugin. After that it is safe to use static_cast,
and with the recent changes even required.

* WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::QtPlatformPlugin::createSelectInputMethod):
(WebCore::QtPlatformPlugin::createNotificationPresenter):
(WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com> qtwebkit-2.1-week39
Benjamin Poulain [Thu, 30 Sep 2010 07:22:51 +0000 (07:22 +0000)]
2010-09-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Crash if an scene with accelerated compositing layout during the paint event
        https://bugs.webkit.org/show_bug.cgi?id=46812

        Delay the deletion of the overlay after the current event is processed.

        Removing the overlay can sometimes be done inside the rendering code of
        the overlay itself. When the rendering code is using the reference after
        the deletion of the overlay, WebKit crashes.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::overlay):
        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
        (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
        * WebCoreSupport/PageClientQt.h:
        (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-29 Andreas Kling <andreas.kling@nokia.com>
Andreas Kling [Wed, 29 Sep 2010 16:46:27 +0000 (16:46 +0000)]
2010-09-29  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
        https://bugs.webkit.org/show_bug.cgi?id=46812

        Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
        instead of keeping a local pointer to it.

        This is cleanup for a follow-up patch.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::overlay):
        (QGraphicsWebView::paint):
        (QGraphicsWebView::setPage):
        (QGraphicsWebView::updateGeometry):
        (QGraphicsWebView::setGeometry):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-09 Simon Fraser <simon.fraser@apple.com>
Simon Fraser [Fri, 10 Sep 2010 01:07:58 +0000 (01:07 +0000)]
2010-09-09  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=45509
        <rdar://problem/8142166> REGRESSION: WebView setDrawsBackground:NO no
        longer works without setBackgroundColor:clearColor

        r61215 caused RenderView to paint the viewport background when the
        document element's renderer is known to not fill opaquely paint
        the entire viewport, i.e. more often than it did before.

        This exposed a latent, long-standing bug which was introduced
        in r14638 (the RenderCanvas -> RenderView rename), where a call
        to view()->isTransparent() was not converted to frameView()->isTransparent(),
        yet happened to still compile because of RenderObject::isTransparent().

        This resulted in us painting the viewport background, even when
        WebView clients explicitly said that they wanted a transparent
        WebView.

        Fixed by calling frameView()->isTransparent(), as intended.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-28 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 28 Sep 2010 16:20:57 +0000 (16:20 +0000)]
2010-09-28  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Clean up QWebPage::ViewportConfiguration API
        https://bugs.webkit.org/show_bug.cgi?id=46730

        - Pass QSize parameter as const-reference
        - Style fixes

        * Api/qwebpage.cpp:
        (QWebPage::viewportConfigurationForSize):
        * Api/qwebpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Benjamin Poulain [Tue, 28 Sep 2010 12:18:41 +0000 (12:18 +0000)]
2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] tst_QWebPage::testStopScheduledPageRefresh() fails on MeeGo handset
        https://bugs.webkit.org/show_bug.cgi?id=46706

        The test require the network to succeed or fail in order to work.
        On MeeGo, the network can simply timeout the because of the netword access
        management. This patch makes the test use local URLs to avoid the
        problem.

        * tests/qwebpage/tst_qwebpage.cpp:
        (TestNetworkManager::TestNetworkManager):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Laszlo Gombos [Wed, 18 Aug 2010 21:11:27 +0000 (21:11 +0000)]
2010-08-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, trivial Symbian build fix.

        [Qt] Remove unnecessary QtGui include from NotificationPresenterClientQt.cpp

        * WebCoreSupport/NotificationPresenterClientQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-24 Luiz Agostini <luiz.agostini@openbossa.org>
Luiz Agostini [Fri, 24 Sep 2010 21:54:25 +0000 (21:54 +0000)]
2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Keep viewport information in Document
        https://bugs.webkit.org/show_bug.cgi?id=46385

        The viewport meta data (layout viewport, scale) needs to be set again when bringing
        back a page from the page cache. As the viewport metadata is only retrieved while parsing
        the document, we need to store it in the Document class.

        * fast/viewport/viewport-128-expected.txt: Copied from LayoutTests/fast/viewport/viewport-19-expected.txt.
        * fast/viewport/viewport-128.html: Added.
2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Keep viewport information in Document
        https://bugs.webkit.org/show_bug.cgi?id=46385

        The viewport meta data (layout viewport, scale) needs to be set again when bringing
        back a page from the page cache. As the viewport metadata is only retrieved while parsing
        the document, we need to store it in the Document class.

        Test: fast/viewport/viewport-128.html

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::processViewport):
        (WebCore::Document::setInPageCache):
        * dom/Document.h:
        (WebCore::Document::viewportArguments):
2010-09-24  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Keep viewport information in Document
        https://bugs.webkit.org/show_bug.cgi?id=46385

        The viewport meta data (layout viewport, scale) needs to be set again when bringing
        back a page from the page cache. As the viewport metadata is only retrieved while parsing
        the document, we need to store it in the Document class.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::viewportArguments):
        * Api/qwebframe_p.h:
        * Api/qwebpage.cpp:
        (QWebPage::viewportConfigurationForSize):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::didReceiveViewportArguments):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-27 Girish Ramakrishnan <girish@forwardbias.in>
Girish Ramakrishnan [Mon, 27 Sep 2010 14:54:15 +0000 (14:54 +0000)]
2010-09-27  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Antonio Gomes.

        [Qt] Enable local rendering of NPAPI plugins on Maemo6.

        https://bugs.webkit.org/show_bug.cgi?id=46618

        * WebCore.pro:
        * bridge/npapi.h:
        * plugins/PluginView.cpp:
        (WebCore::PluginView::setValue):
        (WebCore::PluginView::PluginView):
        * plugins/PluginView.h:
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::platformGetValueStatic):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Benjamin Poulain [Mon, 27 Sep 2010 11:48:13 +0000 (11:48 +0000)]
2010-09-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
        https://bugs.webkit.org/show_bug.cgi?id=46617

        This patch avoid the race condition by waiting for the window
        to be mapped on screen before attempting any actions.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore: Make db.changeVersion()'s third parameter optional, as required by the spec. qtwebkit-2.1-week38
Dumitru Daniliuc [Thu, 22 Jul 2010 20:56:49 +0000 (20:56 +0000)]
WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):

LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* fast/workers/storage/resources/change-version-sync-1.js:
* fast/workers/storage/resources/change-version-sync-2.js:
* storage/change-version.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the Wince build.
hausmann@webkit.org [Fri, 24 Sep 2010 14:26:14 +0000 (14:26 +0000)]
[Qt] Fix the Wince build.

Patch by Romain Pokrzywka <romain@kdab.com> on 2010-09-24
Reviewed by Simon Hausmann.

.:

* WebKit.pri: Apply msvc flags to wince, too.

WebCore:

* WebCore.pro: Apply msvc flags to wince, too.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable building Qt/Webkit with debug symbols
hausmann@webkit.org [Fri, 24 Sep 2010 14:24:04 +0000 (14:24 +0000)]
[Qt] Enable building Qt/Webkit with debug symbols

Patch by Anders Bakken <agbakken@gmail.com> on 2010-09-24
Reviewed by Simon Hausmann.

With this patch one can configure with -webkit-debug to build Webkit
with debug symbols without having to manually edit WebCore.pro.

* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-16 Thomas Zander <t.zander@nokia.com>
commit-queue [Thu, 16 Sep 2010 20:05:51 +0000 (20:05 +0000)]
2010-09-16  Thomas Zander <t.zander@nokia.com>

        Reviewed by Andreas Kling.

        https://bugs.webkit.org/show_bug.cgi?id=45878

        [Qt] Fixed incorrect Symbian scoping.

        The missing install functionality is only true for mmp based systems.

        * WebCore.pro: limit functionality to mmp systems.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-24 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Fri, 24 Sep 2010 12:44:42 +0000 (12:44 +0000)]
2010-09-24  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Web Sockets are insecure with QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=44769

        Throw an error when the server certificate is not valid.
        DRT currently does not support secure websocket connection,
        so no new tests. This was tested with the server at
        http://code.google.com/p/pywebsocket instead.

        * platform/network/qt/SocketStreamHandleQt.cpp:
        (WebCore::SocketStreamHandlePrivate::socketSslErrors):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit...
Ademar de Souza Reis Jr [Thu, 23 Sep 2010 22:22:05 +0000 (19:22 -0300)]
Merge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit into qtwebkit-2.1

7 years ago2010-09-23 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue [Thu, 23 Sep 2010 22:08:51 +0000 (22:08 +0000)]
2010-09-23  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Fix QWebHapticFeedbackPlayer exposure via QWebKitPlatformPlugin

        [Qt] QWebHapticFeedbackPlayer needs correct exposure through QWebKitPlatformPlugin
        https://bugs.webkit.org/show_bug.cgi?id=46402

        QWebHapticFeedbackPlayer is exported through
        QWebKitPlatformPlugin::createExtension(), but
        createHapticFeedbackPlayer() and the correct
        inheritage are missing.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
        * WebCoreSupport/QtPlatformPlugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Qt build by adding missing file
Tor Arne Vestbø [Thu, 23 Sep 2010 11:24:28 +0000 (11:24 +0000)]
Fix Qt build by adding missing file

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Tor Arne Vestbø [Thu, 23 Sep 2010 10:53:58 +0000 (10:53 +0000)]
2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Refactor QtWebKitPlatformPlugin interface

        Make it easier to keep source-compability for the
        QtWebKitPlatformPlugin interface, and run qmake
        on the example (but not build) for convenience.

        https://bugs.webkit.org/show_bug.cgi?id=46345

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/QtPlatformPlugin.cpp:
        * examples/platformplugin/README:
        * examples/platformplugin/WebPlugin.cpp:
        * examples/platformplugin/WebPlugin.h:
        * examples/platformplugin/qwebkitplatformplugin.h:
2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Refactor QtWebKitPlatformPlugin interface

        Make it easier to keep source-compability for the
        QtWebKitPlatformPlugin interface, and run qmake
        on the example (but not build) for convenience.

        https://bugs.webkit.org/show_bug.cgi?id=46345

        * Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Symbian] Fix commit/decommit of system memory using RChunk
Simon Hausmann [Tue, 24 Aug 2010 10:38:35 +0000 (10:38 +0000)]
[Symbian] Fix commit/decommit of system memory using RChunk

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-08-24
Reviewed by Simon Hausmann.

Swap accidentially reversed start and m_base values for determining the
offset within the RChunk.

* wtf/PageReservation.h:
(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 43185 - Switch RegisterFile over to use PageAllocation
Gavin Barraclough [Thu, 5 Aug 2010 20:57:33 +0000 (20:57 +0000)]
Bug 43185 - Switch RegisterFile over to use PageAllocation

Reviewed by Sam Weinig.

Remove platform-specific memory allocation code.

* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::~RegisterFile):
(JSC::RegisterFile::releaseExcessCapacity):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
(JSC::RegisterFile::checkAllocatedOkay):
* wtf/PageAllocation.cpp:
(WTF::PageAllocation::lastError):
* wtf/PageAllocation.h:
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::isPageAligned):
(WTF::PageAllocation::isPowerOfTwo):
* wtf/PageReservation.h:
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix part II.
Gavin Barraclough [Thu, 5 Aug 2010 01:19:26 +0000 (01:19 +0000)]
Windows build fix part II.

* wtf/PageReservation.h:
(WTF::PageReservation::systemReserve):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix.
Gavin Barraclough [Thu, 5 Aug 2010 00:53:18 +0000 (00:53 +0000)]
Windows build fix.

* wtf/PageReservation.h:
(WTF::PageReservation::systemReserve):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix - add new header to !Mac projects.
Gavin Barraclough [Thu, 5 Aug 2010 00:21:56 +0000 (00:21 +0000)]
Build fix - add new header to !Mac projects.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJavaScriptCore: Bug 43515 - Fix small design issues with PageAllocation, split out...
Gavin Barraclough [Thu, 5 Aug 2010 00:18:58 +0000 (00:18 +0000)]
JavaScriptCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.

Reviewed by Sam Weinig.

The PageAllocation class has a number of issues:
* Changes in bug #43269 accidentally switched SYMBIAN over to use malloc/free to allocate
  blocks of memory for the GC heap, instead of allocating RChunks.  Revert this change in
  behaviour.
* In order for PageAllocation to work correctly on WinCE we should be decommitting memory
  before deallocating.  In order to simplify understanding the expected state at deallocate,
  split behaviour out into PageAllocation and PageReservation classes.  Require that all
  memory be decommitted before calling deallocate on a PageReservation, add asserts to
  enforce this.
* add many missing asserts.
* inline more functions.
* remove ability to create sub-PageAllocations from an existing PageAllocations object -
  this presented an interface that would allow sub regions to be deallocated, which would
  not have provided expected behaviour.
* remove writable/executable arguments to commit, this value can be cached at the point
  the memory is reserved.
* remove writable/executable arguments to allocateAligned, protection other than RW is not
  supported.
* add missing checks for overflow & failed allocation to mmap path through allocateAligned.

* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::Allocation::Allocation):
(JSC::ExecutablePool::Allocation::base):
(JSC::ExecutablePool::Allocation::size):
(JSC::ExecutablePool::Allocation::operator!):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocInternal):
* runtime/AlignedMemoryAllocator.h:
(JSC::::allocate):
(JSC::::AlignedMemoryAllocator):
* runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
* runtime/Collector.h:
* wtf/PageAllocation.cpp:
* wtf/PageAllocation.h:
(WTF::PageAllocation::operator!):
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::systemAllocate):
(WTF::PageAllocation::systemAllocateAt):
(WTF::PageAllocation::systemAllocateAligned):
(WTF::PageAllocation::systemDeallocate):
(WTF::PageAllocation::systemPageSize):
* wtf/PageReservation.h: Copied from JavaScriptCore/wtf/PageAllocation.h.
(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):
(WTF::PageReservation::systemReserve):
(WTF::PageReservation::systemReserveAt):
* wtf/Platform.h:

JavaScriptGlue: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)

Reviewed by Sam Weinig.

* ForwardingHeaders/wtf/Bitmap.h: Added.
* ForwardingHeaders/wtf/PageReservation.h: Added.

WebCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)

Reviewed by Sam Weinig.

* ForwardingHeaders/wtf/Bitmap.h: Added.
* ForwardingHeaders/wtf/PageReservation.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
Mark Rowe [Wed, 4 Aug 2010 08:16:27 +0000 (08:16 +0000)]
Build fix.

Fix the contents of the forwarding headers too.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
Mark Rowe [Wed, 4 Aug 2010 08:06:06 +0000 (08:06 +0000)]
Build fix.

It's really useful if the forwarding headers match the name of the file that they're forwarding to.
Amazingly enough, if the name doesn't match then the file cannot be found! Who'd have thunk it?!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative windows build fix.
Gavin Barraclough [Wed, 4 Aug 2010 04:37:26 +0000 (04:37 +0000)]
Speculative windows build fix.

* wtf/Bitmap.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix following r64624.
Gavin Barraclough [Wed, 4 Aug 2010 04:25:42 +0000 (04:25 +0000)]
Build fix following r64624.

JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/PageAllocation.h:

JavaScriptGlue:

* ForwardingHeaders/wtf/BitMap.h: Added.

WebCore:

* ForwardingHeaders/wtf/BitMap.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=43269
Gavin Barraclough [Wed, 4 Aug 2010 03:27:13 +0000 (03:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=43269

Patch by Nathan Lawrence <nlawrence@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.

Added new allocateAligned methods to PageAllocation.  In order to
prevent a regress in performance, the function needs to be inlined.

Additionally, I ported the symbian block allocator to use
PageAllocation and added a new WTF::Bitmap class to support this.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/AlignedMemoryAllocator.h: Added.
(JSC::AlignedMemory::deallocate):
(JSC::AlignedMemory::base):
(JSC::AlignedMemory::AlignedMemory):
(JSC::AlignedMemoryAllocator::destroy):
(JSC::AlignedMemoryAllocator::allocate):
(JSC::AlignedMemoryAllocator::AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::~AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::free):
* runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::allocate):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
* runtime/Collector.h:
(JSC::CollectorHeap::collectorBlock):
* runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::operator*):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
* wtf/Bitmap.h: Added.
(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::advanceToNextFreeBit):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):
* wtf/PageAllocation.h:
(WTF::PageAllocation::operator UnspecifiedBoolType):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::reserveAligned):
* wtf/Platform.h:
* wtf/symbian: Removed.
* wtf/symbian/BlockAllocatorSymbian.cpp: Removed.
* wtf/symbian/BlockAllocatorSymbian.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 43390 - Do not CRASH if we run out of room for jit code.
Gavin Barraclough [Wed, 4 Aug 2010 00:15:47 +0000 (00:15 +0000)]
Bug 43390 - Do not CRASH if we run out of room for jit code.

Reviewed by Oliver Hunt.

Change the ExecutableAllocator implementations not to crash, and to return 0 if memory cannot be allocated.
The assemblers should pass this through without trying to use it in executableCopy.
Change the LinkBuffer to handle this, and to provide an allocationSuccessful() method to test for this.

Change the JIT to throw an exception if allocation fails.
Make JIT optimizations fail gracefully if memory cannot be allocated (use non-optimized path).
Change YARR JIT to fallback to PCRE

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::allocationSuccessful):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
* jit/ExecutableAllocator.cpp:
(JSC::ExecutablePool::systemAlloc):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::allocInternal):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compilePatchGetArrayLength):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::setupPolymorphicProtoList):
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* runtime/ExceptionHelpers.cpp:
(JSC::createOutOfMemoryError):
* runtime/ExceptionHelpers.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-02 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
commit-queue [Mon, 2 Aug 2010 12:21:11 +0000 (12:21 +0000)]
2010-08-02  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Simon Hausmann.

        [QT] build fix for symbian
        https://bugs.webkit.org/show_bug.cgi?id=43234

        1) wrong order of passing param's
        2) static_cast complains on symbian so using reinterpret_cast

        No new tests added. Just a build fix for qt symbian

        * wtf/PageAllocation.cpp:
        (WTF::PageAllocation::commit):
        (WTF::PageAllocation::decommit):
        (WTF::PageAllocation::reserve):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-07-30 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
commit-queue [Fri, 30 Jul 2010 11:10:02 +0000 (11:10 +0000)]
2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Simon Hausmann.

        [QT] build fix for symbian
        https://bugs.webkit.org/show_bug.cgi?id=43234

        * wtf/PageAllocation.h:
        (WTF::PageAllocation::PageAllocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 43162 - Add support for MADV_FREE to PageAllocation.
Gavin Barraclough [Thu, 29 Jul 2010 03:22:26 +0000 (03:22 +0000)]
Bug 43162 - Add support for MADV_FREE to PageAllocation.

Reviewed by Darin Adler.

* wtf/PageAllocation.cpp:
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix from Chromium/GTK build fix!
Gavin Barraclough [Tue, 27 Jul 2010 06:04:19 +0000 (06:04 +0000)]
Windows build fix from Chromium/GTK build fix!

* wtf/PageAllocation.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium/GTK build fix
Gavin Barraclough [Tue, 27 Jul 2010 05:51:10 +0000 (05:51 +0000)]
Chromium/GTK build fix

* wtf/PageAllocation.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for !Mac platforms.
Gavin Barraclough [Tue, 27 Jul 2010 05:23:28 +0000 (05:23 +0000)]
Build fix for !Mac platforms.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBug 43009 - Abstract out page allocation from executable allocators
Gavin Barraclough [Tue, 27 Jul 2010 05:02:09 +0000 (05:02 +0000)]
Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

JavaScriptCore:

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

* CMakeListsEfl.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
* jit/ExecutableAllocatorPosix.cpp: Removed.
* jit/ExecutableAllocatorSymbian.cpp: Removed.
* jit/ExecutableAllocatorWin.cpp: Removed.
* wscript:
* wtf/PageAllocator.cpp: Added.
(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):
* wtf/PageAllocator.h: Added.
(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

JavaScriptGlue:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

WebCore:

* ForwardingHeaders/wtf/PageAllocation.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-20 Andreas Kling <andreas.kling@nokia.com>
andreas.kling [Fri, 20 Aug 2010 08:12:08 +0000 (08:12 +0000)]
2010-08-20  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Initialize GDK before loading plugins
        https://bugs.webkit.org/show_bug.cgi?id=44324

        Attempt to call gdk_init_check() before loading any plugins.
        This prevents various crashes and freezes in Adobe's Flash plugin.

        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::initializeGdkIfPossible):
        (WebCore::PluginPackage::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-14 Tasuku Suzuki <tasuku.suzuki@nokia.com>
commit-queue [Sat, 14 Aug 2010 19:24:30 +0000 (19:24 +0000)]
2010-08-14  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Fix compilation with QT_NO_LINEEDIT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Jocelyn Turcotte [Tue, 21 Sep 2010 14:30:51 +0000 (14:30 +0000)]
2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Check if the reply has been deleted before finishing a network request
        https://bugs.webkit.org/show_bug.cgi?id=46174

        A crash can happen with the following sequence:
        1. QNetworkReplyHandler::abort() emits reply->deleteLater()
        2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
        3. event loop would call reply->deleteLater()
        However a crash occurs since m_reply == 0 on step 2.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::finish):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add robot loader timeout and extra time options.
Jocelyn Turcotte [Tue, 21 Sep 2010 11:25:54 +0000 (11:25 +0000)]
[Qt] Add robot loader timeout and extra time options.
https://bugs.webkit.org/show_bug.cgi?id=46172

Reviewed by Andreas Kling.

[-robot-timeout <s>]: Load the next page after s seconds if the current
page didn't finish loading.
[-robot-extra-time <s>]: Wait s seconds after the current page finished
loading before loading the next one. This should allow some time for the
page's JavaScript to execute.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/main.cpp:
(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::LauncherApplication):
(LauncherApplication::handleUserOptions):
(main):
* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::loadUrlList):
* QtTestBrowser/urlloader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>
commit-queue [Mon, 20 Sep 2010 20:20:25 +0000 (20:20 +0000)]
2010-09-20  Jacob Dinu  <dinu.jacob@nokia.com>

        Reviewed by Adam Barth.

        When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
        that all initialzations are done before calling client dispatchDidCommitLoad to avoid
        client from accessing incorrect data.
        https://bugs.webkit.org/show_bug.cgi?id=41155

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::transitionToCommitted):
2010-09-20  Jacob Dinu  <dinu.jacob@nokia.com>

        Reviewed by Adam Barth.

        Added a new qwebpage test for loading a cached page
        https://bugs.webkit.org/show_bug.cgi?id=41155

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::loadCachedPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Andreas Kling [Sat, 18 Sep 2010 15:23:47 +0000 (15:23 +0000)]
2010-09-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Don't copy clip path to TransparencyLayer
        https://bugs.webkit.org/show_bug.cgi?id=45965

        We don't need to copy the GC's clip path to the TransparencyLayer since it will
        clip anyway when ending the layer.

        * platform/graphics/qt/GraphicsContextQt.cpp
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-16 Leonid Ebril <leonid.ebril@nokia.com> qtwebkit-2.1-week37
commit-queue [Thu, 16 Sep 2010 20:31:02 +0000 (20:31 +0000)]
2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
        https://bugs.webkit.org/show_bug.cgi?id=45885

        Avoid creation of an additional window for screenshot to prevent overlapping with original window.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::screenshot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Andreas Kling [Thu, 16 Sep 2010 22:35:30 +0000 (22:35 +0000)]
2010-09-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.
        Backported to 2.1 by Ademar Reis.

        [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
        https://bugs.webkit.org/show_bug.cgi?id=45923

        QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
        instead of QPainter::clipPath().isEmpty().

        * platform/graphics/qt/GraphicsContextQt.cpp
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-10 yi shen <yi.4.shen@nokia.com>
commit-queue [Sat, 11 Sep 2010 07:07:00 +0000 (07:07 +0000)]
2010-09-10  yi shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] selected text gets deleted when qgraphicswebview losts focus
        https://bugs.webkit.org/show_bug.cgi?id=45539

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue [Wed, 15 Sep 2010 03:37:14 +0000 (03:37 +0000)]
2010-09-14  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Zoom factor for checkboxes and radios.
        https://bugs.webkit.org/show_bug.cgi?id=45776

        RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
        checkboxes and radios.

        Even with this change the used QStyle must support different sizes for radios and checkboxes.
        QWindowStyle and QMacStyle, for example, do not.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page...
hausmann@webkit.org [Wed, 15 Sep 2010 13:32:02 +0000 (13:32 +0000)]
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247

Reviewed by Tor Arne Vestbø.

The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/mainwindow.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Update the Symbian def files
hausmann@webkit.org [Wed, 15 Sep 2010 11:34:25 +0000 (11:34 +0000)]
[Qt] Update the Symbian def files

Re-freeze with the viewport meta tag updates.

* symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-13 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Tue, 14 Sep 2010 01:10:21 +0000 (01:10 +0000)]
2010-09-13  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [WINCE] Buildfix for ViewportArguments.cpp
        https://bugs.webkit.org/show_bug.cgi?id=45678

        Use fabs() instead of abs().
        This patch also fixes the return value, when
        the value is between -1 and 1.

        * dom/ViewportArguments.cpp:
        (WebCore::findUserScalableValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore: Update support for the viewport meta tag algorithm, to
Kenneth Rohde Christiansen [Mon, 13 Sep 2010 10:37:28 +0000 (10:37 +0000)]
WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

Tests: fast/viewport/viewport-1.html
       fast/viewport/viewport-10.html
       fast/viewport/viewport-100.html
       fast/viewport/viewport-101.html
       fast/viewport/viewport-102.html
       fast/viewport/viewport-103.html
       fast/viewport/viewport-104.html
       fast/viewport/viewport-105.html
       fast/viewport/viewport-106.html
       fast/viewport/viewport-107.html
       fast/viewport/viewport-108.html
       fast/viewport/viewport-109.html
       fast/viewport/viewport-11.html
       fast/viewport/viewport-110.html
       fast/viewport/viewport-111.html
       fast/viewport/viewport-112.html
       fast/viewport/viewport-113.html
       fast/viewport/viewport-114.html
       fast/viewport/viewport-115.html
       fast/viewport/viewport-116.html
       fast/viewport/viewport-117.html
       fast/viewport/viewport-118.html
       fast/viewport/viewport-119.html
       fast/viewport/viewport-12.html
       fast/viewport/viewport-120.html
       fast/viewport/viewport-121.html
       fast/viewport/viewport-122.html
       fast/viewport/viewport-123.html
       fast/viewport/viewport-124.html
       fast/viewport/viewport-125.html
       fast/viewport/viewport-126.html
       fast/viewport/viewport-127.html
       fast/viewport/viewport-13.html
       fast/viewport/viewport-14.html
       fast/viewport/viewport-15.html
       fast/viewport/viewport-16.html
       fast/viewport/viewport-17.html
       fast/viewport/viewport-18.html
       fast/viewport/viewport-19.html
       fast/viewport/viewport-2.html
       fast/viewport/viewport-20.html
       fast/viewport/viewport-21.html
       fast/viewport/viewport-22.html
       fast/viewport/viewport-23.html
       fast/viewport/viewport-24.html
       fast/viewport/viewport-25.html
       fast/viewport/viewport-26.html
       fast/viewport/viewport-27.html
       fast/viewport/viewport-28.html
       fast/viewport/viewport-29.html
       fast/viewport/viewport-3.html
       fast/viewport/viewport-30.html
       fast/viewport/viewport-31.html
       fast/viewport/viewport-32.html
       fast/viewport/viewport-33.html
       fast/viewport/viewport-34.html
       fast/viewport/viewport-35.html
       fast/viewport/viewport-36.html
       fast/viewport/viewport-37.html
       fast/viewport/viewport-38.html
       fast/viewport/viewport-39.html
       fast/viewport/viewport-4.html
       fast/viewport/viewport-40.html
       fast/viewport/viewport-41.html
       fast/viewport/viewport-42.html
       fast/viewport/viewport-43.html
       fast/viewport/viewport-44.html
       fast/viewport/viewport-45.html
       fast/viewport/viewport-46.html
       fast/viewport/viewport-47.html
       fast/viewport/viewport-48.html
       fast/viewport/viewport-49.html
       fast/viewport/viewport-5.html
       fast/viewport/viewport-50.html
       fast/viewport/viewport-51.html
       fast/viewport/viewport-52.html
       fast/viewport/viewport-53.html
       fast/viewport/viewport-54.html
       fast/viewport/viewport-55.html
       fast/viewport/viewport-56.html
       fast/viewport/viewport-57.html
       fast/viewport/viewport-58.html
       fast/viewport/viewport-59.html
       fast/viewport/viewport-6.html
       fast/viewport/viewport-60.html
       fast/viewport/viewport-61.html
       fast/viewport/viewport-62.html
       fast/viewport/viewport-63.html
       fast/viewport/viewport-64.html
       fast/viewport/viewport-65.html
       fast/viewport/viewport-66.html
       fast/viewport/viewport-67.html
       fast/viewport/viewport-68.html
       fast/viewport/viewport-69.html
       fast/viewport/viewport-7.html
       fast/viewport/viewport-70.html
       fast/viewport/viewport-71.html
       fast/viewport/viewport-72.html
       fast/viewport/viewport-73.html
       fast/viewport/viewport-74.html
       fast/viewport/viewport-75.html
       fast/viewport/viewport-76.html
       fast/viewport/viewport-77.html
       fast/viewport/viewport-78.html
       fast/viewport/viewport-79.html
       fast/viewport/viewport-8.html
       fast/viewport/viewport-80.html
       fast/viewport/viewport-81.html
       fast/viewport/viewport-82.html
       fast/viewport/viewport-83.html
       fast/viewport/viewport-84.html
       fast/viewport/viewport-85.html
       fast/viewport/viewport-86.html
       fast/viewport/viewport-87.html
       fast/viewport/viewport-88.html
       fast/viewport/viewport-9.html
       fast/viewport/viewport-90.html

* dom/ViewportArguments.cpp:
(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):

WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
* Api/qwebpage.cpp:
(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):
* Api/qwebpage.h:
* Api/qwebpage_p.h:
(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::didReceiveViewportArguments):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):

WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::dumpConfigurationForViewport):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

* fast/viewport/viewport-1-expected.txt: Added.
* fast/viewport/viewport-1.html: Added.
* fast/viewport/viewport-10-expected.txt: Added.
* fast/viewport/viewport-10.html: Added.
* fast/viewport/viewport-100-expected.txt: Added.
* fast/viewport/viewport-100.html: Added.
* fast/viewport/viewport-101-expected.txt: Added.
* fast/viewport/viewport-101.html: Added.
* fast/viewport/viewport-102-expected.txt: Added.
* fast/viewport/viewport-102.html: Added.
* fast/viewport/viewport-103-expected.txt: Added.
* fast/viewport/viewport-103.html: Added.
* fast/viewport/viewport-104-expected.txt: Added.
* fast/viewport/viewport-104.html: Added.
* fast/viewport/viewport-105-expected.txt: Added.
* fast/viewport/viewport-105.html: Added.
* fast/viewport/viewport-106-expected.txt: Added.
* fast/viewport/viewport-106.html: Added.
* fast/viewport/viewport-107-expected.txt: Added.
* fast/viewport/viewport-107.html: Added.
* fast/viewport/viewport-108-expected.txt: Added.
* fast/viewport/viewport-108.html: Added.
* fast/viewport/viewport-109-expected.txt: Added.
* fast/viewport/viewport-109.html: Added.
* fast/viewport/viewport-11-expected.txt: Added.
* fast/viewport/viewport-11.html: Added.
* fast/viewport/viewport-110-expected.txt: Added.
* fast/viewport/viewport-110.html: Added.
* fast/viewport/viewport-111-expected.txt: Added.
* fast/viewport/viewport-111.html: Added.
* fast/viewport/viewport-112-expected.txt: Added.
* fast/viewport/viewport-112.html: Added.
* fast/viewport/viewport-113-expected.txt: Added.
* fast/viewport/viewport-113.html: Added.
* fast/viewport/viewport-114-expected.txt: Added.
* fast/viewport/viewport-114.html: Added.
* fast/viewport/viewport-115-expected.txt: Added.
* fast/viewport/viewport-115.html: Added.
* fast/viewport/viewport-116-expected.txt: Added.
* fast/viewport/viewport-116.html: Added.
* fast/viewport/viewport-117-expected.txt: Added.
* fast/viewport/viewport-117.html: Added.
* fast/viewport/viewport-118-expected.txt: Added.
* fast/viewport/viewport-118.html: Added.
* fast/viewport/viewport-119-expected.txt: Added.
* fast/viewport/viewport-119.html: Added.
* fast/viewport/viewport-12-expected.txt: Added.
* fast/viewport/viewport-12.html: Added.
* fast/viewport/viewport-120-expected.txt: Added.
* fast/viewport/viewport-120.html: Added.
* fast/viewport/viewport-121-expected.txt: Added.
* fast/viewport/viewport-121.html: Added.
* fast/viewport/viewport-122-expected.txt: Added.
* fast/viewport/viewport-122.html: Added.
* fast/viewport/viewport-123-expected.txt: Added.
* fast/viewport/viewport-123.html: Added.
* fast/viewport/viewport-124-expected.txt: Added.
* fast/viewport/viewport-124.html: Added.
* fast/viewport/viewport-125-expected.txt: Added.
* fast/viewport/viewport-125.html: Added.
* fast/viewport/viewport-126.html: Added.
* fast/viewport/viewport-127.html: Added.
* fast/viewport/viewport-13-expected.txt: Added.
* fast/viewport/viewport-13.html: Added.
* fast/viewport/viewport-14-expected.txt: Added.
* fast/viewport/viewport-14.html: Added.
* fast/viewport/viewport-15-expected.txt: Added.
* fast/viewport/viewport-15.html: Added.
* fast/viewport/viewport-16-expected.txt: Added.
* fast/viewport/viewport-16.html: Added.
* fast/viewport/viewport-17-expected.txt: Added.
* fast/viewport/viewport-17.html: Added.
* fast/viewport/viewport-18-expected.txt: Added.
* fast/viewport/viewport-18.html: Added.
* fast/viewport/viewport-19-expected.txt: Added.
* fast/viewport/viewport-19.html: Added.
* fast/viewport/viewport-2-expected.txt: Added.
* fast/viewport/viewport-2.html: Added.
* fast/viewport/viewport-20-expected.txt: Added.
* fast/viewport/viewport-20.html: Added.
* fast/viewport/viewport-21-expected.txt: Added.
* fast/viewport/viewport-21.html: Added.
* fast/viewport/viewport-22-expected.txt: Added.
* fast/viewport/viewport-22.html: Added.
* fast/viewport/viewport-23-expected.txt: Added.
* fast/viewport/viewport-23.html: Added.
* fast/viewport/viewport-24-expected.txt: Added.
* fast/viewport/viewport-24.html: Added.
* fast/viewport/viewport-25-expected.txt: Added.
* fast/viewport/viewport-25.html: Added.
* fast/viewport/viewport-26-expected.txt: Added.
* fast/viewport/viewport-26.html: Added.
* fast/viewport/viewport-27-expected.txt: Added.
* fast/viewport/viewport-27.html: Added.
* fast/viewport/viewport-28-expected.txt: Added.
* fast/viewport/viewport-28.html: Added.
* fast/viewport/viewport-29-expected.txt: Added.
* fast/viewport/viewport-29.html: Added.
* fast/viewport/viewport-3-expected.txt: Added.
* fast/viewport/viewport-3.html: Added.
* fast/viewport/viewport-30-expected.txt: Added.
* fast/viewport/viewport-30.html: Added.
* fast/viewport/viewport-31-expected.txt: Added.
* fast/viewport/viewport-31.html: Added.
* fast/viewport/viewport-32-expected.txt: Added.
* fast/viewport/viewport-32.html: Added.
* fast/viewport/viewport-33-expected.txt: Added.
* fast/viewport/viewport-33.html: Added.
* fast/viewport/viewport-34-expected.txt: Added.
* fast/viewport/viewport-34.html: Added.
* fast/viewport/viewport-35-expected.txt: Added.
* fast/viewport/viewport-35.html: Added.
* fast/viewport/viewport-36-expected.txt: Added.
* fast/viewport/viewport-36.html: Added.
* fast/viewport/viewport-37-expected.txt: Added.
* fast/viewport/viewport-37.html: Added.
* fast/viewport/viewport-38-expected.txt: Added.
* fast/viewport/viewport-38.html: Added.
* fast/viewport/viewport-39-expected.txt: Added.
* fast/viewport/viewport-39.html: Added.
* fast/viewport/viewport-4-expected.txt: Added.
* fast/viewport/viewport-4.html: Added.
* fast/viewport/viewport-40-expected.txt: Added.
* fast/viewport/viewport-40.html: Added.
* fast/viewport/viewport-41-expected.txt: Added.
* fast/viewport/viewport-41.html: Added.
* fast/viewport/viewport-42-expected.txt: Added.
* fast/viewport/viewport-42.html: Added.
* fast/viewport/viewport-43-expected.txt: Added.
* fast/viewport/viewport-43.html: Added.
* fast/viewport/viewport-44-expected.txt: Added.
* fast/viewport/viewport-44.html: Added.
* fast/viewport/viewport-45-expected.txt: Added.
* fast/viewport/viewport-45.html: Added.
* fast/viewport/viewport-46-expected.txt: Added.
* fast/viewport/viewport-46.html: Added.
* fast/viewport/viewport-47-expected.txt: Added.
* fast/viewport/viewport-47.html: Added.
* fast/viewport/viewport-48-expected.txt: Added.
* fast/viewport/viewport-48.html: Added.
* fast/viewport/viewport-49-expected.txt: Added.
* fast/viewport/viewport-49.html: Added.
* fast/viewport/viewport-5-expected.txt: Added.
* fast/viewport/viewport-5.html: Added.
* fast/viewport/viewport-50-expected.txt: Added.
* fast/viewport/viewport-50.html: Added.
* fast/viewport/viewport-51-expected.txt: Added.
* fast/viewport/viewport-51.html: Added.
* fast/viewport/viewport-52-expected.txt: Added.
* fast/viewport/viewport-52.html: Added.
* fast/viewport/viewport-53-expected.txt: Added.
* fast/viewport/viewport-53.html: Added.
* fast/viewport/viewport-54-expected.txt: Added.
* fast/viewport/viewport-54.html: Added.
* fast/viewport/viewport-55-expected.txt: Added.
* fast/viewport/viewport-55.html: Added.
* fast/viewport/viewport-56-expected.txt: Added.
* fast/viewport/viewport-56.html: Added.
* fast/viewport/viewport-57-expected.txt: Added.
* fast/viewport/viewport-57.html: Added.
* fast/viewport/viewport-58-expected.txt: Added.
* fast/viewport/viewport-58.html: Added.
* fast/viewport/viewport-59-expected.txt: Added.
* fast/viewport/viewport-59.html: Added.
* fast/viewport/viewport-6-expected.txt: Added.
* fast/viewport/viewport-6.html: Added.
* fast/viewport/viewport-60-expected.txt: Added.
* fast/viewport/viewport-60.html: Added.
* fast/viewport/viewport-61-expected.txt: Added.
* fast/viewport/viewport-61.html: Added.
* fast/viewport/viewport-62-expected.txt: Added.
* fast/viewport/viewport-62.html: Added.
* fast/viewport/viewport-63-expected.txt: Added.
* fast/viewport/viewport-63.html: Added.
* fast/viewport/viewport-64-expected.txt: Added.
* fast/viewport/viewport-64.html: Added.
* fast/viewport/viewport-65.html: Added.
* fast/viewport/viewport-66-expected.txt: Added.
* fast/viewport/viewport-66.html: Added.
* fast/viewport/viewport-67-expected.txt: Added.
* fast/viewport/viewport-67.html: Added.
* fast/viewport/viewport-68-expected.txt: Added.
* fast/viewport/viewport-68.html: Added.
* fast/viewport/viewport-69-expected.txt: Added.
* fast/viewport/viewport-69.html: Added.
* fast/viewport/viewport-7-expected.txt: Added.
* fast/viewport/viewport-7.html: Added.
* fast/viewport/viewport-70-expected.txt: Added.
* fast/viewport/viewport-70.html: Added.
* fast/viewport/viewport-71-expected.txt: Added.
* fast/viewport/viewport-71.html: Added.
* fast/viewport/viewport-72-expected.txt: Added.
* fast/viewport/viewport-72.html: Added.
* fast/viewport/viewport-73-expected.txt: Added.
* fast/viewport/viewport-73.html: Added.
* fast/viewport/viewport-74-expected.txt: Added.
* fast/viewport/viewport-74.html: Added.
* fast/viewport/viewport-75-expected.txt: Added.
* fast/viewport/viewport-75.html: Added.
* fast/viewport/viewport-76-expected.txt: Added.
* fast/viewport/viewport-76.html: Added.
* fast/viewport/viewport-77-expected.txt: Added.
* fast/viewport/viewport-77.html: Added.
* fast/viewport/viewport-78-expected.txt: Added.
* fast/viewport/viewport-78.html: Added.
* fast/viewport/viewport-79-expected.txt: Added.
* fast/viewport/viewport-79.html: Added.
* fast/viewport/viewport-8-expected.txt: Added.
* fast/viewport/viewport-8.html: Added.
* fast/viewport/viewport-80-expected.txt: Added.
* fast/viewport/viewport-80.html: Added.
* fast/viewport/viewport-81-expected.txt: Added.
* fast/viewport/viewport-81.html: Added.
* fast/viewport/viewport-82.html: Added.
* fast/viewport/viewport-83-expected.txt: Added.
* fast/viewport/viewport-83.html: Added.
* fast/viewport/viewport-84.html: Added.
* fast/viewport/viewport-85-expected.txt: Added.
* fast/viewport/viewport-85.html: Added.
* fast/viewport/viewport-86-expected.txt: Added.
* fast/viewport/viewport-86.html: Added.
* fast/viewport/viewport-87.html: Added.
* fast/viewport/viewport-88-expected.txt: Added.
* fast/viewport/viewport-88.html: Added.
* fast/viewport/viewport-9-expected.txt: Added.
* fast/viewport/viewport-9.html: Added.
* fast/viewport/viewport-90-expected.txt: Added.
* fast/viewport/viewport-90.html: Added.
* platform/gtk/Skipped: Skip tests due to missing DRT support.
* platform/mac/Skipped: Skip tests due to missing DRT support.
* platform/win/Skipped: Skip tests due to missing DRT support.
* platform/qt/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue [Thu, 5 Aug 2010 17:50:27 +0000 (17:50 +0000)]
2010-08-05  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Make the viewport meta tag parser support the Android
        target-densitydpi extension.
        http://webkit.org/b/43492

        http://developer.android.com/reference/android/webkit/WebView.html
        Section 'Building web pages to support different screen densities'

        * dom/ViewportArguments.cpp:
        (WebCore::setViewportFeature):
        (WebCore::viewportErrorMessageTemplate):
        * dom/ViewportArguments.h:
        (WebCore::):
        (WebCore::ViewportArguments::ViewportArguments):
        (WebCore::ViewportArguments::hasCustomArgument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit...
Ademar de Souza Reis Jr [Mon, 13 Sep 2010 14:26:18 +0000 (11:26 -0300)]
Merge branch 'qtwebkit-2.1' of gitorious.org:+qtwebkit-developers/webkit/qtwebkit into qtwebkit-2.1

7 years ago2010-09-08 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Wed, 8 Sep 2010 12:38:02 +0000 (12:38 +0000)]
2010-09-08  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Missing EOL in expected test results
        https://bugs.webkit.org/show_bug.cgi?id=45352

        Add the missing EOL.

        * fast/notifications/notifications-click-event-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-08-27 John Gregg <johnnyg@google.com>
johnnyg [Tue, 31 Aug 2010 08:58:28 +0000 (08:58 +0000)]
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * public/WebNotification.h:
        * src/WebNotification.cpp:
        (WebKit::WebNotification::dispatchClickEvent):
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        Test: fast/notifications/notifications-click-event.html

        * notifications/Notification.h:
        * notifications/Notification.idl:
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * fast/notifications/notifications-click-event-expected.txt: Added.
        * fast/notifications/notifications-click-event.html: Added.
        * platform/qt/Skipped:
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event.
        Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
        can be simulated during a layout test.  Requires storing a list of active
        notifications so that they can be referred to later for clicking.
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::simulateDesktopNotificationClick):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/NotificationPresenter.cpp:
        (NotificationPresenter::simulateClick):
        (NotificationPresenter::show):
        (NotificationPresenter::cancel):
        (NotificationPresenter::objectDestroyed):
        * DumpRenderTree/chromium/NotificationPresenter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2010-09-10 Yael Aharon <yael.aharon@nokia.com>
Yael Aharon [Sat, 11 Sep 2010 03:42:09 +0000 (03:42 +0000)]
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        * fast/notifications/notifications-click-event-expected.txt:
        * platform/qt/Skipped:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Propagate click events to JavaScript from either the
        platform plugn or from QSystemTrayIcon.
        Also added the method NotificationWrapper::openerPageUrl so that
        if the platform plugin can reopen the page that created the
        notification directly, when the user clicks the notification.

        Added DumpRenderTreeSupportQt::simulateDesktopNotificationClick
        for testing purpose.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationWrapper::openerPageUrl):
        (WebCore::NotificationWrapper::notificationClicked):
        (WebCore::NotificationPresenterClientQt::displayNotification):
        (WebCore::NotificationPresenterClientQt::notificationClicked):
        * WebCoreSupport/NotificationPresenterClientQt.h:
        * examples/platformplugin/WebNotificationPresenter.cpp:
        (WebNotificationWidget::event):
        * examples/platformplugin/WebNotificationPresenter.h:
        (WebNotificationPresenter::WebNotificationPresenter):
        * examples/platformplugin/qwebkitplatformplugin.h:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Add support for simulateDesktopNotificationClick by calling
        back to DumpRenderTreeSupportQt.cpp.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::simulateDesktopNotificationClick):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodoc: Changed the title so lists of contents sort better.
hausmann@webkit.org [Sun, 12 Sep 2010 21:19:15 +0000 (21:19 +0000)]
doc: Changed the title so lists of contents sort better.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* docs/qtwebkit.qdoc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDoc: More work on the QML documentation.
hausmann@webkit.org [Sun, 12 Sep 2010 21:08:55 +0000 (21:08 +0000)]
Doc: More work on the QML documentation.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qml] Ensure WebView gets focus when an editable node is clicked on.
hausmann@webkit.org [Sun, 12 Sep 2010 20:58:30 +0000 (20:58 +0000)]
[Qml] Ensure WebView gets focus when an editable node is clicked on.

Patch by Martin Jones <martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-13342

* declarative/qdeclarativewebview.cpp:
(GraphicsWebView::mousePressEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDoc: qdoc fixes.
hausmann@webkit.org [Sun, 12 Sep 2010 20:56:59 +0000 (20:56 +0000)]
Doc: qdoc fixes.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fix qt_webkit_version.pri install for in-Qt builds
hausmann@webkit.org [Sun, 12 Sep 2010 20:53:56 +0000 (20:53 +0000)]
[Qt] fix qt_webkit_version.pri install for in-Qt builds

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.

Task-number: QTBUG-13306

* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore: [Qt] Let QtWebKit inject itself into the qt configuration
hausmann@webkit.org [Sun, 12 Sep 2010 20:50:22 +0000 (20:50 +0000)]
WebCore: [Qt] Let QtWebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.

Task-number: QTBUG-12379

* WebCore.pro:

WebKit/qt: [Qt] let WebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-12379

* qt_webkit_version.pri: Use the faster + instead of *
operator to add webkit to the config.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix group of declarative web view in QML docs.
hausmann@webkit.org [Sun, 12 Sep 2010 20:44:02 +0000 (20:44 +0000)]
[Qt] Fix group of declarative web view in QML docs.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAbsented missing functions
Simon Hausmann [Sun, 12 Sep 2010 12:35:52 +0000 (14:35 +0200)]
Absented missing functions

7 years ago2010-09-07 Kent Hansen <kent.hansen@nokia.com> qtwebkit-2.1-week36
kent.hansen [Tue, 7 Sep 2010 11:14:33 +0000 (11:14 +0000)]
2010-09-07  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set
        https://bugs.webkit.org/show_bug.cgi?id=44697

        When the signal handler is a JS function, __qt_sender__ is stuffed into a temporary
        object that's pushed onto the function's scope before the function is invoked, and
        popped again afterwards.

        We were pushing this new scope object _after_ calling JSFunction::getCallData(),
        and relying on JSC::call() to use the fresh scope chain from the function object.
        However, this is no longer the case; JSC::call() uses the scope chain passed in
        the CallData argument. Hence, we need to set up the scope before the function's
        CallData is queried.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66875 268f45cc-cd09-0410-ab3c-d52691b4dbfc