4 years agovaapidecode: Fix the output video format negotiation. 1.3
Sreerenj Balachandran [Fri, 18 Oct 2013 08:40:58 +0000 (11:40 +0300)]
vaapidecode: Fix the output video format negotiation.

Delay the output_state set up till we get the exact output
video format, which means it will get delayed until the decoder
finishes the decoding of first buffer.

4 years agoAdd provision to build against GST-VERSION >= 1.3.0 API
Sreerenj Balachandran [Fri, 18 Oct 2013 08:40:39 +0000 (11:40 +0300)]
Add provision to build against GST-VERSION >= 1.3.0 API


4 years agovaapisink: expose the raw video formats in static caps template.
Sreerenj Balachandran [Fri, 18 Oct 2013 08:40:20 +0000 (11:40 +0300)]
vaapisink: expose the raw video formats in static caps template.

Expose all raw video formats in the static caps template since the
vaapisink is supporting raw data. We will get the exact set of formats
supported by the driver dynamically through the _get_caps() routine.

4 years agoMerge branch 'master' into gwe_master master
Sreerenj Balachandran [Thu, 17 Oct 2013 13:14:35 +0000 (16:14 +0300)]
Merge branch 'master' into gwe_master

4 years agovaapipostproc: add support for raw YUV video source buffers.
Gwenole Beauchesne [Fri, 4 Oct 2013 13:37:24 +0000 (15:37 +0200)]
vaapipostproc: add support for raw YUV video source buffers.

Allow video processing from raw YUV buffers coming from the sink pad,
while still producing a VA surface for the downstream elements.

4 years agovaapipostproc: add support for "mixed" interlace mode.
Gwenole Beauchesne [Fri, 4 Oct 2013 14:00:56 +0000 (16:00 +0200)]
vaapipostproc: add support for "mixed" interlace mode.

Add support for "mixed" interlace-mode, whereby the video frame buffer
shall be deinterlaced only if its flags mention that's actually an
interlaced frame buffer.

4 years agovaapipostproc: rework plug-in element.
Gwenole Beauchesne [Thu, 3 Oct 2013 17:04:07 +0000 (19:04 +0200)]
vaapipostproc: rework plug-in element.

Rewrite the vaapipostproc plug-in element so that it derives from
GstBaseTransform, thus simplifying the caps negotiation process.

4 years agoplugins: fix and optimize check for buffer pool allocator params.
Gwenole Beauchesne [Wed, 9 Oct 2013 15:25:10 +0000 (17:25 +0200)]
plugins: fix and optimize check for buffer pool allocator params.

Reset the buffer pool allocator only if the config caps changed in a
sensible way: format or resolution change. i.e. don't bother with
other caps like colorimetry et al. as this doesn't affect the way to
allocate VA surfaces or images.

4 years agoplugins: enable memory maps for read & write with direct-rendering.
Gwenole Beauchesne [Wed, 9 Oct 2013 08:33:55 +0000 (10:33 +0200)]
plugins: enable memory maps for read & write with direct-rendering.

Enable read and write mappings only if direct-rendering is supported.
Otherwise, this means that we may need to download data from the VA
surface first for correctness, even if the VA surface doesn't need to
be read at all. i.e. sometimes, READWRITE mappings are meant for
surfaces that are written to first, and read afterwards for further

4 years agoplugins: fix check for direct-rendering support.
Gwenole Beauchesne [Wed, 9 Oct 2013 08:06:40 +0000 (10:06 +0200)]
plugins: fix check for direct-rendering support.

Fix check for direct-rendering if the creation of VA surfaces with
an explicit pixel format is not support, e.g. VA-API < 0.34.0, and
that we tried to allocate a VA surface based on the corresponding
chroma type. i.e. in that particular case, we have to make sure that
the derived image has actually the expected format.

4 years agoplugins: fix buffer pool reset_buffer() to reset memory resources.
Gwenole Beauchesne [Wed, 9 Oct 2013 07:47:18 +0000 (09:47 +0200)]
plugins: fix buffer pool reset_buffer() to reset memory resources.

Fix GstVaapiVideoBufferPool::reset_buffer() to reset the underlying
memory resources, and more particularly the VA surface proxy. Most
importantly, the GstVaapiVideoMeta is retained. Cached surface in
memory are released, thus triggering a new allocation the next time
we need to map the buffer.

4 years agoplugins: fix GstVaapiVideoMemory to allocate VA surface proxies.
Gwenole Beauchesne [Wed, 9 Oct 2013 07:33:56 +0000 (09:33 +0200)]
plugins: fix GstVaapiVideoMemory to allocate VA surface proxies.

Make sure GstVaapiVideoMemory allocates VA surface proxies from a
pool stored in the parent VA memory allocator.

This fixes the following scenario:
- VA video buffer 1 is allocated from a buffer pool
- Another video buffer is created, and inherits info from buffer 1
- Buffer 1 is released, thus pushing it back to the buffer pool
- New buffer alloc request comes it, this yields buffer 1 back
- At this stage, buffers 1 and 2 still share the same underlying VA
  surface, but buffer 2 was already submitted downstream for further
  processing, thus conflicting with additional processing we were
  about to perform on buffer 1.

Maybe the core GstBufferPool implementation should have been fixed
instead to actually make sure that the returned GstBuffer memory we
found from the pool is writable?

4 years agoplugins: create a proxy for GstVaapiUploader allocated buffers.
Gwenole Beauchesne [Fri, 4 Oct 2013 17:34:32 +0000 (19:34 +0200)]
plugins: create a proxy for GstVaapiUploader allocated buffers.

Always make sure to allocate a VA surface proxy for GstVaapiUploader
allocated buffers, i.e. make gst_vaapi_uploader_get_buffer() allocate
a proxy surface.

This fixes cases where we want to retain the underlying surface longer,
instead of releasing it back to the surface pool right away.

4 years agoplugins: add helper function to disable deinterlacing in caps.
Gwenole Beauchesne [Fri, 4 Oct 2013 17:30:36 +0000 (19:30 +0200)]
plugins: add helper function to disable deinterlacing in caps.

Add gst_caps_set_interlaced() helper function that would reset the
interlace-mode field to "progressive" for GStreamer >= 1.0, or the
interlaced field to "false" for GStreamer 0.10.

4 years agofilter: fix memory leak of VPP operations.
Gwenole Beauchesne [Tue, 1 Oct 2013 16:26:39 +0000 (18:26 +0200)]
filter: fix memory leak of VPP operations.

Fix ensure_operations() to release the VPP operations array if non
NULL, prior to returning to the caller. The former function was also
renamed to a more meaningful get_operations() since the caller owns
the returned array that needs to be released.

4 years agofilter: fix first-time operation lookup.
Zhao Halley [Wed, 4 Sep 2013 05:53:25 +0000 (13:53 +0800)]
filter: fix first-time operation lookup.

Fix first-time operation lookup through find_operation() if the set
of supported operations was not initially determined through the
gst_vaapi_filter_get_operations() helper function.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: fix colorbalance related subtypes.
Zhao Halley [Wed, 4 Sep 2013 05:53:25 +0000 (13:53 +0800)]
filter: fix colorbalance related subtypes.

Fix intiialization of GstVaapiFilterOpData for colorbalance related
operations. In particular, fill in the va_subtype field accordingly.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: fix VA-API 0.34.0 symbol guards.
Víctor Manuel Jáquez Leal [Mon, 30 Sep 2013 15:08:12 +0000 (17:08 +0200)]
filter: fix VA-API 0.34.0 symbol guards.

VASurfaceAttrib and VAProcFilterParameterBufferType are symbols
that need to be guarded for libva 0.34 and 0.33, respectively.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: hanle the context query in any pad.
Víctor Manuel Jáquez Leal [Tue, 1 Oct 2013 15:57:11 +0000 (17:57 +0200)]
plugins: hanle the context query in any pad.

Also this patch simplifies the code, since now the query is common for the
decoder and the sink.

4 years agoplugins: query upstream element for a GstContext.
Víctor Manuel Jáquez Leal [Tue, 1 Oct 2013 10:09:44 +0000 (12:09 +0200)]
plugins: query upstream element for a GstContext.

Fix gst_vaapi_video_context_prepare() to also query upstream elements
for a valid GstContext. Improve comments regarding the steps used to
lookup or build that context, thus conforming to the GstContext API

Signed-off-by: Gwenole Beauchesne <>
4 years agoFix detection and packaging of GStreamer 1.2.x builds.
Gwenole Beauchesne [Thu, 26 Sep 2013 13:21:24 +0000 (15:21 +0200)]
Fix detection and packaging of GStreamer 1.2.x builds.

The GStreamer 1.2.x packages sticked to the naming convention for 1.0.x
packages, i.e. -1.0 suffix. However, for gstreamer-vaapi packaging
purposes, update the versioning to -1.2 suffix instead.

4 years agoplugins: add support for GstVideoGLTextureUploadMeta.
Víctor Manuel Jáquez Leal [Mon, 15 Jul 2013 11:41:00 +0000 (13:41 +0200)]
plugins: add support for GstVideoGLTextureUploadMeta.

requested, and more specifically under a GLX configuration, then add
the GstVideoGLTextureUploadMeta to the output buffer.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: add support for GstCaps features.
Sreerenj Balachandran [Thu, 4 Jul 2013 08:03:52 +0000 (11:03 +0300)]
plugins: add support for GstCaps features.

Move VA video buffer memory from "video/x-surface,type=vaapi" format,
as expressed in caps, to the more standard use of caps features. i.e.
add "memory:VASurface" feature attribute to the associated caps.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: improve ::query() debugging messages.
Víctor Manuel Jáquez Leal [Fri, 12 Jul 2013 16:58:57 +0000 (12:58 -0400)]
plugins: improve ::query() debugging messages.

Fix gst_vaapidecode_query() to correctly display the query type name,
instead of randomly displaying that we shared the underlying display.
Also add debug info for the GstVaapiSink::query() handler, i.e. the
supplied query type name actually.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: add support for GstContext API.
Víctor Manuel Jáquez Leal [Fri, 12 Jul 2013 16:58:57 +0000 (12:58 -0400)]
plugins: add support for GstContext API.

Add support for the new GstContext API from GStreamer 1.2.x.
- implement the GstElement::set_context() hook ;
- reply to the `context' query from downstream elements.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: add compat layer for GstVideoContext.
Víctor Manuel Jáquez Leal [Wed, 22 May 2013 16:07:52 +0000 (12:07 -0400)]
plugins: add compat layer for GstVideoContext.

Add thin compatibility layer for the deprecated GstVideoContext API.
For GStreamer API >= 1.2, this involves the following two functions:
- gst_vaapi_video_context_prepare(): queries if a context is already
  set in the pipeline ;
- gst_vaapi_video_context_propagate(): propagates the newly-created
  context to the rest of the pipeline.

Signed-off-by: Gwenole Beauchesne <>
4 years agoplugins: initial port to GStreamer 1.2.
Víctor Manuel Jáquez Leal [Tue, 21 May 2013 16:42:39 +0000 (12:42 -0400)]
plugins: initial port to GStreamer 1.2.

Port vaapidecode and vaapisink plugins to GStreamer API >= 1.2. This
is rather minimalistic so that to test the basic functionality.

Disable vaapipostproc plugin for now as further polishing is needed.
Also disable GstVideoContext interface support since this API is now
gone in 1.2.x. This is preparatory work for GstContext support.

Signed-off-by: Gwenole Beauchesne <>
4 years agotests: simple-decoder: fix for non-X11 backends.
Gwenole Beauchesne [Tue, 24 Sep 2013 14:21:11 +0000 (16:21 +0200)]
tests: simple-decoder: fix for non-X11 backends.

Don't try to create pixmaps if we have not requested that feature. This
fixes execution for non-X11 backends, and most specifically DRM video
output mode.

4 years agocodecparsers: update to gst-vaapi-branch commit b33bd32.
Gwenole Beauchesne [Tue, 24 Sep 2013 14:22:59 +0000 (16:22 +0200)]
codecparsers: update to gst-vaapi-branch commit b33bd32.

b33bd32 jpeg: fix and optimize scan for next marker code

4 years agojpeg: fix calculation of MCU count.
Gwenole Beauchesne [Mon, 23 Sep 2013 17:14:56 +0000 (19:14 +0200)]
jpeg: fix calculation of MCU count.

Fix calculation of MCU count for image sizes that are not a multiple
of 8 pixels in either dimension, but also for non-common sampling
factors like 4:2:2 in non-interleaved mode.

4 years agojpeg: add support for multiscan images.
Gwenole Beauchesne [Mon, 23 Sep 2013 14:49:41 +0000 (16:49 +0200)]
jpeg: add support for multiscan images.

Add support for images with multiple scans per frame. The Huffman table
can be updated before SOS, and thus possibly requiring multiple uploads
of Huffman tables to the VA driver. So, the latter must be able to cope
with multiple VA buffers of type 'huffman-table' and with the correct
sequential order.

4 years agojpeg: improve robustness when packets are missing.
Gwenole Beauchesne [Mon, 23 Sep 2013 09:41:52 +0000 (11:41 +0200)]
jpeg: improve robustness when packets are missing.

Improve robustness when some expected packets where not received yet
or that were not correctly decoded. For example, don't try to decode
a picture if there was no valid frame headers.

4 years agojpeg: minor clean-ups.
Gwenole Beauchesne [Fri, 20 Sep 2013 14:46:43 +0000 (16:46 +0200)]
jpeg: minor clean-ups.

Improve debugging and error messages. Rename a few variables to fit the
existing naming conventions. Change some fatal asserts to non-fatal
error codes.

4 years agojpeg: rework and optimize parser.
Gwenole Beauchesne [Fri, 20 Sep 2013 08:12:08 +0000 (10:12 +0200)]
jpeg: rework and optimize parser.

Split the input buffer data into decoder units that represent a JPEG
segment. Handle scan decoder unit specifically so that it can include
both the scan header (SOS) but also any other ECS or RSTi segment.

That way, we parse the input buffer stream only once at the gst-vaapi
level instead of (i) in gst_vaapi_decoder_jpeg_parse() to split the
stream into frames SOI .. EOI and (ii) in decode_buffer() to further
determine segment boundaries and decode them.

In practice, this is a +15 to +25% performance improvement.

4 years agojpeg: handle comment segments.
Junfeng Xu [Tue, 17 Sep 2013 06:29:54 +0000 (14:29 +0800)]
jpeg: handle comment segments.

Fix decode_buffer() function to gracefully skip comment (COM) segments.
This fixes decoding of streams generated by certain cameras, e.g. like
the Logitech Pro C920.

Signed-off-by: Junfeng Xu <>
4 years agojpeg: fix determination of image bounds.
Gwenole Beauchesne [Wed, 18 Sep 2013 15:59:44 +0000 (17:59 +0200)]
jpeg: fix determination of image bounds.

Look for the exact image bounds characterised by the <SOI> and <EOI>
markers. Use the gst_jpeg_parse() codec parser utility function to
optimize the lookup for the next marker segment.

4 years agojpeg: fix calculation of offset to next marker segment.
Junfeng Xu [Tue, 10 Sep 2013 07:46:09 +0000 (15:46 +0800)]
jpeg: fix calculation of offset to next marker segment.

Fix calculation of the offset to the next marker segment since the
correction of the codecparser part to match the API specification.
i.e. the GstJpegMarkerSegment.size field represents the size in bytes
of the segment minus any marker prefix.

Signed-off-by: Junfeng Xu <>
4 years agocodecparsers: update to gst-vaapi-branch commit 23c7dde.
Gwenole Beauchesne [Fri, 20 Sep 2013 16:30:18 +0000 (18:30 +0200)]
codecparsers: update to gst-vaapi-branch commit 23c7dde.

23c7dde jpeg: fix calculation of segment size

4 years agoBump version for development.
Gwenole Beauchesne [Sat, 31 Aug 2013 14:00:05 +0000 (16:00 +0200)]
Bump version for development.

4 years ago0.5.6.
Gwenole Beauchesne [Sat, 31 Aug 2013 13:47:33 +0000 (15:47 +0200)]

4 years agoNEWS: updates.
Gwenole Beauchesne [Sat, 31 Aug 2013 13:46:25 +0000 (15:46 +0200)]
NEWS: updates.

4 years agoconfigure: fix detection of VA/JPEG decoding API.
Wind Yuan [Thu, 15 Aug 2013 09:59:37 +0000 (17:59 +0800)]
configure: fix detection of VA/JPEG decoding API.

Fix detection of VA/JPEG decoding API with non-standard libva packages.
More precisely, some packages were shipping with a <va/va.h> header that
did not include <va/va_dec_jpeg.h>.

Signed-off-by: Gwenole Beauchesne <>
4 years agovaapisink: ensure the uploader is setup for upstream allocated buffers.
Zhao Halley [Thu, 18 Apr 2013 11:49:42 +0000 (19:49 +0800)]
vaapisink: ensure the uploader is setup for upstream allocated buffers.

In GStreamer 0.10 builds, make sure that the GstVaapiUploader helper
is setup in case upstream elements allocate buffers themselves without
honouring our GstVaapiSink::bufer_alloc() hook.

In particular, this fixes support for OGG video streams with WebKit.

Signed-off-by: Gwenole Beauchesne <>
4 years agovaapisink: simplify get_render_buffer() for GStreamer 0.10 builds.
Gwenole Beauchesne [Thu, 29 Aug 2013 17:07:34 +0000 (19:07 +0200)]
vaapisink: simplify get_render_buffer() for GStreamer 0.10 builds.

Implement and use gst_vaapisink_get_render_buffer() for GStreamer 0.10
builds as well.

4 years agovaapisink: handle raw buffers not created from VA video buffer pool.
Gwenole Beauchesne [Thu, 29 Aug 2013 16:34:57 +0000 (18:34 +0200)]
vaapisink: handle raw buffers not created from VA video buffer pool.

Handle raw video buffers that were not created from a VA video buffer
pool. Use the generic GstVideo API to copy buffers in GStreamer 1.0.x
builds instead of the GstVaapiUploader.

4 years agovaapidecode: remove extraneous size information from allowed caps.
Gwenole Beauchesne [Thu, 29 Aug 2013 17:33:02 +0000 (19:33 +0200)]
vaapidecode: remove extraneous size information from allowed caps.

Fix _getcaps() implementation to not report codecs with size information
filled in the returned caps. That's totally useless nowadays. Ideally,
this is a hint to insert a video parser element, thus allowing future
optimizations, but this is not a strict requirement for gstreamer-vaapi,
which is able to parse the elementary bitstreams itself.

4 years agovaapidecode: submit the last frame from output adapter to decoder.
Guangxin.Xu [Tue, 30 Jul 2013 06:05:39 +0000 (14:05 +0800)]
vaapidecode: submit the last frame from output adapter to decoder.

If there is no frame delimiter at the end of the stream, e.g. no
end-of-stream or end-of-sequence marker, and that the current frame
was fully parsed correctly, then assume that last frame is complete
and submit it to the decoder.

Signed-off-by: Guangxin.Xu <>
Signed-off-by: Gwenole Beauchesne <>
4 years agovaapidecode: push all decoded frames from within the task.
Gwenole Beauchesne [Thu, 29 Aug 2013 09:55:05 +0000 (11:55 +0200)]
vaapidecode: push all decoded frames from within the task.

Make sure to push all decoded frames from the task so that the unlying
VA surfaces could all be rendered from the same thread.

4 years agowayland: render the raw surface if VPP failed.
Gwenole Beauchesne [Tue, 27 Aug 2013 16:24:12 +0000 (18:24 +0200)]
wayland: render the raw surface if VPP failed.

As a last resort, if video processing capabilities (VPP) are not available,
or they did not produce anything conclusive enough, then try to fallback to
the original rendering code path whereby the whole VA surface is rendered
as is, no matter of video cropping or deinterlacing requests.

Note: under those conditions, the visual outcome won't be correct but at
least, something gets displayed instead of bailing out.

4 years agowayland: add supporting for video processing.
Gwenole Beauchesne [Tue, 27 Aug 2013 16:20:08 +0000 (18:20 +0200)]
wayland: add supporting for video processing.

Try to use VA/VPP processing capabilities to handle video cropping and
additional rendering flags that may not be directly supported by the
underlying hardware when exposing a suitable Wayland buffer for the
supplied VA surface. e.g. deinterlacing, different color primaries than
BT.601, etc.

4 years agowayland: add new frame redraw infrastructure.
Gwenole Beauchesne [Tue, 27 Aug 2013 14:26:22 +0000 (16:26 +0200)]
wayland: add new frame redraw infrastructure.

Update the frame redraw infrastructure with a new FrameState stucture
holds all the necessary information used to display the next pending

While we are at it, delay the sync operation down to when it is actually
needed. That way, we keep performing additional tasks meanwhile.

4 years agofilter: allow specification of render target regions.
Gwenole Beauchesne [Tue, 27 Aug 2013 16:06:10 +0000 (18:06 +0200)]
filter: allow specification of render target regions.

Add support for rendering the source surface to a particular region within
the supplied target surface. The default background color is black.

4 years agodecode: fix creation of GLX video buffers for GStreamer 0.10.
Gwenole Beauchesne [Mon, 26 Aug 2013 15:14:33 +0000 (17:14 +0200)]
decode: fix creation of GLX video buffers for GStreamer 0.10.

Fix creation of GstVaapiVideoBuffer objects (i) to have that type for real;
and (ii) to correctly extract the GstSurfaceConverter from the video buffer
object meta.

This fixes support for cluttersink with GStreamer 0.10 builds.

4 years agompeg2: disable video cropping as picture_display_extension() is missing.
Gwenole Beauchesne [Mon, 26 Aug 2013 14:15:49 +0000 (16:15 +0200)]
mpeg2: disable video cropping as picture_display_extension() is missing.

Disable video cropping in MPEG-2 codec because it is partially implemented
and actually because nobody implements it that way, and the standard spec
does not specify the display process either anyway.

Most notably, there are two possible use cases for sequence_display_extension()
horizontal_display_size & vertical_display_size: (i) guesstimating the
pixel-aspect-ratio, or (ii) implement some kind of span & scan process
in conjunction with picture_display_extension() information.

4 years agovaapisink: allow scaling to ignore aspect ratio.
Simon Farnsworth [Fri, 16 Aug 2013 15:58:58 +0000 (16:58 +0100)]
vaapisink: allow scaling to ignore aspect ratio.

Other GStreamer sinks, like xvimagesink, have a force-aspect-ratio property,
which allows you to say that you don't want the sink to respect aspect
ratio. Add the same property to vaapisink.

Signed-off-by: Simon Farnsworth <simon.farnsworth at>
4 years agovaapisink: fix memory leak of GstVaapiUploader instance.
Wind Yuan [Tue, 14 May 2013 07:19:04 +0000 (15:19 +0800)]
vaapisink: fix memory leak of GstVaapiUploader instance.

Make sure gst_vaapisink_ensure_uploader() checks for the existence
of a former GstVaapiUploader instance prior to forcibly creating a
new one.

4 years agovaapisink: fix get_caps() implementation for GStreamer 1.0.
Guangxin.Xu [Wed, 31 Jul 2013 08:49:20 +0000 (16:49 +0800)]
vaapisink: fix get_caps() implementation for GStreamer 1.0.

Fix GstBaseSink::get_caps() implementation for GStreamer 1.0.X builds
by honouring the filter caps argument. More precisely, this fixes the
following pipeline: gst-launch-1.0 videotestsrc ! vaapisink

Signed-off-by: Guangxin.Xu <>
Signed-off-by: Gwenole Beauchesne <>
4 years agompeg4: fix double definition of GstVaapiDecoderMpeg4Class.
Gwenole Beauchesne [Mon, 26 Aug 2013 09:31:06 +0000 (11:31 +0200)]
mpeg4: fix double definition of GstVaapiDecoderMpeg4Class.

This fixes the following issue:

  CC     libgstvaapi_0.10_la-gstvaapidecoder_mpeg4.lo
gstvaapidecoder_mpeg4.c:113: error: redefinition of typedef
gstvaapidecoder_mpeg4.c:44: note: previous declaration of
'GstVaapiDecoderMpeg4Class' was here
make[5]: *** [libgstvaapi_0.10_la-gstvaapidecoder_mpeg4.lo] Error 1
make[5]: Leaving directory

4 years agotests: filter: add support for deinterlacing.
Gwenole Beauchesne [Tue, 30 Jul 2013 13:59:40 +0000 (15:59 +0200)]
tests: filter: add support for deinterlacing.

Add --deinterlace option to enable deinterlacing through explicit VA/VPP
deinterlacing filter. However, if --deinterlace option is not set but the
--deinterlace-flags option is set with "top-field-first", then the very
basic bob deinterlacing filter is set through VA/VPP proc pipeline flags.

4 years agotests: filter: add support for denoising and sharpening.
Zhao Halley [Wed, 17 Jul 2013 09:29:41 +0000 (17:29 +0800)]
tests: filter: add support for denoising and sharpening.

Add --denoise option to enable noise reduction with the level specified
as the option value (float). Likewise, add --sharpen option to enable

Signed-off-by: Gwenole Beauchesne <>
4 years agotests: filter: add support for frame cropping.
Gwenole Beauchesne [Wed, 24 Jul 2013 12:31:34 +0000 (14:31 +0200)]
tests: filter: add support for frame cropping.

Add support for frame cropping through the --crop-rect|-c argument.
The format used is either <WIDTH> 'x' <HEIGHT>, with origin at (0,0) ;
or full specification with '('? <X> ',' <Y> ')'? <WIDTH> 'x' <HEIGHT>.

4 years agotests: filter: dump supported operations and formats.
Gwenole Beauchesne [Tue, 23 Jul 2013 16:00:26 +0000 (18:00 +0200)]
tests: filter: dump supported operations and formats.

4 years agotests: add initial test for video processing.
Zhao Halley [Mon, 8 Jul 2013 08:54:55 +0000 (16:54 +0800)]
tests: add initial test for video processing.

Add minimal test case for video processing: scaling and color format

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: add initial support for deinterlacing.
Zhao Halley [Mon, 29 Jul 2013 01:23:50 +0000 (09:23 +0800)]
filter: add initial support for deinterlacing.

Add basic deinterlacing support, i.e. bob-deinterlacing whereby only
the selected field from the input surface is kept for the target surface.
Setting gst_vaapi_filter_set_deinterlacing() method argument to
GST_VAAPI_DEINTERLACE_METHOD_NONE means to disable deinterlacing.

Also move GstVaapiDeinterlaceMethod definition from vaapipostproc plug-in
to libgstvaapi core library.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: add support for color balance adjustment.
Zhao Halley [Wed, 17 Jul 2013 09:40:41 +0000 (17:40 +0800)]
filter: add support for color balance adjustment.

Add ProcAmp (color balance) adjustments for hue, saturation, brightness
and contrast. The respective range for each filter shall be the same as
for the VA display attributes.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: add support for sharpening.
Zhao Halley [Wed, 17 Jul 2013 09:37:16 +0000 (17:37 +0800)]
filter: add support for sharpening.

Sharpening is configured with a float value. The supported range is
-1.0 .. 1.0 with 0.0 being the default, and that means no sharpening
operation at all.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: add support for denoising.
Zhao Halley [Wed, 17 Jul 2013 09:29:41 +0000 (17:29 +0800)]
filter: add support for denoising.

Noise reduction is configured with a float value. The supported range
is 0.0 .. 1.0 with 0.0 being the default, and that means no denoise
operation at all.

Signed-off-by: Gwenole Beauchesne <>
4 years agofilter: add support for frame cropping.
Gwenole Beauchesne [Wed, 24 Jul 2013 12:22:28 +0000 (14:22 +0200)]
filter: add support for frame cropping.

Frame cropping is defined with a GstVaapiRectangle value. The default
behaviour is to treat the source surface as a whole

4 years agofilter: add helper functions.
Gwenole Beauchesne [Thu, 25 Jul 2013 11:55:15 +0000 (13:55 +0200)]
filter: add helper functions.

Add helper functions to ensure an operation VA buffer is allocated to
the right size; that filter caps get parsed and assigned to the right
operation too; and that float parameters are correctly scaled to fit
the reported range from the VA driver.

4 years agoAdd initial infrastructure for video processing.
Gwenole Beauchesne [Tue, 23 Jul 2013 13:52:45 +0000 (15:52 +0200)]
Add initial infrastructure for video processing.

Add initial API for video processing: only scaling and color format
conversion operations are supported.

4 years agolibs: add gst_vaapi_video_format_from_string() helper.
Gwenole Beauchesne [Wed, 24 Jul 2013 09:53:38 +0000 (11:53 +0200)]
libs: add gst_vaapi_video_format_from_string() helper.

Add gst_vaapi_video_format_from_string() helper function to convert from
a video format string representation to a suitable GstVideoFormat. This
is just an alias to gst_video_format_from_string() for GStreamer 1.0.x
builds, and a proper iteration over all GstVideoFormat string representations
otherwise for earlier GStreamer 0.10.x builds.

4 years agolibs: add gst_vaapi_video_format_from_va_fourcc() helper.
Gwenole Beauchesne [Wed, 24 Jul 2013 09:37:23 +0000 (11:37 +0200)]
libs: add gst_vaapi_video_format_from_va_fourcc() helper.

Add gst_vaapi_video_format_from_va_fourcc() helper that converts from a
VA fourcc value to a suitable GstVideoFormat.

4 years agolibs: add type definitions for GstVaapiPoint and GstVaapiRectangle.
Gwenole Beauchesne [Wed, 24 Jul 2013 09:41:05 +0000 (11:41 +0200)]
libs: add type definitions for GstVaapiPoint and GstVaapiRectangle.

Add helper functions to describe GstVaapiPoint and GstVaapiRectangle
structures as a standard GType. This could be useful to have them
described as a GValue later on.

4 years agolibs: drop some public APIs.
Gwenole Beauchesne [Fri, 26 Jul 2013 11:57:35 +0000 (13:57 +0200)]
libs: drop some public APIs.

Don't expose GstVaapiContext APIs and make them totally private to
libgstvaapi core library. That API would also tend to disappear in
a future revision. Likewise, don't expose GstVaapiDisplayCache API
but keep symbols visible so that the various render backends could
share a common display cache implementation in libgstvaapi.

Try to clean-up the documentation from any stale entry too.

4 years agotests: image: allow creation of images with interleaved patterns.
Gwenole Beauchesne [Fri, 23 Aug 2013 16:35:42 +0000 (18:35 +0200)]
tests: image: allow creation of images with interleaved patterns.

Add image_generate_full() function to create interleaved color rectangles.
If flags is zero, the whole frame is generated with a unique pattern. If
flags is non-zero, then each field is handled individually.

4 years agotests: image: fix conversion from RGB to YUV.
Gwenole Beauchesne [Fri, 23 Aug 2013 14:25:39 +0000 (16:25 +0200)]
tests: image: fix conversion from RGB to YUV.

Fix RGB to YUV conversion to preserve full data range.

4 years agotests: image: try to upload images through vaDeriveImage() too.
Gwenole Beauchesne [Fri, 26 Jul 2013 11:12:28 +0000 (13:12 +0200)]
tests: image: try to upload images through vaDeriveImage() too.

On some platforms, vaPutImage() would fail even if it does not involve
color format conversion or scaling, whereas copying raw pixels through
vaDeriveImage() could work instead.

4 years agotests: image: add support for packed YUV formats.
Gwenole Beauchesne [Fri, 26 Jul 2013 08:05:06 +0000 (10:05 +0200)]
tests: image: add support for packed YUV formats.

Add support for packed YUV 4:2:2 formats, i.e. YUY2 and UYVY.

4 years agotests: image: fix generation of I420/YV12 images.
Gwenole Beauchesne [Thu, 25 Jul 2013 16:10:40 +0000 (18:10 +0200)]
tests: image: fix generation of I420/YV12 images.

U/V planes were reversed, thus producing invalid images.

4 years agotests: image: fix string representation for GstVideoFormat.
Gwenole Beauchesne [Wed, 24 Jul 2013 11:55:04 +0000 (13:55 +0200)]
tests: image: fix string representation for GstVideoFormat.

4 years agoimage: clean image API up.
Gwenole Beauchesne [Fri, 26 Jul 2013 10:57:19 +0000 (12:57 +0200)]
image: clean image API up.

Don't expose functions that reference a GstVaapiImageRaw, those are
meant to be internal only for implementing subpictures sync. Also add
a few private definitions to avoid functions calls for retrieving
image size and format information.

4 years agoimage: add gst_vaapi_image_copy() helper.
Gwenole Beauchesne [Fri, 26 Jul 2013 09:43:49 +0000 (11:43 +0200)]
image: add gst_vaapi_image_copy() helper.

Add gst_vaapi_image_copy() helper function to copy images of same format
and size.

4 years agoplugins: handle video cropping in X11 pixmap converter.
Gwenole Beauchesne [Mon, 22 Jul 2013 12:53:51 +0000 (14:53 +0200)]
plugins: handle video cropping in X11 pixmap converter.

Use GstVideoCropMeta in GStreamer 1.0 or any other render rectangle
we could decode from the stream.

4 years agoplugins: add support for "x11-pixmap" video converter type.
Gwenole Beauchesne [Mon, 22 Jul 2013 09:58:33 +0000 (11:58 +0200)]
plugins: add support for "x11-pixmap" video converter type.

Install a new video converter that supports X11 pixmap targets for X11
backends only, or make the GLX converter creation function chain up to
the X11 converter whenever requested.

4 years agotests: simple-decoder: add support for pixmap API.
Gwenole Beauchesne [Mon, 22 Jul 2013 07:36:08 +0000 (09:36 +0200)]
tests: simple-decoder: add support for pixmap API.

Add support for the new render-to-pixmap API. Avoid flickering on
platforms supporting video overlay by keeping up to 2 intermediate

4 years agotests: simple-decoder: add support for video cropping.
Gwenole Beauchesne [Mon, 22 Jul 2013 07:12:21 +0000 (09:12 +0200)]
tests: simple-decoder: add support for video cropping.

Handle video cropping information attached to a VA surface proxy.

4 years agotests: add support for render-to-pixmap.
Gwenole Beauchesne [Mon, 22 Jul 2013 07:03:30 +0000 (09:03 +0200)]
tests: add support for render-to-pixmap.

Add --pixmap option to test-decode so that to allow copies of VA
surface to an intermediate pixmap and rendering from that pixmap.

Only X11 backends are supported for now.

4 years agox11: implement pixmap rendering with RENDER extension.
Gwenole Beauchesne [Mon, 22 Jul 2013 07:00:38 +0000 (09:00 +0200)]
x11: implement pixmap rendering with RENDER extension.

Use hardware accelerated XRenderComposite() function, from the RENDER
extension, to blit a pixmap to screen. Besides, this can also support
cropping and scaling.

4 years agox11: implement pixmap API.
Gwenole Beauchesne [Fri, 19 Jul 2013 13:05:34 +0000 (15:05 +0200)]
x11: implement pixmap API.

Implement the new render-to-pixmap API. The only supported pixmap format
that will work is xRGB, with native byte ordering. Others might work but
they were not tested.

4 years agox11: update x11_get_geometry() helper function with depth output.
Gwenole Beauchesne [Mon, 22 Jul 2013 08:10:40 +0000 (10:10 +0200)]
x11: update x11_get_geometry() helper function with depth output.

Allow x11_get_geometry() utility function to also return the depth
assigned to the X drawable.

4 years agoAdd initial Pixmap API.
Gwenole Beauchesne [Mon, 22 Jul 2013 08:00:21 +0000 (10:00 +0200)]
Add initial Pixmap API.

Add API to transfer VA urfaces to native pixmaps. Also add an API to
render a native pixmap, for completeness. In general, rendering to
pixmap would only be useful to certain VA drivers and use cases on
X11 display servers. e.g. GLX_EXT_texture_from_pixmap (TFP) handled
in an upper layer.

4 years agolibs: add and expose gst_vaapi_video_format_to_string() helper.
Gwenole Beauchesne [Mon, 22 Jul 2013 13:15:48 +0000 (15:15 +0200)]
libs: add and expose gst_vaapi_video_format_to_string() helper.

This is just a wrapper over gst_video_format_to_string() for older
GStreamer 0.10 builds.

4 years agoplugins: fix display type comparison in gst_vaapi_create_display().
Emilio López [Thu, 18 Jul 2013 05:54:54 +0000 (02:54 -0300)]
plugins: fix display type comparison in gst_vaapi_create_display().

After the code got moved to create the gst_vaapi_create_display() helper,
this comparison was not updated to dereference the newly-created
pointer, so the code was comparing the pointer itself to the type, and
therefore failing to retrieve the VA display.

This fixes the following error (and gets gst-vaapi decoding again):

    ERROR vaapidecode gstvaapidecode.c:807:gst_vaapidecode_ensure_allowed_caps: failed to retrieve VA display

Signed-off-by: Emilio López <>
4 years agoBump version for development.
Gwenole Beauchesne [Wed, 17 Jul 2013 09:07:39 +0000 (11:07 +0200)]
Bump version for development.

4 years agompeg2: don't output dummy pictures.
Gwenole Beauchesne [Mon, 15 Jul 2013 15:49:31 +0000 (17:49 +0200)]
mpeg2: don't output dummy pictures.

Mark dummy pictures as output already so that we don't try to submit
them to the upper layer since this is purely internal / temporary
picture for helping the decoder.

4 years agodecoder: dispose GstVideoCodecFrame earlier.
Gwenole Beauchesne [Mon, 15 Jul 2013 15:43:34 +0000 (17:43 +0200)]
decoder: dispose GstVideoCodecFrame earlier.

Once the picture was output, it is no longer necessary to keep an extra
reference to the underlying GstVideoCodecFrame. So, we can release it
earlier, and maybe subsequently release the associate surface proxy

4 years ago0.5.5.
Gwenole Beauchesne [Mon, 15 Jul 2013 12:47:01 +0000 (14:47 +0200)]

4 years agoFix new video format API.
Gwenole Beauchesne [Mon, 15 Jul 2013 12:42:33 +0000 (14:42 +0200)]
Fix new video format API.

Fix new internal video format API, based on GstVideoFormat, to not
clobber with system symbols. So replace the gst_video_format_* prefix
with gst_vaapi_video_format_ prefix, even if the format type remains

4 years agoBump library major version.
Gwenole Beauchesne [Mon, 15 Jul 2013 12:05:45 +0000 (14:05 +0200)]
Bump library major version.

Bump the library major version due to API/ABI changes that occurred in
the imaging API. In particular, GstVaapiImageFormat type was replaced
with the standard GstVideoFormat type. All dependent APIs were updated
to match this change.

4 years agoNEWS: updates.
Gwenole Beauchesne [Mon, 15 Jul 2013 11:44:43 +0000 (13:44 +0200)]
NEWS: updates.