5 years ago0.5.3. 0.5.3
Gwenole Beauchesne [Thu, 18 Apr 2013 17:09:45 +0000 (19:09 +0200)]

5 years agoNEWS: updates.
Gwenole Beauchesne [Thu, 18 Apr 2013 17:08:39 +0000 (19:08 +0200)]
NEWS: updates.

5 years agovaapidecode: rework heuristics to detect decode timeout.
Gwenole Beauchesne [Thu, 18 Apr 2013 13:55:26 +0000 (15:55 +0200)]
vaapidecode: rework heuristics to detect decode timeout.

Rework heuristics to detect when downstream element ran into errors,
and thus failing to release any VA surface in due time for the current
frame to get decoded. In particular, recalibrate the render time base
when the first frame gets submitted downstream, or when there is no
timestamp that could be inferred.

5 years agovaapidecode: rework GstVideoDecoder::handle_frame() with a task.
Gwenole Beauchesne [Thu, 18 Apr 2013 13:50:02 +0000 (15:50 +0200)]
vaapidecode: rework GstVideoDecoder::handle_frame() with a task.

Rework GstVideoDecoder::handle_frame() to decode the current frame,
while possibly waiting for a free surface, and separately submit all
decoded frames from a task. This makes it possible to pop and render
decoded frames as soon as possible.

5 years agoplugins: use gst_object_unref() wherever applicable.
Gwenole Beauchesne [Thu, 18 Apr 2013 08:06:15 +0000 (10:06 +0200)]
plugins: use gst_object_unref() wherever applicable.

Use gst_object_unref() wherever applicable, e.g. objects derived from
GstElement, GstVideoPool, etc.

5 years agodocs: drop obsolete plug-ins.
Gwenole Beauchesne [Wed, 17 Apr 2013 12:21:16 +0000 (14:21 +0200)]
docs: drop obsolete plug-ins.

Drop documentation for obsolete plug-ins, even for GStreamer 0.10.
i.e. vaapiupload and vaapidownload are no longer the recommended
plug-ins to use.

5 years agodebian: fix build of GStreamer 0.10 packages.
Gwenole Beauchesne [Wed, 17 Apr 2013 11:17:26 +0000 (13:17 +0200)]
debian: fix build of GStreamer 0.10 packages.

Fix build of Debian packages to scan the actual GStreamer API version
from the generated changelog file.

5 years agovaapipostproc: minor clean-ups.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:58:04 +0000 (10:58 +0200)]
vaapipostproc: minor clean-ups.

Use g_clear_object() wherever appropriate and remove dead-code.

5 years agovaapipostproc: fix reference counting buf for passthrough mode.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:53:03 +0000 (10:53 +0200)]
vaapipostproc: fix reference counting buf for passthrough mode.

Fix reference counting bug for passthrough mode, whereby the input buffer
was propagated as is downstream through gst_pad_push() without increasing
its reference count before. The was a problem when gst_pad_push() returns
an error and we further decrease the reference count of the input buffer.

5 years agovaapipostproc: port to GStreamer 1.0.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:18:45 +0000 (10:18 +0200)]
vaapipostproc: port to GStreamer 1.0.

Add support for interlaced streams with GStreamer 1.0 too. Basically,
this enables vaapipostproc, though it is not auto-plugged yet. We also
make sure to reply to CAPS queries, and happily handle CAPS events.

5 years agodecoder: fix GstVideoCodecFrame flags for interlaced contents.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:14:55 +0000 (10:14 +0200)]
decoder: fix GstVideoCodecFrame flags for interlaced contents.

Fix support for interlaced contents with GStreamer 0.10. In particular,
propagate GstVaapiSurfaceProxy frame flags to GstVideoCodecFrame flags

This is a regression from commit 87e5717.

5 years agodecoder: rename GstVaapiDecoderFrame to GstVaapiParserFrame.
Gwenole Beauchesne [Tue, 16 Apr 2013 11:23:41 +0000 (13:23 +0200)]
decoder: rename GstVaapiDecoderFrame to GstVaapiParserFrame.

Rename GstVaapiDecoderFrame to GstVaapiParserFrame because this data
structure was only useful to parsing and a proper GstvaapiDecoderFrame
instance will be created instead.

5 years agodecoder: export presentation timestamp for raw decoding mode.
Gwenole Beauchesne [Tue, 16 Apr 2013 17:09:30 +0000 (19:09 +0200)]
decoder: export presentation timestamp for raw decoding mode.

Fix regression from 0.4-branch whereby GstVaapiSurfaceProxy no longer
held any information about the expected presentation timestamp, frame
duration or additional flags like interlaced or top-field-first.

5 years agodecoder: use new GstVaapiSurfaceProxy utility functions.
Gwenole Beauchesne [Tue, 16 Apr 2013 16:56:24 +0000 (18:56 +0200)]
decoder: use new GstVaapiSurfaceProxy utility functions.

Use new GstVaapiSurfaceProxy internal helper functions to propagate the
necessary GstVideoCodecFrame flags to vaapidecode (GStreamer 0.10).

Also make GstVaapiDecoder push_frame() operate similarly to drop_frame().
i.e. increase the GstVideoCodecFrame reference count in push_frame rather
than gst_vaapi_picture_output().

5 years agosurfaceproxy: add more attributes for raw decoding modes.
Gwenole Beauchesne [Tue, 16 Apr 2013 16:35:48 +0000 (18:35 +0200)]
surfaceproxy: add more attributes for raw decoding modes.

Add more attributes for raw decoding modes, i.e. directly through the
libgstvaapi helper library. In particular, add presentation timestamp,
duration and a couple of flags (interlaced, TFF, RFF, one-field).

5 years agosurfaceproxy: drop user-data support from GstVaapiSurfaceProxy.
Gwenole Beauchesne [Tue, 16 Apr 2013 11:48:00 +0000 (13:48 +0200)]
surfaceproxy: drop user-data support from GstVaapiSurfaceProxy.

Drop user-data support from GstVaapiSurfaceProxy. Rather make it explicit
to call some user-provided function when the surface proxy is released.

5 years agobuild: link against libdl.
Víctor Manuel Jáquez Leal [Mon, 15 Apr 2013 08:52:51 +0000 (12:52 +0400)]
build: link against libdl.

Ensure libgstvaapi-glx*.so builds against libdl since dlsym() is used
to resolve glXGetProcAddress() from GLX libraries. This fix builds on
Fedora 17.

Signed-off-by: Gwenole Beauchesne <>
5 years agodecoder: fix gst_vaapi_decoder_get_codec_state().
Gwenole Beauchesne [Mon, 15 Apr 2013 12:22:57 +0000 (14:22 +0200)]
decoder: fix gst_vaapi_decoder_get_codec_state().

Fix previous commit whereby gst_vaapi_decoder_get_codec_state() was
supposed to make GstVaapiDecoder own the return GstVideoCodecState
object. Only comment was updated, not the actual code.

5 years agodecoder: make gst_vaapi_decoder_get_codec_state() return the original state.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:58:58 +0000 (13:58 +0200)]
decoder: make gst_vaapi_decoder_get_codec_state() return the original state.

Make gst_vaapi_decoder_get_codec_state() return the original codec state,
i.e. make the GstVaapiDecoder object own the return state so that callers
that want an extra reference to it would just gst_video_codec_state_ref()
it before usage. This aligns the behaviour with what we had before with

This is an ABI incompatible change, library major version was bumped from
previous release (0.5.2).

5 years agoplugins: mark a few more functions as internal.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:52:19 +0000 (13:52 +0200)]
plugins: mark a few more functions as internal.

Mark the following functions are internal, i.e. private to the vaapi plug-in:
- gst_vaapi_video_buffer_pool_get_type()
- gst_vaapi_video_converter_glx_get_type()
- gst_vaapi_video_converter_glx_new()

5 years agoplugins: implement GstSurfaceMeta API.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:48:43 +0000 (13:48 +0200)]
plugins: implement GstSurfaceMeta API.

Implement GstSurfaceMeta API for GStreamer 1.0.x. Even though this is
an unstable/deprecated API, this makes it possible to support Clutter
sink with minimal changes. Tested against clutter-gst 1.9.92.

5 years agovaapisink: optimize GstVideoOverlayInterface::expose().
Gwenole Beauchesne [Fri, 12 Apr 2013 15:12:43 +0000 (17:12 +0200)]
vaapisink: optimize GstVideoOverlayInterface::expose().

When render-mode is "overlay", then it is not really useful to peek into
the GstBaseSink::last_buffer, since we have our own video_buffer already
recorded and maintained into GstVaapiSink.

5 years agovaapisink: fix memory leak of GstSample objects.
Gwenole Beauchesne [Fri, 12 Apr 2013 15:05:06 +0000 (17:05 +0200)]
vaapisink: fix memory leak of GstSample objects.

Fix memory leak of GstSample objects in GstVideoOverlayInterface::expose().
This also fixes extra unreferencing of the underlying GstBuffer in the common
path afterwards (for both 0.10 or 1.0).

5 years agoplugins: fix description for gst-inspect.
Gwenole Beauchesne [Fri, 12 Apr 2013 11:44:52 +0000 (13:44 +0200)]
plugins: fix description for gst-inspect.

Fix the name of the plug-in element reported to gst-inspect-1.0. i.e. we
need an explicit definition for GStreamer >= 1.0 because the GST_PLUGIN_DEFINE
incorrectly uses #name for creating the plug-in name, instead of using macro
expansion (and let further expansion of macros) through e.g. G_STRINGIFY().

5 years agoREADME: updates.
Gwenole Beauchesne [Thu, 11 Apr 2013 07:24:44 +0000 (09:24 +0200)]
README: updates.

Update build requirements for GStreamer 1.0.x support. Add section for
ways to report bugs.

5 years agoNEWS: updates.
Gwenole Beauchesne [Wed, 10 Apr 2013 14:54:01 +0000 (16:54 +0200)]
NEWS: updates.

5 years agoFix make dist to include all source files, in any case.
Gwenole Beauchesne [Wed, 10 Apr 2013 13:31:41 +0000 (15:31 +0200)]
Fix make dist to include all source files, in any case.

Fix make dist to allow build for either GStreamer 0.10 or 1.0. i.e. make
sure to include all source files in either case while generating source

5 years agoBump library major version.
Gwenole Beauchesne [Wed, 10 Apr 2013 13:21:57 +0000 (15:21 +0200)]
Bump library major version.

Bump library major version, while preserving a major version of 0 for
GStreamer 1.0 based libraries, and a major version of 2 for GStreamer
0.10 based librarieS.

5 years agoplugins: implement direct-rendering mode for raw YUV buffer uploads.
Gwenole Beauchesne [Wed, 10 Apr 2013 12:37:42 +0000 (14:37 +0200)]
plugins: implement direct-rendering mode for raw YUV buffer uploads.

Allow direct-rendering (writes) into target VA surfaces.

5 years agoplugins: implement uploads from raw YUV buffers for GStreamer 1.0.
Gwenole Beauchesne [Tue, 9 Apr 2013 14:02:06 +0000 (16:02 +0200)]
plugins: implement uploads from raw YUV buffers for GStreamer 1.0.

Implement GstVideoMeta::{,un}map() to support raw YUV buffer upload when
the last component is unmapped. Downloads are not supported yet. The aim
was to first support SW decoding + HW accelerated rendering (vaapisink).
e.g. for Wayland.

5 years agovaapidecode: submit all decoded frames before decoding a new one.
Gwenole Beauchesne [Wed, 3 Apr 2013 09:10:41 +0000 (11:10 +0200)]
vaapidecode: submit all decoded frames before decoding a new one.

Make sure to purge all pending frames that were already decoded prior
to decoding a new one. This helps release VA surfaces as early as

5 years agovaapidecode: reply to CAPS queries.
Gwenole Beauchesne [Tue, 2 Apr 2013 14:12:16 +0000 (16:12 +0200)]
vaapidecode: reply to CAPS queries.

Handle GST_QUERY_CAPS, which is the GStreamer 1.0 mechanism to retrieve
the set of allowed caps, i.e. it works similar to GstPad::get_caps().

This fixes fallback to SW decoding if no HW decoder is available.

5 years agodecoder: fix unpaired GstBuffer map/unmaps.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:26:38 +0000 (11:26 +0100)]
decoder: fix unpaired GstBuffer map/unmaps.

This possibly fixes a few memory leaks along the way.

5 years agoAllow build against either GStreamer API (0.10 or 1.0).
Gwenole Beauchesne [Wed, 20 Mar 2013 13:40:57 +0000 (14:40 +0100)]
Allow build against either GStreamer API (0.10 or 1.0).

Introduce a new configure option --with-gstreamer-api that determines
the desired GStreamer API to use. By default, GStreamer 1.0 is selected.
Also integrate more compatibility glue into gstcompat.h and plugins.

5 years agoplugins: use new video buffer pools.
Sreerenj Balachandran [Thu, 8 Nov 2012 14:41:22 +0000 (16:41 +0200)]
plugins: use new video buffer pools.

Use new GstVaapiVideoBufferPool to maintain video buffers. Implement
GstBaseSink::propose_allocation() to expose that pool to upstream
elements; and also implement GstVideoDecoder::decide_allocation() to
actually use that pool (from downstream), if any, or create one.

Signed-off-by: Gwenole Beauchesne <>
5 years agoplugins: add GstVaapiVideoMemory and GstVaapiVideoBufferPool objects.
Sreerenj Balachandran [Thu, 8 Nov 2012 14:41:22 +0000 (16:41 +0200)]
plugins: add GstVaapiVideoMemory and GstVaapiVideoBufferPool objects.

Add initial support for GstVaapiVideoMemory backed buffer pool. The memory
object currently holds a reference to GstVaapiVideoMeta.

Signed-off-by: Gwenole Beauchesne <>
5 years agoplugins: allow copies of GstVaapiVideoMeta objects.
Gwenole Beauchesne [Thu, 4 Apr 2013 15:36:45 +0000 (17:36 +0200)]
plugins: allow copies of GstVaapiVideoMeta objects.

Make it possible to copy GstVaapiVideoMeta objects, unless they contain VA
objects created from GstVaapiVideoPool. This is mostly useful to clone a
GstVaapiVideoMeta object containing a VA surface proxy so that to alter its
rendering flags.

5 years agoplugins: make it possible to clear VA objects from GstVaapiVideoMeta.
Gwenole Beauchesne [Thu, 4 Apr 2013 14:16:31 +0000 (16:16 +0200)]
plugins: make it possible to clear VA objects from GstVaapiVideoMeta.

Fix GstVaapiVideoMeta to allow VA objects to be destroyed when they are
reset to NULL. i.e. make gst_vaapi_video_meta_set_{image,surface}() and
gst_vaapi_video_meta_set_surface_proxy() actually clear VA objects when
argument is NULL.

5 years agoplugins: initial port to GStreamer 1.0.
Sreerenj Balachandran [Mon, 3 Sep 2012 11:00:25 +0000 (14:00 +0300)]
plugins: initial port to GStreamer 1.0.

Port vaapidecode and vaapisink plugins to GStreamer API >= 1.0. This
is rather minimalistic so that to test the basic functionality.

Disable vaapiupload, vaapidownload and vaapipostproc plugins. The latter
needs polishing wrt. to GStreamer 1.x functionality and the former are
totally phased out in favor of GstVaapiVideoMemory map/unmap facilities,
which are yet to be implemented.

Signed-off-by: Gwenole Beauchesne <>
5 years agotests: add support for GStreamer 1.0.
Gwenole Beauchesne [Thu, 21 Mar 2013 09:12:09 +0000 (10:12 +0100)]
tests: add support for GStreamer 1.0.

5 years agoAdd initial support for GStreamer 1.0.
Sreerenj Balachandran [Tue, 4 Sep 2012 12:12:18 +0000 (15:12 +0300)]
Add initial support for GStreamer 1.0.

This integrates support for GStreamer API >= 1.0 only in the libgstvaapi
core decoding library. The changes are kept rather minimal here so that
the library retains as little dependency as possible on core GStreamer

Signed-off-by: Gwenole Beauchesne <>
5 years agovaapisink: improve check for raw YUV format mode.
Gwenole Beauchesne [Wed, 3 Apr 2013 13:58:57 +0000 (15:58 +0200)]
vaapisink: improve check for raw YUV format mode.

Improve check for raw YUV format modes by avoiding checks against strings
("video/x-raw-yuv") for each new GstBuffer allocation. In the usual case,
GstBaseSink::set_caps() is called first and if VA surface format mode is
used, then GstBaseSink::buffer_alloc() is not called. If the latter is
called before set_caps(), then we just make a full check. This one is
pretty rare though, e.g. it usually happens once for custom pipelines.

5 years agoplugins: don't fail if there is no overlay composition to apply.
Gwenole Beauchesne [Wed, 3 Apr 2013 13:06:46 +0000 (15:06 +0200)]
plugins: don't fail if there is no overlay composition to apply.

Fix gst_vaapi_apply_composition() to not fail if no overlay composition
was found. i.e. return success (TRUE). This was harmless though extra
debug messages are not nice.

This is a regression introduced by commit 95b8659.

5 years agovaapidecode: expose the exact set of supported HW decoders.
Gwenole Beauchesne [Wed, 3 Apr 2013 12:59:33 +0000 (14:59 +0200)]
vaapidecode: expose the exact set of supported HW decoders.

Don't return static caps that don't mean anything for the underlying codecs
that are actually supported for decoding. i.e. always allocate a VA display
and retrieve the exact set of HW decoders available. That VA display may be
re-used later on during negotiation through GstVideoContext "prepare-context".

This fixes fallback to SW decoding if no HW decoder is available.

5 years agodecoder: drop obsolete functions.
Gwenole Beauchesne [Wed, 3 Apr 2013 11:08:55 +0000 (13:08 +0200)]
decoder: drop obsolete functions.

Drop the following functions that are now obsolete:
- gst_vaapi_context_get_surface()
- gst_vaapi_context_put_surface()
- gst_vaapi_context_find_surface_by_id()
- gst_vaapi_surface_proxy_new()
- gst_vaapi_surface_proxy_get_context()
- gst_vaapi_surface_proxy_set_context()
- gst_vaapi_surface_proxy_set_surface()

This is an API change.

5 years agodecoder: delegate surface size check to VA context reset.
Gwenole Beauchesne [Wed, 3 Apr 2013 11:14:59 +0000 (13:14 +0200)]
decoder: delegate surface size check to VA context reset.

Now that the surface pool is reference counted in the surface proxy wrapper,
we can safely ignore surface size checks in gst_vaapi_decoder_ensure_context().
Besides, this check is already performed in gst_vaapi_context_reset_full().

5 years agodecoder: simplify acquisition/release of spare surface.
Gwenole Beauchesne [Wed, 3 Apr 2013 09:37:44 +0000 (11:37 +0200)]
decoder: simplify acquisition/release of spare surface.

Introduce gst_vaapi_surface_proxy_new_from_pool() to allocate a new surface
proxy from the context surface pool. This change also makes sure to retain
the parent surface pool in the proxy.

Besides, it was also totally useless to attach/detach parent context to
VA surface each time we acquire/release it. Since the whole context owns
all associated VA surfaces, we can mark this as such only once and for all.

5 years agoBump version for development.
Gwenole Beauchesne [Fri, 29 Mar 2013 09:39:37 +0000 (10:39 +0100)]
Bump version for development.

5 years ago0.5.2. 0.5.2
Gwenole Beauchesne [Thu, 28 Mar 2013 09:18:51 +0000 (10:18 +0100)]

5 years agoNEWS: updates.
Gwenole Beauchesne [Thu, 28 Mar 2013 09:15:53 +0000 (10:15 +0100)]
NEWS: updates.

5 years agoplugins: fix usage of gst_vaapi_reply_to_query().
Gwenole Beauchesne [Tue, 26 Mar 2013 17:57:00 +0000 (18:57 +0100)]
plugins: fix usage of gst_vaapi_reply_to_query().

Make gst_vaapi_reply_to_query() first check whether the query argument
is actually a video-context query, i.e. with type GST_QUERY_TYPE_CUSTOM.
Then, make sure vaapisink propagates the query to the parent class if
it is not a video-context query.

5 years agoplugins: streamline video buffers.
Gwenole Beauchesne [Tue, 26 Mar 2013 17:45:53 +0000 (18:45 +0100)]
plugins: streamline video buffers.

Add new gst_vaapi_video_buffer_new() helper function that allocates a video
buffer from a GstVaapiVideoMeta. Also remove obsolete and useless function

5 years agoplugins: integrate GstVaapiVideoMeta from libgstvaapi.
Gwenole Beauchesne [Tue, 26 Mar 2013 09:31:10 +0000 (10:31 +0100)]
plugins: integrate GstVaapiVideoMeta from libgstvaapi.

Move GstVaapiVideoMeta from core libgstvaapi decoding library to the
actual plugin elements. That's only useful there. Also inline reference
counting code from GstVaapiMiniObject.

5 years agoplugins: drop gstvaapipluginbuffer.[ch] helper files.
Gwenole Beauchesne [Thu, 21 Mar 2013 16:17:53 +0000 (17:17 +0100)]
plugins: drop gstvaapipluginbuffer.[ch] helper files.

Move all gst_vaapi_video_buffer_new*() helpers from gstvaapipluginbuffer.[ch]
to gstvaapivideobuffer.[ch], and drop the obsolete files.

5 years agoplugins: integrate GstVaapiVideoBuffer from libgstvaapi.
Gwenole Beauchesne [Thu, 21 Mar 2013 16:06:43 +0000 (17:06 +0100)]
plugins: integrate GstVaapiVideoBuffer from libgstvaapi.

Move GstVaapiVideoBuffer from core libgstvaapi decoding library to the
actual plugin elements. That's only useful there.

5 years agoplugins: use common helper function to apply compositions.
Gwenole Beauchesne [Thu, 21 Mar 2013 15:32:43 +0000 (16:32 +0100)]
plugins: use common helper function to apply compositions.

Use common gst_vaapi_apply_composition() helper function to apply compositions
attached to a buffer in vaapisink or GstVaapiVideoConverterGLX.

5 years agoplugins: integrate GstVaapiVideoConverterGLX from libgstvaapi.
Gwenole Beauchesne [Thu, 21 Mar 2013 15:09:42 +0000 (16:09 +0100)]
plugins: integrate GstVaapiVideoConverterGLX from libgstvaapi.

Make sure libgstvaapi core decoding library doesn't include un-needed
dependencies. So, move out GstVaapiVideoConverterGLX to plugins instead.
Besides, even if the vaapisink element is not used, we are bound to have
a correctly populated GstSurfaceBuffer from vaapidecode.

Also clean-up the file along the way.

5 years agovc1: fix use of possibly uninitialized variable.
Gwenole Beauchesne [Thu, 21 Mar 2013 12:32:15 +0000 (13:32 +0100)]
vc1: fix use of possibly uninitialized variable.

In decode_codec_data(), force initialization of format to zero so that
we can catch up cases where codec-data has neither "format" nor "wmvversion"
fields, thus making it possible to gracefully fail in this case.

5 years agojpeg: propagate buffer data as a const guchar * pointer (cosmetics).
Gwenole Beauchesne [Thu, 21 Mar 2013 12:43:46 +0000 (13:43 +0100)]
jpeg: propagate buffer data as a const guchar * pointer (cosmetics).

5 years agodecoder: sanitize codec-data decoding.
Gwenole Beauchesne [Thu, 21 Mar 2013 13:36:40 +0000 (14:36 +0100)]
decoder: sanitize codec-data decoding.

Add a new GstVaapiDecoder::decode_codec_data() hook to actually decode
codec-data in the decoder sub-class. Provide a common shared helper
function to do the actual work and delegating further to the sub-class.

5 years agodecoder: get rid of GstVaapiDecoderUnit::buffer field.
Gwenole Beauchesne [Thu, 21 Mar 2013 12:41:28 +0000 (13:41 +0100)]
decoder: get rid of GstVaapiDecoderUnit::buffer field.

Drop GstVaapiDecoderUnit buffer field (GstBuffer) since it's totally
useless nowadays as creating sub-buffers doesn't bring any value. It
actually means more memory allocations. We can't do without that in
JPEG and MPEG-4:2 decoders.

5 years agodecoder: sanitize uses of codec frame input buffer (cosmetics).
Gwenole Beauchesne [Thu, 21 Mar 2013 12:28:05 +0000 (13:28 +0100)]
decoder: sanitize uses of codec frame input buffer (cosmetics).

Alias GST_VAAPI_DECODER_CODEC_FRAME(decoder)->input_buffer to a simple
"buffer" variable.

5 years agovaapisink: add helper function to apply a composition buffer.
Gwenole Beauchesne [Wed, 20 Mar 2013 16:34:38 +0000 (17:34 +0100)]
vaapisink: add helper function to apply a composition buffer.

Simplify application of a composition buffer to a GstVaapiSurface, and
all its peers, until that function is eventually promoted to libgstvaapi.

5 years agovaapisink: fix support for raw YUV buffers.
Gwenole Beauchesne [Wed, 20 Mar 2013 12:42:15 +0000 (13:42 +0100)]
vaapisink: fix support for raw YUV buffers.

If the raw YUV buffer was created from vaapisink, through the buffer_alloc()
hook, then it will have a valid GstVaapiVideoMeta object attached to it.
However, we previously assumed in that case that it was a "native" VA buffer,
thus not calling into GstVaapiUploader::process().

5 years agoplugins: use modern GstElement metadata information.
Gwenole Beauchesne [Wed, 20 Mar 2013 17:41:40 +0000 (18:41 +0100)]
plugins: use modern GstElement metadata information.

Use gst_element_class_set_static_metadata() from GStreamer 1.0, which
basically is the same as gst_element_class_set_details_simple() in
GStreamer 0.10 context.

5 years agoplugins: move up interfaces (cosmetics).
Gwenole Beauchesne [Wed, 20 Mar 2013 17:04:39 +0000 (18:04 +0100)]
plugins: move up interfaces (cosmetics).

Move GstImplementsInterface and GstVideoContext support functions up
so that to keep a clear separation between the plugin element and its
interface hooks.

5 years agoplugins: upgrade to newer APIs (GstVideoInfo based helpers).
Gwenole Beauchesne [Wed, 20 Mar 2013 11:57:18 +0000 (12:57 +0100)]
plugins: upgrade to newer APIs (GstVideoInfo based helpers).

Use GstVideoInfo and gst_video_info_from_caps() helper wherever possible.
Also use the newly added gst_vaapi_image_format_from_structure() helper
in GstVaapiUploader::ensure_allowed_caps().

5 years agoplugins: fix creation of video buffer from another source buffer.
Gwenole Beauchesne [Wed, 20 Mar 2013 13:02:48 +0000 (14:02 +0100)]
plugins: fix creation of video buffer from another source buffer.

gst_vaapi_video_buffer_new_from_buffer() needs to reference the source
buffer video meta since it would be unreference'd from the get_buffer()
helper function. For other cases, we still use (steal) the newly created
video meta.

5 years agoplugins: include "sysdeps.h" header instead of "config.h".
Gwenole Beauchesne [Wed, 20 Mar 2013 10:57:03 +0000 (11:57 +0100)]
plugins: include "sysdeps.h" header instead of "config.h".

5 years agotests: modernize GstTypeFind functions.
Gwenole Beauchesne [Wed, 20 Mar 2013 17:33:23 +0000 (18:33 +0100)]
tests: modernize GstTypeFind functions.

Use the GstTypeFind hooks from GStreamer 1.0. They look safer and
exactly correspond to the expected behaviour.

5 years agotests: fix license templates.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:57:57 +0000 (11:57 +0100)]
tests: fix license templates.

5 years agotests: use gst_vaapi_image_format_from_structure() in test-display.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:53:59 +0000 (11:53 +0100)]
tests: use gst_vaapi_image_format_from_structure() in test-display.

Use gst_vaapi_image_format_from_structure() helper in test-display and
then extract a VAImageFormat from it instead of relying on GstCaps for
YUV and RGB formats.

5 years agotests: include "sysdeps.h" header instead of "config.h".
Gwenole Beauchesne [Wed, 20 Mar 2013 10:50:15 +0000 (11:50 +0100)]
tests: include "sysdeps.h" header instead of "config.h".

5 years agosubpicture: use gst_video_overlay_rectangle_get_pixels_unscaled_raw().
Gwenole Beauchesne [Wed, 20 Mar 2013 17:25:05 +0000 (18:25 +0100)]
subpicture: use gst_video_overlay_rectangle_get_pixels_unscaled_raw().

Use newer gst_video_overlay_rectangle_get_pixels_unscaled_raw() helper
function with GStreamer 0.10 compatible semantics, or that tries to
approach the current meaning. Basically, this is also just about moving
the helper to gstcompat.h.

5 years agoimage: add gst_vaapi_image_format_from_structure() helper.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:10:31 +0000 (11:10 +0100)]
image: add gst_vaapi_image_format_from_structure() helper.

Add helper function to convert video formats from a GstStructure to a
plain GstVaapiImageFormat.

5 years agosysdeps: split out GStreamer API compatibility glue to "gstcompat.h".
Gwenole Beauchesne [Wed, 20 Mar 2013 17:12:18 +0000 (18:12 +0100)]
sysdeps: split out GStreamer API compatibility glue to "gstcompat.h".

5 years agosysdeps: add more standard includes by default.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:56:15 +0000 (11:56 +0100)]
sysdeps: add more standard includes by default.

5 years agoconfigure: improve GStreamer API version checks.
Gwenole Beauchesne [Wed, 20 Mar 2013 13:43:46 +0000 (14:43 +0100)]
configure: improve GStreamer API version checks.

5 years agoconfigure: rename GST_MAJORMINOR to GST_API_VERSION.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:44:10 +0000 (11:44 +0100)]
configure: rename GST_MAJORMINOR to GST_API_VERSION.

5 years agoconfigure: improve check for H.264 codecparser.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:28:06 +0000 (11:28 +0100)]
configure: improve check for H.264 codecparser.

5 years agovaapiupload: fix illegal write in ensure_image().
Holger Kaelberer [Mon, 25 Feb 2013 23:38:24 +0000 (00:38 +0100)]
vaapiupload: fix illegal write in ensure_image().

Fix ensure_image() to only zero-initialize the first line of each plane.
Properly initializing each plane to their full vertical resolution would
require to actually compute it based on the image format.

In particular, for NV12 images, the UV plane has half vertical resolution
vs. the Y plane. So using the full image height to initialize the UV plane
will obviously lead to a buffer overflow. Likewise for other YUV format.

Since ensure_image() is only a helper function to initialize something,
and not necessarily the whole thing, it is fine to initializ the first
line only. Besides, the target surface is not rendered either.

Signed-off-by: Gwenole Beauchesne <>
5 years agobuild: fix compiling of local GstVideoDecoder and codecparsers.
Xiang, Haihao [Sun, 17 Feb 2013 08:28:47 +0000 (16:28 +0800)]
build: fix compiling of local GstVideoDecoder and codecparsers.

Generated source files were missing a dependency on the complete set of
generated header files. e.g. gstvideodecoder.c requires gstvideoutils.h
to build and almost every codec parser source depends on parserutils.h.

Signed-off-by: Xiang, Haihao <>
Signed-off-by: Gwenole Beauchesne <>
5 years agoh264: set {luma,chroma}_log2_weight_denom to 0 if no pred_weight_table().
Gwenole Beauchesne [Fri, 8 Feb 2013 10:56:54 +0000 (11:56 +0100)]
h264: set {luma,chroma}_log2_weight_denom to 0 if no pred_weight_table().

Force luma_log2_weight_denom and chroma_log2_weight_denom to zero if
there is no pred_weight_table() that was parsed.

This is a workaround for the VA intel-driver on Ivy Bridge.

5 years agoh264: use new profile definitions from codecparsers.
Gwenole Beauchesne [Thu, 7 Feb 2013 14:42:55 +0000 (15:42 +0100)]
h264: use new profile definitions from codecparsers.

5 years agocodecparsers: update to gst-vaapi-branch commit 500bc02.
Gwenole Beauchesne [Thu, 7 Feb 2013 14:29:44 +0000 (15:29 +0100)]
codecparsers: update to gst-vaapi-branch commit 500bc02.

500bc02 h264: add profile enums

5 years agoNEWS: updates.
Gwenole Beauchesne [Wed, 6 Feb 2013 14:27:18 +0000 (15:27 +0100)]
NEWS: updates.

5 years agocodecparsers: update to gst-vaapi-branch commit 31b1c57.
Gwenole Beauchesne [Wed, 6 Feb 2013 14:21:27 +0000 (15:21 +0100)]
codecparsers: update to gst-vaapi-branch commit 31b1c57.

8957fb7 mpeg2: add helpers to convert quantization matrices
07c4034 mpeg2: store quantization matrices in zigzag scan order

5 years agotests: simple-decoder: fix build on older platforms.
Gwenole Beauchesne [Thu, 31 Jan 2013 10:32:24 +0000 (11:32 +0100)]
tests: simple-decoder: fix build on older platforms.

Make simple-decoder build and execute correctly on older platforms,
and more precisely older versions of glib.

5 years agoglibcompat: add replacement for g_async_queue_timeout_pop().
Gwenole Beauchesne [Thu, 31 Jan 2013 10:30:12 +0000 (11:30 +0100)]
glibcompat: add replacement for g_async_queue_timeout_pop().

g_async_queue_timeout_pop() appeared in glib 2.31.18. Implement it as
g_async_queue_timed_pop() with a GTimeVal as the final time to wait for
new data to arrive in the queue.

5 years agoglibcompat: add replacement for g_cond_wait().
Gwenole Beauchesne [Thu, 31 Jan 2013 10:25:18 +0000 (11:25 +0100)]
glibcompat: add replacement for g_cond_wait().

5 years agompeg2: fix decoding of 4K videos.
Gwenole Beauchesne [Wed, 30 Jan 2013 17:38:38 +0000 (18:38 +0100)]
mpeg2: fix decoding of 4K videos.

Account for slice_vertical_position_extension when vertical_size > 2800.

5 years agompeg2: fix decoding of sequence_end().
Gwenole Beauchesne [Wed, 30 Jan 2013 17:54:13 +0000 (18:54 +0100)]
mpeg2: fix decoding of sequence_end().

There shall be only one place to call decode_current_picture(), and this
is in the end_frame() hook. The EOS unit is processed after end_frame()
so this means we cannot have a valid picture to decode/output at this

5 years agompeg2: improve robustness when packets are missing.
Gwenole Beauchesne [Wed, 30 Jan 2013 14:10:06 +0000 (15:10 +0100)]
mpeg2: improve robustness when packets are missing.

Improve robustness when some expected packets where not received yet
or that were not correctly decoded. For example, don't try to decode
a picture if there was no valid sequence or picture headers.

5 years agodecoder: handle decode-only frames in raw API mode.
Gwenole Beauchesne [Wed, 30 Jan 2013 17:58:01 +0000 (18:58 +0100)]
decoder: handle decode-only frames in raw API mode.

Fix gst_vaapi_decoder_get_surface() to only return frames with a valid
surface proxy, i.e. with a valid VA surface. This means that any frame
marked as decode-only is simply skipped.

5 years agodecoder: allow frames to be dropped.
Gwenole Beauchesne [Wed, 30 Jan 2013 15:33:48 +0000 (16:33 +0100)]
decoder: allow frames to be dropped.

If the decoder was not able to decode a frame because insufficient
information was available, e.g. missing sequence or picture header,
then allow the frame to be gracefully dropped without generating
any error.

It is also possible that a frame is not meant to be displayed but
only used as a reference, so dropping that frame is also a valid
operation since GstVideoDecoder base class has extra references to
that GstVideoCodecFrame that needs to be released.

5 years agovaapidecode: handle decode-only frames.
Gwenole Beauchesne [Wed, 30 Jan 2013 15:26:07 +0000 (16:26 +0100)]
vaapidecode: handle decode-only frames.

Decode-only frames may not have a valid surface proxy. So, simply discard
them gracefully, i.e. don't create meta data information. GstVideoDecoder
base class will properly handle this case and won't try to push any buffer
to downstream elements.

5 years agovaapidecode: add support for post-seek semantics reset.
Sreerenj Balachandran [Wed, 23 Jan 2013 22:49:17 +0000 (00:49 +0200)]
vaapidecode: add support for post-seek semantics reset.

Implement GstVideoDecoder::reset() as a destruction of the VA decoder
and the creation of a new VA decoder.

Signed-off-by: Gwenole Beauchesne <>
5 years agoBump version for development.
Gwenole Beauchesne [Wed, 30 Jan 2013 08:38:07 +0000 (09:38 +0100)]
Bump version for development.

5 years ago0.5.1. 0.5.1
Gwenole Beauchesne [Wed, 30 Jan 2013 08:37:38 +0000 (09:37 +0100)]

5 years agompeg2: implement GstVaapiDecoder::flush() as a DPB flush.
Sreerenj Balachandran [Wed, 23 Jan 2013 22:48:26 +0000 (00:48 +0200)]
mpeg2: implement GstVaapiDecoder::flush() as a DPB flush.