5 years ago0.4.3. 0.4.3
Gwenole Beauchesne [Tue, 5 Feb 2013 13:58:58 +0000 (14:58 +0100)]

5 years agoNEWS: updates.
Gwenole Beauchesne [Tue, 5 Feb 2013 10:31:15 +0000 (11:31 +0100)]
NEWS: updates.

5 years agocodecparsers: update to gst-vaapi-branch commit b8efe57.
Gwenole Beauchesne [Tue, 5 Feb 2013 13:03:39 +0000 (14:03 +0100)]
codecparsers: update to gst-vaapi-branch commit b8efe57.

b8efe57 mpeg2: add helpers to convert quantization matrices
f8c2672 mpeg2: store quantization matrices in zigzag-order

5 years agompeg2: fix decoding of 4K videos.
Gwenole Beauchesne [Wed, 30 Jan 2013 17:38:38 +0000 (18:38 +0100)]
mpeg2: fix decoding of 4K videos.

Account for slice_vertical_position_extension when vertical_size > 2800.

5 years agolegal: fix year for some copyright notices (2013).
Gwenole Beauchesne [Tue, 5 Feb 2013 10:04:47 +0000 (11:04 +0100)]
legal: fix year for some copyright notices (2013).

5 years agolegal: fix year for some copyright notices (2012).
Gwenole Beauchesne [Tue, 5 Feb 2013 10:00:55 +0000 (11:00 +0100)]
legal: fix year for some copyright notices (2012).

5 years agolegal: add Intel copyright on modified files.
Gwenole Beauchesne [Tue, 5 Feb 2013 09:59:27 +0000 (10:59 +0100)]
legal: add Intel copyright on modified files.

5 years agowayland: use a local event queue to avoid lock contention.
Gwenole Beauchesne [Mon, 28 Jan 2013 17:09:09 +0000 (18:09 +0100)]
wayland: use a local event queue to avoid lock contention.

5 years agowayland: fix thread-safe issues.
Gwenole Beauchesne [Mon, 28 Jan 2013 16:28:58 +0000 (17:28 +0100)]
wayland: fix thread-safe issues.

The Wayland API is not fully thread-safe and client applications shall
perform locking themselves on key functions. Besides, make sure to
release the lock if the _render() function fails.

5 years agowayland: really wait until the pending redraw completed.
Gwenole Beauchesne [Mon, 28 Jan 2013 15:37:28 +0000 (16:37 +0100)]
wayland: really wait until the pending redraw completed.

Introduce gst_vaapi_window_wayland_sync() helper function to wait for
the completion of the redraw request. Use it in _render() function to
actually block until the previous draw request is completed.

5 years agowayland: fix frame_redraw callback.
Gwenole Beauchesne [Wed, 23 Jan 2013 09:10:35 +0000 (10:10 +0100)]
wayland: fix frame_redraw callback.

The redraw callback needs to be attached to the surface prior to the
commit. Otherwise, the callback notifies the next surface repaint,
which is not the desired behaviour. i.e. we want to be notified for
the surface we have just filled.

Another isse was the redraw_pending was reset before the actual completion
of the frame redraw callback function, thus causing concurrency issues.
e.g. the callback could have been called again, but with a NULL buffer.

5 years agowayland: fix display sharing.
Gwenole Beauchesne [Mon, 28 Jan 2013 13:45:28 +0000 (14:45 +0100)]
wayland: fix display sharing.

When the Wayland display is shared, we still have to create our own local
shell and compositor objects, since they are not propagated from the cache.
Likewise, we also need to determine the display size or vaapisink would
fail to account for the display aspect ratio, and will try to create a 0x0

5 years agoh264: reset got_{sps,pps} when corrupted SPS/PPS headers are parsed.
Zhao Halley [Tue, 8 Jan 2013 21:40:46 +0000 (05:40 +0800)]
h264: reset got_{sps,pps} when corrupted SPS/PPS headers are parsed.

Reset got_{sps,pps} when corrupted SPS/PPS headers are parsed. This means
that no frame will be decoded until valid SPS/PPS headers are parsed again.
This also prevents from parsing slice headers with invalid data, and avoids
potential crashes.

5 years agovc1: handle CLOSED_ENTRY.
Gwenole Beauchesne [Wed, 23 Jan 2013 10:11:25 +0000 (11:11 +0100)]
vc1: handle CLOSED_ENTRY.

When CLOSED_ENTRY == 0, and if the B pictures that follow an entry-point
lack a reference anchor picture, these B pictures shall be discarded.

5 years agovc1: fix decoding of WMV3 videos in AVI format.
Wind Yuan [Fri, 11 Jan 2013 09:08:00 +0000 (17:08 +0800)]
vc1: fix decoding of WMV3 videos in AVI format.

The AVI demuxer (avidemux) does not set a proper "format" attribute
to the generated caps. So, try to recover the video codec format from
the "wmvversion" property instead.

Signed-off-by: Gwenole Beauchesne <>
5 years agovc1: review and report errors accordingly.
Gwenole Beauchesne [Tue, 22 Jan 2013 12:28:13 +0000 (13:28 +0100)]
vc1: review and report errors accordingly.

Use GST_ERROR() to report real errors instead of hiding them into

5 years agovc1: cope with latest codecparser changes.
Gwenole Beauchesne [Wed, 23 Jan 2013 09:25:52 +0000 (10:25 +0100)]
vc1: cope with latest codecparser changes.

Fix build with newer VC-1 codecparser where dqsbedge was renamed to
dqbedge, and now represents either DQSBEDGE or DQDBEDGE depending on
the actual value of DQPROFILE.

5 years agocodecparsers: update to gst-vaapi-branch commit 35053b8.
Gwenole Beauchesne [Fri, 25 Jan 2013 09:40:18 +0000 (10:40 +0100)]
codecparsers: update to gst-vaapi-branch commit 35053b8.

aeb898b vc1: fix bitplanes decoding (DIFF6 or NORM6 residual bytes)
63e3344 vc1: fix bitplanes decoding (DIFF6 or NORM6)
b0a9372 vc1: add API to parse slice headers
773f3d1 vc1: fix bitplanes decoding
870e083 vc1: simplify GstVC1VopDquant structure
bc0d65e vc1: fix VOPDQUANT parser for DQUANT == 2
dcd3abd vc1: fix calculation of ALTPQUANT
73ca0b7 vc1: fix parser for DQPROFILE in VOPDQUANT
8840c2d h264: zero-initialize SPS VUI parameters

5 years agocodecparsers: update to gst-vaapi-rebased commit b47983a.
Gwenole Beauchesne [Mon, 14 Jan 2013 15:06:54 +0000 (16:06 +0100)]
codecparsers: update to gst-vaapi-rebased commit b47983a.

b47983a h264: add inferred value for slice_beta_offset_div2

5 years agoBump version for development.
Gwenole Beauchesne [Tue, 18 Dec 2012 09:32:20 +0000 (10:32 +0100)]
Bump version for development.

5 years ago0.4.2. 0.4.2
Gwenole Beauchesne [Tue, 18 Dec 2012 09:31:52 +0000 (10:31 +0100)]

5 years agoNEWS: updates.
Gwenole Beauchesne [Mon, 17 Dec 2012 13:57:44 +0000 (14:57 +0100)]
NEWS: updates.

5 years agoimage: fix GstVaapiImage map and unmap.
Gwenole Beauchesne [Tue, 20 Nov 2012 13:36:29 +0000 (14:36 +0100)]
image: fix GstVaapiImage map and unmap.

Fix gst_vaapi_image_map() to return TRUE and the GstVaapiImageRaw
structure correctly filled in if the image was already mapped.
Likewise, make gst_vaapi_image_unmap() return TRUE if the image
was already unmapped.

5 years agompeg4: fix decoding at end-of-stream.
Wind Yuan [Fri, 12 Oct 2012 08:50:09 +0000 (16:50 +0800)]
mpeg4: fix decoding at end-of-stream.

Signed-off-by: Gwenole Beauchesne <>
5 years agompeg4: fix size argument to gst_adapter_flush().
Wind Yuan [Fri, 12 Oct 2012 08:44:05 +0000 (16:44 +0800)]
mpeg4: fix size argument to gst_adapter_flush().

Flush only consumed_size bytes from the GstAdapter.

Signed-off-by: Gwenole Beauchesne <>
5 years agotests: add test for MPEG-4:2 decoding.
Gwenole Beauchesne [Mon, 17 Dec 2012 10:51:17 +0000 (02:51 -0800)]
tests: add test for MPEG-4:2 decoding.

5 years agoh264: initialize VA context before allocating the first slice.
Gwenole Beauchesne [Mon, 17 Dec 2012 12:42:29 +0000 (04:42 -0800)]
h264: initialize VA context before allocating the first slice.

Fix decode_slice() to ensure a VA context exists prior to creating a
new GstVaapiSliceH264, which invokes vaCreateBuffer() with some VA
context ID. i.e. the latter was not initialized, thus causing failures
on Cedar Trail for example.

5 years agoconfigure: install plugin elements in GST_PLUGIN_PATH, if set.
Zhao Halley [Wed, 5 Dec 2012 01:15:32 +0000 (09:15 +0800)]
configure: install plugin elements in GST_PLUGIN_PATH, if set.

If GST_PLUGIN_PATH environment variable exists and points to a valid
directory, then use it as the system installation path for gst-vaapi
plugin elements.

Signed-off-by: Gwenole Beauchesne <>
5 years agolibs: only export gst_vaapi_*() symbols.
Gwenole Beauchesne [Mon, 17 Dec 2012 12:15:53 +0000 (04:15 -0800)]
libs: only export gst_vaapi_*() symbols.

This fixes symbol clashes between the gst-vaapi built-in codecparsers/
library and the system-provided one, mainly used by videoparses/. Now,
only symbols with the gst_vaapi_* prefix will be exported, if they are
not marked as "hidden" to libgstvaapi.

5 years agolibs: fix compatibility with glib 2.28.
Gwenole Beauchesne [Mon, 17 Dec 2012 08:41:24 +0000 (09:41 +0100)]
libs: fix compatibility with glib 2.28.

Always prefer non deprecated APIs by default and provide compatibility
glue for older glib versions when necessary.

5 years agolibs: use glib >= 2.32 semantics for mutexes.
Gwenole Beauchesne [Mon, 17 Dec 2012 09:10:55 +0000 (10:10 +0100)]
libs: use glib >= 2.32 semantics for mutexes.

Use glib >= 2.32 semantics for GMutex and GRecMutex wrt. initialization
and termination. Basically, the new mutex objects can be used as static
mutex objects from the deprecated APIs, e.g. GStaticMutex and GStaticRecMutex.

5 years agovaapidecode: adopt non-deprecrated glib locking primitive pattern.
Rob Bradford [Thu, 4 Oct 2012 16:39:53 +0000 (17:39 +0100)]
vaapidecode: adopt non-deprecrated glib locking primitive pattern.

The use of heap allocated GMutex/GCond is deprecated. Instead place them
inside the structure they are locking.

These changes switch to use g_mutex_init/g_cond_init rather than the heap
allocation functions.

Because we cannot test for a NULL pointer for the GMutex/GCond we must
initialise inside the GObject _init function and clear inside the _finalize
which is guaranteed to only be called once and after the object is no longer
in use.

5 years agovideobuffer: fix memory leak for surface and image.
Wind Yuan [Tue, 30 Oct 2012 05:15:45 +0000 (13:15 +0800)]
videobuffer: fix memory leak for surface and image.

Fix reference leak of surface and image in GstVaapiVideoBuffer wrapper,
thus resulting on actual memory leak of GstVaapiImage when using them
for downloads/uploads from VA surfaces and more specifically surfaces
when the pipeline is shutdown. i.e. vaTerminate() was never called
because the resources were not unreferenced, and thus not deallocated
in the end.

Signed-off-by: Gwenole Beauchesne <>
5 years agoBump version for development.
Gwenole Beauchesne [Tue, 27 Nov 2012 08:56:08 +0000 (09:56 +0100)]
Bump version for development.

5 years agoMark release. 0.4.1
Gwenole Beauchesne [Tue, 27 Nov 2012 08:55:31 +0000 (09:55 +0100)]
Mark release.

5 years ago0.4.1.
Gwenole Beauchesne [Tue, 27 Nov 2012 08:40:11 +0000 (09:40 +0100)]

5 years agoNEWS: updates.
Gwenole Beauchesne [Mon, 19 Nov 2012 09:04:52 +0000 (10:04 +0100)]
NEWS: updates.

5 years agowayland: port to 1.0 version of the protocol.
Rob Bradford [Fri, 2 Nov 2012 18:18:37 +0000 (18:18 +0000)]
wayland: port to 1.0 version of the protocol.

This patch updates to relect the 1.0 version of the protocol. The main
changes are the switch to wl_registry for global object notifications
and the way that the event queue and file descriptor is processed.

Signed-off-by: Gwenole Beauchesne <>
5 years agoh264: fix picture size in macroblocks.
Gwenole Beauchesne [Fri, 16 Nov 2012 17:00:10 +0000 (18:00 +0100)]
h264: fix picture size in macroblocks.

The picture size signalled by sps->{width,height} is the actual size with
cropping applied, not the original size derived from pic_width_in_mbs_minus1
and pic_height_in_map_units_minus1. VA driver expects that original size,

There is another issue pending: frame cropping information needs to be
taken care of.

5 years agoh264: start decoding slices after first SPS/PPS activation.
Gwenole Beauchesne [Wed, 14 Nov 2012 17:40:47 +0000 (18:40 +0100)]
h264: start decoding slices after first SPS/PPS activation.

Only start decoding slices when at least one SPS and PPS got activated.
This fixes cases when a source represents a substream of another stream
and no SPS and PPS was inserted before the first slice of the generated

5 years agoh264: fix VAPictureParameterBufferH264.ReferenceFrames[] construction.
Gwenole Beauchesne [Wed, 14 Nov 2012 13:25:34 +0000 (14:25 +0100)]
h264: fix VAPictureParameterBufferH264.ReferenceFrames[] construction.

... for interlaced streams. The short_ref[] and long_ref[] arrays may
contain up to 32 fields but VA ReferenceFrames[] array expects up to
16 reference frames, thus including both fields.

5 years agoh264: fix interlaced stream decoding with MMCO.
Gwenole Beauchesne [Wed, 14 Nov 2012 09:27:12 +0000 (10:27 +0100)]
h264: fix interlaced stream decoding with MMCO.

Fix decoding of interlaced streams when adaptive_ref_pic_marking_mode_flag
is equal to 1, i.e. when memory management control operations are used. In
particular, when field_pic_flag is set to 0, the new reference flags shall
be applied to both fields.

5 years agoh264: add initial support for interlaced streams.
Gwenole Beauchesne [Tue, 13 Nov 2012 16:14:39 +0000 (17:14 +0100)]
h264: add initial support for interlaced streams.

Decoded frames are only output when they are complete, i.e. when both
fields are decoded. This also means that the "interlaced" caps is not
propagated to vaapipostproc or vaapisink elements. Another limitation
is that interlaced bitstreams with MMCO are unlikely to work.

5 years agoh264: split remove_reference_at() into finer units.
Gwenole Beauchesne [Tue, 13 Nov 2012 15:35:30 +0000 (16:35 +0100)]
h264: split remove_reference_at() into finer units.

Split remove_reference_at() into a function that actually removes the
specified entry from the short-term or long-term reference picture array,
and a function that sets reference flags to the desired value, possibly
zero. The latters marks the picture as "unused for reference".

5 years agodecoder: fix gst_vaapi_picture_new_field() object type.
Gwenole Beauchesne [Tue, 23 Oct 2012 12:04:22 +0000 (14:04 +0200)]
decoder: fix gst_vaapi_picture_new_field() object type.

Fix gst_vaapi_picture_new_field() to preserve the original picture type.
e.g. gst_vaapi_picture_new_field() with a GstVaapiPictureH264 argument
shall generate a GstVaapiPictureH264 object.

5 years agoh264: add picture structure for reference picture marking process.
Gwenole Beauchesne [Tue, 13 Nov 2012 13:04:31 +0000 (14:04 +0100)]
h264: add picture structure for reference picture marking process.

Introduce new `structure' field to the H.264 specific picture structure
so that to simplify the reference picture marking process. That local
picture structure is derived from the original picture structure, as
defined by the syntax elements field_pic_flag and bottom_field_flag.

5 years agoh264: introduce new frame store structure.
Gwenole Beauchesne [Fri, 2 Nov 2012 14:14:58 +0000 (15:14 +0100)]
h264: introduce new frame store structure.

The frame store represents a Decoded Picture Buffer entry, which can
hold up to two fields. So far, the frame store is only used to hold
full frames.

5 years agoh264: minor clean-ups.
Gwenole Beauchesne [Wed, 31 Oct 2012 15:37:14 +0000 (16:37 +0100)]
h264: minor clean-ups.

Move DPB flush up if the current picture to decode is an IDR. Besides,
don't bother to check for IDR pictures in dpb_add() function since an
explicit DPB flush was already performed in this case.

5 years agoh264: simplify reference picture marking process.
Gwenole Beauchesne [Wed, 31 Oct 2012 13:24:09 +0000 (14:24 +0100)]
h264: simplify reference picture marking process.

... to build the short_ref[] and long_ref[] lists from the DPB, instead
of maintaining them separately. This avoids refs/unrefs while making it
possible to generate the list based on the actual picture structure.

This also ensures that the list of generated ReferenceFrames[] actually
matches what reference frames are available in the DPB. i.e. short_ref[]
and long_ref[] entries are implied from the DPB, so there is no risk of
having "dangling" references.

5 years agoh264: introduce per-field POC in GstVaapiPictureH264.
Gwenole Beauchesne [Wed, 31 Oct 2012 10:52:03 +0000 (11:52 +0100)]
h264: introduce per-field POC in GstVaapiPictureH264.

Use the POC member available in the GstVaapiPicture base class and
get rid of the dependency on the local VAPictureH264 TopFieldOrderCnt
and BottomFieldOrderCnt. Rather, use a simple field_poc[] array
initialized to INT_MAX, so that to simplify picture POC calculation
for non frame pictures.

5 years agoh264: introduce GST_VAAPI_PICTURE_{SHORT,LONG}_TERM_REFERENCE flags.
Gwenole Beauchesne [Wed, 31 Oct 2012 10:45:14 +0000 (11:45 +0100)]

Further get rid of GstVaapiPictureH264-local VAPictureH264.flags for
reference bits, thus simplifying the reference picture marking process
to only track a single set of reference flags. Also introduce a new
long_term_frame_idx member.

5 years agoh264: introduce GST_VAAPI_PICTURE_FLAG_IDR flag.
Gwenole Beauchesne [Wed, 31 Oct 2012 10:33:40 +0000 (11:33 +0100)]
h264: introduce GST_VAAPI_PICTURE_FLAG_IDR flag.

5 years agoh264: fill in GstVaapiPicture structure.
Gwenole Beauchesne [Wed, 31 Oct 2012 09:56:15 +0000 (10:56 +0100)]
h264: fill in GstVaapiPicture structure.

... and get rid of local VAPictureH264.flags fields in GstVaapiPictureH264.

5 years agoh264: add vaapi_fill_picture() helper.
Gwenole Beauchesne [Wed, 31 Oct 2012 10:07:48 +0000 (11:07 +0100)]
h264: add vaapi_fill_picture() helper.

Add vaapi_fill_picture() helper function to convert GstVaapiPictureH264
to VAPictureH264 structure. This is preparatory work to get rid of the
local VAPictureH264 member in GstVaapiPictureH264.

5 years agoh264: fix activation order of picture and sequence parameters.
Gwenole Beauchesne [Fri, 26 Oct 2012 14:12:05 +0000 (16:12 +0200)]
h264: fix activation order of picture and sequence parameters.

Delay ensure_context() until we actually need a VA context for allocating
new VA surfaces, and then GstVaapiPictures, but also when a real activation
of a new picture parameter set occurs, thus also implying an activation
of the related sequence parameter set.

The most important thing was to drop the global pps and sps pointers since
they may not have matched the currently activated picture parameter or
sequence parameter sets at the specified decode point.

Anoter positive side-effect is that this cleans up all occurrences of
decode_current_picture() to only keep those useful in decode_picture(),
before a new picture is allocated, or in decode_sequence_end() when
an end-of-stream or end-of-sequence condition occurred.

5 years agoh264: fix detection of picture boundaries.
Gwenole Beauchesne [Wed, 24 Oct 2012 16:23:09 +0000 (18:23 +0200)]
h264: fix detection of picture boundaries.

Strictly follow the standard ( to detect the first VCL NAL
unit of a primary coded picture.

5 years agoh264: optimize handling of scaling lists.
Gwenole Beauchesne [Tue, 23 Oct 2012 12:50:14 +0000 (14:50 +0200)]
h264: optimize handling of scaling lists.

Don't copy scaling lists twice to an intermediate state. Rather, directly
use the scaling lists from GstH264PPS since they would match those provided
by SPS header, if necessary. i.e. if PPS-specific scaling lists are not
available in the bitstream.

5 years agoh264: simplify code when MMCO is 5.
Gwenole Beauchesne [Tue, 23 Oct 2012 08:33:50 +0000 (10:33 +0200)]
h264: simplify code when MMCO is 5.

Remove exit_picture() and exit_picture_poc() since PicOrderCnt(CurrPic)
is now updated accordingly to the standard. Besides, MMCO = 5 specific
operations are moved up to exec_ref_pic_marking_adaptive_mmco_5().

5 years agoh264: fix MMCO-based reference picture marking process.
Gwenole Beauchesne [Mon, 22 Oct 2012 09:52:13 +0000 (11:52 +0200)]
h264: fix MMCO-based reference picture marking process.

Fix adaptive memory control decoded reference picture marking process
implementation for operations 2 to 6, thus also fixing support for
long-term reference pictures.

5 years agoh264: move MMCO handlers out of the loop (cosmetics).
Gwenole Beauchesne [Mon, 22 Oct 2012 08:50:29 +0000 (10:50 +0200)]
h264: move MMCO handlers out of the loop (cosmetics).

This change only splits each individual MMCO handler into several functions
dedicated for each operation. This is needed to perform further work later

5 years agoh264: add flag to compile with strict DPB ordering mode.
Gwenole Beauchesne [Tue, 16 Oct 2012 14:52:04 +0000 (16:52 +0200)]
h264: add flag to compile with strict DPB ordering mode.

Allow build with strict DPB ordering mode whereby evicted entries
are replaced by the next entries, in order instead of optimizing
it away with the last entry in the DPB.

This is only useful for debugging purpose, against a reference SW
decoder for example.

5 years agoh264: drop extra code covered by built-in codecparsers.
Gwenole Beauchesne [Tue, 16 Oct 2012 14:46:17 +0000 (16:46 +0200)]
h264: drop extra code covered by built-in codecparsers.

GstH264SliceHdr.n_emulation_prevention_bytes is bound to exist now that
a newer version of codecparsers/ are used if the system provided one is
now recent enough to have those required extensions.

5 years agoh264: use pixel-aspect-ratio from SPS header.
Simon Farnsworth [Thu, 27 Sep 2012 17:05:46 +0000 (18:05 +0100)]
h264: use pixel-aspect-ratio from SPS header.

Propagate pixel-aspect-ratio determined by the GStreamer codecparser
from the sequence headers.

Signed-off-by: Simon Farnsworth <>
Signed-off-by: Gwenole Beauchesne <>
5 years agoh264: add decode_nalu() helper function.
Gwenole Beauchesne [Wed, 10 Oct 2012 08:35:20 +0000 (10:35 +0200)]
h264: add decode_nalu() helper function.

Split decode_buffer() into the core infrastructure that determines
the NAL units contained in the adapter and the actual function that
decodes the NAL unit.

5 years agoh264: fix end-of-stream conditions (flush).
Gwenole Beauchesne [Wed, 10 Oct 2012 08:31:39 +0000 (10:31 +0200)]
h264: fix end-of-stream conditions (flush).

Decode pending data in the adapter prior to processing the actual
code for end-of-stream.

5 years agovc1: use framerate information from bitstream parser.
Gwenole Beauchesne [Thu, 11 Oct 2012 13:04:12 +0000 (15:04 +0200)]
vc1: use framerate information from bitstream parser.

5 years agovc1: use pixel-aspect-ratio from bitstream parser.
Simon Farnsworth [Thu, 27 Sep 2012 17:05:46 +0000 (18:05 +0100)]
vc1: use pixel-aspect-ratio from bitstream parser.

Signed-off-by: Simon Farnsworth <>
Signed-off-by: Gwenole Beauchesne <>
5 years agompeg2: fix PAR calculation from commit 132922d.
Sreerenj Balachandran [Thu, 8 Nov 2012 09:40:47 +0000 (11:40 +0200)]
mpeg2: fix PAR calculation from commit 132922d.

Invoke gst_mpeg_video_finalise_mpeg2_sequence_header() to get the
correct PAR values. While doing so, require a newer version of the
bitstream parser library.

Note: it may be necessary to also parse the Sequence_Display_Extension()

Signed-off-by: Sreerenj Balachandran <>
Signed-off-by: Gwenole Beauchesne <>
5 years agompeg2: use pixel-aspec-ratio information from bitstream parser.
Simon Farnsworth [Thu, 27 Sep 2012 17:05:46 +0000 (18:05 +0100)]
mpeg2: use pixel-aspec-ratio information from bitstream parser.

Signed-off-by: Simon Farnsworth <>
Signed-off-by: Gwenole Beauchesne <>
5 years agompeg2: add decode_packet() helper function.
Gwenole Beauchesne [Wed, 10 Oct 2012 07:45:03 +0000 (09:45 +0200)]
mpeg2: add decode_packet() helper function.

Split decode_buffer() into the core infrastructure that determines
the packets contained in the adapter and the actual function that
decodes the packet data.

5 years agompeg2: fix end-of-stream conditions (flush).
Gwenole Beauchesne [Tue, 9 Oct 2012 13:34:18 +0000 (15:34 +0200)]
mpeg2: fix end-of-stream conditions (flush).

Decode pending data in the adapter prior to processing the actual
code for end-of-stream. Initial code from Feng Yuan.

5 years agompeg2: fix memory leak of empty packets.
Gwenole Beauchesne [Tue, 9 Oct 2012 13:40:49 +0000 (15:40 +0200)]
mpeg2: fix memory leak of empty packets.

Fix memory leakage of empty packets, i.e. packets that only contain
the start code prefix. In particular, free empty user-data packets.

Besides, the codec parser will already fail gracefully if the packet
to parse does not have the minimum required size. So, we can also
completely drop the block of code that used to handle packets of size 4
(including the start code).

5 years agompeg2: fix return value for "no-data" conditions.
Gwenole Beauchesne [Tue, 9 Oct 2012 13:01:38 +0000 (15:01 +0200)]
mpeg2: fix return value for "no-data" conditions.

Fix return value when the second scan for start code fails. This means
there is not enough data to determine the full extents of the current
packet and the function shall return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA
in this case, instead of GST_VAAPI_DECODER_STATUS_SUCCESS.

5 years agodecoder: refine semantics of gst_vaapi_decoder_put_buffer().
Gwenole Beauchesne [Tue, 9 Oct 2012 12:48:00 +0000 (14:48 +0200)]
decoder: refine semantics of gst_vaapi_decoder_put_buffer().

Improve the semantics for gst_vaapi_decoder_put_buffer() when an empty
buffer is passed on. An empty buffer is a buffer with a NULL data pointer
or with a size equals to zero. In this case, that buffer is simply
skipped and the function returns TRUE. A NULL buffer argument still
marks the end-of-stream.

5 years agodecoder: drop unused functions.
Gwenole Beauchesne [Tue, 9 Oct 2012 12:40:00 +0000 (14:40 +0200)]
decoder: drop unused functions.

5 years agovaapidecode: flush buffers when receiving EOS.
Wind Yuan [Mon, 27 Aug 2012 02:29:04 +0000 (22:29 -0400)]
vaapidecode: flush buffers when receiving EOS.

Signed-off-by: Gwenole Beauchesne <>
5 years agovaapidecode: fix compiler warnings.
Gwenole Beauchesne [Wed, 17 Oct 2012 12:52:35 +0000 (14:52 +0200)]
vaapidecode: fix compiler warnings.

Don't care of the return value for gst_vaapi_decoder_put_buffer()
during destruction of the element. Don't print out (uninitialised)
error code when allocation of video buffer failed.

5 years agoAdd codecparsers submodule.
Gwenole Beauchesne [Thu, 11 Oct 2012 08:03:14 +0000 (10:03 +0200)]
Add codecparsers submodule.

Backport from git master:
c3b343f Add codecparsers submodule
cee782a jpeg: use submodule sources
022e99e h264: use submodule sources
d42d838 fix generation of symlinks
d453297 update to gst-vaapi-rebased commit 73d6aab
18245b4 always build the VC-1 parser library
9ab3ce2 always build parserutils first

5 years agoFix build with the GNU gold linker.
Gwenole Beauchesne [Thu, 15 Nov 2012 14:00:43 +0000 (15:00 +0100)]
Fix build with the GNU gold linker.

In particular, fix libgstvaapi-glx DSO dependencies to include libgstbase
and libgstvideo libs, e.g. for gst_video_buffer_get_overlay_composition().

5 years ago.gitignore: updates.
Gwenole Beauchesne [Thu, 11 Oct 2012 12:17:12 +0000 (14:17 +0200)]
.gitignore: updates.

5 years agoautogen: fix check for gtkdocize and autoreconf.
Gwenole Beauchesne [Thu, 11 Oct 2012 11:40:37 +0000 (13:40 +0200)]
autogen: fix check for gtkdocize and autoreconf.

If gtkdocize or autoreconf programs were not found, then the
script would fail to report that correctly because test -z was not passed
any argument (empty string "" in this case).

5 years agoconfigure: generate bzip2 tarballs in ustar format by default.
Gwenole Beauchesne [Wed, 17 Oct 2012 13:42:17 +0000 (15:42 +0200)]
configure: generate bzip2 tarballs in ustar format by default.

5 years agoBump version for development.
Gwenole Beauchesne [Fri, 5 Oct 2012 12:10:54 +0000 (14:10 +0200)]
Bump version for development.

5 years ago0.4.0. 0.4.0
Gwenole Beauchesne [Fri, 5 Oct 2012 11:51:54 +0000 (13:51 +0200)]

5 years agodebian: fix make dist for packaging.
Gwenole Beauchesne [Fri, 5 Oct 2012 11:36:27 +0000 (13:36 +0200)]
debian: fix make dist for packaging.

5 years agowayland: cosmetics (remove tabs).
Gwenole Beauchesne [Fri, 5 Oct 2012 10:06:27 +0000 (12:06 +0200)]
wayland: cosmetics (remove tabs).

5 years agowayland: add support for windowed mode.
Rob Bradford [Thu, 4 Oct 2012 16:39:52 +0000 (17:39 +0100)]
wayland: add support for windowed mode.

Rather than always making the surface fullscreen instead implement the
set_fullscreen vfunc on GstVaapiWindow and then set the shell surface
fullscreen on not depending on that.

Reviewed-by: Joe Konno <>
Signed-off-by: Gwenole Beauchesne <>
5 years agoFix and document build dependencies better.
Gwenole Beauchesne [Fri, 28 Sep 2012 15:54:03 +0000 (17:54 +0200)]
Fix and document build dependencies better.

5 years agodebian: fix GStreamer build dependencies.
Gwenole Beauchesne [Fri, 28 Sep 2012 15:41:42 +0000 (17:41 +0200)]
debian: fix GStreamer build dependencies.

5 years agodebian: fix Wayland build dependencies.
Gwenole Beauchesne [Fri, 28 Sep 2012 15:39:43 +0000 (17:39 +0200)]
debian: fix Wayland build dependencies.

5 years agodebian: fix conditional build of packages.
Gwenole Beauchesne [Fri, 28 Sep 2012 15:38:17 +0000 (17:38 +0200)]
debian: fix conditional build of packages.

Make it still possible to build package even if one of the build dependencies
for a specific video backend is not available.

5 years agoutils: drop unused GLX helpers.
Gwenole Beauchesne [Thu, 27 Sep 2012 09:08:58 +0000 (11:08 +0200)]
utils: drop unused GLX helpers.

Remove helpers for GL_ARB_fragment_program and GL_ARB_multitexture
extensions since they are not used throughout gstreamer-vaapi.

5 years agoutils: fix build with <GL/glext.h> version >= 85.
Gwenole Beauchesne [Thu, 27 Sep 2012 09:04:24 +0000 (11:04 +0200)]
utils: fix build with <GL/glext.h> version >= 85.

Mesa recently updated the <GL/glext.h> header version to Khronos version 85.
This caused the PFNGLMULTITEXCOORD2FPROC definition to be moved out of the
GL_VERSION_1_3_DEPRECATED block. However, since <GL/gl.h> also defines
GL_VERSION_1_3 to 1, the definitions in <GL/glext.h> are then not enabled,
thus leaving PFNGLMULTITEXCOORD2FPROC undefined as well.

Provide a PFNGLMULTITEXCOORD2FPROC replacement as an interim solution for
newer versions of the <GL/glext.h> header.

5 years agoconfigure: update VA-API version requirements.
Gwenole Beauchesne [Wed, 26 Sep 2012 14:33:16 +0000 (16:33 +0200)]
configure: update VA-API version requirements.

VA/DRM and VA/Wayland API are now promoted to VA-API 0.33.0 (libva 1.1.0).

6 years agoh264: review and report errors accordingly.
Gwenole Beauchesne [Fri, 21 Sep 2012 14:43:38 +0000 (16:43 +0200)]
h264: review and report errors accordingly.

Use GST_ERROR() to report real errors instead of hiding them into

6 years agoh264: exclusively use GstAdapter, drop sub-buffer hack.
Gwenole Beauchesne [Thu, 20 Sep 2012 15:58:21 +0000 (17:58 +0200)]
h264: exclusively use GstAdapter, drop sub-buffer hack.

Maintaining the sub-buffer is rather suboptimal especially since we
were also maintaining a GstAdapter. Now, we only use the GstAdapter
thus requiring minor extra parsing when receiving avcC buffers.

6 years agoREADME: updates.
Gwenole Beauchesne [Thu, 20 Sep 2012 14:18:27 +0000 (16:18 +0200)]
README: updates.

6 years agoNEWS: updates.
Gwenole Beauchesne [Thu, 20 Sep 2012 14:02:39 +0000 (16:02 +0200)]
NEWS: updates.

6 years agodebian: fix packaging on recent Ubuntu platforms.
Gwenole Beauchesne [Thu, 20 Sep 2012 12:38:15 +0000 (14:38 +0200)]
debian: fix packaging on recent Ubuntu platforms.

Use explicit GStreamer plugins path.

6 years agodocs: fix build for make dist.
Gwenole Beauchesne [Mon, 17 Sep 2012 15:55:43 +0000 (17:55 +0200)]
docs: fix build for make dist.