9 years ago* Bugfix when fetching parts and messages (merged r3682 from trunk). modest-diablo-pe2
Jose Dapena Paz [Wed, 26 Nov 2008 14:53:00 +0000 (14:53 +0000)]
* Bugfix when fetching parts and messages (merged r3682 from trunk).

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3828 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoIDLE fixes for the case when connection fails
Sergio Villar Senin [Wed, 26 Nov 2008 08:52:50 +0000 (08:52 +0000)]
IDLE fixes for the case when connection fails

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3827 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago Added some extra locking to prevent two sending threads running at the same time
Sergio Villar Senin [Wed, 19 Nov 2008 14:45:25 +0000 (14:45 +0000)]
Added some extra locking to prevent two sending threads running at the same time

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3813 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago Fixes a crash when decoding mime parts while purging them. Merged from trunk r3811
Sergio Villar Senin [Wed, 19 Nov 2008 14:31:24 +0000 (14:31 +0000)]
 Fixes a crash when decoding mime parts while purging them. Merged from trunk r3811

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3812 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
Jose Dapena Paz [Wed, 19 Nov 2008 14:05:19 +0000 (14:05 +0000)]
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
  Remove calls to camel_imap_folder_start_idle that could happen even
  when idle was locked by an operation, causing hangs.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3809 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoComplete rework of the lock behavior of Tinymail (camel) imap IDLE
Jose Dapena Paz [Mon, 10 Nov 2008 14:08:37 +0000 (14:08 +0000)]
Complete rework of the lock behavior of Tinymail (camel) imap IDLE

The problem we want to fix is: sometimes IDLE thread causes
deathlocks (connect lock, idle lock, g_thread_join, etc).
This happens easily when there are disconnects, or
when we switch fast among folders.

The main changes are:
* Provided a count of reasons to stop idle because of connect lock.
* If a caller has taken connect lock, then it should do the send done
  stuff itself.
* Idle thread has the connect lock always when it's in the body of the
* In any point, if we want to  take the connect lock, then we should
  stop idle. No partial idle can be alive when we want to connect.
* Camel queue enables/disables the possibility to start idle. That's
  for avoiding running IDLE / SEND DONE in the middle of queued

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3801 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* Specify with defines the IDLE tick time (time between iterations in
Jose Dapena Paz [Mon, 10 Nov 2008 12:56:11 +0000 (12:56 +0000)]
* Specify with defines the IDLE tick time (time between iterations in
  idle loop) and IDLE default delay (time between IDLE/DONE cycles if no
  event happens).
* Fix the IDLE delay account parameter to take into account the tick

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3799 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Merged from trunk r3776, do not write in chunks in the filesystem
Sergio Villar Senin [Mon, 20 Oct 2008 10:07:35 +0000 (10:07 +0000)]
* Merged from trunk r3776, do not write in chunks in the filesystem

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3782 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Merged from trunk r3777
Sergio Villar Senin [Mon, 20 Oct 2008 10:04:23 +0000 (10:04 +0000)]
* Merged from trunk r3777

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3781 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* Disable IMAP IDLE support as it's still broken and
Jose Dapena Paz [Mon, 20 Oct 2008 09:17:19 +0000 (09:17 +0000)]
* Disable IMAP IDLE support as it's still broken and
  can cause hangs.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3780 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Fixes NB#84845, merged from tinymail trunk r3678
Sergio Villar Senin [Mon, 6 Oct 2008 15:36:44 +0000 (15:36 +0000)]
* Fixes NB#84845, merged from tinymail trunk r3678

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3774 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c: added
Jose Dapena Paz [Tue, 30 Sep 2008 09:11:05 +0000 (09:11 +0000)]
* libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c: added
  some code that properly checks the result of the call to
  NSS_InitReadWrite (merged from trunk r3720).

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3773 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoBackported from trunk:
Jose Dapena Paz [Fri, 26 Sep 2008 09:07:12 +0000 (09:07 +0000)]
Backported from trunk:
* Adding extra checks on writing to summary on disk, to make sure we
  detect if summary save_rewrite process was complete, and then, we can
  load again the summary or consider this corrupt.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3772 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c
Jose Dapena Paz [Tue, 16 Sep 2008 15:25:31 +0000 (15:25 +0000)]
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c
  (let_idle_die): do a trylock in connect_lock instead of lock, so that
  we can avoid interlocks on stop_idle called from imap_command_start
  (merged from trunk r3763).

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3764 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Fixes NB#86831
Sergio Villar Senin [Thu, 11 Sep 2008 16:26:35 +0000 (16:26 +0000)]
* Fixes NB#86831

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3762 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoFixed an invalid g_free
Sergio Villar Senin [Wed, 10 Sep 2008 16:42:13 +0000 (16:42 +0000)]
Fixed an invalid g_free

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3761 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* libtinymail-camel/tny-camel-mime-part.c
Jose Dapena Paz [Thu, 4 Sep 2008 22:00:41 +0000 (22:00 +0000)]
* libtinymail-camel/tny-camel-mime-part.c
  (tny_camel_mime_part_decode_to_stream_async_default): make it really
  asynchronous, doing the operation in a separate thread.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3758 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoMerged bugfix from trunk (r3754)
Sergio Villar Senin [Wed, 3 Sep 2008 09:14:48 +0000 (09:14 +0000)]
Merged bugfix from trunk (r3754)

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3755 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoMerged fix for bug 86637 from trunk
Vivek Sekar [Wed, 27 Aug 2008 07:12:12 +0000 (07:12 +0000)]
Merged fix for bug 86637 from trunk

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3744 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoreverted to revision 3730, for use with week 34 release.
Vivek Sekar [Tue, 19 Aug 2008 09:26:36 +0000 (09:26 +0000)]
reverted to revision 3730, for use with week 34 release.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3738 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoMerged fix for bug 86637 from trunk.
Vivek Sekar [Mon, 11 Aug 2008 08:04:52 +0000 (08:04 +0000)]
Merged fix for bug 86637 from trunk.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3735 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Ported a POP3 fix from trunk
Sergio Villar Senin [Mon, 28 Jul 2008 17:54:39 +0000 (17:54 +0000)]
* Ported a POP3 fix from trunk

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3729 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago * Ported bug fix from trunk
Sergio Villar Senin [Wed, 23 Jul 2008 11:45:54 +0000 (11:45 +0000)]
* Ported bug fix from trunk

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3727 d4f517bd-a70b-0410-9f68-c17655437c52

9 years ago* libtinymail-camel/camel-lite/camel/providers/imap/camep-imap-store.c:
Jose Dapena Paz [Mon, 21 Jul 2008 12:00:36 +0000 (12:00 +0000)]
* libtinymail-camel/camel-lite/camel/providers/imap/camep-imap-store.c:
  Trivial fix for current folder weak reference code.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3724 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoBackported from trunk.
Jose Dapena Paz [Wed, 16 Jul 2008 13:42:30 +0000 (13:42 +0000)]
Backported from trunk.
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
        Added fetching aol specific imap capability.
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.[ch]:
        Now we use FETCH instead of SEARCH for getting the UID's
        when the server is AOL.
        Added an extra check in imap_get_uids. If server gives a list
        including sequence numbers we didn't request, we ignore them.
        This should fix the AOL problem fetching headers.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3722 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoBackported from tinymail trunk r3717 and r3718.
Jose Dapena Paz [Fri, 4 Jul 2008 08:58:06 +0000 (08:58 +0000)]
Backported from tinymail trunk r3717 and r3718.
* libtinymail-camel/camel-lite/camel/camel.c:
  Drop usage of PR_Cleanup on shutting down camel, as this is not safe,
  nor required. This method is responsible for freeing the common
  threads management code, including the lock that's accessed on the
  crash in __nptl_deallocate_tsd.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3719 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoFix backported from trunk r3715
Jose Dapena Paz [Wed, 2 Jul 2008 20:34:09 +0000 (20:34 +0000)]
Fix backported from trunk r3715
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
        * Avoid joining idle_thread from itself causing a crash/lock.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3716 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoMerged fixes from trunk r3711 and r3712
Jose Dapena Paz [Tue, 1 Jul 2008 16:11:10 +0000 (16:11 +0000)]
Merged fixes from trunk r3711 and r3712
* libtinymail-camel/camel-lite/camel/camel-provider.[ch]:
        * Now providers offer a new shutdown handler, that will be
          called on shutting down camel.
* libtinymail-camel/camel-lite/camel/camel.c:
        * Use the providers shutdown handler on shutting down camel.
* libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-provider.c:
        * Implement new provider shutdown handler, to kill the login delay
          threads on shutting down tinymail.
* libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-store.[ch]:
        * New method to kill the login delay thread. This is used to kill
          the thread on shutting down tinymail.
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-provider.c:
        * Set as NULL the default shutdown handler.
* libtinymail-camel/tny-camel-pop-store-account.c:
        * Manage properly the internal inbox reference to avoid leaking it.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3714 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoMerge of trunk patches r3664, r3665, r3704 and r3705.
Jose Dapena Paz [Tue, 1 Jul 2008 13:47:45 +0000 (13:47 +0000)]
Merge ... trunk patches r3664, r3665, r3704 and r3705.
* libtinymail-camel/tny-camel-queue.c: Letting the thread wait for
        more items instead of exiting
* libtinymail-camel/tny-camel-folder.c:
        * Fix camel operation references
* libtinymail-camel/tny-camel-bs-mime-part.c:
        * Fix camel operation references
* libtinymail-camel/tny-camel-queue.c:
        * Make queue reference to account be weak.
* libtinymail-camel/tny-camel-account.c:
        * More camel operation reference fixes.
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c:
        * Don't set in_idle to false so that join works properly.
        * On disconnecting we forze a stop_idle so we warrant idle
          thread has died when we disconnect.
        * Send let idle die commands on disconnecting.
        * It's very important to make the idle thread die on time as it
          keeps a reference to the folder. Folder keeps a reference to
          this store, and then store should finish idle soon to be able
          to finalize (cycle reference).
* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
        * On finishing the idle thread we state we're out of it.
* libtinymail-camel/camel-lite/camel.c:
        * Avoid running internal methods of camel_shutdown two times if
          we can call shutdown two times.
* libtinymail-camel/tny-session-camel.c:
        * Keep a proper reference to TnyDevice.
* libtinymail-camel/tny-camel-store-account.c:
        * Free the iter store reference on finalising.
* libtinymail-camel/tny-camel-account.c:
        * Set service to null after unreffing it.
* libtinymailui-gtk/tny-gtk-folder-store-tree-model.c:
        * Don't get folders again when we change status to disconnected.

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3710 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoPorted fix for NB#86655 from trunk
Sergio Villar Senin [Mon, 30 Jun 2008 10:04:21 +0000 (10:04 +0000)]
Ported fix for NB#86655 from trunk

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3709 d4f517bd-a70b-0410-9f68-c17655437c52

9 years agoCreated the pe2 branch of tinymail for modest
Vivek Sekar [Tue, 17 Jun 2008 11:29:22 +0000 (11:29 +0000)]
Created the pe2 branch of tinymail for modest

git-svn-id: https://svn.tinymail.org/svn/tinymail/releases/modest/diablo-pe2@3700 d4f517bd-a70b-0410-9f68-c17655437c52