8 years agoImport revised translations stalker-froyo stalker-froyo-stage
Kenny Root [Mon, 21 Jun 2010 02:00:16 +0000 (19:00 -0700)]
Import revised translations

Change-Id: I3fea87caec5e237761978c2276d3634b6aa58987

8 years agoShow QSB icon in Launcher
Bjorn Bringert [Tue, 15 Jun 2010 03:25:09 +0000 (04:25 +0100)]
Show QSB icon in Launcher

Bug http://b/issue?id=2577981

8 years agoImport revised translations
Kenny Root [Thu, 10 Jun 2010 05:47:05 +0000 (22:47 -0700)]
Import revised translations

Change-Id: I2122064912235b148572b05100b9485855e02e3b

8 years agoImport revised translations
Kenny Root [Mon, 17 May 2010 18:41:08 +0000 (11:41 -0700)]
Import revised translations

Change-Id: Iacfb54290b12ff2a7bf44d0001cf49da8ddf6495

8 years agoImport revised translations
Kenny Root [Thu, 29 Apr 2010 22:52:36 +0000 (15:52 -0700)]
Import revised translations

Change-Id: I1834d425ccb02246455b7c11d8801d73f108bb96

8 years agoMerge "Import revised translations" into froyo
Kenny Root [Wed, 28 Apr 2010 04:57:16 +0000 (21:57 -0700)]
Merge "Import revised translations" into froyo

8 years agoImport revised translations
Kenny Root [Tue, 27 Apr 2010 21:03:06 +0000 (14:03 -0700)]
Import revised translations

Change-Id: I66a6dc3303dbaf0f1cb66746074ac6c27943bf20

8 years agoFix another source of ANRs in search widget
Bjorn Bringert [Tue, 27 Apr 2010 13:15:01 +0000 (14:15 +0100)]
Fix another source of ANRs in search widget

Change I7cc589fa0ef7d8665c28eb1403b34d0de44001c0 fixed
one call to getCorpora() when updating the All search widget.
This fixes the other call to getCorpora() in the default path.

Bug: http://b/issue?id=2614736
Change-Id: Ifcfb6a236b8a1499c93a7e5bc3159706f7b5b858

8 years agoFix QSB ANR's when updating All search widget
Bjorn Bringert [Wed, 21 Apr 2010 20:37:12 +0000 (21:37 +0100)]
Fix QSB ANR's when updating All search widget

Before, the corpus list was constructed unnecessarily when updating
a search widget set to the All corpus. Creating the corpus list
is a pretty expensive operation, especially the first time after
boot before SearchManagerService has updated the list of global

Bug: http://b/issue?id=2614736
Change-Id: I7cc589fa0ef7d8665c28eb1403b34d0de44001c0

8 years agoImport revised translations
Kenny Root [Thu, 15 Apr 2010 03:34:24 +0000 (20:34 -0700)]
Import revised translations

Change-Id: I4395be2a9a46e8903226063dbd71ca7a79afb5b2

8 years agoSet QSB version to 100 / 1.0
Bjorn Bringert [Thu, 8 Apr 2010 11:29:07 +0000 (12:29 +0100)]
Set QSB version to 100 / 1.0

Bug http://b/issue?id=2580397

Change-Id: Ic6605617a471ed3bf2899b1feadb1f9c83c493a6

8 years agoDon't show QSB icon in Launcher
Bjorn Bringert [Wed, 7 Apr 2010 18:18:45 +0000 (19:18 +0100)]
Don't show QSB icon in Launcher

Fixes http://b/issue?id=2574522

Change-Id: I907e1ecb4ea8b6625e85a75b51d1a4c090dd786a

8 years agoAllow Apps corpus Go button to use a custom search activity
Bjorn Bringert [Sat, 3 Apr 2010 10:31:37 +0000 (11:31 +0100)]
Allow Apps corpus Go button to use a custom search activity

Bug: http://b/issue?id=2559078
Change-Id: Id8fbdecb42e8cb21ef57085fb9c35df0d347fcdb

8 years agoGuard against null from getSearchablesInGlobalSearch()
Bjorn Bringert [Wed, 31 Mar 2010 14:18:04 +0000 (15:18 +0100)]
Guard against null from getSearchablesInGlobalSearch()

Bug http://b/issue?id=2531294

Change-Id: Ibb813cda8de76452fe9e26a899f91aafa5014253

8 years agoPass search intents to ApplicationsProvider on Go
Bjorn Bringert [Wed, 31 Mar 2010 12:19:47 +0000 (13:19 +0100)]
Pass search intents to ApplicationsProvider on Go

Bug http://b/issue?id=2559078

Change-Id: I00e7db95e980179252471cf368bd630a5f907b08

8 years agoMerge "Import revised translations" into froyo
Kenny Root [Tue, 30 Mar 2010 16:32:50 +0000 (09:32 -0700)]
Merge "Import revised translations" into froyo

8 years agoImport revised translations
Kenny Root [Tue, 30 Mar 2010 16:16:42 +0000 (09:16 -0700)]
Import revised translations

Change-Id: Ide2733e6180ffaf30aa302d5924e005c161e1562

8 years agoMerge "Remove unused action key methods" into froyo
Bjorn Bringert [Tue, 30 Mar 2010 09:06:49 +0000 (02:06 -0700)]
Merge "Remove unused action key methods" into froyo

8 years agoRemove overscroll
Adam Powell [Tue, 30 Mar 2010 00:30:06 +0000 (17:30 -0700)]
Remove overscroll

Change-Id: I3d81368a7249fc4b98bf1689e1f82d1281c12c5d

8 years agoRemove unused action key methods
Bjorn Bringert [Mon, 29 Mar 2010 21:27:43 +0000 (22:27 +0100)]
Remove unused action key methods

The action key interface will not be exposed in Froyo,
and we weren't using these methods anyway.

Bug http://b/issue?id=2553524

Change-Id: I326e6784e232b303166b315314bb463ecae09941

8 years agoWrite to click log asynchronously
Bjorn Bringert [Fri, 26 Mar 2010 13:22:32 +0000 (13:22 +0000)]
Write to click log asynchronously

This moves all write operations (except table creation)
to asynchronous transactions. This inclueds:
- Click logging
- Storing refreshed shortcuts
- Clearing history

Bug http://b/issue?id=2537681

Change-Id: Ia134ada5afc23310f6557ff7a34e5f03348c3935

8 years agoDon't log clicks asynchronously
Bjorn Bringert [Thu, 25 Mar 2010 17:03:02 +0000 (17:03 +0000)]
Don't log clicks asynchronously

It can throw IndexOutOfBoundsException, because the
cursor has already been closed.

Bug http://b/issue?id=2537681

Change-Id: I86465591166e35b81ca25c3446d77933ab9a6fcf

8 years agoClick logging performance improvements
Bjorn Bringert [Thu, 25 Mar 2010 16:06:12 +0000 (16:06 +0000)]
Click logging performance improvements

- Logs clicks asynchronously.

- Gets rid of SourceLog, and adds a corpus field to ClickLog that
  is used instead. This should reduce the amount of work done
  when logging clicks.

- Uses the 30 day threshold for both source ranking and shortcuts.

Bug http://b/issue?id=2537681

Change-Id: I70cf6031b667fcc41bc23cc8d61351607a1058fd

8 years agoShow IME on launching QSB, even when hardware keyboard is available.
Amith Yamasani [Wed, 24 Mar 2010 23:01:03 +0000 (16:01 -0700)]
Show IME on launching QSB, even when hardware keyboard is available.

Bug: 2500129

After the window receives focus, post a message to request the soft
input method to show. If done any sooner, the window and view focus
and IME decisions have not settled down yet.

8 years agoMerge "Reflecting the rename of contact search activity"
Dmitri Plotnikov [Tue, 23 Mar 2010 23:39:46 +0000 (16:39 -0700)]
Merge "Reflecting the rename of contact search activity"

8 years agoReflecting the rename of contact search activity
Dmitri Plotnikov [Tue, 23 Mar 2010 22:58:14 +0000 (15:58 -0700)]
Reflecting the rename of contact search activity

Bug: 2534618
Change-Id: I08f3f766fa4ea7c44b82ec758df5a879f80c3f22

8 years agoReduce QSB start-up time
Bjorn Bringert [Tue, 23 Mar 2010 10:07:12 +0000 (10:07 +0000)]
Reduce QSB start-up time

This change reduces the QSB start-up CPU time by
about 40% by doing the following:

- Don't get zero-query suggestions in onResume(), do it with a 100 ms
  delay instead, like when typing

- Don't log the qsb_start event in onResume(), do it in the first

- Get rid of one level in the view hierarchy.

Bug: http://b/issue?id=2537351

Change-Id: Ic9c566c2497446f71318af4a85090acd06d5b9a8

8 years agoCreate source contexts lazily
Bjorn Bringert [Fri, 19 Mar 2010 16:01:59 +0000 (16:01 +0000)]
Create source contexts lazily

Bug http://b/issue?id=2500425

Change-Id: Ibf99370918722ff0b4332912f8ae8bdb46f137e2

8 years agoDisable debug logging and remove unused imports and classes
Bjorn Bringert [Thu, 18 Mar 2010 23:43:46 +0000 (23:43 +0000)]
Disable debug logging and remove unused imports and classes

Fixes http://b/issue?id=2410136

Change-Id: I2416c9b6c1b9e819ec17d7954b6b70bf106f0414

8 years agoMerge "Import revised translations"
Eric Fischer [Thu, 18 Mar 2010 17:53:42 +0000 (10:53 -0700)]
Merge "Import revised translations"

8 years agoMerge "Assign explicit numbers to QSB event log tags (for unbundled stability)"
Dan Egnor [Thu, 18 Mar 2010 16:11:01 +0000 (09:11 -0700)]
Merge "Assign explicit numbers to QSB event log tags (for unbundled stability)"

8 years agoImport revised translations
Kenny Root [Thu, 18 Mar 2010 05:14:54 +0000 (22:14 -0700)]
Import revised translations

Change-Id: I31e1ac6de90d20deed922867c0eaa8d7e3f9efc9

8 years agoAssign explicit numbers to QSB event log tags (for unbundled stability)
Dan Egnor [Thu, 18 Mar 2010 02:48:48 +0000 (19:48 -0700)]
Assign explicit numbers to QSB event log tags (for unbundled stability)

Change-Id: I3eb1a693ab3c6e44c9d91ac41731536c9d2abcec

8 years agoMerge "Dismiss QSB on BACK even if IME is up"
Bjorn Bringert [Wed, 17 Mar 2010 22:20:11 +0000 (15:20 -0700)]
Merge "Dismiss QSB on BACK even if IME is up"

8 years agoDismiss QSB on BACK even if IME is up
Bjorn Bringert [Wed, 17 Mar 2010 21:29:52 +0000 (21:29 +0000)]
Dismiss QSB on BACK even if IME is up

Bug: http://b/2503930
Change-Id: I978ce593bfc9994f5b3553f9a81c2026b8cc5666

8 years agoVarious changes to shorcut promotion logic.
Bryan Mawhinney [Wed, 17 Mar 2010 17:35:22 +0000 (17:35 +0000)]
Various changes to shorcut promotion logic.

- Default services are always shown before non-default
- All default sources must respond before non default are called
- The top slots above the keyboard are shared by any default source results.

Change-Id: I59c9dad0fac1f9664b5f40cc32cc38fb42507fb2

8 years agoPerform simple url normalization when doing duplicate detection.
Bryan Mawhinney [Wed, 17 Mar 2010 15:37:50 +0000 (15:37 +0000)]
Perform simple url normalization when doing duplicate detection.

Fixes http://b/2500216

Change-Id: I4700e00381a82477c16dcaf36ca09e26b31aa0ba

8 years agoLarger touch area for corpus indicator
Bjorn Bringert [Wed, 17 Mar 2010 13:36:01 +0000 (13:36 +0000)]
Larger touch area for corpus indicator

Bug http://b/issue?id=2503914

Change-Id: I3f2ecdf0bfb6ea7b3c7986fa29c80320ec6039c9

8 years agoMerge "Set SOURCE=launcher-widget for searches started from widget"
Bjorn Bringert [Tue, 16 Mar 2010 19:00:28 +0000 (12:00 -0700)]
Merge "Set SOURCE=launcher-widget for searches started from widget"

8 years agoSet SOURCE=launcher-widget for searches started from widget
Bjorn Bringert [Tue, 16 Mar 2010 13:01:02 +0000 (13:01 +0000)]
Set SOURCE=launcher-widget for searches started from widget

Bug: http://b/issue?id=2315234
Change-Id: I3d29d2c53d0c1fc643dfc5f53d84caebd81f6587

8 years agoMerge "Don't send 0 length queries to the browser."
Bjorn Bringert [Tue, 16 Mar 2010 12:17:10 +0000 (05:17 -0700)]
Merge "Don't send 0 length queries to the browser."

8 years agoGuard against enter key on empty suggestions list
Bjorn Bringert [Tue, 16 Mar 2010 10:24:45 +0000 (10:24 +0000)]
Guard against enter key on empty suggestions list

Fixes http://b/issue?id=2515034

Change-Id: I829fef3514306aa85d2a7f466f597b02fb964b90

8 years agoDon't send 0 length queries to the browser.
Bryan Mawhinney [Tue, 16 Mar 2010 10:08:17 +0000 (10:08 +0000)]
Don't send 0 length queries to the browser.

Change-Id: Iedac00f92d5567f97afff2df879421183a5070fc

8 years agoUse resource names in stored shortcut icons URIs
Bjorn Bringert [Mon, 15 Mar 2010 20:02:49 +0000 (20:02 +0000)]
Use resource names in stored shortcut icons URIs

This makes the URIs in shortcuts for suggestions produced
by QSB stable across upgrades (as long as the resource names
don't change).


Change-Id: I17a8c06fcbc36f439c0751bb4dd0cb8789cb5e6b

8 years agoQSB IME and BACK fixes
Bjorn Bringert [Mon, 15 Mar 2010 10:17:29 +0000 (10:17 +0000)]
QSB IME and BACK fixes

- Open soft keyboard with hard keyboard closed

- Use extract UI in landscape mode.

- Fix this error:
1. Tap home screen search widget corpus indicator.
2. Tap outside corpus selection dialog to dismiss it.
3. Tap corpus indicator in QSB top left.
4. Press BACK
5. All of QSB was dismissed

Bugs: http://b/issue?id=2500129 and http://b/issue?id=2438199

Change-Id: I0d51999e7205246d5ab470be494397b86b73e795

8 years agoUse search app icon in widget corpus indicator at boot
Bjorn Bringert [Mon, 15 Mar 2010 11:57:53 +0000 (11:57 +0000)]
Use search app icon in widget corpus indicator at boot

Fixes http://b/issue?id=2512784

Change-Id: Ifb4328d83a004f303c47502e862cf84ede5c607c

8 years agoAllow installing QuickSearchBox in data partition
Bjorn Bringert [Sun, 14 Mar 2010 17:16:10 +0000 (17:16 +0000)]
Allow installing QuickSearchBox in data partition


- Only use sources that the QSB process can read. This will exclude
  any sources protected by the GLOBAL_SEARCH permission when
  QSB is in the data partition.

- Add permission to read bookmarks, needed by Web source
  when QuickSearchBox doesn't have the GLOBAL_SEARCH permission.

- Change QuickSearchBox icon to a generic magnifying glass, to make it
  different from GoogleQuickSearchBox.

- Change All corpus icon to be the same as the app icon
  (magnifying glass).

- Set package name in home screen search widget intents, so that
  the correct search app is started.

Fixes http://b/issue?id=2512719

Change-Id: I47892b011c06ebb000cd975bad057eeecc4d34db

8 years agoMerge "Don't show shortcuts for upgraded apps"
Bjorn Bringert [Mon, 15 Mar 2010 10:16:15 +0000 (03:16 -0700)]
Merge "Don't show shortcuts for upgraded apps"

8 years agoFix qsb_latency event log tag syntax
Bjorn Bringert [Sun, 14 Mar 2010 14:32:14 +0000 (14:32 +0000)]
Fix qsb_latency event log tag syntax

See http://b/issue?id=2415859

Change-Id: I07a0c93f3e7b557651786faeecb54d844d5e94cf

8 years agoDon't show shortcuts for upgraded apps
Bjorn Bringert [Fri, 12 Mar 2010 21:01:36 +0000 (21:01 +0000)]
Don't show shortcuts for upgraded apps

This required moving the limit on the number of shortcuts
returned from the SQL query to the ShortcutCursor constructor.

Fixes http://b/issue?id=2493974

Change-Id: Icd2c71c31433429c005926497c1767ccc713beb4

8 years agoShow shortcuts in corpus-specific mode.
Bryan Mawhinney [Fri, 12 Mar 2010 14:52:03 +0000 (14:52 +0000)]
Show shortcuts in corpus-specific mode.

Change-Id: Ibc101f26a9aede7992a43731975d99eb96318568

8 years agoDismiss QSB on BACK after clicking widget corpus selector
Bjorn Bringert [Fri, 12 Mar 2010 13:19:20 +0000 (13:19 +0000)]
Dismiss QSB on BACK after clicking widget corpus selector

Fixes http://b/issue?id=2505484

Change-Id: I823a7b047560426a667744acb5ef41e6c9b84fda

8 years agoMerge "Fix ShouldQueryStrategy.shouldQuery"
Bjorn Bringert [Fri, 12 Mar 2010 13:54:53 +0000 (05:54 -0800)]
Merge "Fix ShouldQueryStrategy.shouldQuery"

8 years agoFix ShouldQueryStrategy.shouldQuery
Bjorn Bringert [Fri, 12 Mar 2010 12:13:53 +0000 (12:13 +0000)]
Fix ShouldQueryStrategy.shouldQuery

updateQuery() didn't store the last query for widening or different

Also adds regression tests for this bug.

Also checks queryAfterNoResults before storing the empty corpus.

Also adds some missing test size annotations and removes
unneccessary "synchronized" from ShouldQueryStrategy
(after some recent changes it's only used from the main

Fixes http://b/issue?id=2510025

Change-Id: I9f3ca6962ec5fe7a1de2baef1ffab2db4add0756

8 years agoDelay suggestion update a bit, to reduce load when typing quickly
Bjorn Bringert [Fri, 12 Mar 2010 11:56:28 +0000 (11:56 +0000)]
Delay suggestion update a bit, to reduce load when typing quickly

This currently uses a 100 ms delay before updating the suggestions.
If a new character is typed before the timeout, the timeout
is reset. At least on Passion, the key repeat interval
when holding down backspace is ~ 50 ms, so this avoids
redundant suggestion queries when holding down backspace.

Also removes obsolete progress update code.

Fixes http://b/issue?id=2507005

Change-Id: I8856a320a37dfa15dd801e0217d40eec79f5894b

8 years agoLogging improvements and better corpus selector handling
Bjorn Bringert [Thu, 11 Mar 2010 16:43:28 +0000 (16:43 +0000)]
Logging improvements and better corpus selector handling

- Log latency for a fraction of corpus suggestion requests.

- Don't log qsb_start when choosing a corpus in the corpus

- Log qsb_exit when leaving QSB without doing a search, voice search
  or clicking a suggestion.

- Create corpus selector dialog directly, instead of it being a
  a managed dialog.

Change-Id: I2db3b4fa7b20cef339aff5715c72c9846103c9f8
Bugs: http://b/issue?id=2415859 and http://b/issue?id=2506462

8 years agoMake MultiSourceCorpusTest:testGetSuggestions deterministic
Bjorn Bringert [Thu, 11 Mar 2010 13:11:46 +0000 (13:11 +0000)]
Make MultiSourceCorpusTest:testGetSuggestions deterministic

Fixes http://b/issue?id=2506606

Change-Id: I124f334d99f2125c419ee0b63005e4e22ef2ae4b

8 years agoMerge "Send zero length queries to the web corpus."
Bjorn Bringert [Thu, 11 Mar 2010 12:27:00 +0000 (04:27 -0800)]
Merge "Send zero length queries to the web corpus."

8 years agoRemove drop shadow at top of QSB
Bjorn Bringert [Thu, 11 Mar 2010 10:41:43 +0000 (10:41 +0000)]
Remove drop shadow at top of QSB

Fixes http://b/issue?id=2505323

Change-Id: I6cd9bf60e5fc5229fc833ea10417609a9268266c

8 years agoSend zero length queries to the web corpus.
Bryan Mawhinney [Mon, 8 Mar 2010 14:11:09 +0000 (14:11 +0000)]
Send zero length queries to the web corpus.

This allows the web provider to warm up, and will allow us to show zero
query suggestions in future.

Change-Id: Ida7ce02e4a145ecae2a3c488875107e9e97b25c0

8 years agoMerge "Use standard window animations for QSB"
Bjorn Bringert [Wed, 10 Mar 2010 15:18:17 +0000 (07:18 -0800)]
Merge "Use standard window animations for QSB"

8 years agoMerge "Fix shortcut refreshes that delete shortcuts"
Bjorn Bringert [Wed, 10 Mar 2010 15:18:12 +0000 (07:18 -0800)]
Merge "Fix shortcut refreshes that delete shortcuts"

8 years agoMerge "Update suggestions when moving left/right from sugggestion"
Bjorn Bringert [Wed, 10 Mar 2010 15:18:08 +0000 (07:18 -0800)]
Merge "Update suggestions when moving left/right from sugggestion"

8 years agoMerge "Use a separate thread pool for Web corpus, to avoid deadlock"
Bjorn Bringert [Wed, 10 Mar 2010 15:18:04 +0000 (07:18 -0800)]
Merge "Use a separate thread pool for Web corpus, to avoid deadlock"

8 years agoUse a separate thread pool for Web corpus, to avoid deadlock
Bjorn Bringert [Tue, 9 Mar 2010 22:23:16 +0000 (22:23 +0000)]
Use a separate thread pool for Web corpus, to avoid deadlock

Fixes http://b/issue?id=2499654

Change-Id: I228d77a3ead794c7922d42fd51ff068f57dab40e

8 years agoFix shortcut refreshes that delete shortcuts
Bjorn Bringert [Wed, 10 Mar 2010 00:49:38 +0000 (00:49 +0000)]
Fix shortcut refreshes that delete shortcuts

Fixes http://b/issue?id=2499859 (I hope)

Change-Id: Ibe3ef5b81072b839c4aebe75e58c7ccae8603ff8

8 years agoUse standard window animations for QSB
Bjorn Bringert [Wed, 10 Mar 2010 10:49:07 +0000 (10:49 +0000)]
Use standard window animations for QSB

Fixes comment 1 in http://b/issue?id=2502479

Change-Id: I8b27d24d8c3c985476278060be4b4fc292a579c1

8 years agoUpdate suggestions when moving left/right from sugggestion
Bjorn Bringert [Tue, 9 Mar 2010 22:48:39 +0000 (22:48 +0000)]
Update suggestions when moving left/right from sugggestion

This is a pretty quick way to do query refinement
if you know about it.

Fixes http://b/issue?id=2499563

Change-Id: Ifc4e2b2ac0c4636390e2f497d014027e7a7cafc0

8 years agoMerge "Use @VisibleForTesting instead of proguard.flags"
Bjorn Bringert [Tue, 9 Mar 2010 19:29:11 +0000 (11:29 -0800)]
Merge "Use @VisibleForTesting instead of proguard.flags"

8 years agoMerge "Make it easier to identify individual worker threads in QSB."
Bjorn Bringert [Tue, 9 Mar 2010 16:31:16 +0000 (08:31 -0800)]
Merge "Make it easier to identify individual worker threads in QSB."

8 years agoMake it easier to identify individual worker threads in QSB.
Bryan Mawhinney [Tue, 9 Mar 2010 16:10:50 +0000 (16:10 +0000)]
Make it easier to identify individual worker threads in QSB.

Change-Id: Iae0adc8c92455a604d1558e6485eff7052561d31

8 years agoAdd read contacts permission to QSB for quick contacts badges.
Bryan Mawhinney [Tue, 9 Mar 2010 15:25:49 +0000 (15:25 +0000)]
Add read contacts permission to QSB for quick contacts badges.

Change-Id: I5cbdcb9987117a40666d416a065134434c39af03

8 years agoUse @VisibleForTesting instead of proguard.flags
Bjorn Bringert [Tue, 9 Mar 2010 14:49:36 +0000 (14:49 +0000)]
Use @VisibleForTesting instead of proguard.flags

Change-Id: Ib6a8cceaa24da843d46ea3561c9d237a21c2b83e

8 years agoUse blue "g" icon for All corpus
Bjorn Bringert [Fri, 5 Mar 2010 22:55:45 +0000 (22:55 +0000)]
Use blue "g" icon for All corpus

Fixes http://b/issue?id=2493097

Change-Id: If3c0de48e9d65056bcd7e91e9441edb23a7baf8c

8 years agoMerge "New assets for search button and corpus indicator"
Bjorn Bringert [Tue, 9 Mar 2010 10:04:14 +0000 (02:04 -0800)]
Merge "New assets for search button and corpus indicator"

8 years agoAdd an empty
Jean-Baptiste Queru [Tue, 9 Mar 2010 02:05:08 +0000 (18:05 -0800)]
Add an empty

Change-Id: I6352c9f53e27e79a639711376020ed100f47bdac

8 years agoNew assets for search button and corpus indicator
Bjorn Bringert [Mon, 8 Mar 2010 21:26:46 +0000 (21:26 +0000)]
New assets for search button and corpus indicator

Fixes http://b/issue?id=2489279

Change-Id: I9093f47827dc1d25da4976020331eb5fa807eb7d

8 years agoFix for: Position of right button edge is different for VS
Valentin Kravtsov [Mon, 8 Mar 2010 21:07:02 +0000 (21:07 +0000)]
Fix for: Position of right button edge is different for VS

Bug fix for: http://b/issue?id=2495951

Position of right button edge is different for voice search and Go button in search dialog

Change-Id: Ib7595ba8b0df723f1e7cd2d1b8dafa33cf38667b

8 years agoMerge changes I7f6b4620,I75d2a863
Bjorn Bringert [Mon, 8 Mar 2010 12:12:25 +0000 (04:12 -0800)]
Merge changes I7f6b4620,I75d2a863

* changes:
  Don't do busy waiting in BarrierConsumer
  Always use the same SuggestionsProvider

8 years agoMerge "Fix suggestion selection handling"
Bjorn Bringert [Mon, 8 Mar 2010 11:44:38 +0000 (03:44 -0800)]
Merge "Fix suggestion selection handling"

8 years agoMerge "Honor "show web suggestions" in QSB (again)"
Bjorn Bringert [Mon, 8 Mar 2010 11:42:19 +0000 (03:42 -0800)]
Merge "Honor "show web suggestions" in QSB (again)"

8 years agoDon't do busy waiting in BarrierConsumer
Bjorn Bringert [Sat, 6 Mar 2010 22:31:37 +0000 (22:31 +0000)]
Don't do busy waiting in BarrierConsumer

Fixes http://b/issue?id=2494205

Change-Id: I7f6b4620865f920ed17e09882715a475bba81615

8 years agoAlways use the same SuggestionsProvider
Bjorn Bringert [Sat, 6 Mar 2010 21:47:47 +0000 (21:47 +0000)]
Always use the same SuggestionsProvider

This fixes a problem where a new SuggestionsProvider was created
for every keystroke when in single-corpus mode. That resulted
in old pending query tasks not being cancelled. This increased
suggestion latency a lot when typing quickly.

Fixes http://b/issue?id=2494162

Change-Id: I75d2a86349cdec8735a26c48c1fb737fac772f78

8 years agoFix suggestion selection handling
Bjorn Bringert [Sat, 6 Mar 2010 18:04:25 +0000 (18:04 +0000)]
Fix suggestion selection handling

This change addresses two problems with how suggestion selection
events were fired:

- When a suggestion was selected with the trackball, and focus then
  moved away from the suggestions list, and back in, no selection
  event was fired. This is because ListView retains the selection
  position. This is worked around by firing selection events
  on suggestion list focus changes when the list view already
  has a selected position.

- If the suggestion list changes so that the old selection is no
  longer valid (only happens when the suggestion list becomes shorter),
  ListView changes the selection so that the position is still valid.
  Before, this triggered a suggestion selection event. We now suppress
  all selection events that happen when the list does not have focus.

Fixes http://b/issue?id=2464727

Change-Id: Ibfbed15bf136ab8f9c9d4172c014c152e56c5089

8 years agoHonor "show web suggestions" in QSB (again)
Bjorn Bringert [Sat, 6 Mar 2010 15:23:38 +0000 (15:23 +0000)]
Honor "show web suggestions" in QSB (again)

Fixes http://b/issue?id=2493994

Change-Id: Ic3fcdb619d0a24b8985d2cbbfa7b47f1191d090c

8 years agoOrder Searchable Items: Web first, the rest alphabetically
Bjorn Bringert [Sat, 6 Mar 2010 14:40:42 +0000 (14:40 +0000)]
Order Searchable Items: Web first, the rest alphabetically

Fixes http://b/issue?id=2491845

Change-Id: I4ceec8f4615e9ac357f6132cf05a8dfe3f7faefe

8 years agoMore refactoring to enable Apps+Market source
Bjorn Bringert [Fri, 5 Mar 2010 13:16:02 +0000 (13:16 +0000)]
More refactoring to enable Apps+Market source

Part of http://b/issue?id=2312744

Change-Id: I3d4bae54e55ade6901fb9d061ada226efd098549

8 years agoEnable only All, Web, Apps and Contacts by default
Bjorn Bringert [Fri, 5 Mar 2010 08:54:05 +0000 (08:54 +0000)]
Enable only All, Web, Apps and Contacts by default

Fixes http://b/issue?id=2491320

Change-Id: I52867aecc5b2e89b5d149532fa89af1181a1e068

8 years agoMerge "Test application for partial suggestions."
Amith Yamasani [Thu, 4 Mar 2010 22:45:29 +0000 (14:45 -0800)]
Merge "Test application for partial suggestions."

8 years agoTest application for partial suggestions.
Amith Yamasani [Tue, 2 Mar 2010 21:57:30 +0000 (13:57 -0800)]
Test application for partial suggestions.

It tests 3 cases -
0 - Null cursor
1 - 3 partial results followed in 2 seconds by 3 additional results
2 - Emptry cursor followed in 2 seconds by 3 results

8 years agoBoost ranking of default enabled corpora
Bjorn Bringert [Thu, 4 Mar 2010 15:31:36 +0000 (15:31 +0000)]
Boost ranking of default enabled corpora

This includes a refactoring to have the CorpusRanker
wrap a Corpora object and cache the ranked corpus list.

Fixes http://b/issue?id=2486544

Change-Id: If3eb02426cfc4dcc00d932d21e2541181f076dc5

8 years agoCorpus selector UI fixes
Bjorn Bringert [Thu, 4 Mar 2010 12:46:12 +0000 (12:46 +0000)]
Corpus selector UI fixes

- Dismiss corpus selector on any touch outside corpus grid

- Dismiss dialog when moving up-and-out of corpus grid with

- Dismiss corpus dialog on typing on hard keyboard.

- Select the current corpus on start. As is normal with GridViews
  and Listviews, this doesn't highlight the selection in touch mode.

- Don't preserve corpus selection dialog when leaving QSB

- Keep dialog at right vertical offset event when it needs to scroll.

Fixes part of http://b/issue?id=2482918
Fixes http://b/issue?id=2481106
Fixes http://b/issue?id=2473693

Change-Id: I276628763d1d252ce9ec4b7094b934ed29d5a44d

8 years agoOnly included queried corpora in qsb_click log event
Bjorn Bringert [Thu, 4 Mar 2010 11:31:54 +0000 (11:31 +0000)]
Only included queried corpora in qsb_click log event

Change-Id: I4ce89b02f7957a427508e58226c5b9867e819b32

8 years agoUse actual set of promoted corpora in suggestion promoter
Bjorn Bringert [Thu, 4 Mar 2010 12:24:00 +0000 (12:24 +0000)]
Use actual set of promoted corpora in suggestion promoter

Fixes http://b/issue?id=2486251

Change-Id: I9de5b09eadf168377e7c7b2f11ce9ae247129f70

8 years agoOnly consider enabled corpora for promotion (doh!)
Bjorn Bringert [Wed, 3 Mar 2010 22:56:09 +0000 (22:56 +0000)]
Only consider enabled corpora for promotion (doh!)

Before, all corpora, not just enabled ones, where considered
for promotion in RankAwarePromoter. This had the effect that web
was the only promoted source ever to be queried.

Also adds a lot of debug printing that helped track this down.

Fixed in http://b/issue?id=2486251

Change-Id: Ia739111b2ab1bf2c5aba8dd1eca29614ca20c407

8 years agoDon't start empty searches.
Bjorn Bringert [Wed, 3 Mar 2010 21:19:19 +0000 (21:19 +0000)]
Don't start empty searches.

Fixes http://b/issue?id=2466682

Change-Id: I2e1649c65575a54c55401c135caafc97b874c127

8 years agoMerge "Use a custom corpus class for Apps"
Bjorn Bringert [Wed, 3 Mar 2010 20:51:17 +0000 (12:51 -0800)]
Merge "Use a custom corpus class for Apps"

8 years agoDon't show shortcuts from disabled corpora
Bjorn Bringert [Wed, 3 Mar 2010 16:06:46 +0000 (16:06 +0000)]
Don't show shortcuts from disabled corpora

Fixes http://b/issue?id=2476221

Change-Id: Ia811d3f0ae0d3cf80af944a72324762f44ec146f

8 years agoUse a custom corpus class for Apps
Bjorn Bringert [Wed, 3 Mar 2010 15:24:26 +0000 (15:24 +0000)]
Use a custom corpus class for Apps

This is in preparation for adding Market search to it,
and also fixes the missing Apps search hint.

Fixes http://b/issue?id=2470338

Change-Id: Ia278519abddface4457680469ab7c011e0d77468

8 years agoRefactoring to make it easier to add the apps+market corpus
Bjorn Bringert [Fri, 26 Feb 2010 17:40:21 +0000 (17:40 +0000)]
Refactoring to make it easier to add the apps+market corpus

I created an abstract MultiSourceCorpus implementation
of Corpus, and changed WebCorpus to use that as its base class.
Once we have Market suggestions, I will use the same bas class for
the Apps corpus. This is part of the fix for http://b/issue?id=2312744

Change-Id: I804555a95ace92eeafd4922e27f86a90dda7889e