qtcontacts-tracker:qtcontacts-tracker.git
6 years agoChanges: Shuffle few utility functions to avoid forward declarations.
Mathias Hasselmann [Fri, 25 Mar 2011 13:03:11 +0000 (14:03 +0100)]
Changes: Shuffle few utility functions to avoid forward declarations.

RevBy: TrustMe

6 years agoChanges: add ut::testMultipleUrls()
Friedrich W. H. Kossebau [Thu, 24 Mar 2011 14:08:41 +0000 (15:08 +0100)]
Changes: add ut::testMultipleUrls()

RevBy: people-review

Details:
tests storing and fetching of 2 urls with all combinations of subtype and context
all contacts are stored and fetched in one go,
not done with a _data method, to speed-up the test, as requested

6 years agoChanges: Move QctLogger to the extension library
Mathias Hasselmann [Fri, 25 Mar 2011 12:36:52 +0000 (13:36 +0100)]
Changes: Move QctLogger to the extension library

RevBy: TrustMe
Details: Mark the header as private as it is not generally useful.

6 years agoChanges: Move avatar generation method to the lib
Adrien Bustany [Thu, 24 Mar 2011 09:25:12 +0000 (11:25 +0200)]
Changes: Move avatar generation method to the lib

RevBy: TrustMe

6 years agoNew: Apply some match flags to filters with instance matching
Mathias Hasselmann [Fri, 25 Mar 2011 00:56:19 +0000 (01:56 +0100)]
New: Apply some match flags to filters with instance matching

RevBy: TrustMe

6 years agoChanges: Repair detail filter for simple cases of instance matching
Mathias Hasselmann [Thu, 24 Mar 2011 23:43:18 +0000 (00:43 +0100)]
Changes: Repair detail filter for simple cases of instance matching

RevBy: TrustMe

6 years agoChanges: Rewrite detail filters with empty field into union filter
Mathias Hasselmann [Thu, 24 Mar 2011 21:26:41 +0000 (22:26 +0100)]
Changes: Rewrite detail filters with empty field into union filter

RevBy: TrustMe
Details: This restores behavior of the old scary builder. It avoids bugs by
reusing existing code. Without such habit it is hard if not impossible to
consider all special cases in each code path.

6 years agoChanges: Move resource() attribute to ResourceInfo class
Mathias Hasselmann [Thu, 24 Mar 2011 14:19:48 +0000 (15:19 +0100)]
Changes: Move resource() attribute to ResourceInfo class

RevBy: TrustMe

6 years agoChanges: Micro-optimize hasDTMFCodes check
Mathias Hasselmann [Thu, 24 Mar 2011 14:17:54 +0000 (15:17 +0100)]
Changes: Micro-optimize hasDTMFCodes check

RevBy: TrustMe
Details: Do inexpensive tests first.

6 years agoChanges: Propagate error codes for bindInstanceValues()
Mathias Hasselmann [Thu, 24 Mar 2011 10:07:14 +0000 (11:07 +0100)]
Changes: Propagate error codes for bindInstanceValues()

RevBy: Friedrich

6 years agoChanges: adapt reference queries, no more GROUP_CONCAT on results for single-valued...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 16:13:03 +0000 (17:13 +0100)]
Changes: adapt reference queries, no more GROUP_CONCAT on results for single-valued nco:gender

RevBy: Mathias

6 years agoChanges: do not GROUP_CONCAT on results for single-valued values-by-instances
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 16:00:09 +0000 (17:00 +0100)]
Changes: do not GROUP_CONCAT on results for single-valued values-by-instances

RevBy: Mathias

6 years agoChanges: adapt reference queries, values-by-instances are now fetched with graph...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:21:31 +0000 (14:21 +0100)]
Changes: adapt reference queries, values-by-instances are now fetched with graph appended

RevBy: people-review

6 years agoChanges: no longer skip ut::testFetchingNonQctResourcesAsReadOnlyDetails() for QConta...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:19:56 +0000 (14:19 +0100)]
Changes: no longer skip ut::testFetchingNonQctResourcesAsReadOnlyDetails() for QContactGender

RevBy: people-review

6 years agoChanges: fetch values-by-instances with graph as well
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:17:48 +0000 (14:17 +0100)]
Changes: fetch values-by-instances with graph as well

RevBy: people-review

6 years agoChanges: Use integer literals for tracker:id() based filters
Mathias Hasselmann [Thu, 24 Mar 2011 10:02:31 +0000 (11:02 +0100)]
Changes: Use integer literals for tracker:id() based filters

RevBy: TrustMe

6 years agoChanges: Update reference queries for filters
Mathias Hasselmann [Thu, 24 Mar 2011 01:11:22 +0000 (02:11 +0100)]
Changes: Update reference queries for filters

RevBy: TrustMe

6 years agoChanges: Highlight "Significant Tests" line if there are failed tests
Mathias Hasselmann [Thu, 24 Mar 2011 01:10:27 +0000 (02:10 +0100)]
Changes: Highlight "Significant Tests" line if there are failed tests

RevBy: TrustMe

6 years agoFixes: Query generated for detail filter with empty field
Mathias Hasselmann [Thu, 24 Mar 2011 00:49:14 +0000 (01:49 +0100)]
Fixes: Query generated for detail filter with empty field

RevBy: TrustMe
Details: Properly enumerate the EXISTS expression list.
Cookies: Adrien for not updating the reference query. Friedrich for putting a
comment, but not fixing the loop.

6 years agoFixes: Handling of range flags in the scary builder
Mathias Hasselmann [Wed, 23 Mar 2011 23:30:07 +0000 (00:30 +0100)]
Fixes: Handling of range flags in the scary builder

RevBy: TrustMe
Details: Copy rangeFlags() when rewriting the range filter. Consider that
IncludeLower is zero, when selecting operators.

Adrien, cookies please! For not updating the reference query.

6 years agoFixes: Expected detail schema for ut_qtcontacts_trackerplugin_querybuilder::testDetai...
Mathias Hasselmann [Wed, 23 Mar 2011 22:31:21 +0000 (23:31 +0100)]
Fixes: Expected detail schema for ut_qtcontacts_trackerplugin_querybuilder::testDetailSchema()

RevBy: TrustMe

6 years agoChanges: Add missing test data files in ut_qtcontacts_trackerplugin_tests.pro
Adrien Bustany [Wed, 23 Mar 2011 16:59:47 +0000 (18:59 +0200)]
Changes: Add missing test data files in ut_qtcontacts_trackerplugin_tests.pro

RevBy: TrustMe

6 years agoChanges: Sanitize error handling in scalar query builder
Adrien Bustany [Mon, 21 Mar 2011 11:42:47 +0000 (13:42 +0200)]
Changes: Sanitize error handling in scalar query builder

RevBy: TrustMe
Details:
This commit makes all the functions that can fail in the scalar QB
return a QContactManager::Error, instead of returning a boolean
(sometimes) and setting an error in m_error (for the few methods which
used to do it). Since m_error is not used anymore, the error() method is
removed.

6 years agoPrepare harmattan/4.13.2-1
Mathias Hasselmann [Wed, 23 Mar 2011 12:56:37 +0000 (13:56 +0100)]
Prepare harmattan/4.13.2-1

6 years agoChanges: Fix return value logic in union/intersection bindFilter
Adrien Bustany [Mon, 21 Mar 2011 11:42:07 +0000 (13:42 +0200)]
Changes: Fix return value logic in union/intersection bindFilter

RevBy: TrustMe

6 years agoChanges: Fix 303-testDetailFilter-1.rq reference file
Adrien Bustany [Mon, 21 Mar 2011 08:23:20 +0000 (10:23 +0200)]
Changes: Fix 303-testDetailFilter-1.rq reference file

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.1-1
Mathias Hasselmann [Tue, 22 Mar 2011 14:57:15 +0000 (15:57 +0100)]
Prepare harmattan/4.13.1-1

6 years agoPrepare harmattan/4.13.1-0
Mathias Hasselmann [Tue, 22 Mar 2011 14:51:46 +0000 (15:51 +0100)]
Prepare harmattan/4.13.1-0

6 years agoFixes: NB#217752 - Deletion of 100 Device contacts is taking more time
Mathias Hasselmann [Tue, 22 Mar 2011 14:25:51 +0000 (15:25 +0100)]
Fixes: NB#217752 - Deletion of 100 Device contacts is taking more time

RevBy: TrustMe
Details: Actually just cleanup the code and update unit tests. We accidentally
released the fix with 4.13.0-2 already.

6 years agoFixes: Initialize m_contactIds early enough
Mathias Hasselmann [Tue, 22 Mar 2011 14:23:25 +0000 (15:23 +0100)]
Fixes: Initialize m_contactIds early enough

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.0-2 harmattan/4.13.0-2
Mathias Hasselmann [Fri, 18 Mar 2011 14:47:56 +0000 (15:47 +0100)]
Prepare harmattan/4.13.0-2

6 years agoNew: Add --cleanup switch to batch saving benchmark
Mathias Hasselmann [Fri, 18 Mar 2011 14:40:53 +0000 (15:40 +0100)]
New: Add --cleanup switch to batch saving benchmark

Bug: NB#232183 - Deletion of 500 Device contacts takes more than 10 seconds
RevBy: TrustMe

6 years agoChanges: Fix testMergeSyncTarget
Adrien Bustany [Fri, 18 Mar 2011 07:35:54 +0000 (09:35 +0200)]
Changes: Fix testMergeSyncTarget

RevBy: TrustMe
Details:
Now that the "telepathy" sync target gets changed to "addressbook" in
the save request, we need a special hack to save a contact with sync
target "telepathy".

6 years agoChanges: Add test for telepathy -> addressbook sync target change on saving
Adrien Bustany [Thu, 17 Mar 2011 13:06:43 +0000 (15:06 +0200)]
Changes: Add test for telepathy -> addressbook sync target change on saving

RevBy: TrustMe

6 years agoChanges: Change sync target from "telepathy" to "addressbook" when saving
Adrien Bustany [Thu, 17 Mar 2011 13:00:50 +0000 (15:00 +0200)]
Changes: Change sync target from "telepathy" to "addressbook" when saving

RevBy: TrustMe
Details:
When saving a contact, we set its sync target to addressbook if it was
previously set to telepathy. This is done to prevent contactsd from
deleting the contact once the user has set some custom data on it.

6 years agoChanges: merge request: Use engine's current sync target and not the default one
Adrien Bustany [Fri, 18 Mar 2011 09:12:53 +0000 (11:12 +0200)]
Changes: merge request: Use engine's current sync target and not the default one

RevBy: TrustMe

6 years agoChanges: merge request: insert/delete sync target in QCT's graph
Adrien Bustany [Fri, 18 Mar 2011 08:26:51 +0000 (10:26 +0200)]
Changes: merge request: insert/delete sync target in QCT's graph

RevBy: TrustMe

6 years agoChanges: Move "addressbook" sync target constant to custom details
Mathias Hasselmann [Fri, 18 Mar 2011 06:40:48 +0000 (08:40 +0200)]
Changes: Move "addressbook" sync target constant to custom details

RevBy: TrustMe
RevBy: people-review

6 years agoChanges: Move common sync targets in customdetails.h
Adrien Bustany [Thu, 17 Mar 2011 12:41:30 +0000 (14:41 +0200)]
Changes: Move common sync targets in customdetails.h

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.0-1 harmattan/4.13.0-1
Mathias Hasselmann [Fri, 18 Mar 2011 09:59:49 +0000 (10:59 +0100)]
Prepare harmattan/4.13.0-1

6 years agoChanges: update reference queries to new note fetching and url subtype fix 146
Friedrich W. H. Kossebau [Thu, 17 Mar 2011 20:59:58 +0000 (21:59 +0100)]
Changes: update reference queries to new note fetching and url subtype fix

RevBy: people-review

6 years agoChanges: also create predicate function to fetch nco:note values
Friedrich W. H. Kossebau [Thu, 17 Mar 2011 20:58:29 +0000 (21:58 +0100)]
Changes: also create predicate function to fetch nco:note values

RevBy: people-review

Details:
old code was created by test-driven approach, even reviewed,
no comments on that please ;)

6 years agoFixes: results for url subtype need to be separated by detail separator
Friedrich W. H. Kossebau [Thu, 17 Mar 2011 20:57:35 +0000 (21:57 +0100)]
Fixes: results for url subtype need to be separated by detail separator

RevBy: people-review

Details:
old code will have failed if there were more than two urls per contact :(

6 years agoChanges: Properly handle resolving of numbers with DTMF codes
Adrien Bustany [Wed, 9 Mar 2011 13:50:58 +0000 (15:50 +0200)]
Changes: Properly handle resolving of numbers with DTMF codes

RevBy: TrustMe
Details:
When resolving numbers with DTMF codes, we should first lookup for an
exact match (of the normalized number), and if there is none try to
strip the DTMF part and lookup again.

6 years agoChanges: Don't consider DTMF codes in number normalization length
Adrien Bustany [Wed, 9 Mar 2011 15:42:42 +0000 (17:42 +0200)]
Changes: Don't consider DTMF codes in number normalization length

RevBy: TrustMe

6 years agoChanges: Use qctMakeLocalPhoneNumber in the scalar QB
Adrien Bustany [Fri, 11 Mar 2011 07:20:31 +0000 (09:20 +0200)]
Changes: Use qctMakeLocalPhoneNumber in the scalar QB

RevBy: TrustMe

6 years agoChanges: Copy remove request's contact ids
Mathias Hasselmann [Thu, 17 Mar 2011 14:21:24 +0000 (15:21 +0100)]
Changes: Copy remove request's contact ids

RevBy: TrustMe
Details: This is to comply with recommended QtContacts practise.

6 years agoChanges: Update .gitignore file
Mathias Hasselmann [Thu, 17 Mar 2011 14:00:33 +0000 (15:00 +0100)]
Changes: Update .gitignore file

RevBy: TrustMe

6 years agoChanges: Allocate batchsaving benchmark on heap to comply with QApplication rules
Mathias Hasselmann [Thu, 17 Mar 2011 13:28:14 +0000 (14:28 +0100)]
Changes: Allocate batchsaving benchmark on heap to comply with QApplication rules

RevBy: TrustMe
Details: "No Qt call permitted without QApplication alive"

6 years agoChanges: Update EXPECTFAIL file
Mathias Hasselmann [Thu, 17 Mar 2011 13:12:36 +0000 (14:12 +0100)]
Changes: Update EXPECTFAIL file

RevBy: TrustMe

6 years agoChanges: Reuse predicate functions from schema in scalar query builder 142
Adrien Bustany [Thu, 17 Mar 2011 08:38:26 +0000 (10:38 +0200)]
Changes: Reuse predicate functions from schema in scalar query builder

RevBy: TrustMe

6 years agoChanges: Add PropertyInfoBase::predicateFunction method
Adrien Bustany [Thu, 17 Mar 2011 08:37:46 +0000 (10:37 +0200)]
Changes: Add PropertyInfoBase::predicateFunction method

RevBy: TrustMe
Details:
This method returns the matching Cubi::PredicateFunction

6 years agoChanges: Reuse ResourceValues from schema in save request
Adrien Bustany [Wed, 16 Mar 2011 13:04:02 +0000 (15:04 +0200)]
Changes: Reuse ResourceValues from schema in save request

RevBy: TrustMe

6 years agoChanges: Use shared ResourceValues in scalar query builder
Adrien Bustany [Wed, 16 Mar 2011 12:35:50 +0000 (14:35 +0200)]
Changes: Use shared ResourceValues in scalar query builder

RevBy: TrustMe
Details:
Use PropertyInfoBase::resource whenever possible.

6 years agoChanges: Add a PropertyInfoBase::resource method
Adrien Bustany [Wed, 16 Mar 2011 12:34:28 +0000 (14:34 +0200)]
Changes: Add a PropertyInfoBase::resource method

RevBy: TrustMe
Details:
This method returns a reference to the matching Cubi::ResourceValue.

6 years agoChanges: Fix qctIriAlias and qctReduceIris use QString
Adrien Bustany [Wed, 16 Mar 2011 11:28:30 +0000 (13:28 +0200)]
Changes: Fix qctIriAlias and qctReduceIris use QString

RevBy: TrustMe

6 years agoChanges: Update ontologies to use prefixed names
Adrien Bustany [Wed, 16 Mar 2011 09:07:00 +0000 (11:07 +0200)]
Changes: Update ontologies to use prefixed names

RevBy: TrustMe

6 years agoChanges: Use prefix notation for resources in ontologycompiler
Adrien Bustany [Tue, 15 Mar 2011 15:26:05 +0000 (17:26 +0200)]
Changes: Use prefix notation for resources in ontologycompiler

RevBy: TrustMe

6 years agoChanges: fetch request: use QStringBuilder to generate detailUri
Adrien Bustany [Wed, 16 Mar 2011 19:33:41 +0000 (21:33 +0200)]
Changes: fetch request: use QStringBuilder to generate detailUri

RevBy: TrustMe

6 years agoChanges: Tidy MR#141
Mathias Hasselmann [Wed, 16 Mar 2011 23:57:48 +0000 (00:57 +0100)]
Changes: Tidy MR#141

RevBy: TrustMe

6 years agoChanges: Add test for sync target merge rules
Adrien Bustany [Sun, 6 Mar 2011 14:34:23 +0000 (15:34 +0100)]
Changes: Add test for sync target merge rules

RevBy: TrustMe

6 years agoChanges: Handle sync target when merging
Adrien Bustany [Sat, 5 Mar 2011 15:33:22 +0000 (16:33 +0100)]
Changes: Handle sync target when merging

RevBy: TrustMe
Details:
When merging contacts with different sync targets, special care must be
taken in order to ensure that both contactsd and as-daemon will be
happy after the merge

6 years agoPrepare harmattan/4.12.11-1
Adrien Bustany [Wed, 16 Mar 2011 14:57:31 +0000 (16:57 +0200)]
Prepare harmattan/4.12.11-1

6 years agoChanges: minor code improvement
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 16:37:55 +0000 (17:37 +0100)]
Changes: minor code improvement

RevBy: people-review

Details:
looks like left-over code, new code is also more readable

6 years agoChanges: Now also do su voodoo for single CITA steps
Mathias Hasselmann [Wed, 16 Mar 2011 16:24:09 +0000 (17:24 +0100)]
Changes: Now also do su voodoo for single CITA steps

RevBy: Adrien

6 years agoChanges: Ignore nco:contactLocalUID when merging
Adrien Bustany [Fri, 11 Mar 2011 12:03:51 +0000 (14:03 +0200)]
Changes: Ignore nco:contactLocalUID when merging

RevBy: TrustMe
RevBy: people-review

6 years agoPrepare harmattan/4.12.10-2
Jens Georg [Wed, 16 Mar 2011 11:07:38 +0000 (13:07 +0200)]
Prepare harmattan/4.12.10-2

6 years agoNew: Add VCard from bug
Jens Georg [Wed, 16 Mar 2011 11:03:03 +0000 (13:03 +0200)]
New: Add VCard from bug

RevBy: TrustMe

6 years agoChanges: Rename functions on phoneutils.h to qctFunctionName
Adrien Bustany [Wed, 16 Mar 2011 09:43:22 +0000 (11:43 +0200)]
Changes: Rename functions on phoneutils.h to qctFunctionName

RevBy: TrustMe

6 years agoChanges: Update reference queries for MR#132
Mathias Hasselmann [Tue, 15 Mar 2011 22:09:01 +0000 (23:09 +0100)]
Changes: Update reference queries for MR#132

RevBy: TrustMe

6 years agoChanges: Tidy unit test of MR#132 a bit
Mathias Hasselmann [Tue, 15 Mar 2011 19:34:36 +0000 (20:34 +0100)]
Changes: Tidy unit test of MR#132 a bit

RevBy: TrustMe

6 years agoChanges: also log actual graph iri if value predicate is from other graph
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 11:18:29 +0000 (12:18 +0100)]
Changes: also log actual graph iri if value predicate is from other graph

RevBy: people-review

6 years agoChanges: add ut_qtcontacts_trackerplugin::testFetchingNonQctResourcesAsReadOnlyDetails()
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 02:40:48 +0000 (03:40 +0100)]
Changes: add ut_qtcontacts_trackerplugin::testFetchingNonQctResourcesAsReadOnlyDetails()

RevBy: people-review

6 years agoFixes: make manually concating the graph iri to values also work with the default...
Friedrich W. H. Kossebau [Thu, 10 Mar 2011 16:46:40 +0000 (17:46 +0100)]
Fixes: make manually concating the graph iri to values also work with the default graph

RevBy: people-review

6 years agoChanges: minor code improvement
Friedrich W. H. Kossebau [Thu, 10 Mar 2011 16:11:59 +0000 (17:11 +0100)]
Changes: minor code improvement

RevBy: people-review

Details:
move Variable last into smallest possible scope

6 years agoChanges: add helper function "PrefixFunction applyConcatWithGraph(...)"
Friedrich W. H. Kossebau [Wed, 9 Mar 2011 11:30:19 +0000 (12:30 +0100)]
Changes: add helper function "PrefixFunction applyConcatWithGraph(...)"

RevBy: people-review

6 years agoChanges: remove useless exception for fields with a foreign key on graph check
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 16:23:02 +0000 (17:23 +0100)]
Changes: remove useless exception for fields with a foreign key on graph check

RevBy: people-review

6 years agoChanges: rename var useGraph to needsGraphInRestrictions
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 16:09:26 +0000 (17:09 +0100)]
Changes: rename var useGraph to needsGraphInRestrictions

RevBy: TrustMe

6 years agoFixes: do not add graph iri for field with single predicate chain and without hasOwner
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 13:37:21 +0000 (14:37 +0100)]
Fixes: do not add graph iri for field with single predicate chain and without hasOwner

RevBy: people-review

6 years agoChanges: fix comment
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 12:07:41 +0000 (13:07 +0100)]
Changes: fix comment

RevBy: TrustMe

6 years agoFixes: only fetch graph for subtype-by-property field if it has hasOwner flag set
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 12:07:24 +0000 (13:07 +0100)]
Fixes: only fetch graph for subtype-by-property field if it has hasOwner flag set

RevBy: people-review

6 years agoChanges: remove dead code
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 11:39:47 +0000 (12:39 +0100)]
Changes: remove dead code

RevBy: Adrien

6 years agoChanges: remove left-over debugging code
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 11:38:22 +0000 (12:38 +0100)]
Changes: remove left-over debugging code

RevBy: Adrien

6 years agoChanges: only delete associated objects inside qct graph
Friedrich W. H. Kossebau [Mon, 7 Mar 2011 10:09:29 +0000 (11:09 +0100)]
Changes: only delete associated objects inside qct graph

RevBy: people-review

6 years agoChanges: set fetched details to readOnly if some resource is not in the qct or defaul...
Friedrich W. H. Kossebau [Mon, 7 Mar 2011 09:50:24 +0000 (10:50 +0100)]
Changes: set fetched details to readOnly if some resource is not in the qct or default graph

RevBy: people-review

Details:
QtContacts details can be set readOnly per detail, not field.
So for now if any resource is not owned by qct or in the default graph,
the whole detail will be set to readonly.
Not checked for ownership are currently:
SubTypes (by class and property)

6 years agoChanges: add property hasOwner to QTrackerContactDetailField
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 05:00:40 +0000 (06:00 +0100)]
Changes: add property hasOwner to QTrackerContactDetailField

RevBy: people-review

6 years agoRestore "Changes: pass fetched value to fetchField(...) and fetchCustomValues(.....
Friedrich W. H. Kossebau [Tue, 25 Jan 2011 10:46:08 +0000 (11:46 +0100)]
Restore "Changes: pass fetched value to fetchField(...) and fetchCustomValues(...) as QString, not QVariant" with a fix

This restores commit 8d14af761f4f5de0870a43a1ff4bfa01d7f0c57a.

RevBy: people-review

6 years agoChanges: start to use Select::isEmpty()
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 15:07:58 +0000 (16:07 +0100)]
Changes: start to use Select::isEmpty()

RevBy: TrustMe

6 years agoChanges: make all methods only used by QTrackerScalarContactQueryBuilder itself private
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 04:26:28 +0000 (05:26 +0100)]
Changes: make all methods only used by QTrackerScalarContactQueryBuilder itself private

RevBy: people-review

6 years agoChanges: minor code reduction
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 03:19:41 +0000 (04:19 +0100)]
Changes: minor code reduction

RevBy: people-review

6 years agoChanges: factor out "static void splitPropertiesIntoProjectionsAndRestrictions(...)"
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 03:04:24 +0000 (04:04 +0100)]
Changes: factor out "static void splitPropertiesIntoProjectionsAndRestrictions(...)"

RevBy: people-review

6 years agoChanges: factor out "static void bindDetailUri(...)"
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:50:11 +0000 (03:50 +0100)]
Changes: factor out "static void bindDetailUri(...)"

RevBy: people-review

6 years agoChanges: minor code reduction
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:37:25 +0000 (03:37 +0100)]
Changes: minor code reduction

RevBy: people-review

6 years agoChanges: add a FIXME note
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:30:47 +0000 (03:30 +0100)]
Changes: add a FIXME note

RevBy: TrustMe

6 years agoChanges: Print start and end time on top of test reports
Mathias Hasselmann [Tue, 15 Mar 2011 22:10:05 +0000 (23:10 +0100)]
Changes: Print start and end time on top of test reports

RevBy: TrustMe

6 years agoFixes: phoneutils.h is a public header
Jens Georg [Tue, 15 Mar 2011 16:03:34 +0000 (18:03 +0200)]
Fixes: phoneutils.h is a public header

RevBy: TrustMe

6 years agoDefinitely fix build
Adrien Bustany [Tue, 15 Mar 2011 14:51:03 +0000 (16:51 +0200)]
Definitely fix build

Details:
That's the kind of commit that is always followed by "argh, this time
definitely fix the build"

6 years agoFixes: remove left-over build-stamp.libcubi dep from build system
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 14:11:49 +0000 (15:11 +0100)]
Fixes: remove left-over build-stamp.libcubi dep from build system

RevBy: Adrien

6 years agoChanges: Tidy MR#140
Mathias Hasselmann [Tue, 15 Mar 2011 13:21:43 +0000 (14:21 +0100)]
Changes: Tidy MR#140

RevBy: TrustMe

6 years agoChanges: Externalize dependency to Cubi
Adrien Bustany [Fri, 11 Mar 2011 16:37:22 +0000 (18:37 +0200)]
Changes: Externalize dependency to Cubi

RevBy: TrustMe