Fixes: Properly detect empty detail filter values
authorMathias Hasselmann <mathias@openismus.com>
Mon, 14 Jun 2010 21:23:52 +0000 (23:23 +0200)
committerMurray Cumming <murrayc@murrayc.com>
Thu, 17 Jun 2010 07:40:40 +0000 (09:40 +0200)
commitf934de087ff2f7ec5d18b8401af9f6dc02cdba50
tree196cd50f53254d9928388df0789a318231f06696
parent693bc31f371df7212786b96c49c3e601e7e6d40b
Fixes: Properly detect empty detail filter values

RevBy: TrustMe
Details:

 * src/dao/conversion.cpp: makeValue():
   Check QUrl::isEmpty() instead of isValid() which is about encoding, not
   content.
 * src/dao/querybuilder.cpp: bindFilter():
   Do a real emptyness check for the detail filter value.
 * tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp:
   testIMContactsFiltering(): Use proper contact IRI. Use QCOMPARE() instead of
   QVERIFY() for checking the service's display name for better error messages.
src/dao/querybuilder.cpp
tests/ut_qtcontacts_trackerplugin/ut_qtcontacts_trackerplugin.cpp