qtcontacts-tracker:hasselmms-qtcontacts-tracker.git
6 years agoChanges: Rename functions on phoneutils.h to qctFunctionName
Adrien Bustany [Wed, 16 Mar 2011 09:43:22 +0000 (11:43 +0200)]
Changes: Rename functions on phoneutils.h to qctFunctionName

RevBy: TrustMe

6 years agoChanges: Update reference queries for MR#132
Mathias Hasselmann [Tue, 15 Mar 2011 22:09:01 +0000 (23:09 +0100)]
Changes: Update reference queries for MR#132

RevBy: TrustMe

6 years agoChanges: Tidy unit test of MR#132 a bit
Mathias Hasselmann [Tue, 15 Mar 2011 19:34:36 +0000 (20:34 +0100)]
Changes: Tidy unit test of MR#132 a bit

RevBy: TrustMe

6 years agoChanges: also log actual graph iri if value predicate is from other graph
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 11:18:29 +0000 (12:18 +0100)]
Changes: also log actual graph iri if value predicate is from other graph

RevBy: people-review

6 years agoChanges: add ut_qtcontacts_trackerplugin::testFetchingNonQctResourcesAsReadOnlyDetails()
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 02:40:48 +0000 (03:40 +0100)]
Changes: add ut_qtcontacts_trackerplugin::testFetchingNonQctResourcesAsReadOnlyDetails()

RevBy: people-review

6 years agoFixes: make manually concating the graph iri to values also work with the default...
Friedrich W. H. Kossebau [Thu, 10 Mar 2011 16:46:40 +0000 (17:46 +0100)]
Fixes: make manually concating the graph iri to values also work with the default graph

RevBy: people-review

6 years agoChanges: minor code improvement
Friedrich W. H. Kossebau [Thu, 10 Mar 2011 16:11:59 +0000 (17:11 +0100)]
Changes: minor code improvement

RevBy: people-review

Details:
move Variable last into smallest possible scope

6 years agoChanges: add helper function "PrefixFunction applyConcatWithGraph(...)"
Friedrich W. H. Kossebau [Wed, 9 Mar 2011 11:30:19 +0000 (12:30 +0100)]
Changes: add helper function "PrefixFunction applyConcatWithGraph(...)"

RevBy: people-review

6 years agoChanges: remove useless exception for fields with a foreign key on graph check
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 16:23:02 +0000 (17:23 +0100)]
Changes: remove useless exception for fields with a foreign key on graph check

RevBy: people-review

6 years agoChanges: rename var useGraph to needsGraphInRestrictions
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 16:09:26 +0000 (17:09 +0100)]
Changes: rename var useGraph to needsGraphInRestrictions

RevBy: TrustMe

6 years agoFixes: do not add graph iri for field with single predicate chain and without hasOwner
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 13:37:21 +0000 (14:37 +0100)]
Fixes: do not add graph iri for field with single predicate chain and without hasOwner

RevBy: people-review

6 years agoChanges: fix comment
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 12:07:41 +0000 (13:07 +0100)]
Changes: fix comment

RevBy: TrustMe

6 years agoFixes: only fetch graph for subtype-by-property field if it has hasOwner flag set
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 12:07:24 +0000 (13:07 +0100)]
Fixes: only fetch graph for subtype-by-property field if it has hasOwner flag set

RevBy: people-review

6 years agoChanges: remove dead code
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 11:39:47 +0000 (12:39 +0100)]
Changes: remove dead code

RevBy: Adrien

6 years agoChanges: remove left-over debugging code
Friedrich W. H. Kossebau [Tue, 8 Mar 2011 11:38:22 +0000 (12:38 +0100)]
Changes: remove left-over debugging code

RevBy: Adrien

6 years agoChanges: only delete associated objects inside qct graph
Friedrich W. H. Kossebau [Mon, 7 Mar 2011 10:09:29 +0000 (11:09 +0100)]
Changes: only delete associated objects inside qct graph

RevBy: people-review

6 years agoChanges: set fetched details to readOnly if some resource is not in the qct or defaul...
Friedrich W. H. Kossebau [Mon, 7 Mar 2011 09:50:24 +0000 (10:50 +0100)]
Changes: set fetched details to readOnly if some resource is not in the qct or default graph

RevBy: people-review

Details:
QtContacts details can be set readOnly per detail, not field.
So for now if any resource is not owned by qct or in the default graph,
the whole detail will be set to readonly.
Not checked for ownership are currently:
SubTypes (by class and property)

6 years agoChanges: add property hasOwner to QTrackerContactDetailField
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 05:00:40 +0000 (06:00 +0100)]
Changes: add property hasOwner to QTrackerContactDetailField

RevBy: people-review

6 years agoRestore "Changes: pass fetched value to fetchField(...) and fetchCustomValues(.....
Friedrich W. H. Kossebau [Tue, 25 Jan 2011 10:46:08 +0000 (11:46 +0100)]
Restore "Changes: pass fetched value to fetchField(...) and fetchCustomValues(...) as QString, not QVariant" with a fix

This restores commit 8d14af761f4f5de0870a43a1ff4bfa01d7f0c57a.

RevBy: people-review

6 years agoChanges: start to use Select::isEmpty()
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 15:07:58 +0000 (16:07 +0100)]
Changes: start to use Select::isEmpty()

RevBy: TrustMe

6 years agoChanges: make all methods only used by QTrackerScalarContactQueryBuilder itself private
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 04:26:28 +0000 (05:26 +0100)]
Changes: make all methods only used by QTrackerScalarContactQueryBuilder itself private

RevBy: people-review

6 years agoChanges: minor code reduction
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 03:19:41 +0000 (04:19 +0100)]
Changes: minor code reduction

RevBy: people-review

6 years agoChanges: factor out "static void splitPropertiesIntoProjectionsAndRestrictions(...)"
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 03:04:24 +0000 (04:04 +0100)]
Changes: factor out "static void splitPropertiesIntoProjectionsAndRestrictions(...)"

RevBy: people-review

6 years agoChanges: factor out "static void bindDetailUri(...)"
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:50:11 +0000 (03:50 +0100)]
Changes: factor out "static void bindDetailUri(...)"

RevBy: people-review

6 years agoChanges: minor code reduction
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:37:25 +0000 (03:37 +0100)]
Changes: minor code reduction

RevBy: people-review

6 years agoChanges: add a FIXME note
Friedrich W. H. Kossebau [Thu, 3 Feb 2011 02:30:47 +0000 (03:30 +0100)]
Changes: add a FIXME note

RevBy: TrustMe

6 years agoChanges: Print start and end time on top of test reports
Mathias Hasselmann [Tue, 15 Mar 2011 22:10:05 +0000 (23:10 +0100)]
Changes: Print start and end time on top of test reports

RevBy: TrustMe

6 years agoFixes: phoneutils.h is a public header
Jens Georg [Tue, 15 Mar 2011 16:03:34 +0000 (18:03 +0200)]
Fixes: phoneutils.h is a public header

RevBy: TrustMe

6 years agoDefinitely fix build
Adrien Bustany [Tue, 15 Mar 2011 14:51:03 +0000 (16:51 +0200)]
Definitely fix build

Details:
That's the kind of commit that is always followed by "argh, this time
definitely fix the build"

6 years agoFixes: remove left-over build-stamp.libcubi dep from build system
Friedrich W. H. Kossebau [Tue, 15 Mar 2011 14:11:49 +0000 (15:11 +0100)]
Fixes: remove left-over build-stamp.libcubi dep from build system

RevBy: Adrien

6 years agoChanges: Tidy MR#140
Mathias Hasselmann [Tue, 15 Mar 2011 13:21:43 +0000 (14:21 +0100)]
Changes: Tidy MR#140

RevBy: TrustMe

6 years agoChanges: Externalize dependency to Cubi
Adrien Bustany [Fri, 11 Mar 2011 16:37:22 +0000 (18:37 +0200)]
Changes: Externalize dependency to Cubi

RevBy: TrustMe

6 years agoChanges: Enable testFilterOnContactType
Adrien Bustany [Fri, 11 Mar 2011 17:38:45 +0000 (19:38 +0200)]
Changes: Enable testFilterOnContactType

RevBy: TrustMe

6 years agoFixes: NB#235995 - QContactDetailFilter doesn't support QContactType
Adrien Bustany [Fri, 11 Mar 2011 17:33:35 +0000 (19:33 +0200)]
Fixes: NB#235995 - QContactDetailFilter doesn't support QContactType

Bug: NB#235995
RevBy: TrustMe

6 years agoChanges: TIDY MR#138 a bit
Mathias Hasselmann [Tue, 15 Mar 2011 10:04:58 +0000 (11:04 +0100)]
Changes: TIDY MR#138 a bit

RevBy: TrustMe

6 years agoNew: Adds a testRemoveSelfContact test
Adrien Bustany [Mon, 14 Mar 2011 16:22:22 +0000 (18:22 +0200)]
New: Adds a testRemoveSelfContact test

RevBy: TrustMe
RevBy: people-review

6 years agoFixes: NB#225067 - It is possible to delete nco:default-contact-me using UI
Adrien Bustany [Mon, 14 Mar 2011 13:58:54 +0000 (15:58 +0200)]
Fixes: NB#225067 - It is possible to delete nco:default-contact-me using UI

Bug: NB#225067
RevBy: TrustMe
Details:
If the ID of the self contact is present in the ids to delete, it'll be
ignored, and an error will be set in the errorMap. All the other
contacts will still be deleted.

6 years agoChanges: Don't hardcode NoError in QTrackerAbstractRequest::handleQuerySuccess
Adrien Bustany [Mon, 14 Mar 2011 15:47:12 +0000 (17:47 +0200)]
Changes: Don't hardcode NoError in QTrackerAbstractRequest::handleQuerySuccess

RevBy: TrustMe
Details:
handleQuerySucess means that the Sparql side of the request went fine,
but that does not mean there are no other errors to emit.

6 years agoChanges: Rename lib/utils.* to lib/phoneutils.*
Mathias Hasselmann [Tue, 15 Mar 2011 09:56:47 +0000 (10:56 +0100)]
Changes: Rename lib/utils.* to lib/phoneutils.*

RevBy: TrustMe
Details: Thinks like "utils" or "misc" tend to end as garbage bins.

6 years agoChanges: Move makeLocalPhoneNumber and normalizePhoneNumber to the lib
Adrien Bustany [Mon, 14 Mar 2011 14:46:38 +0000 (16:46 +0200)]
Changes: Move makeLocalPhoneNumber and normalizePhoneNumber to the lib

RevBy: TrustMe

6 years agoChanges: Avoid some redundant work creating new contacts
Mathias Hasselmann [Fri, 11 Mar 2011 15:39:44 +0000 (16:39 +0100)]
Changes: Avoid some redundant work creating new contacts

RevBy: coco nuts
Details: Don't was time only deleting properties. For new contacts. Also just
insert computed GUID and creation timestamp for those.

6 years agoChanges: Don't update nco:contactLocalUID after saving
Mathias Hasselmann [Fri, 11 Mar 2011 14:42:14 +0000 (15:42 +0100)]
Changes: Don't update nco:contactLocalUID after saving

RevBy: coco nuts

6 years agoChanges: Use localtime for nie:contentLastModified in contact merge
Jens Georg [Fri, 11 Mar 2011 13:36:16 +0000 (15:36 +0200)]
Changes: Use localtime for nie:contentLastModified in contact merge

RevBy: coco
Details: Otherwise - due to Qt bug failing to append "Z" on toString() with
UTC times we end of with the wrong TZ offset as tracker interprets the UTC
time string as localtime.

6 years agoNew: ut_qtcontacts_trackerplugin::testAnniversary()
Mathias Hasselmann [Fri, 11 Mar 2011 13:21:45 +0000 (14:21 +0100)]
New: ut_qtcontacts_trackerplugin::testAnniversary()

RevBy: TrustMe

6 years agoChanges: Check for parallel parameter in debian/rules
Adrien Bustany [Fri, 11 Mar 2011 12:04:49 +0000 (14:04 +0200)]
Changes: Check for parallel parameter in debian/rules

RevBy: TrustMe

6 years agoPrepare harmattan/4.12.10-1
Mathias Hasselmann [Fri, 11 Mar 2011 11:42:25 +0000 (12:42 +0100)]
Prepare harmattan/4.12.10-1

6 years agoFixes: Explicitly run pre steps as user on CITA
Mathias Hasselmann [Fri, 11 Mar 2011 11:38:32 +0000 (12:38 +0100)]
Fixes: Explicitly run pre steps as user on CITA

RevBy: TrustMe

6 years agoRevert "Fixes: Workaround CITA running pre steps as root"
Mathias Hasselmann [Fri, 11 Mar 2011 11:34:56 +0000 (12:34 +0100)]
Revert "Fixes: Workaround CITA running pre steps as root"

This reverts commit 59bb4263e21123a6d12aa7b84f5ef8c440aa3ef9.

6 years agoFixes: Workaround CITA running pre steps as root
Mathias Hasselmann [Fri, 11 Mar 2011 11:29:43 +0000 (12:29 +0100)]
Fixes: Workaround CITA running pre steps as root

RevBy: TrustMe
Details: Run "tracker-control -rs" from QCT_TEST_MAIN() for now as we have
proper credentials there.

WE MUST REVERT THIS HACK ASAP!

6 years agoChanges: Augment the tests timeout even more
Adrien Bustany [Fri, 11 Mar 2011 11:10:03 +0000 (13:10 +0200)]
Changes: Augment the tests timeout even more

RevBy: TrustMe

6 years agoChanges: Don't decode unicode codepoints in query builder tests
Mathias Hasselmann [Thu, 10 Mar 2011 22:28:11 +0000 (23:28 +0100)]
Changes: Don't decode unicode codepoints in query builder tests

RevBy: TrustMe
Details: Encoding unicode codepoints makes it quite hard to check reference
queries - "\uXXXX" is much better to read than "?" and such.

6 years agoFixes: ut_qtcontacts_trackerplugin_querybuilder::testFetchRequestQuery
Mathias Hasselmann [Thu, 10 Mar 2011 22:31:34 +0000 (23:31 +0100)]
Fixes: ut_qtcontacts_trackerplugin_querybuilder::testFetchRequestQuery

RevBy: TrustMe

6 years agoChanges: minor improvement
Friedrich W. H. Kossebau [Thu, 10 Mar 2011 15:46:32 +0000 (16:46 +0100)]
Changes: minor improvement

RevBy: Jens

Details:
no need to fetch inverseObject again if it was only just inserted into the hash table

6 years agoChanges: Update FUTURE file
Mathias Hasselmann [Thu, 10 Mar 2011 07:25:43 +0000 (08:25 +0100)]
Changes: Update FUTURE file

RevBy: TrustMe

6 years agoChanges: Update reference queries for fetching individual details
Mathias Hasselmann [Thu, 10 Mar 2011 00:33:08 +0000 (01:33 +0100)]
Changes: Update reference queries for fetching individual details

RevBy: TrustMe
Details: Now 45 of the 63 query builder tests pass.

6 years agoFixes: Minor typo in few skipped reference query
Mathias Hasselmann [Wed, 9 Mar 2011 22:56:33 +0000 (23:56 +0100)]
Fixes: Minor typo in few skipped reference query

RevBy: TrustMe

6 years agoChanges: Use Latin1 instead of Ascii as there is the chance that it's not real Ascii...
Jens Georg [Tue, 1 Mar 2011 21:28:16 +0000 (23:28 +0200)]
Changes: Use Latin1 instead of Ascii as there is the chance that it's not real Ascii (see documentation of toAscii)

RevBy: coco

6 years agoChanges: Update generated ontologies to use QString for Iri
Jens Georg [Tue, 1 Mar 2011 20:45:43 +0000 (22:45 +0200)]
Changes: Update generated ontologies to use QString for Iri

RevBy: coco

6 years agoChanges: Use QString instead of QUrl for Iris
Jens Georg [Mon, 28 Feb 2011 18:44:18 +0000 (20:44 +0200)]
Changes: Use QString instead of QUrl for Iris

RevBy: coco

6 years agoFixes: Unbreak master
Mathias Hasselmann [Wed, 9 Mar 2011 15:57:30 +0000 (16:57 +0100)]
Fixes: Unbreak master

RevBy: cocos
Details: You find me into the shame corner.

6 years agoChanges: Preserve graph when merging contacts
Adrien Bustany [Mon, 28 Feb 2011 13:38:03 +0000 (15:38 +0200)]
Changes: Preserve graph when merging contacts

6 years agoUpdate Cubi to 284edbf8dd2ba52cb51a997014c2e1d1cd7fc31d
Mathias Hasselmann [Wed, 9 Mar 2011 15:13:21 +0000 (16:13 +0100)]
Update Cubi to 284edbf8dd2ba52cb51a997014c2e1d1cd7fc31d

6 years agoPrepare harmattan/4.12.9-1
Mathias Hasselmann [Wed, 9 Mar 2011 14:59:55 +0000 (15:59 +0100)]
Prepare harmattan/4.12.9-1

6 years agoNew: Add unit testing for QContactFavorite.
Robin Burchell [Tue, 8 Mar 2011 14:06:18 +0000 (14:06 +0000)]
New: Add unit testing for QContactFavorite.

RevBy: MR#134
Bug: BMC#14196
Details:

Performs the following steps:
 - Create a contact
 - Check there is no QContactFavorite
 - Favorite contact
 - Check favorite worked
 - Unfavorite contact
 - Check unfavorite worked

6 years agoChanges: Increase timeout of tests to 240 seconds
Adrien Bustany [Tue, 8 Mar 2011 15:24:54 +0000 (17:24 +0200)]
Changes: Increase timeout of tests to 240 seconds

RevBy: TrustMe
Details:
Some tests, like testFuzzing, take some time to finish on device

6 years agoChanges: Install ut_qtcontacts_trackerplugin_helper
Adrien Bustany [Tue, 8 Mar 2011 14:55:58 +0000 (16:55 +0200)]
Changes: Install ut_qtcontacts_trackerplugin_helper

6 years agoChanges: fix debian/rules after postinst script removal
Adrien Bustany [Tue, 8 Mar 2011 14:20:28 +0000 (16:20 +0200)]
Changes: fix debian/rules after postinst script removal

6 years agoChanges: install ut_qtcontacts_trackerplugin_settings_helper
Adrien Bustany [Tue, 8 Mar 2011 14:09:09 +0000 (16:09 +0200)]
Changes: install ut_qtcontacts_trackerplugin_settings_helper

6 years agoChanges: Remove the localUID postinst script
Adrien Bustany [Fri, 4 Mar 2011 08:56:24 +0000 (09:56 +0100)]
Changes: Remove the localUID postinst script

RevBy: TrustMe
Details:
That change should now be widely accepted.

6 years agoPrepare harmattan/4.12.8-1
Mathias Hasselmann [Tue, 8 Mar 2011 11:08:15 +0000 (12:08 +0100)]
Prepare harmattan/4.12.8-1

6 years agoFixes: Possible lock-up if the task is run really fast
Jens Georg [Mon, 7 Mar 2011 15:59:27 +0000 (17:59 +0200)]
Fixes: Possible lock-up if the task is run really fast

RevBy: coco

Details: Looks like that we could miss a wakeAll on very rare occasions

6 years agoChanges: Remove spam from insert query for foreign key objects.
Mathias Hasselmann [Tue, 8 Mar 2011 10:12:11 +0000 (11:12 +0100)]
Changes: Remove spam from insert query for foreign key objects.

RevBy: TrustMe
Details: Only insert parent property's range when it is different from the
property's domain.

6 years agoChanges: Delete associated objects via their foreign key value
Mathias Hasselmann [Mon, 7 Mar 2011 14:57:37 +0000 (15:57 +0100)]
Changes: Delete associated objects via their foreign key value

RevBy: MR#130
Details: Repairs testRemoveSubTypes

6 years agoChanges: Extract RelatedObjectInfo
Mathias Hasselmann [Mon, 7 Mar 2011 14:56:52 +0000 (15:56 +0100)]
Changes: Extract RelatedObjectInfo

RevBy: MR#130

6 years agoChanges: Update ut_qtcontacts_trackerplugin::testSavePhoneNumber() for tel: IRI removal
Mathias Hasselmann [Fri, 4 Mar 2011 21:25:12 +0000 (22:25 +0100)]
Changes: Update ut_qtcontacts_trackerplugin::testSavePhoneNumber() for tel: IRI removal

RevBy: MR#130

6 years agoChanges: Mark nco::phoneNumber as foreign key property in the detail schema
Mathias Hasselmann [Thu, 3 Mar 2011 22:11:15 +0000 (23:11 +0100)]
Changes: Mark nco::phoneNumber as foreign key property in the detail schema

RevBy: MR#130
Details: This permits reuse of phone number resources now that tel: IRI support is gone.

6 years agoChanges: Remove tel: IRI scheme
Mathias Hasselmann [Thu, 3 Mar 2011 22:10:04 +0000 (23:10 +0100)]
Changes: Remove tel: IRI scheme

RevBy: MR#130
Details: It caused major headaches when adding similar phone numbers to the same contact.

6 years agoNew: ut_qtcontacts_trackerplugin::testSimilarPhoneNumber()
Mathias Hasselmann [Fri, 4 Mar 2011 09:50:44 +0000 (10:50 +0100)]
New: ut_qtcontacts_trackerplugin::testSimilarPhoneNumber()

RevBy: MR#130
Details: Test that different contacts can have same phone number.

6 years agoChanges: Use "-maxwarnings 0" for test package
Mathias Hasselmann [Mon, 7 Mar 2011 14:48:28 +0000 (15:48 +0100)]
Changes: Use "-maxwarnings 0" for test package

RevBy: TrustMe

6 years agoUpdate tracker-sparql pc version to 0.10
Adrien Bustany [Tue, 1 Mar 2011 20:16:47 +0000 (22:16 +0200)]
Update tracker-sparql pc version to 0.10

6 years agoNew: ut_qtcontacts_trackerplugin::testSimilarPhoneNumber()
Mathias Hasselmann [Thu, 3 Mar 2011 21:36:07 +0000 (22:36 +0100)]
New: ut_qtcontacts_trackerplugin::testSimilarPhoneNumber()

RevBy: TrustMe
Details: Simulation of the main issue with tel: IRIs

6 years agoChanges: Show tracker error message when a save request task fails
Mathias Hasselmann [Thu, 3 Mar 2011 21:35:44 +0000 (22:35 +0100)]
Changes: Show tracker error message when a save request task fails

RevBy: TrustMe

6 years agoChanges: Bump tracker-runtime dependency to 0.10.0 for SQL variable fix
Jens Georg [Tue, 1 Mar 2011 21:43:04 +0000 (23:43 +0200)]
Changes: Bump tracker-runtime dependency to 0.10.0 for SQL variable fix

RevBy: coco

6 years agoFixes: Variables in filter don't contribute to SQL variables anymore, so this XFAIL...
Jens Georg [Mon, 28 Feb 2011 14:22:13 +0000 (16:22 +0200)]
Fixes: Variables in filter don't contribute to SQL variables anymore, so this XFAIL is void

RevBy: coco

6 years agoFixes: NB#231925 - Replace libcreds2-qt with mssf-qt
Mathias Hasselmann [Wed, 2 Mar 2011 09:43:27 +0000 (10:43 +0100)]
Fixes: NB#231925 - Replace libcreds2-qt with mssf-qt

RevBy: TrustMe

6 years agoChanges: Respect Murphy's law in OnlineAccountConversion
Mathias Hasselmann [Tue, 1 Mar 2011 19:34:49 +0000 (20:34 +0100)]
Changes: Respect Murphy's law in OnlineAccountConversion

RevBy: Friedrich

6 years agoChanges: Use better variable names in QContactTrackerEngine destructor
Mathias Hasselmann [Tue, 1 Mar 2011 20:48:05 +0000 (21:48 +0100)]
Changes: Use better variable names in QContactTrackerEngine destructor

RevBy: TrustMe

6 years agoChanges: Use const char* variant of qctWarn() in OnlineAccountConversion
Mathias Hasselmann [Tue, 1 Mar 2011 19:33:39 +0000 (20:33 +0100)]
Changes: Use const char* variant of qctWarn() in OnlineAccountConversion

RevBy: TrustMe

6 years agoFixes: accountPath in unit tests need to be all different to avoid clashes
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 17:31:39 +0000 (18:31 +0100)]
Fixes: accountPath in unit tests need to be all different to avoid clashes

RevBy: people-review

Details:
Otherwise this error messages is triggered:
"Unable to insert multiple values for subject
`telepathy:/org/freedesktop/fake/account/1' and
single valued property `nco:imDisplayName'
(old_value: 'roads.desert', new value: 'ovi1.com')

6 years agoFixes: solve warnings about "Invalid account path:"
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 17:28:50 +0000 (18:28 +0100)]
Fixes: solve warnings about "Invalid account path:"

RevBy: people-review

Details:
QContactOnlineAccount is expected to have an AccountPath atm

6 years agoFixes: ut_qtcontacts_trackerplugin::insertContact(...) was mixing serviceProvider...
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 15:00:36 +0000 (16:00 +0100)]
Fixes: ut_qtcontacts_trackerplugin::insertContact(...) was mixing serviceProvider with protocol

RevBy: people-review

6 years agoChanges: use "jabber" as default protocol in ut_qtcontacts_trackerplugin::insertConta...
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 14:12:56 +0000 (15:12 +0100)]
Changes: use "jabber" as default protocol in ut_qtcontacts_trackerplugin::insertContact(...)

RevBy: people-review

Details:
Both QtMobility and telepathy use "jabber" for XMPP (and Jabber)

6 years agoFixes: schema mistakenly set hasDetailUri for QContactOnlineAccount::FieldProtocol
Friedrich W. H. Kossebau [Sun, 27 Feb 2011 23:13:34 +0000 (00:13 +0100)]
Fixes: schema mistakenly set hasDetailUri for QContactOnlineAccount::FieldProtocol

RevBy: people-review

Details:
protocol name is not used for generation of detail uri,
cmp. also QTrackerContactSubject::makeIri...) which failed before
as values.count() was now 3, not 2

6 years agoChanges: add some temporary check if protocol names are all-lower-case or not
Friedrich W. H. Kossebau [Sun, 27 Feb 2011 22:47:00 +0000 (23:47 +0100)]
Changes: add some temporary check if protocol names are all-lower-case or not

RevBy: people-review

6 years agoRevert "Changes: add some temporary check if protocol names are all-lower-case or...
Jens Georg [Mon, 28 Feb 2011 13:01:47 +0000 (15:01 +0200)]
Revert "Changes: add some temporary check if protocol names are all-lower-case or not"

This reverts commit 20d974e8654712b575add6a0597d1992ee2e6820.

Ah yes, thanks gitorious. That was the wrong patch.

6 years agoChanges: add some temporary check if protocol names are all-lower-case or not
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 15:07:46 +0000 (16:07 +0100)]
Changes: add some temporary check if protocol names are all-lower-case or not

RevBy: people-review

6 years agoUpdate Cubi to efa9834aef170e608453f708f2ef8473a9d70ae4
Jens Georg [Mon, 28 Feb 2011 09:50:24 +0000 (11:50 +0200)]
Update Cubi to efa9834aef170e608453f708f2ef8473a9d70ae4

6 years agoFixes: adapt unit test to new pattern for display label with last name first
Friedrich W. H. Kossebau [Fri, 25 Feb 2011 15:21:45 +0000 (16:21 +0100)]
Fixes: adapt unit test to new pattern for display label with last name first

RevBy: Adrien

6 years agoChanges: Use more efficient QMultiHash::contains in merge request
Adrien Bustany [Thu, 24 Feb 2011 20:10:53 +0000 (22:10 +0200)]
Changes: Use more efficient QMultiHash::contains in merge request

RevBy: TrustMe

6 years agoFixes: NB#218724 - Display of the contact name is call history view is incorrect
Adrien Bustany [Thu, 24 Feb 2011 19:45:02 +0000 (21:45 +0200)]
Fixes: NB#218724 - Display of the contact name is call history view is incorrect

RevBy: TrustMe