qtcontacts-tracker:hasselmms-qtcontacts-tracker.git
6 years agoChanges: Add Cubi::ResourceValue qctMakePhoneNumberResource(QString, QStringList)
Xavier Claessens [Wed, 13 Apr 2011 07:37:28 +0000 (09:37 +0200)]
Changes: Add Cubi::ResourceValue qctMakePhoneNumberResource(QString, QStringList)

6 years agoRemove dao/cubidefines.h and bump cubi dep
Xavier Claessens [Mon, 11 Apr 2011 12:02:49 +0000 (14:02 +0200)]
Remove dao/cubidefines.h and bump cubi dep

Those are now part of cubi API

6 years agoChanges: Compact weak sync target list when "all" is found in list.
Mathias Hasselmann [Mon, 11 Apr 2011 19:05:37 +0000 (21:05 +0200)]
Changes: Compact weak sync target list when "all" is found in list.

RevBy: Adrien

6 years agoFixes: Fixes use proper paramenter name for weak sync targets
Mathias Hasselmann [Mon, 11 Apr 2011 19:05:12 +0000 (21:05 +0200)]
Fixes: Fixes use proper paramenter name for weak sync targets

RevBy: Adrien

6 years agoChanges: Tidy MR#168
Mathias Hasselmann [Mon, 11 Apr 2011 13:15:35 +0000 (15:15 +0200)]
Changes: Tidy MR#168

RevBy: TrustMe

6 years agoChanges: Add an engine parameter for sync target mangling
Adrien Bustany [Wed, 6 Apr 2011 14:29:19 +0000 (17:29 +0300)]
Changes: Add an engine parameter for sync target mangling

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.7-1
Mathias Hasselmann [Mon, 11 Apr 2011 10:56:17 +0000 (12:56 +0200)]
Prepare harmattan/4.13.7-1

6 years agoChanges: Don't run garbage collector when saving only one contact
Mathias Hasselmann [Mon, 11 Apr 2011 10:25:28 +0000 (12:25 +0200)]
Changes: Don't run garbage collector when saving only one contact

RevBy: TrustMe
Details: Hotfix for making contact editor more responsive.

6 years agoChanges: Also test qctMakePhoneNumberResource
Mathias Hasselmann [Mon, 11 Apr 2011 10:22:30 +0000 (12:22 +0200)]
Changes: Also test qctMakePhoneNumberResource

RevBy: TrustMe

6 years agoFixes: Use proper regex in ut_qtcontacts_trackerplugin_querybuilder::testPhoneNumberIRI
Mathias Hasselmann [Mon, 11 Apr 2011 10:20:41 +0000 (12:20 +0200)]
Fixes: Use proper regex in ut_qtcontacts_trackerplugin_querybuilder::testPhoneNumberIRI

RevBy: TrustMe

6 years agoChanges: Add a ResourceValue helper for normalized number IRIs
Adrien Bustany [Mon, 11 Apr 2011 08:58:10 +0000 (11:58 +0300)]
Changes: Add a ResourceValue helper for normalized number IRIs

RevBy: TrustMe

6 years agoChanges: Add an escape parameter to phone IRI generation methods
Adrien Bustany [Mon, 11 Apr 2011 08:57:43 +0000 (11:57 +0300)]
Changes: Add an escape parameter to phone IRI generation methods

RevBy: TrustMe

6 years agoNew: Template version of QTrackerContactDetailSchema::detail()
Mathias Hasselmann [Sun, 10 Apr 2011 22:01:09 +0000 (00:01 +0200)]
New: Template version of QTrackerContactDetailSchema::detail()

RevBy: TrustMe

6 years agoChanges: Remove generated detail uris
Jens Georg [Wed, 6 Apr 2011 11:30:08 +0000 (14:30 +0300)]
Changes: Remove generated detail uris

RevBy: coco heads

6 years agoFixes: Don't queue resolver task like crazy chicken
Mathias Hasselmann [Fri, 8 Apr 2011 10:33:00 +0000 (12:33 +0200)]
Fixes: Don't queue resolver task like crazy chicken

RevBy: Adrien
Details: Works arround schemalister freezing by QtSparql bug.

6 years agoChanges: Remove wrong copyright file
Jens Georg [Fri, 8 Apr 2011 14:00:36 +0000 (17:00 +0300)]
Changes: Remove wrong copyright file

RevBy: TrustMe

6 years agoChanges: Add libqtcontacts-tracker to XB-Maemo-CI-Packages
Adrien Bustany [Fri, 8 Apr 2011 12:30:20 +0000 (15:30 +0300)]
Changes: Add libqtcontacts-tracker to XB-Maemo-CI-Packages

RevBy: TrustMe

6 years agoChanges: Cleanup abstract request a bit.
Mathias Hasselmann [Fri, 8 Apr 2011 10:24:21 +0000 (12:24 +0200)]
Changes: Cleanup abstract request a bit.

RevBy: TrustMe
Details: Shuffle a few declarations

6 years agoFixes: ut_qtcontacts_trackerplugin_resourcecache::testSchemaIds for QctQueue
Mathias Hasselmann [Fri, 8 Apr 2011 00:23:01 +0000 (02:23 +0200)]
Fixes: ut_qtcontacts_trackerplugin_resourcecache::testSchemaIds for QctQueue

RevBy: TrustMe

6 years agoChanges: Tidy MR#149
Mathias Hasselmann [Fri, 8 Apr 2011 00:22:42 +0000 (02:22 +0200)]
Changes: Tidy MR#149

RevBy: TrustMe

6 years agoChanges: Add a queue to the engine
Adrien Bustany [Fri, 18 Feb 2011 13:51:06 +0000 (15:51 +0200)]
Changes: Add a queue to the engine

RevBy: TrustMe
Details:
Queue items are subclasses of the QctTask class. The lifetime of a
QctTask is handled either by the task itself (calling deleteLater when
it's done) or by QObject parenting. The tasks does not own external
objects, that is, QctResolverTask can delete the resolver because it
created it, but QctRequestTask does not delete the request. QctTask is a
controller, not a wrapper.
QctQueue is NOT reentrant, that means if you nest calls modifying the
queue, you'll hit a deadlock. To make the queue reentrant, we'd have to
move some method calls to the mainloop, but then that fails is no global
mainloop is running, which is the case for tests for example.

6 years agoChanges: Rename QctRequestTask to QctSyncRequestTask
Adrien Bustany [Mon, 21 Mar 2011 12:54:06 +0000 (14:54 +0200)]
Changes: Rename QctRequestTask to QctSyncRequestTask

RevBy: TrustMe

6 years agoChanges: add QContactRingtone example to testFetchingNonQctResourcesAsReadOnlyDetails...
Friedrich W. H. Kossebau [Thu, 7 Apr 2011 17:14:42 +0000 (19:14 +0200)]
Changes: add QContactRingtone example to testFetchingNonQctResourcesAsReadOnlyDetails_data()

RevBy: coco-heads

6 years agoChanges: adapts testFetchingNonQctResourcesAsReadOnlyDetails() to have shared resourc...
Friedrich W. H. Kossebau [Thu, 7 Apr 2011 16:38:10 +0000 (18:38 +0200)]
Changes: adapts testFetchingNonQctResourcesAsReadOnlyDetails() to have shared resources in other graph

RevBy: coco-heads

6 years agoChanges: only do coalesce with empty string on single-value predicate functions
Friedrich W. H. Kossebau [Thu, 7 Apr 2011 10:27:04 +0000 (12:27 +0200)]
Changes: only do coalesce with empty string on single-value predicate functions

RevBy: coco-heads

Details:
with an unbound triple a predicate function for a multi-valued predicate
will return "", but for a single-valued will return null.

6 years agoChanges: remove OnlineAccountProtocolConversion, no longer needed
Friedrich W. H. Kossebau [Thu, 7 Apr 2011 10:53:38 +0000 (12:53 +0200)]
Changes: remove OnlineAccountProtocolConversion, no longer needed

RevBy: coco-heads

Details:
http://bugreports.qt.nokia.com/browse/QTMOBILITY-1282 got fixed,
so protocol ids of Qt Mobility and telepathy are identical now

6 years agoChanges: Add a QString version of qctMakePhoneNumberIri
Adrien Bustany [Thu, 7 Apr 2011 10:29:38 +0000 (13:29 +0300)]
Changes: Add a QString version of qctMakePhoneNumberIri

RevBy: TrustMe
Details:
Commhistory daemon does not use mobility classes, so that version is
more convenient for them

6 years agoPrepare harmattan/4.13.6-1
Mathias Hasselmann [Thu, 7 Apr 2011 09:43:42 +0000 (11:43 +0200)]
Prepare harmattan/4.13.6-1

6 years agoFixes: Remove unused function
Mathias Hasselmann [Wed, 6 Apr 2011 23:40:20 +0000 (01:40 +0200)]
Fixes: Remove unused function

RevBy: g++

6 years agoFixes: Compiler warning
Mathias Hasselmann [Wed, 6 Apr 2011 23:24:53 +0000 (01:24 +0200)]
Fixes: Compiler warning

RevBy: TrustMe

6 years agoChanges: Add unit test for phone number IRI generation
Adrien Bustany [Wed, 6 Apr 2011 10:49:58 +0000 (13:49 +0300)]
Changes: Add unit test for phone number IRI generation

RevBy: TrustMe

6 years agoChanges: Add method to generate phone number IRIs to the lib
Adrien Bustany [Tue, 5 Apr 2011 14:40:24 +0000 (17:40 +0300)]
Changes: Add method to generate phone number IRIs to the lib

RevBy: TrustMe

6 years agoNew: Add .spec file for meego
Mathias Hasselmann [Wed, 6 Apr 2011 20:47:32 +0000 (22:47 +0200)]
New: Add .spec file for meego

RevBy: TrustMe
Details: Taken from Adriens OBS repository. Still need to figure out what to
do with it.

6 years agoChanges: Update .gitignore file
Mathias Hasselmann [Wed, 6 Apr 2011 20:43:20 +0000 (22:43 +0200)]
Changes: Update .gitignore file

RevBy: TrustMe

6 years agoChanges: Work around missing -e switch in dash's builtin echo
Mathias Hasselmann [Wed, 6 Apr 2011 20:08:34 +0000 (22:08 +0200)]
Changes: Work around missing -e switch in dash's builtin echo

RevBy: TrustMe
Details: https://bugs.launchpad.net/ubuntu/+source/dash/+bug/72167

6 years agoFixes: restrictions chain was inverted in splitPropertiesIntoProjectionsAndRestrictio...
Friedrich W. H. Kossebau [Wed, 6 Apr 2011 15:51:56 +0000 (17:51 +0200)]
Fixes: restrictions chain was inverted in splitPropertiesIntoProjectionsAndRestrictions(...)

RevBy: TrustMe (because I actually ran the testsuite ;) )

6 years agoChanges: Tidy[?] splitPropertiesIntoProjectionsAndRestrictions() a bit
Mathias Hasselmann [Wed, 6 Apr 2011 13:10:21 +0000 (15:10 +0200)]
Changes: Tidy[?] splitPropertiesIntoProjectionsAndRestrictions() a bit

RevBy: TrustMe

6 years agoChanges: adapt reference queries for defining readonlyness with shared resources
Friedrich W. H. Kossebau [Thu, 31 Mar 2011 17:01:16 +0000 (19:01 +0200)]
Changes: adapt reference queries for defining readonlyness with shared resources

RevBy: coco-heads

Details:
with values from shared resources the graph is now fetched from the predicate
to the shared resource

6 years agoFixes: define readonlyness with shared resources only by the predicate to them
Friedrich W. H. Kossebau [Wed, 30 Mar 2011 09:36:40 +0000 (11:36 +0200)]
Fixes: define readonlyness with shared resources only by the predicate to them

RevBy: coco-heads

6 years agoChanges: add property definesOwnership to PropertyInfoBase and ContactDetailField
Friedrich W. H. Kossebau [Thu, 31 Mar 2011 19:50:08 +0000 (21:50 +0200)]
Changes: add property definesOwnership to PropertyInfoBase and ContactDetailField

RevBy: coco-heads

6 years agoChanges: remove unneeded parameter "strict" in splitPropertiesIntoProjectionsAndRestr...
Friedrich W. H. Kossebau [Tue, 29 Mar 2011 14:56:58 +0000 (16:56 +0200)]
Changes: remove unneeded parameter "strict" in splitPropertiesIntoProjectionsAndRestrictions()

RevBy: people-review

Details:
there is only one user of that internal method who always uses "strict = false"

6 years agoChanges: RelationshipRemoveRequest: Don't call emitResult from start()
Adrien Bustany [Thu, 31 Mar 2011 17:06:33 +0000 (20:06 +0300)]
Changes: RelationshipRemoveRequest: Don't call emitResult from start()

RevBy: TrustMe

6 years agoChanges: RelationshipFetchRequest: Don't call emitResult from start()
Adrien Bustany [Thu, 31 Mar 2011 17:01:46 +0000 (20:01 +0300)]
Changes: RelationshipFetchRequest: Don't call emitResult from start()

RevBy: TrustMe

6 years agoChanges: RelationshipSaveRequest: Avoid spawning empty QSparqlQuery
Adrien Bustany [Thu, 31 Mar 2011 16:43:37 +0000 (19:43 +0300)]
Changes: RelationshipSaveRequest: Avoid spawning empty QSparqlQuery

RevBy: TrustMe
Details:
If no relations could be saved, the SPARQL query is empty, and there is
no need to make an IPC call for that.

6 years agoChanges: RelationshipSaveRequest: don't call emitResult from start
Adrien Bustany [Thu, 31 Mar 2011 16:29:43 +0000 (19:29 +0300)]
Changes: RelationshipSaveRequest: don't call emitResult from start

RevBy: TrustMe
Details:
Calling emitResult from start without passing by the mainloop can
create reentrency issues.

6 years agoChanges: Add emitResultLater to abstract request class
Adrien Bustany [Tue, 5 Apr 2011 06:34:19 +0000 (09:34 +0300)]
Changes: Add emitResultLater to abstract request class

RevBy: TrustMe
Details:
Because Qt can forward signals without using the mainloop when both the
emitter and the receiver are in the same thread, a call to the start()
method can trigger a request update *before* the call to start()
actually returns. This can cause reentrancy problems, so we avoid it by
forcing a call through the main loop.

6 years agoChanges: Print the app path for missing AEGIS credentials
Xavier Claessens [Wed, 6 Apr 2011 07:55:51 +0000 (09:55 +0200)]
Changes: Print the app path for missing AEGIS credentials

RevBy: coconuts
Details: It is hard to find the offending process otherwise.

6 years agoPrepare harmattan/4.13.5-1
Mathias Hasselmann [Tue, 5 Apr 2011 09:32:28 +0000 (11:32 +0200)]
Prepare harmattan/4.13.5-1

6 years agoChanges: Tidy MR#163
Mathias Hasselmann [Mon, 4 Apr 2011 23:01:27 +0000 (01:01 +0200)]
Changes: Tidy MR#163

RevBy: TrustMe

6 years agoNew: Add fetch benchmark
Adrien Bustany [Wed, 16 Mar 2011 18:47:54 +0000 (20:47 +0200)]
New: Add fetch benchmark

RevBy: TrustMe

6 years agoChanges: Remove obsolete "optional" attribute from ResourceInfo
Mathias Hasselmann [Mon, 4 Apr 2011 22:47:39 +0000 (00:47 +0200)]
Changes: Remove obsolete "optional" attribute from ResourceInfo

RevBy: Jens

6 years agoChanges: Update reference queries
Mathias Hasselmann [Mon, 4 Apr 2011 22:37:39 +0000 (00:37 +0200)]
Changes: Update reference queries

RevBy: TrustMe

6 years agoFixes: Fix property chain for ncal:dtstart
Jens Georg [Tue, 22 Mar 2011 12:47:05 +0000 (14:47 +0200)]
Fixes: Fix property chain for ncal:dtstart

RevBy: coco heads

6 years agoChanges: adapt reference queries, variable to iri projections in fn:concat no longer...
Friedrich W. H. Kossebau [Mon, 4 Apr 2011 14:14:35 +0000 (16:14 +0200)]
Changes: adapt reference queries, variable to iri projections in fn:concat no longer need str()

RevBy: coco-heads

6 years agoChanges: no longer needed to force cast to iri with str() in projection of variable...
Friedrich W. H. Kossebau [Mon, 4 Apr 2011 14:01:35 +0000 (16:01 +0200)]
Changes: no longer needed to force cast to iri with str() in projection of variable in fn:concat

RevBy: coco-heads

6 years agoChanges: adapt reference queries, graph variable projection no longer wrapped with...
Friedrich W. H. Kossebau [Mon, 4 Apr 2011 13:06:28 +0000 (15:06 +0200)]
Changes: adapt reference queries, graph variable projection no longer wrapped with str()

RevBy: coco-heads

6 years agoChanges: no longer wrap graph variable projection with str()
Friedrich W. H. Kossebau [Fri, 1 Apr 2011 15:09:04 +0000 (17:09 +0200)]
Changes: no longer wrap graph variable projection with str()

RevBy: coco-heads

6 years agoChanges: Add virtual destructor to RelatedObjectInfoData
Adrien Bustany [Sat, 26 Mar 2011 18:34:49 +0000 (20:34 +0200)]
Changes: Add virtual destructor to RelatedObjectInfoData

RevBy: TrustMe
Details:
Classes deriving from RelatedObjectInfoData leak if the destructor is
not virtual.

6 years agoChanges: Add virtual destructor in QctSparqlResolverData
Adrien Bustany [Sat, 26 Mar 2011 17:50:08 +0000 (19:50 +0200)]
Changes: Add virtual destructor in QctSparqlResolverData

RevBy: TrustMe
Details:
Without this destructor, all members in children classes are leaked

6 years agoChanges: Delete QSparqlResults as they finish in save request
Adrien Bustany [Sat, 26 Mar 2011 15:52:26 +0000 (17:52 +0200)]
Changes: Delete QSparqlResults as they finish in save request

RevBy: TrustMe
Details:
Each QSparqlResult keeps a reference to the QString holding the SPARQL
query. When saving lots of contacts, those queries take a lot of heap.

6 years agoChanges: Use const where possible
Adrien Bustany [Fri, 25 Mar 2011 11:40:02 +0000 (13:40 +0200)]
Changes: Use const where possible

RevBy: TrustMe
Details:
(Based on a patch by Jens)

6 years agoFixes: testTelepathyIriConversion broke with 7f7abac58afd68cdb45d341ec267a4a246858559
Jens Georg [Thu, 31 Mar 2011 12:16:59 +0000 (15:16 +0300)]
Fixes: testTelepathyIriConversion broke with 7f7abac58afd68cdb45d341ec267a4a246858559

RevBy: TrustMe

6 years agoFixes: testIMContactsFiltering with tracker 0.10.5
Jens Georg [Thu, 31 Mar 2011 11:25:21 +0000 (14:25 +0300)]
Fixes: testIMContactsFiltering with tracker 0.10.5

RevBy: Adrien
Details: Tracker tightened some constraints on nie:url

6 years agoFixes: Use proper variant type in TelepathyConversion::makeValue
Mathias Hasselmann [Thu, 31 Mar 2011 09:38:41 +0000 (11:38 +0200)]
Fixes: Use proper variant type in TelepathyConversion::makeValue

RevBy: TrustMe
Details: Original patch by Adrien

6 years agoFixes: NB#239457 - libqtcontacts-tracker-dbg should be split
Adrien Bustany [Thu, 31 Mar 2011 06:12:08 +0000 (09:12 +0300)]
Fixes: NB#239457 - libqtcontacts-tracker-dbg should be split

RevBy: TrustMe

6 years agoFixes: testVCardsAndSync failing if testfiles are not writable by user running tests
Jens Georg [Wed, 30 Mar 2011 17:34:53 +0000 (20:34 +0300)]
Fixes: testVCardsAndSync failing if testfiles are not writable by user running tests

RevBy: coco heads
Details: QDir::DirsLast is not a QDir::Filter but a QDir::SortFlag. It was
used in QDir::Filter in the test; the corresponding QDir::Filter enum is
QDir::Writable. Also QDir::Dirs | QDir::AllDirs can be reduced to
QDir::AllDirs

6 years agoFixes: Potential lock-up when trying to remove the self-contact
Jens Georg [Tue, 29 Mar 2011 11:22:04 +0000 (14:22 +0300)]
Fixes: Potential lock-up when trying to remove the self-contact

RevBy: coco heads

6 years agoFixes: Overwrite mode of batch saving benchmark
Mathias Hasselmann [Tue, 29 Mar 2011 07:54:06 +0000 (09:54 +0200)]
Fixes: Overwrite mode of batch saving benchmark

RevBy: TrustMe
Details: Overwrite mode actually created new contacts since the tracker:id() switch.

6 years agoChanges: Permit patch level in configure script
Mathias Hasselmann [Mon, 28 Mar 2011 12:37:33 +0000 (14:37 +0200)]
Changes: Permit patch level in configure script

RevBy: TrustMe

6 years agoFixes: Don't report finished state with first save request error already
Mathias Hasselmann [Mon, 28 Mar 2011 11:08:28 +0000 (13:08 +0200)]
Fixes: Don't report finished state with first save request error already

RevBy: Jens
Details: ...with other contacts are pending still.

6 years agoFixes: NB#239930 - don't create a event loop in the ctor
Jens Georg [Fri, 25 Mar 2011 16:12:21 +0000 (18:12 +0200)]
Fixes: NB#239930 - don't create a event loop in the ctor

Bug: NB#239930
RevBy: coco heads

6 years agoFixes: NB#240602 - Segfault in savesaverequest when QtSparql reports error
Mathias Hasselmann [Mon, 28 Mar 2011 09:37:20 +0000 (11:37 +0200)]
Fixes: NB#240602 - Segfault in savesaverequest when QtSparql reports error

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.4-1
Mathias Hasselmann [Fri, 25 Mar 2011 13:28:23 +0000 (14:28 +0100)]
Prepare harmattan/4.13.4-1

6 years agoFixes: Add missing logger files
Mathias Hasselmann [Fri, 25 Mar 2011 13:26:39 +0000 (14:26 +0100)]
Fixes: Add missing logger files

RevBy: TrustMe

6 years agoPrepare harmattan/4.13.3-1
Mathias Hasselmann [Fri, 25 Mar 2011 13:13:31 +0000 (14:13 +0100)]
Prepare harmattan/4.13.3-1

6 years agoChanges: Shuffle few utility functions to avoid forward declarations.
Mathias Hasselmann [Fri, 25 Mar 2011 13:03:11 +0000 (14:03 +0100)]
Changes: Shuffle few utility functions to avoid forward declarations.

RevBy: TrustMe

6 years agoChanges: add ut::testMultipleUrls()
Friedrich W. H. Kossebau [Thu, 24 Mar 2011 14:08:41 +0000 (15:08 +0100)]
Changes: add ut::testMultipleUrls()

RevBy: people-review

Details:
tests storing and fetching of 2 urls with all combinations of subtype and context
all contacts are stored and fetched in one go,
not done with a _data method, to speed-up the test, as requested

6 years agoChanges: Move QctLogger to the extension library
Mathias Hasselmann [Fri, 25 Mar 2011 12:36:52 +0000 (13:36 +0100)]
Changes: Move QctLogger to the extension library

RevBy: TrustMe
Details: Mark the header as private as it is not generally useful.

6 years agoChanges: Move avatar generation method to the lib
Adrien Bustany [Thu, 24 Mar 2011 09:25:12 +0000 (11:25 +0200)]
Changes: Move avatar generation method to the lib

RevBy: TrustMe

6 years agoNew: Apply some match flags to filters with instance matching
Mathias Hasselmann [Fri, 25 Mar 2011 00:56:19 +0000 (01:56 +0100)]
New: Apply some match flags to filters with instance matching

RevBy: TrustMe

6 years agoChanges: Repair detail filter for simple cases of instance matching
Mathias Hasselmann [Thu, 24 Mar 2011 23:43:18 +0000 (00:43 +0100)]
Changes: Repair detail filter for simple cases of instance matching

RevBy: TrustMe

6 years agoChanges: Rewrite detail filters with empty field into union filter
Mathias Hasselmann [Thu, 24 Mar 2011 21:26:41 +0000 (22:26 +0100)]
Changes: Rewrite detail filters with empty field into union filter

RevBy: TrustMe
Details: This restores behavior of the old scary builder. It avoids bugs by
reusing existing code. Without such habit it is hard if not impossible to
consider all special cases in each code path.

6 years agoChanges: Move resource() attribute to ResourceInfo class
Mathias Hasselmann [Thu, 24 Mar 2011 14:19:48 +0000 (15:19 +0100)]
Changes: Move resource() attribute to ResourceInfo class

RevBy: TrustMe

6 years agoChanges: Micro-optimize hasDTMFCodes check
Mathias Hasselmann [Thu, 24 Mar 2011 14:17:54 +0000 (15:17 +0100)]
Changes: Micro-optimize hasDTMFCodes check

RevBy: TrustMe
Details: Do inexpensive tests first.

6 years agoChanges: Propagate error codes for bindInstanceValues()
Mathias Hasselmann [Thu, 24 Mar 2011 10:07:14 +0000 (11:07 +0100)]
Changes: Propagate error codes for bindInstanceValues()

RevBy: Friedrich

6 years agoChanges: adapt reference queries, no more GROUP_CONCAT on results for single-valued...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 16:13:03 +0000 (17:13 +0100)]
Changes: adapt reference queries, no more GROUP_CONCAT on results for single-valued nco:gender

RevBy: Mathias

6 years agoChanges: do not GROUP_CONCAT on results for single-valued values-by-instances
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 16:00:09 +0000 (17:00 +0100)]
Changes: do not GROUP_CONCAT on results for single-valued values-by-instances

RevBy: Mathias

6 years agoChanges: adapt reference queries, values-by-instances are now fetched with graph...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:21:31 +0000 (14:21 +0100)]
Changes: adapt reference queries, values-by-instances are now fetched with graph appended

RevBy: people-review

6 years agoChanges: no longer skip ut::testFetchingNonQctResourcesAsReadOnlyDetails() for QConta...
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:19:56 +0000 (14:19 +0100)]
Changes: no longer skip ut::testFetchingNonQctResourcesAsReadOnlyDetails() for QContactGender

RevBy: people-review

6 years agoChanges: fetch values-by-instances with graph as well
Friedrich W. H. Kossebau [Wed, 23 Mar 2011 13:17:48 +0000 (14:17 +0100)]
Changes: fetch values-by-instances with graph as well

RevBy: people-review

6 years agoChanges: Use integer literals for tracker:id() based filters
Mathias Hasselmann [Thu, 24 Mar 2011 10:02:31 +0000 (11:02 +0100)]
Changes: Use integer literals for tracker:id() based filters

RevBy: TrustMe

6 years agoChanges: Update reference queries for filters
Mathias Hasselmann [Thu, 24 Mar 2011 01:11:22 +0000 (02:11 +0100)]
Changes: Update reference queries for filters

RevBy: TrustMe

6 years agoChanges: Highlight "Significant Tests" line if there are failed tests
Mathias Hasselmann [Thu, 24 Mar 2011 01:10:27 +0000 (02:10 +0100)]
Changes: Highlight "Significant Tests" line if there are failed tests

RevBy: TrustMe

6 years agoFixes: Query generated for detail filter with empty field
Mathias Hasselmann [Thu, 24 Mar 2011 00:49:14 +0000 (01:49 +0100)]
Fixes: Query generated for detail filter with empty field

RevBy: TrustMe
Details: Properly enumerate the EXISTS expression list.
Cookies: Adrien for not updating the reference query. Friedrich for putting a
comment, but not fixing the loop.

6 years agoFixes: Handling of range flags in the scary builder
Mathias Hasselmann [Wed, 23 Mar 2011 23:30:07 +0000 (00:30 +0100)]
Fixes: Handling of range flags in the scary builder

RevBy: TrustMe
Details: Copy rangeFlags() when rewriting the range filter. Consider that
IncludeLower is zero, when selecting operators.

Adrien, cookies please! For not updating the reference query.

6 years agoFixes: Expected detail schema for ut_qtcontacts_trackerplugin_querybuilder::testDetai...
Mathias Hasselmann [Wed, 23 Mar 2011 22:31:21 +0000 (23:31 +0100)]
Fixes: Expected detail schema for ut_qtcontacts_trackerplugin_querybuilder::testDetailSchema()

RevBy: TrustMe

6 years agoChanges: Add missing test data files in ut_qtcontacts_trackerplugin_tests.pro
Adrien Bustany [Wed, 23 Mar 2011 16:59:47 +0000 (18:59 +0200)]
Changes: Add missing test data files in ut_qtcontacts_trackerplugin_tests.pro

RevBy: TrustMe

6 years agoChanges: Sanitize error handling in scalar query builder
Adrien Bustany [Mon, 21 Mar 2011 11:42:47 +0000 (13:42 +0200)]
Changes: Sanitize error handling in scalar query builder

RevBy: TrustMe
Details:
This commit makes all the functions that can fail in the scalar QB
return a QContactManager::Error, instead of returning a boolean
(sometimes) and setting an error in m_error (for the few methods which
used to do it). Since m_error is not used anymore, the error() method is
removed.

6 years agoPrepare harmattan/4.13.2-1
Mathias Hasselmann [Wed, 23 Mar 2011 12:56:37 +0000 (13:56 +0100)]
Prepare harmattan/4.13.2-1

6 years agoChanges: Fix return value logic in union/intersection bindFilter
Adrien Bustany [Mon, 21 Mar 2011 11:42:07 +0000 (13:42 +0200)]
Changes: Fix return value logic in union/intersection bindFilter

RevBy: TrustMe