qtcontacts-tracker:hasselmms-contactsd.git
6 years agobirthday: Don't set -e option in with-daemon.sh
Adrien Bustany [Thu, 3 Nov 2011 16:42:46 +0000 (18:42 +0200)]
birthday: Don't set -e option in with-daemon.sh

We still want to call cleanup() if the test fails

6 years agobirthday: Bump timeout for locale change test too
Adrien Bustany [Thu, 3 Nov 2011 16:42:33 +0000 (18:42 +0200)]
birthday: Bump timeout for locale change test too

6 years agotelepathy: Don't delete avatar if missing in initial roster
Adrien Bustany [Thu, 3 Nov 2011 15:37:41 +0000 (17:37 +0200)]
telepathy: Don't delete avatar if missing in initial roster

6 years agoPrepare to release 1.0.18-1
Adrien Bustany [Thu, 3 Nov 2011 13:26:15 +0000 (15:26 +0200)]
Prepare to release 1.0.18-1

6 years agotelepathy: Don't keep a ref to the CDTpContact in CDTpAvatarUpdate
Adrien Bustany [Thu, 3 Nov 2011 11:57:49 +0000 (13:57 +0200)]
telepathy: Don't keep a ref to the CDTpContact in CDTpAvatarUpdate

6 years agobirthday: test: Wait at least 10 seconds for calendar events
Adrien Bustany [Thu, 3 Nov 2011 08:42:46 +0000 (10:42 +0200)]
birthday: test: Wait at least 10 seconds for calendar events

6 years agobirthday: Add debug message in the test::loopWait
Adrien Bustany [Thu, 3 Nov 2011 08:42:00 +0000 (10:42 +0200)]
birthday: Add debug message in the test::loopWait

6 years agoEnable birthday tests again
Adrien Bustany [Wed, 2 Nov 2011 12:46:39 +0000 (14:46 +0200)]
Enable birthday tests again

6 years agoPrepare to release 1.0.17-2
Adrien Bustany [Thu, 3 Nov 2011 08:09:17 +0000 (10:09 +0200)]
Prepare to release 1.0.17-2

6 years agoPrepare to release 1.0.17-1
Adrien Bustany [Thu, 3 Nov 2011 08:08:34 +0000 (10:08 +0200)]
Prepare to release 1.0.17-1

6 years agoNo need to load the MfeSyncPlugin plugin in tests anymore
Adrien Bustany [Wed, 2 Nov 2011 15:05:34 +0000 (17:05 +0200)]
No need to load the MfeSyncPlugin plugin in tests anymore

The crash was fixed long enough ago

6 years agoRevert "Changes: Reduce code duplication in CDTpAvatarUpdate"
Adrien Bustany [Wed, 2 Nov 2011 14:38:19 +0000 (16:38 +0200)]
Revert "Changes: Reduce code duplication in CDTpAvatarUpdate"

This reverts commit 744aaaa62c7b062ab3249597cf3921c981ab8a84.

This commit made the request/update always get deleted in
onRequestFinished, whereas another request round is needed if you have
an URL redirect.

6 years agotelepathy: Show contact id in warning in createContactInfoBuilder
Adrien Bustany [Wed, 2 Nov 2011 14:07:06 +0000 (16:07 +0200)]
telepathy: Show contact id in warning in createContactInfoBuilder

6 years agobirthday: Set reminder to 36h before
Adrien Bustany [Wed, 2 Nov 2011 12:54:33 +0000 (14:54 +0200)]
birthday: Set reminder to 36h before

6 years agobirthday: Precise all reminder parameters
Adrien Bustany [Wed, 2 Nov 2011 12:33:50 +0000 (14:33 +0200)]
birthday: Precise all reminder parameters

6 years agobirthday: Make mkcal happy with whole day events
Adrien Bustany [Wed, 2 Nov 2011 12:33:07 +0000 (14:33 +0200)]
birthday: Make mkcal happy with whole day events

6 years agobirthday: Workaround a bug in libmkcal in updateBirthday
Adrien Bustany [Wed, 2 Nov 2011 11:07:55 +0000 (13:07 +0200)]
birthday: Workaround a bug in libmkcal in updateBirthday

When settings the start date for a birthday event, you need to use the
"right" variant of KDateTime.

6 years agoPrepare to release 1.0.16-1
Adrien Bustany [Tue, 1 Nov 2011 13:56:51 +0000 (15:56 +0200)]
Prepare to release 1.0.16-1

6 years agoChanges: Reduce code duplication in CDTpAvatarUpdate
Mathias Hasselmann [Mon, 31 Oct 2011 11:07:09 +0000 (12:07 +0100)]
Changes: Reduce code duplication in CDTpAvatarUpdate

RevBy: cocos (MR#40)

6 years agoFixes: NB#288663 - Contactsd crashes in multiapps scenario at ~CDTpAvatarUpdate()
Mathias Hasselmann [Mon, 31 Oct 2011 11:01:12 +0000 (12:01 +0100)]
Fixes: NB#288663 - Contactsd crashes in multiapps scenario at ~CDTpAvatarUpdate()

RevBy: cocos (MR#40)

6 years agoAdd GRP::calendar AEGIS token
Adrien Bustany [Tue, 1 Nov 2011 11:35:09 +0000 (13:35 +0200)]
Add GRP::calendar AEGIS token

6 years agotelepathy: Fix crash in CDTpRemovalOperation on null connection
Adrien Bustany [Mon, 31 Oct 2011 09:04:50 +0000 (11:04 +0200)]
telepathy: Fix crash in CDTpRemovalOperation on null connection

6 years agoPrepare to release 10.15.1-2
Adrien Bustany [Tue, 25 Oct 2011 15:17:22 +0000 (18:17 +0300)]
Prepare to release 10.15.1-2

6 years agoReally disable birthday plugin tests
Adrien Bustany [Tue, 25 Oct 2011 15:15:13 +0000 (18:15 +0300)]
Really disable birthday plugin tests

6 years agoPrepare to release 10.15.1-1
Adrien Bustany [Tue, 25 Oct 2011 13:15:58 +0000 (16:15 +0300)]
Prepare to release 10.15.1-1

6 years agoDisable birthday plugin tests for now
Adrien Bustany [Tue, 25 Oct 2011 13:14:44 +0000 (16:14 +0300)]
Disable birthday plugin tests for now

Apparently the language restoration is not completely functional

6 years agoPrepare to release 10.15-1
Adrien Bustany [Mon, 24 Oct 2011 14:25:45 +0000 (17:25 +0300)]
Prepare to release 10.15-1

6 years agoChanges: Fetch social avatars from Facebook
Mathias Hasselmann [Thu, 20 Oct 2011 14:35:34 +0000 (16:35 +0200)]
Changes: Fetch social avatars from Facebook

RevBy: cocos

6 years agoChanges: Write social avatars to tracker
Mathias Hasselmann [Thu, 20 Oct 2011 14:08:11 +0000 (16:08 +0200)]
Changes: Write social avatars to tracker

RevBy: cocos

6 years agoChanges: Provide infrastructure for storing social avatars
Mathias Hasselmann [Thu, 20 Oct 2011 14:03:05 +0000 (16:03 +0200)]
Changes: Provide infrastructure for storing social avatars

RevBy: cocos

6 years agoChanges: Use local scopes in createGarbageCollectorBuilder()
Mathias Hasselmann [Thu, 20 Oct 2011 13:59:59 +0000 (15:59 +0200)]
Changes: Use local scopes in createGarbageCollectorBuilder()

RevBy: cocos
Details: Avoids name conflicts and accidental reuse of variables.

6 years agotelepathy: Fix a null dereference in onUpdateQueueTimeout
Adrien Bustany [Fri, 21 Oct 2011 13:46:51 +0000 (16:46 +0300)]
telepathy: Fix a null dereference in onUpdateQueueTimeout

6 years agoPrepare to release 1.0.14-1
Adrien Bustany [Fri, 21 Oct 2011 13:24:38 +0000 (16:24 +0300)]
Prepare to release 1.0.14-1

6 years agotelepathy: Prevent crash in CDTpInvitationOperation if account connection is null
Adrien Bustany [Fri, 21 Oct 2011 08:50:07 +0000 (11:50 +0300)]
telepathy: Prevent crash in CDTpInvitationOperation if account connection is null

6 years agoChanges: map all non-female/-male string in x-gender field to nco:gender_other
Friedrich W. H. Kossebau [Fri, 21 Oct 2011 12:08:20 +0000 (14:08 +0200)]
Changes: map all non-female/-male string in x-gender field to nco:gender_other

6 years agoFixes: NB#286052 - Duplicate set of address details gets added to tp contact each...
Friedrich W. H. Kossebau [Thu, 20 Oct 2011 16:46:04 +0000 (18:46 +0200)]
Fixes: NB#286052 - Duplicate set of address details gets added to tp contact each start

6 years agoFixes: configure did not check if NANO_VERSION is set before using its value
Friedrich W. H. Kossebau [Thu, 20 Oct 2011 17:09:58 +0000 (19:09 +0200)]
Fixes: configure did not check if NANO_VERSION is set before using its value

6 years agoChanges: Remove urn:contactsd:invalid-avatar hack
Mathias Hasselmann [Tue, 18 Oct 2011 07:52:54 +0000 (10:52 +0300)]
Changes: Remove urn:contactsd:invalid-avatar hack

RevBy: cocos (MR#34)

6 years agotelepathy: Only create PersonContact for valid IM contacts in createContactsBuilder
Adrien Bustany [Tue, 18 Oct 2011 13:32:20 +0000 (16:32 +0300)]
telepathy: Only create PersonContact for valid IM contacts in createContactsBuilder

If some stale IMAddresses were left in the DB (for example, after
deleting a nco:PersonContact linked to an invalid buddy, and before the
garbage collection happened), a new contact would be created for them.

6 years agotelepathy: Factor out common cache loader/writer parts
Adrien Bustany [Tue, 18 Oct 2011 08:17:23 +0000 (11:17 +0300)]
telepathy: Factor out common cache loader/writer parts

6 years agoFixes: Leave more room for new CDTpContact::Change values
Mathias Hasselmann [Fri, 14 Oct 2011 07:50:15 +0000 (09:50 +0200)]
Fixes: Leave more room for new CDTpContact::Change values

RevBy: cocos (MR#34)

6 years agoFixes: Remove redundant lookups in CDTpStorage::updateContact()
Mathias Hasselmann [Mon, 17 Oct 2011 13:40:51 +0000 (15:40 +0200)]
Fixes: Remove redundant lookups in CDTpStorage::updateContact()

RevBy: cocos (MR#34)

6 years agoFixes: Inverted logic in updateContactsInfoBuilder()
Mathias Hasselmann [Tue, 18 Oct 2011 06:29:10 +0000 (08:29 +0200)]
Fixes: Inverted logic in updateContactsInfoBuilder()

RevBy: cocos (MR#34)

6 years agoChanges: Avoid temporary variables when reading back contact info
Mathias Hasselmann [Mon, 17 Oct 2011 13:28:23 +0000 (15:28 +0200)]
Changes: Avoid temporary variables when reading back contact info

RevBy: cocos (MR#34)

6 years agoChanges: Avoid local variable for CDTpAccountCacheLoader/Writer::run()
Mathias Hasselmann [Tue, 18 Oct 2011 06:27:51 +0000 (08:27 +0200)]
Changes: Avoid local variable for CDTpAccountCacheLoader/Writer::run()

RevBy: cocos (MR#34)

6 years agobirthday: Sanitize CDBirthdayController::onTrackerIdsFetched
Adrien Bustany [Tue, 18 Oct 2011 06:41:01 +0000 (09:41 +0300)]
birthday: Sanitize CDBirthdayController::onTrackerIdsFetched

6 years agotelepathy: Remove deleteLater calls in CDTpAccoutCache(Loader|Writer)
Adrien Bustany [Tue, 18 Oct 2011 06:36:08 +0000 (09:36 +0300)]
telepathy: Remove deleteLater calls in CDTpAccoutCache(Loader|Writer)

6 years agoChanges: remove the space from calendarEventId ("1234 com.nokia.birthday" -> "com...
Friedrich W. H. Kossebau [Tue, 18 Oct 2011 08:41:59 +0000 (10:41 +0200)]
Changes: remove the space from calendarEventId ("1234 com.nokia.birthday" -> "com.nokia.birthday/1234")

Details:
works around NB#286209

6 years agoPrepare to release 1.0.13-1
Adrien Bustany [Mon, 17 Oct 2011 10:57:21 +0000 (13:57 +0300)]
Prepare to release 1.0.13-1

6 years agotelepathy: Also create IMAddress for IM ids that failed to resolve
Adrien Bustany [Mon, 17 Oct 2011 10:51:16 +0000 (13:51 +0300)]
telepathy: Also create IMAddress for IM ids that failed to resolve

6 years agotelepathy: Remove getters/setters from CDTpContact::Info
Adrien Bustany [Mon, 17 Oct 2011 07:38:52 +0000 (10:38 +0300)]
telepathy: Remove getters/setters from CDTpContact::Info

Those were only here for the QDataStream operators, so were not really
needed.

6 years agoPrepare to release 1.0.12.3-1
Adrien Bustany [Wed, 12 Oct 2011 08:11:40 +0000 (11:11 +0300)]
Prepare to release 1.0.12.3-1

6 years agoAdd birthday plugin tests in EXPECTFAIL
Adrien Bustany [Wed, 12 Oct 2011 08:06:47 +0000 (11:06 +0300)]
Add birthday plugin tests in EXPECTFAIL

They fail at the moment and the plugin is not included in images yet.

6 years agoPrepare to release 1.0.12.2-1
Adrien Bustany [Mon, 10 Oct 2011 12:27:21 +0000 (15:27 +0300)]
Prepare to release 1.0.12.2-1

6 years agotelepathy: Fix CDTPContact::Info unserialization
Adrien Bustany [Mon, 10 Oct 2011 12:07:14 +0000 (15:07 +0300)]
telepathy: Fix CDTPContact::Info unserialization

6 years agoPrepare to release 1.0.12.1-1
Adrien Bustany [Thu, 6 Oct 2011 15:04:55 +0000 (18:04 +0300)]
Prepare to release 1.0.12.1-1

6 years agoFix make check
Adrien Bustany [Thu, 6 Oct 2011 15:03:34 +0000 (18:03 +0300)]
Fix make check

6 years agobirthday plugin: Restore original language after test finishes
Adrien Bustany [Thu, 6 Oct 2011 14:51:45 +0000 (17:51 +0300)]
birthday plugin: Restore original language after test finishes

6 years agoPrepare to release 1.0.12-1
Adrien Bustany [Wed, 5 Oct 2011 10:16:55 +0000 (13:16 +0300)]
Prepare to release 1.0.12-1

6 years agoAdd missing aegis token to ut_birthdayplugin
Adrien Bustany [Wed, 5 Oct 2011 10:10:21 +0000 (13:10 +0300)]
Add missing aegis token to ut_birthdayplugin

6 years agoSplit the birthday plugin in a separate package
Adrien Bustany [Wed, 5 Oct 2011 07:51:31 +0000 (10:51 +0300)]
Split the birthday plugin in a separate package

6 years agobirthday plugin: Set an alarm one day before birthdays
Adrien Bustany [Tue, 4 Oct 2011 15:28:59 +0000 (18:28 +0300)]
birthday plugin: Set an alarm one day before birthdays

6 years agoFactor files shared between the birthday and telepathy tests
Adrien Bustany [Wed, 5 Oct 2011 08:03:57 +0000 (11:03 +0300)]
Factor files shared between the birthday and telepathy tests

6 years agoFix path to with-daemon.sh in tests
Adrien Bustany [Wed, 5 Oct 2011 08:58:27 +0000 (11:58 +0300)]
Fix path to with-daemon.sh in tests

6 years agoFixes: NB#275463 - AddBuddy ids should get resolved by the connection manager
Adrien Bustany [Tue, 4 Oct 2011 11:30:55 +0000 (14:30 +0300)]
Fixes: NB#275463 - AddBuddy ids should get resolved by the connection manager

6 years agoPrepare to release 1.0.11.1-1
Adrien Bustany [Tue, 4 Oct 2011 07:40:36 +0000 (10:40 +0300)]
Prepare to release 1.0.11.1-1

6 years agoFix tests packaging
Adrien Bustany [Tue, 4 Oct 2011 07:32:05 +0000 (10:32 +0300)]
Fix tests packaging

Previous packaging was designed to handle only one test,
ut_telepathyplugin. Now that we also have a test for the birthday
plugin, move each test to a separate subdir

6 years agoPrepare to release 1.0.11-1
Adrien Bustany [Tue, 4 Oct 2011 07:01:20 +0000 (10:01 +0300)]
Prepare to release 1.0.11-1

6 years agoBirthday plugin: Comment strange setYearly method call
David King [Fri, 30 Sep 2011 08:55:56 +0000 (10:55 +0200)]
Birthday plugin: Comment strange setYearly method call

6 years agoBirthday plugin: Change testChangeBirthday to use a 3-day offset
David King [Thu, 29 Sep 2011 12:22:19 +0000 (14:22 +0200)]
Birthday plugin: Change testChangeBirthday to use a 3-day offset

If the test changes the birthday on the contact by only one day, it is
feasible that time zone differences could accumulate and make the test
fail in success conditions (or succeed in failure conditions). Change
the offset to be three days to make sure that this is not the case.

6 years agoBirthday plugin: Do not set an end date for birthday events
David King [Thu, 29 Sep 2011 09:13:57 +0000 (11:13 +0200)]
Birthday plugin: Do not set an end date for birthday events

Additionally, make sure that the recurrence of the calendar event is
updated if the contact is updated.

6 years agoRetagging harmattan for Bifh to pick it.
Subramanian Girish [Thu, 29 Sep 2011 16:38:20 +0000 (19:38 +0300)]
Retagging harmattan for Bifh to pick it.

6 years agoPrepare to release 1.0.10-1
Adrien Bustany [Thu, 29 Sep 2011 12:05:47 +0000 (15:05 +0300)]
Prepare to release 1.0.10-1

6 years agotelepathy: Check that presence-only updates are tagged as such
Adrien Bustany [Thu, 29 Sep 2011 11:39:00 +0000 (14:39 +0300)]
telepathy: Check that presence-only updates are tagged as such

6 years agoDon't use QTEST_MAIN in the tests
Adrien Bustany [Wed, 28 Sep 2011 12:46:05 +0000 (15:46 +0300)]
Don't use QTEST_MAIN in the tests

This uses a QApplication if QtGui is linked, and then fail to connect to X.
We use a replacement of QTEST_MAIN that always instantiates a QCoreApplication
instead.

6 years agotelepathy: Don't discard presence updates for contacts missing from roster cache
Adrien Bustany [Wed, 28 Sep 2011 08:39:55 +0000 (11:39 +0300)]
telepathy: Don't discard presence updates for contacts missing from roster cache

6 years agotelepathy: Emit syncStarted even before the roster is received
Adrien Bustany [Fri, 23 Sep 2011 12:21:35 +0000 (15:21 +0300)]
telepathy: Emit syncStarted even before the roster is received

6 years agotelepathy: Give a grace period before writing changes to Tracker when the internet...
Adrien Bustany [Thu, 15 Sep 2011 12:33:28 +0000 (15:33 +0300)]
telepathy: Give a grace period before writing changes to Tracker when the internet connection drops

6 years agotelepathy: Add a way to distinguish presence updates from ContactInfo updates in...
Adrien Bustany [Wed, 14 Sep 2011 11:56:42 +0000 (14:56 +0300)]
telepathy: Add a way to distinguish presence updates from ContactInfo updates in change signals

6 years agotelepathy: Factor timestamp updating in CDTpStorage
Adrien Bustany [Wed, 14 Sep 2011 07:29:08 +0000 (10:29 +0300)]
telepathy: Factor timestamp updating in CDTpStorage

6 years agotelepathy: Remove useless DELETE when putting an account offline
Adrien Bustany [Wed, 14 Sep 2011 06:59:10 +0000 (09:59 +0300)]
telepathy: Remove useless DELETE when putting an account offline

We used to delete all the capabilities, before inserting them all again,
this is useless, we can just insert them all and Tracker will ignore the
duplicate statements (makes putting an account offline almost twice as
fast).

6 years agotelepathy: Make roster cache persistent in CDTpAccount
Adrien Bustany [Tue, 13 Sep 2011 14:05:46 +0000 (17:05 +0300)]
telepathy: Make roster cache persistent in CDTpAccount

6 years agotelepathy: Add classes to serialize/unserialize the roster cache to a file
Adrien Bustany [Tue, 13 Sep 2011 14:03:55 +0000 (17:03 +0300)]
telepathy: Add classes to serialize/unserialize the roster cache to a file

6 years agotelepathy: Only write the required contact changes when going online/offline
Adrien Bustany [Fri, 9 Sep 2011 08:53:49 +0000 (11:53 +0300)]
telepathy: Only write the required contact changes when going online/offline

6 years agotelepathy: Add a helper to get the IM address of a CDTpContactPtr
Adrien Bustany [Fri, 9 Sep 2011 08:42:59 +0000 (11:42 +0300)]
telepathy: Add a helper to get the IM address of a CDTpContactPtr

6 years agotelepathy: Add rosterChanges method to CDTpAccount
Adrien Bustany [Fri, 9 Sep 2011 08:42:10 +0000 (11:42 +0300)]
telepathy: Add rosterChanges method to CDTpAccount

This method diffs the roster cache with the current roster, and returns
the data to update for each contact.

6 years agotelepathy: Add Added/Deleted to CDTpContact::Changes
Adrien Bustany [Fri, 9 Sep 2011 08:39:39 +0000 (11:39 +0300)]
telepathy: Add Added/Deleted to CDTpContact::Changes

6 years agotelepathy: Cache the roster in CDTpAccount when the connection goes down
Adrien Bustany [Fri, 9 Sep 2011 08:36:53 +0000 (11:36 +0300)]
telepathy: Cache the roster in CDTpAccount when the connection goes down

6 years agotelepathy: Add a "diff" method to CDTpContact::Info
Adrien Bustany [Tue, 20 Sep 2011 11:43:45 +0000 (14:43 +0300)]
telepathy: Add a "diff" method to CDTpContact::Info

This method can be used to get a set a CDTpContact::Change representing
the difference between two contacts.

6 years agotelepathy: Add QDataStream operators for CDTpContact::Info
Adrien Bustany [Tue, 13 Sep 2011 14:04:31 +0000 (17:04 +0300)]
telepathy: Add QDataStream operators for CDTpContact::Info

6 years agotelepathy: Add CDTpContact::Info for roster cache
Adrien Bustany [Tue, 13 Sep 2011 11:53:18 +0000 (14:53 +0300)]
telepathy: Add CDTpContact::Info for roster cache

6 years agotelepathy: Track current connection in CDTpAccount
Adrien Bustany [Fri, 9 Sep 2011 08:35:05 +0000 (11:35 +0300)]
telepathy: Track current connection in CDTpAccount

When we get the connectionChanged signal, the previous connection has
already been replaced. If we want to take an action based on the
previous state of the connection, we need to track it.

6 years agoHandle SIGINT/SIGTERM to quit properly
Adrien Bustany [Tue, 13 Sep 2011 15:25:53 +0000 (18:25 +0300)]
Handle SIGINT/SIGTERM to quit properly

6 years agoAutomatic version bump
Mathias Hasselmann [Thu, 22 Sep 2011 12:17:35 +0000 (14:17 +0200)]
Automatic version bump

6 years agoPrepare harmattanfb/1.0.9-1
Mathias Hasselmann [Thu, 22 Sep 2011 12:15:39 +0000 (14:15 +0200)]
Prepare harmattanfb/1.0.9-1

6 years agoChanges: Use QCOMPARE instead of QVERIFY for checking a few strings.
Mathias Hasselmann [Wed, 21 Sep 2011 10:06:22 +0000 (12:06 +0200)]
Changes: Use QCOMPARE instead of QVERIFY for checking a few strings.

RevBy: cocos (MR#32)
Details: QCOMPARE prints the string content.

6 years agoChanges: Use custom label instead of first name for birthday tests
Mathias Hasselmann [Wed, 21 Sep 2011 10:05:46 +0000 (12:05 +0200)]
Changes: Use custom label instead of first name for birthday tests

RevBy: cocos (MR#32)
Details: Also verify that details get added to the contact.

6 years agoChanges: Merge contact fetching logic
Mathias Hasselmann [Wed, 21 Sep 2011 09:40:55 +0000 (11:40 +0200)]
Changes: Merge contact fetching logic

RevBy: cocos (MR#32)

6 years agoChanges: Merge common logic in contact fetching callbacks
Mathias Hasselmann [Wed, 21 Sep 2011 09:37:25 +0000 (11:37 +0200)]
Changes: Merge common logic in contact fetching callbacks

RevBy: cocos (MR#32)

6 years agoFixes: Reorder birthday controller methods to have a chance understanding it
Mathias Hasselmann [Wed, 21 Sep 2011 09:30:15 +0000 (11:30 +0200)]
Fixes: Reorder birthday controller methods to have a chance understanding it

RevBy: cocos (MR#32)