qt:qtenginio.git
4 years agoMake items in in the image gallery not selectable
Jędrzej Nowacki [Thu, 28 Nov 2013 09:28:44 +0000 (10:28 +0100)]
Make items in in the image gallery not selectable

Change-Id: I9a6442c92b48ea28440cd0a65d189cf5ccf20e02
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoStart moving code away from ReplyBase
Frederik Gladhorn [Wed, 27 Nov 2013 12:33:05 +0000 (13:33 +0100)]
Start moving code away from ReplyBase

Change-Id: Ib164de80c2741261e587c095635f7bc9e61c18f5
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoRemove empty init function
Frederik Gladhorn [Wed, 27 Nov 2013 07:11:16 +0000 (08:11 +0100)]
Remove empty init function

Change-Id: I288a6f034c21dd3622639fa078991114e9db46af
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoRemove properties from EnginioModelBase
Frederik Gladhorn [Wed, 27 Nov 2013 07:08:05 +0000 (08:08 +0100)]
Remove properties from EnginioModelBase

Change-Id: Ifdb7f8dba0eb7fe5f9e8ab73044af0009baa46fe
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix QNetworkAccessManager being destroyd too late
Frederik Gladhorn [Thu, 28 Nov 2013 13:45:43 +0000 (14:45 +0100)]
Fix QNetworkAccessManager being destroyd too late

Change-Id: I7d4bc7c1529a58e725bad1f957391436627c2fd5
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix memory leak in tests.
Jędrzej Nowacki [Tue, 26 Nov 2013 12:41:36 +0000 (12:41 +0000)]
Fix memory leak in tests.

QNetworkReply should be removed when finished.

Change-Id: Ifb027d634885f4df26a5807c56b8e9f976b82d0b
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix up documentation, do not mention *Base classes
Frederik Gladhorn [Tue, 26 Nov 2013 22:04:03 +0000 (23:04 +0100)]
Fix up documentation, do not mention *Base classes

Change-Id: I955e7a18631b158825a750c44ec310ff13b834f2
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix documentation depends
Frederik Gladhorn [Tue, 26 Nov 2013 22:12:09 +0000 (23:12 +0100)]
Fix documentation depends

Change-Id: I8395c7e886a53a50346eb0bf0e0ae09e5a506609
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoUpdate TODO example
Jędrzej Nowacki [Tue, 26 Nov 2013 09:42:18 +0000 (09:42 +0000)]
Update TODO example

The example gathered a bit of dust. Especially in terms of role names
handling

Task-number: QTBUG-35024
Change-Id: Ie2309c654fc8f2cc5d14705ab03616af713f02f6
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove undefined EnginioReply ctor
Jędrzej Nowacki [Tue, 26 Nov 2013 11:46:28 +0000 (11:46 +0000)]
Remove undefined EnginioReply ctor

The constructor is probably some leftover from an invalid conflict
resolution

Change-Id: I65431d7f90ce147703cbf6e48ad269b1ac12f388
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix some qdoc errors.
Jędrzej Nowacki [Tue, 26 Nov 2013 11:39:15 +0000 (11:39 +0000)]
Fix some qdoc errors.

EnginioModel::enginio was renamed to EnginioModel::client.
EnginioIdentity::prepareSessionToken and removeSessionToken were moved
to protected section and qdoc thinks that they are apis.
Enginio was renamed to EnginioClient in QML.

Change-Id: I2549c9eac8d2ccbf8b82660eb92c4dcbd25dbb60
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix qdoc link error to Enginio::Role
Jędrzej Nowacki [Mon, 25 Nov 2013 15:31:23 +0000 (15:31 +0000)]
Fix qdoc link error to Enginio::Role

Change-Id: If0e812375f5d72fee5eba5f227b253eb39aa9099
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMove EnginioModelBase::Roles to Enginio::Roles
Jędrzej Nowacki [Mon, 25 Nov 2013 15:14:53 +0000 (15:14 +0000)]
Move EnginioModelBase::Roles to Enginio::Roles

Change-Id: I9729c25bdbe83c8f3339c161c94e502c35141966
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoImprove qml test: use compare over verify
Jędrzej Nowacki [Mon, 25 Nov 2013 14:56:50 +0000 (14:56 +0000)]
Improve qml test: use compare over verify

Change-Id: I4bd00f99f456dbbd65fd2bd47b90f0b6ba20e718
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMove all enums defined by EnginioClientConnection to a gadet
Jędrzej Nowacki [Mon, 25 Nov 2013 14:55:46 +0000 (14:55 +0000)]
Move all enums defined by EnginioClientConnection to a gadet

Change-Id: I5987fd34d95d0f8d5e417f74981d3f92fdef72c5
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRename Enginio to EnginioClient in QML
Jędrzej Nowacki [Mon, 25 Nov 2013 14:45:59 +0000 (14:45 +0000)]
Rename Enginio to EnginioClient in QML

Change-Id: I83b932fc5c9febae1743ed20ad50069826b2d7c7
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMark EnginioModelBase ctor as protected
Jędrzej Nowacki [Mon, 25 Nov 2013 13:24:53 +0000 (13:24 +0000)]
Mark EnginioModelBase ctor as protected

Change-Id: Ibe80aeb2c33c98baf62a4531b5a85ea398d0a475
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoHard code cipher when ENGINIO_VALGRIND_DEBUG is set
Frederik Gladhorn [Fri, 22 Nov 2013 14:21:31 +0000 (15:21 +0100)]
Hard code cipher when ENGINIO_VALGRIND_DEBUG is set

Valgrind do not like openssl implementation of AES. The stderr is
spammed massively by warnings caused by usage of red zone, which makes
the analysis completely unusable.

Change-Id: I987434afbfc810c8b4347afbf2204dd4c3ba44ef
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoDelete all EnginioReplyBase children in EnginioClientBase dtor.
Jędrzej Nowacki [Wed, 20 Nov 2013 11:25:04 +0000 (11:25 +0000)]
Delete all EnginioReplyBase children in EnginioClientBase dtor.

Normally children are deleted in QObject destructor, but
EnginioReplyBase destructor checks for EnginioClientBasePrivate
properties which are destroyed at this point. Therefore we need to
destroy replies a bit earlier.

Change-Id: Ic98ae75c590c26271efcabfce662f6ea236f9c65
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoDo not delete unfinished QNetworkReply.
Jędrzej Nowacki [Fri, 15 Nov 2013 15:34:24 +0000 (15:34 +0000)]
Do not delete unfinished QNetworkReply.

Change-Id: I06751f807c70bd38b6a60a91082b72fd8dce1747
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoCall QNetworkReply::abort when we the request's result is not needed.
Jędrzej Nowacki [Fri, 15 Nov 2013 13:34:18 +0000 (13:34 +0000)]
Call QNetworkReply::abort when we the request's result is not needed.

Dummy reply is not leaking anymore if an owning EnginioReply is deleted

Change-Id: I9cee6527a5c132ce922295e6b4a34310f0cc3874
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix memory corruption.
Jędrzej Nowacki [Fri, 22 Nov 2013 15:41:58 +0000 (15:41 +0000)]
Fix memory corruption.

EnginioClient destroyed signal was trying to disconnect a reply created
by the identity even if the identity was already deleted.

Change-Id: I335e3ee94b8d8fbe854382b91051245a990b7a1f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoConvert EnginioIdentity to use QObjectPrivate pattern.
Jędrzej Nowacki [Thu, 21 Nov 2013 10:26:40 +0000 (10:26 +0000)]
Convert EnginioIdentity to use QObjectPrivate pattern.

Change-Id: I6b402f0e2fc5e07062c8ffd8c0e38b014b08983d
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUse shared QNetworkRequest instead constructing one from scratch
Jędrzej Nowacki [Fri, 22 Nov 2013 15:46:18 +0000 (15:46 +0000)]
Use shared QNetworkRequest instead constructing one from scratch

That way we have one point in which we can inject features for all
network requests.

Change-Id: I1b90221ec368ef44c81e1308864c0b1b10030dac
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd basic error handling to example
Frederik Gladhorn [Tue, 29 Oct 2013 09:40:32 +0000 (10:40 +0100)]
Add basic error handling to example

Change-Id: I23fd6ecba4c5718241d8d2a508ee24910d4d8fa9
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoRename EnginioClientBase to EnginioClientConnection.
Jędrzej Nowacki [Fri, 22 Nov 2013 11:26:35 +0000 (11:26 +0000)]
Rename EnginioClientBase to EnginioClientConnection.

The "Base" name was meaningless. EnginioClientConnection is keeping
information about backend connection.

[ChangeLog][API] Renamed EnginioClientBase to EnginioClientConnection

Change-Id: Ide98c67702c2edd3ba2485d10f619917671834b4
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUpdate docs after search function has been renamed.
Jędrzej Nowacki [Fri, 22 Nov 2013 09:34:39 +0000 (09:34 +0000)]
Update docs after search function has been renamed.

Change-Id: I83a9b6a8b029723d6ec718fa47451cdda3b16bdd
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoImprove socialtodos docs
Frederik Gladhorn [Wed, 23 Oct 2013 15:11:20 +0000 (17:11 +0200)]
Improve socialtodos docs

While the last two sections are still missing, I think this is great as
a first version. We can improve it incrementally and it is already much
better than what we have.

Done-with: Harri Eronen

Change-Id: Ife54cbf75814742d88a43db298c4ccac2f29f55a
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoSimplify replies connections ownership.
Jędrzej Nowacki [Tue, 19 Nov 2013 13:55:56 +0000 (13:55 +0000)]
Simplify replies connections ownership.

By using new QObject::connect signal we do not have to manually trace
QObject connections anymore.

The patch fixes random crash in EnginioModel autotests in which a not
needed anymore reply was delivered.

Change-Id: I71e21f486d8ed6b55889a1f71d6c801e20bdab09
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoEnginioModel::setData change order of arguments
Frederik Gladhorn [Thu, 21 Nov 2013 15:01:43 +0000 (16:01 +0100)]
EnginioModel::setData change order of arguments

This makes it consistent with QAbstractItemModel

[ChangeLog][API] The order of the role and value arguments in
EnginioModel::setData changed.

Change-Id: I60b0e1c8a9417aa1c9345789ff86e08c029804b4
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoClean up symbol visibility
Frederik Gladhorn [Thu, 21 Nov 2013 14:32:02 +0000 (15:32 +0100)]
Clean up symbol visibility

Change-Id: Id9138a0906388cf318b9bcf029c1d3c61febe90c
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename EnginioModelBase::Roles to Role
Frederik Gladhorn [Thu, 21 Nov 2013 14:25:16 +0000 (15:25 +0100)]
API: Rename EnginioModelBase::Roles to Role

[ChangeLog][API] Renamed Roles to Role in EnginioModelBase. Enums should
be singular.

Change-Id: Ib0228c0b982cc67f10c76c9187626f0f76d6883d
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename EnginioModel::setProperty to setData
Frederik Gladhorn [Thu, 21 Nov 2013 14:21:42 +0000 (15:21 +0100)]
API: Rename EnginioModel::setProperty to setData

[ChangeLog][API] Renamed setProperty to setData in EnginioModel for
better consistency with other C++ models.

Change-Id: I112571b31de713a9d7886bfe925fe445eb37c6ed
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename EnginioModel::engino property to client
Frederik Gladhorn [Thu, 21 Nov 2013 13:28:44 +0000 (14:28 +0100)]
API: Rename EnginioModel::engino property to client

[ChangeLog][API] Renamed EnginioModel::engino property to client

Change-Id: I56ee3dfeab0f051b92dddf88bc94fb15552572a5
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoMake setUser and setPassword slots
Frederik Gladhorn [Thu, 21 Nov 2013 14:31:45 +0000 (15:31 +0100)]
Make setUser and setPassword slots

Change-Id: I23b4c592e2f26ada3ea74d33ee4731b86d5a5d40
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAdd explicit to single argument constructor
Frederik Gladhorn [Thu, 21 Nov 2013 14:27:31 +0000 (15:27 +0100)]
Add explicit to single argument constructor

Change-Id: I8adfbd24023417ac4d450f67413f47e959e666f0
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename downloadFile to downloadUrl
Frederik Gladhorn [Thu, 21 Nov 2013 12:59:40 +0000 (13:59 +0100)]
API: Rename downloadFile to downloadUrl

[ChangeLog][API] Renamed the downloadFile function to downloadUrl to
make it clear that this function does only provide a URL and does not
download the file.

Change-Id: I6b3c20de9319c7545ff266d2778b985729fe5077
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename search to fullTextSearch
Frederik Gladhorn [Thu, 21 Nov 2013 12:30:11 +0000 (13:30 +0100)]
API: Rename search to fullTextSearch

[ChangeLog][API] Renamed the search function to fullTextSearch

Change-Id: I4c667ccbf89048e9ef49d26d4fb80ed52153dfde
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoMove Q_PROPERTY to the Q_OBJECT macro for consistency
Frederik Gladhorn [Thu, 21 Nov 2013 13:17:56 +0000 (14:17 +0100)]
Move Q_PROPERTY to the Q_OBJECT macro for consistency

Change-Id: I9e0fd718711bbc802880a9a50004c51e19e29d48
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoRemove const from signals
Frederik Gladhorn [Thu, 21 Nov 2013 13:08:04 +0000 (14:08 +0100)]
Remove const from signals

Change-Id: Id52306da8a7034f807f83322a9c5150d4d97df3a
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAPI: Rename ObjectAclOperation to AccessControlOperation
Frederik Gladhorn [Thu, 21 Nov 2013 12:46:48 +0000 (13:46 +0100)]
API: Rename ObjectAclOperation to AccessControlOperation

[ChangeLog][API] Renamed ObjectAclOperation to AccessControlOperation

Change-Id: I5490bae6790e69384d2a3de60962071525630ffe
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoUpdate types in qml docs
Jędrzej Nowacki [Mon, 18 Nov 2013 12:25:39 +0000 (12:25 +0000)]
Update types in qml docs

Change-Id: I6cb63452337baa827ced7288eef70be070e95c9f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove an unused varianble
Jędrzej Nowacki [Mon, 18 Nov 2013 14:10:07 +0000 (14:10 +0000)]
Remove an unused varianble

Change-Id: I77a979df80db885b8d74874ce0c73be46f2c2ffe
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoWorkaround crash when staging url is used.
Jędrzej Nowacki [Wed, 20 Nov 2013 09:27:30 +0000 (09:27 +0000)]
Workaround crash when staging url is used.

On staging we have enabled notifications which are know to be subject
of many untested races. In production environment the problem doesn't
exist.

Change-Id: Idfdc4521ff853a73c78f07d98455d588a2d99c52
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd missing destructor for EnginioQmlClient
Jędrzej Nowacki [Wed, 20 Nov 2013 11:09:33 +0000 (11:09 +0000)]
Add missing destructor for EnginioQmlClient

Change-Id: I63339474120a6ec120bcbff5ca4e08dd3dad4016
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd missing Qt namespace
Jędrzej Nowacki [Thu, 21 Nov 2013 12:46:11 +0000 (12:46 +0000)]
Add missing Qt namespace

Change-Id: I50e3619b8e5a0a1419cba1955f5432d81918c537
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoNew example addressbook.
Jędrzej Nowacki [Mon, 14 Oct 2013 09:18:16 +0000 (09:18 +0000)]
New example addressbook.

The new example shows how to do a full text search and sort a model.

Change-Id: I87666c5bc642cadce1d40db0ddb70fed4a171076
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoWe can not delete QNetworkReply when it is not finished.
Jędrzej Nowacki [Fri, 15 Nov 2013 09:39:58 +0000 (09:39 +0000)]
We can not delete QNetworkReply when it is not finished.

It may happen that finished signal is emitted for the deleted reply
which causes random crashes.

Change-Id: Ie3759a160d3342f8195c8d625d30bb7f52978842
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUpdate qml type info
Frederik Gladhorn [Mon, 18 Nov 2013 16:49:10 +0000 (17:49 +0100)]
Update qml type info

Change-Id: Ief068e60aa31b2b8816a214922e3776e21210eb2
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAdd changelog for 1.0.0
Frederik Gladhorn [Mon, 18 Nov 2013 15:41:10 +0000 (16:41 +0100)]
Add changelog for 1.0.0

Change-Id: Ib036a5613a9e65178d935aedc44bb11285f9926f
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix forward declare struct / class mismatch warning.
Jędrzej Nowacki [Thu, 14 Nov 2013 14:07:18 +0000 (14:07 +0000)]
Fix forward declare struct / class mismatch warning.

Change-Id: I369fad1d0f68773d97c309d4b139a49f3d28bd9f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMake code a bit more verbose.
Jędrzej Nowacki [Thu, 14 Nov 2013 13:52:08 +0000 (13:52 +0000)]
Make code a bit more verbose.

There was too many "->" to understand it.

Change-Id: Id47dc32b31309a5183e23be74ee44afb308dbf16
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd test for re-assigning the same object as qml model query
Jędrzej Nowacki [Tue, 12 Nov 2013 11:46:22 +0000 (11:46 +0000)]
Add test for re-assigning the same object as qml model query

Change-Id: I05471f898c37e2184e4a8fb8a59e23c29dcb270b
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix constructErrorMessage function
Jędrzej Nowacki [Fri, 8 Nov 2013 10:50:02 +0000 (10:50 +0000)]
Fix constructErrorMessage function

De-inline error message construction function, there is not point
in duplicating the code in the binary. The function was hidden
into a struct namespace and exported. Parameters were modified
to accept const reference.

Change-Id: Ib7c4f36b7484be523b81b7ade1011f7a5a2e890f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove redundant check
Jędrzej Nowacki [Fri, 8 Nov 2013 09:57:25 +0000 (09:57 +0000)]
Remove redundant check

Successful remove operation on ACL requires the valid property name.

Change-Id: I1f1489703ec52b96f9f82267943ccf3b6e232db3
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd more tests for fake replies
Jędrzej Nowacki [Fri, 8 Nov 2013 09:53:02 +0000 (09:53 +0000)]
Add more tests for fake replies

Change-Id: Ib5824d9363d2c3bf51aee5ddba03051e09990a1c
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix EnginioModel::setData
Jędrzej Nowacki [Thu, 7 Nov 2013 16:04:42 +0000 (16:04 +0000)]
Fix EnginioModel::setData

The code was not checking for rows indexes smaller then 0.

Change-Id: I39d4fad06809977e3cec0f7b7dc85f3814c0dcfa
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd tests for EnginioModel::enginioChanged signal.
Jędrzej Nowacki [Thu, 7 Nov 2013 15:37:30 +0000 (15:37 +0000)]
Add tests for EnginioModel::enginioChanged signal.

Change-Id: I438edd9bba4c8405fff4cde5b496b274c1497f0a
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove debug code when building for checking test coverage
Jędrzej Nowacki [Thu, 7 Nov 2013 15:26:58 +0000 (15:26 +0000)]
Remove debug code when building for checking test coverage

The change removes noise created by Q_ASSERT

Change-Id: I9058f3a8b9262be990c36d320d7c6087fb6b6fed
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoCheck if the right signal is emitted on OAuth2 properties change.
Jędrzej Nowacki [Thu, 7 Nov 2013 15:18:28 +0000 (15:18 +0000)]
Check if the right signal is emitted on OAuth2 properties change.

Change-Id: I3f6af4a4b8be242796a22c4dbc5784423088c069
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove unsued EnginioReply private contructor
Jędrzej Nowacki [Thu, 7 Nov 2013 14:55:18 +0000 (14:55 +0000)]
Remove unsued EnginioReply private contructor

Change-Id: Ifcacc2fbcdcae473d812ded2c7466e52e6085468
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUse Qt coding style in EnginioClientBase constructor
Jędrzej Nowacki [Thu, 7 Nov 2013 10:17:22 +0000 (10:17 +0000)]
Use Qt coding style in EnginioClientBase constructor

Change-Id: I1118530cbbc0dbc11e302c0950dbb7e29a0a539e
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMove EnginioClientBaase constructor to protected section
Jędrzej Nowacki [Thu, 7 Nov 2013 10:13:54 +0000 (10:13 +0000)]
Move EnginioClientBaase constructor to protected section

The constructor is internal

Change-Id: I481749a06fb6d19418a7fbb4fbd0acd64b1b98a1
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUse module/class forward header
Jędrzej Nowacki [Thu, 7 Nov 2013 09:54:59 +0000 (09:54 +0000)]
Use module/class forward header

Change-Id: I3a4d7d7abf8328a1182a888af022bb0b6fa03632
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove unsused function
Jędrzej Nowacki [Thu, 7 Nov 2013 09:47:02 +0000 (09:47 +0000)]
Remove unsused function

Change-Id: Ida858f6cfe940ea6b70f977c41522e7b58818597
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove redundant q pointer from EnginioClientBasePrivate
Jędrzej Nowacki [Thu, 7 Nov 2013 09:37:57 +0000 (09:37 +0000)]
Remove redundant q pointer from EnginioClientBasePrivate

Change-Id: I23fc0d9cc3543220f9d86d9c4a0f8b6e7dc6c803
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoBump version to 1.0.0
Frederik Gladhorn [Mon, 18 Nov 2013 09:45:59 +0000 (10:45 +0100)]
Bump version to 1.0.0

Change-Id: I1d886d2d1dbb93936a3cb8ce9363fc9a09a078b0
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAdd classname entry to qmldir file.
Morten Johan Sørvig [Wed, 13 Nov 2013 11:30:50 +0000 (12:30 +0100)]
Add classname entry to qmldir file.

Required for iOS static builds.

Change-Id: I714610cb361148180bdd3199ae2a9b2cc033a43c
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoCompile with QT_NO_SSL
Morten Johan Sørvig [Sat, 26 Oct 2013 16:21:18 +0000 (18:21 +0200)]
Compile with QT_NO_SSL

connectToHostEcrypted is not available when Qt is configured
with -no-openssl. The function call is an optimization
to initiate TCP and SSL setup as early as possible
and can be omitted.

Change-Id: I9730f9a86524e299d09762aebd96eb41d31aa310
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAvoid compile error when QT_NO_SSL defined
Alex Blasche [Tue, 12 Nov 2013 08:20:14 +0000 (09:20 +0100)]
Avoid compile error when QT_NO_SSL defined

QtEnginio requires SSL. Any attempt to build this module without
an SSL enabled Qt build should skip building this module.

Change-Id: I1a500888b50663e725cc77e69293752da0f5ff24
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoMove EnginioClient to QObjectPrivate concept
Jędrzej Nowacki [Thu, 7 Nov 2013 09:23:29 +0000 (09:23 +0000)]
Move EnginioClient to QObjectPrivate concept

Change-Id: I40c0fe70441662e8ac3df13ef2d44f21c2a96cf3
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRemove redundant q pointer from EnginioQmlReplyPrivate
Jędrzej Nowacki [Thu, 7 Nov 2013 09:00:23 +0000 (09:00 +0000)]
Remove redundant q pointer from EnginioQmlReplyPrivate

Change-Id: I4a324d68722cdda71605393ec0c7daf43ede26fd
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoMigrate Enginio replies private classes to QObjectPrivate concept
Jędrzej Nowacki [Thu, 7 Nov 2013 08:55:31 +0000 (08:55 +0000)]
Migrate Enginio replies private classes to QObjectPrivate concept

Change-Id: Ieb995e0fa1e69b65605c8ade7a76c7b72fbd38fc
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRename EnginioReplyPrivate to EnginioReplyBasePrivate
Jędrzej Nowacki [Thu, 7 Nov 2013 08:33:24 +0000 (08:33 +0000)]
Rename EnginioReplyPrivate to EnginioReplyBasePrivate

Change-Id: I43d479cd0eba39d0830424eeffe03babc4c8660e
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoUse QObjectPrivate in EnginioModel
Jędrzej Nowacki [Wed, 6 Nov 2013 18:03:13 +0000 (18:03 +0000)]
Use QObjectPrivate in EnginioModel

Enginio is part of Qt and it doesn't need to relay on BC of Qt.
The change unify code handling with Qt policies and reduce
creation overhead by one allocation.

Change-Id: I2715f93dc6dbf094575ca3ff533d711ffaad6b3f
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRename EnginioModelPrivate1 to EnginioQmlModelPrivate
Jędrzej Nowacki [Wed, 6 Nov 2013 12:17:19 +0000 (12:17 +0000)]
Rename EnginioModelPrivate1 to EnginioQmlModelPrivate

We need a proper private name to use Q_D

Change-Id: Ib15fa44568574162b2110151240c0fcbe1c555e5
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRename EnginioModelPrivate1 to EnginioModelPrivate
Jędrzej Nowacki [Wed, 6 Nov 2013 12:15:35 +0000 (12:15 +0000)]
Rename EnginioModelPrivate1 to EnginioModelPrivate

We need a proper private name to use Q_D

Change-Id: I5ff3f64cd1f7c0db05755ba1bf14356d89cc064e
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoRename EnginioModelPrivate to EnginioModelBasePrivate.
Jędrzej Nowacki [Wed, 6 Nov 2013 09:59:50 +0000 (09:59 +0000)]
Rename EnginioModelPrivate to EnginioModelBasePrivate.

We need that to make Q_D macro working correctly.

Change-Id: I253c5999618557e279cea0eb7768b5968982acd5
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd gcov support to Enginio build,
Jędrzej Nowacki [Thu, 7 Nov 2013 14:31:32 +0000 (14:31 +0000)]
Add gcov support to Enginio build,

The Enginio library can by build with "coverage" config option, which
produces html code coverage report.

Change-Id: Iaed61bcbbe67f0efb64413e6e4b5dde218709ec1
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoLeave us some space to grow in EnginioModel::Roles.
Jędrzej Nowacki [Tue, 5 Nov 2013 15:44:15 +0000 (15:44 +0000)]
Leave us some space to grow in EnginioModel::Roles.

Change-Id: I7c002ee9b10f872592abdc7dd5f9e1a3b67f3749
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoUse correct forward declared header
Jędrzej Nowacki [Tue, 5 Nov 2013 15:47:19 +0000 (15:47 +0000)]
Use correct forward declared header

Change-Id: I81cbe9c16c310824fc8da165e3302846a6e65762
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoFix some crashes in EnginioQmlModel
Jędrzej Nowacki [Fri, 1 Nov 2013 14:40:11 +0000 (15:40 +0100)]
Fix some crashes in EnginioQmlModel

Change-Id: I172819f1c16b21c904a00edcc94e2a07d162dfe7
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoFix input method handling
Frederik Gladhorn [Wed, 6 Nov 2013 00:12:19 +0000 (01:12 +0100)]
Fix input method handling

We need to explicitly commit and hide the IM when text is accepted.

Change-Id: Iab5afe777adb28445356dc188b8d3c5c18351a18
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoAdd TextField.qml to pro file
Frederik Gladhorn [Wed, 6 Nov 2013 00:11:55 +0000 (01:11 +0100)]
Add TextField.qml to pro file

Change-Id: I7f919a9a341835c559fa1f533ade03d558dd105b
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix social todo example
Frederik Gladhorn [Tue, 5 Nov 2013 22:17:37 +0000 (23:17 +0100)]
Fix social todo example

Adding wouldn't work because of the missing id for the text input. There
was no warning since the text input one level up was found (from the
list management instead of the specific list)...

Change-Id: I85c4d8c521c28d1d83de7210861b20978f3e095a
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix hint text always visible when using IM
Frederik Gladhorn [Mon, 28 Oct 2013 20:57:45 +0000 (21:57 +0100)]
Fix hint text always visible when using IM

Also remove some duplicate place holder text code.

Change-Id: I82b12f6d6d2b7364cc5939b3f88c8ebdeae243bf
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoImprove Enginio overview and example documentation.
Mitch Curtis [Mon, 4 Nov 2013 14:35:38 +0000 (15:35 +0100)]
Improve Enginio overview and example documentation.

Change-Id: I23c56614753e81f2507dcd8805c8d8290cec75d2
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoDelete QNAM instance when it is not needed anymore.
Jędrzej Nowacki [Thu, 31 Oct 2013 14:48:14 +0000 (14:48 +0000)]
Delete QNAM instance when it is not needed anymore.

The QNAM is still shared in the thread but it may happen that is has to
be recreated. The main advantage of this change is that we clean
memory and that the QNAM is not destroyed after ~QCoreApplication.

Change-Id: I3dc6a5e7d85b2feebb498700986d27d203dbb89e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoFix two simple doc bugs
Jędrzej Nowacki [Mon, 4 Nov 2013 12:11:21 +0000 (12:11 +0000)]
Fix two simple doc bugs

Change-Id: I5cc4441333ff5d5633b8b2b6e87443bfe9191b5c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoRemove last bits of EnginioBasicAuthentication
Jędrzej Nowacki [Fri, 1 Nov 2013 14:48:27 +0000 (15:48 +0100)]
Remove last bits of EnginioBasicAuthentication

Change-Id: Ib7be38c8a3d58e8c80a1dca9ccb52041f3d9ea83
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoControls import is needed for the stack attached prop
Frederik Gladhorn [Fri, 1 Nov 2013 13:45:02 +0000 (14:45 +0100)]
Controls import is needed for the stack attached prop

Change-Id: I539eca9a17b5b7de452897e66849c2c51be2039e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoUse OAuth2 instead of basic auth
Frederik Gladhorn [Fri, 1 Nov 2013 13:38:16 +0000 (14:38 +0100)]
Use OAuth2 instead of basic auth

Change-Id: Ia72333d2fa705834664dab5ca134f7cbe89e2960
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoFix login to work again after pressing back
Frederik Gladhorn [Mon, 28 Oct 2013 21:00:30 +0000 (22:00 +0100)]
Fix login to work again after pressing back

Change-Id: Id002a55e9990e44446f1c9df9919f6183d64065b
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
4 years agoRemove backend secret concept from QtEnginio
Jędrzej Nowacki [Wed, 30 Oct 2013 15:22:47 +0000 (15:22 +0000)]
Remove backend secret concept from QtEnginio

The secret number was redundant.

The change exposed flaky-ness in qml model tests so they were re-factored
and expected values were updated.

Change-Id: I11bbe89390be4e1d3dcec521fde3856455ed4dd9
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoEnable OAuth2 tests on production
Jędrzej Nowacki [Thu, 31 Oct 2013 09:19:46 +0000 (09:19 +0000)]
Enable OAuth2 tests on production

Change-Id: I4356b5f3a26fd30e357809a390aa3b1c940dcb97
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoRemove debug output from QML Model test
Jędrzej Nowacki [Thu, 31 Oct 2013 09:03:30 +0000 (09:03 +0000)]
Remove debug output from QML Model test

Change-Id: Ib0d1c9b15a29cd47955df533cc73d7f74f11903d
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoFix typo in autotests
Jędrzej Nowacki [Thu, 31 Oct 2013 08:27:10 +0000 (08:27 +0000)]
Fix typo in autotests

Change-Id: Ia29fd4380ac42ec036a47c527ab65c21f0a732d6
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
4 years agoUnify naming convention for QByteArrays in EnginioString
Jędrzej Nowacki [Tue, 29 Oct 2013 12:38:40 +0000 (12:38 +0000)]
Unify naming convention for QByteArrays in EnginioString

Change-Id: I5b6860d6556e69b1811c39a6f570afde36a868e4
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoAdd request headers to reply debug output
Jędrzej Nowacki [Tue, 29 Oct 2013 12:37:23 +0000 (12:37 +0000)]
Add request headers to reply debug output

Change-Id: I883d013cd63b3c0f03759a85f798c4ea63652397
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
4 years agoFix OAuth2 tests.
Jędrzej Nowacki [Tue, 29 Oct 2013 12:31:36 +0000 (12:31 +0000)]
Fix OAuth2 tests.

The rest api path was changed.

Change-Id: I7881a2d76eb08885b9ad6333dc794d5ddebd1a6a
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>