Fix QLineEditPrivate::shouldShowPlaceholderText()
authorJ-P Nurmi <jpnurmi@digia.com>
Mon, 2 Dec 2013 19:40:57 +0000 (20:40 +0100)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Thu, 5 Dec 2013 12:50:50 +0000 (13:50 +0100)
commitb8084618545570a8832d344a2e9586e1226cc697
treef22ce8fd2972d0140b84a91470c182656e1a190f
parent3e549f5daa55464512ee2763558f3a7ffd45c545
Fix QLineEditPrivate::shouldShowPlaceholderText()

As stated in commit 46106c4, placeholder text should not be shown
when an empty QLineEdit has visual preedit text fed by a composing
input method. The same condition applies to setPlaceholderText() in
the sense that there is no need to call update() when the placeholder
text is not even shown.

Change-Id: I2521a119b160e16ae0738d3575fea6d9939d6d2a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Tasuku Suzuki <stasuku@gmail.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
src/widgets/widgets/qlineedit.cpp
src/widgets/widgets/qlineedit_p.h