5 years agoQHeaderView 5.0 - no emit of sortIndicatorChanged when unchanged
Thorbjørn Lund Martsum [Thu, 25 Oct 2012 04:49:20 +0000 (06:49 +0200)]
QHeaderView 5.0 - no emit of sortIndicatorChanged when unchanged

There is no reason to emit this when there is no change.

Change-Id: I34f0ceec7c4b0959b77bc5be3ce2c2ad55864598
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoQt 5.0 - Add QHeaderView refactor to changes notes.
Thorbjørn Lund Martsum [Thu, 25 Oct 2012 13:44:11 +0000 (15:44 +0200)]
Qt 5.0 - Add QHeaderView refactor to changes notes.

Some widgets users could get the picture that nothing has
happened in that area. So lets at least write that something
has been improved.

Change-Id: Ic314ab06d28e687986a8ab472d8b58830cb0ad90
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoAdd a CMake macro to test module includes
Stephen Kelly [Fri, 19 Oct 2012 14:59:53 +0000 (16:59 +0200)]
Add a CMake macro to test module includes

The variations of includes which should work are tested. For example,
in the case of testing the QtCore module and QObject include, the
following includes are generated and compiled:

      #include <QObject>
      #include <QtCore/QObject>
      #include <QtCore>
      #include <QtCore/QtCore>

As the private include directories are not available to the compiler,
this also tests that private headers are not included from public ones.

Change-Id: Id03d0fe290c9691e0f7515015892991d1701ab72
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoFix syncing of visibility and enabled for menus on Cocoa
Andy Shaw [Fri, 28 Sep 2012 13:58:58 +0000 (15:58 +0200)]
Fix syncing of visibility and enabled for menus on Cocoa

Fixed menu handling on Cocoa so if a menu is enabled/disabled or made
visible or not then it will keep this in sync with the appropriate
native menu entry.

Change-Id: If269185fcf065fb1b2f60d6ef8c27c107eb4509f
Reviewed-by: Pasi Matilainen <pasi.matilainen@digia.com>
Reviewed-by: James Turner <james.turner@kdab.com>
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
5 years agoescape constructed command for makefiles
Oswald Buddenhagen [Thu, 18 Oct 2012 17:20:34 +0000 (19:20 +0200)]
escape constructed command for makefiles

Change-Id: Iec7f2bd7b02d03bf6a99dde363a41578924e523c
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
5 years agoRemove unnecessary call to png_set_sBit when writing png files
Sergey Borovkov [Wed, 24 Oct 2012 21:20:01 +0000 (01:20 +0400)]
Remove unnecessary call to png_set_sBit when writing png files

According to libpng documentation - PNG files reduce possible bit depths
to 1, 2, 4, 8, and 16. If data is of another bit depth, it's possible to
write an sBIT chunk into the file so that decoders can recover the
original data if desired. Since we hardcode depth to 8 there is no need
to call png_set_sBit

Change-Id: I8e3941675019b920051775128ff4cf2bf1ca7c4a
Reviewed-by: aavit <eirik.aavitsland@digia.com>
5 years agoAngle: Fix shadow build
Yuchen Deng [Thu, 25 Oct 2012 12:57:06 +0000 (20:57 +0800)]
Angle: Fix shadow build

Change-Id: I4ce4741ba1aa4009bd4984b4fad5a1b407d2cce5
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoBlackberry bearer plugin: Only Report working interfaces as active
Peter Hartmann [Tue, 23 Oct 2012 10:42:20 +0000 (12:42 +0200)]
Blackberry bearer plugin: Only Report working interfaces as active

Some interfaces might be connected but not working (e.g. no IP address,
no gateway etc.)

In practice, this prevents the USB interface (among others) from
being reported as active and thus the QNetworkConfigurationManager
as being reported as online.
We only want Wifi and 3G etc. connections to be reported as online
when they are up.

Change-Id: I59fbe53bed8392d363a0191d589737f2304c853f
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Andrey Leonov <aleonov@rim.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
5 years agoQNX: Query dynamic buffer count at runtime
Rafael Roquetto [Wed, 24 Oct 2012 18:27:24 +0000 (16:27 -0200)]
QNX: Query dynamic buffer count at runtime

While unlikely, there are cases in which QQnxWindow::renderBuffer() is
called before the window buffers have been created. Without this check, the
program will abort on QQnxBuffer constructor, since the value that will be
passed to it will be of an invalid buffer.

Change-Id: I9ad5926dca856570032dcf10b6975e8f3364c284
Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
5 years agomove QMAKEMODULES addition to .qmake.super to qt_build_config.prf
Oswald Buddenhagen [Tue, 18 Sep 2012 16:26:09 +0000 (18:26 +0200)]
move QMAKEMODULES addition to .qmake.super to qt_build_config.prf

this is qt module specific magic that has no business in the generic

a side effect is that every qt module now needs to have a .qmake.conf
(unless it sets MODULE_QMAKE_OUTDIR, like webkit does).

Change-Id: Id9e5f6eee2d8ec0c711e7217d9e1893fc9c88132
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
5 years agoremove last traces of qpluginbase.pri
Oswald Buddenhagen [Fri, 21 Sep 2012 13:57:49 +0000 (15:57 +0200)]
remove last traces of qpluginbase.pri

Change-Id: Idafdab98016cd20f0605a46bf9cb8938da41a99e
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
5 years agofix 'qmltypes' targets
Oswald Buddenhagen [Tue, 23 Oct 2012 18:10:25 +0000 (20:10 +0200)]
fix 'qmltypes' targets

should now actually work for all build types

Change-Id: I2dc1f8231737c13e95ce8aab1330b4f063951547
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
5 years agomake qmltypes target properly respect debug vs. release
Oswald Buddenhagen [Tue, 23 Oct 2012 14:46:32 +0000 (16:46 +0200)]
make qmltypes target properly respect debug vs. release

Change-Id: Ia4f5ccb2b795a7594b74ea95aa0cc56a91aa7043
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
5 years agoAdd glxContextForContext function to QXcbNativeInterface.
Zeno Albisser [Wed, 24 Oct 2012 14:04:15 +0000 (16:04 +0200)]
Add glxContextForContext function to QXcbNativeInterface.

This change enables receiving the native GLXContext object that is used
by a QOpenGLContext in case of GLX.
This clearly is non-public api that is only meant to be used as a
last resort for cases where it is really necessary to get hold of
a native context object.

Change-Id: I7f1f974f18063ed334b8034a0c0192c875c10cec
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoAdjust autotest files for raster engine to new default pen
aavit [Wed, 24 Oct 2012 08:42:37 +0000 (10:42 +0200)]
Adjust autotest files for raster engine to new default pen

Fix those test scripts that assumed cosmetic default pen, and
improve testing coverage of cosmetic vs non-cosmetic pens in general.
Ref. I04d910e9700baf7f13a8aac07a3633014bb9283e

Change-Id: I2bb3525c21a8e9c8dd1f16e7dcd225195df43c1b
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoDrop Symbian Carbide settings from .gitignore
aavit [Mon, 22 Oct 2012 09:04:27 +0000 (11:04 +0200)]
Drop Symbian Carbide settings from .gitignore

Change-Id: I429343246714e26690ffd9748e5e6873509c6625
Reviewed-by: Paul Olav Tvete <paul.tvete@digia.com>
5 years agoFix a crash in QFileDialog when selecting an invalid name filter.
Friedemann Kleint [Fri, 26 Oct 2012 08:44:00 +0000 (10:44 +0200)]
Fix a crash in QFileDialog when selecting an invalid name filter.

When nameDetailsVisible is set to false and an invalid/empty
string is passed to selectNameFilter(), the regexp used to
strip the filter off the suffixes returns empty and a crash

Change-Id: I926ea49514ff25a103977d8121fca1cf83d647f5
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
5 years agoFix enter/leave event generation between native widgets when grabbing.
Miikka Heikkinen [Fri, 26 Oct 2012 08:30:22 +0000 (11:30 +0300)]
Fix enter/leave event generation between native widgets when grabbing.

Removed enter/leave event generation when moving between between
related windows in QWidgetWindow (i.e. native widgets) while some
widget was explicitly grabbing the mouse input. This makes enter/leave
event generation identical to non-native widgets.

Task-number: QTBUG-27551
Change-Id: I4996007bd7922e073a2957ad267a6373e8f3fecc
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoNew-style Windows cursors when dragging object from outside
Cyril Oblikov [Tue, 23 Oct 2012 15:00:58 +0000 (18:00 +0300)]
New-style Windows cursors when dragging object from outside

New-style drag&drop cursors are used now on Windows when user drags
object to application from outside (e.g. image from Explorer). This is
achieved by using IDropTargetHelper.

Change-Id: I67e1db73cf433e235fce891eef0093cd4e605904
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoMake compile on WCE after c3b9398
Kevin Funk [Thu, 25 Oct 2012 09:27:04 +0000 (11:27 +0200)]
Make compile on WCE after c3b9398

Change-Id: I594893eb80ecade903e592c41c7117b08bc946a5
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoProperly check for widget's visibility in doublespinbox autotest
Oliver Wolff [Mon, 22 Oct 2012 08:59:52 +0000 (10:59 +0200)]
Properly check for widget's visibility in doublespinbox autotest

Change-Id: If9e08ab5c84090729537e2a060257564c62fda9a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agocorrect spelling in comment
Mark Brand [Wed, 24 Oct 2012 13:55:53 +0000 (15:55 +0200)]
correct spelling in comment

Change-Id: I6ffa96ac9cda0701c99f839804f400a167fcf9a7
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoRemove Windows as a dependency of mac style
Jens Bache-Wiig [Wed, 17 Oct 2012 14:11:58 +0000 (16:11 +0200)]
Remove Windows as a dependency of mac style

There is not need to have this dependency any more
since mac is overriding anything we depend on in Windows
style anyway.

Change-Id: I8fe0e0cc949265170947b492e04e08fdd4cf5027
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
5 years agoHappy Eyeballs: Make sure that we commit the address type for SSL connections
Jocelyn Turcotte [Mon, 15 Oct 2012 12:35:19 +0000 (14:35 +0200)]
Happy Eyeballs: Make sure that we commit the address type for SSL connections

_q_connected checks if pendingEncrypt is false before committing the
address type. This could be used to delay the commit but nothing is done
later in _q_encrypted, so the commit is avoided completely.

This causes SSL connections on a network without IPV6 support to hang
if the domain name record contains both IPV4 and IPV6 addresses.

As SSL is handled a few layers above IP, there should be no reason to
avoid/delay committing the address type if the TCP connection was
established surccessfully. Thus this patch is removing the check completely.

Change-Id: If56a3365f9f51712b4aae3f7902711711ace86fd
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
5 years agotest: Remove QSKIP from tst_QFileDialog2
Sergio Ahumada [Sun, 21 Oct 2012 18:53:02 +0000 (20:53 +0200)]
test: Remove QSKIP from tst_QFileDialog2

In task227930_correctNavigationKeyboardBehavior()

Task-number: QTBUG-23602
Change-Id: I07f40dbc3840c232e09ff1327f00e3fd9c16c22f
Reviewed-by: Morten Johan Sørvig <morten.sorvig@digia.com>
5 years agotest: Remove tst_QPixmap::grabWindow() function
Sergio Ahumada [Sun, 21 Oct 2012 21:56:14 +0000 (23:56 +0200)]
test: Remove tst_QPixmap::grabWindow() function

QPixmap::grabWindow() was deprecated by 41914453d38d01b9b69e16ccee69444d1a304bf7

Task-number: QTBUG-20863
Change-Id: I7e675c124cd96cf1815b65e57f3fba19e5065066
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Reviewed-by: Caroline Chao <caroline.chao@digia.com>
5 years agoTest: remove QSKIP from tst_qstring
Caroline Chao [Wed, 17 Oct 2012 10:25:20 +0000 (12:25 +0200)]
Test: remove QSKIP from tst_qstring

Instead omit the whole tests when appropriate.

In particular:

- When Q_CC_HPACC is defined the tests fromStdString and toStdString are
crashing. Omit the tests in this configuration since the compiler is not

- Clean the localeAwareCompare() by removing the code where Q_OS_WIN is
defined but not Q_OS_WINCE. System and user locale cannot be set on
Q_OS_WIN other than Win CE and some code could never be reached.

Change-Id: I72ae3246bf8c2a73d14cce45dde14bcb8001d8b3
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
5 years agoFix qmake's pro file cache to interact correctly with write_file
Simon Hausmann [Thu, 25 Oct 2012 08:55:00 +0000 (10:55 +0200)]
Fix qmake's pro file cache to interact correctly with write_file

When writing a file with write_file() we have to inform the pro file parser
cache to discard the file if it's existant in the cache, to ensure that
calling include() after write_file() always works.

Change-Id: I7d09269a57de55ca30b0e11dd40770de9f919f64
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
5 years agoRemove widget dependencies on Vista style animations
Jens Bache-Wiig [Tue, 23 Oct 2012 16:34:25 +0000 (18:34 +0200)]
Remove widget dependencies on Vista style animations

This patch will make it possible to get animations on
desktop components without using the widget pointer.

Change-Id: I2d2eca111dab0d96f276ff3627505c0652c4b4e5
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
5 years agoQTextEngine: Support SMP code points when case changing
Konstantin Ritt [Mon, 22 Oct 2012 16:27:31 +0000 (19:27 +0300)]
QTextEngine: Support SMP code points when case changing

Semi-related to QTBUG-17337

Change-Id: I6b42c0f7e588bbeab27bf410fcdfa1a6f80e4ac2
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@digia.com>
5 years agoRemove stale QT_MODULE() usage cases
Konstantin Ritt [Thu, 11 Oct 2012 14:01:21 +0000 (17:01 +0300)]
Remove stale QT_MODULE() usage cases

As of Qt5, this macro is defined to be empty; simply get rid of these leftovers.

Change-Id: I167ccb4c9e92ec9b5e4faeb02bf9c5ef5d982b50
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
5 years agoCore/kernel: Make some signals private.
Stephen Kelly [Thu, 18 Oct 2012 12:29:06 +0000 (14:29 +0200)]
Core/kernel: Make some signals private.

There are more opportunities in QtCore and the rest of Qt to make signals
private instead of public. This is a test-dart to see if there is any
reason not to do this.

It would be nice to make QObject::destroyed private, but as it has a
default argument it would be source incompatible to anyone connecting
to the SIGNAL(destroyed()) instead of SIGNAL(destroyed(QObject*)).

Currently the function-pointer-based connect syntax does not accept
a functor (or lambda) with a different number of arguments than the
signal. Olivier says a fix for that might come in 5.1, but for now
the qfiledialog2 test is changed to not use that anymore.

Also, the function pointer for a private signal can not be assigned to
a local variable, so the qmetamethod test is changed to not do so

Change-Id: Iaf776b822f9ba364f2c184df0c6b23811da56e44
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
5 years agoMac: Non-editable QComboBoxes shouldn't get focus by default
Gabriel de Dietrich [Mon, 22 Oct 2012 14:39:35 +0000 (16:39 +0200)]
Mac: Non-editable QComboBoxes shouldn't get focus by default

On Mac, only line edits and list views always get tab focus. It's only
when we enable full keyboard access that other controls can get tab
focus. When it's not editable, a combobox looks like a button, and it
behaves as such in this respect.

Change-Id: Ia31b0ad01b48a47c1b81180364681d8614863106
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoQStyleAnimation: writable duration & delay properties
J-P Nurmi [Tue, 23 Oct 2012 12:36:59 +0000 (14:36 +0200)]
QStyleAnimation: writable duration & delay properties

These will be needed by upcoming QFadeStyleAnimation and QBlendStyleAnimation.

Change-Id: Ibc5092d5dbd834cb9b16353d3e83b95b04d9484b
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
5 years agoQMacStyle: make default button animations independent of QWidget
J-P Nurmi [Mon, 22 Oct 2012 17:27:05 +0000 (19:27 +0200)]
QMacStyle: make default button animations independent of QWidget

Change-Id: I63c078050288e3151a9c6aad5d4ae28a58afd84f
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
5 years agoDon't crash if there's no m_image yet.
Sérgio Martins [Sun, 21 Oct 2012 23:55:04 +0000 (00:55 +0100)]
Don't crash if there's no m_image yet.

Reproducible with:
    QBackingStore store( &window );

All other methods already have null pointer checks.

Change-Id: Ie278a263760900b58cf4a2ef286deb7f35d50cd0
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoImplement viewOptions logic in QTableViewPrivate.
Stephen Kelly [Tue, 23 Oct 2012 12:03:05 +0000 (14:03 +0200)]
Implement viewOptions logic in QTableViewPrivate.

This is similar to the patch 05aa8c6c12509cce87d1a3811c5ea1dd83fa0898
which was applied to QListView.

Task-number: QTBUG-26548
Change-Id: I38ff07230673a93a32b01a7f1951d0378d94185b
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Oliver Wolff <oliver.wolff@digia.com>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoAdd missing test for the Qt5PrintSupport module.
Stephen Kelly [Mon, 22 Oct 2012 07:31:51 +0000 (09:31 +0200)]
Add missing test for the Qt5PrintSupport module.

Change-Id: Ic3860cc13fbb37a1d3ae63ad100b7d722a987272
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
5 years agoFix crash when handling WM_PAINT during COM operations
Miikka Heikkinen [Tue, 23 Oct 2012 13:25:47 +0000 (16:25 +0300)]
Fix crash when handling WM_PAINT during COM operations

Synchronous expose corrupts painter state if it is done during existing
paint operation, which can happen e.g. when requesting some value from
dumpcpp generated wrapper inside a slot.

Fixed by implementing support for setting asynchronous expose and
doing expose according to the setting in handleWmPaint().

Task-number: QTBUG-27209
Change-Id: I89b5aa823fda947d26b1a4757f129e7c31ea408b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoFix: don't override the new non-cosmetic default pen in qwidget
aavit [Tue, 23 Oct 2012 13:27:18 +0000 (15:27 +0200)]
Fix: don't override the new non-cosmetic default pen in qwidget

As QWidget initializes any painter created in paintevent handler to
have the pen color of the palette's foreground, setting it to 0 width,
i.e. cosmetic, it negated the effect of the recent change to default
1-width non-cosmetic, ref. I04d910e9700baf7f13a8aac07a3633014bb9283e

This caused scaled painting with default pen on QImage and QWidget
to yield different results.

Change-Id: I930b64bf7c0a8c84b9ea3edb49adc813370fed0e
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoRevert hacks in text rendering code path
Eskil Abrahamsen Blomfeldt [Tue, 23 Oct 2012 11:14:27 +0000 (13:14 +0200)]
Revert hacks in text rendering code path

There are a lot of hacks here and there in Qt trying to align the
text in a correct way which caused regressions to appear once
the default coordinate system changed. We need to remove these
hacks to get a more consistent and maintainable base. This also
fixes the regression introduced by changing the aliased coordinate

Task-number: QTBUG-27667

Change-Id: I620db2ca23b7ff6c912f3a51e86e7e36bbef81f0
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agotest: Don't fail if the network test server is not set up
Sergio Ahumada [Mon, 22 Oct 2012 10:17:48 +0000 (12:17 +0200)]
test: Don't fail if the network test server is not set up

Not having access to a network test server is not a failure per se
but rather an enviromental condition not met at run-time.

Change-Id: Ie7d10ca5fbf2df45fb1fd1ac19718c9fae855c03
Reviewed-by: Caroline Chao <caroline.chao@digia.com>
5 years agoQSslSocket: Allow disconnections within the connected() signal
Jocelyn Turcotte [Tue, 16 Oct 2012 16:25:01 +0000 (18:25 +0200)]
QSslSocket: Allow disconnections within the connected() signal

When doing happy eyeballs style network state lookup, we might have to
close an SSL socket from its connected signal. This can cause the warning:
QSslSocket::startClientEncryption: cannot start handshake when not connected

The signal should be emitted after we called startClientEncryption to
avoid this warning. In that case it will initialize the encryption
and ramp it down right after.

Change-Id: I0c8c79cad7f91f0088b87c5e4ee8aafbc688411c
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
5 years agoFix incorrect library path in libEGL.pro.
Jason Barron [Wed, 24 Oct 2012 12:00:32 +0000 (14:00 +0200)]
Fix incorrect library path in libEGL.pro.

Should not use the QT_INSTALL* variables here since it won't
work if we configure with a prefix.

Change-Id: I03ac170cb11262c38928f2a0d95e6f243d6d665b
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@digia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoFixed crash on destruction of animating QDockWidget in a QMainWindow
Rohan McGovern [Mon, 22 Oct 2012 04:19:24 +0000 (14:19 +1000)]
Fixed crash on destruction of animating QDockWidget in a QMainWindow

It doesn't make sense to hold an unguarded pointer to a
QPropertyAnimation while assigning ownership of that animation to the
animated widget.

Destruction of the widget while the animation is in progress causes
the animation pointer to become dangling; then the widget is removed
from the containing QMainWindowLayout, which attempts to abort the
animation, dereferencing the invalid pointer.

The crash can be reproduced sometimes with
tst_QDockWidget::taskQTBUG_2940_resizeAfterUndocking (which is in
Qt4 only).

Change-Id: I758bf7193b2ea39cd4d8e87197d8ff957d3368eb
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
5 years agoFix widget borders when using global stylesheetstyle
Miikka Heikkinen [Tue, 23 Oct 2012 08:50:13 +0000 (11:50 +0300)]
Fix widget borders when using global stylesheetstyle

Recent fixes to stylesheetstyle caused not calling fixupBorder()
when globalStyleSheetStyle is used.

Task-number: QTBUG-27651
Change-Id: I73263c951e2db7d574e81da3f60a1b79f3852716
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
5 years agofix flakiness of tst_qlocalsocket::processConnection
Joerg Bornemann [Wed, 24 Oct 2012 09:28:57 +0000 (11:28 +0200)]
fix flakiness of tst_qlocalsocket::processConnection

QSystemSemaphore is persistent after a crash and we'd have to toggle the
Open/Create flag. Waiting for the server being available by trying to
connect is much more reliable.

Change-Id: I510814cef189b43658911f8ade3cf831ae6c7e58
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoAdd DnD support for QNX.
Sergio Martins [Tue, 9 Oct 2012 12:00:07 +0000 (13:00 +0100)]
Add DnD support for QNX.

We only need DnD within the same application for now, so returning
a QSimpleDrag is enough.

Change-Id: I842d48f0252f8103fa8632dd3d149ae431658adb
Reviewed-by: Thomas McGuire <thomas.mcguire@kdab.com>
Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com>
Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
5 years agoAdd ContextMenu event to QWindowSystemInterface
Miikka Heikkinen [Mon, 22 Oct 2012 11:43:38 +0000 (14:43 +0300)]
Add ContextMenu event to QWindowSystemInterface

Context menu key wasn't working, as QPA had no handling for it.
Added ContextMenu event to QWindowSystemInterface and proper handling
to QGuiApplication and QWidgetWindow.

Also provide Windows implementation.

Task-number: QTBUG-27648
Change-Id: I7ce71ec4b5cdcc7be758e67f9faf6d863f7b19be
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoUpdate QDataStream format docs for gui/math3d classes
Sean Harmer [Tue, 23 Oct 2012 18:17:25 +0000 (19:17 +0100)]
Update QDataStream format docs for gui/math3d classes

Change-Id: I158d1bc5414f273320f0561000e69c3e06f6ac5a
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>
Reviewed-by: Jerome Pasion <jerome.pasion@digia.com>
5 years agoUnmark tst_qgroupbox as a parallel test
Rohan McGovern [Tue, 23 Oct 2012 04:43:25 +0000 (14:43 +1000)]
Unmark tst_qgroupbox as a parallel test

Judging from recent failures in the call to QTest::qWaitForWindowActive
in this test, the test may not be parallel-safe as previously thought.

Change-Id: I0a05eafd9086207ea3fc73f611bf834b657d5b8a
Reviewed-by: Toby Tomkins <tjtomkins@gmail.com>
5 years agoAdd ANGLE as a 3rdparty library to Qt.
Jason Barron [Mon, 15 Oct 2012 12:16:51 +0000 (14:16 +0200)]
Add ANGLE as a 3rdparty library to Qt.

ANGLE is a component that implements the OpenGL ES 2.0 API on
top of DirectX 9. See the following for more info:


ANGLE is now the default configuration on Windows. If you
want to use desktop OpenGL, you should build Qt with the
following configure options:

    -opengl desktop

To configure Qt to use another OpenGL ES 2 implementation,
you should use:

    -opengl es2 -no-angle

Task-number: QTBUG-24207

Change-Id: Iefcbeaa37ed920f431729749ab8333b248fe5134
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoQuieten warning about uninitialized use of d pointer
Tobias Hunger [Tue, 23 Oct 2012 15:14:06 +0000 (17:14 +0200)]
Quieten warning about uninitialized use of d pointer

We had this issue in Qt 4 before: Clang considers the use of d uninitialized
in the initializer list for d. This might or might not be legal, the clang
devs are divided on that topic. Let's just use a more common form and ignore
the issue language lawyers.

Change-Id: I3324255963a6d0f4a9057fe0d1d9ae868d3efef7
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
5 years agomention slotification of select()/selectRow() in changes
Mark Brand [Sat, 13 Oct 2012 18:52:36 +0000 (20:52 +0200)]
mention slotification of select()/selectRow() in changes

This change does not affect source code compatibility. Therefore
it is mentioned in the general section.

Change-Id: I81ea30d18b01de69322d9527d0c2775b37d1d196
Reviewed-by: David Faure <david.faure@kdab.com>
5 years agoMac: Set minimum version to 10.7 for clang-libc++
Morten Johan Sorvig [Fri, 12 Oct 2012 09:31:08 +0000 (11:31 +0200)]
Mac: Set minimum version to 10.7 for clang-libc++

Clang's libc++ does not support 10.6.

Add mac-minimum-version.conf which sets the version
to 10.6. Set the version to 10.7 in the clang-libx++*

Change-Id: I494d0d24b0d73d9395e9d5406c8c63c9af87f8cc
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
5 years agotest: Remove QSKIP from tst_QSettings::fileName()
Sergio Ahumada [Sun, 21 Oct 2012 21:26:44 +0000 (23:26 +0200)]
test: Remove QSKIP from tst_QSettings::fileName()

Change-Id: I24ed2d182faff989f62f192246ebf95ca492c10d
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
5 years agotest: Remove QSKIP from tst_QClipboard::copy_exit_paste()
Sergio Ahumada [Sun, 21 Oct 2012 22:12:14 +0000 (00:12 +0200)]
test: Remove QSKIP from tst_QClipboard::copy_exit_paste()

Change-Id: Ib64680dbd966940c56ab089ff1b7727b237fdaee
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
5 years agotest: Rename test case name TestQtJson -> tst_QtJson
Sergio Ahumada [Mon, 22 Oct 2012 10:39:02 +0000 (12:39 +0200)]
test: Rename test case name TestQtJson -> tst_QtJson

This allows us to follow test naming convention which should start
with "tst_"



Change-Id: Id83ccc324776399184c3665565eb8d045bfee2e2
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
5 years agotest: Fix tst_QDir.equalityOperator()
Sergio Ahumada [Mon, 22 Oct 2012 12:08:01 +0000 (14:08 +0200)]
test: Fix tst_QDir.equalityOperator()

On Fedora 17 /sbin/ is a symlink now, so this test fails there.
Using /usr/ instead.

Change-Id: Ie35902fc093101191bdbf33324e20835d1da1528
Reviewed-by: Caroline Chao <caroline.chao@digia.com>
5 years agoReturn invalid datetime when calling addMSecs with invalid QDateTime.
Mitch Curtis [Wed, 17 Oct 2012 11:56:50 +0000 (13:56 +0200)]
Return invalid datetime when calling addMSecs with invalid QDateTime.

This is in line with what QTime::addMSecs and QDate::addDays do, for

Change-Id: I902112486727f74f669a97bde6c42028e0838f8d
Reviewed-by: Jon Severinsson <jon@severinsson.net>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
5 years agoImprove QTime test coverage.
Mitch Curtis [Tue, 16 Oct 2012 10:05:06 +0000 (12:05 +0200)]
Improve QTime test coverage.

Change-Id: If47de3dc047ac4f8a4a1498cf225e03bbbf4110e
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
Reviewed-by: Jon Severinsson <jon@severinsson.net>
5 years agoImprove QDate test coverage.
Mitch Curtis [Mon, 15 Oct 2012 16:22:45 +0000 (18:22 +0200)]
Improve QDate test coverage.

Some statements could not be tested, such as default cases of switches
where all possible cases are already handled and some statements where
the system locale is used.

I also removed some statements that would never be reached and hence
will never be able to be covered by tests.

Change-Id: I8ea3071f66d942d986e65708732af6751d36b5e3
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
5 years agoClarify assert on use of const char* as TestData type in tests.
Mitch Curtis [Fri, 28 Sep 2012 14:23:09 +0000 (16:23 +0200)]
Clarify assert on use of const char* as TestData type in tests.

Currently all C-style strings used as data types in QTest::addColumn
will assert at runtime with, e.g.: "expected data of type
'const char*', got 'QString' for element 0 of data with tab 'blah'".
This patch makes it clear that C-style strings are disallowed.

Change-Id: Iadbb8f10e16607de95c7adb43d9ff3310aac6738
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
5 years agoOutput leading zeroes for yyyy date formats in QLocale::toString().
Mitch Curtis [Fri, 21 Sep 2012 09:30:55 +0000 (11:30 +0200)]
Output leading zeroes for yyyy date formats in QLocale::toString().

Converting the date 1 January 0001 to a string in the format
"dd MMMM yyyy" currently results in the string "01 January 1", but it
should be "01 January 0001".

Task-number: QTBUG-27287
Change-Id: Ia025da7343d1c36aaee34c47c6db551a6e89595f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
5 years agoFix valgrind warning in QTriangulatingStroker.
Friedemann Kleint [Tue, 23 Oct 2012 15:25:48 +0000 (17:25 +0200)]
Fix valgrind warning in QTriangulatingStroker.

Initialize all member variables including m_invScale, which
was uninitialized.

Change-Id: Id581b1db9411b2f945281e17b7a0407c746761f8
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoAdd QStyleAnimation::updateTarget()
J-P Nurmi [Mon, 22 Oct 2012 17:15:14 +0000 (19:15 +0200)]
Add QStyleAnimation::updateTarget()

For example a paused "default button" animation might want to update
the target to get "non-default button" looks meanwhile the animation
is paused.

Change-Id: Ibb854a40f38a8971e7233b1f34a83056e6a9d827
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoEnable HiDPI mode for retina displays.
Morten Sorvig [Wed, 15 Aug 2012 11:36:05 +0000 (13:36 +0200)]
Enable HiDPI mode for retina displays.

Change-Id: I3b62ec9c3bf5e53c6ec056b95c52cfeb6ce5b61f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
5 years agoFix warning about missing return value in XCB native interface.
Friedemann Kleint [Mon, 22 Oct 2012 14:08:44 +0000 (16:08 +0200)]
Fix warning about missing return value in XCB native interface.

Change-Id: If311211076c05ed8d0fb62a9ff1129b93a813850
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
5 years agoQProcess: Include program in destructor warning.
Friedemann Kleint [Tue, 23 Oct 2012 08:11:54 +0000 (10:11 +0200)]
QProcess: Include program in destructor warning.

Change-Id: Ib6870d2b161197fdeab7fe5140ac4757c79f478e
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
5 years agoStabilize tst_qfontdialog test case.
Miikka Heikkinen [Mon, 22 Oct 2012 12:03:06 +0000 (15:03 +0300)]
Stabilize tst_qfontdialog test case.

The delayed quit signal used as failsafe to ensure exit from event
loops interfere with later test if the test case works normally,
as closing the last toplevel window will also exit the event loop.

Fixed by stopping the quit timer if nested application exec loop
is exited.

Change-Id: If87655f1f28f50e27a64f3430c9f65bb3ab7dd70
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
5 years agoQStyleAnimation: fix threaded rendering
J-P Nurmi [Tue, 23 Oct 2012 08:53:40 +0000 (10:53 +0200)]
QStyleAnimation: fix threaded rendering

Change-Id: I00875adf2e4b157a3f8b0b99e5280b1275635026
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoBlackberry: Fix applicationFilePath() for unpackaged executables
Thomas McGuire [Wed, 17 Oct 2012 08:45:43 +0000 (10:45 +0200)]
Blackberry: Fix applicationFilePath() for unpackaged executables

Not all executables originate from a BAR package, for example unit
Make those use the fallback code for finding the application file path.

Change-Id: I5603f329bbe74e37d319ddd190f72bc6f64e1a5c
Reviewed-by: Fabian Bumberger <fbumberger@rim.com>
Reviewed-by: Kevin Krammer <kevin.krammer@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
5 years agoFix QRegExpValidator::validate docs about the pos parameter
Giuseppe D'Angelo [Sun, 14 Oct 2012 03:12:35 +0000 (04:12 +0100)]
Fix QRegExpValidator::validate docs about the pos parameter

The code sets it to input.length() iff the regexp doesn't
match the string, while the docs say it's *always* set.

Therefore, make the docs match what the code does and
add a simple test to enforce it.

We're not changing the code to match the docs because

1) it's better to stay conservative (we don't want
to break existing behaviour);

2) this behaviour mimics what the int/double validators do
(they don't move pos at all).

Change-Id: I958074558de6b0fc5944101c6535fc7e00442ae9
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoCMake: Make qt5_use_modules a macro, not a function.
Stephen Kelly [Mon, 22 Oct 2012 07:32:24 +0000 (09:32 +0200)]
CMake: Make qt5_use_modules a macro, not a function.

Because qt5_use_modules is a function that does a find package which
finds imported targets, things like this:

 qt5_use_modules(foo Sql)
 if (TARGET Qt5::Sql)
    message("Qt5Sql_FOUND: ${Qt5Sql_FOUND}")

will show Qt5Sql as being not found, even though the target is in scope.

Fix that by making it a macro instead.

Change-Id: If314bd5b4d3f769c6c7df5ff2c924eabd16dcc0e
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoFix mistakes in QNetworkAccessManager docs.
Mitch Curtis [Thu, 11 Oct 2012 13:24:11 +0000 (15:24 +0200)]
Fix mistakes in QNetworkAccessManager docs.

Change-Id: I2c797affec9472815003b1a032196c81088e1df6
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoqpa: Fix drawPixmap rendering using CompositionMode_Source in DirectFB
Julien Brianceau [Fri, 19 Oct 2012 09:35:43 +0000 (11:35 +0200)]
qpa: Fix drawPixmap rendering using CompositionMode_Source in DirectFB

Change-Id: I646bc7054e1aa17dca4f54ddd3d2668c173773d4
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
Reviewed-by: Jørgen Lind <jorgen.lind@gmail.com>
5 years agoRemove softkey API, it was only implemented for Symbian.
Jan Arve Saether [Mon, 22 Oct 2012 13:09:43 +0000 (15:09 +0200)]
Remove softkey API, it was only implemented for Symbian.

It is only removed from the documentation for now (I think this should
go in the beta 2).
That should liberate us to be able to change the API if needed for
other platforms that might need a soft keys API.

Once this goes in, the plan is to do the actual cleanup.

Change-Id: I9a7a3eb45597cd013fe3c4bd479ad08a25ef0b9b
Reviewed-by: Janne Anttila <janne.anttila@digia.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
5 years agoconfigure: make sure that global shadow doc symlink is always updated
Tor Arne Vestbø [Fri, 19 Oct 2012 09:04:01 +0000 (11:04 +0200)]
configure: make sure that global shadow doc symlink is always updated

We forcibly overwrite the symlink - in case the source dir changes.

Change-Id: I3986b968f787ea0d250887113a0c223e10038546
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
5 years agoRemove Cleanlooks and Plastique
Jens Bache-Wiig [Thu, 18 Oct 2012 13:22:15 +0000 (15:22 +0200)]
Remove Cleanlooks and Plastique

We have a new style Fusion that will replace these styles.
They will be moved to a separate
module rather than included in platforms that do not need them.

Change-Id: I51ebbcad5406e99130e5b12e62ba624d1489088c
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
5 years agoFix clipping and font problems with groupbox in Fusion style
Jens Bache-Wiig [Sun, 21 Oct 2012 10:07:13 +0000 (12:07 +0200)]
Fix clipping and font problems with groupbox in Fusion style

The groupbox did not take custom fonts into account when calculating
the height of its titlebar. This resulted in clipping issues on

Task-number: QTBUG-27655

Change-Id: I7252bc94d2bbb0731b9dbc1caa6cdd2074fdd7ab
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoMake QPen default to 1-width non-cosmetic.
Samuel Rødal [Mon, 15 Oct 2012 15:06:34 +0000 (17:06 +0200)]
Make QPen default to 1-width non-cosmetic.

Use the Qt4CompatiblePainting render hint when painting with QPainter to
treat default constructed QPens as cosmetic still.

The NonCosmeticDefaultPen render hint gets documented as obsolete, since
it was in any case not respected by the raster nor OpenGL paint engine.

Change-Id: I04d910e9700baf7f13a8aac07a3633014bb9283e
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoMove some icon code from WindowsStyle to CommonStyle
Jens Bache-Wiig [Mon, 22 Oct 2012 10:32:25 +0000 (12:32 +0200)]
Move some icon code from WindowsStyle to CommonStyle

Fusion style only depends on CommonStyle and it seems the autotest
for tst_QFileSystemModel:iconProvider assumes an icon will be
returned from standardPixmap. Since we dont want the icons
to depend on style in this case we should move all this to commonstyle.

Change-Id: I3a26367e5c0aefe2a39838f0c2cadc4f7afad89d
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
5 years agoDelete QWhatsThis() and QToolTip()
Marc Mutz [Mon, 22 Oct 2012 06:20:23 +0000 (08:20 +0200)]
Delete QWhatsThis() and QToolTip()

These classes are not supposed to be instantiated.

QToolTip() already was declared, but not implemented.
This patch just adds Q_DECL_EQ_DELETE for better
diagnostics on C++11.

QWhatsThis() was implemented, but appears to be unused.
Since it was private to begin with, successfully compiling
QtWidgets is a sufficient test.

Change-Id: I698ece8f0eebbcdac7be98456dd42197b758a825
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoQDateTimeEdit: don't throw off auto-indention
Marc Mutz [Mon, 22 Oct 2012 06:32:50 +0000 (08:32 +0200)]
QDateTimeEdit: don't throw off auto-indention

Reformulate #ifdef'ery involving {}s so as not to throw
off auto-indention of code editors due to unbalanced {}s.

Change-Id: I0f9858c78d0b6d923de75ca45c7d65ce3fa53e50
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoTrim trailing whitespace.
Stephen Kelly [Mon, 22 Oct 2012 09:00:00 +0000 (11:00 +0200)]
Trim trailing whitespace.

Change-Id: Iee6bb66831f53399e5937eab5704af835979f5c3
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
5 years agoFix integer overflow in QSpinBox.
Stephen Kelly [Thu, 18 Oct 2012 11:36:02 +0000 (13:36 +0200)]
Fix integer overflow in QSpinBox.

Change-Id: Ic204d42fbdffc44576f7e76132bc53621e836299
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoUse the layout change hint to speed up QItemSelectionModel.
Stephen Kelly [Thu, 27 Sep 2012 09:36:23 +0000 (11:36 +0200)]
Use the layout change hint to speed up QItemSelectionModel.

The testcase in the bug report takes 370035 ms to sort the rows with
Qt 4, and 5646 ms in Qt 5 (when using the extra hints to layout*Changed).

That's an improvement of more than 98%.

Task-number: QTBUG-17732
Change-Id: If78f972d80c501e0cb39078228086c4f4ac8a65b
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoPass the correct handle to the Windows EGL context constructor.
Jason Barron [Sun, 21 Oct 2012 18:29:11 +0000 (20:29 +0200)]
Pass the correct handle to the Windows EGL context constructor.

We should pass the shareHandle here instead of the handle for the
context since that's what it expects.

Change-Id: If851758817057ecc3c3646cba2354becf5a8a839
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
5 years agoDoc: Fix small capitalization error for the Qt SQL module header.
Sze Howe Koh [Sat, 20 Oct 2012 16:17:09 +0000 (00:17 +0800)]
Doc: Fix small capitalization error for the Qt SQL module header.

The header file is named QtSql, not QtSQL.

Change-Id: Ia3634c80d73f04fd27256f392cfed2068eeb9bc5
Reviewed-by: Mark Brand <mabrand@mabrand.nl>
5 years agoEmit cursorPositionChanged in private slot.
Frederik Gladhorn [Fri, 12 Oct 2012 16:42:21 +0000 (18:42 +0200)]
Emit cursorPositionChanged in private slot.

Since the private slot is already there and used, it might as well
emit the signal and save us one connection.

Change-Id: I899df74c20f8c2b7875a0f9d0a04465c5dc48bde
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoBring back accessibility for plain text edit.
Frederik Gladhorn [Fri, 12 Oct 2012 13:00:23 +0000 (15:00 +0200)]
Bring back accessibility for plain text edit.

This ports 282951bc6c7ddb607fb7ebf61eb8de9acf3da77f
aka Change-Id: If0269a49b9fcd1b3e9fcfd32fac912560df28f21
to Qt 5.

Change-Id: I46f1d4947d90688b598993f76330e2e10aeca950
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Jan Arve Sæther <jan-arve.saether@digia.com>
5 years agonormalise signal/slot signatures [QtGui tests]
Marc Mutz [Tue, 16 Oct 2012 09:02:34 +0000 (11:02 +0200)]
normalise signal/slot signatures [QtGui tests]

Change-Id: I42e11de9ef1d8a04b2a8e200afb84f2245f3361a
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoFix crash due to memory access violation
Konstantin Ritt [Sat, 20 Oct 2012 00:19:20 +0000 (03:19 +0300)]
Fix crash due to memory access violation

The font engine has been re-used without increasing it's reference counter

Task-number: QTBUG-27596
Change-Id: Icd4c3ca131446255ad4a27da8aa9a6c69177212e
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
5 years agoRevert removal of commented out tests in tst_qdatetime.cpp.
Mitch Curtis [Thu, 20 Sep 2012 14:01:04 +0000 (16:01 +0200)]
Revert removal of commented out tests in tst_qdatetime.cpp.

Two lines were commented out but were removed with
Ib6ceb1cb7fb4c6eca672495f96d9cfd907853c85. They have been replaced
as expected fails.

Task-number: QTBUG-22833
Change-Id: Ib154a31bffcdc8e43c6ad236df193e99334652c6
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
5 years agonormalise signal/slot signatures [QtCore tests]
Marc Mutz [Tue, 16 Oct 2012 08:59:53 +0000 (10:59 +0200)]
normalise signal/slot signatures [QtCore tests]

Normalise all signal/slot signatures in tests/*/corelib,
except in tst_QObject, where they might be test data.

Change-Id: Id4e101f285b1676bb583b0afae06d235e599e24b
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
5 years agoDoc: refer to QUrlQuery in QUrl's main doc body
Thiago Macieira [Fri, 19 Oct 2012 03:58:50 +0000 (20:58 -0700)]
Doc: refer to QUrlQuery in QUrl's main doc body

As opposed to the deprecated methods.

Task-number: QTBUG-25628
Change-Id: Ic1b50b1ac1b974cdd2dd9f0151d567227784e547
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
5 years agoRemove the QThread::terminated() signal
Sze Howe Koh [Thu, 18 Oct 2012 16:33:03 +0000 (00:33 +0800)]
Remove the QThread::terminated() signal

The signal is removed from the API; all references to it are removed
from documentation; the unit test that checks for its emission is
modified to listen for QThread::finished() instead.

The QThreadPrivate::terminated flag is also removed, as it served no
purpose other than to trigger the emission of QThread::terminated()

As discussed at http://lists.qt-project.org/pipermail/development/2012-October/007216.html
the signal is not guaranteed to be emitted after every termination,
rendering it useless.

Change-Id: I7b0c45d7889da0d33875545331606f2208ee56fc
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
5 years agoRemove DRI2/OpenGL code paths from xcb plugin.
Samuel Rødal [Mon, 8 Oct 2012 10:53:56 +0000 (12:53 +0200)]
Remove DRI2/OpenGL code paths from xcb plugin.

These were used to test QtWayland, but there are other options available
for that now. The DRI2 code hasn't been maintained and doesn't even
compile at the moment, so let's just remove it to de-clutter the source.

Change-Id: I7db0f4db82348497b9f4d6c2dcf2e13f3ab14a76
Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
5 years agoSmall xcb startup performance optimization.
Samuel Rødal [Tue, 2 Oct 2012 07:30:18 +0000 (09:30 +0200)]
Small xcb startup performance optimization.

Prefetch all the extensions, to avoid having to do blocking calls later.

Change-Id: I1527dbf03d76372ec88bc0d5d9f7af18a4cc2a26
Reviewed-by: Lars Knoll <lars.knoll@digia.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
5 years agoMade xcb plugin work when the GLX extension is not present.
Samuel Rødal [Mon, 1 Oct 2012 08:17:21 +0000 (10:17 +0200)]
Made xcb plugin work when the GLX extension is not present.

Change-Id: I9285d7524586ff404206c088019ece33335137d9
Reviewed-by: Lars Knoll <lars.knoll@digia.com>