Qt Continuous Integration System [Wed, 21 Apr 2010 12:00:28 +0000 (14:00 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (28 commits)
QNAM: Add a code comment related to the cache
QtScript: regression with instanceof operator for QMetaObject wrappers
QNAM HTTP: Fixed a bug when getting empty files with pipelining
[tst_bic] Fix compilation in non-X11/Mac/Windows platforms
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
...
Markus Goetz [Wed, 21 Apr 2010 10:17:44 +0000 (12:17 +0200)]
QNAM: Add a code comment related to the cache
Qt Continuous Integration System [Wed, 21 Apr 2010 10:09:03 +0000 (12:09 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Fix window transparency on Symbian.
Tweak the 'normalGeometry' of the widget before setting it.
Use QDesktopWidget as a status pane observer on Symbian.
Delay creation of S60 screen furniture.
Don't use setGeometry() in setWindowState() on Symbian.
Modify setWindowState() on Symbian to create the native window earlier.
Kent Hansen [Tue, 20 Apr 2010 16:13:02 +0000 (18:13 +0200)]
QtScript: regression with instanceof operator for QMetaObject wrappers
Tell JavaScriptCore that QMetaObject wrappers can be used as the
second operand to instanceof; this is done by setting the
ImplementsHasInstance flag.
We don't actually have to implement hasInstance() because the
default implementation does the right thing.
Task-number: QTBUG-8366
Reviewed-by: Olivier Goffart
Markus Goetz [Wed, 21 Apr 2010 08:28:31 +0000 (10:28 +0200)]
QNAM HTTP: Fixed a bug when getting empty files with pipelining
Instead of returning from the socket's readyRead() handler
break out of the switch() and continue parsing the data.
Jason Barron [Tue, 20 Apr 2010 09:15:41 +0000 (11:15 +0200)]
Fix window transparency on Symbian.
In the create_sys() function where native handles are created, we were
only looking at the "isOpaque" flag to determine if a window should be
translucent or not. This is not the correct thing to do because
transparency should only be granted if the application explicitly sets
the Qt::WA_TranslucentBackground flag.
The fix is to defer the transparency decision to s60UpdateIsOpaque()
which does the right thing.
Reviewed-by: Jani Hautakangas
Jason Barron [Tue, 20 Apr 2010 08:27:49 +0000 (10:27 +0200)]
Tweak the 'normalGeometry' of the widget before setting it.
If a widget is initially shown as maximized or fullscreen then the
normal geometry is calculated before the status pane has been created.
When returning to the "Normal" window state the geometry needs to be
tweaked to compensate the fact that there is a status present now. This
should only happen if the application has not been given an explicit
position.
Reviewed-by: Janne Anttila
Jason Barron [Tue, 20 Apr 2010 08:09:00 +0000 (10:09 +0200)]
Use QDesktopWidget as a status pane observer on Symbian.
Now that the S60 screen furniture construction is delayed, we need to
manually set the status pane observer to get notifications about
changes in the size of the status pane. Using the AppUi would have been
the obvious choice here, but sadly CAknAppUi (base class for
QS60MainAppUi) uses private inheritance when implementing the
MEikStatusPaneObserver interface.
To work around this problem we make QSymbianControl implement the
interface and use the instance of this class that is associated with
QDesktopWidget to recevive the notifications and then call the function
in the AppUi to maintain the same behavior.
Reviewed-by: Janne Anttila
Reviewed-by: mread
Jason Barron [Tue, 20 Apr 2010 07:59:27 +0000 (09:59 +0200)]
Delay creation of S60 screen furniture.
Previously the S60 screen furniture (Status Pane and CBA) was being
constructed when QApplication was constructed. This meant that if you
never created a widget, you would still get those app panes which is
not what we want.
This patch avoids constructing these panes in QApplication, and manually
creates them later when the first window is shown in a state where they
would be needed.
Reviewed-by: Janne Anttila
Reviewed-by: mread
Jason Barron [Tue, 20 Apr 2010 07:35:27 +0000 (09:35 +0200)]
Don't use setGeometry() in setWindowState() on Symbian.
setGeometry() has the side effect that it internally sets both the
WA_Moved and WA_Resized attributes and these attributes should only be
used when the application has explicitly set a size or position. When
a widget is resized due to being maximized or fullscreened then we
should resize the native window handle instead of calling setGeometry.
Reviewed-by: Janne Anttila
Jason Barron [Tue, 20 Apr 2010 07:31:58 +0000 (09:31 +0200)]
Modify setWindowState() on Symbian to create the native window earlier.
The native window is used quite early in this function so as soon as we
determine that this does in fact require a native window, we should
create it immediately.
Reviewed-by: Janne Anttila
Thiago Macieira [Wed, 21 Apr 2010 07:20:54 +0000 (09:20 +0200)]
[tst_bic] Fix compilation in non-X11/Mac/Windows platforms
Qt Continuous Integration System [Wed, 21 Apr 2010 07:06:49 +0000 (09:06 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (24 commits)
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
[tst_bic] Collapse multiple empty newlines.
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
[tst_bic] Update the test to find newer versions of Qt after 4.3
...
Qt Continuous Integration System [Wed, 21 Apr 2010 04:52:38 +0000 (06:52 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging:
Compile on symbian:
Qt Continuous Integration System [Wed, 21 Apr 2010 03:34:35 +0000 (05:34 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (24 commits)
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
[tst_bic] Collapse multiple empty newlines.
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
[tst_bic] Update the test to find newer versions of Qt after 4.3
...
hawcroft [Wed, 21 Apr 2010 01:54:52 +0000 (11:54 +1000)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6
hawcroft [Wed, 21 Apr 2010 01:33:28 +0000 (11:33 +1000)]
Compile on symbian:
Symbian can't seem to handle defines declared in pro files
defined as string literals.
e.g DEFINES += FOO when FOO is then initialized as a
string literal e.g DEFINES += FOO="bar" fails be
included as a valid define during compilation.
Reviewed-by:TrustMe
Qt Continuous Integration System [Wed, 21 Apr 2010 01:35:15 +0000 (03:35 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging:
QAudioOutput always uses default output device
symbian: deploy 4.wav test file properly
Kurt Korbatits [Wed, 21 Apr 2010 00:56:33 +0000 (10:56 +1000)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6
Kurt Korbatits [Wed, 21 Apr 2010 00:55:10 +0000 (10:55 +1000)]
QAudioOutput always uses default output device
Task-number:QTBUG-9766
Reviewed-by:Derick Hawcroft
hawcroft [Wed, 21 Apr 2010 00:40:19 +0000 (10:40 +1000)]
symbian: deploy 4.wav test file properly
Reviewed-by: Kurt Korbatits
Qt Continuous Integration System [Tue, 20 Apr 2010 23:34:19 +0000 (01:34 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (24 commits)
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
[tst_bic] Collapse multiple empty newlines.
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
[tst_bic] Update the test to find newer versions of Qt after 4.3
...
Qt Continuous Integration System [Tue, 20 Apr 2010 21:36:40 +0000 (23:36 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging:
Fixed failure of tst_qbytearraymatcher on 64 bit.
Fixed DataTag missing from testlib XML in some cases.
Fixed "pass" incident missing from test xml in some cases
Reverted "qwarn" -> "qwarning" attribute change in XML test logs.
Fixed failure of tst_selftests::runSubTest(subtest xml)
Extend testlib selftest to cover all loggers, not just plain text.
Qt Continuous Integration System [Tue, 20 Apr 2010 19:41:49 +0000 (21:41 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (24 commits)
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
[tst_bic] Collapse multiple empty newlines.
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
[tst_bic] Update the test to find newer versions of Qt after 4.3
...
Qt Continuous Integration System [Tue, 20 Apr 2010 17:55:37 +0000 (19:55 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
QS60Style: Style draws a focus frame to context menus and popups
Context menu for application is differs from native S60 apps
Fix RTL text rendering in the QVGPaintEngine
QS60Style: Qt does not draw transparency correctly
Small doc changes to Symbian capabilites part
Qt Continuous Integration System [Tue, 20 Apr 2010 15:50:16 +0000 (17:50 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2:
No repaint when resizing graphics item with an effect.
Fix sqlite driver doesn't return error message RAISE by a trigger.
Qt Continuous Integration System [Tue, 20 Apr 2010 15:35:17 +0000 (17:35 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging:
Fixed failure of tst_qbytearraymatcher on 64 bit.
Fixed DataTag missing from testlib XML in some cases.
Fixed "pass" incident missing from test xml in some cases
Reverted "qwarn" -> "qwarning" attribute change in XML test logs.
Fixed failure of tst_selftests::runSubTest(subtest xml)
Extend testlib selftest to cover all loggers, not just plain text.
Sami Merila [Tue, 20 Apr 2010 13:28:46 +0000 (16:28 +0300)]
QS60Style: Style draws a focus frame to context menus and popups
Currently QS60Style draws a ficus frame around context menus and
combobox popups. This should be removed, as these widgets have
keypad navigable item highlight rect inside them AND
the widgets cannot be navigated in/out from other widgets.
Also, currently there is no room to draw the focus frame to left
and right border, so the focus frame looks somewhat strange
theme colored think line above and below popup/menu.
Task-number: QTBUG-10064
Reviewed-by: Alessandro Portale
Qt Continuous Integration System [Tue, 20 Apr 2010 13:08:25 +0000 (15:08 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1: (24 commits)
Fix accidental change in QtWebKit
QNAM HTTP: Pipelining improvement
fix qmake conditionals
QtScript: Add translation context test
Ensure we stop the name lookups in QAbstractSocket if we abort().
Don't rely on tryStart() to do job control.
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
[tst_bic] Add two more private classes to the blacklist
[tst_bic] Remove superfluous newline
[tst_bic] Fix gen.sh not to generate sequential empty lines
Fix QSslSocket::constructing autotest failure
Improve QScript{Engine,Value}::toObject() test coverage
[tst_bic] Add testing for Phonon too
[tst_bic] Cache the compilation results for a faster testing
[tst_bic] Blacklist all template expansions
[tst_bic] Add baseline for Qt 4.6.0
[tst_bic] Collapse multiple empty newlines.
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
[tst_bic] Update the test to find newer versions of Qt after 4.3
...
Markus Goetz [Tue, 20 Apr 2010 12:45:41 +0000 (14:45 +0200)]
Fix accidental change in QtWebKit
Reviewed-by: TrustMe
Markus Goetz [Tue, 20 Apr 2010 08:52:13 +0000 (10:52 +0200)]
QNAM HTTP: Pipelining improvement
Fail earlier. Use constant that was introduced in one of the previous
commits.
Reviewed-by: Peter Hartmann
Sami Merila [Tue, 20 Apr 2010 11:13:01 +0000 (14:13 +0300)]
Context menu for application is differs from native S60 apps
QMenu and QComboBoxListView differ somewhat from their native
equivalents. First, the font is not correct. It uses a default font,
when style should polish the widgets to use "AVKON primary" font.
Second, the background graphic is not the same as on native side.
Finally, and most importantly, menu items should be lot taller when
using touch enabled S60 UI.
Task-number: QT-3295
Reviewed-by: Janne Anttila
Bjørn Erik Nilsen [Tue, 20 Apr 2010 09:03:24 +0000 (11:03 +0200)]
No repaint when resizing graphics item with an effect.
Problem was that the item's cache was not invalidated from
prepareGeometryChange(). We did invalidate the cache for all the
ancestors, but not for the item itself. To avoid looping through the
whole parent chain twice, we invalidate the item's cache before
walking the parent chain. It would be nice to centralize the cache
invalidating mechanism, but for now it's OK to solve it like this.
Auto test included.
Task-number: QTBUG-9551
Reviewed-by: samuel
Oswald Buddenhagen [Mon, 19 Apr 2010 19:18:41 +0000 (21:18 +0200)]
fix qmake conditionals
Reviewed-by: maurice
Kent Hansen [Tue, 20 Apr 2010 08:42:52 +0000 (10:42 +0200)]
QtScript: Add translation context test
The context is determined from the filename passed to evaluate(),
and should be equivalent to QFileInfo(fileName).baseName().
Reviewed-by: Olivier Goffart
Thiago Macieira [Mon, 19 Apr 2010 19:43:03 +0000 (21:43 +0200)]
Ensure we stop the name lookups in QAbstractSocket if we abort().
If we're not even going to connect, there's no point in trying to get
the host resolution
Reviewed-By: Markus Goetz
Thiago Macieira [Mon, 19 Apr 2010 19:02:54 +0000 (21:02 +0200)]
Don't rely on tryStart() to do job control.
It may fail but threads become available the next instant. Instead,
simply use our own currentLookups count.
Reviewed-by: Markus Goetz
Bill King [Tue, 20 Apr 2010 02:07:22 +0000 (12:07 +1000)]
Fix sqlite driver doesn't return error message RAISE by a trigger.
Task-number: QTBUG-7988
Reviewed-by: Justin McPherson
Thiago Macieira [Mon, 19 Apr 2010 12:46:54 +0000 (14:46 +0200)]
[tst_bic] Suppress the warning about the QGraphicsProxyWidget BIC
Thiago Macieira [Mon, 19 Apr 2010 12:44:27 +0000 (14:44 +0200)]
[tst_bic] Add two more private classes to the blacklist
Thiago Macieira [Mon, 19 Apr 2010 12:43:08 +0000 (14:43 +0200)]
[tst_bic] Remove superfluous newline
Thiago Macieira [Mon, 19 Apr 2010 11:33:56 +0000 (13:33 +0200)]
[tst_bic] Fix gen.sh not to generate sequential empty lines
João Abecasis [Thu, 15 Apr 2010 17:02:34 +0000 (19:02 +0200)]
Fix QSslSocket::constructing autotest failure
The optimizations in
d0645d1792e1cbdf417a923ea071975e4390fccd did not
take into account 0-length reads, used in network programming to check
connected state.
By not returning early in the case where lastReadChunkSize == maxSize
and maxSize == 0, we allow the underlying device to report error
conditions on 0-length reads.
This reverts commit
aea71e2e02fa966842b094244bc3f5fc88f50f41, while
still ensuring that QIODevice::read() returns -1 on a closed device.
Reviewed-by: mread
Reviewed-by: Thiago Macieira
Kent Hansen [Mon, 19 Apr 2010 11:03:51 +0000 (13:03 +0200)]
Improve QScript{Engine,Value}::toObject() test coverage
Test that calling toObject() doesn't change the type of the
original value.
Thiago Macieira [Mon, 19 Apr 2010 10:35:35 +0000 (12:35 +0200)]
[tst_bic] Add testing for Phonon too
Thiago Macieira [Mon, 19 Apr 2010 10:33:53 +0000 (12:33 +0200)]
[tst_bic] Cache the compilation results for a faster testing
Thiago Macieira [Mon, 19 Apr 2010 10:32:35 +0000 (12:32 +0200)]
[tst_bic] Blacklist all template expansions
Thiago Macieira [Mon, 19 Apr 2010 10:31:53 +0000 (12:31 +0200)]
[tst_bic] Add baseline for Qt 4.6.0
Thiago Macieira [Mon, 19 Apr 2010 10:31:24 +0000 (12:31 +0200)]
[tst_bic] Collapse multiple empty newlines.
The test searches for '\n\n' so it requires a proper data set
Thiago Macieira [Mon, 19 Apr 2010 09:20:57 +0000 (11:20 +0200)]
[tst_bic] Remove the QtNetwork classes from the QtXmlPatterns description file
Thiago Macieira [Mon, 19 Apr 2010 09:11:56 +0000 (11:11 +0200)]
[tst_bic] Add the exception for the BIC breakage in QGraphicsProxyWidget in 4.5
Thiago Macieira [Mon, 19 Apr 2010 09:00:07 +0000 (11:00 +0200)]
[tst_bic] Update the test to find newer versions of Qt after 4.3
Thiago Macieira [Mon, 19 Apr 2010 08:59:05 +0000 (10:59 +0200)]
[tst_bic] Remove the QtXml dependencies from the QtDBus class listing
Thiago Macieira [Mon, 19 Apr 2010 08:51:10 +0000 (10:51 +0200)]
[tst_bic] Remove non-dot-zero release files from the data, they are not scanned
Thiago Macieira [Mon, 19 Apr 2010 08:49:37 +0000 (10:49 +0200)]
[tst_bic] Update gen.sh to match new libraries
Thiago Macieira [Mon, 19 Apr 2010 09:12:17 +0000 (11:12 +0200)]
Fix the include header <qstring.h> -> <QtCore/qstring.h>
Qt Continuous Integration System [Mon, 19 Apr 2010 10:25:03 +0000 (12:25 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Fix RTL text rendering in the QVGPaintEngine
QS60Style: Qt does not draw transparency correctly
Small doc changes to Symbian capabilites part
Qt Continuous Integration System [Mon, 19 Apr 2010 07:55:57 +0000 (09:55 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2:
QMenu: Behavior regression
Mac: Graphics View starving user events and sometimes crashes.
Fixed a crash on Windows 7 systems with invalid PrinterPorts entries.
Rohan McGovern [Mon, 19 Apr 2010 07:07:22 +0000 (17:07 +1000)]
Fixed failure of tst_qbytearraymatcher on 64 bit.
Code had `sizeof(needle-1)' where `sizeof(needle)-1' was meant.
This would pass where sizeof(char*) == 4, but not where
sizeof(char*) == 8.
Rohan McGovern [Fri, 16 Apr 2010 05:29:08 +0000 (15:29 +1000)]
Fixed DataTag missing from testlib XML in some cases.
Task-number: QTBUG-6320
Rohan McGovern [Fri, 16 Apr 2010 04:39:35 +0000 (14:39 +1000)]
Fixed "pass" incident missing from test xml in some cases
Task-number: QTBUG-6278
Rohan McGovern [Fri, 16 Apr 2010 03:58:57 +0000 (13:58 +1000)]
Reverted "qwarn" -> "qwarning" attribute change in XML test logs.
XML test logger message type changed from "qwarn" to "qwarning" for
warnings, apparently accidentally.
Rohan McGovern [Fri, 16 Apr 2010 03:54:48 +0000 (13:54 +1000)]
Fixed failure of tst_selftests::runSubTest(subtest xml)
Rohan McGovern [Fri, 16 Apr 2010 03:28:19 +0000 (13:28 +1000)]
Extend testlib selftest to cover all loggers, not just plain text.
Qt Continuous Integration System [Mon, 19 Apr 2010 06:12:48 +0000 (08:12 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-multimedia-staging:
Bug in QAudioOutput: Invalid use of "waveOutUnprepareHeader"
Qt Continuous Integration System [Mon, 19 Apr 2010 02:28:55 +0000 (04:28 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1:
Re-apply change
f14ae11e6731bd7416f45c3ef7ce464587862223 by Iain
Re-apply change
81837e43e3f966c1755e90eb65df6e3bad506ed7 by Iain
Updated WebKit from /home/shausman/src/webkit/trunk to qtwebkit/qtwebkit-4.6 (
6ed0b6197addffc7dacbdb3e49db711420a2c47a )
Kurt Korbatits [Mon, 19 Apr 2010 02:25:56 +0000 (12:25 +1000)]
Bug in QAudioOutput: Invalid use of "waveOutUnprepareHeader"
Fixed freeBlocks func in both input and output
Task-number:QTBUG-9875
Reviewed-by:Andrew den Exter
Iain [Thu, 15 Apr 2010 16:08:17 +0000 (18:08 +0200)]
Re-apply change
f14ae11e6731bd7416f45c3ef7ce464587862223 by Iain
Update WebKit DEF files on Symbian
Add/absent function with altered signature to BWINS DEF file.
Correct ordinal numbering in EABI DEF file, it was broken and causing
the build to fail.
Reviewed-by: TrustMe
Iain [Thu, 15 Apr 2010 14:41:58 +0000 (16:41 +0200)]
Re-apply change
81837e43e3f966c1755e90eb65df6e3bad506ed7 by Iain
Symbol visibility fixes for RVCT4 on Symbian
RVCT 4 is far more strict with regards to symbol visiblity that RVCT
2.2, and will hide symbols unless all references have default visibility
in the object files. Update the various places in Qt code where the
symbol visibility was set incorrectly for DLL-based platforms (those that
use __declspec(dllimport) and (dllexport).
Note: Other Qt modules and QtScript are fixed in different commits.
Task-number: QTBUG-9903
Reviewed-by: Jason Barron
Janne Koskinen
Simon Hausmann [Sat, 17 Apr 2010 00:07:02 +0000 (02:07 +0200)]
Updated WebKit from /home/shausman/src/webkit/trunk to qtwebkit/qtwebkit-4.6 (
6ed0b6197addffc7dacbdb3e49db711420a2c47a )
Changes in WebKit/qt since the last update:
++ b/WebKit/qt/ChangeLog
2010-04-08 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
https://bugs.webkit.org/show_bug.cgi?id=36674
The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.
I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.
* Api/qwebframe.cpp:
(qtwebkit_webframe_scrollRecursively):
2010-03-24 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
Auto-uppercase and predictive text need to be disabled for S60 (as for maemo)
https://bugs.webkit.org/show_bug.cgi?id=33176
* WebCoreSupport/EditorClientQt.cpp:
Gabriel de Dietrich [Fri, 16 Apr 2010 14:21:58 +0000 (16:21 +0200)]
QMenu: Behavior regression
When opening a submenu, and then moving the mouse over the parent menu
margins, the submenu would close, whereas it didn't in 4.5.
Reviewed-by: Olivier
Task-number: QTBUG-9785
Alessandro Portale [Fri, 16 Apr 2010 13:56:15 +0000 (15:56 +0200)]
Fix RTL text rendering in the QVGPaintEngine
The QVGPaintEngine calls vgDrawGlyphs() to draw the glyphs of a
QTextItem. vgDrawGlyphs(), which is an official OpenVG function, and
not implemented in Qt itself, expects glyphs coordinates differently
than Qt's glyph painting loops of other paint engines expect.
Therefore, we need to handle RTL text separately in
QVGPaintEngine::drawTextItem(). Rhys Weatherley provided this patch.
This issue is not Symbian specific, but rather QVGPaintEngine
specific.
Task-number: QT-3140
Reviewed-by: Rhys Weatherley
Sami Merila [Fri, 16 Apr 2010 12:41:26 +0000 (15:41 +0300)]
Merge branch '4.6' of git@scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6
Sami Merila [Fri, 16 Apr 2010 12:37:03 +0000 (15:37 +0300)]
QS60Style: Qt does not draw transparency correctly
This is due to default mask depth in QS60Style. It is currently set as
default EGray2 and then inquiried from S60SkinServer. For 3.1 devices,
skinserver does not explicitly set the mask depth (even though default
is 8bit mask), so no value is returned and default value is used.
This leads to a situation where style uses 2bit masks for 9 or 3 part
frame graphics.
Corrected by changing the default value to 8bit mask (EGray256).
Task-number: QTBUG-9927
Reviewed-by: Janne Anttila
Bjørn Erik Nilsen [Thu, 15 Apr 2010 16:06:33 +0000 (18:06 +0200)]
Mac: Graphics View starving user events and sometimes crashes.
Problem was that we called processEvents() and excluded user input
events. The idea was to only process pending update
requests, but by doing that there's also a chance that user input events
will starve. Also, there's no gurantee that only update requests
will be processed by processEvents(), so a safer solution is to call
"HIViewRender" on Carbon and "displayIfNeeded" on Cocoa. This will for
sure dispatch pending update requests and nothing else (which is exactly
what we want).
No auto test regressions.
Fixes tst_qgraphicsproxywidget::updateAndDelete failure on Carbon.
Benchmarks indicate an increase in performance.
Task-number: QTBUG-7502
Reviewed-by: richard
Trond Kjernaasen [Fri, 16 Apr 2010 11:10:51 +0000 (13:10 +0200)]
Fixed a crash on Windows 7 systems with invalid PrinterPorts entries.
Some Windows 7 systems appear to have invalid entries in the
PrinterPorts registry key. It's supposed to contain 3 entries, but
some return a single value.
Task-number: QTBUG-9938
Reviewed-by: Kim
Qt Continuous Integration System [Fri, 16 Apr 2010 10:10:13 +0000 (12:10 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Small doc changes to Symbian capabilites part
Espen Riskedal [Fri, 16 Apr 2010 09:54:08 +0000 (11:54 +0200)]
Small doc changes to Symbian capabilites part
Qt Continuous Integration System [Fri, 16 Apr 2010 01:09:43 +0000 (03:09 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1:
Doc
Aaron Kennedy [Fri, 16 Apr 2010 00:20:01 +0000 (10:20 +1000)]
Doc
Update QObject documentation to match the Qt's Property System
documentation.
Qt Continuous Integration System [Thu, 15 Apr 2010 23:13:00 +0000 (01:13 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1:
create magic comment messages in "finished" state
make QT_TR_NOOP work in static initializers
make HashString and HashStringList objects smaller
remove pointless manual assignments from token type enum
Qt Continuous Integration System [Thu, 15 Apr 2010 21:19:45 +0000 (23:19 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Update EABI and BWINS DEF files for Symbian
Update WebKit DEF files on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Oswald Buddenhagen [Thu, 15 Apr 2010 20:12:18 +0000 (22:12 +0200)]
create magic comment messages in "finished" state
there is really no point in marking them "unfinished". later file
rewrites would reset the state anyway.
Oswald Buddenhagen [Thu, 15 Apr 2010 19:48:28 +0000 (21:48 +0200)]
make QT_TR_NOOP work in static initializers
do that by ignoring all equal signs and everything between and
including brackets. this makes static initializers look
effectively like function definitions, thus creating proper
context.
Task-number: QTBUG-9276
Oswald Buddenhagen [Thu, 15 Apr 2010 19:12:34 +0000 (21:12 +0200)]
make HashString and HashStringList objects smaller
qHash(QString) has only 28 bits, so we can use the upper bits
for flagging whether the hash is valid.
size effect:
LP32: align(4, 4 + 4 + 1) = 12 vs. align(4, 4 + 4) = 8
LP64: align(8, 8 + 8 + 1) = 24 vs. align(8, 8 + 8) = 16
P64: align(8, 8 + 4 + 1) = 16 vs. align(8, 8 + 4) = 16
Oswald Buddenhagen [Thu, 15 Apr 2010 18:59:20 +0000 (20:59 +0200)]
remove pointless manual assignments from token type enum
making the range discontiguous just makes the switch()
jump table bigger or not applicable at all.
Qt Continuous Integration System [Thu, 15 Apr 2010 19:21:00 +0000 (21:21 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1:
Add translation context to qsTr() benchmark
QtScript: Add autotest for enumeration of QMetaObject properties
QNAM HTTP: Pipelining changes
Iain [Thu, 15 Apr 2010 18:01:34 +0000 (20:01 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6
Iain [Thu, 15 Apr 2010 18:00:52 +0000 (20:00 +0200)]
Update EABI and BWINS DEF files for Symbian
Reviewed-by: TrustMe
Qt Continuous Integration System [Thu, 15 Apr 2010 17:26:48 +0000 (19:26 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Iain [Thu, 15 Apr 2010 16:08:17 +0000 (18:08 +0200)]
Update WebKit DEF files on Symbian
Add/absent function with altered signature to BWINS DEF file.
Correct ordinal numbering in EABI DEF file, it was broken and causing
the build to fail.
Reviewed-by: TrustMe
Qt Continuous Integration System [Thu, 15 Apr 2010 15:35:00 +0000 (17:35 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2:
Fixes auto-test failure for
9da13ea53aec6d841ba7f416531d6c52d4368df4.
Fixes tooltips for QGraphicsProxyWidget.
Kent Hansen [Thu, 15 Apr 2010 15:22:27 +0000 (17:22 +0200)]
Add translation context to qsTr() benchmark
That's a more realistic case, since translations are usually
tied to a physical script.
Kent Hansen [Thu, 15 Apr 2010 15:13:50 +0000 (17:13 +0200)]
QtScript: Add autotest for enumeration of QMetaObject properties
The issue reported in QTBUG-3665 had been fixed since 4.6.0, but
it went unnoticed that there had been a bug in the first place
since there was no test for this behavior.
Qt Continuous Integration System [Thu, 15 Apr 2010 15:08:11 +0000 (17:08 +0200)]
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-1:
QNAM HTTP: Pipelining changes
Iain [Thu, 15 Apr 2010 14:41:58 +0000 (16:41 +0200)]
Symbol visibility fixes for RVCT4 on Symbian
RVCT 4 is far more strict with regards to symbol visiblity that RVCT
2.2, and will hide symbols unless all references have default visibility
in the object files. Update the various places in Qt code where the
symbol visibility was set incorrectly for DLL-based platforms (those that
use __declspec(dllimport) and (dllexport).
Note: Other Qt modules and QtScript are fixed in different commits.
Task-number: QTBUG-9903
Reviewed-by: Jason Barron
Janne Koskinen
Iain [Thu, 15 Apr 2010 14:38:02 +0000 (16:38 +0200)]
Symbol visibility fixes for RVCT4 on Symbian
RVCT 4 is far more strict with regards to symbol visiblity that RVCT
2.2, and will hide symbols unless all references have default visibility
in the object files. Update the various places in Qt code where the
symbol visibility was set incorrectly for DLL-based platforms (those that
use __declspec(dllimport) and (dllexport).
Note: QtWebkit and other Qt modules are fixed in different commits.
Task-number: QTBUG-9903
Reviewed-by: Jason Barron
Iain [Thu, 15 Apr 2010 14:19:50 +0000 (16:19 +0200)]
Symbol visibility fixes for RVCT4 on Symbian
RVCT 4 is far more strict with regards to symbol visiblity that RVCT
2.2, and will hide symbols unless all references have default visibility
in the object files. Update the various places in Qt code where the
symbol visibility was set incorrectly for DLL-based platforms (those that
use __declspec(dllimport) and (dllexport).
Note: QtWebkit and QtScript are fixed in different commits.
Task-number: QTBUG-9903
Reviewed-by: Jason Barron
Yoann Lopes [Thu, 15 Apr 2010 13:55:13 +0000 (15:55 +0200)]
Markus Goetz [Thu, 15 Apr 2010 11:54:30 +0000 (13:54 +0200)]
QNAM HTTP: Pipelining changes
Re-wrote some code to improve pipelining efficiency. Greatly helps
with combining into one TCP packet.
Task-number: QTBUG-9894
Task-number: QT-3280
Reviewed-by: Peter Hartmann